mbox series

[00/25] replace snprintf with strlcpy

Message ID 20230601150106.18375-1-stephen@networkplumber.org (mailing list archive)
Headers
Series replace snprintf with strlcpy |

Message

Stephen Hemminger June 1, 2023, 3 p.m. UTC 
  This patch series was generated by using the existing
Coccinelle script to find where snprintf() is used but
strlcpy() could be used instead.

Manually replaced fixed some trigraphs and paren's where
needed. Also one instance the whole temporary string
copy was not needed at all.

Stephen Hemminger (25):
  app: use strlcpy in tests
  examples: use strlcpy instead of snprintf
  lib: use strlcpy instead of snprintf
  raw/ifpga: replace snprintf with strlcpy
  common/cnxk: replace snprint with strlcpy
  common/mlx5: replace snprintf with strlcpy
  drivers/gpu: replace snprintf with strlcpy
  crypto/ipsec_mb: remove unnecessary snprintf
  crypto/dpaa_sec: replace snprintf with strlcpy
  event/cnxk: replace snprintf with strlcpy
  net/atlantic: replace snprintf with strlcpy
  net/axgbe: replace snprintf with strlcpy
  net/bnxt: replace snprintf with strlcpy
  net/cpfl: replace snprintf with strlcpy
  net/cxgbe: replace snprintf with strlcpy
  net/dpaa*: replace snprintf with strlcpy
  net/hinic: replace snptintf with strlcpy
  net/hns3: replace snprint with strlcpy
  net/intel: replace snprintf with strlcpy
  net/ionic: replace snprintf with strlcpy
  net/mlx5: replace snprintf with strlcpy
  net/nfp: replace snprintf with strlcpy
  net/ngbe: replace snprintf with strlcpy
  net/qede: replace snprintf with strlcpy
  net/txgbe: replace snprintf with strlcpy

 app/test-bbdev/main.c                         |  5 ++--
 app/test-pmd/cmdline_flow.c                   |  6 ++--
 app/test/process.h                            |  2 +-
 app/test/test_graph_perf.c                    | 29 ++++++++++---------
 drivers/common/cnxk/roc_nix_stats.c           |  4 +--
 drivers/common/mlx5/linux/mlx5_common_os.c    |  2 +-
 drivers/common/mlx5/mlx5_common_utils.c       |  5 ++--
 drivers/crypto/dpaa_sec/dpaa_sec.c            |  2 +-
 drivers/crypto/ipsec_mb/ipsec_mb_ops.c        |  7 +----
 drivers/event/cnxk/cnxk_eventdev_stats.c      | 11 ++++---
 drivers/gpu/cuda/cuda.c                       |  2 +-
 drivers/gpu/cuda/gdrcopy.c                    |  2 +-
 drivers/net/atlantic/atl_ethdev.c             |  5 ++--
 drivers/net/axgbe/axgbe_ethdev.c              |  6 ++--
 drivers/net/bnxt/bnxt_ethdev.c                |  8 ++---
 drivers/net/cpfl/cpfl_ethdev.c                |  6 ++--
 drivers/net/cxgbe/cxgbe_ethdev.c              |  9 +++---
 drivers/net/dpaa/dpaa_ethdev.c                |  8 ++---
 drivers/net/dpaa2/dpaa2_ethdev.c              |  8 ++---
 drivers/net/fm10k/fm10k_ethdev.c              |  6 ++--
 drivers/net/hinic/base/hinic_compat.h         |  1 +
 drivers/net/hinic/base/hinic_pmd_niccfg.c     |  4 +--
 drivers/net/hinic/hinic_pmd_ethdev.c          | 14 ++++-----
 drivers/net/hns3/hns3_fdir.c                  |  2 +-
 drivers/net/hns3/hns3_rxtx.c                  |  8 ++---
 drivers/net/hns3/hns3_stats.c                 | 22 +++++++-------
 drivers/net/i40e/i40e_rxtx.c                  |  8 ++---
 drivers/net/iavf/iavf_ethdev.c                |  6 ++--
 drivers/net/ice/ice_dcf_ethdev.c              |  6 ++--
 drivers/net/ice/ice_rxtx.c                    |  8 ++---
 drivers/net/idpf/idpf_ethdev.c                |  6 ++--
 drivers/net/ionic/ionic_ethdev.c              | 15 +++++-----
 drivers/net/ipn3ke/ipn3ke_representor.c       | 17 +++++------
 drivers/net/mlx5/mlx5_rx.c                    | 16 +++++-----
 .../net/nfp/flower/nfp_flower_representor.c   |  4 +--
 drivers/net/ngbe/ngbe_rxtx.c                  |  8 ++---
 drivers/net/qede/qede_ethdev.c                | 10 +++----
 drivers/net/txgbe/txgbe_ethdev_vf.c           |  6 ++--
 drivers/raw/ifpga/afu_pmd_core.c              |  3 +-
 examples/fips_validation/fips_validation.c    |  8 ++---
 examples/l3fwd-graph/main.c                   |  2 +-
 examples/pipeline/cli.c                       |  2 +-
 examples/vhost_blk/vhost_blk.c                |  5 ++--
 lib/bbdev/rte_bbdev.c                         |  2 +-
 lib/ethdev/sff_8636.c                         | 11 ++++---
 45 files changed, 157 insertions(+), 170 deletions(-)

Comments

Tyler Retzlaff June 2, 2023, 8:01 p.m. UTC | #1 
On Thu, Jun 01, 2023 at 08:00:41AM -0700, Stephen Hemminger wrote:
> This patch series was generated by using the existing
> Coccinelle script to find where snprintf() is used but
> strlcpy() could be used instead.

i guess the motivation here is strlcpy is safer to use than the portable
snprintf? not objecting, just confirming.

> 
> Manually replaced fixed some trigraphs and paren's where
> needed. Also one instance the whole temporary string
> copy was not needed at all.
> 
> Stephen Hemminger (25):
>   app: use strlcpy in tests
>   examples: use strlcpy instead of snprintf
>   lib: use strlcpy instead of snprintf
>   raw/ifpga: replace snprintf with strlcpy
>   common/cnxk: replace snprint with strlcpy
>   common/mlx5: replace snprintf with strlcpy
>   drivers/gpu: replace snprintf with strlcpy
>   crypto/ipsec_mb: remove unnecessary snprintf
>   crypto/dpaa_sec: replace snprintf with strlcpy
>   event/cnxk: replace snprintf with strlcpy
>   net/atlantic: replace snprintf with strlcpy
>   net/axgbe: replace snprintf with strlcpy
>   net/bnxt: replace snprintf with strlcpy
>   net/cpfl: replace snprintf with strlcpy
>   net/cxgbe: replace snprintf with strlcpy
>   net/dpaa*: replace snprintf with strlcpy
>   net/hinic: replace snptintf with strlcpy
>   net/hns3: replace snprint with strlcpy
>   net/intel: replace snprintf with strlcpy
>   net/ionic: replace snprintf with strlcpy
>   net/mlx5: replace snprintf with strlcpy
>   net/nfp: replace snprintf with strlcpy
>   net/ngbe: replace snprintf with strlcpy
>   net/qede: replace snprintf with strlcpy
>   net/txgbe: replace snprintf with strlcpy
> 
>  app/test-bbdev/main.c                         |  5 ++--
>  app/test-pmd/cmdline_flow.c                   |  6 ++--
>  app/test/process.h                            |  2 +-
>  app/test/test_graph_perf.c                    | 29 ++++++++++---------
>  drivers/common/cnxk/roc_nix_stats.c           |  4 +--
>  drivers/common/mlx5/linux/mlx5_common_os.c    |  2 +-
>  drivers/common/mlx5/mlx5_common_utils.c       |  5 ++--
>  drivers/crypto/dpaa_sec/dpaa_sec.c            |  2 +-
>  drivers/crypto/ipsec_mb/ipsec_mb_ops.c        |  7 +----
>  drivers/event/cnxk/cnxk_eventdev_stats.c      | 11 ++++---
>  drivers/gpu/cuda/cuda.c                       |  2 +-
>  drivers/gpu/cuda/gdrcopy.c                    |  2 +-
>  drivers/net/atlantic/atl_ethdev.c             |  5 ++--
>  drivers/net/axgbe/axgbe_ethdev.c              |  6 ++--
>  drivers/net/bnxt/bnxt_ethdev.c                |  8 ++---
>  drivers/net/cpfl/cpfl_ethdev.c                |  6 ++--
>  drivers/net/cxgbe/cxgbe_ethdev.c              |  9 +++---
>  drivers/net/dpaa/dpaa_ethdev.c                |  8 ++---
>  drivers/net/dpaa2/dpaa2_ethdev.c              |  8 ++---
>  drivers/net/fm10k/fm10k_ethdev.c              |  6 ++--
>  drivers/net/hinic/base/hinic_compat.h         |  1 +
>  drivers/net/hinic/base/hinic_pmd_niccfg.c     |  4 +--
>  drivers/net/hinic/hinic_pmd_ethdev.c          | 14 ++++-----
>  drivers/net/hns3/hns3_fdir.c                  |  2 +-
>  drivers/net/hns3/hns3_rxtx.c                  |  8 ++---
>  drivers/net/hns3/hns3_stats.c                 | 22 +++++++-------
>  drivers/net/i40e/i40e_rxtx.c                  |  8 ++---
>  drivers/net/iavf/iavf_ethdev.c                |  6 ++--
>  drivers/net/ice/ice_dcf_ethdev.c              |  6 ++--
>  drivers/net/ice/ice_rxtx.c                    |  8 ++---
>  drivers/net/idpf/idpf_ethdev.c                |  6 ++--
>  drivers/net/ionic/ionic_ethdev.c              | 15 +++++-----
>  drivers/net/ipn3ke/ipn3ke_representor.c       | 17 +++++------
>  drivers/net/mlx5/mlx5_rx.c                    | 16 +++++-----
>  .../net/nfp/flower/nfp_flower_representor.c   |  4 +--
>  drivers/net/ngbe/ngbe_rxtx.c                  |  8 ++---
>  drivers/net/qede/qede_ethdev.c                | 10 +++----
>  drivers/net/txgbe/txgbe_ethdev_vf.c           |  6 ++--
>  drivers/raw/ifpga/afu_pmd_core.c              |  3 +-
>  examples/fips_validation/fips_validation.c    |  8 ++---
>  examples/l3fwd-graph/main.c                   |  2 +-
>  examples/pipeline/cli.c                       |  2 +-
>  examples/vhost_blk/vhost_blk.c                |  5 ++--
>  lib/bbdev/rte_bbdev.c                         |  2 +-
>  lib/ethdev/sff_8636.c                         | 11 ++++---
>  45 files changed, 157 insertions(+), 170 deletions(-)
> 
> -- 
> 2.39.2