diff mbox series

[22/25] net/nfp: replace snprintf with strlcpy

Message ID	20230601150106.18375-23-stephen@networkplumber.org (mailing list archive)
State	Rejected, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Chaoyong He <chaoyong.he@corigine.com>, =?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com> Subject: [PATCH 22/25] net/nfp: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:03 -0700 Message-Id: <20230601150106.18375-23-stephen@networkplumber.org> In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace snprintf with strlcpy \| [00/25] replace snprintf with strlcpy [01/25] app: use strlcpy in tests [02/25] examples: use strlcpy instead of snprintf [03/25] lib: use strlcpy instead of snprintf [04/25] raw/ifpga: replace snprintf with strlcpy [05/25] common/cnxk: replace snprint with strlcpy [06/25] common/mlx5: replace snprintf with strlcpy [07/25] drivers/gpu: replace snprintf with strlcpy [08/25] crypto/ipsec_mb: remove unnecessary snprintf [09/25] crypto/dpaa_sec: replace snprintf with strlcpy [10/25] event/cnxk: replace snprintf with strlcpy [11/25] net/atlantic: replace snprintf with strlcpy [12/25] net/axgbe: replace snprintf with strlcpy [13/25] net/bnxt: replace snprintf with strlcpy [14/25] net/cpfl: replace snprintf with strlcpy [15/25] net/cxgbe: replace snprintf with strlcpy [16/25] net/dpaa*: replace snprintf with strlcpy [17/25] net/hinic: replace snptintf with strlcpy [18/25] net/hns3: replace snprint with strlcpy [19/25] net/intel: replace snprintf with strlcpy [20/25] net/ionic: replace snprintf with strlcpy [21/25] net/mlx5: replace snprintf with strlcpy [22/25] net/nfp: replace snprintf with strlcpy [23/25] net/ngbe: replace snprintf with strlcpy [24/25] net/qede: replace snprintf with strlcpy [25/25] net/txgbe: replace snprintf with strlcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger June 1, 2023, 3:01 p.m. UTC

  Suggested by devtools/cocci/strlcpy-with-header.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Niklas Söderlund June 5, 2023, 11:10 a.m. UTC | #1

Hi Stephen,

Thanks for your work.

On 2023-06-01 08:01:03 -0700, Stephen Hemminger wrote:
> Suggested by devtools/cocci/strlcpy-with-header.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

> ---
>  drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
> index 362c67f7b56d..09e0447d9268 100644
> --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> @@ -600,7 +600,7 @@ nfp_flower_pf_repr_init(struct rte_eth_dev *eth_dev,
>  	repr->repr_type        = init_repr_data->repr_type;
>  	repr->app_fw_flower    = init_repr_data->app_fw_flower;
>  
> -	snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
> +	strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
>  
>  	eth_dev->dev_ops = &nfp_flower_pf_repr_dev_ops;
>  	eth_dev->rx_pkt_burst = nfp_flower_pf_recv_pkts;
> @@ -671,7 +671,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
>  	repr->repr_type        = init_repr_data->repr_type;
>  	repr->app_fw_flower    = init_repr_data->app_fw_flower;
>  
> -	snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
> +	strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
>  
>  	eth_dev->dev_ops = &nfp_flower_repr_dev_ops;
>  	eth_dev->rx_pkt_burst = nfp_flower_repr_rx_burst;
> -- 
> 2.39.2
>

diff mbox series

Patch

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 362c67f7b56d..09e0447d9268 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -600,7 +600,7 @@  nfp_flower_pf_repr_init(struct rte_eth_dev *eth_dev,
 	repr->repr_type        = init_repr_data->repr_type;
 	repr->app_fw_flower    = init_repr_data->app_fw_flower;
 
-	snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+	strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
 
 	eth_dev->dev_ops = &nfp_flower_pf_repr_dev_ops;
 	eth_dev->rx_pkt_burst = nfp_flower_pf_recv_pkts;
@@ -671,7 +671,7 @@  nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
 	repr->repr_type        = init_repr_data->repr_type;
 	repr->app_fw_flower    = init_repr_data->app_fw_flower;
 
-	snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+	strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
 
 	eth_dev->dev_ops = &nfp_flower_repr_dev_ops;
 	eth_dev->rx_pkt_burst = nfp_flower_repr_rx_burst;