diff mbox series

[06/25] common/mlx5: replace snprintf with strlcpy

Message ID	20230601150106.18375-7-stephen@networkplumber.org (mailing list archive)
State	Rejected, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com> Subject: [PATCH 06/25] common/mlx5: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:47 -0700 Message-Id: <20230601150106.18375-7-stephen@networkplumber.org> In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace snprintf with strlcpy \| [00/25] replace snprintf with strlcpy [01/25] app: use strlcpy in tests [02/25] examples: use strlcpy instead of snprintf [03/25] lib: use strlcpy instead of snprintf [04/25] raw/ifpga: replace snprintf with strlcpy [05/25] common/cnxk: replace snprint with strlcpy [06/25] common/mlx5: replace snprintf with strlcpy [07/25] drivers/gpu: replace snprintf with strlcpy [08/25] crypto/ipsec_mb: remove unnecessary snprintf [09/25] crypto/dpaa_sec: replace snprintf with strlcpy [10/25] event/cnxk: replace snprintf with strlcpy [11/25] net/atlantic: replace snprintf with strlcpy [12/25] net/axgbe: replace snprintf with strlcpy [13/25] net/bnxt: replace snprintf with strlcpy [14/25] net/cpfl: replace snprintf with strlcpy [15/25] net/cxgbe: replace snprintf with strlcpy [16/25] net/dpaa*: replace snprintf with strlcpy [17/25] net/hinic: replace snptintf with strlcpy [18/25] net/hns3: replace snprint with strlcpy [19/25] net/intel: replace snprintf with strlcpy [20/25] net/ionic: replace snprintf with strlcpy [21/25] net/mlx5: replace snprintf with strlcpy [22/25] net/nfp: replace snprintf with strlcpy [23/25] net/ngbe: replace snprintf with strlcpy [24/25] net/qede: replace snprintf with strlcpy [25/25] net/txgbe: replace snprintf with strlcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger June 1, 2023, 3 p.m. UTC

  Suggested by devtools/cocci/strlcpy-with-header.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
 drivers/common/mlx5/mlx5_common_utils.c    | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c
index aafff60eeb38..c4ceeccf3825 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.c
+++ b/drivers/common/mlx5/linux/mlx5_common_os.c
@@ -897,7 +897,7 @@  mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len)
 		}
 	} while (strchr(ptr->d_name, '.') || strchr(ptr->d_name, '_') ||
 		 strchr(ptr->d_name, 'v'));
-	snprintf(cur_ifname, sizeof(cur_ifname), "%s", ptr->d_name);
+	strlcpy(cur_ifname, ptr->d_name, sizeof(cur_ifname));
 	closedir(dir);
 	snprintf(tmp + strlen(tmp), sizeof(tmp) - strlen(tmp),
 			"/%s/phys_switch_id", cur_ifname);
diff --git a/drivers/common/mlx5/mlx5_common_utils.c b/drivers/common/mlx5/mlx5_common_utils.c
index e69d06878c2e..3e809b409854 100644
--- a/drivers/common/mlx5/mlx5_common_utils.c
+++ b/drivers/common/mlx5/mlx5_common_utils.c
@@ -49,8 +49,7 @@  mlx5_list_create(const char *name, void *ctx, bool lcores_share,
 	if (!list)
 		return NULL;
 	if (name)
-		snprintf(list->l_const.name,
-			 sizeof(list->l_const.name), "%s", name);
+		strlcpy(list->l_const.name, name, sizeof(list->l_const.name));
 	list->l_const.ctx = ctx;
 	list->l_const.lcores_share = lcores_share;
 	list->l_const.cb_create = cb_create;
@@ -422,7 +421,7 @@  mlx5_hlist_create(const char *name, uint32_t size, bool direct_key,
 		return NULL;
 	}
 	if (name)
-		snprintf(h->l_const.name, sizeof(h->l_const.name), "%s", name);
+		strlcpy(h->l_const.name, name, sizeof(h->l_const.name));
 	h->l_const.ctx = ctx;
 	h->l_const.lcores_share = lcores_share;
 	h->l_const.cb_create = cb_create;