From patchwork Thu Jun 1 15:00:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127841 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DCF442C04; Thu, 1 Jun 2023 17:01:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAF7D42D20; Thu, 1 Jun 2023 17:01:15 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 6DDA442D17 for ; Thu, 1 Jun 2023 17:01:14 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1b00ecabdf2so8737985ad.2 for ; Thu, 01 Jun 2023 08:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631673; x=1688223673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5V4zO97PRtEsq4DvATu6DdzyIxNiLY8Nd1F9AOpOLO4=; b=g7toQa3ISlZVCbmJOGdHKTkNZ8/HXbWhn4uLU0yhbU+IrCt8+4h5ezxQPMusJZCUfR NupFFGWy50nh0pyhHY1IhgOkvjJ6jji9qNT48Lj4bQj7Zw1iWGf7NeADFssXzoN+/Cd/ Ko27YylHc0pNVIv28Q1h5CxjmEep+MhHQVchwfxOJhoAGjWl4OY4mI5l0qNoQPQCJSsC +rPH9QSTAcgNMN6eMQMJY+mixee9yFl+YN6MvtR0rAq75X+vdA5uZN82Id+iHsr+IFoh wCue/bjONC0wMwmbrBlp1wBP6wllj6uCGfa6NoUFS6SysSJva4WoEJk/q3r59igCA7hT 5j6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631673; x=1688223673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5V4zO97PRtEsq4DvATu6DdzyIxNiLY8Nd1F9AOpOLO4=; b=WRLUXq3qG5F627ieIh4336UU56LQ8ECSPP+fv0mH7umG4cCQmHZKSa+RyjqrGRkT8Q Vw2lf6mMsSXrCru0RUNzfq7zSqduQz3sncWVFUrDcxpR61IRgBKeB81vDMw89LWMZH6I kbgPLaO/5b/AtkP295ZyXwHGCG6Yuf6nyJ68OajmnwdZ/l858vKyQ3Tubf7ezgID1XmW gYmRWW2LZvD4O78GGP6shtt/S3zdnL0MuYH5SkzIYl+wVu2PVUpqjL2iGVgdWAbhGCR1 xsVJYNjtPFyjrkzaiaKhs1WjfHvy2kZrI0nhMxMH/kr98VwQDhAve/lxlbqq09g4aiFL 9n2Q== X-Gm-Message-State: AC+VfDyPxPvK6P6z1/nm2Orj3ek70SHRfKQOb2EVZpIi/b/t/ejeCGEa qx/8FKBqmkq6PT1l76WCqYL1RYlUZ/8UzVbzIdBzTw== X-Google-Smtp-Source: ACHHUZ6CDxJDanggNdDYs1+07D1z7baVcm78GKTZzedqECKTz8+IX6y54vEXj702FExGdZPZ022RrQ== X-Received: by 2002:a17:902:e849:b0:1ad:1c22:1b53 with SMTP id t9-20020a170902e84900b001ad1c221b53mr10280024plg.40.1685631673266; Thu, 01 Jun 2023 08:01:13 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:11 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru , Ori Kam , Aman Singh , Yuying Zhang , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram Subject: [PATCH 01/25] app: use strlcpy in tests Date: Thu, 1 Jun 2023 08:00:42 -0700 Message-Id: <20230601150106.18375-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer using strlcpy over snprintf(). Signed-off-by: Stephen Hemminger --- app/test-bbdev/main.c | 5 ++--- app/test-pmd/cmdline_flow.c | 6 +++--- app/test/process.h | 2 +- app/test/test_graph_perf.c | 29 ++++++++++++++++------------- 4 files changed, 22 insertions(+), 20 deletions(-) diff --git a/app/test-bbdev/main.c b/app/test-bbdev/main.c index ec830eb32bc8..b1f2d79f4b07 100644 --- a/app/test-bbdev/main.c +++ b/app/test-bbdev/main.c @@ -251,9 +251,8 @@ parse_args(int argc, char **argv, struct test_params *tp) TEST_ASSERT(strlen(optarg) > 0, "Config file name is null"); - snprintf(tp->test_vector_filename, - sizeof(tp->test_vector_filename), - "%s", optarg); + strlcpy(tp->test_vector_filename, optarg, + sizeof(tp->test_vector_filename)); break; case 's': TEST_ASSERT(strlen(optarg) > 0, diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 58939ec321d6..40f67d126b4b 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -10028,7 +10028,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) char tmp[3], *end = tmp; uint32_t read_lim = left & 1 ? 1 : 2; - snprintf(tmp, read_lim + 1, "%s", src); + strlcpy(tmp, src, read_lim + 1); *dst = strtoul(tmp, &end, 16); if (*end) { *dst = 0; @@ -11404,7 +11404,7 @@ cmd_flow_get_help(cmdline_parse_token_hdr_t *hdr, char *dst, unsigned int size) if (!size) return -1; /* Set token type and update global help with details. */ - strlcpy(dst, (token->type ? token->type : "TOKEN"), size); + strlcpy(dst, token->type ? : "TOKEN", size); if (token->help) cmd_flow.help_str = token->help; else @@ -12220,7 +12220,7 @@ cmd_set_raw_get_help(cmdline_parse_token_hdr_t *hdr, char *dst, if (!size) return -1; /* Set token type and update global help with details. */ - snprintf(dst, size, "%s", (token->type ? token->type : "TOKEN")); + strlcpy(dst, token->type ? : "TOKEN", size); if (token->help) cmd_set_raw.help_str = token->help; else diff --git a/app/test/process.h b/app/test/process.h index 1f073b9c5c2a..e2bdecb9c807 100644 --- a/app/test/process.h +++ b/app/test/process.h @@ -176,7 +176,7 @@ get_current_prefix(char *prefix, int size) return NULL; /* get the prefix */ - snprintf(prefix, size, "%s", basename(dirname(buf))); + strlcpy(prefix, basename(dirname(buf)), size); return prefix; } diff --git a/app/test/test_graph_perf.c b/app/test/test_graph_perf.c index c5b463f700cd..521d4077600d 100644 --- a/app/test/test_graph_perf.c +++ b/app/test/test_graph_perf.c @@ -294,8 +294,9 @@ graph_node_count_edges(uint32_t stage, uint16_t node, uint16_t nodes_per_stage, for (i = 0; i < nodes_per_stage && edges < MAX_EDGES_PER_NODE; i++) { if (edge_map[stage + 1][i][node]) { ename[edges] = malloc(sizeof(char) * RTE_NODE_NAMESIZE); - snprintf(ename[edges], RTE_NODE_NAMESIZE, "%s", - rte_node_id_to_name(node_map[stage + 1][i])); + strlcpy(ename[edges], + rte_node_id_to_name(node_map[stage + 1][i]), + RTE_NODE_NAMESIZE); node_data->next_nodes[edges] = node_map[stage + 1][i]; node_data->next_percentage[edges] = edge_map[stage + 1][i][node]; @@ -405,9 +406,9 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, graph_data->nb_nodes++; goto pattern_name_free; } - snprintf(node_patterns[graph_data->nb_nodes], - RTE_NODE_NAMESIZE, "%s", - rte_node_id_to_name(node_map[i][j])); + strlcpy(node_patterns[graph_data->nb_nodes], + rte_node_id_to_name(node_map[i][j]), + RTE_NODE_NAMESIZE); node_data = &graph_data->node_data[graph_data->nb_nodes]; node_data->node_id = node_map[i][j]; @@ -467,8 +468,8 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, graph_data->nb_nodes++; goto pattern_name_free; } - snprintf(node_patterns[graph_data->nb_nodes], RTE_NODE_NAMESIZE, - "%s", rte_node_id_to_name(src_nodes[i])); + strlcpy(node_patterns[graph_data->nb_nodes], + rte_node_id_to_name(src_nodes[i]), RTE_NODE_NAMESIZE); node_data = &graph_data->node_data[graph_data->nb_nodes]; node_data->node_id = src_nodes[i]; node_data->is_sink = false; @@ -479,8 +480,9 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, if (!src_map[i][j]) continue; ename[edges] = malloc(sizeof(char) * RTE_NODE_NAMESIZE); - snprintf(ename[edges], RTE_NODE_NAMESIZE, "%s", - rte_node_id_to_name(node_map[0][j])); + strlcpy(ename[edges], + rte_node_id_to_name(node_map[0][j]), + RTE_NODE_NAMESIZE); node_data->next_nodes[edges] = node_map[0][j]; node_data->next_percentage[edges] = src_map[i][j]; edges++; @@ -524,8 +526,8 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, graph_data->nb_nodes++; goto pattern_name_free; } - snprintf(node_patterns[graph_data->nb_nodes], RTE_NODE_NAMESIZE, - "%s", rte_node_id_to_name(snk_nodes[i])); + strlcpy(node_patterns[graph_data->nb_nodes], + rte_node_id_to_name(snk_nodes[i]), RTE_NODE_NAMESIZE); node_data = &graph_data->node_data[graph_data->nb_nodes]; node_data->node_id = snk_nodes[i]; node_data->is_sink = true; @@ -543,8 +545,9 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, if (!snk_map[i][j]) continue; ename[edges] = malloc(sizeof(char) * RTE_NODE_NAMESIZE); - snprintf(ename[edges], RTE_NODE_NAMESIZE, "%s", - rte_node_id_to_name(snk_nodes[j])); + strlcpy(ename[edges], + rte_node_id_to_name(snk_nodes[j]), + RTE_NODE_NAMESIZE); node_data->next_nodes[edges] = snk_nodes[j]; node_data->next_percentage[edges] = snk_map[i][j]; edges++; From patchwork Thu Jun 1 15:00:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127842 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF2742C04; Thu, 1 Jun 2023 17:01:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D826C42D38; Thu, 1 Jun 2023 17:01:16 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 3FEDF42D32 for ; Thu, 1 Jun 2023 17:01:16 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b01d3bb571so4235445ad.2 for ; Thu, 01 Jun 2023 08:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631675; x=1688223675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gIvha0+GOXub4tzHETH9R4qYWzELpkNT71kklhQwYlo=; b=hEMT5RGZpn3MtPKmGSBFliiRRmY8G14b2wQCxTR150FxOSaPmEACmzYGghejomwzSf 9loocmBfKj0n3j+FwKOxc0/Yd6tqpp3OcjhP0I5tYxx8NplEulzEYwoJZAsROjgDUgan U/YBu6wua0isiEF6/5C6mqBM6OyTc9dV+XhOaX26ubBWF8FFhp/F7BCjd/qEyeIcunjT zSxbjdryP8NaeClbKgYj7sDC9Xprrpr4g+ECtEr30HdR9/Mpmort4KcG1Us9uatF9trD RMqcDJoZdGuOLvFUAOzpmcHpRer/nrdSz9wg8UQrydwCrUpceZdFEz5oVl+TrQ738hg+ 0jzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631675; x=1688223675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gIvha0+GOXub4tzHETH9R4qYWzELpkNT71kklhQwYlo=; b=FrRxKIe4yVPaOLmN8lckg17SZVaL+M//9TDkfKRQeSdihJXRIlYHLH8eqv/2Ss+Sjt cA1m1h2QgI3C+etlStO2RI5J+0squ8kmlutc7IOe+meXxANmEUWnz4ngiuV4jizNQuPP NSayzNLdlkFWT2kPs2rwZ/21x75frfPJcOkSYs4mF+2Eqp2ytU4EARGuVFqM9tPWFcOO +MlvWDteuj1LEXfdOzI2i8HNBj2mmb3phreUihurPzTjk489Zx8wJYsbddq+jTv21lJs VI4bdv6joH0kGwT0txV1t+341K3cYCTGENmNflrtA93dqJJD++q5qkWzv2XPPgh6DvP7 jVpQ== X-Gm-Message-State: AC+VfDylGdIdKxEooLpItztV+s97k1ihPHUtoKpoUHFidAuzFSBBTXb3 SbasRsgPJBxmy8N7is12eGG9UzjvddyvnibyAZnjsA== X-Google-Smtp-Source: ACHHUZ6TFasnnPaCaLcFYKWvNUyTwQ45V7kAW2JXrYjjwgbRbDPKbahPZxPuQAXGUJCvafXx5jbXHw== X-Received: by 2002:a17:902:d4c4:b0:19f:8ad5:4331 with SMTP id o4-20020a170902d4c400b0019f8ad54331mr7602155plg.38.1685631675230; Thu, 01 Jun 2023 08:01:15 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:14 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Brian Dooley , Gowrishankar Muthukrishnan , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Cristian Dumitrescu , Maxime Coquelin , Chenbo Xia Subject: [PATCH 02/25] examples: use strlcpy instead of snprintf Date: Thu, 1 Jun 2023 08:00:43 -0700 Message-Id: <20230601150106.18375-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace snprintf() with strlcpy() where possible. Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_validation.c | 8 ++++---- examples/l3fwd-graph/main.c | 2 +- examples/pipeline/cli.c | 2 +- examples/vhost_blk/vhost_blk.c | 5 ++--- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c index f840804009ed..6e913898074d 100644 --- a/examples/fips_validation/fips_validation.c +++ b/examples/fips_validation/fips_validation.c @@ -505,8 +505,8 @@ fips_test_parse_one_json_group(void) switch (json_typeof(param)) { case JSON_STRING: - snprintf(json_value, sizeof(json_value), "%s", - json_string_value(param)); + strlcpy(json_value, json_string_value(param), + sizeof(json_value)); break; case JSON_INTEGER: @@ -550,8 +550,8 @@ fips_test_parse_one_json_case(void) switch (json_typeof(param)) { case JSON_STRING: - snprintf(info.one_line_text, MAX_LINE_CHAR, "%s", - json_string_value(param)); + strlcpy(info.one_line_text, json_string_value(param), + MAX_LINE_CHAR); break; case JSON_INTEGER: diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index 5feeab4f0fb0..ee8f247108ad 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -546,7 +546,7 @@ parse_args(int argc, char **argv) break; case CMD_LINE_OPT_PCAP_FILENAME_CAP: - rte_strlcpy(pcap_filename, optarg, + strlcpy(pcap_filename, optarg, sizeof(pcap_filename)); printf("Pcap file name: %s\n", pcap_filename); break; diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 2ae6cc579ff2..514b6d779212 100644 --- a/examples/pipeline/cli.c +++ b/examples/pipeline/cli.c @@ -3164,7 +3164,7 @@ cmd_ipsec_sa_add(char **tokens, goto free; } - snprintf(out, out_size, "%s", line); + strlcpy(out, line, out_size); out_size -= strlen(out); out += strlen(out); diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index 3709d7ed06ba..3b05df390cce 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -771,9 +771,8 @@ vhost_blk_bdev_construct(const char *bdev_name, if (!bdev) return NULL; - snprintf(bdev->name, sizeof(bdev->name), "%s", bdev_name); - snprintf(bdev->product_name, sizeof(bdev->product_name), "%s", - bdev_serial); + strlcpy(bdev->name, bdev_name, sizeof(bdev->name)); + strlcpy(bdev->product_name, bdev_serial, sizeof(bdev->product_name)); bdev->blocklen = blk_size; bdev->blockcnt = blk_cnt; bdev->write_cache = wce_enable; From patchwork Thu Jun 1 15:00:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127843 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB67E42C04; Thu, 1 Jun 2023 17:01:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1EE142D3D; Thu, 1 Jun 2023 17:01:17 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 495DE42D3A for ; Thu, 1 Jun 2023 17:01:17 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b041cceb16so8048995ad.2 for ; Thu, 01 Jun 2023 08:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631676; x=1688223676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3JuhadsjfflQsneHaARKKs7cNuYBKeWlaNdhUAcHkpo=; b=m+t1s4hyAr96btn/BFl3aqUcR8ATZc20UOCYSDXgsAinqa5g8CCz4zahZnAWuWhOPY d41nLxBD6uO9JubjrVStvIgvPQcbWOdihuc44Sf++0opLpBVtonsxEPxsbk1YsxPKwLm AVllHLFnUhII540/neIGjtpEELr/XmvsyYOBThgAtxhN/9zud6m1aPSdy0sP/zoKppyF 4jCzz//UwT8ixZUwlTIA1r56xXXqHNmsDolw5YCTSIxiDxYuIap5WfUF0A8phZAit2kK EhGYpLyF8MHd6rm40RQhrlilbHikDof/4J0AT2GxoqSAm2s2R+QLp8OP7JmFaAnL+ZTB 6eow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631676; x=1688223676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3JuhadsjfflQsneHaARKKs7cNuYBKeWlaNdhUAcHkpo=; b=apdlacn4VvYfbvhWWdRP0cmPFUbiuLBgG4opzw4LSURfhjgGblLR/q76bnLN/y8NKl fkkrB/zxcXBgWjbjPCEkUCEiyWAWe1RYn0gzIjJ3BJtnPvsf/yZ5tfHcPePl66puNrAm zG83JUBFy6tNKG0Rfw8b6EDjKWHwTP5Fp7s9d9fT90ReG/59SdqEgGyV11qq9K3TvlkV G8Sfz9ulfGQXLpy+tdWr2ids7V+84zkpVPuJQfL8kVoUOSbvnPzTahbKb5RCWgih7fG9 ueMuyTCqZkZ0jrGA0U6ivYwFSvePsdOuLSd/FPlXY6loxYkO5uBtTNZIbSuDpOnLURBf ef6w== X-Gm-Message-State: AC+VfDyewH2orrPhoPQpl3XTocpiFxo6j7bGiYrbAecjgi409hbl4x1i 9Ps83dxpNh0ybvRWCZecJDhmIf7OHhhvSTlz2OBjZw== X-Google-Smtp-Source: ACHHUZ5CRbnBmT3ZND6cy7YOS9VW5kVmmb/SV76j4xViZB2jfByQQEpYkIzC1X3ccuFdenT+wdG57Q== X-Received: by 2002:a17:903:2284:b0:1b0:45e2:ef38 with SMTP id b4-20020a170903228400b001b045e2ef38mr10320049plh.26.1685631676174; Thu, 01 Jun 2023 08:01:16 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:15 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Subject: [PATCH 03/25] lib: use strlcpy instead of snprintf Date: Thu, 1 Jun 2023 08:00:44 -0700 Message-Id: <20230601150106.18375-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace snprintf with strlcpy where possible. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- lib/ethdev/sff_8636.c | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 581509b5a213..7cc126a0e7be 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/lib/bbdev/rte_bbdev.c @@ -212,7 +212,7 @@ rte_bbdev_allocate(const char *name) bbdev->data->dev_id = dev_id; bbdev->state = RTE_BBDEV_INITIALIZED; - ret = snprintf(bbdev->data->name, RTE_BBDEV_NAME_MAX_LEN, "%s", name); + ret = strlcpy(bbdev->data->name, name, RTE_BBDEV_NAME_MAX_LEN); if ((ret < 0) || (ret >= RTE_BBDEV_NAME_MAX_LEN)) { rte_bbdev_log(ERR, "Copying device name \"%s\" failed", name); return NULL; diff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c index 6b65f47efedf..a623e0d065d8 100644 --- a/lib/ethdev/sff_8636.c +++ b/lib/ethdev/sff_8636.c @@ -203,16 +203,19 @@ static void sff_8636_show_ext_identifier(const uint8_t *data, struct rte_tel_dat switch (data[SFF_8636_EXT_ID_OFFSET] & SFF_8636_EXT_ID_EPWR_CLASS_MASK) { case SFF_8636_EXT_ID_PWR_CLASS_LEGACY: - snprintf(val_string, sizeof(val_string), "%s", ""); + strlcpy(val_string, "", sizeof(val_string)); break; case SFF_8636_EXT_ID_PWR_CLASS_5: - snprintf(val_string, sizeof(val_string), "%s", "4.0W max. Power consumption, "); + strlcpy(val_string, "4.0W max. Power consumption, ", + sizeof(val_string)); break; case SFF_8636_EXT_ID_PWR_CLASS_6: - snprintf(val_string, sizeof(val_string), "%s", "4.5W max. Power consumption, "); + strlcpy(val_string, "4.5W max. Power consumption, ", + sizeof(val_string)); break; case SFF_8636_EXT_ID_PWR_CLASS_7: - snprintf(val_string, sizeof(val_string), "%s", "5.0W max. Power consumption, "); + strlcpy(val_string, "5.0W max. Power consumption, ", + sizeof(val_string)); break; } From patchwork Thu Jun 1 15:00:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127844 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6701D42C04; Thu, 1 Jun 2023 17:01:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B2BF42D42; Thu, 1 Jun 2023 17:01:19 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 5F10242D3F for ; Thu, 1 Jun 2023 17:01:18 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-64f47448aeaso647785b3a.0 for ; Thu, 01 Jun 2023 08:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631677; x=1688223677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mnNZnferKtAN5dQAZ0nl8YtGIyjuTkqE1jvZ3mmpjeU=; b=pcMb6dww2kNapWFVRI+kJUQnKb3QJllHaiTNDX3I6PGgxbzpJeoKn/CGskTYylpKRF rAbfJhJDnpQjh52c/iZTe/9kIHFH5Zmndx3F48xF+QwcEvpOJwBw80tEK+PZK+Z6e3xm dSd3mjx5EcPMxTqeb7I5rihRKwiA5Z/I9bJ5Sxcxohpl99wI/izIbxGkvEkwvMGx72id fyZEQBkLCZ7wSYFRwpAm85nBthLS7U2sNDBOYMKnUsvAOKRy1y346wGcFzDSX9h+Fj8S yrr+cbSs9BsviZyTzZuUHzPBwvP5pFNO3yf/P8kqhi4E8LzgVoKcQDIv+3ThDEt/3roR E4aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631677; x=1688223677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mnNZnferKtAN5dQAZ0nl8YtGIyjuTkqE1jvZ3mmpjeU=; b=WT1molC7itSKK7w992oeDV9ngVS786BwRkh8pElcPjkLoWo5obHCTHNkq6/qxv2xAL OBUKfcJbkTEV15SS61afnJ6lRjboxhaj9DwTXw5y796IapK5jXt3fz6oC421yAh7U6L9 MBW2p8eZwMmzrSKOwGErWfR6gRRIl3vzr2WaRXdHKDchBKW6EaPBtdG7KBSDZJDtGZJW EYYRaPzllxyjzqLDaHw/j8QfYS9tRquE6XCrRzRYP/SRIwbl6kNq/hB0IrNpy6q/DCIt ccOb2V15Ulx6hZ/tzjYLlJAv+Bv9y6f7TlxXT3vhxXh9GmOF7+DqgkVHRX5Xpj1C8ZN2 dEKg== X-Gm-Message-State: AC+VfDwugJpqCCOxRwAqtBVyuz23druvQcpcynDRoiFl0WxdY2er72Y2 IFG1Re1s+DeIwyiAY7CXn96B0tjtoK7m154WBHxyoQ== X-Google-Smtp-Source: ACHHUZ4D86IVo4v/VK1VCuaN5d9Goi0iLltIrmZti2z6I747dmqPeCXL/PisQ1AzAYoaAdSLPXYOog== X-Received: by 2002:a05:6a20:3c87:b0:10f:2abb:c9fd with SMTP id b7-20020a056a203c8700b0010f2abbc9fdmr8142481pzj.43.1685631677223; Thu, 01 Jun 2023 08:01:17 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:16 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu , Tianfei Zhang Subject: [PATCH 04/25] raw/ifpga: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:45 -0700 Message-Id: <20230601150106.18375-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Rosen Xu --- drivers/raw/ifpga/afu_pmd_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/afu_pmd_core.c b/drivers/raw/ifpga/afu_pmd_core.c index 3ab1f47ac1a4..e969897dbe7d 100644 --- a/drivers/raw/ifpga/afu_pmd_core.c +++ b/drivers/raw/ifpga/afu_pmd_core.c @@ -16,6 +16,7 @@ #include #include #include +#include #include "afu_pmd_core.h" @@ -225,7 +226,7 @@ static int afu_shared_data_alloc(const char *name, return -EINVAL; /* name format is afu_?|??:??.? which is unique */ - snprintf(mz_name, sizeof(mz_name), "%s", name); + strlcpy(mz_name, name, sizeof(mz_name)); mz = rte_memzone_lookup(mz_name); if (!mz) { From patchwork Thu Jun 1 15:00:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127845 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1427C42C04; Thu, 1 Jun 2023 17:02:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 319E842D51; Thu, 1 Jun 2023 17:01:21 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id AC18842D46 for ; Thu, 1 Jun 2023 17:01:19 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b01dac1a82so4723995ad.2 for ; Thu, 01 Jun 2023 08:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631678; x=1688223678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HZARbk9YgVRO2lX5CYMPQBUD+qzvDSA0DNrTV3EpARg=; b=bvqroIgPZeaWVj0yqcYnl6CroLF6B1IQa6VPkuzTY72hGW3ZoWzhGW967LUM9F8JJ4 rTD6TqlHmYwiH5riV472AOrcAhJr9dAtyjVatOFzeqkHHDo10GpwTfbxf5T12cdh42J9 Kpg/UYqleR2ua/BKFpLkx5oq2VFn28RIY+ZbSyIfVDW1mLjKQDPyqAGMkHE/F1DnoQTE ZB4pMx87rrkI2icZ3dNc+5oguB8NUoFLtlXfm37q/P2r0RH/cxKAsCgYkRRnwmYmN7/d 53+HFBUXD40iaEfmosj4asPV1UmGeQXuZs+J7FjxGr5RhMtttQNTx1b9PYLITqEDkD8F tJfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631678; x=1688223678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HZARbk9YgVRO2lX5CYMPQBUD+qzvDSA0DNrTV3EpARg=; b=dcZHGLS5jTU8gqhw3b2cSzorcEdre4g2+Iq/xHnlm8ASZrRF9rAHuqh5dGraZT5tPV YXziFkJLf9hetwhyJoGdKGWoQRgE8x8Dl+kEc1AMVr+LTG+rsI56JZkBJPKaIdU8SSLi cmCGOl8WAxvZVFn703iEP2uhvG6Kkd16VLyr5p2YhkH7YCfwUVI9pIhnduxqY1/UDUY9 D2xQspu9AwQAPyY4wApu54n5VpvWM2odjrIqiiOtg/Rq9ycCiOV3N7niTLohc7gvAqq/ w6BleMLyuQsK2j8a2GsJ/dOveorS2qQemaCxfx2SZ4a3odKWILsRvOp2e84bBPuyokWn WJVQ== X-Gm-Message-State: AC+VfDzpFjKWOe9TUdeqwwLPzbuqovNRN16xFL028cg/pw7nH94kBAQd AJVCYFR/hXtFJrQ5SEy04PHS4hBZEbWumYN0WXHdvQ== X-Google-Smtp-Source: ACHHUZ5AsCnf5r2Di6paq/15iuDMqQ7v01ghv6+voKP2ySHtKt6LUOwLgS87QN2qRyL7T8R3dR37mA== X-Received: by 2002:a17:902:e844:b0:1b0:36b5:dd6c with SMTP id t4-20020a170902e84400b001b036b5dd6cmr7088448plg.26.1685631678258; Thu, 01 Jun 2023 08:01:18 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:17 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH 05/25] common/cnxk: replace snprint with strlcpy Date: Thu, 1 Jun 2023 08:00:46 -0700 Message-Id: <20230601150106.18375-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_stats.c b/drivers/common/cnxk/roc_nix_stats.c index 6b5803af8442..b2e1c8cd05ad 100644 --- a/drivers/common/cnxk/roc_nix_stats.c +++ b/drivers/common/cnxk/roc_nix_stats.c @@ -16,9 +16,7 @@ #define NIX_XSTATS_NAME_PRINT(xstats_names, count, xstats, index) \ do { \ if (xstats_names) \ - snprintf(xstats_names[count].name, \ - sizeof(xstats_names[count].name), "%s", \ - xstats[index].name); \ + strlcpy(xstats_names[count].name, xstats[index].name, sizeof(xstats_names[count].name)); \ } while (0) int From patchwork Thu Jun 1 15:00:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127846 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FC5D42C04; Thu, 1 Jun 2023 17:02:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3842C42D59; Thu, 1 Jun 2023 17:01:23 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id AAF2742D55 for ; Thu, 1 Jun 2023 17:01:21 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-64d5f65a2f7so649384b3a.1 for ; Thu, 01 Jun 2023 08:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631680; x=1688223680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9BATqt2tO/9/EDDw5Lf9l06MYHtgzXoYUTBgmOoOGsQ=; b=l7O3bW6J9Qr3pA07CJK4/X6m22E7gBxBLtFvOFJj//PW96TQrhj+fij/jGbtyZB+VK ufpzIvzZcy9otHukFW+1QEucYui5+6k/9r/oIqWmTt6J6dWhJzGlt/kSNblWMv1z/j3t uJfwYXhkJg0Mi2pyMdLCNKO6H6FbyZ9lXAXRIvQ82OW6JVruZmF3f7yM1mPPJVkd0z2t ZsI2XAnVQCrED0uu7msTdoWGLP/KTrQf4ErHaZuS3xRnX+s9ocqn98TDWZvg+9mVb3SM XvF6l4pQEVEMlaPD8Y/WAAawsPUIeuzTd4sqblk8gZgFLvd9elD1qeHhn1YSCLFvQO4j 3lNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631680; x=1688223680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9BATqt2tO/9/EDDw5Lf9l06MYHtgzXoYUTBgmOoOGsQ=; b=QG/wMYBHVQUDENMSqs5FLF4sWie94jlRjJ8SSdLsjwllzqSDdcUMCqZyzFyfOs5lwe e65Rte0JthcM7ZfZnb3QygDGiFRNqu9j4kZrgsYZpkKayu1udODdN1SCE93DSga6ZSy7 D6zJctS92qW5L5ju1D8B4VRuihDEGDUhYMhCuihWSTLpB6bU8dPm78V10n2YfD0CkNDr +3x5dt95W9+kZvN2bY+IhD7mU4XYsoH/nriRP9P7Zj/2CDpe6/5PwzTCNAULg6/O/LIK +xUi55YsfqWV6X2Qsxq/6QLG2zOfQVhL6IrioQV3hq17p4WAMDDy6/LQKOHNRIRp4WpF eWsg== X-Gm-Message-State: AC+VfDypQtWC0DNopIxZdqapqfenYNRF1xKlpLb2MBYOsubDzp12TJhI p82Lp2K7oHMm8NyKdnHBnLoKtPHxmUwckmC5vKt0lA== X-Google-Smtp-Source: ACHHUZ4Mff9MjrB28hQIgHP6Rc4PeUPTmpgx5itDWL2OfjH7IbuHaYp8JlVi7cnFmow3pNH9ohpP8A== X-Received: by 2002:a17:902:d50c:b0:1b0:663e:4b3f with SMTP id b12-20020a170902d50c00b001b0663e4b3fmr5738915plg.37.1685631680543; Thu, 01 Jun 2023 08:01:20 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:19 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH 06/25] common/mlx5: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:47 -0700 Message-Id: <20230601150106.18375-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/common/mlx5/mlx5_common_utils.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c index aafff60eeb38..c4ceeccf3825 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.c +++ b/drivers/common/mlx5/linux/mlx5_common_os.c @@ -897,7 +897,7 @@ mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len) } } while (strchr(ptr->d_name, '.') || strchr(ptr->d_name, '_') || strchr(ptr->d_name, 'v')); - snprintf(cur_ifname, sizeof(cur_ifname), "%s", ptr->d_name); + strlcpy(cur_ifname, ptr->d_name, sizeof(cur_ifname)); closedir(dir); snprintf(tmp + strlen(tmp), sizeof(tmp) - strlen(tmp), "/%s/phys_switch_id", cur_ifname); diff --git a/drivers/common/mlx5/mlx5_common_utils.c b/drivers/common/mlx5/mlx5_common_utils.c index e69d06878c2e..3e809b409854 100644 --- a/drivers/common/mlx5/mlx5_common_utils.c +++ b/drivers/common/mlx5/mlx5_common_utils.c @@ -49,8 +49,7 @@ mlx5_list_create(const char *name, void *ctx, bool lcores_share, if (!list) return NULL; if (name) - snprintf(list->l_const.name, - sizeof(list->l_const.name), "%s", name); + strlcpy(list->l_const.name, name, sizeof(list->l_const.name)); list->l_const.ctx = ctx; list->l_const.lcores_share = lcores_share; list->l_const.cb_create = cb_create; @@ -422,7 +421,7 @@ mlx5_hlist_create(const char *name, uint32_t size, bool direct_key, return NULL; } if (name) - snprintf(h->l_const.name, sizeof(h->l_const.name), "%s", name); + strlcpy(h->l_const.name, name, sizeof(h->l_const.name)); h->l_const.ctx = ctx; h->l_const.lcores_share = lcores_share; h->l_const.cb_create = cb_create; From patchwork Thu Jun 1 15:00:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127847 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 520D142C04; Thu, 1 Jun 2023 17:02:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ADBF42D5D; Thu, 1 Jun 2023 17:01:24 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 8C36C42D59 for ; Thu, 1 Jun 2023 17:01:22 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b024e29657so4262505ad.3 for ; Thu, 01 Jun 2023 08:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631681; x=1688223681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m33lEkmqGKnD19bn6xGeZcBa1oG7YjatxdgS7K8uixQ=; b=hjL2x0pAyu/qUZZXNVAx4ercALTjWC7XqcplhjRJTvZGafjxyqUt+afJgTamlrBQ/J E1j04Moo7p2HIiU+xdO5PHxh1p8KUH2WJGvpRWjIiEfteFQLhDimGHrPkWopZ0pFQikR mAxKFrX2ju+2nXEAGuuVMHwOOJtjHPqjpEubkBSreH0eD7uUvRBUge/LYYfs2VcqlOwc MIyxb5+54PpkgScrQW6opjsAX9ikztgdQR2cPSsaCLN7iEJ7gTYAeNluMX5EwDjn4F20 Qlrm5CMKsiJ+3nGSIXQNngdMq9NNdJOvpJOJ8G76SitiWUNW3YORcSI1ykflLPB8445N 11cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631681; x=1688223681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m33lEkmqGKnD19bn6xGeZcBa1oG7YjatxdgS7K8uixQ=; b=Quc+V/Gy2Njb0DwXQVRcGN4enhFWhuObZ5lGcmrR0s2PVjRJeEbhEAjiLI0hW4Df9S B+bF3Xv1KaosUUSgo79E1CXjgT5RwJlAV/+IAWYqaTMQp8n2bBRVgxR8NHufwk0boDFq ssYpeAHw0xQtjjoBIF9TO6gCXDoQph0wV9byCkKzkTUJwrpq7vR/UwezSMMXiZyyJOse L9d95lw4fCUmmiSpTv8neP5R32n1Qp2i2pYK4qv0vy5zKi1QJSIDC+5Is7gNlHCrogGH 2p68WWFBeF4x0fVyCCEVq0qrUWajEUoPlRM80jewgoTa2qt4MVleG9U1ZNSaKqhFj5en RwYA== X-Gm-Message-State: AC+VfDxyZGZbMG11cl3fmgRvoUb28+z6M1MimfFm/Wn0bm1JlX4wsvZq AtJ9j7S05iFZXGI17Wyy1IZ0eCr1yICHwaxmF1WOcA== X-Google-Smtp-Source: ACHHUZ4/JwxZvEQTGPomiRwJDqoX60+TvmOHAvx7SveSWcv1CIXFfpirgEsY532mtOyRszyqM8QE0g== X-Received: by 2002:a17:902:da83:b0:1ab:675:3e31 with SMTP id j3-20020a170902da8300b001ab06753e31mr7024329plx.37.1685631681533; Thu, 01 Jun 2023 08:01:21 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Elena Agostini Subject: [PATCH 07/25] drivers/gpu: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:48 -0700 Message-Id: <20230601150106.18375-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/gpu/cuda/cuda.c | 2 +- drivers/gpu/cuda/gdrcopy.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/cuda/cuda.c b/drivers/gpu/cuda/cuda.c index a552aabeb82d..01875816d592 100644 --- a/drivers/gpu/cuda/cuda.c +++ b/drivers/gpu/cuda/cuda.c @@ -291,7 +291,7 @@ cuda_loader(void) char cuda_path[1024]; if (getenv("CUDA_PATH_L") == NULL) - snprintf(cuda_path, 1024, "%s", "libcuda.so"); + strlcpy(cuda_path, "libcuda.so", 1024); else snprintf(cuda_path, 1024, "%s/%s", getenv("CUDA_PATH_L"), "libcuda.so"); diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c index 322a5dbeb207..ad7809a99b00 100644 --- a/drivers/gpu/cuda/gdrcopy.c +++ b/drivers/gpu/cuda/gdrcopy.c @@ -20,7 +20,7 @@ gdrcopy_loader(void) char gdrcopy_path[1024]; if (getenv("GDRCOPY_PATH_L") == NULL) - snprintf(gdrcopy_path, 1024, "%s", "libgdrapi.so"); + strlcpy(gdrcopy_path, "libgdrapi.so", 1024); else snprintf(gdrcopy_path, 1024, "%s/%s", getenv("GDRCOPY_PATH_L"), "libgdrapi.so"); From patchwork Thu Jun 1 15:00:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127848 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FC9C42C04; Thu, 1 Jun 2023 17:02:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EEA542D4B; Thu, 1 Jun 2023 17:01:26 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 7EDD142D35 for ; Thu, 1 Jun 2023 17:01:23 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b00ffb4186so5199805ad.0 for ; Thu, 01 Jun 2023 08:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631682; x=1688223682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SRf7mhU5Ui3qEPXgyHB19qZMBbPmBo6F4Ki2T26Ioc4=; b=3ovClv5K8VzpXU8nu9lLpfuVSUFc1xbTMTl0yKhEJDTB7QAiSWtZRT7EvZiRE8rQ11 QeWw/Fj1qX9DXnnlehTmUK/JmEhV5HdtgZ/NNNA+CWB6BhJe76VP1qAAqkDoc/qzcdmp nA8WgkcWLXPsZhAB4S4HUk2eXuaez+DFqNxgS+wQ7y7/EcujLVq1BzANlXR4Fx3ues+V Mj+eQ4vILUxchkIiS6gwr6F97t3rXTpbC0r8FCx+LpMmI2bD70YKrJO4cjGezBqfz4v6 ZjLi4dJCMzVRSv/Mj6A5iphtS7CAIYvCFmkw1oBNPil4SjRKwAOjk8Qz+QnGMqBsajMQ mUew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631682; x=1688223682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SRf7mhU5Ui3qEPXgyHB19qZMBbPmBo6F4Ki2T26Ioc4=; b=AyZhIyTS7dO1a4wZefFGVT863EY/g83l3KGBXVDaloqcVJ46yUyhc3Y4Q6h7AX22GW l8Ihu6KQSLPsFawcf9MAz4I+D3MTiTQl2IJ4OtTpHGLQ/os1rtVJJ9xShzOoi6mQ5oVu JEKLz2TooqQeavr0yMcEG85I8dybQHqpq73ef85i0Ne2FCYDtGFL19NryBNHwhanNZ+V Lbr1Wj3Wobe2i0BPm0kg5hiT7u1felK+sec6NR2S004V3KIRVONz6KTkduIqkHiWL2wZ 8GDiLY8F+6vKJ3QNaq9D+gRMtFmABXbWOlVyqUfGY00yqHCTD+aC7tJ6KugyAQXnS/vP 59fw== X-Gm-Message-State: AC+VfDxyYmS2K6pZmshX6prpPIybUKl8KeD3aR+rgewp9qdSCChYFCVy n8g+NnYiIb2MpW7LKKV49fyMsRdC35hAqWCjh8mVRA== X-Google-Smtp-Source: ACHHUZ4BS7ofx96yz6xRxd2ww9GHPDzjglvni8zgUYM+FUlLgTWPlCW7URXcs9Z+RjodxnhoB+qYtg== X-Received: by 2002:a17:902:f684:b0:1b0:e0a:b7ab with SMTP id l4-20020a170902f68400b001b00e0ab7abmr7466563plg.31.1685631682475; Thu, 01 Jun 2023 08:01:22 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Pablo de Lara Subject: [PATCH 08/25] crypto/ipsec_mb: remove unnecessary snprintf Date: Thu, 1 Jun 2023 08:00:49 -0700 Message-Id: <20230601150106.18375-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Can just use the ring name directly. Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 3e52f9567401..4af6592f12c5 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -185,12 +185,7 @@ static struct rte_ring struct ipsec_mb_qp *qp, unsigned int ring_size, int socket_id) { struct rte_ring *r; - char ring_name[RTE_CRYPTODEV_NAME_MAX_LEN]; - - unsigned int n = rte_strlcpy(ring_name, qp->name, sizeof(ring_name)); - - if (n >= sizeof(ring_name)) - return NULL; + const char *ring_name = qp->name; r = rte_ring_lookup(ring_name); if (r) { From patchwork Thu Jun 1 15:00:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127849 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6071242BF2; Thu, 1 Jun 2023 17:02:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4178F42D6C; Thu, 1 Jun 2023 17:01:27 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 7952542D63 for ; Thu, 1 Jun 2023 17:01:24 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-53fa455cd94so448817a12.2 for ; Thu, 01 Jun 2023 08:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631683; x=1688223683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djgZTxoRoEqcBlTmlHpwVyCDIEy5aJcPb5uWrzyUU/g=; b=owooBmqpTMd/D9oUgXOLQj2svAtUNv9AneO87XWAHMc8Jv86nLgAf7euATtwfXEe21 eo3cXN6LVV1ZDlslUEd/h9RlMvTYWQCaG1nLEng+BmxH6+piecuWKF/tAQXQYQOE0ldt MhisQrDICJEzocWWfNE0d51TG6ehgjFgj+Q21mJz+rfhk45aJ8AoDFgS4VJaI+OZsoN4 4OMA/wkx9SWTcDpKI6CsCUZgH/bNDuv/b3b+/ONo9Np0eBiFLPmfZ9EGYDT0D+dgYFSY w2Eq+tYCA9CMXE9aex/ggW2BVi7EPCtD/TPw9vRuMnkpKtITZh1bQSfOVyNmzzKroefZ NnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631683; x=1688223683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djgZTxoRoEqcBlTmlHpwVyCDIEy5aJcPb5uWrzyUU/g=; b=jNZliAAy0n9Oo7KAYd+5AOlvyWaJsSxYUJJXX2xSsJ471VD4LRViOn1ZwncaDR4NOc CGJRrzpf804SkPQpKyQs1Pq/LARZznmzpB+YtVdliubo+MtE0mu3psmogJRJKUrBPvL8 LNUInviSeG0RV8exg6MTI48eNFEPtYFfKOTqjDaKsLtlWnhLkL4/TIDsiXxipSPHhYTh /x/GU86c8WytcBWqNgLlI4b3yslsTO9J03gloIhpH8Phvq+mm0e8nseuRvKPHb2IyIcD Our4CLmRZjSv+awXmfIG6pX3rggEFJvFDDqyZYASOZuy5s/w6rpikN9arS4QFE5bFhq0 hAxA== X-Gm-Message-State: AC+VfDxE6FALhUQep9UNxH+msuCPw1kZQpgTwxn85n1nYfjKMZDzrbwB ll+VU+XbuNmf/QWMqbW80jJvhMkKtB2+AWlFKQGV5g== X-Google-Smtp-Source: ACHHUZ5ENvqwab7lqQltoBeF5nEA+PCZ9oA7k1aoGG6e5W7PkvirzhCPEDjG43Gv7XCzOle1c7n5iA== X-Received: by 2002:a17:903:22c8:b0:1b0:6e1:4b9f with SMTP id y8-20020a17090322c800b001b006e14b9fmr6919880plg.43.1685631683408; Thu, 01 Jun 2023 08:01:23 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:23 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 09/25] crypto/dpaa_sec: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:50 -0700 Message-Id: <20230601150106.18375-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index db5268384786..0df3a9f1e9b9 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -3740,7 +3740,7 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, if (rte_eal_process_type() != RTE_PROC_PRIMARY) return 0; - snprintf(cryptodev_name, sizeof(cryptodev_name), "%s", dpaa_dev->name); + strlcpy(cryptodev_name, dpaa_dev->name, sizeof(cryptodev_name)); cryptodev = rte_cryptodev_pmd_allocate(cryptodev_name, rte_socket_id()); if (cryptodev == NULL) From patchwork Thu Jun 1 15:00:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127850 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA53242BF2; Thu, 1 Jun 2023 17:03:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E97942D75; Thu, 1 Jun 2023 17:01:28 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 8886B42D0D for ; Thu, 1 Jun 2023 17:01:25 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b024e29657so4263315ad.3 for ; Thu, 01 Jun 2023 08:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631685; x=1688223685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+YABHkpto7McdN0ZM1kCvQncty03rMYfMiMT51DCr6w=; b=JsTsB6d4vooGqSPhoT4HWJAL5cmlvXTdzzpFLZZSblVZX0xhhtYa3dywO/k9EJftDm GxxZdS014FAUfn3SXZYDmt4cDoc08ghLsQfsmycLEJcI1bmyNROS76xpOplJYV219zDg Jvuefe4d2eB7HB5O9RArNuw00ft2KRQdQq3RHvt7qMm95XG7LsDo3ETSJB9uJ+wf7red JQvFsxHtbiwfYlkiVLEu3QmiGm8scUhPo0Hpp4e/1OAaIvYW+fTnx1y8ICNCLEHDGYoT 5f/JiicmwnAEhozKaTiiffG5+4or2vSuXj7jtA60vBTAhR6DcK/73c59pRBlzKGu84eg qeTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631685; x=1688223685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+YABHkpto7McdN0ZM1kCvQncty03rMYfMiMT51DCr6w=; b=R9a5ShBVnGt5717wBinKU0WMP3R8JPXw/7ERGGVg1fHUv3HJht1glLEwkofDa6v/Ap Q8rbyU97EMs2MTYHmXBPrdF0f+yyhOfqEsFXGv4+bDEuCbAD8+hnhkRt34+NNOckT2C5 DWRvt3Brnxb67JcjxZy3HF9Dn/4XcuVwMfpiORQN7jXswoWpCxhTKu2BOu7YNRQMY3MX SAtBx9g1ZPuihstUSi+01psjWvFtf2xE7DaPYl4V6g8UDKk1t6AtUdFKaom3O2PXY3bN IDzcI0TFhzYEkJpfCG8Z3GX0fB7ceStB4GMjtFGjaH9BrgPeulCeP7J5CDgeCFD6dGWn LOuA== X-Gm-Message-State: AC+VfDydXAj1QevYHALKNXtU2QRqIpmT7iQqIp0Q+NLnF1DVPRMnJRMO TEntbr3aAVd8BtuzjLMbFH16LEFSd6fkcZWOkML7OA== X-Google-Smtp-Source: ACHHUZ6QlsoWwSeddoXgDj8ZFP8erdcVsxgcJVbWtBJwUVWqLuKhrit1JniVTlkMrfIXkTHlPUOsgA== X-Received: by 2002:a17:902:f682:b0:1ac:63ac:10a7 with SMTP id l2-20020a170902f68200b001ac63ac10a7mr6804577plg.68.1685631684807; Thu, 01 Jun 2023 08:01:24 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:24 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Pavan Nikhilesh , Shijith Thotton Subject: [PATCH 10/25] event/cnxk: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:51 -0700 Message-Id: <20230601150106.18375-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_eventdev_stats.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/event/cnxk/cnxk_eventdev_stats.c b/drivers/event/cnxk/cnxk_eventdev_stats.c index a8a87a06e43e..e18d24815f81 100644 --- a/drivers/event/cnxk/cnxk_eventdev_stats.c +++ b/drivers/event/cnxk/cnxk_eventdev_stats.c @@ -246,15 +246,14 @@ cnxk_sso_xstats_get_names(const struct rte_eventdev *event_dev, unsigned int i; for (i = 0; i < CNXK_SSO_NUM_HWS_XSTATS; i++) { - snprintf(xstats_names_copy[i].name, - sizeof(xstats_names_copy[i].name), "%s", - sso_hws_xstats[i].name); + strlcpy(xstats_names_copy[i].name, sso_hws_xstats[i].name, + sizeof(xstats_names_copy[i].name)); } for (; i < CNXK_SSO_NUM_XSTATS; i++) { - snprintf(xstats_names_copy[i].name, - sizeof(xstats_names_copy[i].name), "%s", - sso_hwgrp_xstats[i - CNXK_SSO_NUM_HWS_XSTATS].name); + strlcpy(xstats_names_copy[i].name, + sso_hwgrp_xstats[i - CNXK_SSO_NUM_HWS_XSTATS].name, + sizeof(xstats_names_copy[i].name)); } switch (mode) { From patchwork Thu Jun 1 15:00:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127851 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2625D42BF2; Thu, 1 Jun 2023 17:03:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2499642D49; Thu, 1 Jun 2023 17:01:29 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id C8F7A42D65 for ; Thu, 1 Jun 2023 17:01:26 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-530638a60e1so847629a12.2 for ; Thu, 01 Jun 2023 08:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631686; x=1688223686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lhQ7hXCbL8jCGpF+RrVr6hnCz9fEMJp3NEzoyaOB8lU=; b=jLgois0u+C8jx134hbExId3TG1z3/oEUR/ZAA9QqPvrglgNJ8ryCoD5zWH2JRPvOEg CIT5gIqUgQhWGetp600K7NmQ72gX41nnsjSrqz69bYEl0CDaYKplcx696KTKwZiDpTMv WzF6wkjp4R1WcyaRTy3yau6Q1UrMk5fJOosHUtsp1prR1zr+mk+3fPLNDzegyj4UMV3g 3q7R5Y3JJONM4UTuwG4vjiywSdh8w5HwkSBKOM3YpjMJtyDRUJ7CbfjGOVd/76rLgKIh +YSwu4GXEsuNZsFBESlolaZ5qNrhhuYyqxB4rNPK6+SQtb9wA4jS46CrUD1nf41LJWYR z11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631686; x=1688223686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lhQ7hXCbL8jCGpF+RrVr6hnCz9fEMJp3NEzoyaOB8lU=; b=ISycvnjRJ533RlG6liGbFabdRlglIGwVZs2rh36JtMD3ZIefyvh8QA83TSv/t7kv3J aDkoX2hyeGRFFce3a5kcbk2HGu1nle4GZ5+JlwPlnIgEqynsp9Q0XUUcaVMylP23QxAg EzZ43UavdDKKSYXAhwYKjCVLaT3ncyr2y8I1Kom7ZUYnTPG2fZxt69Hus1iFnG0X+a4p PD6l+HMZi6mAXRO0rRYHv5Y5Yyh7px2wBBzs5sTQUNR//NoHqtTLjv4QCdea9xQFUd+Z CL0al9XoLlli820wxnNoQpKSoDGp5wo3wTmZNacM2LqFtt24FkcjdRid454omyXnoJDT oYYg== X-Gm-Message-State: AC+VfDyxT1YjRA2URGdw7aq7nezR8JGLGF6MZW+cuthU33JOucM3VjIT w2kcXhbEZYtatSUWrhVngF9l5GjKVgI4XKOYwIr6JQ== X-Google-Smtp-Source: ACHHUZ7jFTY17+58tEZZjgQkQ8LyNMVnEJ2N61BuVVStxywDCZlHleRS2jcFpKHpN3o+oB6u3DKuig== X-Received: by 2002:a17:902:c38d:b0:1af:d750:10cb with SMTP id g13-20020a170902c38d00b001afd75010cbmr9003243plg.63.1685631685803; Thu, 01 Jun 2023 08:01:25 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:25 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Igor Russkikh Subject: [PATCH 11/25] net/atlantic: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:52 -0700 Message-Id: <20230601150106.18375-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 3a028f429002..09a7d9c8c88f 100644 --- a/drivers/net/atlantic/atl_ethdev.c +++ b/drivers/net/atlantic/atl_ethdev.c @@ -1006,9 +1006,8 @@ atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused, if (xstats_names) { for (i = 0; i < size && i < count; i++) { - snprintf(xstats_names[i].name, - RTE_ETH_XSTATS_NAME_SIZE, "%s", - atl_xstats_tbl[i].name); + strlcpy(xstats_names[i].name, atl_xstats_tbl[i].name, + RTE_ETH_XSTATS_NAME_SIZE); } } From patchwork Thu Jun 1 15:00:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127852 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E17F142C04; Thu, 1 Jun 2023 17:03:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A93C42D94; Thu, 1 Jun 2023 17:01:30 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 77AAE42D70 for ; Thu, 1 Jun 2023 17:01:27 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b041cceb16so8050815ad.2 for ; Thu, 01 Jun 2023 08:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631687; x=1688223687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jDXI9oQoR7EXpy9FklUrCQ6X6QowaT/dPrOxnWyyFrM=; b=jqrT2bRXcjLIYywChoy6H4UTOBdT7vIl1eCiVFbu4RE2SJlUjAf83KuvDpYMIhOF2O uRRg+34bLBhpMTnspWdt0pUYEJPiUFdZJ09Sg5RPVLBDB1oFAINVb6JJODJt4u0LXXqh k1GZDAx9JD5cRl0nCG7TOIAawW5ECdHsw4LHh8CiWWXl//bKLwWw+A/BYqRauOBrqGh6 jRTpeOMFnDMWALeSqP1xHrdB/AzeIs9swktyxzydZhwAf/tgGU/A4hUYkHroK1MdnMuM CwYzXKwdAOriDDOKLJYKzm9VxHnAWb1I78yDvFdtAq3RZ0U+Dz+5cNuKFiX3y95yHO/u NXPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631687; x=1688223687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jDXI9oQoR7EXpy9FklUrCQ6X6QowaT/dPrOxnWyyFrM=; b=lNRwFTAotJrKv9zZE3fQm9C/fbsYQvSo0DLxPmo64dT20NbIF3DEZxEbKBqE9BqmzK kyVBqf8InpUXbfZA71wERmHAFm/nGoqas589z4PNRGkcc3DW+Pq6RQixXsnAQh1WMc0R lV1havn9c/61kMJ6rkfvkWHbu9CNOLeXjFpQ5rwbXwWV6DMU20L1TfP8gxu3SYSio/u7 A894CPisG5o7NBtEg9eMhH/vul+NIHgSrf82FH1OOsjzn0FZCVnVCBLdC5wTw8YvhyJZ sDbx8eAw90wjCP50t5W+G2aEDSVhfcK2uVnN5gIoIGDRZgyVRySWDRdmouAglmtk13Wy OzlA== X-Gm-Message-State: AC+VfDyODTQl7graGecNHR/7mtgiMIeKnX5WMifFHJXfuSi24WLrC3kf bpr0C8LF9XHLv4LmzgMft779RFKs2PHa9FP2ojojYQ== X-Google-Smtp-Source: ACHHUZ4I26Qj5v6WRF8psPduHbiX9GIH7HaEP8EFwjuMJJiVSlur5827fEigk1mM4jFiSWI/QwSCtQ== X-Received: by 2002:a17:903:120f:b0:1af:cbb1:845 with SMTP id l15-20020a170903120f00b001afcbb10845mr9783792plh.16.1685631686716; Thu, 01 Jun 2023 08:01:26 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:26 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH 12/25] net/axgbe: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:53 -0700 Message-Id: <20230601150106.18375-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 48714eebe699..f28d18ec9035 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -1025,9 +1025,9 @@ axgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (n >= AXGBE_XSTATS_COUNT && xstats_names) { for (i = 0; i < AXGBE_XSTATS_COUNT; ++i) { - snprintf(xstats_names[i].name, - RTE_ETH_XSTATS_NAME_SIZE, "%s", - axgbe_xstats_strings[i].name); + strlcpy(xstats_names[i].name, + axgbe_xstats_strings[i].name, + RTE_ETH_XSTATS_NAME_SIZE); } } From patchwork Thu Jun 1 15:00:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127853 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0266C42C04; Thu, 1 Jun 2023 17:03:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96C5E42DA2; Thu, 1 Jun 2023 17:01:31 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 9D36F42D7C for ; Thu, 1 Jun 2023 17:01:28 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1b0424c5137so8066885ad.1 for ; Thu, 01 Jun 2023 08:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631687; x=1688223687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=42w8IFnPtQZmyRCLOmEdVnUarPz4yi1d8NICTDvg0BA=; b=KgRKAFFRGwG+farOIYzXOJWDcpnGr4btTyGolXqJrl4CXrCpKSDwXEDvkdUDXVn08r zWz+Vy6X6pwpsQ/h73prawJkulnXzYGTY/WMtkXOscUbMx/Z2k+NFBoP3qtmtjTo3el0 5pHfvRw4Kq60+8m+8lQtwxG7u+uR0ZhL8EVA3KF+EdbLqp5Vk8c5QXM4oYCP4Sz3TbYZ 40GZQsBKQWVAiw6PD8TRNPCX72299AEBHfRDUve5O84g38HfRw324hkBcvt6c5pcTG1T v0RNl+V8tri3HIb0C1cJYMHLM2ykUBH1Q4xwJlaLizO1KjAyg2gtZ7ncbhaDfeut2G4b M3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631687; x=1688223687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=42w8IFnPtQZmyRCLOmEdVnUarPz4yi1d8NICTDvg0BA=; b=Bu2v0314uZoGNLy0XAweR/NHdla9J1Bgv8JQXD4cZBjbhP9khasEC+4WEgX3BHKgo6 PnNKyvYEAiW1jueUD3QZODHDPqSFIEp2Y4tEwz0cuEfyGRa7H9nZ/5HH4w8DM8FNysiB NM+9f7dy3YtuDczH/YImrC+bKpT2pot9FWVBNGAq1eY+7xXFMC0lDJr3ScTxeUuCOUsd VRIuc+YbPn2HapOSNeHfnjZGK/Cib3RnO/AhGWw7sp71PRL0CUCM3152Hqo0Io6QN7Yx hAcMsnhCiRyArHZLunw350yqQcArHbmUTQ9OBjlBjGUN8An37khcm3l5jv/yCbMFfbjK TIbw== X-Gm-Message-State: AC+VfDx7SHgFTRPVweEqwuH65FcJf/sMm8H+MSb0LiDlW00OIrMmbbBg UNVSL2dsduLj6Pbkb23fCiqWqPn50Mlf/lYgwzd+Vg== X-Google-Smtp-Source: ACHHUZ6DbPKqWR+1NUp2j8E2bs5ApApUavhGNI0fVYj8ld5bDyXaYpAS6BIIs0VdevjbIWofeVKGzw== X-Received: by 2002:a17:902:db02:b0:1b1:99c9:8cfa with SMTP id m2-20020a170902db0200b001b199c98cfamr3208066plx.14.1685631687667; Thu, 01 Jun 2023 08:01:27 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:27 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH 13/25] net/bnxt: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:54 -0700 Message-Id: <20230601150106.18375-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index ef7b8859d997..d6aa84f6d3e4 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2983,8 +2983,8 @@ bnxt_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(bnxt_rx_burst_info); i++) { if (pkt_burst == bnxt_rx_burst_info[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - bnxt_rx_burst_info[i].info); + strlcpy(mode->info, bnxt_rx_burst_info[i].info, + sizeof(mode->info)); return 0; } } @@ -3017,8 +3017,8 @@ bnxt_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(bnxt_tx_burst_info); i++) { if (pkt_burst == bnxt_tx_burst_info[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - bnxt_tx_burst_info[i].info); + strlcpy(mode->info, bnxt_tx_burst_info[i].info, + sizeof(mode->info)); return 0; } } From patchwork Thu Jun 1 15:00:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127854 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B867342C04; Thu, 1 Jun 2023 17:03:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9228B42DA9; Thu, 1 Jun 2023 17:01:32 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 8846B42D82 for ; Thu, 1 Jun 2023 17:01:29 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b010338d82so4439325ad.0 for ; Thu, 01 Jun 2023 08:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631688; x=1688223688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j0likHfQdZETDBZU4vhlch6000df6BW+7SOm4sIHWFI=; b=wN2rf+geLDORiMk53xrq1y1e7hgftOS6iDQTIUfHTWXzW44sTMCOae2Q9QmfBK+moc FLgEnNLHxGIybmZFTQcqrpgwJVH03Nruvd5eM6D15HpYS25np79fMJLeZHaZ4fXqWxBJ rOZirtk1+XlSAv5S2c8y2z9kehLRwWT1hkemUkoWVh4gsWqDx2vSKSrGSH6t8Sv8AYBB aPFv86a6/PIdY09yoZfxabclb+brOoAR55uuaLUV94oiNh9fovKJaxk2ILPl5LN9D3dp /LmhhYN6oqfLx+L6AY44A0dlVcd74uQHjPe/RWSVVb/nJfqubc1NHQgYy9jHvtYGvjz1 5nrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631688; x=1688223688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j0likHfQdZETDBZU4vhlch6000df6BW+7SOm4sIHWFI=; b=OGxG8Fk0xFRB0lRc+1L1YL5g9ZzDHBQGbg9ZPff8j+FWDTIR7QuPg5qA0SjRzuTguK gxCk71rw1HtqjU/2yl8ExLg13UagvuFg3UVvrCBanYXaH/z6bLN2VSdhMJk0wPhpXQQ3 WX9iX4O7jkNVXkiMjBRFbQgLVbFM9lAwmRAbAAHcHKWrQ6MW+MsY2lVRTIqWXIlt6Q4k qhhG80E14RGGWKgfIaSagvbJk2PUhc6MlsUasUe8iuZwatlTntFKObRJgH7eL636FSvt Y5VbVj2KfmMLrT+518BWFl9cekoOa6TW+6jXc2YRtld8VvrsHA6M2w43HaNO9G3x1dXk o8FQ== X-Gm-Message-State: AC+VfDyqTfFICZyRym3hv8N207Ye92wXNJnIVsM/DH4AI+mswI15v5wT RcyRVCAetCLYbQ7SLkHy3TFzvKoOFEDelAUGajO2rA== X-Google-Smtp-Source: ACHHUZ5MTJbirz2iPvGT7jIrd1QhkIuyaJmC83S7xdX/7e2JtxXuX1CCwqQf1KUhPXCHm80HzZxNhg== X-Received: by 2002:a17:902:d4d1:b0:1b1:8471:341 with SMTP id o17-20020a170902d4d100b001b184710341mr2433796plg.21.1685631688561; Thu, 01 Jun 2023 08:01:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang , Beilei Xing Subject: [PATCH 14/25] net/cpfl: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:55 -0700 Message-Id: <20230601150106.18375-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ede730fd508b..7aed8c878ee6 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -380,9 +380,9 @@ static int cpfl_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (xstats_names) { for (i = 0; i < CPFL_NB_XSTATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_cpfl_stats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_cpfl_stats_strings[i].name, + sizeof(xstats_names[i].name)); } } return CPFL_NB_XSTATS; From patchwork Thu Jun 1 15:00:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127855 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDB0142C04; Thu, 1 Jun 2023 17:03:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9275342DB3; Thu, 1 Jun 2023 17:01:33 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 96B7442D93 for ; Thu, 1 Jun 2023 17:01:30 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b02085bf8dso4389695ad.0 for ; Thu, 01 Jun 2023 08:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631689; x=1688223689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aKTYFTgDMobt85QN4hlYLhT1Yx+YASoq64PqApvDBiA=; b=tSzF9F52qfiFPzX73AU1s18GfioJE+wDhPoVBB9OtYu/jbUjPA13jv/cX6pS8rUtqF 2425TZdp/Q+u6/ovtjeMJ7o/vnZ42wUVDhduUAU49WFzdjiLbId6jkvqB8CwME3k4B0i ri7gzrERshPaqvzX8nFKUryQg9GTn+svR8anS2S1+xYJXq9DKn9N+KnFTfa6xle2o160 pFFnFay1VpyBi0zOf4JClSbIv8YLLfPAK1tCnMd+Fns/KYDDdpddWF2fOB6YlGmO9Z4w R0YQSFT04ZTuWVPD8ikEucetmzIdjWNlLSm96RCOnKVWFo1ACe5j7Jz1KwuU/wSh1vQ4 HCBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631689; x=1688223689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKTYFTgDMobt85QN4hlYLhT1Yx+YASoq64PqApvDBiA=; b=QM8qvWlvp2ujZMkGQ+xtkfD6/YNor0nkBnix6DIaTA4VO2n0HDMmm1ra3ezLzzkyID gYgG+SlxB7mtJAVrdq3gzjWg3k4frT+1MuWAyJJql7uMbdo21P/vOqEWRAFntjPYWl4v 5DAHYazKQnFJAaeTp8rf/2uGBOtYUZ9JwXVyPjHtBsfdpU9Q2yc9YtuLx09TYYpw/zhb /Ll0mgAv8FA8XiPUlCBvwEavcJQ17/kwse9O/+c+jlFc9bIOg4wCDUyU/htW+Hg1uKQH 99iamCqt9ULKamCWqC8aQAtWG3vLXJjOIn3+AVjDvnbJSJbpw6WXF0Ty1ffWpO55FkYZ OzHg== X-Gm-Message-State: AC+VfDy+Ixfh3h1PeKiAN3gMQM12gQo8IgixWcBtux3ab0UhCvUAtMYP K9VNNhl4u7Co/5vYN6eTnGfyyTJKeiUHIUIjx4Ww0g== X-Google-Smtp-Source: ACHHUZ7ZFkpyc8ihJwAxkpOGxy4xZ6AkikPz501bVmTytQVLuW1i9KhgozVqclkQHLkRVVwPz3M4VQ== X-Received: by 2002:a17:902:e789:b0:1af:bcf7:2bd8 with SMTP id cp9-20020a170902e78900b001afbcf72bd8mr4723241plb.52.1685631689568; Thu, 01 Jun 2023 08:01:29 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:29 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH 15/25] net/cxgbe: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:56 -0700 Message-Id: <20230601150106.18375-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 45bbeaef0ceb..a00fa6051344 100644 --- a/drivers/net/cxgbe/cxgbe_ethdev.c +++ b/drivers/net/cxgbe/cxgbe_ethdev.c @@ -928,9 +928,8 @@ static int cxgbe_dev_xstats(struct rte_eth_dev *dev, count = 0; for (i = 0; i < nstats; i++, count++) { if (xstats_names != NULL) - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", xstats_str[i].name); + strlcpy(xstats_names[count].name, xstats_str[i].name, + sizeof(xstats_names[count].name)); if (xstats != NULL) { stats_ptr = RTE_PTR_ADD(&ps, xstats_str[i].offset); @@ -1043,8 +1042,8 @@ int cxgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev, ret = -EINVAL; goto out_err; } - rte_strlcpy(xnames[i].name, xnames_copy[ids[i]].name, - sizeof(xnames[i].name)); + strlcpy(xnames[i].name, xnames_copy[ids[i]].name, + sizeof(xnames[i].name)); } ret = n; From patchwork Thu Jun 1 15:00:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127856 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11D2242C04; Thu, 1 Jun 2023 17:04:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DB7C42DB9; Thu, 1 Jun 2023 17:01:34 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 56AA242D93 for ; Thu, 1 Jun 2023 17:01:31 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b024e29657so4264485ad.3 for ; Thu, 01 Jun 2023 08:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631690; x=1688223690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=70HxSvyY6cwn3irxYhJzEh4895TjypQ8oU2O13BnGGo=; b=Y9M5rqyZGLeMy2rHZGJa7Yq1znf++MhYwwflGcs9fRR2yOPW/aEdH0pZ0klOlGGhM8 newnh7VRZqgnV4HS+0OFrS+mG+lfnulN/X52mKFo3cImVtK42XErLLG8sRkAdXjnJq5A 6w+uoOs4QOe9KCxv7C2pmVk5AJDXh9WODD4J+jS3+UPP7WkyKTguk9VWlu+2GUMLoult 4cZWRqjC8ISrIaC/7jwofeYh2iVUfjwYfnkJMILu5Vxz6Pp9eaxvZsYjJ5vVRavIIErK 3bwI92irgwR69Z381DrbLQlbmLZzoD5ci4hLTcQqIeYHHH7yex9GbAwnHOSfFRGjzSnz 8CQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631690; x=1688223690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=70HxSvyY6cwn3irxYhJzEh4895TjypQ8oU2O13BnGGo=; b=HUoH2f48Z+Ztci14dK7J2VvmAiTHwmUBtPLv7rXTtqwyU1FD4NqyOSuEET0e+QawRT FRTuZcc/03sgQMeiXxK0jb8q7/UMOlXEHX8/e8PRp0VFUkoJrycnAZvL7bY+hR1yfLOC zVfBXCEbIhPS3/Oecu3QBmmapqG9d2e97LHhU7o70Qozcj539e7mn+WdYmkwDyqzeIp4 QWU8s525HY9rACUso/GyYvDEEW20+LGP600J48Fow7MAyPWMCbXsaxHADV9UtmzIfw29 J6SUMoH02F53jBjcBJjdq0En2MAuYsO6idvbW53ZUfUegMWsa+0avjj/SUBXGJPXWj/1 CXQQ== X-Gm-Message-State: AC+VfDyYtxsq8sspHRTX7OJXe8lqLLBTjmzCEu31piNSS5AfooVaUTv9 5XpuIUpzvDVI6Xvg52QfO+Ozaqe/5f9F8r6L7aETAw== X-Google-Smtp-Source: ACHHUZ6Af407cHEJWo4Q9vh7UeDUhzfiYWo6/vzL/HKBCs1z9VF9ifOIisHec1Q8q6oVt1o9WHZQvw== X-Received: by 2002:a17:902:a60c:b0:1b1:95ac:a4da with SMTP id u12-20020a170902a60c00b001b195aca4damr1677471plq.8.1685631690657; Thu, 01 Jun 2023 08:01:30 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 16/25] net/dpaa*: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:57 -0700 Message-Id: <20230601150106.18375-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 8 ++++---- drivers/net/dpaa2/dpaa2_ethdev.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index a6c86113d125..0076a531005b 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -620,8 +620,8 @@ dpaa_dev_rx_burst_mode_get(struct rte_eth_dev *dev, /* Update Rx offload info */ for (i = 0; i < RTE_DIM(rx_offload_map); i++) { if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) { - snprintf(mode->info, sizeof(mode->info), "%s", - rx_offload_map[i].output); + strlcpy(mode->info, rx_offload_map[i].output, + sizeof(mode->info)); ret = 0; break; } @@ -654,8 +654,8 @@ dpaa_dev_tx_burst_mode_get(struct rte_eth_dev *dev, /* Update Tx offload info */ for (i = 0; i < RTE_DIM(tx_offload_map); i++) { if (eth_conf->txmode.offloads & tx_offload_map[i].flags) { - snprintf(mode->info, sizeof(mode->info), "%s", - tx_offload_map[i].output); + strlcpy(mode->info, tx_offload_map[i].output, + sizeof(mode->info)); ret = 0; break; } diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 679f33ae1a08..baa1c2d1ea0f 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -313,8 +313,8 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev, /* Update Rx offload info */ for (i = 0; i < RTE_DIM(rx_offload_map); i++) { if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) { - snprintf(mode->info, sizeof(mode->info), "%s", - rx_offload_map[i].output); + strlcpy(mode->info, rx_offload_map[i].output, + sizeof(mode->info)); ret = 0; break; } @@ -348,8 +348,8 @@ dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev, /* Update Tx offload info */ for (i = 0; i < RTE_DIM(tx_offload_map); i++) { if (eth_conf->txmode.offloads & tx_offload_map[i].flags) { - snprintf(mode->info, sizeof(mode->info), "%s", - tx_offload_map[i].output); + strlcpy(mode->info, tx_offload_map[i].output, + sizeof(mode->info)); ret = 0; break; } From patchwork Thu Jun 1 15:00:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127857 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9BC142C04; Thu, 1 Jun 2023 17:04:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BDF742DBF; Thu, 1 Jun 2023 17:01:35 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id B72D042DAB for ; Thu, 1 Jun 2023 17:01:32 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1b0218c979cso5065735ad.3 for ; Thu, 01 Jun 2023 08:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631691; x=1688223691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CTvwsqDlltB9bgXoPUp/FsEl/z0wa37pIpMd9rwJ9rk=; b=wXu0wNwT5SlTXf4IP5yuooHR/9mCHMI6HZ7wedYvESlTKQXebo6Vr6oe1/5GmVAIBb G9FrUbXvIdPVy1yaPCwy23vTaiQ40Js2iRDOis3sN7ls+dKke6ejX6V4vMewotsHCcuE BK4CYXtfRhq05bNCqNYjphCkGkEc70pTwKsn8NVQp05cCqajU6YhhR/Cv6V8uDTEPw9E xDXiH7u1x3WBJb9QsEXnw9uUXWVGHAHA+czU2kuQvLB8nxRWiOmpOrFeZKI2fKtwBfjr vG2dhEJQI15kjFgLX28/3ucidSThvin5KI7AXukrXWwnrpr9RHTghd2m+FjsQbsFtIjD +dMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631691; x=1688223691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CTvwsqDlltB9bgXoPUp/FsEl/z0wa37pIpMd9rwJ9rk=; b=Nn72GJOHbwFKCXw94YzxTMNtk0BTywT8Za7yoVBOsci+kmBv379wr4iAnXrsgV07XT f8Fw7+P4BQFcz2DkulzvPZkiL8QIqVyG5YUHJFuGDyMA8FYwS9B93O3j2aGcz+eZwS5H Hs9sON08yt5KzueHyceJBSB8eyY571UL11gys2CyOydjfURm04KPwruLljJMWJIEtAf0 inPs8F2BjwMTPxNvfJAJj4ZbURj+SSu4Yrjias9N+f8cHIU+ioKjKkrs+fHKmxJkUk9h hRJGVTmOIHe4ize8Z7dz6RjHmL8hWOJH7d18/b3UlWrc9bVJCmMNEJLqzf6WTfdVpq6h ypUg== X-Gm-Message-State: AC+VfDxDLsa+Tl1SLyzRuet9A7dD2J1ADnQ5reNqIh3+bY3Hqwq2UggH ehxhfntddLVfVZ2znLMex+YCEq/daReZBQRL02+WRg== X-Google-Smtp-Source: ACHHUZ4K5q+LxL0u6snECZ9ZD/leM8UXB6gik353uU27L8A1tlTVNV2jq2fJuSdfeIFtfEUYQ14QsQ== X-Received: by 2002:a17:902:aa09:b0:1ad:edbd:8541 with SMTP id be9-20020a170902aa0900b001adedbd8541mr6124504plb.13.1685631691536; Thu, 01 Jun 2023 08:01:31 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Subject: [PATCH 17/25] net/hinic: replace snptintf with strlcpy Date: Thu, 1 Jun 2023 08:00:58 -0700 Message-Id: <20230601150106.18375-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/base/hinic_compat.h | 1 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 4 +--- drivers/net/hinic/hinic_pmd_ethdev.c | 14 +++++++------- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hinic/base/hinic_compat.h b/drivers/net/hinic/base/hinic_compat.h index aea332046ede..e8d0badb792a 100644 --- a/drivers/net/hinic/base/hinic_compat.h +++ b/drivers/net/hinic/base/hinic_compat.h @@ -19,6 +19,7 @@ #include #include #include +#include typedef uint8_t u8; typedef int8_t s8; diff --git a/drivers/net/hinic/base/hinic_pmd_niccfg.c b/drivers/net/hinic/base/hinic_pmd_niccfg.c index 8c08d63286df..eb127a308a0b 100644 --- a/drivers/net/hinic/base/hinic_pmd_niccfg.c +++ b/drivers/net/hinic/base/hinic_pmd_niccfg.c @@ -1337,7 +1337,7 @@ int hinic_get_mgmt_version(void *hwdev, char *fw) return -EIO; } - snprintf(fw, HINIC_MGMT_VERSION_MAX_LEN, "%s", fw_ver.ver); + strlcpy(fw, (const char *)fw_ver.ver, HINIC_MGMT_VERSION_MAX_LEN); return 0; } @@ -2115,5 +2115,3 @@ int hinic_set_fdir_tcam_rule_filter(void *hwdev, bool enable) return err; } - - diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index 7aa5e7d8e929..bb4d5a3f0f85 100644 --- a/drivers/net/hinic/hinic_pmd_ethdev.c +++ b/drivers/net/hinic/hinic_pmd_ethdev.c @@ -786,7 +786,7 @@ static int hinic_fw_version_get(struct rte_eth_dev *dev, char *fw_version, if (fw_size < strlen(fw_ver) + 1) return (strlen(fw_ver) + 1); - snprintf(fw_version, fw_size, "%s", fw_ver); + strlcpy(fw_version, fw_ver, fw_size); return 0; } @@ -2302,9 +2302,9 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev, /* get vport stats */ for (i = 0; i < HINIC_VPORT_XSTATS_NUM; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", hinic_vport_stats_strings[i].name); + strlcpy(xstats_names[count].name, + hinic_vport_stats_strings[i].name, + sizeof(xstats_names[count].name)); count++; } @@ -2313,9 +2313,9 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev, /* get phy port stats */ for (i = 0; i < HINIC_PHYPORT_XSTATS_NUM; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", hinic_phyport_stats_strings[i].name); + strlcpy(xstats_names[count].name, + hinic_phyport_stats_strings[i].name, + sizeof(xstats_names[count].name)); count++; } From patchwork Thu Jun 1 15:00:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127858 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1588442C04; Thu, 1 Jun 2023 17:04:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 940C742DCF; Thu, 1 Jun 2023 17:01:36 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 84F6242DAE for ; Thu, 1 Jun 2023 17:01:33 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1b025d26f4fso8144505ad.1 for ; Thu, 01 Jun 2023 08:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631692; x=1688223692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H+qK5KLsp4zBm++ghShYmDp9X/nFOGl4xmclx72bFbk=; b=VBj8ebd25hV20JjQMA2lXo2p8ia4KxkbPGtRj1cuyCaCrLW0+b371i6xJHBUOv9NuI 0euH2qgaPfCsKIZum3wrah6fRENpYL1mdxdwf6GaW9/N4fB08k3wSEhMPkAS+dHYrerN xCs1f3A1a8upHIM0yD6ESm7dBx5ltFgpc4mGW/yge17OB1kIdjVYL8eNC7ULgD8T9oIc B8SnQOEujfQJLi85mSJiovI4KzFD8H3C+8e5ztnsyIGdzq2/xOzJV/MnHZ2SKR6TrVsZ GGqFpop4rn+xXN2Bwqq5f4hIdTIhAVHPXHKzPFn9dkO1yupt13ZVSwhCh4KUeWExd1gn M1Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631692; x=1688223692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+qK5KLsp4zBm++ghShYmDp9X/nFOGl4xmclx72bFbk=; b=I1opJudbbsM/IqPnEYMmccQX5mQuPJ1RnpG2kA6UsPOI4uOwgsQzfWWLC3aeo6q82T e5iBLlDIMK/b9BeBr0XZjr5qCiVXBJqD2cnJ914Jh34X5sqD4HDdzlim9ZbkatdPcrQJ cvs12zBUf36xAQjOiZJv+BzT+hPREeMIuQ0AYcFoi4L8uL0LQllFns0M315ZyOn2aGlA jBPmjMqlodTw7oForxvKV5slbg1NQ5+OhKADVVMv9PXcmN925zHve3dCpC9kf/2c3tjX 3+CMO5Ra3N3zYJbx6+5w/4CP+JmDnWIeeCr8Q9NcdoTDFlQ8/1qoDxGqWlIVKJW2r2sj QoxA== X-Gm-Message-State: AC+VfDxRjeOK7ylFTlAnxtytaonoCNnaMSy0EeFmsEpT692jQqQDCSGd GVY4Il8SwXBiu80OyjuHO9u7RkolmbJhHsKeDWmeFw== X-Google-Smtp-Source: ACHHUZ45KWbY5lqwrVyBOjWZjVN3DgdxRlfZ0VQRWLhrq8KkPkRZTXolSMvLmxPktgEDbttwyvmcCw== X-Received: by 2002:a17:902:ea0c:b0:1ac:84dd:6d1f with SMTP id s12-20020a170902ea0c00b001ac84dd6d1fmr10281086plg.1.1685631692468; Thu, 01 Jun 2023 08:01:32 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dongdong Liu , Yisen Zhuang Subject: [PATCH 18/25] net/hns3: replace snprint with strlcpy Date: Thu, 1 Jun 2023 08:00:59 -0700 Message-Id: <20230601150106.18375-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_fdir.c | 2 +- drivers/net/hns3/hns3_rxtx.c | 8 ++++---- drivers/net/hns3/hns3_stats.c | 22 +++++++++++----------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c index 48a91fb517de..766416432c57 100644 --- a/drivers/net/hns3/hns3_fdir.c +++ b/drivers/net/hns3/hns3_fdir.c @@ -843,7 +843,7 @@ int hns3_fdir_filter_init(struct hns3_adapter *hns) fdir_hash_params.socket_id = rte_socket_id(); TAILQ_INIT(&fdir_info->fdir_list); - snprintf(fdir_hash_name, RTE_HASH_NAMESIZE, "%s", hns->hw.data->name); + strlcpy(fdir_hash_name, hns->hw.data->name, RTE_HASH_NAMESIZE); fdir_info->hash_handle = rte_hash_create(&fdir_hash_params); if (fdir_info->hash_handle == NULL) { PMD_INIT_LOG(ERR, "Create FDIR hash handle fail!"); diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 4065c519c329..78921edcc9ab 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -2795,8 +2795,8 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(burst_infos); i++) { if (pkt_burst == burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - burst_infos[i].info); + strlcpy(mode->info, burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } @@ -4290,8 +4290,8 @@ hns3_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(burst_infos); i++) { if (pkt_burst == burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - burst_infos[i].info); + strlcpy(mode->info, burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c index bad65fcbed8b..2fd460813919 100644 --- a/drivers/net/hns3/hns3_stats.c +++ b/drivers/net/hns3/hns3_stats.c @@ -1176,9 +1176,9 @@ hns3_imissed_stats_name_get(struct rte_eth_dev *dev, imissed_stats_num = hns3_get_imissed_stats_num(hns); for (i = 0; i < imissed_stats_num; i++) { - snprintf(xstats_names[cnt].name, - sizeof(xstats_names[cnt].name), - "%s", hns3_imissed_stats_strings[i].name); + strlcpy(xstats_names[cnt].name, + hns3_imissed_stats_strings[i].name, + sizeof(xstats_names[cnt].name)); cnt++; } @@ -1228,9 +1228,9 @@ hns3_dev_xstats_get_names(struct rte_eth_dev *dev, if (!hns->is_vf) { /* Get MAC name from hw->hw_xstats.mac_stats struct */ for (i = 0; i < HNS3_NUM_MAC_STATS; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", hns3_mac_strings[i].name); + strlcpy(xstats_names[count].name, + hns3_mac_strings[i].name, + sizeof(xstats_names[count].name)); count++; } } @@ -1238,9 +1238,9 @@ hns3_dev_xstats_get_names(struct rte_eth_dev *dev, hns3_imissed_stats_name_get(dev, xstats_names, &count); for (i = 0; i < HNS3_NUM_RESET_XSTATS; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", hns3_reset_stats_strings[i].name); + strlcpy(xstats_names[count].name, + hns3_reset_stats_strings[i].name, + sizeof(xstats_names[count].name)); count++; } @@ -1418,8 +1418,8 @@ hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev, rte_free(names_copy); return -EINVAL; } - snprintf(xstats_names[i].name, sizeof(xstats_names[i].name), - "%s", names_copy[ids[i]].name); + strlcpy(xstats_names[i].name, names_copy[ids[i]].name, + sizeof(xstats_names[i].name)); } rte_free(names_copy); From patchwork Thu Jun 1 15:01:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127859 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B365B42C04; Thu, 1 Jun 2023 17:04:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01AD942F94; Thu, 1 Jun 2023 17:01:38 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id A4DEF42DBC for ; Thu, 1 Jun 2023 17:01:34 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1b0201d9a9eso8160545ad.0 for ; Thu, 01 Jun 2023 08:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631693; x=1688223693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jgRGa9fj99icTw6Fj7eUMSpK1g2HT9wjEmFLEFL4/bA=; b=xSu9HtwammUZJUsOd8kcOZoPhgCWSfjERRvFVIH96/1MGFMh7SIx/JsQ2szw5WZrib K2GLiSNyw/HAz96v80N6RR76APvLRmyGXWDxYgG6fCD6DyGtvNalAY4jb7yP+JkDArq3 gW/6qMV3/IDZeNDPKDBUfkanlfg+Way/p7fF84Xk2J2BsZLVHMCotmGwHrrMJ+j/CAUV HRhclmjSkQigY6zUfPIKBVUdVAOIuqrST8InuJcnkgepCcTFawuNnQlN6a7dIZaFcfvc eUFSlmyrGlmhPb5ztLbFDtZqBf5FHkOV6MC8Bfqn8XR9sa/6qThiz35KYi16+LT3uv7p Oehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631693; x=1688223693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jgRGa9fj99icTw6Fj7eUMSpK1g2HT9wjEmFLEFL4/bA=; b=AYKH7KIHkI13/Ymzs/4Yq8x/B/3Zd8naQaLN9rw3RU3vhzbTKssSHSRBC9yEREUl+H KfLOL7504GjYHavqQm6Jbc5r5Vw4+yZ0yJeCWs1KzasFKHQs1+8rbrUb0ulftu1Fyjdn 7cP66H+JurM/Apn+3mHuYCk8JbsW8/q+pIlW/79UyY6S8KTi8yb8uwwKpoZpg8nQz4Yv 00EZth7BDuCZArputCYvKp6XYj9oRnXAgjlm5EHRB0L+IprP9zT/qGgmdXdwdbpHbipc BqmZ7pbyZOUF9vBRx+js1p0Ssm0KD+q8f1jLqDE3v08U6qp4GKsvAlLAuI56XVS1+JTg ftXw== X-Gm-Message-State: AC+VfDyuLR1sSmQzDUeM1IoXw637fzy/2/9Fi46j20sPWgFtm6mRAOzG YAlL4f/PwDQ9wy3zs2x0tCAeoGzhZ0XJBQaqO9IFLg== X-Google-Smtp-Source: ACHHUZ5IroQoBo5fm39sl9qPqrLY4HkrFXej9ZZ+b5GmyFWdFWNPZBP8wyJfBtgh79JnvlRhwAAYsw== X-Received: by 2002:a17:902:ea0b:b0:1b0:56cf:b89d with SMTP id s11-20020a170902ea0b00b001b056cfb89dmr2650501plg.12.1685631693593; Thu, 01 Jun 2023 08:01:33 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qi Zhang , Xiao Wang , Yuying Zhang , Beilei Xing , Jingjing Wu , Qiming Yang Subject: [PATCH 19/25] net/intel: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:00 -0700 Message-Id: <20230601150106.18375-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 6 +++--- drivers/net/i40e/i40e_rxtx.c | 8 ++++---- drivers/net/iavf/iavf_ethdev.c | 6 +++--- drivers/net/ice/ice_dcf_ethdev.c | 6 +++--- drivers/net/ice/ice_rxtx.c | 8 ++++---- drivers/net/idpf/idpf_ethdev.c | 6 +++--- 6 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 4d3c4c10cfa4..cb8cf1a8a8ea 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1244,9 +1244,9 @@ static int fm10k_xstats_get_names(__rte_unused struct rte_eth_dev *dev, /* Global stats */ for (i = 0; i < FM10K_NB_HW_XSTATS; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", fm10k_hw_stats_strings[count].name); + strlcpy(xstats_names[count].name, + fm10k_hw_stats_strings[count].name, + sizeof(xstats_names[count].name)); count++; } diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 788ffb51c272..54fb9b9c15ec 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -3395,8 +3395,8 @@ i40e_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(i40e_rx_burst_infos); ++i) { if (pkt_burst == i40e_rx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - i40e_rx_burst_infos[i].info); + strlcpy(mode->info, i40e_rx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } @@ -3526,8 +3526,8 @@ i40e_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(i40e_tx_burst_infos); ++i) { if (pkt_burst == i40e_tx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - i40e_tx_burst_infos[i].info); + strlcpy(mode->info, i40e_tx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index f6d68403ce71..f3474f6faccb 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1802,9 +1802,9 @@ static int iavf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (xstats_names != NULL) for (i = 0; i < IAVF_NB_XSTATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_iavf_stats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_iavf_stats_strings[i].name, + sizeof(xstats_names[i].name)); } return IAVF_NB_XSTATS; } diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index dcbf2af5b039..ea5296b54246 100644 --- a/drivers/net/ice/ice_dcf_ethdev.c +++ b/drivers/net/ice/ice_dcf_ethdev.c @@ -1549,9 +1549,9 @@ static int ice_dcf_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (xstats_names != NULL) for (i = 0; i < ICE_DCF_NB_XSTATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_ice_dcf_stats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_ice_dcf_stats_strings[i].name, + sizeof(xstats_names[i].name)); } return ICE_DCF_NB_XSTATS; } diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 0ea0045836cc..bde52f7532fb 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3605,8 +3605,8 @@ ice_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(ice_rx_burst_infos); ++i) { if (pkt_burst == ice_rx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - ice_rx_burst_infos[i].info); + strlcpy(mode->info, ice_rx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } @@ -3846,8 +3846,8 @@ ice_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(ice_tx_burst_infos); ++i) { if (pkt_burst == ice_tx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - ice_tx_burst_infos[i].info); + strlcpy(mode->info, ice_tx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index e02ec2ec5ace..39c9edbb3c19 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -384,9 +384,9 @@ static int idpf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (xstats_names) for (i = 0; i < IDPF_NB_XSTATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_idpf_stats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_idpf_stats_strings[i].name, + sizeof(xstats_names[i].name)); } return IDPF_NB_XSTATS; } From patchwork Thu Jun 1 15:01:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127860 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A000842C04; Thu, 1 Jun 2023 17:04:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE88A42F9E; Thu, 1 Jun 2023 17:01:38 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 7E84042DC8 for ; Thu, 1 Jun 2023 17:01:36 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b02497f4cfso4712265ad.3 for ; Thu, 01 Jun 2023 08:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631695; x=1688223695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8dqrjxEsQL5vuVPAXCkZC0SCxHc+z1y3yRa7Zuhkn5c=; b=zDaHNyhpHM1zUREyQ4s/t/09fpCK3s+8ASDpujCR/Jbi9vNva0vYoiqT79KXiPiKC5 A8SBreSQ7u2R0BxzpVjJgCKNCzeZJ/IuBWsKXNWlv/noq/lJ6YFYddWVuJKQhq+6/f/f 9dRPBo6Ejy2eRlVTCx+6Mz/jq4khD0gucLKtgJGx1tSU5gHrgdOwqW0+DbsRU+OsE/H9 PfFkzVpy3XMrWbUmRCQ6VTxm8oTvqysIqnuZtC3n+n3rDZdUgQjcUt5SnS1hmZqtRTwS lzJsfb87uphV+3qe2ZhGuIX/ac1OIzXb2LAwj+R6hx+bnEhisC7Ph4fZvcrnVflCj+G8 naMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631695; x=1688223695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8dqrjxEsQL5vuVPAXCkZC0SCxHc+z1y3yRa7Zuhkn5c=; b=DHuEUbyiuiekaUlrFwVdRv80DyRxLdPtxn5OqBKcSnXskzqiDLXqC9L3n8rzR93ONV hZXpm2qcC6G24LSuaqDSPt0FS7ZSYQGyVzar+CMs1PkXbipnpoUw/NDw7JZ4Yyef/58W PA/po7tjOZzMFIKx4LT1ooYLdhL/ER33RGof9HbstT2xwOQNqdRJZxicn3Vg67eFhNrY Tc+3407WVo3JvdJiSCYp2ir0bbw48FPA0QXAdi1QakM93IlsrFuWmz/dVtt+o1Uan7zZ +0bnuHv2nFO66kLz9zC25uf8c/VpR94uOjzotaz/SU2hbdooUpdNjXv+v2KlF5uWI2RO AOZA== X-Gm-Message-State: AC+VfDwXLQy5P4nCLrSB7o1s0RMshba38XlPP3AYxJzaA914dYJkfl1Q ax8ypwYXrWpQBVdeJ/EkNDRbE6QaNb7EzdAuYBHX7A== X-Google-Smtp-Source: ACHHUZ5xmZsDnZCNiMtGxbzZWiUDjnFnlUyf+MtM2aIG3gVqAqkAvvoLk6ENL9NF3HDDhVN2OYQffg== X-Received: by 2002:a17:902:9002:b0:1a9:7ffb:5ed0 with SMTP id a2-20020a170902900200b001a97ffb5ed0mr5791644plp.59.1685631695512; Thu, 01 Jun 2023 08:01:35 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Boyer , Rosen Xu Subject: [PATCH 20/25] net/ionic: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:01 -0700 Message-Id: <20230601150106.18375-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Rosen Xu --- drivers/net/ionic/ionic_ethdev.c | 15 +++++++-------- drivers/net/ipn3ke/ipn3ke_representor.c | 17 +++++++---------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index 340fd0cd5923..c6f6342e52f8 100644 --- a/drivers/net/ionic/ionic_ethdev.c +++ b/drivers/net/ionic/ionic_ethdev.c @@ -208,8 +208,7 @@ ionic_dev_fw_version_get(struct rte_eth_dev *eth_dev, struct ionic_adapter *adapter = lif->adapter; int ret; - ret = snprintf(fw_version, fw_size, "%s", - adapter->fw_version); + ret = strlcpy(fw_version, adapter->fw_version, fw_size); if (ret < 0) return -EINVAL; @@ -705,9 +704,9 @@ ionic_dev_xstats_get_names(__rte_unused struct rte_eth_dev *eth_dev, if (xstats_names != NULL) { for (i = 0; i < IONIC_NB_HW_STATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_ionic_xstats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_ionic_xstats_strings[i].name, + sizeof(xstats_names[i].name)); } } @@ -725,9 +724,9 @@ ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *eth_dev, if (!ids) { if (xstats_names != NULL) { for (i = 0; i < IONIC_NB_HW_STATS; i++) { - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_ionic_xstats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_ionic_xstats_strings[i].name, + sizeof(xstats_names[i].name)); } } diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c index e50fc73f43c4..feafe9679907 100644 --- a/drivers/net/ipn3ke/ipn3ke_representor.c +++ b/drivers/net/ipn3ke/ipn3ke_representor.c @@ -124,8 +124,7 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev) rawdev = hw->rawdev; memset(attr_name, 0, sizeof(attr_name)); - snprintf(attr_name, IPN3KE_RAWDEV_ATTR_LEN_MAX, "%s", - "LineSideBaseMAC"); + strlcpy(attr_name, "LineSideBaseMAC", IPN3KE_RAWDEV_ATTR_LEN_MAX); rawdev->dev_ops->attr_get(rawdev, attr_name, &base_mac); rte_ether_addr_copy((struct rte_ether_addr *)&base_mac, &rpst->mac_addr); @@ -2330,19 +2329,17 @@ __rte_unused unsigned int limit) /* Get stats from ipn3ke_rpst_stats */ for (i = 0; i < IPN3KE_RPST_ETH_XSTATS_CNT; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", - ipn3ke_rpst_stats_strings[i].name); + strlcpy(xstats_names[count].name, + ipn3ke_rpst_stats_strings[i].name, + sizeof(xstats_names[count].name)); count++; } /* Get individual stats from ipn3ke_rpst_hw_port */ for (i = 0; i < IPN3KE_RPST_HW_PORT_XSTATS_CNT; i++) { - snprintf(xstats_names[count].name, - sizeof(xstats_names[count].name), - "%s", - ipn3ke_rpst_hw_port_strings[i].name); + strlcpy(xstats_names[count].name, + ipn3ke_rpst_hw_port_strings[i].name, + sizeof(xstats_names[count].name)); count++; } From patchwork Thu Jun 1 15:01:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127861 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91C1A42C04; Thu, 1 Jun 2023 17:05:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05A4742FA8; Thu, 1 Jun 2023 17:01:40 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 7C2AD42F86 for ; Thu, 1 Jun 2023 17:01:37 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b03b9f02b4so4210575ad.3 for ; Thu, 01 Jun 2023 08:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631696; x=1688223696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I7tekuFDxD/Cu8II9jNd6w/r+xZWRdRrnuBjlBGaNE4=; b=pTqDWigAo/RvAp3IRokC0LE2SblZbMbnpeBpnA1v5LtNuZrPL+uSHYVFuyvVOmS9+F sN42bIZazRvqtAexexih/Fd9iFzPrEE9Vos1vmgI+pq+ue1S1mhXokguCpU0EPmmWUJv FX5lbWUgRx2HiLbwP5D8dw9q3S6TEquc+X22eMS/Q8Gw9zjCVHdtNC3A1fn5PsWMbg1n St7vP6/Dk8ezMbyTVT/oBwBgBo8Cx44Yc4Qd8o8mRoaGr5Lm24KLjbaT0fOfVfIgtDjq tVTGjC+iC2YuZI9xyPW/rM0K+t5ces+NlzIFdm1V2/5XXIp+VnGNXc5gOO1TW2lvD4sq kK8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631696; x=1688223696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I7tekuFDxD/Cu8II9jNd6w/r+xZWRdRrnuBjlBGaNE4=; b=btinyWtPRmnqZlqqOxlksA8xxkIcED587z8vpgSoXRt9oY+yqgd9hu58kfSY4lSGAC p2gcJr7sgQYL02zr3J43WmqlF2qxKaE2NjoSLLNNSyIMOKUW4bKYd4W0a5hcjKF6PxBo NnvV5FycxTH9BzjrPilunBRp8cxgzabMf1k63OL/s7zx6QXDjspod/crptaV7itjYqrY l7ETde4UTIVENhrku3R9IJPnqvQz6aF9ufgAGli5BXkHf2SNGxkc5faDMrEmzgjdvGHX MMgrMw0d0VOkkDdjqlmBEVgA6rQfKkxRDReVWBtTascsIdVISFZ/lpJUEnozXNwqvpZq RXYw== X-Gm-Message-State: AC+VfDwXQKs4lOeGtBWoCLJGNfSmDilIsDfdf9sbuW1oredxKOImvxwR uOJKSsA8JshwHqJP6W6WuVuwZl75yeHK4FzkOY3OCg== X-Google-Smtp-Source: ACHHUZ6Z82Lwk1LOXHCaeY8SfrFMn3A/e0VtlYSTKJzxvSIQ9RKaaZGOQ2I5Mjk6EytPwLf8aguJwQ== X-Received: by 2002:a17:902:da8f:b0:1b1:a4b8:4f23 with SMTP id j15-20020a170902da8f00b001b1a4b84f23mr1064095plx.24.1685631696450; Thu, 01 Jun 2023 08:01:36 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:36 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH 21/25] net/mlx5: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:02 -0700 Message-Id: <20230601150106.18375-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_rx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c index a2be523e9e36..5d0ec51f2a19 100644 --- a/drivers/net/mlx5/mlx5_rx.c +++ b/drivers/net/mlx5/mlx5_rx.c @@ -219,26 +219,26 @@ mlx5_rx_burst_mode_get(struct rte_eth_dev *dev, return -rte_errno; } if (pkt_burst == mlx5_rx_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", "Scalar"); + strlcpy(mode->info, "Scalar", sizeof(mode->info)); } else if (pkt_burst == mlx5_rx_burst_mprq) { - snprintf(mode->info, sizeof(mode->info), "%s", "Multi-Packet RQ"); + strlcpy(mode->info, "Multi-Packet RQ", sizeof(mode->info)); } else if (pkt_burst == mlx5_rx_burst_vec) { #if defined RTE_ARCH_X86_64 - snprintf(mode->info, sizeof(mode->info), "%s", "Vector SSE"); + strlcpy(mode->info, "Vector SSE", sizeof(mode->info)); #elif defined RTE_ARCH_ARM64 - snprintf(mode->info, sizeof(mode->info), "%s", "Vector Neon"); + strlcpy(mode->info, "Vector Neon", sizeof(mode->info)); #elif defined RTE_ARCH_PPC_64 - snprintf(mode->info, sizeof(mode->info), "%s", "Vector AltiVec"); + strlcpy(mode->info, "Vector AltiVec", sizeof(mode->info)); #else return -EINVAL; #endif } else if (pkt_burst == mlx5_rx_burst_mprq_vec) { #if defined RTE_ARCH_X86_64 - snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector SSE"); + strlcpy(mode->info, "MPRQ Vector SSE", sizeof(mode->info)); #elif defined RTE_ARCH_ARM64 - snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector Neon"); + strlcpy(mode->info, "MPRQ Vector Neon", sizeof(mode->info)); #elif defined RTE_ARCH_PPC_64 - snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector AltiVec"); + strlcpy(mode->info, "MPRQ Vector AltiVec", sizeof(mode->info)); #else return -EINVAL; #endif From patchwork Thu Jun 1 15:01:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127862 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 145A742C04; Thu, 1 Jun 2023 17:05:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FAF542FB4; Thu, 1 Jun 2023 17:01:41 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 2AB6F42F98 for ; Thu, 1 Jun 2023 17:01:38 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1b025d26f4fso8145165ad.1 for ; Thu, 01 Jun 2023 08:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631697; x=1688223697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8lw1+NY0rVzeC60tyo98Jv1WJw98RbrAw+E0e1/CcMg=; b=PMms9MbekNylw/roFTLbpMx97ViDUc1h54OUsQCbQElnsHNKRRfHOZ95qZrWpuH6z6 h5c5LHif5xj82A8pTlxsR/FkEfVro/Xjz1dor0HYlIQ/7/ctT9DKnzZglsv7w3ZcPcc8 j+QlCP8Baw7mI9B2GdLFTVc/d9GB1vrfAvYTWQbxNRP3vhKkTY0qZ/ZSAVUjAZVIwYq/ FOLMAPN1oBsrc1tlEUTfFQskTQwGIk51wNXx+ceMHh9ZI7qFBw6hZ+zwnJr2eDOPuHa1 79H20g+3ImCjSZuHTMmv28v5c2R+afGdhadpYNTfIVQksNcnE8Blvsa5cdD/72l8n2d5 P36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631697; x=1688223697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8lw1+NY0rVzeC60tyo98Jv1WJw98RbrAw+E0e1/CcMg=; b=dYWwbBm6ios3xPSG46BWrVJ8sQU5o8PaH/MzNF/bCGKWePXEOQS9YVxlrm6VenajGP SkFJAqen60zqVh4z4JkwF83FIZxcNERNDI3gmDZx8M5L20RhwZVUN2t+jxP8W+VezyHJ v9pFM5u0N8gbEtWXVotClone3mMKQIRCtX8mfwPKIZrlRbWGEL2mSw8chI1mWCvG89jy IOjtNPsnlRX3QkpdpoFogHSFByt7nIOe67ksCM0/uNemkbNHGXgO+WGTK8kD+7aX96SZ bYxYPxnzZin0vDrIDrTpjYlhdImn1MoK/Wby0bn3SbioieBrytFYB8pJ/ZI/IQwBbDEQ NzDg== X-Gm-Message-State: AC+VfDzzLqsjG4gNWz4BuVbAtZFMofOOkHwVpRuskPC0w7AXb34h0cjN iG5PCTlsBR26GgorRYiVP9tvVZHPMkmkIAs4tQ3SYA== X-Google-Smtp-Source: ACHHUZ6wccw379AsBn6Pn59ltIbIK9gpZF1aC46OQjmlRjuMD6b4TWEVDtNXtgTnUia9LBR07CANFg== X-Received: by 2002:a17:902:ba95:b0:1b0:3f89:9836 with SMTP id k21-20020a170902ba9500b001b03f899836mr7711139pls.22.1685631697468; Thu, 01 Jun 2023 08:01:37 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:37 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chaoyong He , =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [PATCH 22/25] net/nfp: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:03 -0700 Message-Id: <20230601150106.18375-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 362c67f7b56d..09e0447d9268 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -600,7 +600,7 @@ nfp_flower_pf_repr_init(struct rte_eth_dev *eth_dev, repr->repr_type = init_repr_data->repr_type; repr->app_fw_flower = init_repr_data->app_fw_flower; - snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name); + strlcpy(repr->name, init_repr_data->name, sizeof(repr->name)); eth_dev->dev_ops = &nfp_flower_pf_repr_dev_ops; eth_dev->rx_pkt_burst = nfp_flower_pf_recv_pkts; @@ -671,7 +671,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev, repr->repr_type = init_repr_data->repr_type; repr->app_fw_flower = init_repr_data->app_fw_flower; - snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name); + strlcpy(repr->name, init_repr_data->name, sizeof(repr->name)); eth_dev->dev_ops = &nfp_flower_repr_dev_ops; eth_dev->rx_pkt_burst = nfp_flower_repr_rx_burst; From patchwork Thu Jun 1 15:01:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127863 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD14742C04; Thu, 1 Jun 2023 17:05:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D6042FBC; Thu, 1 Jun 2023 17:01:42 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 99E5C42FA4 for ; Thu, 1 Jun 2023 17:01:39 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-53404873a19so487638a12.3 for ; Thu, 01 Jun 2023 08:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631698; x=1688223698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g3b3IZxmWuRpIxKYlTZSiLXGvuEHR7RHcxIKtL6KXM8=; b=3TmJPqfX2nmUAcR+FviwbHRhciKtaE4lbyAxL6k5m8/9A7P36d8mg/8x6ZWA44SzPV jgeNLNyZvB8IM1uLWHcTNxkvPBdOHFqu/TF/bkybIcLBzhjGhcGRFN9g1ShpghXr4NK8 jEKc+xhQtvclB9YGLUUsw0EVZXUh9kAWZ2bvcMZcMLeV6nQ+3PGVCFIj6mqv6hDG7PjX OfDTuATn4CeReTEYlmzA7YIstiAVR+q2YUc+JgkNy4eQAdDVpiG9vzQUS6zwRWxBjckW IsaxCZXVd6QG4NByA0YMjtEqqPO4KKtzJrk4O218ZXyZdJ4XWvUrzMbgYMQbnTDumR7g WrDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631698; x=1688223698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g3b3IZxmWuRpIxKYlTZSiLXGvuEHR7RHcxIKtL6KXM8=; b=iIdBirJ+srVQviHXjju8oNqg97AQSe8fiegZvfw4w6T7DOsK7Hq6CVV09mXfQLCNKc RJixvq+nSdB9mGI2i12v6DAId2LHvvADefvwsVtgri2HgZ/pZlFY6lHVeuTJmp6/1QwL XbTeBBLU/iMt0yNJUObDc5tgub/ai8xXbeogwLa77YIJwoa7qW8xDw1upNfBkpAMAIk+ YXwLaAeQ1GUAHpmzBFcD0sVGLs2ZZtE+TJrkgbcdRrc6G7bWh9TKcz0pXgy5Ol3lXLR2 Zh7qDW93Z55yXAFaIC+b8Brm0vHbbLTkplpeN9V9MgUlrVq5V66gpQtwYUspfKDjMtH5 VtkQ== X-Gm-Message-State: AC+VfDzMNwpsXYHTw849l4ws43/rCm10OODtlmHmQqbK5Fg/RP2I+r3G e2PRlgNQ/dFH3GJBMtT26ncXyy3OX0FRU3ggTnkQOw== X-Google-Smtp-Source: ACHHUZ4aIaXQpg7Ewj1Shq/d3KfPvl4G6uPkoFnnZXfDZ6HvJH+MW+sVEW306nG/X5sQ25tgcl+8qA== X-Received: by 2002:a17:902:d2ca:b0:1b1:7890:ff48 with SMTP id n10-20020a170902d2ca00b001b17890ff48mr3430555plc.5.1685631698399; Thu, 01 Jun 2023 08:01:38 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:38 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu Subject: [PATCH 23/25] net/ngbe: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:04 -0700 Message-Id: <20230601150106.18375-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ngbe/ngbe_rxtx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c index 0c678e155726..dc6043f3620a 100644 --- a/drivers/net/ngbe/ngbe_rxtx.c +++ b/drivers/net/ngbe/ngbe_rxtx.c @@ -1875,8 +1875,8 @@ ngbe_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(ngbe_tx_burst_infos); ++i) { if (pkt_burst == ngbe_tx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - ngbe_tx_burst_infos[i].info); + strlcpy(mode->info, ngbe_tx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } @@ -2785,8 +2785,8 @@ ngbe_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, for (i = 0; i < RTE_DIM(ngbe_rx_burst_infos); ++i) { if (pkt_burst == ngbe_rx_burst_infos[i].pkt_burst) { - snprintf(mode->info, sizeof(mode->info), "%s", - ngbe_rx_burst_infos[i].info); + strlcpy(mode->info, ngbe_rx_burst_infos[i].info, + sizeof(mode->info)); ret = 0; break; } From patchwork Thu Jun 1 15:01:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127864 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDA3C42C04; Thu, 1 Jun 2023 17:05:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E87D42B8B; Thu, 1 Jun 2023 17:01:43 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 82A6542FB0 for ; Thu, 1 Jun 2023 17:01:40 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-52c30fa5271so381933a12.0 for ; Thu, 01 Jun 2023 08:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631699; x=1688223699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cqMUF35ogrk7JxGsEvY3cD/eBWCmp0e7y14xdvFfCuI=; b=RBt8VPD/Ssq4dtekJQS6KQ+fUNYIzJNlVHEWXqBmmsY/8GIjLAFgw3ZXjDaWoxU/E3 mhC+zu+7ZB54cqkPyXvs2WBeoPv2JI/7lHY/uPH0kZTXoH2DrCSeapABkKTwXuPL0TVQ 1uWV4+PnOQhtEXcylboMxMPSJSoJI1ap1E0oQ7oLmuwRPhdcCrrYK8qkjS+Z8GD33Jgb vtWbw1tLyQXUh2pF2HGy8bUeEbhpxGwU/DLOaIjKA1+BVB4/0M8x9ouSAQYWhjQojfb6 +KcoO/oIo9GSut7M5nrO5kZgoCjcoMAx9SoSiszEwLEjNsGahT9z5NPmtN8ruN6sL2xY qYwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631699; x=1688223699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqMUF35ogrk7JxGsEvY3cD/eBWCmp0e7y14xdvFfCuI=; b=Q1JTzrIUdwmD6qfUIrgTo+yQRCyLTk/bc8cFPLBu5uEImVeTwOcZ4+KRNCEKuXrffG tYsw7s6DfZwCLF9v8iLH2feqsxYUHc25Xxy8oI6RCa80+iz748WqsN3/f/TPdn34OmOm KgLezOPGt4JnX93ikOajHBm1UdCeimehn4Oo2iCvTvjEalaD/lOj4u1NSAIXTytlTO0x lodqJan36Ij0pv6SDblFqCKmJt0bnxvnOZPcyKu8HqjPwr6xUHN9zLF5MpTcpDy+TAuk ymNo0eMlWVgOyfCxuQMRH8yNdTiGz9wWE2Uk8TOTfNSSYA7VPn85Ciz1oow4NT2A4amJ PvfA== X-Gm-Message-State: AC+VfDzjocinTPxFs8tseSgUC2UNM+wRuvXDphXWmSFJc8Ks1x09gYww hYHuuEZMTAzUM1+ke8A10/z3a2mHTxUJP4/62+++Xw== X-Google-Smtp-Source: ACHHUZ4hTKdnXvZ5zBmsjDSaomNqAbHCRsNrgjy/CaycKwip651Fq/dBELQKlGeT70nqgox7ljYV9Q== X-Received: by 2002:a17:902:bb8f:b0:1af:daf4:b6f1 with SMTP id m15-20020a170902bb8f00b001afdaf4b6f1mr5365964pls.38.1685631699384; Thu, 01 Jun 2023 08:01:39 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:38 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Devendra Singh Rawat , Alok Prasad Subject: [PATCH 24/25] net/qede: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:05 -0700 Message-Id: <20230601150106.18375-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_ethdev.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index a4923670d6ba..7429ec3e8773 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -238,8 +238,8 @@ qede_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size) size_t size; if (IS_PF(edev)) - snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s", - QEDE_PMD_FW_VERSION); + strlcpy(ver_str, QEDE_PMD_FW_VERSION, + QEDE_PMD_DRV_VER_STR_SIZE); else snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%d.%d.%d.%d", info->fw_major, info->fw_minor, @@ -374,11 +374,9 @@ static void qede_print_adapter_info(struct rte_eth_dev *dev) ECORE_IS_BB(edev) ? "BB" : "AH", 'A' + edev->chip_rev, (int)edev->chip_metal); - snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s", - QEDE_PMD_DRV_VERSION); + strlcpy(ver_str, QEDE_PMD_DRV_VERSION, QEDE_PMD_DRV_VER_STR_SIZE); DP_INFO(edev, " %-20s: %s\n", "Driver version", ver_str); - snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s", - QEDE_PMD_BASE_VERSION); + strlcpy(ver_str, QEDE_PMD_BASE_VERSION, QEDE_PMD_DRV_VER_STR_SIZE); DP_INFO(edev, " %-20s: %s\n", "Base version", ver_str); qede_fw_version_get(dev, ver_str, sizeof(ver_str)); DP_INFO(edev, " %-20s: %s\n", "Firmware version", ver_str); From patchwork Thu Jun 1 15:01:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127865 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DFE742C04; Thu, 1 Jun 2023 17:06:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 935F942FCA; Thu, 1 Jun 2023 17:01:44 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 7528D42FBA for ; Thu, 1 Jun 2023 17:01:41 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-64d41763796so643175b3a.2 for ; Thu, 01 Jun 2023 08:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631700; x=1688223700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6uSBtC1PErz5EsP8GeqIk33zyQMLE9A/pyqMuv0s6sM=; b=3KS8vtE9ln67tSzEt2yXk/hUDmwxM9JAHhdProUMfKz1jRzw4gCuVXrDtbfxnHwr2n qd8nP0oyyaSdhal9sv9xK4Q4OP66jEn5M33lxkG98zNGkiWv6v62qdT/Fb1vA8UMWadn LUQE5Ojr5AIIqHmcxEaJ8rD0dsacO3ZKleoMa07zRISZEAp6/URQ+UEleVC9WESPHpNO AtR3OXZuq+d6mGy/np1F6rdpKAJdja3sGRdrcCk3gz4x5g6detPcEQltAEe3dYU5R3zW +n+7H2p1PKiJyMIqzSfTfO37zVh7/zWPYg9/aJIkZaYnuB/m/yxnGKpd1p3DLnuXqwyo DhLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631700; x=1688223700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6uSBtC1PErz5EsP8GeqIk33zyQMLE9A/pyqMuv0s6sM=; b=CIJfN1MeGUOAKaZxmZ5zMlAGSmRHzl4KtCHnPFFom7okM7tgQXlPzehIFOdCnZ6lCc IqlsL8yVCE9jeJnKLymRXlUDvhGwEqyCvmNmJGzLHHKRQE3NEKJXEeNrcCY/oMHpxmOD alElMv54pxepwb8UzLRSd3wgNZSfVHNDjqR7XxWJPHP2pC4SmghdiGGlcC9z7ZdC8njZ ORb7dnlHgoKgI9LUy+WDrfbSnvdfakDEKFU0TuoBPdJh02mX4N7Y8eiYDsBz/fw2xBgF ePB3pH7Xe0rPwwyUXliu98jkGkWfpsU8qJjvn3WV0KRhRHYlmkfMIrvKNi0airMqJR42 rV/A== X-Gm-Message-State: AC+VfDxud3T0AXQZrEt/xZyT1Z2rxNGB0XEGQ4dNOZfYNA6Ahe8rZ/60 RurDi6RqBpL7j1+eHTIbO4LaB6VSsPlym9Rw6VY2nA== X-Google-Smtp-Source: ACHHUZ49vW6yPbB7Gh4GwX72q5ii/XfoaX2lB07tpchKTQ4KhhRMVciml5i5TyCjo/e84PcW5kzYYA== X-Received: by 2002:a05:6a20:c90b:b0:10b:cb87:f5e with SMTP id gx11-20020a056a20c90b00b0010bcb870f5emr6468478pzb.45.1685631700432; Thu, 01 Jun 2023 08:01:40 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 08:01:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH 25/25] net/txgbe: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:06 -0700 Message-Id: <20230601150106.18375-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Suggested by devtools/cocci/strlcpy-with-header.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev_vf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c index 3b1f7c913b7b..376357a23648 100644 --- a/drivers/net/txgbe/txgbe_ethdev_vf.c +++ b/drivers/net/txgbe/txgbe_ethdev_vf.c @@ -357,9 +357,9 @@ static int txgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, if (xstats_names != NULL) for (i = 0; i < TXGBEVF_NB_XSTATS; i++) - snprintf(xstats_names[i].name, - sizeof(xstats_names[i].name), - "%s", rte_txgbevf_stats_strings[i].name); + strlcpy(xstats_names[i].name, + rte_txgbevf_stats_strings[i].name, + sizeof(xstats_names[i].name)); return TXGBEVF_NB_XSTATS; }