diff mbox series

[v2,45/71] event/dlb2: replace use of fixed size rte_memcpy

Message ID	20240301171707.95242-46-stephen@networkplumber.org (mailing list archive)
State	Superseded
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Abdullah Sevincer <abdullah.sevincer@intel.com> Subject: [PATCH v2 45/71] event/dlb2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:41 -0800 Message-ID: <20240301171707.95242-46-stephen@networkplumber.org> In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace use of fixed size rte_mempcy \| [v2,00/71] replace use of fixed size rte_mempcy [v2,01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy [v2,02/71] eal: replace use of fixed size rte_memcpy [v2,03/71] ethdev: replace use of fixed size rte_memcpy [v2,04/71] eventdev: replace use of fixed size rte_memcpy [v2,05/71] cryptodev: replace use of fixed size rte_memcpy [v2,06/71] ip_frag: replace use of fixed size rte_memcpy [v2,07/71] net: replace use of fixed size rte_memcpy [v2,08/71] lpm: replace use of fixed size rte_memcpy [v2,09/71] node: replace use of fixed size rte_memcpy [v2,10/71] pdcp: replace use of fixed size rte_memcpy [v2,11/71] pipeline: replace use of fixed size rte_memcpy [v2,12/71] rib: replace use of fixed size rte_memcpy [v2,13/71] security: replace use of fixed size rte_memcpy [v2,14/71] net/mlx5: replace use of fixed size rte_memcpy [v2,15/71] net/nfp: replace use of fixed size rte_memcpy [v2,16/71] net/ngbe: replace use of fixed size rte_memcpy [v2,17/71] net/null: replace use of fixed size rte_memcpy [v2,18/71] net/pcap: replace use of fixed size rte_memcpy [v2,19/71] net/sfc: replace use of fixed size rte_memcpy [v2,20/71] net/tap: replace use of fixed size rte_memcpy [v2,21/71] net/txgbe: replace use of fixed size rte_memcpy [v2,22/71] raw/ifpga: replace use of fixed size rte_memcpy [v2,23/71] raw/skeleton: replace use of fixed size rte_memcpy [v2,24/71] net/hns3: replace use of fixed size rte_memcpy [v2,25/71] net/i40e: replace use of fixed size rte_memcpy [v2,26/71] net/iavf: replace use of fixed size rte_memcpy [v2,27/71] net/ice: replace use of fixed size rte_memcpy [v2,28/71] net/idpf: replace use of fixed size rte_memcpy [v2,29/71] net/ipn3ke: replace use of fixed size rte_memcpy [v2,30/71] net/ixgbe: replace use of fixed size rte_memcpy [v2,31/71] net/memif: replace use of fixed size rte_memcpy [v2,32/71] net/qede: replace use of fixed size rte_memcpy [v2,33/71] baseband/acc: replace use of fixed size rte_memcpy [v2,34/71] baseband/la12xx: replace use of fixed size rte_memcpy [v2,35/71] common/idpf: replace use of fixed size rte_memcpy [v2,36/71] common/qat: replace use of fixed size rte_memcpy [v2,37/71] compress/qat: replace use of fixed size rte_memcpy [v2,38/71] crypto/ccp: replace use of fixed size rte_memcpy [v2,39/71] crypto/cnxk: replace use of fixed size rte_memcpy [v2,40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy [v2,41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy [v2,42/71] crypto/qat: replace use of fixed size rte_memcpy [v2,43/71] crypto/scheduler: replace use of fixed size rte_memcpy [v2,44/71] event/cnxk: replace use of fixed size rte_memcpy [v2,45/71] event/dlb2: replace use of fixed size rte_memcpy [v2,46/71] event/dpaa2: replace use of fixed size rte_memcpy [v2,47/71] event/octeontx: replace use of fixed size rte_memcpy [v2,48/71] mempool/dpaa: replace use of fixed size rte_memcpy [v2,49/71] mempool/dpaa2: replace use of fixed size rte_memcpy [v2,50/71] ml/cnxk: replace use of fixed size rte_memcpy [v2,51/71] net/af_xdp: replace use of fixed size rte_memcpy [v2,52/71] net/avp: replace use of fixed size rte_memcpy [v2,53/71] net/axgbe: replace use of fixed size rte_memcpy [v2,54/71] net/bnx2x: replace use of fixed size rte_memcpy [v2,55/71] net/bnxt: replace use of fixed size rte_memcpy [v2,56/71] net/bonding: replace use of fixed size rte_memcpy [v2,57/71] net/cnxk: replace use of fixed size rte_memcpy [v2,58/71] net/cpfl: replace use of fixed size rte_memcpy [v2,59/71] net/cxgbe: replace use of fixed size rte_memcpy [v2,60/71] net/dpaa2: replace use of fixed size rte_memcpy [v2,61/71] net/e1000: replace use of fixed size rte_memcpy [v2,62/71] net/enic: replace use of fixed size rte_memcpy [v2,63/71] net/failsafe: replace use of fixed size rte_memcpy [v2,64/71] net/gve/base: replace use of fixed size rte_memcpy [v2,65/71] net/hinic: replace use of fixed size rte_memcpy [v2,66/71] net/mvpp2: replace use of fixed size rte_memcpy [v2,67/71] app/test-pmd: replace use of fixed size rte_memcpy [v2,68/71] app/graph: replace use of fixed size rte_memcpy [v2,69/71] app/test-eventdev: replace use of fixed size rte_memcpy [v2,70/71] app/test: replace use of fixed size rte_memcpy [v2,71/71] examples: replace use of fixed size rte_memcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger March 1, 2024, 5:15 p.m. UTC

  Automatically generated by devtools/cocci/rte_memcpy.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/event/dlb2/dlb2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sevincer, Abdullah March 5, 2024, 5:07 p.m. UTC | #1

Hi Stephen,

Are all rte_memcpy functions now be replaced by memcpy and no more use of rte_memcpy?

Stephen Hemminger March 5, 2024, 6:30 p.m. UTC | #2

On Tue, 5 Mar 2024 17:07:02 +0000
"Sevincer, Abdullah" <abdullah.sevincer@intel.com> wrote:

> Hi Stephen,
> 
> Are all rte_memcpy functions now be replaced by memcpy and no more use of rte_memcpy?
> 

Long term yes. There is no reason for rte_memcpy to exist, it only exists because
the DPDK team at Intel was able to get a faster result for bulk copies than
the current glibc versions.

Medium term, it would be good to kill rte_memcpy for the fixed size case.
Already done for several other architectures.

Short term, none of this is urgent.

Sevincer, Abdullah March 6, 2024, 3:24 p.m. UTC | #3

Acked-by: Abdullah Sevincer <abdullah.sevincer@intel.com>

diff mbox series

Patch

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 271bbce54a3a..5c1cd35dbda6 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -225,7 +225,7 @@  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
 	handle->info.hw_rsrc_max.reorder_window_size =
 		dlb2->hw_rsrc_query_results.num_hist_list_entries;
 
-	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info));
+	memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info));
 
 	return 0;
 }
@@ -1671,7 +1671,7 @@  dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2,
 	qm_port->issued_releases = 0;
 
 	/* Save config message too. */
-	rte_memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb));
+	memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb));
 
 	/* update state */
 	qm_port->state = PORT_STARTED; /* enabled at create time */
@@ -1872,7 +1872,7 @@  dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2,
 	qm_port->issued_releases = 0;
 
 	/* Save config message too. */
-	rte_memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir));
+	memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir));
 
 	/* update state */
 	qm_port->state = PORT_STARTED; /* enabled at create time */