diff mbox series

[v2,29/71] net/ipn3ke: replace use of fixed size rte_memcpy

Message ID	20240301171707.95242-30-stephen@networkplumber.org (mailing list archive)
State	Superseded
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Rosen Xu <rosen.xu@intel.com> Subject: [PATCH v2 29/71] net/ipn3ke: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:25 -0800 Message-ID: <20240301171707.95242-30-stephen@networkplumber.org> In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace use of fixed size rte_mempcy \| [v2,00/71] replace use of fixed size rte_mempcy [v2,01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy [v2,02/71] eal: replace use of fixed size rte_memcpy [v2,03/71] ethdev: replace use of fixed size rte_memcpy [v2,04/71] eventdev: replace use of fixed size rte_memcpy [v2,05/71] cryptodev: replace use of fixed size rte_memcpy [v2,06/71] ip_frag: replace use of fixed size rte_memcpy [v2,07/71] net: replace use of fixed size rte_memcpy [v2,08/71] lpm: replace use of fixed size rte_memcpy [v2,09/71] node: replace use of fixed size rte_memcpy [v2,10/71] pdcp: replace use of fixed size rte_memcpy [v2,11/71] pipeline: replace use of fixed size rte_memcpy [v2,12/71] rib: replace use of fixed size rte_memcpy [v2,13/71] security: replace use of fixed size rte_memcpy [v2,14/71] net/mlx5: replace use of fixed size rte_memcpy [v2,15/71] net/nfp: replace use of fixed size rte_memcpy [v2,16/71] net/ngbe: replace use of fixed size rte_memcpy [v2,17/71] net/null: replace use of fixed size rte_memcpy [v2,18/71] net/pcap: replace use of fixed size rte_memcpy [v2,19/71] net/sfc: replace use of fixed size rte_memcpy [v2,20/71] net/tap: replace use of fixed size rte_memcpy [v2,21/71] net/txgbe: replace use of fixed size rte_memcpy [v2,22/71] raw/ifpga: replace use of fixed size rte_memcpy [v2,23/71] raw/skeleton: replace use of fixed size rte_memcpy [v2,24/71] net/hns3: replace use of fixed size rte_memcpy [v2,25/71] net/i40e: replace use of fixed size rte_memcpy [v2,26/71] net/iavf: replace use of fixed size rte_memcpy [v2,27/71] net/ice: replace use of fixed size rte_memcpy [v2,28/71] net/idpf: replace use of fixed size rte_memcpy [v2,29/71] net/ipn3ke: replace use of fixed size rte_memcpy [v2,30/71] net/ixgbe: replace use of fixed size rte_memcpy [v2,31/71] net/memif: replace use of fixed size rte_memcpy [v2,32/71] net/qede: replace use of fixed size rte_memcpy [v2,33/71] baseband/acc: replace use of fixed size rte_memcpy [v2,34/71] baseband/la12xx: replace use of fixed size rte_memcpy [v2,35/71] common/idpf: replace use of fixed size rte_memcpy [v2,36/71] common/qat: replace use of fixed size rte_memcpy [v2,37/71] compress/qat: replace use of fixed size rte_memcpy [v2,38/71] crypto/ccp: replace use of fixed size rte_memcpy [v2,39/71] crypto/cnxk: replace use of fixed size rte_memcpy [v2,40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy [v2,41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy [v2,42/71] crypto/qat: replace use of fixed size rte_memcpy [v2,43/71] crypto/scheduler: replace use of fixed size rte_memcpy [v2,44/71] event/cnxk: replace use of fixed size rte_memcpy [v2,45/71] event/dlb2: replace use of fixed size rte_memcpy [v2,46/71] event/dpaa2: replace use of fixed size rte_memcpy [v2,47/71] event/octeontx: replace use of fixed size rte_memcpy [v2,48/71] mempool/dpaa: replace use of fixed size rte_memcpy [v2,49/71] mempool/dpaa2: replace use of fixed size rte_memcpy [v2,50/71] ml/cnxk: replace use of fixed size rte_memcpy [v2,51/71] net/af_xdp: replace use of fixed size rte_memcpy [v2,52/71] net/avp: replace use of fixed size rte_memcpy [v2,53/71] net/axgbe: replace use of fixed size rte_memcpy [v2,54/71] net/bnx2x: replace use of fixed size rte_memcpy [v2,55/71] net/bnxt: replace use of fixed size rte_memcpy [v2,56/71] net/bonding: replace use of fixed size rte_memcpy [v2,57/71] net/cnxk: replace use of fixed size rte_memcpy [v2,58/71] net/cpfl: replace use of fixed size rte_memcpy [v2,59/71] net/cxgbe: replace use of fixed size rte_memcpy [v2,60/71] net/dpaa2: replace use of fixed size rte_memcpy [v2,61/71] net/e1000: replace use of fixed size rte_memcpy [v2,62/71] net/enic: replace use of fixed size rte_memcpy [v2,63/71] net/failsafe: replace use of fixed size rte_memcpy [v2,64/71] net/gve/base: replace use of fixed size rte_memcpy [v2,65/71] net/hinic: replace use of fixed size rte_memcpy [v2,66/71] net/mvpp2: replace use of fixed size rte_memcpy [v2,67/71] app/test-pmd: replace use of fixed size rte_memcpy [v2,68/71] app/graph: replace use of fixed size rte_memcpy [v2,69/71] app/test-eventdev: replace use of fixed size rte_memcpy [v2,70/71] app/test: replace use of fixed size rte_memcpy [v2,71/71] examples: replace use of fixed size rte_memcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger March 1, 2024, 5:15 p.m. UTC

  Automatically generated by devtools/cocci/rte_memcpy.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ipn3ke/ipn3ke_flow.c        | 32 ++++++++++++-------------
 drivers/net/ipn3ke/ipn3ke_representor.c | 16 ++++++-------
 drivers/net/ipn3ke/ipn3ke_tm.c          |  6 ++---
 3 files changed, 26 insertions(+), 28 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c
index d20a29b9a2d6..eeb0ec55d9a6 100644
--- a/drivers/net/ipn3ke/ipn3ke_flow.c
+++ b/drivers/net/ipn3ke/ipn3ke_flow.c
@@ -100,15 +100,14 @@  ipn3ke_pattern_vxlan(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_ETH:
 			eth = item->spec;
 
-			rte_memcpy(&parser->key[0],
-					eth->hdr.src_addr.addr_bytes,
-					RTE_ETHER_ADDR_LEN);
+			memcpy(&parser->key[0], eth->hdr.src_addr.addr_bytes,
+			       RTE_ETHER_ADDR_LEN);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_VXLAN:
 			vxlan = item->spec;
 
-			rte_memcpy(&parser->key[6], vxlan->hdr.vni, 3);
+			memcpy(&parser->key[6], vxlan->hdr.vni, 3);
 			break;
 
 		default:
@@ -164,9 +163,8 @@  ipn3ke_pattern_mac(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_ETH:
 			eth = item->spec;
 
-			rte_memcpy(parser->key,
-					eth->hdr.src_addr.addr_bytes,
-					RTE_ETHER_ADDR_LEN);
+			memcpy(parser->key, eth->hdr.src_addr.addr_bytes,
+			       RTE_ETHER_ADDR_LEN);
 			break;
 
 		default:
@@ -369,13 +367,13 @@  ipn3ke_pattern_ip_tcp(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_IPV4:
 			ipv4 = item->spec;
 
-			rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
+			memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_TCP:
 			tcp = item->spec;
 
-			rte_memcpy(&parser->key[4], &tcp->hdr.src_port, 2);
+			memcpy(&parser->key[4], &tcp->hdr.src_port, 2);
 			break;
 
 		default:
@@ -434,13 +432,13 @@  ipn3ke_pattern_ip_udp(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_IPV4:
 			ipv4 = item->spec;
 
-			rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
+			memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_UDP:
 			udp = item->spec;
 
-			rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2);
+			memcpy(&parser->key[4], &udp->hdr.src_port, 2);
 			break;
 
 		default:
@@ -502,19 +500,19 @@  ipn3ke_pattern_ip_nvgre(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_IPV4:
 			ipv4 = item->spec;
 
-			rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
+			memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_UDP:
 			udp = item->spec;
 
-			rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2);
+			memcpy(&parser->key[4], &udp->hdr.src_port, 2);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_NVGRE:
 			nvgre = item->spec;
 
-			rte_memcpy(&parser->key[6], nvgre->tni, 3);
+			memcpy(&parser->key[6], nvgre->tni, 3);
 			break;
 
 		default:
@@ -576,19 +574,19 @@  ipn3ke_pattern_vxlan_ip_udp(const struct rte_flow_item patterns[],
 		case RTE_FLOW_ITEM_TYPE_VXLAN:
 			vxlan = item->spec;
 
-			rte_memcpy(&parser->key[0], vxlan->hdr.vni, 3);
+			memcpy(&parser->key[0], vxlan->hdr.vni, 3);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_IPV4:
 			ipv4 = item->spec;
 
-			rte_memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4);
+			memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4);
 			break;
 
 		case RTE_FLOW_ITEM_TYPE_UDP:
 			udp = item->spec;
 
-			rte_memcpy(&parser->key[7], &udp->hdr.src_port, 2);
+			memcpy(&parser->key[7], &udp->hdr.src_port, 2);
 			break;
 
 		default:
diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index 8145f1bb2a0e..99527d18793a 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -137,17 +137,17 @@  ipn3ke_rpst_dev_start(struct rte_eth_dev *dev)
 
 	if (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) {
 		/* Set mac address */
-		rte_memcpy(((char *)(&val)),
-			(char *)&dev->data->mac_addrs->addr_bytes[0],
-			sizeof(uint32_t));
+		memcpy(((char *)(&val)),
+		       (char *)&dev->data->mac_addrs->addr_bytes[0],
+		       sizeof(uint32_t));
 		(*hw->f_mac_write)(hw,
 				val,
 				IPN3KE_MAC_PRIMARY_MAC_ADDR0,
 				rpst->port_id,
 				0);
-		rte_memcpy(((char *)(&val)),
-			(char *)&dev->data->mac_addrs->addr_bytes[4],
-			sizeof(uint16_t));
+		memcpy(((char *)(&val)),
+		       (char *)&dev->data->mac_addrs->addr_bytes[4],
+		       sizeof(uint16_t));
 		(*hw->f_mac_write)(hw,
 				val,
 				IPN3KE_MAC_PRIMARY_MAC_ADDR1,
@@ -2753,13 +2753,13 @@  ipn3ke_rpst_mac_addr_set(struct rte_eth_dev *ethdev,
 		rte_ether_addr_copy(&mac_addr[0], &rpst->mac_addr);
 
 		/* Set mac address */
-		rte_memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t));
+		memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t));
 		(*hw->f_mac_write)(hw,
 				val,
 				IPN3KE_MAC_PRIMARY_MAC_ADDR0,
 				rpst->port_id,
 				0);
-		rte_memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t));
+		memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t));
 		(*hw->f_mac_write)(hw,
 				val,
 				IPN3KE_MAC_PRIMARY_MAC_ADDR0,
diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c
index 0260227900ae..b7097083d2d6 100644
--- a/drivers/net/ipn3ke/ipn3ke_tm.c
+++ b/drivers/net/ipn3ke/ipn3ke_tm.c
@@ -814,7 +814,7 @@  ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev,
 				rte_strerror(EINVAL));
 	} else {
 		sp->valid = 1;
-		rte_memcpy(&sp->params, profile, sizeof(sp->params));
+		memcpy(&sp->params, profile, sizeof(sp->params));
 	}
 
 	tm->h.n_shaper_profiles++;
@@ -960,7 +960,7 @@  ipn3ke_tm_tdrop_profile_add(struct rte_eth_dev *dev,
 			IPN3KE_TDROP_TH2_MASK);
 	tp->th1 = th1;
 	tp->th2 = th2;
-	rte_memcpy(&tp->params, profile, sizeof(tp->params));
+	memcpy(&tp->params, profile, sizeof(tp->params));
 
 	/* Add to list */
 	tm->h.n_tdrop_profiles++;
@@ -1308,7 +1308,7 @@  ipn3ke_tm_node_add(struct rte_eth_dev *dev,
 		n->tdrop_profile = ipn3ke_hw_tm_tdrop_profile_search(hw,
 			params->leaf.wred.wred_profile_id);
 
-	rte_memcpy(&n->params, params, sizeof(n->params));
+	memcpy(&n->params, params, sizeof(n->params));
 
 	return 0;
 }