From patchwork Fri Mar 1 17:14:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137691 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE94F43C12; Fri, 1 Mar 2024 18:17:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA55542FF1; Fri, 1 Mar 2024 18:17:19 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 0657042FE9 for ; Fri, 1 Mar 2024 18:17:18 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dc9222b337so23651385ad.2 for ; Fri, 01 Mar 2024 09:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313437; x=1709918237; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6uhYXuFO0hkzj3eBHFdCdGhcudl4GtPWett1S7Oeck=; b=xBXw7S2XkOXjkOWhI/0x3lVQFRWSL4FlkrO6/oGOCSG9ysQ0RN2TgNnWv8mvU8Kbn0 9dcuDRVPn7NnEq6/xnKDbGBmKEsP2gNVwyZ8/LSWZ66qbdOs5GOkHZ8Py83P9nDAB53a ztieT9x0uA8OwHgBP7k/9sF+QixjuKp4AszMC1aRIETs2toHqOfmn3sB8aOa9UYqmMRS SX9BfsU9kLKIiZNF3IuwafIB0Esd5t2d2+M+ubH/cnZpDmO9EQnAvNcOlAhZyOHsPhEK 695f+NHki0OjfGyvCpMh8k4EEVqpkFFlUMSGr4QY2vVDHTCxKjiZXtoffILIsHm0qpnZ VClA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313437; x=1709918237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g6uhYXuFO0hkzj3eBHFdCdGhcudl4GtPWett1S7Oeck=; b=WrVujpnzlSy6JoUdXp9NZ7+8llMFubXec4yxbpZ3wjt0Ef+1pPZ/8oSJPDWUnzcbtz CxUboOJNNAYmtlK0+sAwMMAGFwg/3uuBVappC7oe6ZyN7HwY9DUrk4as0oa6b7xPMLvQ F3ybChNtLXMj0g1k1YHRnggrJlWB7DPBMSp8taLEtwIm8fxBF+FK8h7OaS8mYjWGyhns ym84quPalb/CTVMm2C+kg1CGhUspYmVNfs8pwsUW8eI0NRLuTtz7UQTjMfGNpGaYWdS4 G1BHMAFMAPllK9Jhs/2dWaHlzhpzSBJewPSrHwqTHbtRiGeesMbBGaQ8KEaRR6SRDQ03 z+BQ== X-Gm-Message-State: AOJu0YxMeSZs5ue7V1txMnWAWHsUsghKx03p8BfnBG0tw4wU9c7saodc liK/Lt+3ZfOdyOkwNHBCbJg+mWHF0HDxVKl6Evk5MSucyBWeN//tK4HaNCXZYHPaIshYvYJMRp7 v9FiWUw== X-Google-Smtp-Source: AGHT+IFGfq40YCM+AIUzkRAQWFVeLPkBU7itYUMw/5ANJ8JPQi66fRqSKngNJ8jD66fsqHeuth3k+g== X-Received: by 2002:a17:902:7c0f:b0:1dc:69ab:7dc0 with SMTP id x15-20020a1709027c0f00b001dc69ab7dc0mr1886285pll.27.1709313437164; Fri, 01 Mar 2024 09:17:17 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:14:57 -0800 Message-ID: <20240301171707.95242-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rte_memcpy should not be used for the simple case of copying a fix size structure because it is slower and will hide problems from code analysis tools. Coverity, fortify and other analyzers special case memcpy(). Gcc (and Clang) are smart enough to inline copies which will be faster. Signed-off-by: Stephen Hemminger --- devtools/cocci/rte_memcpy.cocci | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 devtools/cocci/rte_memcpy.cocci diff --git a/devtools/cocci/rte_memcpy.cocci b/devtools/cocci/rte_memcpy.cocci new file mode 100644 index 000000000000..fa1038fc066d --- /dev/null +++ b/devtools/cocci/rte_memcpy.cocci @@ -0,0 +1,11 @@ +// +// rte_memcpy should not be used for simple fixed size structure +// because compiler's are smart enough to inline these. +// +@@ +expression src, dst; constant size; +@@ +( +- rte_memcpy(dst, src, size) ++ memcpy(dst, src, size) +) From patchwork Fri Mar 1 17:14:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137692 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E94A43C12; Fri, 1 Mar 2024 18:17:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66566432CC; Fri, 1 Mar 2024 18:17:22 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id BB98B42FE9 for ; Fri, 1 Mar 2024 18:17:18 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d7232dcb3eso18698355ad.2 for ; Fri, 01 Mar 2024 09:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313438; x=1709918238; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EFwKhKzbWxIKE4LKzTUwAw7ItEgO/nVUD+Tiqa1uL1U=; b=dG2A/CG13UYg5kXcWRVYYJeZlJSQBF7eimtwimtTdiV99hfBTUxo+p/Gx+rPr6OT4d NB0Jjd4ZUU2gwhFz5ho456CsfzYiHXlLe6A7UltcOs9+zY7dZeD/ORpLdYyktroqKCI3 XM0Z8GxxOWoufBczcV3CYqzizDf/6PyFvNYHle1m/bfrov9nVXAgI0AYltDI4PLz4PTr f6tHC0pGaNbokYX3dN+/h0MwnapJepbhcX2lgOsjndn9Xu1FhB4orl7AzU8VKDS5Ux1S MX2pCZ+ChPJFa4tEL7mS0gUD+OEm9vohnRY/CGvSzcrPteZgh8uTTfVcsL7kGH3bWb3e kpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313438; x=1709918238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EFwKhKzbWxIKE4LKzTUwAw7ItEgO/nVUD+Tiqa1uL1U=; b=Nbot81cZ9zCAJfwDwimOTDT3qv9Ge4LXiUv/cigQEh4/Pd/cGkryGT6bF02wxee5NN WLW8ljRXqDmBQ6g9G7IHHfOkM07Il46/5i9G597mJgqGKErmJJwv5T1tMU32QzUcSsx/ n0QM+P8KA/UjeJ2LQuXAH9H9NPRD0ETE2wnFsdIFSUY34fwpWuCpUhZ72J37bN7aMNjt rfCoDsRFJdDF3sH/SnhmBpitk+2JO4L/69IgadNpjm8Fr7wd2e1y6UufgYG2hJ6ML7KM mo7nxPLRgMRlq+JT59DTGmm37BTm2/ZFPv07vuUWIftYmI5B5BlfCasQ/Va9sD1fa0eO unBQ== X-Gm-Message-State: AOJu0YxHszOcy+3ydK/nRBHMNuKM4rv2viVUEQ14/yTLBssjIHkTPCMk IuGW7brn7fe4IPeotFRRBcRCgTdio3jXr0Drn3kmygwgthIHt4zOa5xgFYodHTRb21fzgxfsPuy mi0HxtA== X-Google-Smtp-Source: AGHT+IGwsQZawbNWAf3WnPd/LldWmFALxsL8wmJ0wTGXZUfVfA7uuq2A39JdqUBwRkSZBU9BJWquAA== X-Received: by 2002:a17:902:d4cd:b0:1db:def5:17f8 with SMTP id o13-20020a170902d4cd00b001dbdef517f8mr2528932plg.9.1709313437992; Fri, 01 Mar 2024 09:17:17 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 02/71] eal: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:14:58 -0800 Message-ID: <20240301171707.95242-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index e541f0793964..07bfaffdac76 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -30,7 +30,6 @@ #include #include #include -#include #ifndef RTE_EXEC_ENV_WINDOWS #include #endif @@ -1253,7 +1252,7 @@ eal_parse_lcores(const char *lcores) /* without '@', by default using lcore_set as cpuset */ if (*lcores != '@') - rte_memcpy(&cpuset, &lcore_set, sizeof(cpuset)); + memcpy(&cpuset, &lcore_set, sizeof(cpuset)); set_count = CPU_COUNT(&lcore_set); /* start to update lcore_set */ @@ -1275,8 +1274,8 @@ eal_parse_lcores(const char *lcores) if (check_cpuset(&cpuset) < 0) goto err; - rte_memcpy(&lcore_config[idx].cpuset, &cpuset, - sizeof(rte_cpuset_t)); + memcpy(&lcore_config[idx].cpuset, &cpuset, + sizeof(rte_cpuset_t)); } /* some cores from the lcore_set can't be handled by EAL */ From patchwork Fri Mar 1 17:14:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137693 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9126E43C12; Fri, 1 Mar 2024 18:17:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFDD8432D6; Fri, 1 Mar 2024 18:17:23 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id AC88642FF9 for ; Fri, 1 Mar 2024 18:17:19 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d95d67ff45so20173385ad.2 for ; Fri, 01 Mar 2024 09:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313439; x=1709918239; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K+KGhTbHEnBZ+LWTV2nbhkUGGI/qctogtFJZDjHHhJo=; b=QSPrzs3NPbeoUaWrlj6LM5rEEYR716u85qTFrX/wbFMET5A6wKW9V9IpTcRtqR1eWd noxiL0o8PEekFfCAuYAw8LFbSuEXGHh8GP3gwLcYLPOmf4MJjp7M+2Y2HFk6iBCpxv+D q8cqSJZQQ6QHxNMswqW4QadGnzksQuC8Q31spuFA/r5Mx18cAsfBDgE9G/XDBkJWpDCu deC8MfUIeiM5hGyDUsjPipEp9IPrGekIF2oUcsdU+0KnKMCSvESnvhpN2JIPY2rbQVw2 ykqr/BPHT6pq6+/pK9LYF/oBOwxavi9cOXQdbZsFIOf8N/Q9H8rkqT5dYOP840ks6IgG RZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313439; x=1709918239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K+KGhTbHEnBZ+LWTV2nbhkUGGI/qctogtFJZDjHHhJo=; b=h+WxEpGsZ+VAlMb57lrauHQEoEpvJ6N42sE5yJD7ZEC3st67xQbCJlmY1IJ2CXIKg1 hG/10+IZH+RRH/ws+2HzV2FxYppSDlutCchSO8yisQc4eI5jXfX1xxd/0+uJg+pU+lep TrmJW0jPiUTWw+GLqheN7P5BbHmQgJyYcZjVpODFJHLRK70FXAlVmHxlINP1ssXFIQDc ObH4GEAGQs2oHroj52TLY/ITR80mGXXcv52SDibJFEjPGW7oScWMVYBaG1wEWtdU+h3m iXnp8ubrE16R8NtsraobhjGuYL3PA7TbL49Ix+030zlUF1hwZkaavNrw8wE1YgmzCti5 Cyuw== X-Gm-Message-State: AOJu0YzSGC4b9rdcUzpPQNod+yL5QCdDm7BO1lhfAugQgeTaemvRd4Xy XpLXmZpEASix9+pGxpGM+6FUTZyrEn26PIIxklBnjvIXtD1yzUDq4EW+NDysHwpGiyjUSEsb8S3 SqQ+Baw== X-Google-Smtp-Source: AGHT+IEHrBAqdXx3uO91qF1nbrmfkQXdyAUZWvxXIwdzB/yMm66G0c80O9U2atK1hr02lbLVxDYpVA== X-Received: by 2002:a17:903:2292:b0:1dc:248:28e6 with SMTP id b18-20020a170903229200b001dc024828e6mr2813555plh.67.1709313438898; Fri, 01 Mar 2024 09:17:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ori Kam Subject: [PATCH v2 03/71] ethdev: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:14:59 -0800 Message-ID: <20240301171707.95242-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- lib/ethdev/rte_flow.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index f1c658f49e80..ef62a0260747 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -618,7 +617,7 @@ rte_eth_dev_owner_get(const uint16_t port_id, struct rte_eth_dev_owner *owner) rte_spinlock_lock(rte_mcfg_ethdev_get_lock()); if (eth_dev_shared_data_prepare() != NULL) { - rte_memcpy(owner, ðdev->data->owner, sizeof(*owner)); + memcpy(owner, ðdev->data->owner, sizeof(*owner)); ret = 0; } else { ret = -ENOMEM; diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 7ab1100ea049..9b831486eb5e 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -994,9 +994,8 @@ rte_flow_conv_rule(struct rte_flow_conv_rule *dst, if (src->attr_ro) { off = RTE_ALIGN_CEIL(off, sizeof(double)); if (size && size >= off + sizeof(*dst->attr)) - dst->attr = rte_memcpy - ((void *)((uintptr_t)dst + off), - src->attr_ro, sizeof(*dst->attr)); + dst->attr = memcpy((void *)((uintptr_t)dst + off), + src->attr_ro, sizeof(*dst->attr)); off += sizeof(*dst->attr); } if (src->pattern_ro) { From patchwork Fri Mar 1 17:15:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137694 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DFD43C12; Fri, 1 Mar 2024 18:17:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D11EB432F6; Fri, 1 Mar 2024 18:17:24 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 6AF7443248 for ; Fri, 1 Mar 2024 18:17:20 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dc75972f25so21372125ad.1 for ; Fri, 01 Mar 2024 09:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313439; x=1709918239; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LQIpOajtBvS65bWVKmyCoedN6gPZpkpUHetRqJFg3sI=; b=1+sDViOq2IelcuSaSPHXzd+R8LMCiabebyysoswZbmZuZIrE/f9pDNoat9M3/GNFM5 fPzAH8/KJlG1FFEtw2rJ3+WGjpncIcN8otC21EKxU/4sjbsgSdPaonUbjRLY2smFS1kV BWJ5jufkz9NN5QJ6WsLC4sHOd7OoShqKuirUgqRoRyrKqiAcTNTA/fYmQPzdc73jm06A FglSlqZ+ymAlTtNqcy/cTnS1vyTpOSBpagsJVmb7Elki9zUSB1uR9eJZ7KPXq1bbNk/1 CndTvI5OwfBiHfjDK4oko+h5kfvcNrXkmR5NfSViOOPrB3E22wBXH46iBZRFHTabr2xW JVxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313439; x=1709918239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LQIpOajtBvS65bWVKmyCoedN6gPZpkpUHetRqJFg3sI=; b=IvK4LXtjCkQ+KGiIrdpFLOfvoa9i3+qQc9sz6QnbtWiefwsSRkivTjuxZi8yRIemF+ NoVdZm5zF7FFPtJ9Blu12EzBh98mpJkVIhuZdltd0mQSpP4zuv1rAITE4bETmDsM2OQD GM2QVSwhN0PeLpieLPS15Rxfh0bBpQK0773bcEij/63shsr1MH9p/Lw+nduyfq9D/HsC MaU73L2ihUJywtpsL6j2fA9C5cmj0/voAvYioWW/PkfXP/dgvE+mSho1XvOOVYiyBriy Lf3XDXhuhpe9L/QukUHLVoMMS/Rq9hsCAtSA7KJOgWbPjvwa/Jtr/uhOxiKLcnK/Gz8n RQ0w== X-Gm-Message-State: AOJu0YwXPrar/AJqhNnAa3lPhfDrJMSzSweN/xIQMBaYkPDM4dP1ryxu THJsot2Rd3z5LXMWKFKlOYZ/LOQxmYp9yMh6bFsevxwvyjvYsPhx0w1dMZNUGAME9e1mM7ByiXO X8q05LQ== X-Google-Smtp-Source: AGHT+IGvNnTLIhgEre6BJ+QQYj6XePhG29HjVteJARwzHcns2CEsjMBZjTtIwDH0GkdYGVP24nDn5g== X-Received: by 2002:a17:902:efc3:b0:1dc:cb04:82e8 with SMTP id ja3-20020a170902efc300b001dccb0482e8mr1846728plb.22.1709313439712; Fri, 01 Mar 2024 09:17:19 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abhinandan Gujjar , Jerin Jacob , Amit Prakash Shukla , Erik Gabriel Carrillo Subject: [PATCH v2 04/71] eventdev: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:00 -0800 Message-ID: <20240301171707.95242-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 2 +- lib/eventdev/rte_event_dma_adapter.c | 4 ++-- lib/eventdev/rte_event_timer_adapter.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c index d46595d19028..d974404abe21 100644 --- a/lib/eventdev/rte_event_crypto_adapter.c +++ b/lib/eventdev/rte_event_crypto_adapter.c @@ -647,7 +647,7 @@ eca_ops_enqueue_burst(struct event_crypto_adapter *adapter, continue; } - rte_memcpy(ev, &m_data->response_info, sizeof(*ev)); + memcpy(ev, &m_data->response_info, sizeof(*ev)); ev->event_ptr = ops[i]; ev->event_type = RTE_EVENT_TYPE_CRYPTODEV; if (adapter->implicit_release_disabled) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index 4196164305d9..c50b3d23da2d 100644 --- a/lib/eventdev/rte_event_dma_adapter.c +++ b/lib/eventdev/rte_event_dma_adapter.c @@ -447,7 +447,7 @@ rte_event_dma_adapter_create(uint8_t id, uint8_t evdev_id, struct rte_event_port if (pc == NULL) return -ENOMEM; - rte_memcpy(pc, port_config, sizeof(struct rte_event_port_conf)); + memcpy(pc, port_config, sizeof(struct rte_event_port_conf)); ret = rte_event_dma_adapter_create_ext(id, evdev_id, edma_default_config_cb, mode, pc); if (ret != 0) rte_free(pc); @@ -668,7 +668,7 @@ edma_ops_enqueue_burst(struct event_dma_adapter *adapter, struct rte_event_dma_a continue; } - rte_memcpy(ev, response_info, sizeof(struct rte_event)); + memcpy(ev, response_info, sizeof(struct rte_event)); ev->event_ptr = ops[i]; ev->event_type = RTE_EVENT_TYPE_DMADEV; if (adapter->implicit_release_disabled) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index a3c6fb772e58..a425a30f5e05 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -548,7 +548,7 @@ event_buffer_add(struct event_buffer *bufp, struct rte_event *eventp) /* Instead of modulus, bitwise AND with mask to get head_idx. */ head_idx = bufp->head & EVENT_BUFFER_MASK; buf_eventp = &bufp->events[head_idx]; - rte_memcpy(buf_eventp, eventp, sizeof(struct rte_event)); + memcpy(buf_eventp, eventp, sizeof(struct rte_event)); /* Wrap automatically when overflow occurs. */ bufp->head++; From patchwork Fri Mar 1 17:15:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137695 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A1EC43C12; Fri, 1 Mar 2024 18:18:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7794743320; Fri, 1 Mar 2024 18:17:26 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 3BE3E43281 for ; Fri, 1 Mar 2024 18:17:21 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1dcb3e6ff3fso8180295ad.2 for ; Fri, 01 Mar 2024 09:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313440; x=1709918240; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C7kfBD3djBUDJJFpAGOmlkIh8y6zpuH5vxwEnCxBnrw=; b=nKX/0GFFK2/iCShax6kh54DlW34YPgunHNk5mDVbXXah9wT1x9m8y0kVDXIEk3w3Xz MBIDuB05Cm3WmGCUJt6qJkAYWynRdEjBjxUY1FnBLlER+sy4gSDL4LNAFQmN0h+5xg9/ iI0swjgHr1TQMujKoZ/5zuf5qWRA5w9vW4PG21IeQlHsQXf9SPuxC9YDzpUY6zrY7w44 y4R+o756ZJtz18zZBjTJyG5fKko1zijCbUveO7bNCLZi7o7Q2I3t74DpM/u6Rpq7fnkf tG8EnEuX+UVeRS/L9H5U/ZE0wq3tCbKynBboDBus3d8yXUQ7LVwzkN70IVjkt1YvIyqt JkUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313440; x=1709918240; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C7kfBD3djBUDJJFpAGOmlkIh8y6zpuH5vxwEnCxBnrw=; b=r//FxwHYRqb7Rvt7KCUc/zzedvYWxJtmBQDDlxZolhzOzJ1wu5tVnpwMFofksvANFr cUdY2xzQR5BqSqPX1XJbuTMCL6DVeMdPzqWGP6sdbWOjrqwpVHf9hFcKK8OFItvqYMnB L8aqdTwAKMY7FmIYMtXM/Xv3+9FUrLAJr9DMmBDgXtHmJW5R7S7Ei6U5pExfNbI4wlsy y9mk2L2wXXNDIVsHRb71wh6C8SFibIHFSXWPJ98pcvCKk+80cg/fZhgR90dLuEZivIHD 9rUy4MDB5o2wGGOT2qG3osUYgt8Eqg2/GnkFaCihWtVwh6xSh0nZkicE/hD+EllbexH0 o+6w== X-Gm-Message-State: AOJu0YxNTaj47umEjDEFX1T9abYhgf8/ypZBmqxecxkMQkOe7pMXLuT3 FH1TDq+OtTtvMq04o/UGpYpmst1lB8VTAAqSAOZDZ+e/76iPdUevCAlGP/8mjObYxwyhOlhUaO8 C1HeL8w== X-Google-Smtp-Source: AGHT+IFqjCotHWpYu2h+dro92B/slufMgLm30j4y+jFuihIiLkNbafVXIv3I9KQUu42zPZpEOuQjpw== X-Received: by 2002:a17:903:2b03:b0:1dc:7f98:d9bf with SMTP id mc3-20020a1709032b0300b001dc7f98d9bfmr3000077plb.59.1709313440446; Fri, 01 Mar 2024 09:17:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal , Fan Zhang Subject: [PATCH v2 05/71] cryptodev: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:01 -0800 Message-ID: <20240301171707.95242-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index 886eb7adc4a9..1377777525dc 100644 --- a/lib/cryptodev/rte_cryptodev.c +++ b/lib/cryptodev/rte_cryptodev.c @@ -2854,7 +2854,7 @@ crypto_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { memset(&caps_val, 0, CRYPTO_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < CRYPTO_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } From patchwork Fri Mar 1 17:15:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137696 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23B8D43C12; Fri, 1 Mar 2024 18:18:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95D7D43338; Fri, 1 Mar 2024 18:17:27 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 122454328F for ; Fri, 1 Mar 2024 18:17:22 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dcb3e6ff3fso8180445ad.2 for ; Fri, 01 Mar 2024 09:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313441; x=1709918241; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AjTHKv757QZS7wC8lHubmHNC99iGHDbQ91APaNvFEtw=; b=RBH3W+cFEtFBB7JFsglDreorA+VeY8Am4mUDq4b5zkg+ptumN4g9yuLGZcurGT3Q5g ZJ7tzwDZhImU8owhNkoAWB8wFhNu5lx0u8m/oGj8wr7olb5/+xh0xibvtjn6CbiHZw0u zHdMcqrl54WHhqa1x3pXKXrRe1ge95IwMlCL8o4/SmBQIbGLUGRBLEx0MA1u35JzVHHq oqpMEUzBOapTcooLv2yghFhUbNJJWlu+YQc0z+GwpRZRZxr0xKt9KK9nY9GwCXo1h6aW 8T32LXkBL3k5CYFcEJXCJXHqAR2aZ/vylkVDGPNgjjrO1nM6tcwUpeZq2/Ka6jhfgGQS 9Djg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313441; x=1709918241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AjTHKv757QZS7wC8lHubmHNC99iGHDbQ91APaNvFEtw=; b=oR1IZG360nEwIc+/TlHxKFeJHb1AdzjTZdNOdLWaPOLY5H9CQHqGvwlNrCLG798/Jx +W71S1fqnsegt4O+SzBRtVc0OWMncd8tbppYO39Dhwn54S/KevNRj8qgJvKEW3XqzAZf EOomXmAmk7r2T8OBwFpX5YGs7v8umqdt1JM1YRIk19+spOr41eOYtIS8mg4JoW0/bJWs uHzz9ix66i50vptq4Num03U30eExFAWHrgtgj66h/ukIYbMvYhLIAV+rlP9n4isERaG4 kpobtSEjNBnr7vvqgamovNjxDC+OtUrSZhVExotWGhcXJuVOPmUIfo9WTEOytjELGGXs hhaQ== X-Gm-Message-State: AOJu0YwGN+yDgbHfsPPRj6NVJ74jAFlwuWzqj2wOahRPS1h5iHtGiTDL 2T1Kmc+qvAmeLbBRGzceIdpQ7/fr5caZowA/nBZSBfQSJUrD/YEaf3Lj6XDh5pHpH9KbFkG3ckP JXRBqyw== X-Google-Smtp-Source: AGHT+IGUpykCYcqsUZIZModvf+38TScgMGluoYO6SwqJROCwZRmYSfPzTnrUXCrTzV1JCv0tCnlmUw== X-Received: by 2002:a17:902:f545:b0:1db:4419:e925 with SMTP id h5-20020a170902f54500b001db4419e925mr2862444plf.1.1709313441273; Fri, 01 Mar 2024 09:17:21 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev Subject: [PATCH v2 06/71] ip_frag: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:02 -0800 Message-ID: <20240301171707.95242-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv6_fragmentation.c | 4 +--- lib/ip_frag/rte_ipv6_reassembly.c | 6 ++---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/ip_frag/rte_ipv6_fragmentation.c b/lib/ip_frag/rte_ipv6_fragmentation.c index 56696f32f851..72ce6501c864 100644 --- a/lib/ip_frag/rte_ipv6_fragmentation.c +++ b/lib/ip_frag/rte_ipv6_fragmentation.c @@ -5,8 +5,6 @@ #include #include -#include - #include "ip_frag_common.h" /** @@ -23,7 +21,7 @@ __fill_ipv6hdr_frag(struct rte_ipv6_hdr *dst, { struct rte_ipv6_fragment_ext *fh; - rte_memcpy(dst, src, sizeof(*dst)); + memcpy(dst, src, sizeof(*dst)); dst->payload_len = rte_cpu_to_be_16(len); dst->proto = IPPROTO_FRAGMENT; diff --git a/lib/ip_frag/rte_ipv6_reassembly.c b/lib/ip_frag/rte_ipv6_reassembly.c index 88863a98d1fe..663b1737a64e 100644 --- a/lib/ip_frag/rte_ipv6_reassembly.c +++ b/lib/ip_frag/rte_ipv6_reassembly.c @@ -4,8 +4,6 @@ #include -#include - #include "ip_frag_common.h" /** @@ -143,8 +141,8 @@ rte_ipv6_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl, int32_t ip_len; int32_t trim; - rte_memcpy(&key.src_dst[0], ip_hdr->src_addr, 16); - rte_memcpy(&key.src_dst[2], ip_hdr->dst_addr, 16); + memcpy(&key.src_dst[0], ip_hdr->src_addr, 16); + memcpy(&key.src_dst[2], ip_hdr->dst_addr, 16); key.id = frag_hdr->id; key.key_len = IPV6_KEYLEN; From patchwork Fri Mar 1 17:15:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137697 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1609143C12; Fri, 1 Mar 2024 18:18:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4FB043344; Fri, 1 Mar 2024 18:17:28 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id D47AE432D6 for ; Fri, 1 Mar 2024 18:17:22 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d93edfa76dso21891125ad.1 for ; Fri, 01 Mar 2024 09:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313442; x=1709918242; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Qu1uDcO72pNt9gZI74NAYZ43yqBgR5SOgUCdZ/xFmU=; b=bVtuvKtjvU2kQ9mnUHvgrwUsUbTntOOWf9vfRjQtLFDIVYdNp57PK9HlgDJhgaJbrq uzzkIHMRT4MuIF641pkMWRKirDN1UR5r0c0RKnkiMDdzhkw/kkLsfG6v8cjm6HK8Hr5Y dq4l62ARQQJPtgZF45Y1oD/6/xmloFCGpD8/PULe10cnsc4MVoZCjKQA7TEp74+SO/xK iA5MbUIqpDVbKegX5xk64DI+3Byhp7ZWK7GCCZWGVN659vRZhmK+sN324hsn24i54Gri HIwUYqOTx1mnzdBrvF2GlM2YJ1iA1RqwvaJmohmo8ZmG34n+ox6QoK81P2H0mKb515CH 6iCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313442; x=1709918242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Qu1uDcO72pNt9gZI74NAYZ43yqBgR5SOgUCdZ/xFmU=; b=WmkWRrrvq2Jr//hee6inCAlzTRvKlX4XNDz+HhFhBGpSXy8ZvQNta1oakL24Ff4fTF kk6EfkF89iF+uWBaCGOBuuwGvvrC2rrwdvTsgtg9fREk15CN0E3l1ai1z01GojKLpsTK mg4CjnETTg/muVA9N7Y8iqgMkKnarQToD7Xriq/W0C3+9IXHA1Qq+GuECo4NLTo2Y/oM nP5nrx6SLMKTjyp2aEBSMq5z6HcI57wiC2CiMl8u6L9rq9265TjykR8+f+7/bykCz+43 WbCjte6gc7ykbE9m4wXdLfWBmgAK06cIsfw862IT8y9s0Wuv7v1C5f9W0lrwQc0C2Yu0 440Q== X-Gm-Message-State: AOJu0YzvWu7YlN6HfCCfdXqL11xxRju5vfoYAsQdFUfqCj2IN4R4mnE9 QqBvDsY9D+lRSFyE3758JY0h/430fovXrAGFVy2orp3hZV6aQMXArVuuWUh6eRhPZi4X3qIqai4 XT7JePA== X-Google-Smtp-Source: AGHT+IHbH/f80wzOrSrKgzKR0VO5rl97goCnK0JIy1mIDCW8ygfiSPqdrX3rtPcM/bHyTriEdgOy9Q== X-Received: by 2002:a17:903:41c2:b0:1dc:e469:6f58 with SMTP id u2-20020a17090341c200b001dce4696f58mr3035995ple.51.1709313442070; Fri, 01 Mar 2024 09:17:22 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 07/71] net: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:03 -0800 Message-ID: <20240301171707.95242-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/rte_ether.c b/lib/net/rte_ether.c index f59c20289d37..761b38f8053f 100644 --- a/lib/net/rte_ether.c +++ b/lib/net/rte_ether.c @@ -13,7 +13,7 @@ rte_eth_random_addr(uint8_t *addr) uint64_t rand = rte_rand(); uint8_t *p = (uint8_t *)&rand; - rte_memcpy(addr, p, RTE_ETHER_ADDR_LEN); + memcpy(addr, p, RTE_ETHER_ADDR_LEN); addr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR; /* clear multicast bit */ addr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR; /* set local assignment bit */ } From patchwork Fri Mar 1 17:15:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137698 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 292C943C12; Fri, 1 Mar 2024 18:18:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1966E4334B; Fri, 1 Mar 2024 18:17:30 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id A4C4643252 for ; Fri, 1 Mar 2024 18:17:23 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e4560664b5so1934400b3a.1 for ; Fri, 01 Mar 2024 09:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313443; x=1709918243; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cge62oB2hQoJVYLWwyWpZK/rL/hv6e9die6Yf0FWap4=; b=BKzgoFMMr0cP32UP6Bd8XCu4s+NHGM4WFmojwM2/6hiD2kuGOI0ooUwt2M+4sAvey8 uaio7UV6iAeo6KSEoRmoyqn5Lb5JXWUzEWJf2X9Q/Vd3opOj6gyWtrd1WUQJI+Jko5aB 1nIpKimkWq2BKqNV6sYPNOIkX0lslDNvbltoDXGprF5h12WY/B+AbO4wyd8Df2ltz6oK UGiSiwIFBYphgKep/HaLSpBfvKAPQsDb94IHQYrkSOnAjk0okeD1qQkEkOnhDdCd9NqF avggkHbke1dWT6NxrcdZDoGIK0aQlMNC9QbfCh/5DtTYqlrPG10zhvsKANj+H0STcKJ1 b6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313443; x=1709918243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cge62oB2hQoJVYLWwyWpZK/rL/hv6e9die6Yf0FWap4=; b=IJNMFPoVGKnqN2DXlLyeRC7XhQo/IosJyky2QVTQvYldW4Fmbr917awCWVckun+KYp 1uTaOpPn5ej25zrap+kDNLyt0EXGvLgRiaHtxKXxR4vBal5oihOkNaLDX4rAZSoZoYK5 kmkK55JGi7lTTcmkQ1rsAnlFsArKafh8hAw9NWvuZ68Ivj5ztt7ebdCVQXMjHpqD2AAa BARdu260J2CW9Pxq+Qc4e2CHRKFaQkHs50KOtPj4dh4eZOqhI2R0RCtaYO69qCIm/l4C RrEJ6rL/0Q3wviFpZWgm0+P1SNdL7OcoY2IdShJaNyP6RhG6TEBH6F+oyOxBJN93TTY5 /J8A== X-Gm-Message-State: AOJu0YyFb5GRLc8U7pC1QY/XvDF+9sJg5zu/fa0Zq1IS7uVaEVm8BKvq +zAfn1HqgVqWoq9Ftn4mg8fUdsBd5SgvDR3dtm9+u9UD7Z8GK62NAm5CsagtxIwXxoJFdeDef05 92W9u2w== X-Google-Smtp-Source: AGHT+IEKEVcGw3pO3ZGqLd2uikqX5A/YpX0lP1TCfM5pLHjfHxYTts2Ykzhz5fe75YkUUXZnUkYVIQ== X-Received: by 2002:a05:6a21:a596:b0:1a0:e469:2599 with SMTP id gd22-20020a056a21a59600b001a0e4692599mr2674691pzc.13.1709313442959; Fri, 01 Mar 2024 09:17:22 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson , Vladimir Medvedkin Subject: [PATCH v2 08/71] lpm: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:04 -0800 Message-ID: <20240301171707.95242-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 271bc480dc60..3303463fbd0a 100644 --- a/lib/lpm/rte_lpm6.c +++ b/lib/lpm/rte_lpm6.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -138,7 +137,7 @@ ip6_mask_addr(uint8_t *ip, uint8_t depth) static inline void ip6_copy_addr(uint8_t *dst, const uint8_t *src) { - rte_memcpy(dst, src, RTE_LPM6_IPV6_ADDR_SIZE); + memcpy(dst, src, RTE_LPM6_IPV6_ADDR_SIZE); } /* From patchwork Fri Mar 1 17:15:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137699 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F7FE43C12; Fri, 1 Mar 2024 18:18:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4912743350; Fri, 1 Mar 2024 18:17:31 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 78C154329E for ; Fri, 1 Mar 2024 18:17:24 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1dc1e7c0e29so7904555ad.1 for ; Fri, 01 Mar 2024 09:17:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313444; x=1709918244; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IWKz5vDuhvQw5GeEv6mkSttdCRlXm2J+mfGzk12cTK4=; b=QL6ustpMRU+W5YBZSGV+L5OULZMOycWjqcg8esA6ycw99gZNT6D04Mddk1VIi6UxJH AAW3q/eX1Cn1jbyfD5UOfQXugop9EEApiZJvqfpu00KWotagIY01aRn9t1NpuDrFl1oz sNXvW+lzO1c8Xj2xrAlBUN4bclmF6cNnG7NueHztJ5+BiyofPCfynwgIdH4PDp7YefJC /bKvVkKRDn7/fPLgoQjYXUZMG9B5Q25qx6sB94DVrgkSO3045CfNMxY9EkvuZxZvwU4b FgHijuixiFKnLW/5NHW/N1mIkMMTH9EKoJr9x/Xdkt4UcCrcbWytAFnbOwskkZhsxMHh Pveg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313444; x=1709918244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IWKz5vDuhvQw5GeEv6mkSttdCRlXm2J+mfGzk12cTK4=; b=saW8pX/vnDMDT7kaytEKOMn2iPW/OSUt023M/0iW+ql+prcteYC9YZdopTumObVdzV xt0/6SuupXLabEYOZiL8XdueItGdkTt3bIQ2v6K8Gvh4DAebFYfCNhQaXQtLYxv4+Wry BHrOUmccp2aMQ7x2lKdkBN4mvgj1SXpC7CWhqduy7XSH2o8Zt15cMZToQZ5wuZyy0gwW xyr/opeE+kcQMBxGEhsKll7qun68Yr9xM/FGjwBYXUkonC6vA/AB2kx5iS6BrOHJqusq F5+D8fM24/acJjSNcmKyZIfnp94UtilVVC5AbE6K3G3Uwo4W55QmsGkg1QcdbA429C3A 3dvA== X-Gm-Message-State: AOJu0YzsJCv3BRYqmG0/mpDWTrE/AvpySHZG4BVeP5wUNPZcb9SNNrV5 m44V9YE1k1h94n7uyHU2XC9o2XlU9NOgecV54Y2DPuRUh9qD02lG0vjsOczUDo5wVknWAIojJoH f1jErxg== X-Google-Smtp-Source: AGHT+IFHFcP4xMFc2OpYwj3FhCTCX8brSQKtLu7lffZBtBuMocPXdEZ/KFCIGcoDGmlJ6qeEoNIRtw== X-Received: by 2002:a17:902:6544:b0:1dc:38c7:ba1a with SMTP id d4-20020a170902654400b001dc38c7ba1amr2030023pln.25.1709313443697; Fri, 01 Mar 2024 09:17:23 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Pavan Nikhilesh Subject: [PATCH v2 09/71] node: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:05 -0800 Message-ID: <20240301171707.95242-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/node/ip6_lookup.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c index 309964f60fd6..b8e567ccd92d 100644 --- a/lib/node/ip6_lookup.c +++ b/lib/node/ip6_lookup.c @@ -112,28 +112,28 @@ ip6_lookup_node_process_scalar(struct rte_graph *graph, struct rte_node *node, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf0, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[0], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[0], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf1 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf1, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf1, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[1], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[1], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf2 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf2, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf2, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[2], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[2], ipv6_hdr->dst_addr, 16); /* Extract DIP of mbuf3 */ ipv6_hdr = rte_pktmbuf_mtod_offset(mbuf3, struct rte_ipv6_hdr *, sizeof(struct rte_ether_hdr)); /* Extract hop_limits as ipv6 hdr is in cache */ node_mbuf_priv1(mbuf3, dyn)->ttl = ipv6_hdr->hop_limits; - rte_memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16); + memcpy(ip_batch[3], ipv6_hdr->dst_addr, 16); rte_lpm6_lookup_bulk_func(lpm6, ip_batch, next_hop, 4); From patchwork Fri Mar 1 17:15:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137700 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96FA343C12; Fri, 1 Mar 2024 18:18:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C93143356; Fri, 1 Mar 2024 18:17:32 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 5F31543287 for ; Fri, 1 Mar 2024 18:17:25 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dc0e5b223eso22793905ad.1 for ; Fri, 01 Mar 2024 09:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313444; x=1709918244; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j2GRggaBe0l63nkJ4Ur1Xfc/M4c8TdNUa8v+1VNgYSo=; b=SkCTFqaGDNn+Pm3JYORh/mUj1+XIDHxYZlRd9/6gVMVTezq6cUoRb2bKevQ7riL22o iURUXwRH8WnUPeBe1zvX33y0WkLTdRq7ePXJ6a65t3Nwn5Mf+DLU+/ZkWcSDWYWZNoI5 LvUKwVHGxRmCkCWN6eLEYkpylRM983Vh9GuFuKfBuTadGuKTYahPR5FbjiAKqyki0m8s wOBO1q/BpGDotsVx21DcAVP9m/s4HA4EPCXeffXR0vdHK2Jt5k0DADMzS/ojf/Lu2R0h Cxv2bGvaQwnGFhGpcy6PgVxw2gcBypFtlAjgQyIU23OO27e4uYL9lWEtzTaV3IvYNKcR fvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313444; x=1709918244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j2GRggaBe0l63nkJ4Ur1Xfc/M4c8TdNUa8v+1VNgYSo=; b=gpQmqrXNyhThl1EPcPMYAG+1ek0dMO2m14lVwcz+gYDnh35o+fwwZpGc0y+scD+krA mRM+eVlvnpL9iZa843/518MVNqwfLrUNvYWq/7rwiUfAyjGZEuLh0JplMS/B7lyK+yUR oumv84hph/U35UuvTAOBb1eX6fZBswBQ/EgbNT36j9EH+78/frJxcKaRpAlHOzxt3Kf9 zffSb6vrs2AX/J1silizKYpDxKiqfhGkGPZMGlJKFcsgn0G9p2gEbd0EAAL20pVleYhQ emnBNDpCs/vAIoJGQMdi4qcVkTXnSu77QK/VdKCQCipCob61neM4i/NgaD+Wssi/5a8L bwIA== X-Gm-Message-State: AOJu0Yys9sipad/sXtDuD8PpIdNAQotDhMTVXNMg0MbDrS1U0geKlrPI oyrAHpudOEvgz6IfFpgnif7VqcKyJSYJh8PCeVi6A3cJLwZ50FLOtB1B2W0JWuRPyuE3uARXsO9 BD0MEtw== X-Google-Smtp-Source: AGHT+IFFJM6Evt4kxMH8CexEAtqTIjwh3Tokjy45iTGKCMVbbQt2xT2I5hWzHmcy/ozTQobK+ZeqQg== X-Received: by 2002:a17:902:ec81:b0:1dc:cee2:5ffc with SMTP id x1-20020a170902ec8100b001dccee25ffcmr2801490plg.6.1709313444486; Fri, 01 Mar 2024 09:17:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph , Volodymyr Fialko Subject: [PATCH v2 10/71] pdcp: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:06 -0800 Message-ID: <20240301171707.95242-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pdcp/pdcp_process.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/pdcp/pdcp_process.c b/lib/pdcp/pdcp_process.c index 9b9b881124b8..6c0693f66629 100644 --- a/lib/pdcp/pdcp_process.c +++ b/lib/pdcp/pdcp_process.c @@ -60,7 +60,7 @@ pdcp_iv_gen_null_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv *e m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -72,10 +72,10 @@ pdcp_iv_gen_null_zs(struct rte_crypto_op *cop, const struct entity_priv *en_priv iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static void @@ -89,7 +89,7 @@ pdcp_iv_gen_aes_ctr_null(struct rte_crypto_op *cop, const struct entity_priv *en iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, 16); + memcpy(iv, iv_u64, 16); } static void @@ -101,8 +101,8 @@ pdcp_iv_gen_zs_null(struct rte_crypto_op *cop, const struct entity_priv *en_priv iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64 = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64, 8); - rte_memcpy(iv + 8, &iv_u64, 8); + memcpy(iv, &iv_u64, 8); + memcpy(iv + 8, &iv_u64, 8); } static void @@ -115,17 +115,17 @@ pdcp_iv_gen_zs_zs(struct rte_crypto_op *cop, const struct entity_priv *en_priv, /* Generating cipher IV */ iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); - rte_memcpy(iv + 8, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); + memcpy(iv + 8, &iv_u64[0], 8); iv += PDCP_IV_LEN; /* Generating auth IV */ iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static void @@ -140,12 +140,12 @@ pdcp_iv_gen_zs_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv *en_ iv = rte_crypto_op_ctod_offset(cop, uint8_t *, PDCP_IV_OFFSET); iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); - rte_memcpy(iv + 8, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); + memcpy(iv + 8, &iv_u64[0], 8); m_ptr = (uint8_t *)rte_pktmbuf_prepend(mb, 8); m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -162,11 +162,11 @@ pdcp_iv_gen_aes_ctr_aes_cmac(struct rte_crypto_op *cop, const struct entity_priv iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, PDCP_IV_LEN); + memcpy(iv, iv_u64, PDCP_IV_LEN); m_ptr = (uint8_t *)rte_pktmbuf_prepend(mb, 8); m = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(m_ptr, &m, 8); + memcpy(m_ptr, &m, 8); } static void @@ -179,15 +179,15 @@ pdcp_iv_gen_aes_ctr_zs(struct rte_crypto_op *cop, const struct entity_priv *en_p iv_u64[0] = en_priv->cipher_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); iv_u64[1] = 0; - rte_memcpy(iv, iv_u64, PDCP_IV_LEN); + memcpy(iv, iv_u64, PDCP_IV_LEN); iv += PDCP_IV_LEN; iv_u64[0] = en_priv->auth_iv_part.u64[0] | ((uint64_t)(rte_cpu_to_be_32(count))); - rte_memcpy(iv, &iv_u64[0], 8); + memcpy(iv, &iv_u64[0], 8); iv_u64[1] = iv_u64[0] ^ en_priv->auth_iv_part.u64[1]; - rte_memcpy(iv + 8, &iv_u64[1], 8); + memcpy(iv + 8, &iv_u64[1], 8); } static int From patchwork Fri Mar 1 17:15:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137701 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8109E43C12; Fri, 1 Mar 2024 18:18:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D83743376; Fri, 1 Mar 2024 18:17:34 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 1082043308 for ; Fri, 1 Mar 2024 18:17:26 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dc49b00bdbso23998835ad.3 for ; Fri, 01 Mar 2024 09:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313445; x=1709918245; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/xlAJnwaWn+Xw+Q/XhSlkHfr43MGX/g/yNBJJd1u4nU=; b=FEgsQGOQmpSTugpXoIjM30XQjRVDD3Sh9aK/ioyq6S/mhQcI1duzODETARNRWP15yT 7NOut72+WFXwyfMNVyRM3YUcBRCHRrScZVJNT+jVknDPsxIunUouqHzHP5YD49Xq8Pj0 qzuJuyCcFhXBXbC7zQ90iBSRUUMo/i5jc1IBPyiUtX0TjRSM6t3gNALN1SFt8mPQOFmd ykMTVYZ9OiancRG6GpiC8a5zYE6sSexllq/d7iDepWIO6niPvQzzI/KvsSO4fmxtj0SJ KpJI7TI8sThE12fP7qrZ/4yGOggp4CWSvLDMpEJ0BsQUI5s9EmIOC1tDOMiE8b1Xfi3c P3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313445; x=1709918245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/xlAJnwaWn+Xw+Q/XhSlkHfr43MGX/g/yNBJJd1u4nU=; b=Eo/VZ3ln0HNnmdAA+mzI9/lokqDCQOcbHVJ1DUphNy9RwCPI4pyNwmEhL8eQdauavs 04zeZToHrHWUqAexcfbDno5OfU0kRdf+bYhbDpaJh7B3qaOETmeGuK57LQosDBLkHxcE 5yOCuGCmx8WWqV0do1B4XOoeKhbnGeNDQ6Kh1rUA9zYAocJ66jIhC39ZATn2Sc3R27Co 9VMU5UvlaxdRB/Nel0mYlrN9nUVrC7q2smwNi2XE1s1Lpl+Wp0fWNGLrJLTDiR78fep6 QErpS5P9rS1z/tL0NmYWojmRHOREuCYJTOmKyorVA4csCnOgDy+0N8Yi+bNVmNDCAOn4 8htA== X-Gm-Message-State: AOJu0YwW3Lii/0SffwoD2hrocBnYSZyRKHCFR4Kb1QKhABgqFKQ6kpDT OQ2Vir4D79lZsJ9IG6JLDgoAC53+Cg4TD53/pkp30gvsNaF4kL+yoYP01NlklyKZ73d8JrFuy57 ZwMWhXA== X-Google-Smtp-Source: AGHT+IFEk3qyXr+VxsiiWVTowxRw6Hq/PIQTuJb7YFK+vkDYa6Odv2xfLgMoIj7ZHTZMzQ4ROHamew== X-Received: by 2002:a17:902:b281:b0:1dc:1fda:202e with SMTP id u1-20020a170902b28100b001dc1fda202emr2084546plr.51.1709313445298; Fri, 01 Mar 2024 09:17:25 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH v2 11/71] pipeline: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:07 -0800 Message-ID: <20240301171707.95242-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_table_action.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c index dfdbc66b087c..c2312dc803a1 100644 --- a/lib/pipeline/rte_table_action.c +++ b/lib/pipeline/rte_table_action.c @@ -1441,7 +1441,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, tcp->src_port, data->port); - rte_memcpy(ip->src_addr, data->addr, 16); + memcpy(ip->src_addr, data->addr, 16); tcp->src_port = data->port; tcp->cksum = tcp_cksum; } else { @@ -1454,7 +1454,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, udp->src_port, data->port); - rte_memcpy(ip->src_addr, data->addr, 16); + memcpy(ip->src_addr, data->addr, 16); udp->src_port = data->port; udp->dgram_cksum = udp_cksum; } @@ -1469,7 +1469,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, tcp->dst_port, data->port); - rte_memcpy(ip->dst_addr, data->addr, 16); + memcpy(ip->dst_addr, data->addr, 16); tcp->dst_port = data->port; tcp->cksum = tcp_cksum; } else { @@ -1482,7 +1482,7 @@ pkt_ipv6_work_nat(struct rte_ipv6_hdr *ip, udp->dst_port, data->port); - rte_memcpy(ip->dst_addr, data->addr, 16); + memcpy(ip->dst_addr, data->addr, 16); udp->dst_port = data->port; udp->dgram_cksum = udp_cksum; } From patchwork Fri Mar 1 17:15:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137702 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4396E43C12; Fri, 1 Mar 2024 18:18:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62DBB4336A; Fri, 1 Mar 2024 18:17:35 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id BDA0343326 for ; Fri, 1 Mar 2024 18:17:26 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dca160163dso23219905ad.3 for ; Fri, 01 Mar 2024 09:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313446; x=1709918246; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jbZuCt7Kf6cf5KLurWbbpI6EGCXfBw+iZwwJae+YM7U=; b=LvWZPf5kSQWVNqK1jJrBdabwvvLwoGmYAGIiy0OkaHZ+/byrSC7R6mOZ2slh/yDtLK ftcpoYSBVtNx9JWVhnpuyWGhMNPNC0QHVeRCZC7iyBshyCoYCbaJ/Z4Domb/6FhJTKO0 EnObpAaVeYFukiHWcrQlfjUGNYQvf6Y/qWNZAvyrK8Mydd9ooQreRC7bral5EjeQM/oa 6b0UTSdbT8EzNaFOHGRPyspvNmfO3CMTLrgEUG2BuEN8/Fmr3+LNHYIBTT2HL3IlwlXU +WVQ+9a0Kj98ZnpETPre0INEDeuho2D4H1fK95FqLhHloGwsE/y87gaGUNqL+0biaJSL dbtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313446; x=1709918246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbZuCt7Kf6cf5KLurWbbpI6EGCXfBw+iZwwJae+YM7U=; b=oDBQevBMHVZyXHj4Vxokah19yPo8X5kyrDWAgyuuoJrSKBMFXJ6YY5hH0zxpd7eO1P 0KRKv5i6Df8WW/oNBIHWaohPvVy1vyezE0c7ukjADNDaD/0rpoR6vrDa/+X7WIAkmUP2 +ZpdLVWuwGe8JAnkyLVNIx4/mrZXBvXZQoAS8jrvXKskFphyFvOTdMKzB25DYuyAolSi VjWFf04zXPuYamcsHlal99erQrpz2h6JV6BktemEyKSjbLohobqqQTOBXLcShbeEJqgI gV26gz0xBIEJR858XVXehtepZrsQWgqLnHGLNudLFrhfnYmKujHabGgip47Hq/cA0JLa MIBg== X-Gm-Message-State: AOJu0YyOoUFbhuy7FHBbF6CCGa63BMbxMZVY3/rlZT3x9lSexP2ED32B TGDJQq54hi0EFWzQ3T/75sAZYGBlay0X3IhN7WltlrzMqrdSQO56JAc64QQTzjAtM8cZqoLsvWW h1hDtig== X-Google-Smtp-Source: AGHT+IGKq3R0PtroHAysh6RzmWzXGA6fIBahFvsqYT5QJwFer1MRomhOC72IFTVQKlt4sl8w/IFClA== X-Received: by 2002:a17:903:32d0:b0:1db:cbff:df15 with SMTP id i16-20020a17090332d000b001dbcbffdf15mr2615131plr.9.1709313446054; Fri, 01 Mar 2024 09:17:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Vladimir Medvedkin Subject: [PATCH v2 12/71] rib: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:08 -0800 Message-ID: <20240301171707.95242-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Mostly automatically generated by devtools/cocci/rte_memcpy.cocci The fib/trie.c was relying on headers rte_rib6 -> rte_memcpy -> rte_vect since rib6 is no longer using rte_memcpy need to get rte_vect.h Signed-off-by: Stephen Hemminger --- lib/fib/trie.c | 2 +- lib/rib/rte_rib6.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287cc..a77f6c758b0d 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -9,7 +9,7 @@ #include #include #include - +#include #include #include #include "trie.h" diff --git a/lib/rib/rte_rib6.h b/lib/rib/rte_rib6.h index 775286f965f2..f366d3d197f3 100644 --- a/lib/rib/rte_rib6.h +++ b/lib/rib/rte_rib6.h @@ -14,7 +14,8 @@ * Level compressed tree implementation for IPv6 Longest Prefix Match */ -#include +#include + #include #ifdef __cplusplus @@ -61,7 +62,7 @@ rte_rib6_copy_addr(uint8_t *dst, const uint8_t *src) { if ((dst == NULL) || (src == NULL)) return; - rte_memcpy(dst, src, RTE_RIB6_IPV6_ADDR_SIZE); + memcpy(dst, src, RTE_RIB6_IPV6_ADDR_SIZE); } /** From patchwork Fri Mar 1 17:15:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137703 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C772943C12; Fri, 1 Mar 2024 18:19:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9468C4338C; Fri, 1 Mar 2024 18:17:36 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 6DB54432BC for ; Fri, 1 Mar 2024 18:17:27 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e5a50d91b4so1803231b3a.2 for ; Fri, 01 Mar 2024 09:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313446; x=1709918246; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f7ShVjOP7v3RAN9c6QxL/R4mkZ6ArXruvMZ0jTEazuM=; b=k+Ey1YmpGWTEY3nG2fEMO5e5eqwvxKB4xZ+pQNDv50kR51vPzDV+7iNTtys1PATWDL 6gWvKvwBW+72ixHDwok9LcF622eICgf2EPCYZ7FT4MHJTVnOTCwXRpgKizZVxVXSKWZm SDSRho8zDFo0Pee76mMUVnd73OqZjPBjs6E9p1Z9+wPv8b5+AyHr81/Gz9aVSgv5ySv9 97okd947ZxTgE8WrqBp5kzRwUz3jyj7QKBguqDuTvlg0hXj6UGdK+iY3xRW8cV47RO1Z F8tJOJz78COnflsRe07F68m9vaUzMzJ19+kAGHuvQpmCpaEIkJkTv7qP/7a+h/styzwY Ullg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313446; x=1709918246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7ShVjOP7v3RAN9c6QxL/R4mkZ6ArXruvMZ0jTEazuM=; b=GnbKJVuV5yWXhr/xv6GU4Uh0mwVP6QAHjeLdgdIHPoYwsYNN4bx86CwacXjemNFks1 R/YmS2/PuQwNQNl1aXF0HgJQo4N0hzKR2KmjHRgPF6RjVO3TAEhamgPax6fj8mY89jch 1+4a4UagDrgAO0BRYtvS3Oi6ih0vQds+7/EO24KGH11MxXGq+ht9vmW+xqOQQVH8icyh qcffUr5XA8OJstUy8sgzBTNh4YjaMnXJoOMDfdzozxvj+lDkIvbGR9Yb+wWIIN+stG3t fu2rbu90FpJhMhT357fC5fPLQgold3aHo+fqSoPJqyTwoMpIEgfO5b83joM0gOGAXzmp UFqw== X-Gm-Message-State: AOJu0YwrunERl6oZTwmxtHYM7HtihTx/3CQmzr1F1h6K+GRoeFR3bd31 HSRM6MLIYMNTRIpQG7DrAG1QaRlr9bHSAb+2MOlyejZqnVURGOIv5ONZLqnrrQTiww5LTwW28F0 /Pzu/Uw== X-Google-Smtp-Source: AGHT+IFgXesCztuur5Q4eEIbOKwLkcw7b55oKx1Oa4EW9+mUgjEa2ksxcU3Lu0Bs7myv22HTfO5bAg== X-Received: by 2002:a05:6a20:da8a:b0:1a1:3812:aa29 with SMTP id iy10-20020a056a20da8a00b001a13812aa29mr2394274pzb.7.1709313446747; Fri, 01 Mar 2024 09:17:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal , Anoob Joseph Subject: [PATCH v2 13/71] security: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:09 -0800 Message-ID: <20240301171707.95242-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/security/rte_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index e5c862f5f570..28d59ef38831 100644 --- a/lib/security/rte_security.c +++ b/lib/security/rte_security.c @@ -384,7 +384,7 @@ crypto_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { memset(&caps_val, 0, CRYPTO_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < CRYPTO_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } @@ -409,7 +409,7 @@ sec_caps_array(struct rte_tel_data *d, while ((dev_caps = &capabilities[i++])->action != RTE_SECURITY_ACTION_TYPE_NONE) { memset(&caps_val, 0, SEC_CAPS_SZ * sizeof(caps_val[0])); - rte_memcpy(caps_val, dev_caps, sizeof(capabilities[0])); + memcpy(caps_val, dev_caps, sizeof(capabilities[0])); for (j = 0; j < SEC_CAPS_SZ; j++) rte_tel_data_add_array_uint(d, caps_val[j]); } From patchwork Fri Mar 1 17:15:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137704 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50FDD43C12; Fri, 1 Mar 2024 18:19:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF239433A5; Fri, 1 Mar 2024 18:17:37 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id A3DBF43310 for ; Fri, 1 Mar 2024 18:17:28 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d94b222a3aso24798825ad.2 for ; Fri, 01 Mar 2024 09:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313448; x=1709918248; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J5lGsz8zSj9bml/O+Ktt4X06wyer0sRSUXfJgwoKNqU=; b=kvnf/K0DEoV35/lt9JAgzd90sWWj6yAihQlL0NQsf4LJCduKalswXM9j8zSo+vL41v RILibT38OzH8Ph+VfaGLrvVznFIq2RUcxJ8bdwJ/Gi+l6s+AJQ62TZCj1PoFSrwZicia Wyr3lBbcrlLZhghJfd7RwNYEpFN92+wvHpmvgjo7TpbXAC1///zMhVZWml8zP5O+f/4O UJr21yt81NpRLp04EVISj6iGysqSZeFTRtm0hSaHIt46HHzP6HIj9H91yQMDYVxVDgUj szpHFZzSJbug26qFaEAZJ4jVWXMnoPMEqcvTLaeqPluxbPjI5zNwD/WURGHLs4ZT/QDT L96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313448; x=1709918248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J5lGsz8zSj9bml/O+Ktt4X06wyer0sRSUXfJgwoKNqU=; b=DuZzBaMf1z4cunjmuOGRcwIc3JVEcoX9z0zN5b0SZ1sLdJIZmLf/JjkwIiRcciwhGW G38YMY/SGyW7bVEIbbtDI3o4qUoHA/ZOkNkpRh9SCJ4Jpw/0iWAwnpwdGWUzWyhpICtE uaqNomNU3WrB3yzblDT6b1lRXu3wMuUcV8RTtPLMj+k99wt5hULLfAD1exCGs3ZPjnA2 dB+/Sm4OSLjtHxn+KbSSL6wB8Lo3j7pC8eSQRbmlx2DqhyrCm+N+sgKxY/iXvYsLSiPJ DAnqC7JyD6PNOt15gqB+bOoBXE3KcukH1yZr+wHmhH5J9d/YV+wdRdK4xR7/kIuWKape TZ3A== X-Gm-Message-State: AOJu0YyAQhYADsR8EjGdcc78xn9Yduabfi0QFZScLx2GwabIPlX+jluv gdsKUqo84oO9pr7CUAnjAaa6sY6G9vJXjPnjfbZiGnh167FX/cBS19jmBzYFZlMnmpUty5Z7yFU /H4PpUQ== X-Google-Smtp-Source: AGHT+IFxNb/t14WG+F9igG5Nmji1WcEqq3C2NUvzVx8e5VfX6RH2YDlsCjxFTjNWhHCjsVxGqpFOxw== X-Received: by 2002:a17:903:41d0:b0:1db:e672:3704 with SMTP id u16-20020a17090341d000b001dbe6723704mr2512263ple.33.1709313447909; Fri, 01 Mar 2024 09:17:27 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v2 14/71] net/mlx5: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:10 -0800 Message-ID: <20240301171707.95242-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_devx.c | 4 ++-- drivers/net/mlx5/mlx5_flow.c | 38 ++++++++++++++++---------------- drivers/net/mlx5/mlx5_flow_aso.c | 6 ++--- drivers/net/mlx5/mlx5_flow_hw.c | 16 +++++++------- drivers/net/mlx5/mlx5_rx.c | 6 ++--- drivers/net/mlx5/mlx5_rxtx_vec.c | 8 +++---- 6 files changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index 9fa400fc48ef..6380a5c83cd3 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -512,7 +512,7 @@ mlx5_rxq_obj_hairpin_new(struct mlx5_rxq_priv *rxq) * during queue setup. */ MLX5_ASSERT(hca_attr->hairpin_data_buffer_locked); - rte_memcpy(&locked_attr, &unlocked_attr, sizeof(locked_attr)); + memcpy(&locked_attr, &unlocked_attr, sizeof(locked_attr)); locked_attr.hairpin_data_buffer_type = MLX5_RQC_HAIRPIN_DATA_BUFFER_TYPE_LOCKED_INTERNAL_BUFFER; tmpl->rq = mlx5_devx_cmd_create_rq(priv->sh->cdev->ctx, &locked_attr, @@ -1289,7 +1289,7 @@ mlx5_txq_obj_hairpin_new(struct rte_eth_dev *dev, uint16_t idx) */ MLX5_ASSERT(hca_attr->hairpin_sq_wq_in_host_mem); MLX5_ASSERT(hca_attr->hairpin_sq_wqe_bb_size > 0); - rte_memcpy(&host_mem_attr, &dev_mem_attr, sizeof(host_mem_attr)); + memcpy(&host_mem_attr, &dev_mem_attr, sizeof(host_mem_attr)); umem_size = MLX5_WQE_SIZE * RTE_BIT32(host_mem_attr.wq_attr.log_hairpin_num_packets); umem_dbrec = RTE_ALIGN(umem_size, MLX5_DBR_SIZE); diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 2b2ae626186e..53c20592b91a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -4495,8 +4495,8 @@ flow_action_handles_translate(struct rte_eth_dev *dev, (error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_NUM, NULL, "too many shared actions"); } - rte_memcpy(&handle[copied_n].action, &actions[n].conf, - sizeof(actions[n].conf)); + memcpy(&handle[copied_n].action, &actions[n].conf, + sizeof(actions[n].conf)); handle[copied_n].index = n; copied_n++; } @@ -5362,29 +5362,29 @@ flow_hairpin_split(struct rte_eth_dev *dev, case RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP: case RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN: case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP: - rte_memcpy(actions_tx, actions, + memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); actions_tx++; break; case RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID: if (push_vlan) { - rte_memcpy(actions_tx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, + sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; case RTE_FLOW_ACTION_TYPE_COUNT: if (encap) { - rte_memcpy(actions_tx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, + sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; @@ -5396,8 +5396,8 @@ flow_hairpin_split(struct rte_eth_dev *dev, actions_tx++; encap = 1; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; @@ -5408,14 +5408,14 @@ flow_hairpin_split(struct rte_eth_dev *dev, sizeof(struct rte_flow_action)); actions_tx++; } else { - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; } break; default: - rte_memcpy(actions_rx, actions, - sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, + sizeof(struct rte_flow_action)); actions_rx++; break; } @@ -5425,7 +5425,7 @@ flow_hairpin_split(struct rte_eth_dev *dev, tag_action->type = (enum rte_flow_action_type) MLX5_RTE_FLOW_ACTION_TYPE_TAG; actions_rx++; - rte_memcpy(actions_rx, actions, sizeof(struct rte_flow_action)); + memcpy(actions_rx, actions, sizeof(struct rte_flow_action)); actions_rx++; set_tag = (void *)actions_rx; *set_tag = (struct mlx5_rte_flow_action_set_tag) { @@ -5435,7 +5435,7 @@ flow_hairpin_split(struct rte_eth_dev *dev, MLX5_ASSERT(set_tag->id > REG_NON); tag_action->conf = set_tag; /* Create Tx item list. */ - rte_memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); + memcpy(actions_tx, actions, sizeof(struct rte_flow_action)); addr = (void *)&pattern_tx[2]; item = pattern_tx; item->type = (enum rte_flow_item_type) diff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c index f3114434729e..49de92c675cd 100644 --- a/drivers/net/mlx5/mlx5_flow_aso.c +++ b/drivers/net/mlx5/mlx5_flow_aso.c @@ -1327,9 +1327,9 @@ mlx5_aso_ct_status_update(struct mlx5_aso_sq *sq, uint16_t num) MLX5_ASSERT(ct); MLX5_ASO_CT_UPDATE_STATE(ct, ASO_CONNTRACK_READY); if (sq->elts[idx].query_data) - rte_memcpy(sq->elts[idx].query_data, - (char *)((uintptr_t)sq->mr.addr + idx * 64), - 64); + memcpy(sq->elts[idx].query_data, + (char *)((uintptr_t)sq->mr.addr + idx * 64), + 64); } } diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index bcf43f545779..04b12bba95a9 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -1970,7 +1970,7 @@ mlx5_tbl_translate_modify_header(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "translate modify_header: no memory for modify header context"); - rte_memcpy(acts->mhdr, mhdr, sizeof(*mhdr)); + memcpy(acts->mhdr, mhdr, sizeof(*mhdr)); pattern.data = (__be64 *)acts->mhdr->mhdr_cmds; if (mhdr->shared) { uint32_t flags = mlx5_hw_act_flag[!!attr->group][tbl_type] | @@ -2823,9 +2823,9 @@ flow_hw_modify_field_construct(struct mlx5_hw_q_job *job, mhdr_action->src.field != RTE_FLOW_FIELD_POINTER) return 0; if (mhdr_action->src.field == RTE_FLOW_FIELD_VALUE) - rte_memcpy(values, &mhdr_action->src.value, sizeof(values)); + memcpy(values, &mhdr_action->src.value, sizeof(values)); else - rte_memcpy(values, mhdr_action->src.pvalue, sizeof(values)); + memcpy(values, mhdr_action->src.pvalue, sizeof(values)); if (mhdr_action->dst.field == RTE_FLOW_FIELD_META || mhdr_action->dst.field == RTE_FLOW_FIELD_TAG || mhdr_action->dst.field == RTE_FLOW_FIELD_METER_COLOR || @@ -4467,7 +4467,7 @@ flow_hw_table_create(struct rte_eth_dev *dev, rte_flow_error_set(error, err, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "Failed to create template table"); else - rte_memcpy(error, &sub_error, sizeof(sub_error)); + memcpy(error, &sub_error, sizeof(sub_error)); } return NULL; } @@ -7773,8 +7773,8 @@ flow_hw_create_tx_repr_tag_jump_acts_tmpl(struct rte_eth_dev *dev, struct rte_flow_action actions_m[4] = { { 0 } }; unsigned int idx = 0; - rte_memcpy(set_tag_v.src.value, &tag_value, sizeof(tag_value)); - rte_memcpy(set_tag_m.src.value, &tag_mask, sizeof(tag_mask)); + memcpy(set_tag_v.src.value, &tag_value, sizeof(tag_value)); + memcpy(set_tag_m.src.value, &tag_mask, sizeof(tag_mask)); flow_hw_update_action_mask(&actions_v[idx], &actions_m[idx], RTE_FLOW_ACTION_TYPE_MODIFY_FIELD, &set_tag_v, &set_tag_m); @@ -8181,8 +8181,8 @@ flow_hw_create_ctrl_regc_jump_actions_template(struct rte_eth_dev *dev, }; set_reg_v.dst.offset = rte_bsf32(marker_mask); - rte_memcpy(set_reg_v.src.value, &marker_bits, sizeof(marker_bits)); - rte_memcpy(set_reg_m.src.value, &marker_mask, sizeof(marker_mask)); + memcpy(set_reg_v.src.value, &marker_bits, sizeof(marker_bits)); + memcpy(set_reg_m.src.value, &marker_mask, sizeof(marker_mask)); return flow_hw_actions_template_create(dev, &attr, actions_v, actions_m, error); } diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c index 5bf1a679b2d8..e35f9abd2064 100644 --- a/drivers/net/mlx5/mlx5_rx.c +++ b/drivers/net/mlx5/mlx5_rx.c @@ -761,9 +761,9 @@ mlx5_rx_poll_len(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cqe, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_cqe, - (const void *)(uintptr_t)cqe, - sizeof(struct mlx5_cqe)); + memcpy(&rxq->title_cqe, + (const void *)(uintptr_t)cqe, + sizeof(struct mlx5_cqe)); } } } diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.c b/drivers/net/mlx5/mlx5_rxtx_vec.c index 2363d7ed27a7..c3bcd3ef16de 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec.c +++ b/drivers/net/mlx5/mlx5_rxtx_vec.c @@ -349,8 +349,8 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_pkt, elts[nocmp_n - 1], - sizeof(struct rte_mbuf)); + memcpy(&rxq->title_pkt, elts[nocmp_n - 1], + sizeof(struct rte_mbuf)); } /* Decompress the last CQE if compressed. */ if (comp_idx < MLX5_VPMD_DESCS_PER_LOOP) { @@ -499,8 +499,8 @@ rxq_burst_mprq_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, ret = check_cqe_iteration(next, rxq->cqe_n, rxq->cq_ci); if (ret != MLX5_CQE_STATUS_SW_OWN || MLX5_CQE_FORMAT(next->op_own) == MLX5_COMPRESSED) - rte_memcpy(&rxq->title_pkt, elts[nocmp_n - 1], - sizeof(struct rte_mbuf)); + memcpy(&rxq->title_pkt, elts[nocmp_n - 1], + sizeof(struct rte_mbuf)); } /* Decompress the last CQE if compressed. */ if (comp_idx < MLX5_VPMD_DESCS_PER_LOOP) { From patchwork Fri Mar 1 17:15:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137705 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 771D943C12; Fri, 1 Mar 2024 18:19:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D84DD433B0; Fri, 1 Mar 2024 18:17:38 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 700F943312 for ; Fri, 1 Mar 2024 18:17:29 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dc96f64c10so23319725ad.1 for ; Fri, 01 Mar 2024 09:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313448; x=1709918248; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=; b=jMn2hpRC/UEoYi+38dxYVjMj1NtSB9oBf3SMfjI803xc9KKKyjuXulITIJ4ZU8gXeq uqgOXpNcilIz0Iz8LMVQTS/Pc06Cbh8KNXVMHjAoqmVQjdaXQxBTEEggkceroAWljoBD NycVnqILW+tJNatksw0i8p0RqfMw0U56XSuSxPfohLpnrDcwQ4q7K123EiWIDVItn6AN 1L3JFxl4V7yj2P9lWvOenDie6An8tsgyIVxPFTPIlbfHVoCX8QpC4H5spMSbNGOkl2xD JQHhO2PboMmKP1PQw942E4uJlUOT0hEmHunyKx368+IFoYC8BZvN1n/MBTBeHLn4VeTZ y+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313448; x=1709918248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=; b=TqeO2h+9Yo0f3T/+wCxaWRCh9/mjw9zB8a6mseWXXn9KlSnxC9LSc3kENwPbSw8A2K 1F523n4+pQYLuFMH6Yp/OD7ZyPfs8VqdaguFRRQoku9nMY02BPruwe3fSNDF5pSNqcUD Z7MQzT7SmsZYfPp8GHHuUsCMYmEwTgeMd59SiDH4UkKqXFtf1OqM6nXe/AKph12uOnmP bepEfQFClgghvmHbcTCvddXAjPbF+2XXbfkorJ3MAyN/zpcVPM90JExCuWOxSkcXM2LK UeKKh/YUvYrRcVTGpRRQQNu3HIvIZScbvhENPS6UakxV94kYygJUp5pzRo1EDRqMEwmT 8FBg== X-Gm-Message-State: AOJu0YzWDbDU/zVn7GQd950RsTk5wLIgg7ivLKA6GlOmmB6IikpByhMR +h8rYMPBOciAMS9sNRD8YqbCcUZCCs7zYuvJg+MofH+ftLf8/t4x7X2KRp/H/1WjehLOJ3sorhk u3qqYmg== X-Google-Smtp-Source: AGHT+IFV4dc3BZsvvmPnOuyV0Im84Oir9qCEfQ6EsmHCQEWXjqb7x44o1V8UUe/LpiTV06Fn7wMGoA== X-Received: by 2002:a17:903:1c7:b0:1dc:a60a:a7c7 with SMTP id e7-20020a17090301c700b001dca60aa7c7mr2652168plh.25.1709313448646; Fri, 01 Mar 2024 09:17:28 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chaoyong He Subject: [PATCH v2 15/71] net/nfp: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:11 -0800 Message-ID: <20240301171707.95242-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_conntrack.c | 2 +- drivers/net/nfp/flower/nfp_flower_flow.c | 16 ++++++++-------- drivers/net/nfp/flower/nfp_flower_representor.c | 2 +- drivers/net/nfp/nfp_mtr.c | 10 +++++----- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_conntrack.c b/drivers/net/nfp/flower/nfp_conntrack.c index f89003be8b40..279bf17eb3a5 100644 --- a/drivers/net/nfp/flower/nfp_conntrack.c +++ b/drivers/net/nfp/flower/nfp_conntrack.c @@ -1470,7 +1470,7 @@ nfp_ct_do_flow_merge(struct nfp_ct_zone_entry *ze, merge_entry->ze = ze; merge_entry->pre_ct_parent = pre_ct_entry; merge_entry->post_ct_parent = post_ct_entry; - rte_memcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie)); + memcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie)); merge_entry->rule.items_cnt = pre_ct_entry->rule.items_cnt + post_ct_entry->rule.items_cnt - cnt_same_item - 1; merge_entry->rule.actions_cnt = pre_ct_entry->rule.actions_cnt + diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c index e26be30d1833..3d07a4429b62 100644 --- a/drivers/net/nfp/flower/nfp_flower_flow.c +++ b/drivers/net/nfp/flower/nfp_flower_flow.c @@ -178,10 +178,10 @@ nfp_mask_id_alloc(struct nfp_flow_priv *priv, return -ENOENT; } - rte_memcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS); *mask_id = temp_id; - rte_memcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS); ring->tail = (ring->tail + NFP_FLOWER_MASK_ELEMENT_RS) % (NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS); @@ -200,7 +200,7 @@ nfp_mask_id_free(struct nfp_flow_priv *priv, if (CIRC_SPACE(ring->head, ring->tail, NFP_FLOWER_MASK_ENTRY_RS) == 0) return -ENOBUFS; - rte_memcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS); + memcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS); ring->head = (ring->head + NFP_FLOWER_MASK_ELEMENT_RS) % (NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS); @@ -2247,13 +2247,13 @@ nfp_flow_action_set_mac(char *act_data, set_mac = action->conf; if (mac_src_flag) { - rte_memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], - set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], + set_mac->mac_addr, RTE_ETHER_ADDR_LEN); for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) set_eth->eth_addr_mask[RTE_ETHER_ADDR_LEN + i] = 0xff; } else { - rte_memcpy(&set_eth->eth_addr[0], - set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&set_eth->eth_addr[0], set_mac->mac_addr, + RTE_ETHER_ADDR_LEN); for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) set_eth->eth_addr_mask[i] = 0xff; } @@ -2329,7 +2329,7 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->reserved = 0; for (i = 0; i < 4; i++) { - rte_memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4); + memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4); set_ip->ipv6[i].exact = tmp; set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); } diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 4f4df0cd2ee2..ce2b06611802 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -181,7 +181,7 @@ nfp_flower_repr_stats_get(struct rte_eth_dev *ethdev, struct nfp_flower_representor *repr; repr = ethdev->data->dev_private; - rte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats)); + memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats)); return 0; } diff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c index 255977ec2236..1f173409b421 100644 --- a/drivers/net/nfp/nfp_mtr.c +++ b/drivers/net/nfp/nfp_mtr.c @@ -243,7 +243,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower, struct nfp_profile_conf old_conf; /* Get the old profile config */ - rte_memcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf)); + memcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf)); memset(&mtr_profile->conf, 0, sizeof(struct nfp_profile_conf)); @@ -267,7 +267,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower, return 0; rollback: - rte_memcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf)); + memcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf)); return ret; } @@ -492,8 +492,8 @@ nfp_mtr_policy_add(struct rte_eth_dev *dev, } mtr_policy->policy_id = mtr_policy_id; - rte_memcpy(&mtr_policy->policy, policy, - sizeof(struct rte_mtr_meter_policy_params)); + memcpy(&mtr_policy->policy, policy, + sizeof(struct rte_mtr_meter_policy_params)); /* Insert policy into policy list */ LIST_INSERT_HEAD(&priv->policies, mtr_policy, next); @@ -1028,7 +1028,7 @@ nfp_mtr_stats_read(struct rte_eth_dev *dev, *stats_mask = mtr->stats_mask; rte_spinlock_lock(&priv->mtr_stats_lock); - rte_memcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr)); + memcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr)); rte_spinlock_unlock(&priv->mtr_stats_lock); prev = &mtr->mtr_stats.prev; From patchwork Fri Mar 1 17:15:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137706 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 579DA43C12; Fri, 1 Mar 2024 18:19:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18DB543389; Fri, 1 Mar 2024 18:17:40 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 2D0894334D for ; Fri, 1 Mar 2024 18:17:30 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dc0e5b223eso22794755ad.1 for ; Fri, 01 Mar 2024 09:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313449; x=1709918249; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GEbsLnLgcuyzMnZrYqny/7Ykl6Zj5T6JhoXq2O6L540=; b=FjyaXwrX2JP7M9UcnOITeMbmDZm8dtjAHPW/xnSdWt5iC82jfaIsoUSAgnZOq9IBaa RH1cZGqZitZdQD0iDKqUb4Fjm9RYaFJeqiMPvabUBDgeu0OzunZHmVMQkcv96sYTzUBG Vl/fGEyqx+8u2W1Bc3qaFwuybTzBzdvko7qdliq7PW0NhZ5c4O6BFmXpJtm3KCXK6hTo S3am9Ey8k3WIcIhaDx5IiNl3v01iork/oujJb5BMrqlYsqB2fDH3nXZt5wxT5PPyirZ7 jg9MG+pzddY6mIWY8jbo2viYy/lNF/+o3EDNv64mcC1xSO6YUn1q74mhxpPkG9x1Mon4 l4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313449; x=1709918249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GEbsLnLgcuyzMnZrYqny/7Ykl6Zj5T6JhoXq2O6L540=; b=SdBIq/jvz+cnloYKiVZe729RVdFsKYe8k3MLx25L+xafryKmm5yv/mCz5SfkG6WRyQ u2snVeEUiS+aVdmNbCwuc4CZAh6KzsUsKnvlN5NnAKC17okWW6A/3gGqgFMd9GMyXj/j JX0xcoGM2v7rA6BXfPkbBc2xozz00xuBSVfvY9KBFDp045FjrWU+NtN6CxzzCa+q3TKd cV6SIe6HilIAr4zoxFxwqkLHAV6DqWVijJH76ucJpb2xtstHeT78bRceZcIoEBQsbozU wNqqedQIQFTslhT3q6eKfBjbGqcJGSt08cCp/2Lome3MQWbRFrkNUVChIp2vAuJuHT+A n8Qg== X-Gm-Message-State: AOJu0YynSQOhj5hntA8gNwlnYZ7QzlON9audE3z1lyxN813sP+Mn+ECd lfTOPnR/3L78E82F76XfzCV9JciPFo53in3HLQp7ZjAnukZ0Ocb9+RKZsTNz+8XbIxSt/b0PUmE anLUTAA== X-Google-Smtp-Source: AGHT+IExrb6jv4rJbviiYLAJZ1DcHinnjfQD622Sjmh0UbuYuaVw3sn5wmSaI0mZUQibBAAItVgGwg== X-Received: by 2002:a17:902:a384:b0:1dc:4a90:b87d with SMTP id x4-20020a170902a38400b001dc4a90b87dmr2073505pla.66.1709313449378; Fri, 01 Mar 2024 09:17:29 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu Subject: [PATCH v2 16/71] net/ngbe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:12 -0800 Message-ID: <20240301171707.95242-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ngbe/ngbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_pf.c b/drivers/net/ngbe/ngbe_pf.c index 947ae7fe942a..48f578b06626 100644 --- a/drivers/net/ngbe/ngbe_pf.c +++ b/drivers/net/ngbe/ngbe_pf.c @@ -347,7 +347,7 @@ ngbe_vf_reset(struct rte_eth_dev *eth_dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = NGBE_VF_RESET | NGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -369,7 +369,7 @@ ngbe_vf_set_mac_addr(struct rte_eth_dev *eth_dev, struct rte_ether_addr *ea = (struct rte_ether_addr *)new_mac; if (rte_is_valid_assigned_ether_addr(ea)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.set_rar(hw, rar_entry, new_mac, vf, true); } return -1; From patchwork Fri Mar 1 17:15:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137707 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A33E443C12; Fri, 1 Mar 2024 18:19:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28B78433C8; Fri, 1 Mar 2024 18:17:42 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id CD5BF4334D for ; Fri, 1 Mar 2024 18:17:30 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21726345ad.3 for ; Fri, 01 Mar 2024 09:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313450; x=1709918250; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZaMQur2ANK3nI5KoKBp9hmJFLLNTC5nTlo/tTsJ8sZk=; b=a1zBiYvWSLSbFa1j3ujM0HdK3gZTIuPxhRevRdlBOlINpVsyCrMeRfTyGbwBrkDb48 g6t1/Yu7/r41lVzR6KNKwfO+WIe4sAQ+9qP1guj+e/NS/yRskjUuZ+CJ4dhETLH5fVqn FwOlmgEdZsj05/wtEq2Ne9CleaEtVBMkcueNrUTrkX5/O7sAq/CmXoIC4nRGw07/MfyN klsjunYraSwd7mFFJWeTNeSWT6UzrfICMVOB+cT0bTK7MOz2OrmZD2SKxneFC7S8PR1I c3kwELlUlfs4ShJX0gT8wrY26sRziGX2XmLkN8Wp1ArtN1ob7jvofHvtSKH8cMbOAZNV e4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313450; x=1709918250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZaMQur2ANK3nI5KoKBp9hmJFLLNTC5nTlo/tTsJ8sZk=; b=BaQaRVZInPOW8qFJZRw+jYQhrOYBSw2X2bqtHMeIuDSNQ31mLI3L1YUZHuHdBDv2Q8 QswWuk3kt50GIAaLVbMLOA+rjMuO4NXnuM6D3KVn3loBIvGAH8jv5ZAWSiSB3n6SYvR0 T1MjhInMv5Yj9U39aEdm77TYXWGyRS+JA6xQ9PrK7Qy2mb6R9JTyL8UV6LNalXkXELc/ zzrOqPOAmN7DvPKguqVOsFsPz66R84ocWGGqZFcQ3057YErU0s8jidKvpLbePM+YE0V/ 7sydIqtbQ4U0BciH72yUKaL106qJLTaBKlNYjSN13N5MW8IxOPsYPoSBcsiDS3lUO4TD UVhw== X-Gm-Message-State: AOJu0YwqCYK0XQIA0nIcVhFXTxZgaD6EuW3NFsqS8jpeC703/O7HYdiI oa9FjMVCdKMSV9IZHzV/ND6qVmjb7sW/jnCs4XwwaDHu/sBNZLWDfAnRaqr63dMcAVzml6HYe3h 2NOQLkA== X-Google-Smtp-Source: AGHT+IGLyp7/qhgFyk00/2DpmuxKkJx+ag01+Zo62yB6r35BMhp0SjNFnAFNveGvYWI/ZBUxKzgzRw== X-Received: by 2002:a17:902:a3c6:b0:1dc:c633:e6b1 with SMTP id q6-20020a170902a3c600b001dcc633e6b1mr1866292plb.49.1709313450096; Fri, 01 Mar 2024 09:17:30 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tetsuya Mukawa Subject: [PATCH v2 17/71] net/null: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:13 -0800 Message-ID: <20240301171707.95242-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 7c46004f1e33..fd8b01b2b17b 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -465,7 +465,7 @@ eth_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf) rss_conf->rss_hf & internal->flow_type_rss_offloads; if (rss_conf->rss_key) - rte_memcpy(internal->rss_key, rss_conf->rss_key, 40); + memcpy(internal->rss_key, rss_conf->rss_key, 40); rte_spinlock_unlock(&internal->rss_lock); @@ -482,7 +482,7 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev, rss_conf->rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf; if (rss_conf->rss_key) - rte_memcpy(rss_conf->rss_key, internal->rss_key, 40); + memcpy(rss_conf->rss_key, internal->rss_key, 40); rte_spinlock_unlock(&internal->rss_lock); @@ -577,7 +577,7 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args) internals->flow_type_rss_offloads = RTE_ETH_RSS_PROTO_MASK; internals->reta_size = RTE_DIM(internals->reta_conf) * RTE_ETH_RETA_GROUP_SIZE; - rte_memcpy(internals->rss_key, default_rss_key, 40); + memcpy(internals->rss_key, default_rss_key, 40); data = eth_dev->data; data->nb_rx_queues = (uint16_t)nb_rx_queues; From patchwork Fri Mar 1 17:15:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137708 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F7AC43C12; Fri, 1 Mar 2024 18:19:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E21F433D7; Fri, 1 Mar 2024 18:17:44 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id A8AB543355 for ; Fri, 1 Mar 2024 18:17:31 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1dcab44747bso21663215ad.1 for ; Fri, 01 Mar 2024 09:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313451; x=1709918251; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BWtdyG5rsTZMIzCe2l7ha4SnqMibQAxbFiLTEf2hi40=; b=TUmCVyDXuNMs4d1jULNXaUlXYnRopcpU3B0uss2CZ9kL9JzruoA9+2fmpbl75CMlRp 7sF7wbcmGE7OTsDwvofM8Du9/NJIRC4tmjk15bXPas2zcbN2nZwpZ9QNZCL4dST6AnWU 9ChTRrxeIXVPr/kmT2eSN9NbTNhYjahK6AtpXcQDQFAfpbgTCwWghkx+TI9kyri+viZk dSQvpiIDoHxSWsaBHcb8VhstBP/jXWwOOfU1xDfP/WgFihYesldtUj1SxK+GU3uAV+68 Y/QSh3+R+8nL5VCXXZDoL+np8r65eEhuS4bT3idzQTnpT0ClO5NMi1MVcEd6aGJXjf7g xBWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313451; x=1709918251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BWtdyG5rsTZMIzCe2l7ha4SnqMibQAxbFiLTEf2hi40=; b=I5VzNfPoNZIFG+Gk7M0CsyZzyxTO64FOdBBT92Vo/lOjpJiNZOu+Bd/y3Jnic+DbFF /SvHza0VSR/xyPfrs+ATPCRW03pTASXjuknKa6G4mMSpqiYqCKTHxZBbiTuKSEbmxVSE z6rtYGU8D3SDMLOf95PQAU1G0gXgNXxEyp/H35MSo6HzuuKL88Pqq9AzthSpRxiL5Mhv Qkd3iBsk5QsLKxUmCBZzA7dmEvcsYQDaYJcdAcWfWf2FpOPUcKuC16Z/s94O2JEoE/PN rS7EbQGP9fVcjXsNNpwr2gIacolcLIRNiO8EL3Q8HhCkPMeMQF/1RueVt7zAlBTv9so1 doFQ== X-Gm-Message-State: AOJu0YypJwEKI5hWeP+3JlMZV+gE816StY0GCeJHN64e9G4UnIhgfphJ z10Dfw8bnhKPF9xcrlL+5C3gIu5lUmyrZT5sceDL+aRKxKW5vvgk/SrLPtsoU3jbgvApUlSNdsZ kpRZHOg== X-Google-Smtp-Source: AGHT+IEuJmKG2k0Av5O5VOHuV4w1ztdNfBARO3rcgGe0Kne/+HAQbxi0ca6EMIpqDPsgRD1BX4HZ7g== X-Received: by 2002:a17:902:c105:b0:1d7:88de:cff1 with SMTP id 5-20020a170902c10500b001d788decff1mr2108780pli.53.1709313450816; Fri, 01 Mar 2024 09:17:30 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 18/71] net/pcap: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:14 -0800 Message-ID: <20240301171707.95242-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c | 2 +- drivers/net/pcap/pcap_osdep_freebsd.c | 2 +- drivers/net/pcap/pcap_osdep_linux.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index bfec0850456f..54f0dfffbdd0 100644 --- a/drivers/net/pcap/pcap_ethdev.c +++ b/drivers/net/pcap/pcap_ethdev.c @@ -1270,7 +1270,7 @@ eth_pcap_update_mac(const char *if_name, struct rte_eth_dev *eth_dev, return -1; PMD_LOG(INFO, "Setting phy MAC for %s", if_name); - rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); eth_dev->data->mac_addrs = mac_addrs; return 0; } diff --git a/drivers/net/pcap/pcap_osdep_freebsd.c b/drivers/net/pcap/pcap_osdep_freebsd.c index 20556b3e9215..d395a5957d56 100644 --- a/drivers/net/pcap/pcap_osdep_freebsd.c +++ b/drivers/net/pcap/pcap_osdep_freebsd.c @@ -52,7 +52,7 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac) ifm = (struct if_msghdr *)buf; sdl = (struct sockaddr_dl *)(ifm + 1); - rte_memcpy(mac->addr_bytes, LLADDR(sdl), RTE_ETHER_ADDR_LEN); + memcpy(mac->addr_bytes, LLADDR(sdl), RTE_ETHER_ADDR_LEN); rte_free(buf); return 0; diff --git a/drivers/net/pcap/pcap_osdep_linux.c b/drivers/net/pcap/pcap_osdep_linux.c index 97033f57c5d9..fc79ad6cdf9e 100644 --- a/drivers/net/pcap/pcap_osdep_linux.c +++ b/drivers/net/pcap/pcap_osdep_linux.c @@ -35,7 +35,7 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac) return -1; } - rte_memcpy(mac->addr_bytes, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); + memcpy(mac->addr_bytes, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); close(if_fd); return 0; From patchwork Fri Mar 1 17:15:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137709 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B9E143C12; Fri, 1 Mar 2024 18:19:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB698433D2; Fri, 1 Mar 2024 18:17:45 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 9CEE24335D for ; Fri, 1 Mar 2024 18:17:32 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dc1e7c0e29so7905815ad.1 for ; Fri, 01 Mar 2024 09:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313452; x=1709918252; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OoUWowKhrMEflDaoUwwzGnre0FIbuyfQ26+Nm2E73oY=; b=NEz5204odMYHEYwWOskdClbUpTI7nJk9ZPKlpQJmZIMFVrGVhYMS9QJtqUqRsmH6YP zSUOO0uw6XCPiTWQ3VWmJtU41PLzToIAdQzNjj7EZgLVguNTRKGHejCcGv+p52gVmFtT zpxA8HUY709XDUuMwYiTCpprR/GOojyMoDoi1NJ81685Bz0RsQQlaQGOEY6uXftB7Oxc ix5fIyTL2rEW9v0TOcP7EDFpyOuJXIwKtR4DmkmuM452GU6JYGDSZaa+EMaSM+DXYK+j GlHGpnpUXaJgU5qaiP8I8tWPrYUmyW+AHszzvWjhhdlGjX6sdbVuoBwpKs4f11K7tvES vSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313452; x=1709918252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OoUWowKhrMEflDaoUwwzGnre0FIbuyfQ26+Nm2E73oY=; b=Afjay0QEALrWEWJqYXKOAi9LzpTv0x1D0W0ml+NwFs4Oo01ubGBjmxe3idFS6K5utZ TTG1y3doCIo7Qzb+cj4IpYh6+0O+S+dNYLTVK9P0NhSM3nnIFeXBkvudDOtMsxDwIpNi JB2jilgBObGVxPV3HsvB4sutHDN7DVlX8bAHtxYiiHvhea2v+oQgtUEc53NwWwzPEW9k tbO4snFJSj3DH3WQn4tDG/pAmBknVLHsJ+pHg4CTjYmNMlfjf97AgvJr1kXueIavoEsP +qUq89s2g0ZOOVNLvPmUOmio2rsX776qzhJbD8IeuBOME/6EGSBT6VTUk8rYw14euFRl sYcA== X-Gm-Message-State: AOJu0YzpchuHOcQo5UgNLMIcOaMVyL3pv4CmkcqwPjEmpbtJsZbwhVwH MWeeRrNPhPUR61tpe+m5nxOKf00w7CxN2FUpwFnnfj+IkS5AB0JegScJwoEFH1x6RDQeFByV+0X pmDt7QA== X-Google-Smtp-Source: AGHT+IECi6NWQSI8lxK0dxhOGX2iIZfqES5ou/QrK/NSiL/6Dqyz1TDdWZj4VtIo5n5i/eX2iwV+tQ== X-Received: by 2002:a17:902:f691:b0:1dc:7856:2200 with SMTP id l17-20020a170902f69100b001dc78562200mr2652111plg.18.1709313451883; Fri, 01 Mar 2024 09:17:31 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v2 19/71] net/sfc: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:15 -0800 Message-ID: <20240301171707.95242-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc.c | 2 +- drivers/net/sfc/sfc_ef10_tx.c | 2 +- drivers/net/sfc/sfc_ethdev.c | 11 +++++------ drivers/net/sfc/sfc_flow.c | 20 ++++++++++---------- drivers/net/sfc/sfc_flow_rss.c | 2 +- drivers/net/sfc/sfc_mae.c | 2 +- drivers/net/sfc/sfc_rx.c | 2 +- drivers/net/sfc/sfc_tso.c | 2 +- drivers/net/sfc/sfc_tso.h | 9 ++++----- 9 files changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 2cfff20f4783..2fd160e99ed2 100644 --- a/drivers/net/sfc/sfc.c +++ b/drivers/net/sfc/sfc.c @@ -850,7 +850,7 @@ sfc_rss_attach(struct sfc_adapter *sa) efx_ev_fini(sa->nic); efx_intr_fini(sa->nic); - rte_memcpy(rss->key, default_rss_key, sizeof(rss->key)); + memcpy(rss->key, default_rss_key, sizeof(rss->key)); memset(&rss->dummy_ctx, 0, sizeof(rss->dummy_ctx)); rss->dummy_ctx.conf.qid_span = 1; rss->dummy_ctx.dummy = true; diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c index 116229382b68..0b78a9eaccd1 100644 --- a/drivers/net/sfc/sfc_ef10_tx.c +++ b/drivers/net/sfc/sfc_ef10_tx.c @@ -514,7 +514,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, struct rte_mbuf *m_seg, first_m_seg->outer_l2_len); th = (const struct rte_tcp_hdr *)(hdr_addr + tcph_off); - rte_memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); + memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); sent_seq = rte_be_to_cpu_32(sent_seq); sfc_ef10_tx_qdesc_tso2_create(txq, *added, packet_id, outer_packet_id, diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 92ca5e7a60de..a6f0743f102c 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1287,8 +1287,7 @@ sfc_set_mc_addr_list(struct rte_eth_dev *dev, } for (i = 0; i < nb_mc_addr; ++i) { - rte_memcpy(mc_addrs, mc_addr_set[i].addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(mc_addrs, mc_addr_set[i].addr_bytes, EFX_MAC_ADDR_LEN); mc_addrs += EFX_MAC_ADDR_LEN; } @@ -1672,7 +1671,7 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, rss_conf->rss_hf = sfc_rx_hf_efx_to_rte(rss, rss->hash_types); rss_conf->rss_key_len = EFX_RSS_KEY_SIZE; if (rss_conf->rss_key != NULL) - rte_memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE); + memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE); return 0; } @@ -1741,7 +1740,7 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev, } } - rte_memcpy(rss->key, rss_conf->rss_key, sizeof(rss->key)); + memcpy(rss->key, rss_conf->rss_key, sizeof(rss->key)); } rss->hash_types = efx_hash_types; @@ -1840,7 +1839,7 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev, sfc_adapter_lock(sa); - rte_memcpy(rss_tbl_new, rss->tbl, sizeof(rss->tbl)); + memcpy(rss_tbl_new, rss->tbl, sizeof(rss->tbl)); for (entry = 0; entry < reta_size; entry++) { int grp_idx = entry % RTE_ETH_RETA_GROUP_SIZE; @@ -1864,7 +1863,7 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev, goto fail_scale_tbl_set; } - rte_memcpy(rss->tbl, rss_tbl_new, sizeof(rss->tbl)); + memcpy(rss->tbl, rss_tbl_new, sizeof(rss->tbl)); fail_scale_tbl_set: bad_reta_entry: diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c index 1b50aefe5c48..2bb98a443335 100644 --- a/drivers/net/sfc/sfc_flow.c +++ b/drivers/net/sfc/sfc_flow.c @@ -325,8 +325,8 @@ sfc_flow_parse_eth(const struct rte_flow_item *item, efx_spec->efs_match_flags |= is_ifrm ? EFX_FILTER_MATCH_IFRM_LOC_MAC : EFX_FILTER_MATCH_LOC_MAC; - rte_memcpy(loc_mac, spec->hdr.dst_addr.addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(loc_mac, spec->hdr.dst_addr.addr_bytes, + EFX_MAC_ADDR_LEN); } else if (memcmp(mask->hdr.dst_addr.addr_bytes, ig_mask, EFX_MAC_ADDR_LEN) == 0) { if (rte_is_unicast_ether_addr(&spec->hdr.dst_addr)) @@ -348,8 +348,8 @@ sfc_flow_parse_eth(const struct rte_flow_item *item, */ if (rte_is_same_ether_addr(&mask->hdr.src_addr, &supp_mask.hdr.src_addr)) { efx_spec->efs_match_flags |= EFX_FILTER_MATCH_REM_MAC; - rte_memcpy(efx_spec->efs_rem_mac, spec->hdr.src_addr.addr_bytes, - EFX_MAC_ADDR_LEN); + memcpy(efx_spec->efs_rem_mac, spec->hdr.src_addr.addr_bytes, + EFX_MAC_ADDR_LEN); } else if (!rte_is_zero_ether_addr(&mask->hdr.src_addr)) { goto fail_bad_mask; } @@ -624,8 +624,8 @@ sfc_flow_parse_ipv6(const struct rte_flow_item *item, RTE_BUILD_BUG_ON(sizeof(efx_spec->efs_rem_host) != sizeof(spec->hdr.src_addr)); - rte_memcpy(&efx_spec->efs_rem_host, spec->hdr.src_addr, - sizeof(efx_spec->efs_rem_host)); + memcpy(&efx_spec->efs_rem_host, spec->hdr.src_addr, + sizeof(efx_spec->efs_rem_host)); } else if (!sfc_flow_is_zero(mask->hdr.src_addr, sizeof(mask->hdr.src_addr))) { goto fail_bad_mask; @@ -637,8 +637,8 @@ sfc_flow_parse_ipv6(const struct rte_flow_item *item, RTE_BUILD_BUG_ON(sizeof(efx_spec->efs_loc_host) != sizeof(spec->hdr.dst_addr)); - rte_memcpy(&efx_spec->efs_loc_host, spec->hdr.dst_addr, - sizeof(efx_spec->efs_loc_host)); + memcpy(&efx_spec->efs_loc_host, spec->hdr.dst_addr, + sizeof(efx_spec->efs_loc_host)); } else if (!sfc_flow_is_zero(mask->hdr.dst_addr, sizeof(mask->hdr.dst_addr))) { goto fail_bad_mask; @@ -889,8 +889,8 @@ sfc_flow_set_efx_spec_vni_or_vsid(efx_filter_spec_t *efx_spec, if (memcmp(vni_or_vsid_mask, vni_or_vsid_full_mask, EFX_VNI_OR_VSID_LEN) == 0) { efx_spec->efs_match_flags |= EFX_FILTER_MATCH_VNI_OR_VSID; - rte_memcpy(efx_spec->efs_vni_or_vsid, vni_or_vsid_val, - EFX_VNI_OR_VSID_LEN); + memcpy(efx_spec->efs_vni_or_vsid, vni_or_vsid_val, + EFX_VNI_OR_VSID_LEN); } else if (!sfc_flow_is_zero(vni_or_vsid_mask, EFX_VNI_OR_VSID_LEN)) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, diff --git a/drivers/net/sfc/sfc_flow_rss.c b/drivers/net/sfc/sfc_flow_rss.c index e28c943335f3..a46ce1fa87e1 100644 --- a/drivers/net/sfc/sfc_flow_rss.c +++ b/drivers/net/sfc/sfc_flow_rss.c @@ -119,7 +119,7 @@ sfc_flow_rss_parse_conf(struct sfc_adapter *sa, key = ethdev_rss->key; } - rte_memcpy(out->key, key, sizeof(out->key)); + memcpy(out->key, key, sizeof(out->key)); switch (in->func) { case RTE_ETH_HASH_FUNCTION_DEFAULT: diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 60ff6d21810a..1f243e798e00 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -547,7 +547,7 @@ sfc_mae_mac_addr_add(struct sfc_adapter *sa, if (mac_addr == NULL) return ENOMEM; - rte_memcpy(mac_addr->addr_bytes, addr_bytes, EFX_MAC_ADDR_LEN); + memcpy(mac_addr->addr_bytes, addr_bytes, EFX_MAC_ADDR_LEN); mac_addr->refcnt = 1; mac_addr->fw_rsrc.mac_id.id = EFX_MAE_RSRC_ID_INVALID; diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index a19322926572..55aae9ef04f3 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -1526,7 +1526,7 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa, sizeof(rss->key)); return EINVAL; } - rte_memcpy(rss->key, conf->rss_key, sizeof(rss->key)); + memcpy(rss->key, conf->rss_key, sizeof(rss->key)); } rss->hash_types = efx_hash_types; diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c index a0827d1c0dd6..5da2de3c3d49 100644 --- a/drivers/net/sfc/sfc_tso.c +++ b/drivers/net/sfc/sfc_tso.c @@ -159,7 +159,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx, /* Handle TCP header */ th = (const struct rte_tcp_hdr *)(tsoh + tcph_off); - rte_memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); + memcpy(&sent_seq, &th->sent_seq, sizeof(uint32_t)); sent_seq = rte_be_to_cpu_32(sent_seq); efx_tx_qdesc_tso2_create(txq->common, packet_id, 0, sent_seq, diff --git a/drivers/net/sfc/sfc_tso.h b/drivers/net/sfc/sfc_tso.h index 9029ad159014..e914eae77ef8 100644 --- a/drivers/net/sfc/sfc_tso.h +++ b/drivers/net/sfc/sfc_tso.h @@ -35,7 +35,7 @@ sfc_tso_ip4_get_ipid(const uint8_t *pkt_hdrp, size_t ip_hdr_off) uint16_t ipid; ip_hdrp = (const struct rte_ipv4_hdr *)(pkt_hdrp + ip_hdr_off); - rte_memcpy(&ipid, &ip_hdrp->packet_id, sizeof(ipid)); + memcpy(&ipid, &ip_hdrp->packet_id, sizeof(ipid)); return rte_be_to_cpu_16(ipid); } @@ -46,9 +46,8 @@ sfc_tso_outer_udp_fix_len(const struct rte_mbuf *m, uint8_t *tsoh) rte_be16_t len = rte_cpu_to_be_16(m->l2_len + m->l3_len + m->l4_len + m->tso_segsz); - rte_memcpy(tsoh + m->outer_l2_len + m->outer_l3_len + - offsetof(struct rte_udp_hdr, dgram_len), - &len, sizeof(len)); + memcpy(tsoh + m->outer_l2_len + m->outer_l3_len + offsetof(struct rte_udp_hdr, dgram_len), + &len, sizeof(len)); } static inline void @@ -67,7 +66,7 @@ sfc_tso_innermost_ip_fix_len(const struct rte_mbuf *m, uint8_t *tsoh, len = rte_cpu_to_be_16(ip_payload_len); } - rte_memcpy(tsoh + iph_ofst + field_ofst, &len, sizeof(len)); + memcpy(tsoh + iph_ofst + field_ofst, &len, sizeof(len)); } unsigned int sfc_tso_prepare_header(uint8_t *tsoh, size_t header_len, From patchwork Fri Mar 1 17:15:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137710 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 781E743C12; Fri, 1 Mar 2024 18:19:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA41B433E4; Fri, 1 Mar 2024 18:17:46 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 55D7843365 for ; Fri, 1 Mar 2024 18:17:33 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d7232dcb3eso18700375ad.2 for ; Fri, 01 Mar 2024 09:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313452; x=1709918252; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ADwliB5YG1I5rnLwuOE9AHiZ+t1JRTJrOeqRGTG73M4=; b=QMm8f9OItygIVIpCQPBNdTWZi96TgcrDTY0SFFfhB0Y+2Ho1dleHhtVYqHB/aU6tEW JsTqVz4ZUlRQpdKpK4J91ggio4Wbo05mCFsFZ3DU9M4pUUlvWFaVD+ZsXx/tKYX+dguJ 1sSeSH33RMY8zv58qnIdjXrAdtLnlLxuPXQG85V+0kmeve0pNXqmjOGChuFvEwFDPla/ wV2bX2B0p6ZeK3bTuosF0VNfzUFn7oZ6uugQhTKt8JLl/cyfurXjvxi1oiUBn51ix6I7 TK4WGF6KT9EKMhqZQSwKRDuBJuVvM/Dhxiu8JY6eho9qlaCgEDwLIopSxCmxM439AcnB kxJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313452; x=1709918252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADwliB5YG1I5rnLwuOE9AHiZ+t1JRTJrOeqRGTG73M4=; b=muLoXjcbmTB4xqKSG3S3gtXig/BQcLfnt+AfbxsKoU783y6nSFvA/Y0jnPvCEHk37e l844iyyLQ7wdDBfi9IC7CuNAOOAtQvD0lKfp+Q6DxzBJJE6WupPqOlstOcCpve/f0wDk PxFFHIxUQf2iMR+coGzPohY3ilnsgh7v8+TpdVQY/Sppfu2bhMlWAdW6A5+3mVlZ+pHR +waR47x4K60eHhKzs6MKwFFIc+4UFXn8Wg+z1bcpUYjqwsd+/zmBrh4aWIs3D8f17vAO ghPQfdqSA3t9OAVaMhNtqq5QAnIUxMgW/U+67+qVn+jkTShY2wBS8iJhmBdmskUzEFUj kBig== X-Gm-Message-State: AOJu0YzSeWcwO5OdVt+HHwckQjr67PDHiWfVx692h4EBXoAnRHPDpSLL RpNTDYUwkjCDKiW/YP0sbiN7D/zuelKEPadcmKmLI33lt7P/Xt0kkmL65gOKGpc4pwllXg2Lh7I Zr37yqQ== X-Google-Smtp-Source: AGHT+IGOmVlNvJtsnP2Pcn6dtId28ZSuEhHcEKw3sZOdPIUqxNuXlwuD1jgZuWLBgB0rPimhgtbpIg== X-Received: by 2002:a17:902:d488:b0:1dc:c17d:6edd with SMTP id c8-20020a170902d48800b001dcc17d6eddmr2704640plg.20.1709313452591; Fri, 01 Mar 2024 09:17:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 20/71] net/tap: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:16 -0800 Message-ID: <20240301171707.95242-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 69d9da695bed..518619c53b4a 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1404,11 +1404,11 @@ tap_mac_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) mac_addr)) mode = LOCAL_AND_REMOTE; ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(ifr.ifr_hwaddr.sa_data, mac_addr, RTE_ETHER_ADDR_LEN); ret = tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 1, mode); if (ret < 0) return ret; - rte_memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); if (pmd->remote_if_index && !pmd->flow_isolate) { /* Replace MAC redirection rule after a MAC change */ ret = tap_flow_implicit_destroy(pmd, TAP_REMOTE_LOCAL_MAC); @@ -2010,7 +2010,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (rte_is_zero_ether_addr(mac_addr)) rte_eth_random_addr((uint8_t *)&pmd->eth_addr); else - rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); + memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); } /* @@ -2033,8 +2033,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (pmd->type == ETH_TUNTAP_TYPE_TAP) { memset(&ifr, 0, sizeof(struct ifreq)); ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, &pmd->eth_addr, - RTE_ETHER_ADDR_LEN); + memcpy(ifr.ifr_hwaddr.sa_data, &pmd->eth_addr, + RTE_ETHER_ADDR_LEN); if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) goto error_exit; } @@ -2091,8 +2091,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, pmd->name, pmd->remote_iface); goto error_remote; } - rte_memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data, - RTE_ETHER_ADDR_LEN); + memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data, + RTE_ETHER_ADDR_LEN); /* The desired MAC is already in ifreq after SIOCGIFHWADDR. */ if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) { TAP_LOG(ERR, "%s: failed to get %s MAC address.", From patchwork Fri Mar 1 17:15:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137711 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6A6943C12; Fri, 1 Mar 2024 18:20:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FBDE433F8; Fri, 1 Mar 2024 18:17:48 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 576A243380 for ; Fri, 1 Mar 2024 18:17:34 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21726865ad.3 for ; Fri, 01 Mar 2024 09:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313453; x=1709918253; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qwocySNCXgh3M3EevzPG9njYICKO5SkeRDh6ctOKxNE=; b=Ed5kIxsj3PTA+yUNr+h4TtzMIcw/UXJz+8LHaTgaH5gYYylx3KtpzcNBBbJgXuwbsK fX+qTlTNbV8K/8Rkx3HaJh/yBfyL9PxmV7n7srYdQg5m2USQxcZVxU4pzOZ4eA1iycxK pobbNDZlWdZJXS5IH5a1mfA/uwVci1N90fa+7LclKwI98KIHaFdx9Lu8tnN5QPCm15tP WCP3E4JMdaUUjMKS8caHitHAUfPKZxtjZzMbaSmhy7xqh4VrpT9fkmr9JqvYgBCe8IRL RjT5GsI5KHJsMKkK3hBab96hPOCC0VOydEO+VA2aUK3fJUWHWvaim/kjlHWibb8DAAZF SjtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313453; x=1709918253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwocySNCXgh3M3EevzPG9njYICKO5SkeRDh6ctOKxNE=; b=kACqWoaPCIVAX0bUnQzJe7nRJqmM7Zt4AudeQfce3zZOVCzWH3CZ0TTSlq5hQLFruC R/bZYQCoUN+4sITnVHD+MH9pbqBjeCMvcFK5pLAaoBuE5IMOthuOKl6tIJCjpVr8w8KG jgiLNdHUMCQWwSiz6NovyIy929FjVmFXiPB6fqwG9dwSnNYADx2EHwsPP2b7jOZ16288 NobH+ez8pIbf+gxS5oOHhLPlqtID5rz/d08Xd5yX8ZcAmuWE9ukprSObLeaEi17gpDF7 Kg5cwdhCrev/4a/rizbgBijstJD/b/gmFERR4Ce1hGdD6gjxzon60qeJlvg+JlA4+TvS 6IRw== X-Gm-Message-State: AOJu0YwTNsERqDc04JHSpx61wwzULjazLIbaNJYCaXvsrGFeLAgkxcjX w+Coph2uQ4rUjch81wCex9UtGb5UAwGEXLQdFixUf5/iAqu6+x6ezkdi2K+An2mEdZjbjnWXmHt lXTnT/A== X-Google-Smtp-Source: AGHT+IGpc/8wSPTujZOiN2L2QzjUKjE+LzlWY9hErAtNubIKWVIFzO+KlNE+ciJoD2cB0TcUFzMNTw== X-Received: by 2002:a17:902:7805:b0:1db:d256:9327 with SMTP id p5-20020a170902780500b001dbd2569327mr1812623pll.19.1709313453545; Fri, 01 Mar 2024 09:17:33 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH v2 21/71] net/txgbe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:17 -0800 Message-ID: <20240301171707.95242-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 9 ++--- drivers/net/txgbe/txgbe_fdir.c | 6 +-- drivers/net/txgbe/txgbe_flow.c | 65 ++++++++++++++------------------ drivers/net/txgbe/txgbe_ipsec.c | 8 ++-- drivers/net/txgbe/txgbe_pf.c | 4 +- drivers/net/txgbe/txgbe_tm.c | 11 +++--- 6 files changed, 46 insertions(+), 57 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index b75e8898e2d4..1c42fd74b47d 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -4304,9 +4304,8 @@ txgbe_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct txgbe_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, - &filter_5tuple, - sizeof(struct txgbe_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct txgbe_5tuple_filter_info)); filter->queue = ntuple_filter->queue; ret = txgbe_add_5tuple_filter(dev, filter); if (ret < 0) { @@ -5109,9 +5108,7 @@ txgbe_dev_l2_tunnel_filter_add(struct rte_eth_dev *dev, if (!node) return -ENOMEM; - rte_memcpy(&node->key, - &key, - sizeof(struct txgbe_l2_tn_key)); + memcpy(&node->key, &key, sizeof(struct txgbe_l2_tn_key)); node->pool = l2_tunnel->pool; ret = txgbe_insert_l2_tn_filter(l2_tn_info, node); if (ret < 0) { diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c index a198b6781bad..00366ed87323 100644 --- a/drivers/net/txgbe/txgbe_fdir.c +++ b/drivers/net/txgbe/txgbe_fdir.c @@ -42,7 +42,7 @@ else \ ipv6_addr[i] = 0; \ } \ - rte_memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ + memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ } while (0) /** @@ -858,8 +858,8 @@ txgbe_fdir_filter_program(struct rte_eth_dev *dev, sizeof(struct txgbe_fdir_filter), 0); if (!node) return -ENOMEM; - rte_memcpy(&node->input, &rule->input, - sizeof(struct txgbe_atr_input)); + memcpy(&node->input, &rule->input, + sizeof(struct txgbe_atr_input)); node->fdirflags = rule->fdirflags; node->fdirhash = fdirhash; node->queue = queue; diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7ef52d0b0fcd..c76fc0eed0e0 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -1834,10 +1834,10 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused, if (item->spec) { rule->b_spec = TRUE; ipv6_spec = item->spec; - rte_memcpy(rule->input.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(rule->input.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->input.src_ip, ipv6_spec->hdr.src_addr, + 16); + memcpy(rule->input.dst_ip, ipv6_spec->hdr.dst_addr, + 16); } /** @@ -2756,9 +2756,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -2782,9 +2782,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -2806,9 +2806,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&filter_syn_list, syn_filter_ptr, entries); @@ -2827,9 +2826,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct txgbe_hw_fdir_mask)); + memcpy(&fdir_info->mask, &fdir_rule.mask, + sizeof(struct txgbe_hw_fdir_mask)); fdir_info->flex_bytes_offset = fdir_rule.flex_bytes_offset; @@ -2873,9 +2871,9 @@ txgbe_flow_create(struct rte_eth_dev *dev, "failed to allocate memory"); goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, - &fdir_rule, - sizeof(struct txgbe_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, + &fdir_rule, + sizeof(struct txgbe_fdir_rule)); TAILQ_INSERT_TAIL(&filter_fdir_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -2910,9 +2908,8 @@ txgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&l2_tn_filter_ptr->filter_info, - &l2_tn_filter, - sizeof(struct txgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter_ptr->filter_info, &l2_tn_filter, + sizeof(struct txgbe_l2_tunnel_conf)); TAILQ_INSERT_TAIL(&filter_l2_tunnel_list, l2_tn_filter_ptr, entries); flow->rule = l2_tn_filter_ptr; @@ -3038,9 +3035,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct txgbe_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, - &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = txgbe_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_ntuple_list, @@ -3051,9 +3047,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct txgbe_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = txgbe_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3065,9 +3060,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_SYN: syn_filter_ptr = (struct txgbe_eth_syn_filter_ele *) pmd_flow->rule; - rte_memcpy(&syn_filter, - &syn_filter_ptr->filter_info, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter, &syn_filter_ptr->filter_info, + sizeof(struct rte_eth_syn_filter)); ret = txgbe_syn_filter_set(dev, &syn_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_syn_list, @@ -3077,9 +3071,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct txgbe_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct txgbe_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct txgbe_fdir_rule)); ret = txgbe_fdir_filter_program(dev, &fdir_rule, TRUE, FALSE); if (!ret) { TAILQ_REMOVE(&filter_fdir_list, @@ -3092,8 +3085,8 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_L2_TUNNEL: l2_tn_filter_ptr = (struct txgbe_eth_l2_tunnel_conf_ele *) pmd_flow->rule; - rte_memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, - sizeof(struct txgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, + sizeof(struct txgbe_l2_tunnel_conf)); ret = txgbe_dev_l2_tunnel_filter_del(dev, &l2_tn_filter); if (!ret) { TAILQ_REMOVE(&filter_l2_tunnel_list, diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..000dd5ec6d39 100644 --- a/drivers/net/txgbe/txgbe_ipsec.c +++ b/drivers/net/txgbe/txgbe_ipsec.c @@ -658,10 +658,10 @@ txgbe_crypto_add_ingress_sa_from_flow(const void *sess, const struct rte_flow_item_ipv6 *ipv6 = ip_spec; ic_session->src_ip.type = IPv6; ic_session->dst_ip.type = IPv6; - rte_memcpy(ic_session->src_ip.ipv6, - ipv6->hdr.src_addr, 16); - rte_memcpy(ic_session->dst_ip.ipv6, - ipv6->hdr.dst_addr, 16); + memcpy(ic_session->src_ip.ipv6, ipv6->hdr.src_addr, + 16); + memcpy(ic_session->dst_ip.ipv6, ipv6->hdr.dst_addr, + 16); } else { const struct rte_flow_item_ipv4 *ipv4 = ip_spec; ic_session->src_ip.type = IPv4; diff --git a/drivers/net/txgbe/txgbe_pf.c b/drivers/net/txgbe/txgbe_pf.c index 176f79005cde..a0f5a67d9c78 100644 --- a/drivers/net/txgbe/txgbe_pf.c +++ b/drivers/net/txgbe/txgbe_pf.c @@ -435,7 +435,7 @@ txgbe_vf_reset(struct rte_eth_dev *eth_dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = TXGBE_VF_RESET | TXGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -457,7 +457,7 @@ txgbe_vf_set_mac_addr(struct rte_eth_dev *eth_dev, struct rte_ether_addr *ea = (struct rte_ether_addr *)new_mac; if (rte_is_valid_assigned_ether_addr(ea)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.set_rar(hw, rar_entry, new_mac, vf, true); } return -1; diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 3171be73d05d..7d77b01dfef2 100644 --- a/drivers/net/txgbe/txgbe_tm.c +++ b/drivers/net/txgbe/txgbe_tm.c @@ -280,8 +280,8 @@ txgbe_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&tm_conf->shaper_profile_list, shaper_profile, node); @@ -625,8 +625,8 @@ txgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->no = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); tm_conf->root = tm_node; /* increase the reference counter of the shaper profile */ @@ -706,8 +706,7 @@ txgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == TXGBE_TM_NODE_TYPE_PORT) { tm_node->no = parent_node->reference_count; TAILQ_INSERT_TAIL(&tm_conf->tc_list, From patchwork Fri Mar 1 17:15:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137712 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA4A43C12; Fri, 1 Mar 2024 18:20:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E10D433FB; Fri, 1 Mar 2024 18:17:49 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 196EF43380 for ; Fri, 1 Mar 2024 18:17:35 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21726995ad.3 for ; Fri, 01 Mar 2024 09:17:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313454; x=1709918254; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8IXPh2XA6t/KG9Hv6IJExd3Kk0yelBv352QTLzXYV34=; b=vjZJPNnwzAv3GiP/5CCKEV19EoInzYh+AKX9nVTDh+kdJ0gBQwf9OknwYqEfxHFLXP hybSQt/a+OESVK21I/EsBgPPGTwDAnWiy2EoLzR7nXsXQRnt6k7+E+UsjPmHUxh3JPdm ZSPnZ1xtok4GmfW4Td8NPypcTfADPIM7ODHgT3v7Q5+I9gycbGq4+e6bntbKRfA17D6v ib38TtozvcpatBedp+IJ1WO1mjViB+xqODRzrKIHZN+7nPO2Z0BPSzagpTV1GB8znNC3 fycfmV7vk7LzC8uu6yjMg4tMMmPoC/c3/DYlyMr1NWqBCA13+2zwy4CCqLnZdLzJXDZe 6fTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313454; x=1709918254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IXPh2XA6t/KG9Hv6IJExd3Kk0yelBv352QTLzXYV34=; b=xD2fJBj68eTfK80oFq6zf0CAkt+lw9/DXeLQZxjdtO+B8mLXrLdO7VnJtfy6qIowtc zavp+z5aKILnqStaxUiGH9Kc4mMYAApHo3E33iEWizesMVbNKejZhpxg6UiEPxnvDU61 jtRddJ8+oThj0JaP6akKLSn+B8ZdbVelSKBY9wLATrKnERBvagLEr4nGlwJuWyZqCvx/ qmlv6M8G9sFIgBmp43e0WrajLlOqGXw33rhluFcLK+qvb6880X+usfzGRKeKoy9yZbLV moBs237TviJEgtUwGzKu9Sn4LZ6MO6aj3tbylRHO5IxAhaNDfDXxXPPXMcMR/3Zg+SG7 g6EQ== X-Gm-Message-State: AOJu0YyN14cG+ENdskzrmu9gbNBAFaL1HGb5D2iUpaMBbumq7mtp81Sr qDe/juTmULyBfovOVz3bOiuvI7RJe4DFGQE4v+QgmhU31jbhy4xvn4FgHRgrok7OSlUMODbLeg6 gFu1fvA== X-Google-Smtp-Source: AGHT+IExXKQPZ8C3zBve9wq0LvSNQKTgmBWuA7JPR+4nFPgYW2kNZ0L7PK7ZMGhHfX1O7p8fs/a4NA== X-Received: by 2002:a17:902:e943:b0:1db:cea0:9d62 with SMTP id b3-20020a170902e94300b001dbcea09d62mr2746013pll.9.1709313454268; Fri, 01 Mar 2024 09:17:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH v2 22/71] raw/ifpga: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:18 -0800 Message-ID: <20240301171707.95242-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Rosen Xu --- drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +-- drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +-- drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +-- drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++---- drivers/raw/ifpga/ifpga_rawdev.c | 11 +++++------ 5 files changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c index 859f28dcc1f0..c2aaed9203ae 100644 --- a/drivers/raw/ifpga/afu_pmd_he_hssi.c +++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c @@ -15,7 +15,6 @@ #include #include -#include #include #include #include @@ -314,7 +313,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config, if (cfg->port >= NUM_HE_HSSI_PORTS) return -EINVAL; - rte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg)); + memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c index c7c5cda48c35..ffb7075c84d2 100644 --- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c +++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c @@ -15,7 +15,6 @@ #include #include -#include #include #include #include @@ -363,7 +362,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config, if ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES)) return -EINVAL; - rte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg)); + memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c index a1db533eeb93..b799e40d2db9 100644 --- a/drivers/raw/ifpga/afu_pmd_he_mem.c +++ b/drivers/raw/ifpga/afu_pmd_he_mem.c @@ -14,7 +14,6 @@ #include #include -#include #include #include #include @@ -126,7 +125,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config, if (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg)) return -EINVAL; - rte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg)); + memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg)); return 0; } diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c index 67b394126595..9236c0b15371 100644 --- a/drivers/raw/ifpga/afu_pmd_n3000.c +++ b/drivers/raw/ifpga/afu_pmd_n3000.c @@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config, if ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) || (cfg->nlb_cfg.end > MAX_CACHE_LINES)) return -EINVAL; - rte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg, - sizeof(struct rte_pmd_afu_nlb_cfg)); + memcpy(&priv->nlb_cfg, &cfg->nlb_cfg, + sizeof(struct rte_pmd_afu_nlb_cfg)); } else if (cfg->type == RTE_PMD_AFU_N3000_DMA) { if (cfg->dma_cfg.index >= NUM_N3000_DMA) return -EINVAL; @@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config, cfg->dma_cfg.length); } } - rte_memcpy(&priv->dma_cfg, &cfg->dma_cfg, - sizeof(struct rte_pmd_afu_dma_cfg)); + memcpy(&priv->dma_cfg, &cfg->dma_cfg, + sizeof(struct rte_pmd_afu_dma_cfg)); } else { IFPGA_RAWDEV_PMD_ERR("Invalid type of N3000 AFU"); return -EINVAL; diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index f89bd3f9e2c3..d5d47e14dd0e 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -258,7 +257,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev) if (point < 12) return -1; point -= 12; - rte_memcpy(ifpga_dev->parent_bdf, &link[point], 12); + memcpy(ifpga_dev->parent_bdf, &link[point], 12); point = strlen(link1); if (point < 26) @@ -948,10 +947,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev, if (ret) return ret; - rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b, - sizeof(u64)); - rte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8, - sizeof(u64)); + memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b, + sizeof(u64)); + memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8, + sizeof(u64)); IFPGA_RAWDEV_PMD_INFO("%s: uuid_l=0x%lx, uuid_h=0x%lx\n", __func__, From patchwork Fri Mar 1 17:15:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137713 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AEAE43C12; Fri, 1 Mar 2024 18:20:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CB8443401; Fri, 1 Mar 2024 18:17:50 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id C30BA43365 for ; Fri, 1 Mar 2024 18:17:35 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dc418fa351so26370515ad.1 for ; Fri, 01 Mar 2024 09:17:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313455; x=1709918255; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qlT84LLO8F031Gnwzj2I+iXnNWFtKWuZ85KZacOSKt4=; b=pUQPitGkeClSmOLlViZ3pvi31IWto8HAk/kpi3mk8LPpQOlwOT/o8SRrd+Q1iN3yko 2glli9owACGKmXnC/h2YnARvJ+NaisaeBJQpP3Dw2szAFCbYf12y88+7EcmofLwOSD6x R20OLK4SXYw55JLIPiuocHykGa3+bTDZ9tj8E6290BrJHPNE1vy8huGL4ns8wVucRmpe eF2M6q+0YyCsJUaA+zaAbpiJ5Csjy34XwvU1yhkOwkFNapAJwlETOtq8o6pNk9bpvE5n EyF4hmZa8a+A6dW7E9gc6pLCP5/0Hk0w9KTrLaScYf58x+5eAtBn9Xh6ry7GQmCJCfMH c0rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313455; x=1709918255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qlT84LLO8F031Gnwzj2I+iXnNWFtKWuZ85KZacOSKt4=; b=Sczv5AXiBtS3O0lOz31H//AIfEyWsv/A5q+0nclZqMrcetexI7TPd1mwbATdhGwkvH wn7lrWH3ysr2RmoNZjT6chU9jJxc234hpha82iDFj68Z85VSXWqmMIrAg+rn+wPEM+t7 d/B+9s3kFXWC7Gj1qHx8AZOTiQwrqqWqw+PWuzZPXaydlzLKkCdy+AjPmu8oykCRV5zS nlDPObvoZE3fB9OWdf3XFrT7fp9bGaNfqa1ltgTnHlaT/tGE54101hyaxvB8yaU9aACs QCsn2aESnUUoqifEi7OlW4hHUZrsJETBithfFnDeTJZXMIb4VwouqfLmnTYmxc6G7lnP XvKA== X-Gm-Message-State: AOJu0YzIGS/Zf3S0aTfpHt6mkwxC3ADucN1iH3SyPstll3zunsMedsVh l42o/N8mezqgpCpao0KV2uZOC8+cQB6Nh29sJ4HHA43lY6WWMZl+0E55Hsh7vHfA4eAqiTHym+6 rc3N7kw== X-Google-Smtp-Source: AGHT+IHwrLIj1m5+P+Uhj0VitTz5XT5Lqn2GXYydAOrJ5mtlCYoxo0x0x9cXuQVDlM7UzuKhcbnUbg== X-Received: by 2002:a17:902:d4d2:b0:1dc:b7d2:3f28 with SMTP id o18-20020a170902d4d200b001dcb7d23f28mr8187586plg.32.1709313455030; Fri, 01 Mar 2024 09:17:35 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sachin Saxena , Hemant Agrawal Subject: [PATCH v2 23/71] raw/skeleton: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:19 -0800 Message-ID: <20240301171707.95242-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/skeleton/skeleton_rawdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index 6e99d35536d7..967b3964f24a 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -245,8 +245,8 @@ static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev, skelq = &skeldev->queues[queue_id]; if (queue_id < SKELETON_MAX_QUEUES) - rte_memcpy(queue_conf, skelq, - sizeof(struct skeleton_rawdev_queue)); + memcpy(queue_conf, skelq, + sizeof(struct skeleton_rawdev_queue)); return 0; } @@ -281,8 +281,7 @@ static int skeleton_rawdev_queue_setup(struct rte_rawdev *dev, if (skeldev->num_queues > queue_id && q->depth < SKELETON_QUEUE_MAX_DEPTH) { - rte_memcpy(q, queue_conf, - sizeof(struct skeleton_rawdev_queue)); + memcpy(q, queue_conf, sizeof(struct skeleton_rawdev_queue)); clear_queue_bufs(queue_id); } else { SKELETON_PMD_ERR("Invalid queue configuration"); From patchwork Fri Mar 1 17:15:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137714 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73B5643C12; Fri, 1 Mar 2024 18:20:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6206B43417; Fri, 1 Mar 2024 18:17:51 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 8982043389 for ; Fri, 1 Mar 2024 18:17:36 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21727245ad.3 for ; Fri, 01 Mar 2024 09:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313456; x=1709918256; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1eW22QZ42KJpLACHXjb2S2ak0hAYtAORjULbMVpXEH4=; b=gsz4tyMAtLl16fvu6yVNVnU4uP+NVitcYy25FC4cm0vNzL75AxKMC8sDTv5eAC6wAb qasbo5G6vaqZLYby82ATCyEk/tLus5biC5lJF9Voe8i4eAHOxyGTP5yu88nxHvbN9Gie W96ErK8FzXVVhibCvXUHiTWLqYeYYExzN8mn77+2BDsTKHpWD9ZhA1ZTmTM95Sru6ob1 u/fZTJ20jWn2aCWHRYF6czbrTTtR2AH/F8IfYXNC/jAQ2ZeRvpXTliu3CINqPXCufZPp pvadYfJGWvTn6Gwwwhfpjm/vK4pdN9VGAcpFtq++F7wRkWF6SdfBNfS9NqydrcTsgsOj 5BTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313456; x=1709918256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1eW22QZ42KJpLACHXjb2S2ak0hAYtAORjULbMVpXEH4=; b=Gjk5bnP0074XQWI2nIN+DGdcGz+E+NVE99Zc4GV6EdM7/VtaJYnHM5LIJrFPD0yOJD U+zr+tHvbgEEKlLup1L5kgJwTB3tTTbiEdLYv1IJs8C4hbqK+s/R/c4o76UoPh8Y5YOK JhJWhfZR9tQbQWQHZZSREF4RBJC9OWI/7zVML5k31Ijfd/mT8TrhO2ITnZYS/KtpV+Ox 0miHCOUT6ndAJgSqACmdVxycIzUfZm8epIOMP1NvitFmcz3vCLXZFT5TFIXSqcEUxPX5 WlcsIHbi+SjLNKoNLZHf/h4q3UjDrYERxiFkEwGOOIAlDjjE7vAYlkwmkujOwmSBv3bp peRw== X-Gm-Message-State: AOJu0Yzg/RFzIsdjsuR03No2QfN2s0f3zIKA0vxqZerzvtb73qmLKHK1 lHaakrkIwNOKh2c/xR64wR/bAxXFPqbZBfczrhlvjouIOK0VB9KdcP3MKU2JloK4HD2h0OoEP1U 0dKh5rQ== X-Google-Smtp-Source: AGHT+IFkWaiGk+kljo347tIgOKL4vnwX9VK7JmAHbnjiK4MQsqANgjIIJUKje14xnw1DoLopFMTrzA== X-Received: by 2002:a17:902:e80b:b0:1dc:bce8:6e23 with SMTP id u11-20020a170902e80b00b001dcbce86e23mr2742953plg.7.1709313455805; Fri, 01 Mar 2024 09:17:35 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jie Hai , Yisen Zhuang Subject: [PATCH v2 24/71] net/hns3: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:20 -0800 Message-ID: <20240301171707.95242-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_fdir.c | 2 +- drivers/net/hns3/hns3_flow.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c index d100e58d102b..332cbb847be3 100644 --- a/drivers/net/hns3/hns3_fdir.c +++ b/drivers/net/hns3/hns3_fdir.c @@ -996,7 +996,7 @@ int hns3_fdir_filter_program(struct hns3_adapter *hns, return -ENOMEM; } - rte_memcpy(&node->fdir_conf, rule, sizeof(struct hns3_fdir_rule)); + memcpy(&node->fdir_conf, rule, sizeof(struct hns3_fdir_rule)); ret = hns3_insert_fdir_filter(hw, fdir_info, node); if (ret < 0) { rte_free(node); diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 7fbe65313ca2..96b91bed6b18 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -2416,8 +2416,8 @@ hns3_flow_query(struct rte_eth_dev *dev, struct rte_flow *flow, } rss_conf = (struct rte_flow_action_rss *)data; rss_rule = (struct hns3_rss_conf_ele *)flow->rule; - rte_memcpy(rss_conf, &rss_rule->filter_info.conf, - sizeof(struct rte_flow_action_rss)); + memcpy(rss_conf, &rss_rule->filter_info.conf, + sizeof(struct rte_flow_action_rss)); break; default: return rte_flow_error_set(error, ENOTSUP, From patchwork Fri Mar 1 17:15:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137715 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 991C643C12; Fri, 1 Mar 2024 18:20:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DF0F433EC; Fri, 1 Mar 2024 18:17:52 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 8818643391 for ; Fri, 1 Mar 2024 18:17:37 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1dc75972f25so21374805ad.1 for ; Fri, 01 Mar 2024 09:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313457; x=1709918257; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TS0Y82C50IXLWOuwUCN6eRSQrrai0mBOAwp6IHmBJM4=; b=DKWRaA3mzbVtJKGhAHtUtQ6Fm9KeidbH2Cx38L1X5E8fXSTW81hiGAeOsuPNPnh9J5 /VwUFJpcsi7Yj4WxmXkeyuZZruXBGbJETQhwxGxEwtEc7n9XvDVV2godG+QUR6qiSTvn fPCqEyaYfJXdH/CblEwcO0UZhrmPy7BxEjX/pgmXu0Nyc85noThA/jChbAQkILfLWG/2 c3JnNOJL7r6EQVwhp/VcAr2ylhKcXx9WA7vUkDMyEzk4okHX6cxK5qgHcg+wU4qD3Btp chZAk2Cvg3Mitxt4fAg5Gl4pJ3Fa1mn+gu25NPCNCq6W/kyASg93J+QhEQOVokkYV46a Y4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313457; x=1709918257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TS0Y82C50IXLWOuwUCN6eRSQrrai0mBOAwp6IHmBJM4=; b=iCIsB396YZK9xSZZi1ai6wDVUUGKNKK9e3X9wU/dJubsuYcZn0fxGMdpOnlRcfnILj R3dKUu5b+2UawkzbVnQZgdKMsxeE1xzSe8OssLa3dxA9Zr8S7I6hZG39J/HB3NwMJEw2 fLny5X6I8CmgjEhUDNVwDsV6h9IO8rt+/N386eIpS6SSdRR9QrAXXw2KO38XTP+4aMnI V6o37/P7v8/yoGqGUUU7IdBEGN9B2Tc7rpCtACrX7BRPjJmAjOy0bdAeDpp35UdWQWgr SQt6zTJbmVfpXPOTR5hp2OY8+ie7k/UrB5XTcT+8vzrbdqHXdloylNKIrysQoSlpjK8U Fuuw== X-Gm-Message-State: AOJu0YzN+W8cDr+eH37hg/ZbG6j2PRMimhPNzk6MU/cEMEhTrHdaVNA2 pthF23mFduPzzBhy4a4J4K9qOCrIqa3a15Gw5moihsWsW7BasKRhvyNPgP9hXT0qkoem/CnZk93 VrOhGmw== X-Google-Smtp-Source: AGHT+IEJ2AI2A4PXH7QWswb1Pl+gt6cMF8gwgWO825iLJOSfVYqMzyrwBBoRP6/GArj8+vx2Cu7gcQ== X-Received: by 2002:a17:903:2b0b:b0:1dc:cbc0:196f with SMTP id mc11-20020a1709032b0b00b001dccbc0196fmr2766956plb.10.1709313456606; Fri, 01 Mar 2024 09:17:36 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang Subject: [PATCH v2 25/71] net/i40e: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:21 -0800 Message-ID: <20240301171707.95242-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 109 ++++++++++++++------------------ drivers/net/i40e/i40e_fdir.c | 28 ++++---- drivers/net/i40e/i40e_flow.c | 56 ++++++++-------- drivers/net/i40e/i40e_pf.c | 3 +- drivers/net/i40e/i40e_tm.c | 11 ++-- drivers/net/i40e/rte_pmd_i40e.c | 34 +++++----- 6 files changed, 108 insertions(+), 133 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4d21341382d8..9ccfe88a3318 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -4310,7 +4309,7 @@ i40e_macaddr_add(struct rte_eth_dev *dev, return -EINVAL; } - rte_memcpy(&mac_filter.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); + memcpy(&mac_filter.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) mac_filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; else @@ -5195,7 +5194,7 @@ i40e_vsi_vlan_pvid_set(struct i40e_vsi *vsi, vsi->info.valid_sections = rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID); memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -5234,8 +5233,8 @@ i40e_vsi_update_tc_bandwidth(struct i40e_vsi *vsi, uint8_t enabled_tcmap) return ret; } - rte_memcpy(vsi->info.qs_handle, tc_bw_data.qs_handles, - sizeof(vsi->info.qs_handle)); + memcpy(vsi->info.qs_handle, tc_bw_data.qs_handles, + sizeof(vsi->info.qs_handle)); return I40E_SUCCESS; } @@ -5492,8 +5491,7 @@ i40e_update_default_filter_setting(struct i40e_vsi *vsi) if (vsi->type != I40E_VSI_MAIN) return I40E_ERR_CONFIG; memset(&def_filter, 0, sizeof(def_filter)); - rte_memcpy(def_filter.mac_addr, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(def_filter.mac_addr, hw->mac.perm_addr, ETH_ADDR_LEN); def_filter.vlan_tag = 0; def_filter.flags = I40E_AQC_MACVLAN_DEL_PERFECT_MATCH | I40E_AQC_MACVLAN_DEL_IGNORE_VLAN; @@ -5511,16 +5509,15 @@ i40e_update_default_filter_setting(struct i40e_vsi *vsi) return I40E_ERR_NO_MEMORY; } mac = &f->mac_info.mac_addr; - rte_memcpy(&mac->addr_bytes, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(&mac->addr_bytes, hw->mac.perm_addr, ETH_ADDR_LEN); f->mac_info.filter_type = I40E_MACVLAN_PERFECT_MATCH; TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); vsi->mac_num++; return ret; } - rte_memcpy(&filter.mac_addr, - (struct rte_ether_addr *)(hw->mac.perm_addr), ETH_ADDR_LEN); + memcpy(&filter.mac_addr, (struct rte_ether_addr *)(hw->mac.perm_addr), + ETH_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; return i40e_vsi_add_mac(vsi, &filter); } @@ -5839,8 +5836,8 @@ i40e_vsi_setup(struct i40e_pf *pf, PMD_DRV_LOG(ERR, "Failed to get VSI params"); goto fail_msix_alloc; } - rte_memcpy(&vsi->info, &ctxt.info, - sizeof(struct i40e_aqc_vsi_properties_data)); + memcpy(&vsi->info, &ctxt.info, + sizeof(struct i40e_aqc_vsi_properties_data)); vsi->vsi_id = ctxt.vsi_number; vsi->info.valid_sections = 0; @@ -5857,8 +5854,8 @@ i40e_vsi_setup(struct i40e_pf *pf, rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID); vsi->info.port_vlan_flags = I40E_AQ_VSI_PVLAN_MODE_ALL | I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH; - rte_memcpy(&ctxt.info, &vsi->info, - sizeof(struct i40e_aqc_vsi_properties_data)); + memcpy(&ctxt.info, &vsi->info, + sizeof(struct i40e_aqc_vsi_properties_data)); ret = i40e_vsi_config_tc_queue_mapping(vsi, &ctxt.info, I40E_DEFAULT_TCMAP); if (ret != I40E_SUCCESS) { @@ -5878,16 +5875,15 @@ i40e_vsi_setup(struct i40e_pf *pf, goto fail_msix_alloc; } - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; - rte_memcpy(pf->dev_addr.addr_bytes, hw->mac.perm_addr, - ETH_ADDR_LEN); + memcpy(pf->dev_addr.addr_bytes, hw->mac.perm_addr, + ETH_ADDR_LEN); /** * Updating default filter settings are necessary to prevent @@ -6030,7 +6026,7 @@ i40e_vsi_setup(struct i40e_pf *pf, if (vsi->type != I40E_VSI_FDIR) { /* MAC/VLAN configuration for non-FDIR VSI*/ - rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; ret = i40e_vsi_add_mac(vsi, &filter); @@ -6143,7 +6139,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on) vsi->info.port_vlan_flags &= ~(I40E_AQ_VSI_PVLAN_EMOD_MASK); vsi->info.port_vlan_flags |= vlan_flags; ctxt.seid = vsi->seid; - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); if (ret) PMD_DRV_LOG(INFO, "Update VSI failed to %s vlan stripping", @@ -7010,8 +7006,8 @@ i40e_add_macvlan_filters(struct i40e_vsi *vsi, memset(req_list, 0, ele_buff_size); for (i = 0; i < actual_num; i++) { - rte_memcpy(req_list[i].mac_addr, - &filter[num + i].macaddr, ETH_ADDR_LEN); + memcpy(req_list[i].mac_addr, &filter[num + i].macaddr, + ETH_ADDR_LEN); req_list[i].vlan_tag = rte_cpu_to_le_16(filter[num + i].vlan_id); @@ -7086,8 +7082,8 @@ i40e_remove_macvlan_filters(struct i40e_vsi *vsi, memset(req_list, 0, ele_buff_size); for (i = 0; i < actual_num; i++) { - rte_memcpy(req_list[i].mac_addr, - &filter[num + i].macaddr, ETH_ADDR_LEN); + memcpy(req_list[i].mac_addr, &filter[num + i].macaddr, + ETH_ADDR_LEN); req_list[i].vlan_tag = rte_cpu_to_le_16(filter[num + i].vlan_id); @@ -7243,8 +7239,8 @@ i40e_find_all_vlan_for_mac(struct i40e_vsi *vsi, "vlan number doesn't match"); return I40E_ERR_PARAM; } - rte_memcpy(&mv_f[i].macaddr, - addr, ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, addr, + ETH_ADDR_LEN); mv_f[i].vlan_id = j * I40E_UINT32_BIT_SIZE + k; i++; @@ -7272,8 +7268,7 @@ i40e_find_all_mac_for_vlan(struct i40e_vsi *vsi, PMD_DRV_LOG(ERR, "buffer number not match"); return I40E_ERR_PARAM; } - rte_memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, ETH_ADDR_LEN); mv_f[i].vlan_id = vlan; mv_f[i].filter_type = f->mac_info.filter_type; i++; @@ -7308,8 +7303,8 @@ i40e_vsi_remove_all_macvlan_filter(struct i40e_vsi *vsi) i = 0; if (vsi->vlan_num == 0) { TAILQ_FOREACH(f, &vsi->mac_list, next) { - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); mv_f[i].filter_type = f->mac_info.filter_type; mv_f[i].vlan_id = 0; i++; @@ -7478,8 +7473,7 @@ i40e_vsi_add_mac(struct i40e_vsi *vsi, struct i40e_mac_filter_info *mac_filter) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = mac_filter->filter_type; - rte_memcpy(&mv_f[i].macaddr, &mac_filter->mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &mac_filter->mac_addr, ETH_ADDR_LEN); } if (mac_filter->filter_type == I40E_MACVLAN_PERFECT_MATCH || @@ -7501,8 +7495,7 @@ i40e_vsi_add_mac(struct i40e_vsi *vsi, struct i40e_mac_filter_info *mac_filter) ret = I40E_ERR_NO_MEMORY; goto DONE; } - rte_memcpy(&f->mac_info.mac_addr, &mac_filter->mac_addr, - ETH_ADDR_LEN); + memcpy(&f->mac_info.mac_addr, &mac_filter->mac_addr, ETH_ADDR_LEN); f->mac_info.filter_type = mac_filter->filter_type; TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); vsi->mac_num++; @@ -7548,8 +7541,7 @@ i40e_vsi_delete_mac(struct i40e_vsi *vsi, struct rte_ether_addr *addr) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = filter_type; - rte_memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, ETH_ADDR_LEN); } if (filter_type == I40E_MACVLAN_PERFECT_MATCH || filter_type == I40E_MACVLAN_HASH_MATCH) { @@ -7835,9 +7827,8 @@ i40e_tunnel_filter_convert( tunnel_filter->input.flags = cld_filter->element.flags; tunnel_filter->input.tenant_id = cld_filter->element.tenant_id; tunnel_filter->queue = cld_filter->element.queue_number; - rte_memcpy(tunnel_filter->input.general_fields, - cld_filter->general_fields, - sizeof(cld_filter->general_fields)); + memcpy(tunnel_filter->input.general_fields, + cld_filter->general_fields, sizeof(cld_filter->general_fields)); return 0; } @@ -8384,9 +8375,8 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, ip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV4; ipv4_addr = rte_be_to_cpu_32(tunnel_filter->ip_addr.ipv4_addr); ipv4_addr_le = rte_cpu_to_le_32(ipv4_addr); - rte_memcpy(&pfilter->element.ipaddr.v4.data, - &ipv4_addr_le, - sizeof(pfilter->element.ipaddr.v4.data)); + memcpy(&pfilter->element.ipaddr.v4.data, &ipv4_addr_le, + sizeof(pfilter->element.ipaddr.v4.data)); } else { ip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV6; for (i = 0; i < 4; i++) { @@ -8394,9 +8384,8 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, rte_cpu_to_le_32(rte_be_to_cpu_32( tunnel_filter->ip_addr.ipv6_addr[i])); } - rte_memcpy(&pfilter->element.ipaddr.v6.data, - &convert_ipv6, - sizeof(pfilter->element.ipaddr.v6.data)); + memcpy(&pfilter->element.ipaddr.v6.data, &convert_ipv6, + sizeof(pfilter->element.ipaddr.v6.data)); } /* check tunneled type */ @@ -8641,7 +8630,7 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf, return -ENOMEM; } - rte_memcpy(tunnel, &check_filter, sizeof(check_filter)); + memcpy(tunnel, &check_filter, sizeof(check_filter)); ret = i40e_sw_tunnel_filter_insert(pf, tunnel); if (ret < 0) rte_free(tunnel); @@ -9766,8 +9755,7 @@ static int i40e_ethertype_filter_convert(const struct rte_eth_ethertype_filter *input, struct i40e_ethertype_filter *filter) { - rte_memcpy(&filter->input.mac_addr, &input->mac_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->input.mac_addr, &input->mac_addr, RTE_ETHER_ADDR_LEN); filter->input.ether_type = input->ether_type; filter->flags = input->flags; filter->queue = input->queue; @@ -9914,8 +9902,7 @@ i40e_ethertype_filter_set(struct i40e_pf *pf, return -ENOMEM; } - rte_memcpy(ethertype_filter, &check_filter, - sizeof(check_filter)); + memcpy(ethertype_filter, &check_filter, sizeof(check_filter)); ret = i40e_sw_ethertype_filter_insert(pf, ethertype_filter); if (ret < 0) rte_free(ethertype_filter); @@ -10795,11 +10782,10 @@ i40e_vsi_config_tc(struct i40e_vsi *vsi, uint8_t tc_map) goto out; } /* update the local VSI info with updated queue map */ - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; @@ -11551,9 +11537,8 @@ i40e_tunnel_filter_restore(struct i40e_pf *pf) cld_filter.element.flags = f->input.flags; cld_filter.element.tenant_id = f->input.tenant_id; cld_filter.element.queue_number = f->queue; - rte_memcpy(cld_filter.general_fields, - f->input.general_fields, - sizeof(f->input.general_fields)); + memcpy(cld_filter.general_fields, f->input.general_fields, + sizeof(f->input.general_fields)); if (((f->input.flags & I40E_AQC_ADD_CLOUD_FILTER_0X11) == diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 47f79ecf11cc..554b763e9f84 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -464,10 +464,10 @@ fill_ip6_head(const struct i40e_fdir_input *fdir_input, unsigned char *raw_pkt, * need to be presented in a reversed order with respect * to the expected received packets. */ - rte_memcpy(&ip6->src_addr, &fdir_input->flow.ipv6_flow.dst_ip, - IPV6_ADDR_LEN); - rte_memcpy(&ip6->dst_addr, &fdir_input->flow.ipv6_flow.src_ip, - IPV6_ADDR_LEN); + memcpy(&ip6->src_addr, &fdir_input->flow.ipv6_flow.dst_ip, + IPV6_ADDR_LEN); + memcpy(&ip6->dst_addr, &fdir_input->flow.ipv6_flow.src_ip, + IPV6_ADDR_LEN); len += sizeof(struct rte_ipv6_hdr); return len; @@ -528,18 +528,16 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf *pf, [I40E_FILTER_PCTYPE_NONF_IPV6_OTHER] = IPPROTO_NONE, }; - rte_memcpy(raw_pkt, &fdir_input->flow.l2_flow.dst, - sizeof(struct rte_ether_addr)); - rte_memcpy(raw_pkt + sizeof(struct rte_ether_addr), - &fdir_input->flow.l2_flow.src, - sizeof(struct rte_ether_addr)); + memcpy(raw_pkt, &fdir_input->flow.l2_flow.dst, + sizeof(struct rte_ether_addr)); + memcpy(raw_pkt + sizeof(struct rte_ether_addr), + &fdir_input->flow.l2_flow.src, sizeof(struct rte_ether_addr)); raw_pkt += 2 * sizeof(struct rte_ether_addr); if (vlan && fdir_input->flow_ext.vlan_tci) { - rte_memcpy(raw_pkt, vlan_frame, sizeof(vlan_frame)); - rte_memcpy(raw_pkt + sizeof(uint16_t), - &fdir_input->flow_ext.vlan_tci, - sizeof(uint16_t)); + memcpy(raw_pkt, vlan_frame, sizeof(vlan_frame)); + memcpy(raw_pkt + sizeof(uint16_t), + &fdir_input->flow_ext.vlan_tci, sizeof(uint16_t)); raw_pkt += sizeof(vlan_frame); len += sizeof(vlan_frame); } @@ -1003,7 +1001,7 @@ static int i40e_fdir_filter_convert(const struct i40e_fdir_filter_conf *input, struct i40e_fdir_filter *filter) { - rte_memcpy(&filter->fdir, input, sizeof(struct i40e_fdir_filter_conf)); + memcpy(&filter->fdir, input, sizeof(struct i40e_fdir_filter_conf)); if (input->input.flow_ext.pkt_template) { filter->fdir.input.flow.raw_flow.packet = NULL; filter->fdir.input.flow.raw_flow.length = @@ -1060,7 +1058,7 @@ i40e_sw_fdir_filter_insert(struct i40e_pf *pf, struct i40e_fdir_filter *filter) return -1; hash_filter = &fdir_info->fdir_filter_array[ret]; - rte_memcpy(hash_filter, filter, sizeof(*filter)); + memcpy(hash_filter, filter, sizeof(*filter)); fdir_info->hash_map[ret] = hash_filter; TAILQ_INSERT_TAIL(&fdir_info->fdir_list, hash_filter, rules); diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 92165c8422d5..9afb7a540d21 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -1175,7 +1175,7 @@ i40e_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ @@ -1986,10 +1986,10 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, filter->input.flow_ext.oip_type = I40E_FDIR_IPTYPE_IPV6; - rte_memcpy(filter->input.flow.ipv6_flow.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(filter->input.flow.ipv6_flow.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(filter->input.flow.ipv6_flow.src_ip, + ipv6_spec->hdr.src_addr, 16); + memcpy(filter->input.flow.ipv6_flow.dst_ip, + ipv6_spec->hdr.dst_addr, 16); /* Check if it is fragment. */ if (ipv6_spec->hdr.proto == @@ -2926,14 +2926,14 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev, } if (!vxlan_flag) { - rte_memcpy(&filter->outer_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->outer_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_OMAC; } else { - rte_memcpy(&filter->inner_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->inner_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_IMAC; } } @@ -3026,8 +3026,8 @@ i40e_flow_parse_vxlan_pattern(__rte_unused struct rte_eth_dev *dev, return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - vxlan_spec->hdr.vni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + vxlan_spec->hdr.vni, 3); filter->tenant_id = rte_be_to_cpu_32(tenant_id_be); filter_type |= RTE_ETH_TUNNEL_FILTER_TENID; @@ -3156,14 +3156,14 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev, } if (!nvgre_flag) { - rte_memcpy(&filter->outer_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->outer_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_OMAC; } else { - rte_memcpy(&filter->inner_mac, - ð_spec->hdr.dst_addr, - RTE_ETHER_ADDR_LEN); + memcpy(&filter->inner_mac, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); filter_type |= RTE_ETH_TUNNEL_FILTER_IMAC; } } @@ -3278,8 +3278,8 @@ i40e_flow_parse_nvgre_pattern(__rte_unused struct rte_eth_dev *dev, "Invalid NVGRE item"); return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - nvgre_spec->tni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + nvgre_spec->tni, 3); filter->tenant_id = rte_be_to_cpu_32(tenant_id_be); filter_type |= RTE_ETH_TUNNEL_FILTER_TENID; @@ -3447,8 +3447,8 @@ i40e_flow_parse_mpls_pattern(__rte_unused struct rte_eth_dev *dev, "Invalid MPLS label mask"); return -rte_errno; } - rte_memcpy(((uint8_t *)&label_be + 1), - mpls_spec->label_tc_s, 3); + memcpy(((uint8_t *)&label_be + 1), + mpls_spec->label_tc_s, 3); filter->tenant_id = rte_be_to_cpu_32(label_be) >> 4; break; default: @@ -4051,9 +4051,8 @@ i40e_flow_destroy_tunnel_filter(struct i40e_pf *pf, cld_filter.element.flags = filter->input.flags; cld_filter.element.tenant_id = filter->input.tenant_id; cld_filter.element.queue_number = filter->queue; - rte_memcpy(cld_filter.general_fields, - filter->input.general_fields, - sizeof(cld_filter.general_fields)); + memcpy(cld_filter.general_fields, filter->input.general_fields, + sizeof(cld_filter.general_fields)); if (!filter->is_to_vf) vsi = pf->main_vsi; @@ -4271,9 +4270,8 @@ i40e_flow_query(struct rte_eth_dev *dev __rte_unused, "action not supported"); return -rte_errno; } - rte_memcpy(rss_conf, - &rss_rule->rss_filter_info.conf, - sizeof(struct rte_flow_action_rss)); + memcpy(rss_conf, &rss_rule->rss_filter_info.conf, + sizeof(struct rte_flow_action_rss)); break; default: return rte_flow_error_set(error, ENOTSUP, diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..f8073ef9cb47 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -16,7 +16,6 @@ #include #include #include -#include #include "i40e_logs.h" #include "base/i40e_prototype.h" @@ -869,7 +868,7 @@ i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf, for (i = 0; i < addr_list->num_elements; i++) { mac = (struct rte_ether_addr *)(addr_list->list[i].addr); - rte_memcpy(&filter.mac_addr, mac, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, mac, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; if (rte_is_zero_ether_addr(mac) || i40e_vsi_add_mac(vf->vsi, &filter)) { diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index cab296e1a4af..3f77a7b3a056 100644 --- a/drivers/net/i40e/i40e_tm.c +++ b/drivers/net/i40e/i40e_tm.c @@ -279,8 +279,8 @@ i40e_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&pf->tm_conf.shaper_profile_list, shaper_profile, node); @@ -526,8 +526,8 @@ i40e_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); pf->tm_conf.root = tm_node; /* increase the reference counter of the shaper profile */ @@ -600,8 +600,7 @@ i40e_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == I40E_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&pf->tm_conf.tc_list, tm_node, node); diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 9d39984ea1fc..03d0b61902a9 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -90,7 +90,7 @@ rte_pmd_i40e_set_vf_mac_anti_spoof(uint16_t port, uint16_t vf_id, uint8_t on) vsi->info.sec_flags &= ~I40E_AQ_VSI_SEC_FLAG_ENABLE_MAC_CHK; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -192,7 +192,7 @@ rte_pmd_i40e_set_vf_vlan_anti_spoof(uint16_t port, uint16_t vf_id, uint8_t on) vsi->info.sec_flags &= ~I40E_AQ_VSI_SEC_FLAG_ENABLE_VLAN_CHK; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -237,9 +237,8 @@ i40e_vsi_rm_mac_filter(struct i40e_vsi *vsi) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = filter_type; - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); } if (filter_type == I40E_MACVLAN_PERFECT_MATCH || filter_type == I40E_MACVLAN_HASH_MATCH) { @@ -298,9 +297,8 @@ i40e_vsi_restore_mac_filter(struct i40e_vsi *vsi) for (i = 0; i < vlan_num; i++) { mv_f[i].filter_type = f->mac_info.filter_type; - rte_memcpy(&mv_f[i].macaddr, - &f->mac_info.mac_addr, - ETH_ADDR_LEN); + memcpy(&mv_f[i].macaddr, &f->mac_info.mac_addr, + ETH_ADDR_LEN); } if (f->mac_info.filter_type == I40E_MACVLAN_PERFECT_MATCH || @@ -380,7 +378,7 @@ i40e_vsi_set_tx_loopback(struct i40e_vsi *vsi, uint8_t on) vsi->info.switch_id &= ~I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); @@ -705,7 +703,7 @@ int rte_pmd_i40e_set_vf_vlan_insert(uint16_t port, uint16_t vf_id, vsi->info.port_vlan_flags &= ~I40E_AQ_VSI_PVLAN_INSERT_PVID; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -767,7 +765,7 @@ int rte_pmd_i40e_set_vf_broadcast(uint16_t port, uint16_t vf_id, } if (on) { - rte_memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); + memcpy(&filter.mac_addr, &broadcast, RTE_ETHER_ADDR_LEN); filter.filter_type = I40E_MACVLAN_PERFECT_MATCH; ret = i40e_vsi_add_mac(vsi, &filter); } else { @@ -839,7 +837,7 @@ int rte_pmd_i40e_set_vf_vlan_tag(uint16_t port, uint16_t vf_id, uint8_t on) } memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.seid = vsi->seid; hw = I40E_VSI_TO_HW(vsi); @@ -2586,11 +2584,10 @@ i40e_vsi_update_queue_region_mapping(struct i40e_hw *hw, return ret; } /* update the local VSI info with updated queue map */ - rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, - sizeof(vsi->info.tc_mapping)); - rte_memcpy(&vsi->info.queue_mapping, - &ctxt.info.queue_mapping, - sizeof(vsi->info.queue_mapping)); + memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, + sizeof(vsi->info.tc_mapping)); + memcpy(&vsi->info.queue_mapping, &ctxt.info.queue_mapping, + sizeof(vsi->info.queue_mapping)); vsi->info.mapping_flags = ctxt.info.mapping_flags; vsi->info.valid_sections = 0; @@ -2961,8 +2958,7 @@ i40e_queue_region_get_all_info(struct i40e_pf *pf, { struct i40e_queue_regions *info = &pf->queue_region; - rte_memcpy(regions_ptr, info, - sizeof(struct i40e_queue_regions)); + memcpy(regions_ptr, info, sizeof(struct i40e_queue_regions)); return 0; } From patchwork Fri Mar 1 17:15:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137716 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F366443C12; Fri, 1 Mar 2024 18:20:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FD844341B; Fri, 1 Mar 2024 18:17:53 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 3802443389 for ; Fri, 1 Mar 2024 18:17:38 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21727605ad.3 for ; Fri, 01 Mar 2024 09:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313457; x=1709918257; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pJfsyrMcQ8xTN23o1pauOoIoqNV5wjsYf/z1finubS0=; b=XPk9mRiE4kGS1n4uszMsKfRL9PKuqz/H+DppJxNct8DCk0lGG4fUtfF+2ZKBzyudM1 D4Cr5XD5fPFmjBWc4p2vStOMiE1tC6pPoS4SvPp2fXQAWDED1FnLyPS1fmsjj6rI7dvb PHi60P6VvuAo/9BZcuFURRNsSGVZfRQupgzNiTenkP89Ct4suBj4bPV9ileEie+ApavY 6w3mvT3aErU01Q5DmjK0E99Gq9Mtcmbm8Qbq/qzQcNoTA4yJF/uN2ADpaTFIs411rlRe 46WhFOZZTumwZHVdHAP9lCeZ5Mf5HkvfpvOtpGBJoHcQDKq003ICuyKltAOcntfMqsRo F3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313457; x=1709918257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJfsyrMcQ8xTN23o1pauOoIoqNV5wjsYf/z1finubS0=; b=W7gq9Sy/YmYQjE1pW7rt0sE3Le08zijDXVUnIp1G2hOY6eU2PZYChjxXirG7mP+8d9 WJijS6VD6VA69lqaIppfCr/XA03zYMgMSmjfqsXRZbrwf+QH/0sTN1E+4i1/QVSJ+CYL gYXglGZKCxk0taDdpTvQ+Ij+1jmfyuboiO9x+ML451mPUZfYsvbVU2QV49I0gkP3AGxT Bqgaa4KjopfWW5NpNRIcsXHESd1pP7H7zrHxF2AITyHJxiB9B0UdcTn+HD8R91YZgq0d tTdTViBEZeVriOMLzW8IRe5ZFWubHquHoo0leeOfO1FRMRCUYZlPdIVMMYLUpAyQUG0q VLWg== X-Gm-Message-State: AOJu0YxBbKXFN+wx7K+3v4oGJNwok3YeIJCKoOsDHEDC4oF8MmuyGrs0 UHNHLzE6Yx2fnrf+FWD+ykeAdEJR7MOwNTYQ3bTqIwbsMUFfIGlCkCunN3vE/S1ONUUpPDHla7w CYmPzcw== X-Google-Smtp-Source: AGHT+IEtGQWjhlqujcGrL3frM9gRzGzjwW1jbed9621vkTQvAUF/Nx6KoZSo26grmM8HTAgaJRA2wA== X-Received: by 2002:a17:903:1c5:b0:1db:f941:c9a with SMTP id e5-20020a17090301c500b001dbf9410c9amr3053540plh.45.1709313457369; Fri, 01 Mar 2024 09:17:37 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH v2 26/71] net/iavf: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:22 -0800 Message-ID: <20240301171707.95242-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_fdir.c | 93 +++++++++++++--------------- drivers/net/iavf/iavf_fsub.c | 50 +++++++-------- drivers/net/iavf/iavf_generic_flow.c | 2 +- drivers/net/iavf/iavf_tm.c | 11 ++-- drivers/net/iavf/iavf_vchnl.c | 9 ++- 5 files changed, 77 insertions(+), 88 deletions(-) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index 811a10287b70..35257c43f135 100644 --- a/drivers/net/iavf/iavf_fdir.c +++ b/drivers/net/iavf/iavf_fdir.c @@ -374,7 +374,7 @@ iavf_fdir_create(struct iavf_adapter *ad, if (filter->mark_flag == 1) iavf_fdir_rx_proc_enable(ad, 1); - rte_memcpy(rule, filter, sizeof(*rule)); + memcpy(rule, filter, sizeof(*rule)); flow->rule = rule; return 0; @@ -672,15 +672,13 @@ iavf_fdir_refine_input_set(const uint64_t input_set, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV4, PROT); memset(&ipv4_spec, 0, sizeof(ipv4_spec)); ipv4_spec.hdr.next_proto_id = proto_id; - rte_memcpy(hdr->buffer, &ipv4_spec.hdr, - sizeof(ipv4_spec.hdr)); + memcpy(hdr->buffer, &ipv4_spec.hdr, sizeof(ipv4_spec.hdr)); return true; case VIRTCHNL_PROTO_HDR_IPV6: VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, PROT); memset(&ipv6_spec, 0, sizeof(ipv6_spec)); ipv6_spec.hdr.proto = proto_id; - rte_memcpy(hdr->buffer, &ipv6_spec.hdr, - sizeof(ipv6_spec.hdr)); + memcpy(hdr->buffer, &ipv6_spec.hdr, sizeof(ipv6_spec.hdr)); return true; default: return false; @@ -885,8 +883,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, ETHERTYPE); } - rte_memcpy(hdr1->buffer, eth_spec, - sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer, eth_spec, + sizeof(struct rte_ether_hdr)); } hdrs->count = ++layer; @@ -976,8 +974,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, input_set |= IAVF_PROT_IPV4_INNER; } - rte_memcpy(hdr->buffer, &ipv4_spec->hdr, - sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer, &ipv4_spec->hdr, + sizeof(ipv4_spec->hdr)); hdrs->count = ++layer; @@ -1066,8 +1064,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, input_set |= IAVF_PROT_IPV6_INNER; } - rte_memcpy(hdr->buffer, &ipv6_spec->hdr, - sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer, &ipv6_spec->hdr, + sizeof(ipv6_spec->hdr)); hdrs->count = ++layer; break; @@ -1101,8 +1099,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr1, ETH, ETHERTYPE); - rte_memcpy(hdr->buffer, &ipv6_frag_spec->hdr, - sizeof(ipv6_frag_spec->hdr)); + memcpy(hdr->buffer, &ipv6_frag_spec->hdr, + sizeof(ipv6_frag_spec->hdr)); } else if (ipv6_frag_mask->hdr.id == UINT32_MAX) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, @@ -1153,13 +1151,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &udp_spec->hdr, - sizeof(udp_spec->hdr)); + memcpy(hdr->buffer, &udp_spec->hdr, + sizeof(udp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &udp_spec->hdr, - sizeof(udp_spec->hdr)); + memcpy(hdr->buffer, &udp_spec->hdr, + sizeof(udp_spec->hdr)); } hdrs->count = ++layer; @@ -1210,13 +1206,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); } hdrs->count = ++layer; @@ -1256,13 +1250,11 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, } if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) - rte_memcpy(hdr->buffer, - &sctp_spec->hdr, - sizeof(sctp_spec->hdr)); + memcpy(hdr->buffer, &sctp_spec->hdr, + sizeof(sctp_spec->hdr)); else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) - rte_memcpy(hdr->buffer, - &sctp_spec->hdr, - sizeof(sctp_spec->hdr)); + memcpy(hdr->buffer, &sctp_spec->hdr, + sizeof(sctp_spec->hdr)); } hdrs->count = ++layer; @@ -1291,8 +1283,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, GTPU_IP, TEID); } - rte_memcpy(hdr->buffer, - gtp_spec, sizeof(*gtp_spec)); + memcpy(hdr->buffer, gtp_spec, + sizeof(*gtp_spec)); } tun_inner = 1; @@ -1346,8 +1338,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, psc.qfi = gtp_psc_spec->hdr.qfi; psc.type = gtp_psc_spec->hdr.type; psc.next = 0; - rte_memcpy(hdr->buffer, &psc, - sizeof(struct iavf_gtp_psc_spec_hdr)); + memcpy(hdr->buffer, &psc, + sizeof(struct iavf_gtp_psc_spec_hdr)); } hdrs->count = ++layer; @@ -1367,8 +1359,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, L2TPV3, SESS_ID); } - rte_memcpy(hdr->buffer, l2tpv3oip_spec, - sizeof(*l2tpv3oip_spec)); + memcpy(hdr->buffer, l2tpv3oip_spec, + sizeof(*l2tpv3oip_spec)); } hdrs->count = ++layer; @@ -1388,8 +1380,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, ESP, SPI); } - rte_memcpy(hdr->buffer, &esp_spec->hdr, - sizeof(esp_spec->hdr)); + memcpy(hdr->buffer, &esp_spec->hdr, + sizeof(esp_spec->hdr)); } hdrs->count = ++layer; @@ -1409,8 +1401,7 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, AH, SPI); } - rte_memcpy(hdr->buffer, ah_spec, - sizeof(*ah_spec)); + memcpy(hdr->buffer, ah_spec, sizeof(*ah_spec)); } hdrs->count = ++layer; @@ -1430,8 +1421,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, PFCP, S_FIELD); } - rte_memcpy(hdr->buffer, pfcp_spec, - sizeof(*pfcp_spec)); + memcpy(hdr->buffer, pfcp_spec, + sizeof(*pfcp_spec)); } hdrs->count = ++layer; @@ -1455,8 +1446,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, PC_RTC_ID); } - rte_memcpy(hdr->buffer, ecpri_spec, - sizeof(*ecpri_spec)); + memcpy(hdr->buffer, ecpri_spec, + sizeof(*ecpri_spec)); } hdrs->count = ++layer; @@ -1471,8 +1462,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, GRE); if (gre_spec && gre_mask) { - rte_memcpy(hdr->buffer, gre_spec, - sizeof(*gre_spec)); + memcpy(hdr->buffer, gre_spec, + sizeof(*gre_spec)); } tun_inner = 1; @@ -1520,8 +1511,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, SESS_ID); } - rte_memcpy(hdr->buffer, l2tpv2_spec, - sizeof(*l2tpv2_spec)); + memcpy(hdr->buffer, l2tpv2_spec, + sizeof(*l2tpv2_spec)); } tun_inner = 1; @@ -1538,8 +1529,8 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, PPP); if (ppp_spec && ppp_mask) { - rte_memcpy(hdr->buffer, ppp_spec, - sizeof(*ppp_spec)); + memcpy(hdr->buffer, ppp_spec, + sizeof(*ppp_spec)); } hdrs->count = ++layer; diff --git a/drivers/net/iavf/iavf_fsub.c b/drivers/net/iavf/iavf_fsub.c index 74e1e7099b8c..d98cde0fa59d 100644 --- a/drivers/net/iavf/iavf_fsub.c +++ b/drivers/net/iavf/iavf_fsub.c @@ -92,7 +92,7 @@ iavf_fsub_create(struct iavf_adapter *ad, struct rte_flow *flow, goto free_entry; } - rte_memcpy(rule, filter, sizeof(*rule)); + memcpy(rule, filter, sizeof(*rule)); flow->rule = rule; rte_free(meta); @@ -272,10 +272,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr1->buffer_spec, eth_spec, - sizeof(struct rte_ether_hdr)); - rte_memcpy(hdr1->buffer_mask, eth_mask, - sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer_spec, eth_spec, + sizeof(struct rte_ether_hdr)); + memcpy(hdr1->buffer_mask, eth_mask, + sizeof(struct rte_ether_hdr)); } else { /* flow subscribe filter will add dst mac in kernel */ input_set_byte += 6; @@ -325,10 +325,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte++; } - rte_memcpy(hdr->buffer_spec, &ipv4_spec->hdr, - sizeof(ipv4_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &ipv4_mask->hdr, - sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer_spec, &ipv4_spec->hdr, + sizeof(ipv4_spec->hdr)); + memcpy(hdr->buffer_mask, &ipv4_mask->hdr, + sizeof(ipv4_spec->hdr)); } hdrs->count = ++layer; @@ -388,10 +388,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 4; } - rte_memcpy(hdr->buffer_spec, &ipv6_spec->hdr, - sizeof(ipv6_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &ipv6_mask->hdr, - sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer_spec, &ipv6_spec->hdr, + sizeof(ipv6_spec->hdr)); + memcpy(hdr->buffer_mask, &ipv6_mask->hdr, + sizeof(ipv6_spec->hdr)); } hdrs->count = ++layer; @@ -425,10 +425,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr->buffer_spec, &udp_spec->hdr, - sizeof(udp_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &udp_mask->hdr, - sizeof(udp_mask->hdr)); + memcpy(hdr->buffer_spec, &udp_spec->hdr, + sizeof(udp_spec->hdr)); + memcpy(hdr->buffer_mask, &udp_mask->hdr, + sizeof(udp_mask->hdr)); } hdrs->count = ++layer; @@ -466,10 +466,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], input_set_byte += 2; } - rte_memcpy(hdr->buffer_spec, &tcp_spec->hdr, - sizeof(tcp_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &tcp_mask->hdr, - sizeof(tcp_mask->hdr)); + memcpy(hdr->buffer_spec, &tcp_spec->hdr, + sizeof(tcp_spec->hdr)); + memcpy(hdr->buffer_mask, &tcp_mask->hdr, + sizeof(tcp_mask->hdr)); } hdrs->count = ++layer; @@ -498,10 +498,10 @@ iavf_fsub_parse_pattern(const struct rte_flow_item pattern[], return -rte_errno; } - rte_memcpy(hdr->buffer_spec, &vlan_spec->hdr, - sizeof(vlan_spec->hdr)); - rte_memcpy(hdr->buffer_mask, &vlan_mask->hdr, - sizeof(vlan_mask->hdr)); + memcpy(hdr->buffer_spec, &vlan_spec->hdr, + sizeof(vlan_spec->hdr)); + memcpy(hdr->buffer_mask, &vlan_mask->hdr, + sizeof(vlan_mask->hdr)); } hdrs->count = ++layer; diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c index 6f6e95fc453f..0bcfb5bf242b 100644 --- a/drivers/net/iavf/iavf_generic_flow.c +++ b/drivers/net/iavf/iavf_generic_flow.c @@ -2019,7 +2019,7 @@ iavf_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ diff --git a/drivers/net/iavf/iavf_tm.c b/drivers/net/iavf/iavf_tm.c index 32bb3be45e1b..a6ad6bb0a28d 100644 --- a/drivers/net/iavf/iavf_tm.c +++ b/drivers/net/iavf/iavf_tm.c @@ -342,8 +342,8 @@ iavf_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->id = node_id; tm_node->parent = NULL; tm_node->reference_count = 0; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); vf->tm_conf.root = tm_node; return 0; } @@ -403,8 +403,7 @@ iavf_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == IAVF_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&vf->tm_conf.tc_list, tm_node, node); @@ -543,8 +542,8 @@ iavf_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&vf->tm_conf.shaper_profile_list, shaper_profile, node); diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 1111d30f57d1..711186c1b552 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -920,7 +920,7 @@ iavf_get_vlan_offload_caps_v2(struct iavf_adapter *adapter) return ret; } - rte_memcpy(&vf->vlan_v2_caps, vf->aq_resp, sizeof(vf->vlan_v2_caps)); + memcpy(&vf->vlan_v2_caps, vf->aq_resp, sizeof(vf->vlan_v2_caps)); return 0; } @@ -1427,8 +1427,8 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add) addr = &adapter->dev_data->mac_addrs[i]; if (rte_is_zero_ether_addr(addr)) continue; - rte_memcpy(list->list[j].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[j].addr, addr->addr_bytes, + sizeof(addr->addr_bytes)); list->list[j].type = (j == 0 ? VIRTCHNL_ETHER_ADDR_PRIMARY : VIRTCHNL_ETHER_ADDR_EXTRA); @@ -1547,8 +1547,7 @@ iavf_add_del_eth_addr(struct iavf_adapter *adapter, struct rte_ether_addr *addr, list->vsi_id = vf->vsi_res->vsi_id; list->num_elements = 1; list->list[0].type = type; - rte_memcpy(list->list[0].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[0].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); args.ops = add ? VIRTCHNL_OP_ADD_ETH_ADDR : VIRTCHNL_OP_DEL_ETH_ADDR; args.in_args = cmd_buffer; From patchwork Fri Mar 1 17:15:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137717 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89A3043C12; Fri, 1 Mar 2024 18:20:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3E3643427; Fri, 1 Mar 2024 18:17:54 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 11A8143392 for ; Fri, 1 Mar 2024 18:17:39 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d94b222a3aso24801105ad.2 for ; Fri, 01 Mar 2024 09:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313458; x=1709918258; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sucpImUOk72On1AycV8jrZiKcZFV6ng/DVXTZJdMBF0=; b=qJm7N3e5VngxH4gqJI2tjO/4QbPotGCMY93QCaUHm/sIuc38+GDpIGUCOk3MDR6E0D A86UVDzqGJ7r6BZnABqw+EOQ+SFI9Eo9hD0ELWHvjbeVd5DiTYTxr8JEU4SB6uOmi4E5 qh3TLW4lUqP2y+fPz9WIY7IxubhYtjQGAyMK2+hPjKFbBQTSfQL8buq5Plg6FmIs/fXP S11v13+qvzMq6rpvmuTbFLLnGY6tc9jlO4sJOsiJvA+KJNzJ6mn1i/pgeAhY0ZlfHI5V +CZubakgFSDoQOr/NKPP42HbkbWD26g2Q6kx8+cwWxOuf9Lf9YCzjXZfrJPP7Dd98Izn ORIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313458; x=1709918258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sucpImUOk72On1AycV8jrZiKcZFV6ng/DVXTZJdMBF0=; b=EbT3b5TA+u1chiTl6wHXWCKbJKUSaXmgov9TTdZXnXfxmn95AKJTbVp0XjVCX677Jx 944AoOL5O4D0IQ2j1Db6FqY7ShzvTrbvfaPhPpdyBh25doLJh8tu9GwEUwnzkAAYiqPj 00vI3JkAuEQMj56q7zck1TvDy2Ys6Cs4R8lEaY6tc+pS/+MCb5yb3GSadmxBWV5O5Wjf YME5+r9CX6n1X0YPsHRxLxeiQ7dFsFlbW4zg9v9XZf3M0IyptlTNXQQ2YilU1PpN8AIS u/tupWBtZizuKjhjk6/Z1WJkEtx9t+V+C8Mz74IuCs4fUNGS9aVm1F6gZMaZgViWiefa YUtA== X-Gm-Message-State: AOJu0YzLWQgq23iArt8j7gM732YqMkHIv/Ix+Zw1i/K3TEGDq3KRHdeg deJzTyn+f7uInyxnCdD2xh0omJ2k3Mcw+AYZ9TFq3yVzmzt1lpLaptJ/IAr16o3AVhDD3Trv4p0 Ayp/VPg== X-Google-Smtp-Source: AGHT+IE4oI0QeQSHDYSymoyPD1fj+VsjGIE6Hy7vGMyc6nnuj92V5VLl1rX9ehGminC4k05pONYpig== X-Received: by 2002:a17:902:f7c4:b0:1dc:cc98:eea3 with SMTP id h4-20020a170902f7c400b001dccc98eea3mr2037412plw.53.1709313458280; Fri, 01 Mar 2024 09:17:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 27/71] net/ice: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:23 -0800 Message-ID: <20240301171707.95242-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_dcf.c | 5 ++-- drivers/net/ice/ice_dcf_parent.c | 2 +- drivers/net/ice/ice_dcf_sched.c | 11 ++++----- drivers/net/ice/ice_diagnose.c | 4 ++-- drivers/net/ice/ice_ethdev.c | 14 +++++------ drivers/net/ice/ice_fdir_filter.c | 37 +++++++++++++++--------------- drivers/net/ice/ice_generic_flow.c | 2 +- drivers/net/ice/ice_hash.c | 2 +- drivers/net/ice/ice_tm.c | 11 ++++----- 9 files changed, 43 insertions(+), 45 deletions(-) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c index 7f8f5163acef..42e5b30b2b5e 100644 --- a/drivers/net/ice/ice_dcf.c +++ b/drivers/net/ice/ice_dcf.c @@ -731,7 +731,7 @@ dcf_get_vlan_offload_caps_v2(struct ice_dcf_hw *hw) return ret; } - rte_memcpy(&hw->vlan_v2_caps, &vlan_v2_caps, sizeof(vlan_v2_caps)); + memcpy(&hw->vlan_v2_caps, &vlan_v2_caps, sizeof(vlan_v2_caps)); return 0; } @@ -1407,8 +1407,7 @@ ice_dcf_add_del_all_mac_addr(struct ice_dcf_hw *hw, return -ENOMEM; } - rte_memcpy(list->list[0].addr, addr->addr_bytes, - sizeof(addr->addr_bytes)); + memcpy(list->list[0].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); PMD_DRV_LOG(DEBUG, "add/rm mac:" RTE_ETHER_ADDR_PRT_FMT, RTE_ETHER_ADDR_BYTES(addr)); diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c index 6e845f458acd..0c53755c9d04 100644 --- a/drivers/net/ice/ice_dcf_parent.c +++ b/drivers/net/ice/ice_dcf_parent.c @@ -407,7 +407,7 @@ ice_dcf_load_pkg(struct ice_adapter *adapter) use_dsn = ice_dcf_execute_virtchnl_cmd(&dcf_adapter->real_hw, &vc_cmd) == 0; if (use_dsn) - rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn)); + memcpy(&dsn, pkg_info.dsn, sizeof(dsn)); return ice_load_pkg(adapter, use_dsn, dsn); } diff --git a/drivers/net/ice/ice_dcf_sched.c b/drivers/net/ice/ice_dcf_sched.c index b08bc5f1dee0..465ae75d5c97 100644 --- a/drivers/net/ice/ice_dcf_sched.c +++ b/drivers/net/ice/ice_dcf_sched.c @@ -308,8 +308,8 @@ ice_dcf_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->id = node_id; tm_node->parent = NULL; tm_node->reference_count = 0; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); hw->tm_conf.root = tm_node; return 0; @@ -373,8 +373,7 @@ ice_dcf_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->shaper_profile = shaper_profile; tm_node->reference_count = 0; tm_node->parent = parent_node; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == ICE_DCF_TM_NODE_TYPE_PORT) { TAILQ_INSERT_TAIL(&hw->tm_conf.tc_list, tm_node, node); @@ -520,8 +519,8 @@ ice_dcf_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&hw->tm_conf.shaper_profile_list, shaper_profile, node); diff --git a/drivers/net/ice/ice_diagnose.c b/drivers/net/ice/ice_diagnose.c index 3be819d7f8f4..c22f71e48efa 100644 --- a/drivers/net/ice/ice_diagnose.c +++ b/drivers/net/ice/ice_diagnose.c @@ -362,13 +362,13 @@ ice_dump_pkg(struct rte_eth_dev *dev, uint8_t **buff, uint32_t *size) count = *size / ICE_PKG_BUF_SIZE; for (i = 0; i < count; i++) { next_buff = (uint8_t *)(*buff) + i * ICE_PKG_BUF_SIZE; - rte_memcpy(pkg_buff.buf, next_buff, ICE_PKG_BUF_SIZE); + memcpy(pkg_buff.buf, next_buff, ICE_PKG_BUF_SIZE); if (ice_aq_upload_section(hw, (struct ice_buf_hdr *)&pkg_buff.buf[0], ICE_PKG_BUF_SIZE, NULL)) return -EINVAL; - rte_memcpy(next_buff, pkg_buff.buf, ICE_PKG_BUF_SIZE); + memcpy(next_buff, pkg_buff.buf, ICE_PKG_BUF_SIZE); } cache_size = sizeof(struct ice_package_header) + *size; diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index f07b236ad4b6..93e364811d2e 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3387,11 +3387,11 @@ static int ice_init_rss(struct ice_pf *pf) RTE_MIN(rss_conf->rss_key_len, vsi->rss_key_size)); - rte_memcpy(key.standard_rss_key, vsi->rss_key, - ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE); - rte_memcpy(key.extended_hash_key, - &vsi->rss_key[ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE], - ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE); + memcpy(key.standard_rss_key, vsi->rss_key, + ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE); + memcpy(key.extended_hash_key, + &vsi->rss_key[ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE], + ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE); ret = ice_aq_set_rss_key(hw, vsi->idx, &key); if (ret) goto out; @@ -4483,7 +4483,7 @@ ice_vsi_config_vlan_filter(struct ice_vsi *vsi, bool on) vsi->info.sw_flags2 &= ~sw_flags2; vsi->info.sw_id = hw->port_info->sw_id; - (void)rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.info.valid_sections = rte_cpu_to_le_16(ICE_AQ_VSI_PROP_SW_VALID | ICE_AQ_VSI_PROP_SECURITY_VALID); @@ -5301,7 +5301,7 @@ ice_vsi_vlan_pvid_set(struct ice_vsi *vsi, struct ice_vsi_vlan_pvid_info *info) ICE_AQ_VSI_INNER_VLAN_EMODE_M); vsi->info.inner_vlan_flags |= vlan_flags; memset(&ctxt, 0, sizeof(ctxt)); - rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); + memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info)); ctxt.info.valid_sections = rte_cpu_to_le_16(ICE_AQ_VSI_PROP_VLAN_VALID); ctxt.vsi_num = vsi->vsi_id; diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 0b7920ad4475..de7b531aa023 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -1224,13 +1224,13 @@ ice_fdir_extract_fltr_key(struct ice_fdir_fltr_pattern *key, memset(key, 0, sizeof(*key)); key->flow_type = input->flow_type; - rte_memcpy(&key->ip, &input->ip, sizeof(key->ip)); - rte_memcpy(&key->mask, &input->mask, sizeof(key->mask)); - rte_memcpy(&key->ext_data, &input->ext_data, sizeof(key->ext_data)); - rte_memcpy(&key->ext_mask, &input->ext_mask, sizeof(key->ext_mask)); + memcpy(&key->ip, &input->ip, sizeof(key->ip)); + memcpy(&key->mask, &input->mask, sizeof(key->mask)); + memcpy(&key->ext_data, &input->ext_data, sizeof(key->ext_data)); + memcpy(&key->ext_mask, &input->ext_mask, sizeof(key->ext_mask)); - rte_memcpy(&key->gtpu_data, &input->gtpu_data, sizeof(key->gtpu_data)); - rte_memcpy(&key->gtpu_mask, &input->gtpu_mask, sizeof(key->gtpu_mask)); + memcpy(&key->gtpu_data, &input->gtpu_data, sizeof(key->gtpu_data)); + memcpy(&key->gtpu_mask, &input->gtpu_mask, sizeof(key->gtpu_mask)); key->tunnel_type = filter->tunnel_type; } @@ -1358,7 +1358,7 @@ ice_fdir_create_filter(struct ice_adapter *ad, if (!entry) goto error; - rte_memcpy(entry, filter, sizeof(*filter)); + memcpy(entry, filter, sizeof(*filter)); flow->rule = entry; @@ -1419,7 +1419,7 @@ ice_fdir_create_filter(struct ice_adapter *ad, if (filter->mark_flag == 1) ice_fdir_rx_parsing_enable(ad, 1); - rte_memcpy(entry, filter, sizeof(*entry)); + memcpy(entry, filter, sizeof(*entry)); ret = ice_fdir_entry_insert(pf, entry, &key); if (ret) { rte_flow_error_set(error, -ret, @@ -1720,8 +1720,8 @@ ice_fdir_parse_action(struct ice_adapter *ad, act_count = actions->conf; filter->input.cnt_ena = ICE_FXD_FLTR_QW0_STAT_ENA_PKTS; - rte_memcpy(&filter->act_count, act_count, - sizeof(filter->act_count)); + memcpy(&filter->act_count, act_count, + sizeof(filter->act_count)); break; default: @@ -1978,12 +1978,13 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, p_ext_data = (tunnel_type && is_outer) ? &filter->input.ext_data_outer : &filter->input.ext_data; - rte_memcpy(&p_ext_data->src_mac, - ð_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN); - rte_memcpy(&p_ext_data->dst_mac, - ð_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN); - rte_memcpy(&p_ext_data->ether_type, - ð_spec->hdr.ether_type, sizeof(eth_spec->hdr.ether_type)); + memcpy(&p_ext_data->src_mac, ð_spec->hdr.src_addr, + RTE_ETHER_ADDR_LEN); + memcpy(&p_ext_data->dst_mac, ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); + memcpy(&p_ext_data->ether_type, + ð_spec->hdr.ether_type, + sizeof(eth_spec->hdr.ether_type)); break; case RTE_FLOW_ITEM_TYPE_IPV4: flow_type = ICE_FLTR_PTYPE_NONF_IPV4_OTHER; @@ -2108,8 +2109,8 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, if (ipv6_mask->hdr.hop_limits == UINT8_MAX) *input_set |= ICE_INSET_IPV6_HOP_LIMIT; - rte_memcpy(&p_v6->dst_ip, ipv6_spec->hdr.dst_addr, 16); - rte_memcpy(&p_v6->src_ip, ipv6_spec->hdr.src_addr, 16); + memcpy(&p_v6->dst_ip, ipv6_spec->hdr.dst_addr, 16); + memcpy(&p_v6->src_ip, ipv6_spec->hdr.src_addr, 16); vtc_flow_cpu = rte_be_to_cpu_32(ipv6_spec->hdr.vtc_flow); p_v6->tc = (uint8_t)(vtc_flow_cpu >> ICE_FDIR_IPV6_TC_OFFSET); p_v6->proto = ipv6_spec->hdr.proto; diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index 50d760004f90..9e7de43575b9 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -1969,7 +1969,7 @@ ice_pattern_skip_void_item(struct rte_flow_item *items, pb = pe + 1; } /* Copy the END item. */ - rte_memcpy(items, pe, sizeof(struct rte_flow_item)); + memcpy(items, pe, sizeof(struct rte_flow_item)); } /* Check if the pattern matches a supported item type array */ diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f92364153376..80b44713a9d1 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -715,7 +715,7 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad, pkt_len, ICE_BLK_RSS, true, &prof)) return -rte_errno; - rte_memcpy(&meta->raw.prof, &prof, sizeof(prof)); + memcpy(&meta->raw.prof, &prof, sizeof(prof)); rte_free(pkt_buf); rte_free(msk_buf); diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index fbab0b8808b9..a8b20ef889fc 100644 --- a/drivers/net/ice/ice_tm.c +++ b/drivers/net/ice/ice_tm.c @@ -293,8 +293,8 @@ ice_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&pf->tm_conf.shaper_profile_list, shaper_profile, node); @@ -403,8 +403,8 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->shaper_profile = shaper_profile; tm_node->children = (void *)((uint8_t *)tm_node + sizeof(struct ice_tm_node)); - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); pf->tm_conf.root = tm_node; return 0; } @@ -480,8 +480,7 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, PMD_DRV_LOG(WARNING, "weight != 1 not supported in level %d", level_id); - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); tm_node->parent->reference_count++; return 0; From patchwork Fri Mar 1 17:15:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137718 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7F9243C12; Fri, 1 Mar 2024 18:20:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23A684342B; Fri, 1 Mar 2024 18:17:56 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id BA4464337F for ; Fri, 1 Mar 2024 18:17:39 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dc49b00bdbso24001625ad.3 for ; Fri, 01 Mar 2024 09:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313459; x=1709918259; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XUHvwBLFAbLslSMTmZSKyZCQSLx2BGir5+OP+Lo8mC8=; b=rSqpm0XCgNVBJglCNgmn8O7YAkrZ0rKmQy7fwcXzuY1UFkE6AXOz7RoFkBRGE4ctdT AAPx+Zn4voixiF3O32aFkR/arWYjoUij7Jm47RJQxTd5IF+r6tRT4jLxDhpAukyq6Hq5 JK0yJoELu/zckXVAZjyN00K3i4joXj1cMxRyDC9URmAPDu2a1TCnZC9mIrISHKsMh5S/ h3Aeqv0jnIC3BGJIyDarXOLbkRvG87fZEdjnqA8LvlUMdCf3GVD7ER0lSGGbpGq24ema mm6aM9TGb1zPq1mGMJolQ7YCy6YheHVtkLFBK9ORXAdrSMPJCVHXYR6y4aDF56kxCiXI J1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313459; x=1709918259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XUHvwBLFAbLslSMTmZSKyZCQSLx2BGir5+OP+Lo8mC8=; b=G4/jGIomptWRn20zE6ObCITjzRY6QH5eudXddEUdWnkIlLFi8tRuL5TAeeRuxApWYo m+zKwEL9UVQsVYYxOJHQLIwXDMyMv3AlnQwuU8ltMM1nutcqKPVkUghdR607SFj1VHvB 3nJyFXki81t7izSb7ULlRw6/LT7OdCDyLjp2TVVp3m/XS+Qv6o8qYaUSA86Hzk0GUH5E /oEOKjNhBUVq0ZiGAKykYwvQiMAWfo0yjrEvvy217UfbNnXRXkvpOs5obEYzVVpPEred LYqrW2EcbBmSun2xjsksdYW4r0hC9F4OtxrIk1IK6Z35W4So+OO/LkIOAlfPTckazbym iSDQ== X-Gm-Message-State: AOJu0Yzxjx6Uekt2ni9Ba7AQfty/B/melHOcFFSpjMDVJYYeWXW5zwWT 5HRYXMLFWSKoo7lgYtwW05mXlNiDZNDTozyewbdNeZG/B4PicmSg2IgB1zne1bB5JNWRHXqlU77 fY6rVGg== X-Google-Smtp-Source: AGHT+IGrVZbOEIbWxodtekKSCL7x/N6iaWdlK4YhE1hdDdhPs5oci+cGMDoIdur6MoXJL+nMuCJS7g== X-Received: by 2002:a17:902:8c93:b0:1dc:b3a3:ca73 with SMTP id t19-20020a1709028c9300b001dcb3a3ca73mr2025763plo.38.1709313458972; Fri, 01 Mar 2024 09:17:38 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH v2 28/71] net/idpf: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:24 -0800 Message-ID: <20240301171707.95242-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/idpf/idpf_ethdev.c | 7 ++++--- drivers/net/idpf/idpf_rxtx.c | 10 ++++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 86151c9ec9fa..9cf33c4b7058 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -1088,8 +1088,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex) return; } - rte_memcpy(adapter->mbx_resp, ctlq_msg.ctx.indirect.payload->va, - IDPF_DFLT_MBX_BUF_SIZE); + memcpy(adapter->mbx_resp, ctlq_msg.ctx.indirect.payload->va, + IDPF_DFLT_MBX_BUF_SIZE); mbx_op = rte_le_to_cpu_16(ctlq_msg.opcode); vc_op = rte_le_to_cpu_32(ctlq_msg.cookie.mbx.chnl_opcode); @@ -1202,7 +1202,8 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); - rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&base->caps, &req_caps, + sizeof(struct virtchnl2_get_capabilities)); ret = idpf_adapter_init(base); if (ret != 0) { diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index 64f22355804e..da659e16531c 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -76,7 +76,7 @@ idpf_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t queue_idx, else ring_size = RTE_ALIGN(len * sizeof(struct idpf_base_tx_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Tx ring", sizeof("idpf Tx ring")); + memcpy(ring_name, "idpf Tx ring", sizeof("idpf Tx ring")); break; case VIRTCHNL2_QUEUE_TYPE_RX: if (splitq) @@ -85,17 +85,19 @@ idpf_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t queue_idx, else ring_size = RTE_ALIGN(len * sizeof(struct virtchnl2_singleq_rx_buf_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Rx ring", sizeof("idpf Rx ring")); + memcpy(ring_name, "idpf Rx ring", sizeof("idpf Rx ring")); break; case VIRTCHNL2_QUEUE_TYPE_TX_COMPLETION: ring_size = RTE_ALIGN(len * sizeof(struct idpf_splitq_tx_compl_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Tx compl ring", sizeof("idpf Tx compl ring")); + memcpy(ring_name, "idpf Tx compl ring", + sizeof("idpf Tx compl ring")); break; case VIRTCHNL2_QUEUE_TYPE_RX_BUFFER: ring_size = RTE_ALIGN(len * sizeof(struct virtchnl2_splitq_rx_buf_desc), IDPF_DMA_MEM_ALIGN); - rte_memcpy(ring_name, "idpf Rx buf ring", sizeof("idpf Rx buf ring")); + memcpy(ring_name, "idpf Rx buf ring", + sizeof("idpf Rx buf ring")); break; default: PMD_INIT_LOG(ERR, "Invalid queue type"); From patchwork Fri Mar 1 17:15:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137719 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A510E43C12; Fri, 1 Mar 2024 18:20:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9130943437; Fri, 1 Mar 2024 18:17:57 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 7AD43433A8 for ; Fri, 1 Mar 2024 18:17:40 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dca3951ad9so21947345ad.3 for ; Fri, 01 Mar 2024 09:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313460; x=1709918260; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=; b=J6A/u8pH977TGPHm9Y7llkadbXKqBQuNrUG8R8Q4IQGJeTo38qm96f2o3U51EUCujz 6Qjx9wwdpXOCjfCpG5037ZeVmuYu8usb2xQa06IlRIY8VROCSqg++ANewUbqfEzjzEDE 8/PHPgWIGGm7v63dOj7INo903iKtDu03RMYkIv0DLkCu+inuhKFbgXpwpR/xvE/LFoMG Wp5Q9UkOl6/pY78jtxHGbSs2z8ZFTgIY3mlfcVkoskInb4K0wMPXvmo/wI48SJ/I4Csf CvU9/ySFp/CE87M33ih5zeTt/5PwlPybSImygqGzjFwKBpwIc9Gj4XopUVxYEtw2BrK+ cbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313460; x=1709918260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=; b=B3m1Q4Jf6ElE2CkAPcVUKnDfiO2FlWhQp8x6cKQ9RQ0GWu2w1Zp3JIbrhrTaPnl0iT oWsLx8iUmtorGQ53TkKJaZTPAxa4VmYwphzvQU3DbEAeDZzll+V6fdC9mqvaoMO3d9c2 jtpwIoTeY1qCUH6Bi7jAPfzNLY7twFkzQY/PVhE9wcm6QJPqcz2+AMimGmk3Y34Q5q3N qkRCOuPxFJiSQrkHSMPDwWi921/7zXeoch78LAFTQkEPid5kXSxBwxAfjpu1u+XqLGp4 HhnQ1rGuyivnv5JrEeC9RbGZqu5LtoXzd9uQLEQyYvMaLmLqj7OZZPVD5X19L2IrmccC 1w3Q== X-Gm-Message-State: AOJu0Yyffge9+Q5sHamGJe4oiv6xRNIfMFu6u0gZeL9Abq1TLUadNf7q Tz2Jk9lV8KC5WUFgx6zW8WyjebmFFOfJay3UTXlRmoVGytqfvveu/pAkwnRX26VtAbfU2RNwGd+ cn15rNA== X-Google-Smtp-Source: AGHT+IEY3mI22BsF/JA5a+SJDXZC6VaKlqFf3F0bdG9DXb1H0MAqL+spbgbH5N8VIIbXhRMvNPIeIQ== X-Received: by 2002:a17:902:f7ce:b0:1db:37b1:b1a3 with SMTP id h14-20020a170902f7ce00b001db37b1b1a3mr2080236plw.17.1709313459743; Fri, 01 Mar 2024 09:17:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH v2 29/71] net/ipn3ke: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:25 -0800 Message-ID: <20240301171707.95242-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ipn3ke/ipn3ke_flow.c | 32 ++++++++++++------------- drivers/net/ipn3ke/ipn3ke_representor.c | 16 ++++++------- drivers/net/ipn3ke/ipn3ke_tm.c | 6 ++--- 3 files changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c index d20a29b9a2d6..eeb0ec55d9a6 100644 --- a/drivers/net/ipn3ke/ipn3ke_flow.c +++ b/drivers/net/ipn3ke/ipn3ke_flow.c @@ -100,15 +100,14 @@ ipn3ke_pattern_vxlan(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_ETH: eth = item->spec; - rte_memcpy(&parser->key[0], - eth->hdr.src_addr.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(&parser->key[0], eth->hdr.src_addr.addr_bytes, + RTE_ETHER_ADDR_LEN); break; case RTE_FLOW_ITEM_TYPE_VXLAN: vxlan = item->spec; - rte_memcpy(&parser->key[6], vxlan->hdr.vni, 3); + memcpy(&parser->key[6], vxlan->hdr.vni, 3); break; default: @@ -164,9 +163,8 @@ ipn3ke_pattern_mac(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_ETH: eth = item->spec; - rte_memcpy(parser->key, - eth->hdr.src_addr.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(parser->key, eth->hdr.src_addr.addr_bytes, + RTE_ETHER_ADDR_LEN); break; default: @@ -369,13 +367,13 @@ ipn3ke_pattern_ip_tcp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_TCP: tcp = item->spec; - rte_memcpy(&parser->key[4], &tcp->hdr.src_port, 2); + memcpy(&parser->key[4], &tcp->hdr.src_port, 2); break; default: @@ -434,13 +432,13 @@ ipn3ke_pattern_ip_udp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2); + memcpy(&parser->key[4], &udp->hdr.src_port, 2); break; default: @@ -502,19 +500,19 @@ ipn3ke_pattern_ip_nvgre(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[4], &udp->hdr.src_port, 2); + memcpy(&parser->key[4], &udp->hdr.src_port, 2); break; case RTE_FLOW_ITEM_TYPE_NVGRE: nvgre = item->spec; - rte_memcpy(&parser->key[6], nvgre->tni, 3); + memcpy(&parser->key[6], nvgre->tni, 3); break; default: @@ -576,19 +574,19 @@ ipn3ke_pattern_vxlan_ip_udp(const struct rte_flow_item patterns[], case RTE_FLOW_ITEM_TYPE_VXLAN: vxlan = item->spec; - rte_memcpy(&parser->key[0], vxlan->hdr.vni, 3); + memcpy(&parser->key[0], vxlan->hdr.vni, 3); break; case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = item->spec; - rte_memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4); + memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4); break; case RTE_FLOW_ITEM_TYPE_UDP: udp = item->spec; - rte_memcpy(&parser->key[7], &udp->hdr.src_port, 2); + memcpy(&parser->key[7], &udp->hdr.src_port, 2); break; default: diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c index 8145f1bb2a0e..99527d18793a 100644 --- a/drivers/net/ipn3ke/ipn3ke_representor.c +++ b/drivers/net/ipn3ke/ipn3ke_representor.c @@ -137,17 +137,17 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev) if (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) { /* Set mac address */ - rte_memcpy(((char *)(&val)), - (char *)&dev->data->mac_addrs->addr_bytes[0], - sizeof(uint32_t)); + memcpy(((char *)(&val)), + (char *)&dev->data->mac_addrs->addr_bytes[0], + sizeof(uint32_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, rpst->port_id, 0); - rte_memcpy(((char *)(&val)), - (char *)&dev->data->mac_addrs->addr_bytes[4], - sizeof(uint16_t)); + memcpy(((char *)(&val)), + (char *)&dev->data->mac_addrs->addr_bytes[4], + sizeof(uint16_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR1, @@ -2753,13 +2753,13 @@ ipn3ke_rpst_mac_addr_set(struct rte_eth_dev *ethdev, rte_ether_addr_copy(&mac_addr[0], &rpst->mac_addr); /* Set mac address */ - rte_memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t)); + memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, rpst->port_id, 0); - rte_memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t)); + memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t)); (*hw->f_mac_write)(hw, val, IPN3KE_MAC_PRIMARY_MAC_ADDR0, diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c index 0260227900ae..b7097083d2d6 100644 --- a/drivers/net/ipn3ke/ipn3ke_tm.c +++ b/drivers/net/ipn3ke/ipn3ke_tm.c @@ -814,7 +814,7 @@ ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev, rte_strerror(EINVAL)); } else { sp->valid = 1; - rte_memcpy(&sp->params, profile, sizeof(sp->params)); + memcpy(&sp->params, profile, sizeof(sp->params)); } tm->h.n_shaper_profiles++; @@ -960,7 +960,7 @@ ipn3ke_tm_tdrop_profile_add(struct rte_eth_dev *dev, IPN3KE_TDROP_TH2_MASK); tp->th1 = th1; tp->th2 = th2; - rte_memcpy(&tp->params, profile, sizeof(tp->params)); + memcpy(&tp->params, profile, sizeof(tp->params)); /* Add to list */ tm->h.n_tdrop_profiles++; @@ -1308,7 +1308,7 @@ ipn3ke_tm_node_add(struct rte_eth_dev *dev, n->tdrop_profile = ipn3ke_hw_tm_tdrop_profile_search(hw, params->leaf.wred.wred_profile_id); - rte_memcpy(&n->params, params, sizeof(n->params)); + memcpy(&n->params, params, sizeof(n->params)); return 0; } From patchwork Fri Mar 1 17:15:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137720 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12D6943C12; Fri, 1 Mar 2024 18:21:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0C804343C; Fri, 1 Mar 2024 18:17:58 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 389E443392 for ; Fri, 1 Mar 2024 18:17:41 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dc49b00bdbso24001945ad.3 for ; Fri, 01 Mar 2024 09:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313460; x=1709918260; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QilAi4ZcFsxnQwbWp/nw4/i6IyoPNGA2EZX5mX0L24w=; b=Xvxv1tknukQqGLi2gOGAVvKuc7BLA+7VfbRtQzA3S0saZRJW/kKGoY/DYspZCJevCk YBx/LP8c/rlWpQwHH+YBEc/ojrOrKoSaHW8Ziwog6Qcajv0fKorFkpCxVD8HtA2dWmJ0 f8Op1r1Yb+u3tJPs6yYepYArHFCZJbDBYd2wGF3CkjFUEDOAA8wnoCZmynEiUFP9PdJi Kw+R/Pa6EK62DBCBU7ptY7wg/38THUE2K88uYnsbTvEWaHlWoDru7W8BnitW2C8jO75r HOW7LE+KxJH/ruRd7LowbMNBHYxgJXFobgPamx75O9q9eP4pLNqmtsGZIr4m2SEcleYg +bGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313460; x=1709918260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QilAi4ZcFsxnQwbWp/nw4/i6IyoPNGA2EZX5mX0L24w=; b=wIW9vR747o7iZ7KfiF40wZEbXATXvt3gAK9YF2IdJhMVaQFhREr6adq5GxI7eT7Vlw 6W3MhV9J8rYG9+JZKXvMhxAYnbumsctodxs5UFn0Klf9u08GrfUHaM5qjHyfzaFMeqXn 2NIi5+IChpZ1ajG6YvmD3KRV8Fk4dZ316ww7+eRguv1pFOS3cxwaEQwPAoiHulkz+FGN fHAuU4s5Fic04jjlJ6RFRhcgC8vhlkaVMSYMeD4gDgG5hkOZ81N9MlT3MvgoXmFBzL2t AUKumvKLJcjbJ6G1zTH96omvwBToPpinGzzuE6pmf0Q+DzIG9xcf14nInAmnhqNQ3s4k lNbA== X-Gm-Message-State: AOJu0YyHaMPTHa0+nyyprP/UB+JZjr9cOmoZBAdXl9rZgsQDk2RwS2/k svC6foGZSVbvDGr/MhMO32GycGoN08+7/iThpIrF5Eac2GXKqGLsNK9/Cr7BykI4FWpeuWfIPca 9yZb5nw== X-Google-Smtp-Source: AGHT+IGDXM4UOUXsXLDcAt+5arcyr6yUkTOEr3eleAxUcB5EYfyD/qByuYYbdiJGKm/RE7kmtofoWg== X-Received: by 2002:a17:902:e805:b0:1db:d2f7:68a4 with SMTP id u5-20020a170902e80500b001dbd2f768a4mr2465451plg.24.1709313460467; Fri, 01 Mar 2024 09:17:40 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 30/71] net/ixgbe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:26 -0800 Message-ID: <20240301171707.95242-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++--- drivers/net/ixgbe/ixgbe_fdir.c | 7 ++-- drivers/net/ixgbe/ixgbe_flow.c | 65 ++++++++++++++----------------- drivers/net/ixgbe/ixgbe_ipsec.c | 8 ++-- drivers/net/ixgbe/ixgbe_pf.c | 5 +-- drivers/net/ixgbe/ixgbe_tm.c | 11 +++--- drivers/net/ixgbe/rte_pmd_ixgbe.c | 4 +- 7 files changed, 48 insertions(+), 61 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 0cd3d0b105f4..6040cac9a896 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -6597,9 +6597,8 @@ ixgbe_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct ixgbe_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, - &filter_5tuple, - sizeof(struct ixgbe_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct ixgbe_5tuple_filter_info)); filter->queue = ntuple_filter->queue; ret = ixgbe_add_5tuple_filter(dev, filter); if (ret < 0) { @@ -7596,9 +7595,7 @@ ixgbe_dev_l2_tunnel_filter_add(struct rte_eth_dev *dev, if (!node) return -ENOMEM; - rte_memcpy(&node->key, - &key, - sizeof(struct ixgbe_l2_tn_key)); + memcpy(&node->key, &key, sizeof(struct ixgbe_l2_tn_key)); node->pool = l2_tunnel->pool; ret = ixgbe_insert_l2_tn_filter(l2_tn_info, node); if (ret < 0) { diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c index 06d6e2126de5..b168ab82781b 100644 --- a/drivers/net/ixgbe/ixgbe_fdir.c +++ b/drivers/net/ixgbe/ixgbe_fdir.c @@ -74,7 +74,7 @@ else \ ipv6_addr[i] = 0; \ } \ - rte_memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ + memcpy((ipaddr), ipv6_addr, sizeof(ipv6_addr));\ } while (0) #define IXGBE_FDIRIP6M_INNER_MAC_SHIFT 4 @@ -1217,9 +1217,8 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, 0); if (!node) return -ENOMEM; - rte_memcpy(&node->ixgbe_fdir, - &rule->ixgbe_fdir, - sizeof(union ixgbe_atr_input)); + memcpy(&node->ixgbe_fdir, &rule->ixgbe_fdir, + sizeof(union ixgbe_atr_input)); node->fdirflags = fdircmd_flags; node->fdirhash = fdirhash; node->queue = queue; diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 687341c6b8d3..8a13f47f2b8c 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -1944,10 +1944,10 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev, if (item->spec) { rule->b_spec = TRUE; ipv6_spec = item->spec; - rte_memcpy(rule->ixgbe_fdir.formatted.src_ip, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(rule->ixgbe_fdir.formatted.dst_ip, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->ixgbe_fdir.formatted.src_ip, + ipv6_spec->hdr.src_addr, 16); + memcpy(rule->ixgbe_fdir.formatted.dst_ip, + ipv6_spec->hdr.dst_addr, 16); } /** @@ -3070,9 +3070,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -3096,9 +3096,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -3120,9 +3120,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&filter_syn_list, syn_filter_ptr, entries); @@ -3141,9 +3140,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct ixgbe_hw_fdir_mask)); + memcpy(&fdir_info->mask, &fdir_rule.mask, + sizeof(struct ixgbe_hw_fdir_mask)); if (fdir_rule.mask.flex_bytes_mask) { ret = ixgbe_fdir_set_flexbytes_offset(dev, @@ -3185,9 +3183,9 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, - &fdir_rule, - sizeof(struct ixgbe_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, + &fdir_rule, + sizeof(struct ixgbe_fdir_rule)); TAILQ_INSERT_TAIL(&filter_fdir_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -3222,9 +3220,8 @@ ixgbe_flow_create(struct rte_eth_dev *dev, PMD_DRV_LOG(ERR, "failed to allocate memory"); goto out; } - rte_memcpy(&l2_tn_filter_ptr->filter_info, - &l2_tn_filter, - sizeof(struct ixgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter_ptr->filter_info, &l2_tn_filter, + sizeof(struct ixgbe_l2_tunnel_conf)); TAILQ_INSERT_TAIL(&filter_l2_tunnel_list, l2_tn_filter_ptr, entries); flow->rule = l2_tn_filter_ptr; @@ -3351,9 +3348,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct ixgbe_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, - &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = ixgbe_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_ntuple_list, @@ -3364,9 +3360,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct ixgbe_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = ixgbe_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3378,9 +3373,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_SYN: syn_filter_ptr = (struct ixgbe_eth_syn_filter_ele *) pmd_flow->rule; - rte_memcpy(&syn_filter, - &syn_filter_ptr->filter_info, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter, &syn_filter_ptr->filter_info, + sizeof(struct rte_eth_syn_filter)); ret = ixgbe_syn_filter_set(dev, &syn_filter, FALSE); if (!ret) { TAILQ_REMOVE(&filter_syn_list, @@ -3390,9 +3384,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct ixgbe_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct ixgbe_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct ixgbe_fdir_rule)); ret = ixgbe_fdir_filter_program(dev, &fdir_rule, TRUE, FALSE); if (!ret) { TAILQ_REMOVE(&filter_fdir_list, @@ -3405,8 +3398,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, case RTE_ETH_FILTER_L2_TUNNEL: l2_tn_filter_ptr = (struct ixgbe_eth_l2_tunnel_conf_ele *) pmd_flow->rule; - rte_memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, - sizeof(struct ixgbe_l2_tunnel_conf)); + memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info, + sizeof(struct ixgbe_l2_tunnel_conf)); ret = ixgbe_dev_l2_tunnel_filter_del(dev, &l2_tn_filter); if (!ret) { TAILQ_REMOVE(&filter_l2_tunnel_list, diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index d3313085560d..d8ed095dce0c 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -680,10 +680,10 @@ ixgbe_crypto_add_ingress_sa_from_flow(const void *sess, const struct rte_flow_item_ipv6 *ipv6 = ip_spec; ic_session->src_ip.type = IPv6; ic_session->dst_ip.type = IPv6; - rte_memcpy(ic_session->src_ip.ipv6, - ipv6->hdr.src_addr, 16); - rte_memcpy(ic_session->dst_ip.ipv6, - ipv6->hdr.dst_addr, 16); + memcpy(ic_session->src_ip.ipv6, ipv6->hdr.src_addr, + 16); + memcpy(ic_session->dst_ip.ipv6, ipv6->hdr.dst_addr, + 16); } else { const struct rte_flow_item_ipv4 *ipv4 = ip_spec; ic_session->src_ip.type = IPv4; diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 0a0f639e3986..f16bd45dbf6a 100644 --- a/drivers/net/ixgbe/ixgbe_pf.c +++ b/drivers/net/ixgbe/ixgbe_pf.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include @@ -450,7 +449,7 @@ ixgbe_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); /* * Piggyback the multicast filter type so VF can compute the * correct vectors @@ -472,7 +471,7 @@ ixgbe_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) if (rte_is_valid_assigned_ether_addr( (struct rte_ether_addr *)new_mac)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, 6); return hw->mac.ops.set_rar(hw, rar_entry, new_mac, vf, IXGBE_RAH_AV); } return -1; diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index ac8976062fa7..00d9de43936b 100644 --- a/drivers/net/ixgbe/ixgbe_tm.c +++ b/drivers/net/ixgbe/ixgbe_tm.c @@ -289,8 +289,8 @@ ixgbe_shaper_profile_add(struct rte_eth_dev *dev, if (!shaper_profile) return -ENOMEM; shaper_profile->shaper_profile_id = shaper_profile_id; - rte_memcpy(&shaper_profile->profile, profile, - sizeof(struct rte_tm_shaper_params)); + memcpy(&shaper_profile->profile, profile, + sizeof(struct rte_tm_shaper_params)); TAILQ_INSERT_TAIL(&tm_conf->shaper_profile_list, shaper_profile, node); @@ -637,8 +637,8 @@ ixgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->no = 0; tm_node->parent = NULL; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, + sizeof(struct rte_tm_node_params)); tm_conf->root = tm_node; /* increase the reference counter of the shaper profile */ @@ -718,8 +718,7 @@ ixgbe_node_add(struct rte_eth_dev *dev, uint32_t node_id, tm_node->reference_count = 0; tm_node->parent = parent_node; tm_node->shaper_profile = shaper_profile; - rte_memcpy(&tm_node->params, params, - sizeof(struct rte_tm_node_params)); + memcpy(&tm_node->params, params, sizeof(struct rte_tm_node_params)); if (parent_node_type == IXGBE_TM_NODE_TYPE_PORT) { tm_node->no = parent_node->reference_count; TAILQ_INSERT_TAIL(&tm_conf->tc_list, diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c index f76ef6392194..ba700fe02313 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c @@ -37,8 +37,8 @@ rte_pmd_ixgbe_set_vf_mac_addr(uint16_t port, uint16_t vf, if (rte_is_valid_assigned_ether_addr( (struct rte_ether_addr *)new_mac)) { - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, - RTE_ETHER_ADDR_LEN); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, + RTE_ETHER_ADDR_LEN); return hw->mac.ops.set_rar(hw, rar_entry, new_mac, vf, IXGBE_RAH_AV); } From patchwork Fri Mar 1 17:15:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137721 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69DFC43C12; Fri, 1 Mar 2024 18:21:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C334943446; Fri, 1 Mar 2024 18:17:59 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id DEBA8433C8 for ; Fri, 1 Mar 2024 18:17:41 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dc49afb495so22719125ad.2 for ; Fri, 01 Mar 2024 09:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313461; x=1709918261; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U14p3o16DPpdZQJaoD/yjieBVV9R77lJfaIzC2sPjsE=; b=EKKaomFtnMdMBb0uZe6CpbF9AvVejTehN35kiR22XTQEUpMwsaA+hlQS51u7TEQWJU Z2G6v2opxQiHzYabOCdgIlkeGbLU0Slr1qyiAwiEQz0agWr4/e4ozRaLsuCyax3+f2Ak E7dVwsiX8py7bIH3UNoUy2Hp8SGNcMv4RGYgVvvOnP2qw6Mbb9dwMqB/sR64cTL2uDqL 65gIoy28Kl3+upzMo+GgkTdt57mwlX3PqXCpY84ukzM5Z4onD+y5vjXwTocXQiSo7R8V ecei9Fbz3Pma6/D2cW3Fwnfwy0PNELNLPBOK4fFGvlXeG5A6FIx4efnNgsXhxDs5g6ns CVXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313461; x=1709918261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U14p3o16DPpdZQJaoD/yjieBVV9R77lJfaIzC2sPjsE=; b=Q8e2o/VZsOP6az/XlS5EXtVlT3KAhYFAm+MObnrLIILlZTX95gtOduGxAThGyhy0PD E7Y8fWdTTRxrV8KwCckiqO5mYPQfOI+IbwcDuM/zn6eKAPPm4a/YAD16All8E/mpI1zn 6iHEfAIezIIScntVrG3gd6l/RRv1HVz5Exed1MvDjEaw3CkBvMK4z7t2xZhZV3fa4OuZ iXKGZAu/ZnoCy/ZNkWlMAc/xyfUxkJsv2HYOcIlKeAFAlPWxhNBnuc0uFdO/5YsMdR6i kPe4KM+3hgiKXxir/dbwTNX3RW+ysp9103xZOi8VLxa4LN/cTzxbBWvYOmfWPxAwPTH1 RNAA== X-Gm-Message-State: AOJu0YwM35pMV/2Yp8b9nFolAVg2LpLlAjGlw3/ijw8F2x9s2a6KV194 cqYorGtVHrPQPm58v0Pn0G13zmnkJH7Bwug/wi4tAjrVeRnsNcKho9H7IyopvjjWKdiIssaYU4c Tujvvig== X-Google-Smtp-Source: AGHT+IGh5HmPMqEjLfRrrXQV8ozF6B7xX5EVuGVPw/4VaAqT74Y5gZRFH54FPfEdN+5U1VZHmWwqew== X-Received: by 2002:a17:903:1251:b0:1dc:f157:51bc with SMTP id u17-20020a170903125100b001dcf15751bcmr1553106plh.3.1709313461191; Fri, 01 Mar 2024 09:17:41 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Grajciar Subject: [PATCH v2 31/71] net/memif: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:27 -0800 Message-ID: <20240301171707.95242-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/memif_socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 649f8d0e618f..f5a3354c4652 100644 --- a/drivers/net/memif/memif_socket.c +++ b/drivers/net/memif/memif_socket.c @@ -48,7 +48,7 @@ memif_msg_send(int fd, memif_msg_t *msg, int afd) cmsg->cmsg_len = CMSG_LEN(sizeof(int)); cmsg->cmsg_level = SOL_SOCKET; cmsg->cmsg_type = SCM_RIGHTS; - rte_memcpy(CMSG_DATA(cmsg), &afd, sizeof(int)); + memcpy(CMSG_DATA(cmsg), &afd, sizeof(int)); } return sendmsg(fd, &mh, 0); @@ -675,7 +675,7 @@ memif_msg_receive(struct memif_control_channel *cc) if (cmsg->cmsg_type == SCM_CREDENTIALS) cr = (struct ucred *)CMSG_DATA(cmsg); else if (cmsg->cmsg_type == SCM_RIGHTS) - rte_memcpy(&afd, CMSG_DATA(cmsg), sizeof(int)); + memcpy(&afd, CMSG_DATA(cmsg), sizeof(int)); } cmsg = CMSG_NXTHDR(&mh, cmsg); } From patchwork Fri Mar 1 17:15:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137722 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32CB143C12; Fri, 1 Mar 2024 18:21:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F266643453; Fri, 1 Mar 2024 18:18:01 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id A49DE43308 for ; Fri, 1 Mar 2024 18:17:42 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dcad814986so20731095ad.0 for ; Fri, 01 Mar 2024 09:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313462; x=1709918262; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=teUGuCMa5oE2y6ygxjJUYiCErkP2+/WR1Ef3UB62su4=; b=ugQBFZBn6stoCtvkMM5efJ1vgnwwsS9OzhjGs3B//XJFKqRMMo7U0BkCeqReXNZeA4 FdKxoO+pffV24TOKYvWWtH5Jf+6adcm/4RmcWezWTq/FV2dy38iWwihFj69yG94kFBOe /uKxYdD9a/14ohu/29Mgc+pPuy/5EpAe+0tUL5+Ma73CrcPZMFpOl8KDK0fXxq50doa5 83E/Q5dh5EBVXXz1aIrstCcZ3shwSHGPhHpW1z4D2ulNgemyeSXARgLM0GNfO7fQISMF GIEUy+MPFoODD9keuL7DfneXU7H/w3yvk2CU+W73hZY/FC9SVE3Q7bMm9ld6hNQ9lusx Kz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313462; x=1709918262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teUGuCMa5oE2y6ygxjJUYiCErkP2+/WR1Ef3UB62su4=; b=rckK4CKM3QOet9HFb8svrDiDbV5+EklgekM3QC1asmKOHQYSt237ktMFOjxJxH5MDC veshXu+hEC+rbLMvSDLCGLZ9UoVPDAiV1c+pZSUHcm9sdjs5oGd5Kxkm4aNDx9w/XH35 4D9LqirSvnKsPZjoq4f+3Jg4JyX0CBv6W03kP8jrNBkmkNiRdf3JawFNBJAYEwba2PHJ mqtDIljUOpnZyz/ZnmHtO/KQFm3zkEZCSSFlicpYKzXnG38X+sqdn2NGkXQUNUe61J8d 2KAVHtoMo2ew8zgGDfLiJ5+1HPvCRTB4EkFTQ+Jhk6100FWLhRto+2GlFilmIRyasXcm RFrQ== X-Gm-Message-State: AOJu0Yzhwgd9Cgvc8A77BPrEEPmxLIuLng3kPjIdrIyw74AE/Sa7vauH QSDMJ0ksIWin+DUlr8NYAaJM7MD+jHW2mESiamqQy68+o8bTDlzt8o+e1KScwB99dTqJusIYrd6 yhe/ydA== X-Google-Smtp-Source: AGHT+IHV9nY99b+ou0OLk+3DvO4irlmuJRvpgLw3Sv9BxMmJPgn6SZyFeriAhzjpEEmG4yt+RsYZlQ== X-Received: by 2002:a17:903:50c:b0:1dc:92a7:f2f0 with SMTP id jn12-20020a170903050c00b001dc92a7f2f0mr1981259plb.23.1709313461969; Fri, 01 Mar 2024 09:17:41 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Devendra Singh Rawat , Alok Prasad Subject: [PATCH v2 32/71] net/qede: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:28 -0800 Message-ID: <20240301171707.95242-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index fd63262f3a47..32fa2016d260 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -180,7 +180,7 @@ static void qed_handle_bulletin_change(struct ecore_hwfn *hwfn) is_mac_exist = ecore_vf_bulletin_get_forced_mac(hwfn, mac, &is_mac_forced); if (is_mac_exist && is_mac_forced) - rte_memcpy(hwfn->hw_info.hw_mac_addr, mac, ETH_ALEN); + memcpy(hwfn->hw_info.hw_mac_addr, mac, ETH_ALEN); /* Always update link configuration according to bulletin */ qed_link_update(hwfn); From patchwork Fri Mar 1 17:15:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137723 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F01E43C12; Fri, 1 Mar 2024 18:21:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0993F43459; Fri, 1 Mar 2024 18:18:03 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 696B6433CF for ; Fri, 1 Mar 2024 18:17:43 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dc13fb0133so19560775ad.3 for ; Fri, 01 Mar 2024 09:17:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313462; x=1709918262; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BBJnI/3AyUXmaUJM8ONwUWsS208vPIazKUl8x2lK6cI=; b=DkMdzjBVXboKTGnUY5WFycIoP9eYQ9qIZonunDPKg57mgervGso1N/5dqvZPkhk59g AZgNC0fdZMSzQNjMDHwTJJvybrNM7rD7FvyqoDyuPwgfC1XEzWULfbFcEOpdM3LCQ1AY aS63OS3w0RkXaf4EkKBDXht/A+IZ6VFH+o38i660sXfeSVJTT+h/EJcOZwtVK7IYWcA7 2PZ4FIKVFmlBvDqDZprisozdBVmkwyy3mZUGZfTt+9u50RkS3RPIjYkHbJ4v470gskm9 YRPU2vTNVR5KePZVb47o0MeO1lqYkIKUyYGp0kqCBz9NAh+B3FBL2qBsL/QHZM/OA8eO FbVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313462; x=1709918262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BBJnI/3AyUXmaUJM8ONwUWsS208vPIazKUl8x2lK6cI=; b=Z9iMfzTzsKfJ9A0A7UOtnT1vsTZFX393+TerTUVUBjL1mvo6fIKhmGP/qSH1u6qO49 Nql6Mbm2ZPR+Ya3nCUbScEY6Ef6jLM2NWtV3J4zFdCFEZMw0VkqdXoagWMw9hrsiIcTN f4qOi5HjPvb8s8k0EFcVHBBhKCZj8ptxB7twl5uJC9ZOWxyQgx6VcsxeIWF8GF8d0KMk 8lGI9ZNFKJR3ySDTB46d65RNl4IPK9lpoRb+aT7rTJgzQIqAW77oyTtmIDOLfbxBR48C aSCn9Zau+yIo2Z3Y4OrIXgUskPfz98nHP2hD5yYVqLPWT4eDRKYQaKPjdWI5pQ5QpjPx SkSg== X-Gm-Message-State: AOJu0Yw22vE82WuXlQwiqMKr+rQ/JT8M+s2uu6+8peGHDA27RAOA1iCy jpG/rlCMKcghmYLB0kAnGE81xyVFmEph3IYCqu2BiZNjH+oms64rjftu7PsCONsg0HSiP1c6t7A S7WqqBg== X-Google-Smtp-Source: AGHT+IFZf2N0vVPbf2NAeeCMspnBAfrItRfIAB1VYbAOFPtEOE0rhZCplnRXg05ttnin9x9PRAjHdQ== X-Received: by 2002:a17:902:a585:b0:1db:a94f:903d with SMTP id az5-20020a170902a58500b001dba94f903dmr1975618plb.36.1709313462705; Fri, 01 Mar 2024 09:17:42 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH v2 33/71] baseband/acc: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:29 -0800 Message-ID: <20240301171707.95242-34-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 17 ++++++++--------- drivers/baseband/acc/rte_vrb_pmd.c | 21 ++++++++++----------- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 4f666e514b72..6a6212f3deed 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -2975,15 +2975,13 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, uint8_t *prev_ptr = (uint8_t *) prev_desc; uint8_t *new_ptr = (uint8_t *) desc; /* Copy first 4 words and BDESCs */ - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0, - prev_ptr + ACC_5GUL_OFFSET_0, - ACC_5GUL_SIZE_1); + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); + memcpy(new_ptr + ACC_5GUL_OFFSET_0, + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1); desc->req.op_addr = prev_desc->req.op_addr; /* Copy FCW */ - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET, - prev_ptr + ACC_DESC_FCW_OFFSET, - ACC_FCW_LD_BLEN); + memcpy(new_ptr + ACC_DESC_FCW_OFFSET, + prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN); acc100_dma_desc_ld_update(op, &desc->req, input, h_output, &in_offset, &h_out_offset, &h_out_length, harq_layout); @@ -3130,7 +3128,8 @@ enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op, desc = acc_desc(q, total_enqueued_cbs); desc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset; desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN; - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN); + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, + ACC_FCW_LD_BLEN); ret = acc100_dma_desc_ld_fill(op, &desc->req, &input, h_output, &in_offset, &h_out_offset, &h_out_length, @@ -4430,7 +4429,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); value = acc_reg_read(d, HwPfPcieGpexBridgeControl); bool firstCfg = (value != ACC100_CFG_PCI_BRIDGE); diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c index 88b1104fab47..3e5376a12e39 100644 --- a/drivers/baseband/acc/rte_vrb_pmd.c +++ b/drivers/baseband/acc/rte_vrb_pmd.c @@ -2450,15 +2450,13 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, uint8_t *prev_ptr = (uint8_t *) prev_desc; uint8_t *new_ptr = (uint8_t *) desc; /* Copy first 4 words and BDESCs. */ - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0, - prev_ptr + ACC_5GUL_OFFSET_0, - ACC_5GUL_SIZE_1); + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0); + memcpy(new_ptr + ACC_5GUL_OFFSET_0, + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1); desc->req.op_addr = prev_desc->req.op_addr; /* Copy FCW. */ - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET, - prev_ptr + ACC_DESC_FCW_OFFSET, - ACC_FCW_LD_BLEN); + memcpy(new_ptr + ACC_DESC_FCW_OFFSET, + prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN); vrb_dma_desc_ld_update(op, &desc->req, input, h_output, &in_offset, &h_out_offset, &h_out_length, harq_layout); @@ -2566,7 +2564,8 @@ vrb_enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op, fcw_offset = (desc_idx << 8) + ACC_DESC_FCW_OFFSET; desc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset; desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN; - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN); + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, + ACC_FCW_LD_BLEN); desc->req.fcw_ld.tb_trailer_size = (c - r - 1) * trail_len; ret = vrb_dma_desc_ld_fill(op, &desc->req, &input, h_output, &in_offset, &h_out_offset, @@ -3991,7 +3990,7 @@ enqueue_mldts_split_op(struct acc_queue *q, struct rte_bbdev_mldts_op *op, if (symb == 0) desc->req.cbs_in_tb = num_syms; else - rte_memcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN); + memcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN); desc->req.data_ptrs[1].address = rte_pktmbuf_iova_offset(input_q, in_offset); desc->req.data_ptrs[1].blen = q_size; in_offset += q_size; @@ -4337,7 +4336,7 @@ vrb1_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration. */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); /* Check we are already out of PG. */ status = acc_reg_read(d, VRB1_PfHiSectionPowerGatingAck); @@ -4744,7 +4743,7 @@ vrb2_configure(const char *dev_name, struct rte_acc_conf *conf) struct acc_device *d = bbdev->data->dev_private; /* Store configuration. */ - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf)); /* Explicitly releasing AXI as this may be stopped after PF FLR/BME. */ address = VRB2_PfDmaAxiControl; From patchwork Fri Mar 1 17:15:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137724 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E499F43C12; Fri, 1 Mar 2024 18:21:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B81B43461; Fri, 1 Mar 2024 18:18:04 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 35DEA433D0 for ; Fri, 1 Mar 2024 18:17:44 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21728665ad.3 for ; Fri, 01 Mar 2024 09:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313463; x=1709918263; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Orm/qFRDO0ClXKFHxnQCXc+zrpbQfCCDz7is4dR9wn8=; b=YVz/28plEDuKYLEzwFG56WnS5Cjw/u491fLBi4bflVZ1BBo5OyldfV49g7yGNuayRU 8JKXsl0DxSb9TGuwBs7e65zRjNTS3exiZF3vM7N/qOZS/nXyr2ghGSrLgxKo66+ilVOV yBvQbsIOTh7wLTyyIvBiom/K0EjZ/reHd8AhZuSuQHWPhVQGbeiALxMXNMyG+SKnNld7 XYT8NlyrLI0xirMzS5AF5GXuOf318s26zfUZVUSdTApzlUrNrLzE6kkRPDQwN6yKO25/ fep66e5WfppqDiyQ27hW/zq11cXvOk1UswQFPJWR28KrldMoXPUKcjp5ZsmCeIS8M4Vh i4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313463; x=1709918263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Orm/qFRDO0ClXKFHxnQCXc+zrpbQfCCDz7is4dR9wn8=; b=hnzYXD5ZhUOI6YXDEy969h1VH61pr0dXILiUBEfOXIAdWfYK+3OQzQVUuyVVWewQ0P lK2NBUlKabMu1eLqaRgiH7uJ4n79dpE+mrCaXZ+DeD4yluY7FVR2d0ZJNqHiHg7B1FlS wmKdTliws4UmiolukK0Ge6tNoB+hVG+bvpb2Hhb+IoBbspBAnbgsp2CmkWCev4Tj5fDX ROyd6vn/os6d+30QEKBGdhXFg+JmLVF3QaU1L5EJc8gz3sGLdwiEIXGW8Wrfw7ZrIaII L687PssSXAdhje/LcKsAQcLt4DyQM/k9kW/J8LLp9ZGHHnENZcEeg8YbbUB/v5mZP8MO pqkg== X-Gm-Message-State: AOJu0YzMBnkgdl/cuvDqdgGEx2C4/rDmaL3JFqBeF0uYe7IQUPbxmSaF IRlbWY7czBamCdSKJI3J5hDvk8JAK9In0/2fAXSuVVhPtP2HwQNaFu3jZKg8ORrT552FCqxxV5f dL2gXgA== X-Google-Smtp-Source: AGHT+IEeHwZCeiKtw5j5PfUe418iUAE5nmpk3NKiLQUuOaGaCmX6Cw8ZK8J8O81mGNDvXsCKDVUqjw== X-Received: by 2002:a17:902:c40f:b0:1dc:aea:10e1 with SMTP id k15-20020a170902c40f00b001dc0aea10e1mr2024478plk.54.1709313463508; Fri, 01 Mar 2024 09:17:43 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH v2 34/71] baseband/la12xx: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:30 -0800 Message-ID: <20240301171707.95242-35-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index bb754a539580..23e2fdb81116 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -597,8 +597,8 @@ dequeue_single_op(struct bbdev_la12xx_q_priv *q_priv, void *dst) op = q_priv->bbdev_op[ci]; - rte_memcpy(dst, q_priv->msg_ch_vaddr[ci], - sizeof(struct bbdev_ipc_enqueue_op)); + memcpy(dst, q_priv->msg_ch_vaddr[ci], + sizeof(struct bbdev_ipc_enqueue_op)); /* Move Consumer Index forward */ ci++; From patchwork Fri Mar 1 17:15:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137725 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85F1643C12; Fri, 1 Mar 2024 18:21:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 789F443421; Fri, 1 Mar 2024 18:18:05 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 01C81433DC for ; Fri, 1 Mar 2024 18:17:45 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dca8b86ee7so22451265ad.2 for ; Fri, 01 Mar 2024 09:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313464; x=1709918264; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKo3GX8T9YEP25rIsWFSPZg4wU3SDSgtwfmRWuCrJao=; b=jMz6Ftr4nvMxG1R+xSaYh5MuIJeioqEvkK0McRnF6d6wrAwfwm2+2G93dOzKNdRQg9 0DPv3t4/jT2GY0juHMMM3kGIM5Cc1IAYaZ2Ow0hTX2k4uYtcQQDj7NmJWrDGs1IK5XzZ 7vRGlrwJkM3EAbJtZEcJK6wAEIZOGOnIKxNfQHmx5+0TOpkKHnr4iVeCDsfIEpFnJv7Q LrMmrldxWw32/gC1GjNVUysunRT1ED+rOur5q5HtwgSkclNsG0Z6X8ovHlxszpYkVYlg L+wUImmDgS+YsvZaLyzDRgZcz+/Q71FYCbH3Nn5cTcaCjE8z18GgppBlkBxecZMEIfQ/ aLhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313464; x=1709918264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKo3GX8T9YEP25rIsWFSPZg4wU3SDSgtwfmRWuCrJao=; b=Ce8EIF0qbUbo6M5sMGgn/CPpSki9QB8+0MkSYaAl1owf7NBddnMyaR1UjEhMJGt3eQ UmWwgIZH2eutXkcVFEfVR+sgs3ZS6uRKuILeh29eKOovhBttXLqWoayIOdEHs15Rq7Xm tdQxvWM9SVAnvE5S8zHCRjTdp3JpeOJd/YhaniigDqvrheX12vlftCO7HrSk+eR50ICb 2yJKCAOOUtk1Gmxmifrz30+TG8Mq1K2ZTX80yXZChrbIbBUJR/ehYLNDRwfmZiwF03Iv jEpFxhJTnb6w53wRa0GNIrrTsfiZ7x+UTfWNrvaWwmosHywQrjysBXYfo5XTKnCxSLt5 zNrQ== X-Gm-Message-State: AOJu0YzcRZ0qM5jTAsUYvYP74+f9THOLWjo/rcpmjZ48//C971/gHcHf 2LgemRiToFI4mjTu8GawXoeDQNsKgA3CTLcaEVhZIBIixue29jzme9MVTjQGX6PpP75d/yoEB+b Oz/+8lg== X-Google-Smtp-Source: AGHT+IHCsH6dGZ1FiqEVpVBM1a7SizrBI1L5FMAZh/Xu5ZdL1n2H8acP9A6zwamIwFBE/FUnayIHNg== X-Received: by 2002:a17:902:868f:b0:1dc:a82f:c6cb with SMTP id g15-20020a170902868f00b001dca82fc6cbmr2102786plo.16.1709313464240; Fri, 01 Mar 2024 09:17:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu Subject: [PATCH v2 35/71] common/idpf: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:31 -0800 Message-ID: <20240301171707.95242-36-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_virtchnl.c | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c index cc4207a46e5e..2cb66371c4bd 100644 --- a/drivers/common/idpf/idpf_common_device.c +++ b/drivers/common/idpf/idpf_common_device.c @@ -459,8 +459,8 @@ idpf_vport_init(struct idpf_vport *vport, vport->num_rx_q = vport_info->num_rx_q; vport->num_rx_bufq = vport_info->num_rx_bufq; vport->max_mtu = vport_info->max_mtu; - rte_memcpy(vport->default_mac_addr, - vport_info->default_mac_addr, ETH_ALEN); + memcpy(vport->default_mac_addr, vport_info->default_mac_addr, + ETH_ALEN); vport->rss_algorithm = vport_info->rss_algorithm; vport->rss_key_size = RTE_MIN(IDPF_RSS_KEY_LEN, vport_info->rss_key_size); diff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c index 6455f640da25..96232c29d64f 100644 --- a/drivers/common/idpf/idpf_common_virtchnl.c +++ b/drivers/common/idpf/idpf_common_virtchnl.c @@ -294,7 +294,8 @@ idpf_vc_caps_get(struct idpf_adapter *adapter) return err; } - rte_memcpy(&adapter->caps, args.out_buffer, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&adapter->caps, args.out_buffer, + sizeof(struct virtchnl2_get_capabilities)); return 0; } @@ -331,7 +332,8 @@ idpf_vc_vport_create(struct idpf_vport *vport, return err; } - rte_memcpy(&(vport->vport_info.info), args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(&(vport->vport_info.info), args.out_buffer, + IDPF_DFLT_MBX_BUF_SIZE); return 0; } @@ -387,7 +389,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport, return err; } - rte_memcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); return 0; } From patchwork Fri Mar 1 17:15:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137726 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23AEF43C12; Fri, 1 Mar 2024 18:21:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAB0C43443; Fri, 1 Mar 2024 18:18:06 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id B3532433DC for ; Fri, 1 Mar 2024 18:17:45 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dc49b00bdbso24002875ad.3 for ; Fri, 01 Mar 2024 09:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313465; x=1709918265; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MBJ9KbebiLctnXbRqq3++6bQ1vDYpL0QWPR9AA8xA1k=; b=aAjLk4Iaf+8+e4TQTVFmLRar/8o/9Yc6NekXpp7DMo88veyxvq0MxTpDzKFm1wwIKZ MQgQrvVmHXYHCmqg+pa30Mnk7Ku8QaXtSJPZAsKmit1ldFj5ZcCzINjfMhQXUmu6LrEg FG4P2/ZFnyUi22OFmYFA9U91IScrZqmOXVamZktsaBU9XWfCFgpNwXjHMApaAIWpWdJ4 XFUioasbjX0e9DvzWeaxLFsGJkIqfb35bFm8U8VNgXQ1XxKwD/eACWNjAQ6eIIa0WC8Z vZNmrGlWAYgUSJ5cGPj94zknHFJohNKhEzM9Sl/eIaNW8MDZZky8lkMaraoMeTRydo38 gnbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313465; x=1709918265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MBJ9KbebiLctnXbRqq3++6bQ1vDYpL0QWPR9AA8xA1k=; b=ii3if1mTdimoxUeVdc/SHMI+v9IDI1kB35Cs9LES2C7Jqt8R5u4wnn8zhIbpP1CnDV b6zlOXxwCQR8rfMpzcxDnJV1yCxDZg0ctQtNQBTFo+Um4OmaZ+c74rQj5kKHJW6gqsUM l9qI2SLKTF9bZnbaR/IL3eXeUIPjLk+y6VtkCUfsElwoJmhMCmAB4T1spVi07rSzC0gI O/6eFiBFpEvE705YK+GdB2GWvcantvHCDIguCLIEM+m/Hi+2kSOM9DWyFjyzJoxAQDmo J0W3OP5jZFbkSEhd6jknTAUGSI19nZiT3ebwJEee9Hpu8CcGrBesE4NhFCfOmvE+qDJ2 Hdzw== X-Gm-Message-State: AOJu0YylJkHNOoPUWB+BmTr6M1lT4TBWkTOvwSgTG47oR/8mWYzOU8sR ToWzqcnUsjAHtDUxIUiyojK+XguwbYJBpWyX0C7yeAeVwyfHmC0PduZ7WHloQ6PxxkJPoark5MU N8xu1ZQ== X-Google-Smtp-Source: AGHT+IGNylCTFVu1jVcQKUIBz0SiELIPtNbLhO2bGB50hCprxdUqGrIMtxR8ttCyAxQKOUOD6q00Cw== X-Received: by 2002:a17:902:6b4c:b0:1db:cb13:10f1 with SMTP id g12-20020a1709026b4c00b001dbcb1310f1mr1955515plt.19.1709313464970; Fri, 01 Mar 2024 09:17:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH v2 36/71] common/qat: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:32 -0800 Message-ID: <20240301171707.95242-37-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_qp.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index f95dd33375a0..0c30c4d8c18d 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -871,9 +871,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp) return -EINVAL; } - rte_memcpy(src_data_addr, - cipher_crc_cap_check_plaintext, - sizeof(cipher_crc_cap_check_plaintext)); + memcpy(src_data_addr, cipher_crc_cap_check_plaintext, + sizeof(cipher_crc_cap_check_plaintext)); phy_src_addr = rte_mem_virt2iova(src_data_addr); if (phy_src_addr == 0 || phy_src_addr == RTE_BAD_IOVA) { @@ -892,9 +891,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp) auth_param = (void *)((uint8_t *)cipher_param + ICP_QAT_FW_HASH_REQUEST_PARAMETERS_OFFSET); - rte_memcpy(cipher_param->u.cipher_IV_array, - cipher_crc_cap_check_iv, - sizeof(cipher_crc_cap_check_iv)); + memcpy(cipher_param->u.cipher_IV_array, cipher_crc_cap_check_iv, + sizeof(cipher_crc_cap_check_iv)); cipher_param->cipher_offset = cipher_crc_cap_check_cipher_offset; cipher_param->cipher_length = From patchwork Fri Mar 1 17:15:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137727 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D56A343C12; Fri, 1 Mar 2024 18:21:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7C534346A; Fri, 1 Mar 2024 18:18:07 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 84E95433DE for ; Fri, 1 Mar 2024 18:17:46 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso2012024a12.2 for ; Fri, 01 Mar 2024 09:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313466; x=1709918266; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9KW1zdzm5T01/a+cb3Ov3Qa2achdwwIyvlZZPbx3Vx0=; b=w+ftNlgj1jI2ELOQTMVXzjCQZhxJHC1hfN7e1xYa4OpYO4r0D076ebIGbTO4Sbi+gh xcVyZjheIn8TBCykWsAeJJtzbnfEk63zr7iWSCJ8HXSTEIuqqhQ5nDplsp9Hgc8KVt2o tPVyrips5XtVchi6vtxeozTLygxPdRxV0/flPlqKcELrzlmlp6XeC5oxWoggKPySGSfh UYDw7mIz8hakE6EVNc/eiHpxqaM5Nbh/xmTHvgVVNdcW3ZXDdjv0mXjhLcn2SSKdmvEw Z7WDZll17EQcF1wgy573BOeh0BGa4BlMi0E87vO/dSm4nxBJKYrkNXfPyYyxMmy5FTa3 z9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313466; x=1709918266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KW1zdzm5T01/a+cb3Ov3Qa2achdwwIyvlZZPbx3Vx0=; b=InYmYHziUMkPvVQsnjxA35SVd5aCzVf1rryYhEPR/H7k5n6Qht1jsCPLTgry5boG6R k2vwTudQjLGVXBSld8VBxN1jDA8CZE81fF0EFvtPnQnDboICXuy6uQiDKMyNjrxAITQJ 3eWCTG9Zz0ynGjrfKmUTGCQZtVFJ7t1UNGeF1ZSR17gJ3xDwRRl8nFRhKu7/ZwxeqVSa jf/KISkAaiHepEuFjP/6qZOaSlbrRvdcYSkSDbSUW41OlY/pXfLPmdqWcmfTtuvP2A93 8dB3y5UZk5dnjwTSASleN8xIOso7IR2LYYy7gQRrZNzV7CDZdaJSC5OlZTrPyz45Kswu Q3Fw== X-Gm-Message-State: AOJu0YyWY33xrnZ1XxxBgG7jx6o1Q8IRuSKJkEAiexJS8TPax4/5Vu2p ol2G8UfeIZknTIhV2cbKJIUfgp+itfeJV3f6zznvjix5lgZ45VyJOXjT2Jp7DcLVbzS9Ros+MFW YyWsEPQ== X-Google-Smtp-Source: AGHT+IFsnkl6DQqpTmO9i/aoR0o7vJFDOGvfIDm0Ikzq29Sl6XtQq3ZuHa/22LayMrJnvAWFzBQ14w== X-Received: by 2002:a17:903:22c2:b0:1dc:7bc:d025 with SMTP id y2-20020a17090322c200b001dc07bcd025mr2712415plg.4.1709313465813; Fri, 01 Mar 2024 09:17:45 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Fan Zhang , Ashish Gupta Subject: [PATCH v2 37/71] compress/qat: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:33 -0800 Message-ID: <20240301171707.95242-38-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/qat/qat_comp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 559948a46a12..5bcbefe395bf 100644 --- a/drivers/compress/qat/qat_comp.c +++ b/drivers/compress/qat/qat_comp.c @@ -375,7 +375,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, QAT_DP_LOG(DEBUG, "op %p, parent_cookie %p", op, parent_cookie); /* copy original op to the local variable for restoring later */ - rte_memcpy(&op_backup, op, sizeof(op_backup)); + memcpy(&op_backup, op, sizeof(op_backup)); parent_cookie->nb_child_responses = 0; parent_cookie->nb_children = 0; @@ -401,7 +401,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, } /* prepare local dst mbuf */ - rte_memcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf)); + memcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf)); rte_pktmbuf_reset(&dst_mbuf); dst_mbuf.buf_len = dst_data_size; dst_mbuf.data_len = dst_data_size; @@ -457,7 +457,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, if (ret < 0) { QAT_DP_LOG(WARNING, "Failed to build child descriptor"); /* restore op and clear cookie */ - rte_memcpy(op, &op_backup, sizeof(op_backup)); + memcpy(op, &op_backup, sizeof(op_backup)); parent_cookie->split_op = 0; parent_cookie->nb_children = 0; return ret; @@ -468,7 +468,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp, } /* restore backed up original op */ - rte_memcpy(op, &op_backup, sizeof(op_backup)); + memcpy(op, &op_backup, sizeof(op_backup)); if (nb_descr != num_descriptors_built) QAT_DP_LOG(ERR, "split op. expected %d, built %d", From patchwork Fri Mar 1 17:15:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137728 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FF9B43C12; Fri, 1 Mar 2024 18:21:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6946043477; Fri, 1 Mar 2024 18:18:09 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 43D1D433E8 for ; Fri, 1 Mar 2024 18:17:47 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dc49b00bdbso24003275ad.3 for ; Fri, 01 Mar 2024 09:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313466; x=1709918266; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ml8BNtMCdJye1xhS+3MVMIo0y3q/nXOGoIniv8RYhzM=; b=hclE+VtZLvny4NM4PhLhIndBMJmLVKXPqBxpIAYKESzhLbWSSb6NpuOJWdYuHo6zEa JwxEmnYmwAdHpJz9tjCXi4TSUriIbZvRsBdNYtCZKWsS0pFormdH+aoH7yNdZzlsO9zh QWodlBvGxSFG1HClE0MIM6Y8QnwPmEodTWejjHDrohyJXq+V8b/DBykmop53WZq0Ss11 TtuDZuT03Wq9F6jceOQQgV8k2ejRXWCM45EOi1oRJa6KYKWuwPBoRmMQy7N0WYSmifKz r4YTCvTckcgpUG6/4nMtzGpIqk8X4L3J5QrWY4Z7J5w4BIFUIPp+3/utgMjoPRF29RRw lsiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313466; x=1709918266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ml8BNtMCdJye1xhS+3MVMIo0y3q/nXOGoIniv8RYhzM=; b=eUBBHXtXaLMYDRncYnLbWFfDbYpqx14scADozNhTFCfhx+i/mdIqIeCCiM+nfQmXC+ 59km3jmC+K7kbjbX5KlDtIJlwUvJO5RZCYDk9Sk574x3/d9RGAC5bqLYYUWr4iE4pnUc O4p7+rAiDoKBvEFvZc4NmEbiBxjuWnryz8+JTSOzm9615Hl3FC6Bzy1+ybDyDL8MZJoK 34hAJTHjXwUu1k13wqDTf+9k6lx0Wdlhr1InN6o1AbbXRqFDa9SsyDk1PHfFBI5YnjIs 94dDXH19bNNnZCQHDuMdCV8XoJty375zHMNe2lXVMI8PcOCFMpn1kAxko1YnWkqDgrjh B4ug== X-Gm-Message-State: AOJu0YyCDVCLnwzdlrjmZnXComFDoU1HEwZa4EdI84bKAZ3+k3MhazkR am1xOXKhFsqdmfV+UT4am3an0gBLxjY36D+jA8Ohd0vCHCkowq5xbO0TTPKxdvhG0G4Ragc9MF8 F79CFtQ== X-Google-Smtp-Source: AGHT+IGV04M5eNpuCpx7PEmjeEEerj29KxQ3rHtfBxLfuRi1jYNY2a/ktfR3mbxcVGZ12/TD9IVjxQ== X-Received: by 2002:a17:903:2409:b0:1dc:a605:5435 with SMTP id e9-20020a170903240900b001dca6055435mr2439799plo.31.1709313466564; Fri, 01 Mar 2024 09:17:46 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Uttarwar Subject: [PATCH v2 38/71] crypto/ccp: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:34 -0800 Message-ID: <20240301171707.95242-39-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_crypto.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 4b84b3303e18..4a70bc5d6e05 100644 --- a/drivers/crypto/ccp/ccp_crypto.c +++ b/drivers/crypto/ccp/ccp_crypto.c @@ -168,7 +168,7 @@ static int partial_hash_sha1(uint8_t *data_in, uint8_t *data_out) if (!SHA1_Init(&ctx)) return -EFAULT; SHA1_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); return 0; } @@ -179,8 +179,7 @@ static int partial_hash_sha224(uint8_t *data_in, uint8_t *data_out) if (!SHA224_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -191,8 +190,7 @@ static int partial_hash_sha256(uint8_t *data_in, uint8_t *data_out) if (!SHA256_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -203,8 +201,7 @@ static int partial_hash_sha384(uint8_t *data_in, uint8_t *data_out) if (!SHA384_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -215,8 +212,7 @@ static int partial_hash_sha512(uint8_t *data_in, uint8_t *data_out) if (!SHA512_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, - SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } From patchwork Fri Mar 1 17:15:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137729 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3527C43C12; Fri, 1 Mar 2024 18:22:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8873A4347E; Fri, 1 Mar 2024 18:18:10 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 22A52433E8 for ; Fri, 1 Mar 2024 18:17:48 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dca3951ad9so21948225ad.3 for ; Fri, 01 Mar 2024 09:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313467; x=1709918267; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FINMwYiClSWzDgSE/KQmfKaD2/JiBuvKG9zmhUkGrGw=; b=hr2zwqgoFnHAHura7nGiXu+NrF57ZsNufu2FdOniWdPzaAbOVOPxEgeUKB82+a+3oQ JopFNP7+HgCu6QkkndkKtI2mDpT9756TJI/CPvMhCgNaXH7RvX4q6rBre9SjEvbhEQCg 86L72tOrblBHXFeuhopM5Nr734KINqcz8Y4FX9OA8YBdJjoR4ZNwheIYzxJWJQHNGFrd 7PNTH4zhOmHxRHaTeC+nLqg2cedm8pa1U4OnXOKqjyNMxEVGqVcRwWSEzc1Gnj3bPNj1 4M7oO7tx8+3HFTDFm5AzGT4gH/kgsj9cDLf3zM6q8BCdZy2SgMzp2V0m6vsp7YW8/HzM qpTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313467; x=1709918267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FINMwYiClSWzDgSE/KQmfKaD2/JiBuvKG9zmhUkGrGw=; b=lrzwrRh9uWhCpW4uNFPGAFGcd9loKA8h4KnnmpGOcoAyZ9T4W3S5OE5e/mwpyXkHs6 +3wb729wXiYaOHlbZ54MMKPLR3yB0iqLk4rah1vViAS/QNdyts+nrA39PaSm7oZiXek2 j3o8NI3L2Mjp321b5N36wDzzbPDOGdU8b7topNMT8SihV11Mci9nGMLCqILsYn074lBU 6YCz2kAPdILpq4L1D7dO6P8jdXCeSV4ikNlAyrUkUws7BmlJYlVVHZy+sbQ2MZ59I561 E3QnJ03SXC2xk4+jK5SJVXtXdso3crehbuaLjpM/u5zm3DGkTrQPDhz9XJRXAnLw/9Dx gTfw== X-Gm-Message-State: AOJu0YyFC46M6mAzk6RW2rtckOXucWTe6XPMojtrt5zXp248SLL4Jd1E Z8RkQqHuCrA4kkniWtPJ6Lw569SCry5UjnKFxuho14430QA4B8pU1P0m1rQnM3GXlWsdZgRYcjp Q6o1jtA== X-Google-Smtp-Source: AGHT+IFfgmRjBIX6ny2DhKTk8+YEwiIUbiDLT+B1YKvVoXP7gf+Nz8plkkE5SEgMe1xo8oPEwGdrew== X-Received: by 2002:a17:902:ec81:b0:1dc:30d7:ff37 with SMTP id x1-20020a170902ec8100b001dc30d7ff37mr2379520plg.42.1709313467450; Fri, 01 Mar 2024 09:17:47 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj Subject: [PATCH v2 39/71] crypto/cnxk: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:35 -0800 Message-ID: <20240301171707.95242-40-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_se.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c index 1dd1dbac9afc..a67af3ec35a1 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c @@ -959,7 +959,7 @@ cnxk_crypto_cn10k_submit(void *qptr, void *inst, uint16_t nb_inst) lmt_dst = PLT_PTR_CAST(lmt_base); for (j = 0; j < i; j++) { - rte_memcpy(lmt_dst, inst, sizeof(struct cpt_inst_s)); + memcpy(lmt_dst, inst, sizeof(struct cpt_inst_s)); inst = RTE_PTR_ADD(inst, sizeof(struct cpt_inst_s)); lmt_dst = RTE_PTR_ADD(lmt_dst, 2 * sizeof(struct cpt_inst_s)); } diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c211884ddaea..e6c1e1586b9b 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -1161,7 +1161,7 @@ cpt_sm_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens, struct roc_se_fc_p void *dst = PLT_PTR_ADD(offset_vaddr, ROC_SE_OFF_CTRL_LEN); const uint64_t *src = fc_params->iv_buf; - rte_memcpy(dst, src, 16); + memcpy(dst, src, 16); } inst->w4.u64 = cpt_inst_w4.u64; } else { From patchwork Fri Mar 1 17:15:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137730 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3725643C12; Fri, 1 Mar 2024 18:22:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EB9143480; Fri, 1 Mar 2024 18:18:11 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id DD6CE433E8 for ; Fri, 1 Mar 2024 18:17:48 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d911c2103aso7697605ad.0 for ; Fri, 01 Mar 2024 09:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313468; x=1709918268; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yVL2RP/1kHT8ATMs47A2COgbtafAekxfII3HJGrOI0s=; b=oq0o7na9g2D0InOnBBhSRX6iJR3lIhaSytTaWMvbDkEtJGCJcG72aAvAB+JF4bvxCE jlFOVZK6cm/1p49Co81apuAavz4CSTz5SZM8k9N4nhaqyFkJyQcUFG6dXPziNXRFwbAe nLpmKK0aW4ULFQ7Wq6wVjmZN6keCoCrhFdA4niWeHFxxXWcmCMXnT0oxC7F7jp5KLC6Z mxI0o9Vljn4O/m7yWnZWZ5gdJ5/eJt5BKsX7iseCmllC7V/GMyUW0Q6/LWJenOrmZDC7 GYHcz1pMf3uFTVK/NlZ+U2dE7ocReisRpg0FhNtNGv4IXKlNicfFz5jCZ6C8xD8Lu30j WFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313468; x=1709918268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVL2RP/1kHT8ATMs47A2COgbtafAekxfII3HJGrOI0s=; b=trE5KUzh4P6KXekBdyjCJ+pELa1y/ppydTulKK0b+gmWPgOiQmOMZlEH8YfW91LcqH xuqfB0FATfKu8zp1f/8sc7oHbrdfVRlMZlLhVkHU9LWVeJffNDtVUatqal68eXBAX2JQ aR0zw8bR2qVDSCvEVoPJHropBNiILNHcOk7PyqPxBFKlu1ACitYFPAw7+nKkgIjBT7w5 A7WMQZIx2ub+6BAlU2Cd4xnbC0kRlXo0PYqo3YrSpAEUk9suOPoEImhcuYuQ4QbbnUjQ u4ojAoTF+DnrEEoF9+k1pwCK2fSGYhrpHSLfJNcRQrBVP/cEvZMDhkS3SaEac4KkYLd1 gSaw== X-Gm-Message-State: AOJu0YwcdkOmds+qx8SjjU0qeCrFPnZEmXK0Hn28Fjr3HnckvBVS2v7M vRJFXD0bvb+1Y4DLm6waOoyxySCjEcKzLoP0YrUR1il024Vztj0/HOUnYnN6+YrRmQz6PfaY2I1 6/guBWA== X-Google-Smtp-Source: AGHT+IE2tS26w31X6CmmxGXNjJ504DG0b3+PV7IqAWxaReVUa5etf7u9BOWx+KWeQ3E3xw3l0JywMg== X-Received: by 2002:a17:902:bcc7:b0:1dc:20f2:77bb with SMTP id o7-20020a170902bcc700b001dc20f277bbmr2295075pls.29.1709313468169; Fri, 01 Mar 2024 09:17:48 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Gagandeep Singh Subject: [PATCH v2 40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:36 -0800 Message-ID: <20240301171707.95242-41-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 44528eaf7f7a..3e7b78656bb4 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -676,7 +676,7 @@ dpaa_sec_dump(struct dpaa_sec_op_ctx *ctx, struct dpaa_sec_qp *qp) } cdb = &sess->cdb; - rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); + memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); #ifdef RTE_LIB_SECURITY printf("\nsession protocol type = %d\n", sess->proto_alg); #endif From patchwork Fri Mar 1 17:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137731 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF14643C12; Fri, 1 Mar 2024 18:22:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C232143482; Fri, 1 Mar 2024 18:18:12 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id AC55C43400 for ; Fri, 1 Mar 2024 18:17:49 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dcce5e84bcso21116575ad.1 for ; Fri, 01 Mar 2024 09:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313469; x=1709918269; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2/dZv4tXYcaE5nRc+9W8tixDh3nyUhSr+lOt9LzaCY=; b=Pvakrtf8JiPg1d/iLqxLhhMWL8XKpXPo8H6tc4FkKfwEhMXh6LERVGV8eZLNAIsqI1 FNMCMSyBhwZ/NSpJ+c0KNEdXpAZhGvN8j5WchsksjdzcCAu0OPWJNVQv2XeytDDtwANw rudTaeI5QfqMp9NFVBVTq8aNlKr/zhHsC3/C3vESIWOFbO2kXu86T2Erd1exNp01YFfM FDmhppslXlAA+6TRHPtjkJbtLILk76CanQfGmN8z+Qcq5TjTifsvlhaQtgXnHNQTPA+X 4CFxo+UpT6qVi4vuZu27CD5VVSyMauF+m7lrign6Ef/1St0xK6PObXtefpDAJnRyqYH1 7tsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313469; x=1709918269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2/dZv4tXYcaE5nRc+9W8tixDh3nyUhSr+lOt9LzaCY=; b=DhlN19pnf789GnOYBHYHDuJubSD/fa5q+hfoZaTTRtLlZub6OVjZ06mkeYWlUdu2Zn e2F0WZJjFLvEgd/kIH/aWvzzihg9W/lxk+6iNxKC2a+9spaGYMjWY/8bd8M1sDeK+PD9 P+9ski3Kff90jvOj41sjCBNyiTBBlxhpJI9tOPbyBsTNGGPVypWSX2qXijvrJZcbmSv+ k+nPNl4H/maOOqA4k6WQZm3yo+2V+B3kaxJI9Ij8n1uDkqUE9Hreo8wi0r8DMxG4kAue w+FyR340+9epVyxsptDDpFLa+qAnASCz7ATBgtk6lQ9sMSLoLECcHkElb/ZECrfMrTT8 aw8A== X-Gm-Message-State: AOJu0Yx6Q1YQQUU0P4CmeIYBCe4PvETDFxmBvxfH897O7h5ZGN1Ruc6/ eLwnyGzwDrJE6YDSKcswc/Bd5uVDwmh1qwaQns+CKHVrgyGU8f74z4adui3EG/0QSQm95gby8oE +TYN4Gw== X-Google-Smtp-Source: AGHT+IEZX98FY+ESMUYSbG3lYSLVkM/AxkPq/ft3cPqql+6h7r2P1zr14kVemQENAmT6XLm4aoOWeA== X-Received: by 2002:a17:903:11c8:b0:1dc:f157:51bd with SMTP id q8-20020a17090311c800b001dcf15751bdmr1601339plh.35.1709313468980; Fri, 01 Mar 2024 09:17:48 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji , Pablo de Lara Subject: [PATCH v2 41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:37 -0800 Message-ID: <20240301171707.95242-42-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c index a96779f05942..f3f519f2d451 100644 --- a/drivers/crypto/ipsec_mb/pmd_snow3g.c +++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c @@ -291,8 +291,8 @@ process_snow3g_hash_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops, /* Copy back digest from src to auth.digest.data */ if (digest_appended) - rte_memcpy(ops[i]->sym->auth.digest.data, - dst, SNOW3G_DIGEST_LENGTH); + memcpy(ops[i]->sym->auth.digest.data, dst, + SNOW3G_DIGEST_LENGTH); } processed_ops++; } From patchwork Fri Mar 1 17:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137732 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD96943C12; Fri, 1 Mar 2024 18:22:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12C6F43362; Fri, 1 Mar 2024 18:18:14 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 8B55F43409 for ; Fri, 1 Mar 2024 18:17:50 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dc96f64c10so23323035ad.1 for ; Fri, 01 Mar 2024 09:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313470; x=1709918270; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=; b=XXfopfhBX8u4JTR6D0SBmO6aVAo78h+L1+/nGU3Is1B3hSdmTmZ4Ybj61fVFH3MN1W xjlPq6j0bnhwT61E9+Zg1P5/aPyyUxM0mnJkZf7WJzkU98FUkquHH+Uw3TskBGslkSlv Af4aWtaeFBEs2TXxO+QId8yQOt/V9JGt1V33jzZVtlLsuegA9kc31S1mX2p29/j7De+3 /ZhXhzgQCl3BzrEO3ZNZyTIcSEseUdYWtPifDps9kSNXFod8SVjplAjRRd1bD4yeaOts nFtTzJDYwUJ8XsFP1lqFKEayGfW9QHipwl+PJ2ONjEOeCaAy6XnthSSixWInDvZnwO99 j1BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313470; x=1709918270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHqrO9fXLJb4/sDGY+8nwb3fjJ8wMgosGzfPhvDHLOw=; b=AH0ie516GTa+z0QrEDAXyEkIE9NxmYkkf49mBqFryUOR1IcDeNX0vkZez4otaUQQW4 dQcWUE8ta1xRqeNOcicsT4KG02Bc3m0XwweRR8j2v7GVPsxLEJV+IQPb5dVSD+mYJuqJ sbR3wINcAILZtu4XceY0BXKL90A97crlZHd00nj7rr1KLKob0MrkHSGAbDm7FsVAhpWV YJG+kdAsUoiO11MnMATWt6k8t/fLcl0z7wpOsm1w2LZaKf0dXSJsMCDV/GNYqME0SEsc qJRcWU3rxbqkMVO7ZcKeFWyg6L4QryfFu6lbGKuSZgkJ4PYjKo9MSpYPJQMzq7Z8v1Oe NyfQ== X-Gm-Message-State: AOJu0YwAnYMzNsmK9zKnEWCKnHQAYgijM2K8TiFYR6CYfUloY1pXhkgO IWrzTsaIelXqAkDCb9vqEMW7vTYOzS4H6ZLwlMBKkB5hNrpSdLUPW7q0oBXhBA5L3JfFwNWPUdT Q7vFwbQ== X-Google-Smtp-Source: AGHT+IFwasPgcFvj24Sf1JBcgyEY3NgVvxFG2yKAWvi/KFnePMHeOsizNDkWaIVrQALk2yGPqtwktg== X-Received: by 2002:a17:903:288:b0:1dc:df18:c5c1 with SMTP id j8-20020a170903028800b001dcdf18c5c1mr2395335plr.33.1709313469753; Fri, 01 Mar 2024 09:17:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH v2 42/71] crypto/qat: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:38 -0800 Message-ID: <20240301171707.95242-43-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/qat/qat_sym_session.c | 52 +++++++++++++--------------- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 9f4f6c3d93e0..8d7809bbec11 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -1310,7 +1310,7 @@ static int partial_hash_sha1(uint8_t *data_in, uint8_t *data_out) if (!SHA1_Init(&ctx)) return -EFAULT; SHA1_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA_DIGEST_LENGTH); return 0; } @@ -1321,7 +1321,7 @@ static int partial_hash_sha224(uint8_t *data_in, uint8_t *data_out) if (!SHA224_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -1332,7 +1332,7 @@ static int partial_hash_sha256(uint8_t *data_in, uint8_t *data_out) if (!SHA256_Init(&ctx)) return -EFAULT; SHA256_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA256_DIGEST_LENGTH); return 0; } @@ -1343,7 +1343,7 @@ static int partial_hash_sha384(uint8_t *data_in, uint8_t *data_out) if (!SHA384_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -1354,7 +1354,7 @@ static int partial_hash_sha512(uint8_t *data_in, uint8_t *data_out) if (!SHA512_Init(&ctx)) return -EFAULT; SHA512_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); + memcpy(data_out, &ctx, SHA512_DIGEST_LENGTH); return 0; } @@ -1365,7 +1365,7 @@ static int partial_hash_md5(uint8_t *data_in, uint8_t *data_out) if (!MD5_Init(&ctx)) return -EFAULT; MD5_Transform(&ctx, data_in); - rte_memcpy(data_out, &ctx, MD5_DIGEST_LENGTH); + memcpy(data_out, &ctx, MD5_DIGEST_LENGTH); return 0; } @@ -1486,8 +1486,7 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg, return -ENOMEM; } - rte_memcpy(in, AES_CMAC_SEED, - ICP_QAT_HW_AES_128_KEY_SZ); + memcpy(in, AES_CMAC_SEED, ICP_QAT_HW_AES_128_KEY_SZ); rte_memcpy(p_state_buf, auth_key, auth_keylen); if (AES_set_encrypt_key(auth_key, auth_keylen << 3, @@ -1531,8 +1530,8 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg, return -ENOMEM; } - rte_memcpy(in, qat_aes_xcbc_key_seed, - ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); + memcpy(in, qat_aes_xcbc_key_seed, + ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); for (x = 0; x < HASH_XCBC_PRECOMP_KEY_NUM; x++) { if (AES_set_encrypt_key(auth_key, auth_keylen << 3, @@ -1795,8 +1794,8 @@ static int qat_sym_do_precomputes_ipsec_mb(enum icp_qat_hw_auth_algo hash_alg, uint8_t *input = in; uint8_t *out = p_state_buf; - rte_memcpy(input, qat_aes_xcbc_key_seed, - ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); + memcpy(input, qat_aes_xcbc_key_seed, + ICP_QAT_HW_AES_XCBC_MAC_STATE2_SZ); for (i = 0; i < HASH_XCBC_PRECOMP_KEY_NUM; i++) { if (aes_ipsecmb_job(input, out, m, auth_key, auth_keylen)) { memset(input - @@ -2265,8 +2264,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, cdesc->cd_cur_ptr += sizeof(struct icp_qat_hw_auth_setup); switch (cdesc->qat_hash_alg) { case ICP_QAT_HW_AUTH_ALGO_SM3: - rte_memcpy(cdesc->cd_cur_ptr, sm3InitialState, - sizeof(sm3InitialState)); + memcpy(cdesc->cd_cur_ptr, sm3InitialState, + sizeof(sm3InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); state2_size = ICP_QAT_HW_SM3_STATE2_SZ; @@ -2277,9 +2276,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, hash_2->auth_config.config = ICP_QAT_HW_AUTH_CONFIG_BUILD(ICP_QAT_HW_AUTH_MODE2, cdesc->qat_hash_alg, digestsize); - rte_memcpy(cdesc->cd_cur_ptr + state1_size + state2_size + - sizeof(*hash_2), sm3InitialState, - sizeof(sm3InitialState)); + memcpy(cdesc->cd_cur_ptr + state1_size + state2_size + sizeof(*hash_2), + sm3InitialState, sizeof(sm3InitialState)); hash_cd_ctrl->inner_state1_sz = state1_size; hash_cd_ctrl->inner_state2_sz = state2_size; hash_cd_ctrl->inner_state2_offset = @@ -2316,8 +2314,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA1: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-1 */ - rte_memcpy(cdesc->cd_cur_ptr, sha1InitialState, - sizeof(sha1InitialState)); + memcpy(cdesc->cd_cur_ptr, sha1InitialState, + sizeof(sha1InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2343,8 +2341,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA224: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-224 */ - rte_memcpy(cdesc->cd_cur_ptr, sha224InitialState, - sizeof(sha224InitialState)); + memcpy(cdesc->cd_cur_ptr, sha224InitialState, + sizeof(sha224InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2368,8 +2366,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA256: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-256 */ - rte_memcpy(cdesc->cd_cur_ptr, sha256InitialState, - sizeof(sha256InitialState)); + memcpy(cdesc->cd_cur_ptr, sha256InitialState, + sizeof(sha256InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2393,8 +2391,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA384: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-384 */ - rte_memcpy(cdesc->cd_cur_ptr, sha384InitialState, - sizeof(sha384InitialState)); + memcpy(cdesc->cd_cur_ptr, sha384InitialState, + sizeof(sha384InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; @@ -2418,8 +2416,8 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, case ICP_QAT_HW_AUTH_ALGO_SHA512: if (cdesc->auth_mode == ICP_QAT_HW_AUTH_MODE0) { /* Plain SHA-512 */ - rte_memcpy(cdesc->cd_cur_ptr, sha512InitialState, - sizeof(sha512InitialState)); + memcpy(cdesc->cd_cur_ptr, sha512InitialState, + sizeof(sha512InitialState)); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); break; From patchwork Fri Mar 1 17:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137733 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1BA43C12; Fri, 1 Mar 2024 18:22:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 951D143490; Fri, 1 Mar 2024 18:18:15 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 4B52343413 for ; Fri, 1 Mar 2024 18:17:51 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e5a50d91b4so1803897b3a.2 for ; Fri, 01 Mar 2024 09:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313470; x=1709918270; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kr1WKZncDCsMZXScbKAM4rAgqfeNUJlqgLjmJ+Cu/Xo=; b=3Ha5aktoVzg4UdQ2h1vGwKjki2QRkC/K6acTbdFMhm6JiNHJFxOMX3IxKwcOqz6P/l tlwLzPa0e3LnJkPi9C8bgCCvcZoGC8ZRwlke2P5tRq3jPWUNT8dvh5TuOWTbmM/HGJnX Db1SMOTEaz9j8Do5rKV80z5044s31ivNueNVvJirVj+U/eY75gd70dT3TqkeyTRPA/Pz b2+0SWzVE40HubjOude3CiecvydtLmJc7xiXPUSkrn/MHKJsuHEoOnEv3a9tKaY4sj3Z Ng05ATnUxgIWiBItF5xHOKHtiD7/lbAPinASZTP7jyadWz59D74GMA52cPOOGqszbW32 tCDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313470; x=1709918270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kr1WKZncDCsMZXScbKAM4rAgqfeNUJlqgLjmJ+Cu/Xo=; b=IlZ/iLFk3QYVVzmhSa3h5EA/Q7gRfPBeON9eXYEj5dfZ14zJ/DvOQQkQZ9cWuYWM/N eDmhMrzt4yEepo9wGsCmH0JAP+kRPq3EooYDzYCtQwp1X5PRWgjbta8OMyy/z9+4p58T clN5nXxFHZ6+Y4nKtLjlf7Cj/L33GwI2ShV1HuBVf8XeiLAiF4HPBymqsxVDtcE+Wg31 Z9XeggiIns588K38kCoFZu3GCeXXGDgVOxw9AO2xeiRtRJcPK/fLhx0hWMvyYDpvduV+ c4kl+ajrx4cZd4Azf3k5RKpdsf6CVfJQYnrOre0gZfYnEzo8AnGCOBNYSNpkwOWDdCLS /nhQ== X-Gm-Message-State: AOJu0YxVTuSSJScX3HWvLzA0Orqawyw1hX8MHeFm7ToKi4gR6umbA4h3 +ox6yFMUZE+6r8mkKvfZh07yqqbcJeixwYhBKJeXal6XUquqG/MWU+Ju0BTKuV+PLD4RTb7/cVd ly8lmww== X-Google-Smtp-Source: AGHT+IFowmhBWuMhDyoXN6M4PQg4P9kdpoBOwLqZXA6/vJEHykzUPvelUaxqelWroPGWsCoKZIflJw== X-Received: by 2002:a05:6a20:3c8d:b0:19e:3a94:6309 with SMTP id b13-20020a056a203c8d00b0019e3a946309mr2611281pzj.5.1709313470510; Fri, 01 Mar 2024 09:17:50 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH v2 43/71] crypto/scheduler: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:39 -0800 Message-ID: <20240301171707.95242-44-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 6 +++--- drivers/crypto/scheduler/scheduler_failover.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c index 9a21edd32a9c..ed1833a7c61d 100644 --- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c +++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c @@ -79,7 +79,7 @@ sync_caps(struct rte_cryptodev_capabilities *caps, /* remove a uncommon cap from the array */ for (j = i; j < sync_nb_caps - 1; j++) - rte_memcpy(&caps[j], &caps[j+1], sizeof(*cap)); + memcpy(&caps[j], &caps[j + 1], sizeof(*cap)); memset(&caps[sync_nb_caps - 1], 0, sizeof(*cap)); sync_nb_caps--; @@ -216,8 +216,8 @@ sync_sec_caps(uint32_t worker_idx, * caps, from the arrays */ for (j = i; j < nb_sec_caps - 1; j++) { - rte_memcpy(&sec_caps[j], &sec_caps[j+1], - sizeof(*sec_cap)); + memcpy(&sec_caps[j], &sec_caps[j + 1], + sizeof(*sec_cap)); rte_memcpy(&sec_crypto_caps[j][0], &sec_crypto_caps[j+1][0], diff --git a/drivers/crypto/scheduler/scheduler_failover.c b/drivers/crypto/scheduler/scheduler_failover.c index 52ff2ffbb7f6..e7c6d19d25b8 100644 --- a/drivers/crypto/scheduler/scheduler_failover.c +++ b/drivers/crypto/scheduler/scheduler_failover.c @@ -171,12 +171,12 @@ scheduler_start(struct rte_cryptodev *dev) sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i; sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i; - rte_memcpy(&qp_ctx->primary_worker, - &sched_ctx->workers[PRIMARY_WORKER_IDX], - sizeof(struct scheduler_worker)); - rte_memcpy(&qp_ctx->secondary_worker, - &sched_ctx->workers[SECONDARY_WORKER_IDX], - sizeof(struct scheduler_worker)); + memcpy(&qp_ctx->primary_worker, + &sched_ctx->workers[PRIMARY_WORKER_IDX], + sizeof(struct scheduler_worker)); + memcpy(&qp_ctx->secondary_worker, + &sched_ctx->workers[SECONDARY_WORKER_IDX], + sizeof(struct scheduler_worker)); } return 0; From patchwork Fri Mar 1 17:15:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137734 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6779D43C12; Fri, 1 Mar 2024 18:22:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF9CC43494; Fri, 1 Mar 2024 18:18:16 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 067FC433ED for ; Fri, 1 Mar 2024 18:17:52 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso2012123a12.2 for ; Fri, 01 Mar 2024 09:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313471; x=1709918271; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OCPeaSpmoR4pGr1jr7yoEFFyqdCQ+w7/Q6s+B5JelMs=; b=I5krbXhlRHndjSq7R2OGlRlLX7MVlKvuydWUJRpP9FoSwRAG/RA0bYcS9ZxXnhCjBi gQgudyPlUFGbB59e1VFMhauPbsMwp/U2QQUqyhuOuB8eXZ9hBfq1agp2pLWn0PLVwm/C sT1A9nRO4LXDOEpuvR/PhThlw/7FmM9kjhExD8WMkXEaP3VRqkiKD8vOHk2KPl430UPA gGWWEXe2wHxpadMvut50u3JG/+Ph6XEi9Yci8HoSSKm4RSXbNizy0MyfLKFbmSgKfx4i XEOpkIlhe6Xh3RpmdUsC/VZ/YNjzrYzg/64VFi6LL9DxYqAqIVHoR9tcPD+APwSQeD6h YDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313471; x=1709918271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OCPeaSpmoR4pGr1jr7yoEFFyqdCQ+w7/Q6s+B5JelMs=; b=vwe92FAfIbQjB3dg7S8fatBU2YD/gmwL2J08gZ4qutIrhPN2Y5hr76xSke1YSGrav4 NBbkS/xjCMIOyWVF4luFERTR8KAgb7/aaVBagsBatU0uNNlX4IKTdWJLEkkkB4KG72F6 uaPdJL8gsBsp8ow+Hh0YmPfWWgSOVTGTCRpeqiUsFK0dXm8K44nun8Lzw32JyjhM+M81 ZV7FPqDn1NOzGj14oQ8jNMxT7uozqRDbrvZtQzvjD9OyVds9oZIysZ8EuTo3IuYgH4jg p829S8ZYTODo/enLuxB3LlQJ092eFi6G8MBLlIq7HTJb5KRMC0eCvyZJA1Lve4XZThUx owAw== X-Gm-Message-State: AOJu0YzRigOQN6z4isHpoj6j0X7i9hSg0UtdwII2N9MD3sUh2J4hLq5Q GSZKr5susQGpgUcTrPhydAHXfy1FvHyqBeNFcEwiW/5SIE6DhVo72QxMFto2F0YUQ2OqmEQTS4U AgUizwQ== X-Google-Smtp-Source: AGHT+IEPgtxDys6yMOqdbPYx6I2m8WYnyCItOPS52Yc7VWlKgF2eYt3DRISbYm6zYtEa/trP+S59nQ== X-Received: by 2002:a17:902:e74a:b0:1dc:c161:bcd4 with SMTP id p10-20020a170902e74a00b001dcc161bcd4mr2718056plf.30.1709313471304; Fri, 01 Mar 2024 09:17:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Pavan Nikhilesh , Shijith Thotton Subject: [PATCH v2 44/71] event/cnxk: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:40 -0800 Message-ID: <20240301171707.95242-45-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_tim_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cnxk/cnxk_tim_evdev.c index 6d59fdf90983..2027c4644c5d 100644 --- a/drivers/event/cnxk/cnxk_tim_evdev.c +++ b/drivers/event/cnxk/cnxk_tim_evdev.c @@ -115,8 +115,8 @@ cnxk_tim_ring_info_get(const struct rte_event_timer_adapter *adptr, adptr_info->min_resolution_ns = tim_ring->ena_periodic ? tim_ring->max_tout : tim_ring->tck_nsec; - rte_memcpy(&adptr_info->conf, &adptr->data->conf, - sizeof(struct rte_event_timer_adapter_conf)); + memcpy(&adptr_info->conf, &adptr->data->conf, + sizeof(struct rte_event_timer_adapter_conf)); } static int From patchwork Fri Mar 1 17:15:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137735 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E608443C12; Fri, 1 Mar 2024 18:22:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D20C74346F; Fri, 1 Mar 2024 18:18:17 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id B715543412 for ; Fri, 1 Mar 2024 18:17:52 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dc49afb495so22720895ad.2 for ; Fri, 01 Mar 2024 09:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313472; x=1709918272; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0X2ZlNRffbU8lumW96o5qjKL55GvanO22xjlz/60sIs=; b=atR+cTxU9VVxtDKQ0lA6Pdqi5tEpPezfiBffA0RhrnHvw6Np0l4avU3PWmkNaauzVv PEpHrDVOOOSA4mdWNEdymvGmG6V8uy0zuB0A72Dj+4VTo2Q5Im5oO+Qh8mDjio6lWmY1 UgbZqwT4JMMX878+lnCdamSd8z/MGljdhfjhQxMRGm7h9dl/20YVbvPmnN2345ux+LDm l3bm3LA+S5OHzocHf60hVKFs+gtENxtqUaZDBFOP0DziR46te6wlqgL7NhfN1QqhS3T+ HoI3nbfaPQV+u2HAWGc+NV/pUsFmYde/CeJ5CuDwVumARRMWSqeWpUeTmGK4j5Muxb4b 0NCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313472; x=1709918272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0X2ZlNRffbU8lumW96o5qjKL55GvanO22xjlz/60sIs=; b=MMulgVZSkSnDOx6uPoEN8wZJ3f7j5FcLoMdzJq3JRwtMJhtNLfV0twS194HNNEz4Ow CktrPpSIyTkEoXRY1vq+ARK9qOYxdrLDpVWzKrg62YAyvC3rqSpYN9+23MzWTw+WwXnq OWwkIydrbObME3C3fsPvf3fu146nbo20tcM3hXHzcoCk6K39eibyVff3KD1iRbb822ph HAL/1y0FfhU7PYjmvTlDSGt6F4lwfhMvCyV2sNTPV1dpg3/GHysG3qEOjFf5LhKoIkUy YIjC2YjkpQDrNGjN2SwvzqDlNwbyvIZNsMBvZLeKI5A3G6wJV7x40zT/W8thkfYQEnbq pTHA== X-Gm-Message-State: AOJu0YyRO9cvnDqYZ+UJqCtmwOYxVkd+qXX7hA71+NAfZCrQYfbVgQh8 AeBcI19nJVvbICo4uP8f1tO+jLchqxlI1k0RfBZDnEGs8XwF2ePv5qn04fUcqPW08NnKer+PMwR WVPL2IA== X-Google-Smtp-Source: AGHT+IEKgpkvXpWxA5zOm91U0L7GtY0i9MwuCaFBKPA1KR3oT96aW5NCWWtOgzimqFyNbFAq3Uzy8w== X-Received: by 2002:a17:902:da87:b0:1dc:8ba1:edc3 with SMTP id j7-20020a170902da8700b001dc8ba1edc3mr2817468plx.9.1709313472047; Fri, 01 Mar 2024 09:17:52 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:51 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Abdullah Sevincer Subject: [PATCH v2 45/71] event/dlb2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:41 -0800 Message-ID: <20240301171707.95242-46-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 271bbce54a3a..5c1cd35dbda6 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -225,7 +225,7 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2) handle->info.hw_rsrc_max.reorder_window_size = dlb2->hw_rsrc_query_results.num_hist_list_entries; - rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info)); + memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info)); return 0; } @@ -1671,7 +1671,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, qm_port->issued_releases = 0; /* Save config message too. */ - rte_memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb)); + memcpy(&qm_port->cfg.ldb, &cfg, sizeof(qm_port->cfg.ldb)); /* update state */ qm_port->state = PORT_STARTED; /* enabled at create time */ @@ -1872,7 +1872,7 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2, qm_port->issued_releases = 0; /* Save config message too. */ - rte_memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir)); + memcpy(&qm_port->cfg.dir, &cfg, sizeof(qm_port->cfg.dir)); /* update state */ qm_port->state = PORT_STARTED; /* enabled at create time */ From patchwork Fri Mar 1 17:15:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137736 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9747F43C12; Fri, 1 Mar 2024 18:22:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02BF643498; Fri, 1 Mar 2024 18:18:19 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id A91334341C for ; Fri, 1 Mar 2024 18:17:53 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1dbae7b8ff2so7552445ad.3 for ; Fri, 01 Mar 2024 09:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313473; x=1709918273; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1pKI+PC8GGOobXD0Rj0HyF7yHfXQeOvMDZSFZ7e298M=; b=QN32PEfTGYLsYP8QmTYE4MDu6CtGgj0xJgvwG2f1uotbh8FaW0amqgMMx0tlCRyyCv lrtQs/hPyEIg4Flxt1ktakg0wdPlohtDXqdB5Iq++fZIXUH1vQjMY8nSODgjY2Nt+LwR +JiUNjdZs8TAGqYeVuCe+Q6KmgZCB6k1IZIeCfiyK6c4DdxllIIqbQvcPqAnSaz4zXSS 448N6a1JQHNZhbXvE4x49vOefazRGNWt2crhkiuXJxp8DkjxJ/J2RiL04eejNLOL6i2M dPwJX3ZDW3mxjOu5KucratHp9WjRVUUkuQpJCNjB0Y4sI+Kow+aviQG5JZ0v6nbM9XmB xboA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313473; x=1709918273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pKI+PC8GGOobXD0Rj0HyF7yHfXQeOvMDZSFZ7e298M=; b=Cn1dbuuyOe97rXi6RnpIJw6YbvPfDmrH8kZog+2vmAhQwdpTCc9qED8hHJaK3uimQ9 7LU6gZFqf0LB+lwUJdv/AXjGcflXBBY5XuSwuVX72PNzdF0JBbUU0RgwF4utwfQD9C13 jph+xHgcS8IxE0mN2ti5RXmRwN0yJhri7GYzr/ugPFnx4FQOYzCizDkjCzwTZbNxsu1G cQbl1mLGw7b5AOIgItEp4/vj9sZMy+LnX06WyCHx16jpHoDg2qNSYleHae34ZR7CSkKq +E2MHr/ficrqDtfHIZcOCjRRqZCfckZfvYNY+QgyMX3pmu5W0yJTio2+9cMPa3NfetV2 zB6A== X-Gm-Message-State: AOJu0YxP7qXoMZ1Bq11FqSj0skZFoCxMaq5ZKY7YcO8ngUGFQlMrj8oE z7B7HQuYT7NL5VJbv2JkjB31QnOkR9WpKULydxJtUiQrVeAzOFXOrBm76z6EckcKiK2cIldz1uN XbXILcA== X-Google-Smtp-Source: AGHT+IFsr+V4SPZReSO6TThybMXEez96phLSk1Iy6rJIYNmmGaoWxsol0ZUlL++cir40Ey8nS6DFLQ== X-Received: by 2002:a17:903:2349:b0:1db:68d5:6281 with SMTP id c9-20020a170903234900b001db68d56281mr2774169plh.35.1709313472830; Fri, 01 Mar 2024 09:17:52 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 46/71] event/dpaa2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:42 -0800 Message-ID: <20240301171707.95242-47-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 1273455673ad..0331bb6fb91d 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -159,7 +159,7 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[], "Unable to allocate event object"); goto send_partial; } - rte_memcpy(ev_temp, event, sizeof(struct rte_event)); + memcpy(ev_temp, event, sizeof(struct rte_event)); DPAA2_SET_FD_ADDR((&fd_arr[loop]), (size_t)ev_temp); DPAA2_SET_FD_LEN((&fd_arr[loop]), sizeof(struct rte_event)); @@ -230,7 +230,7 @@ static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp, RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + memcpy(ev, ev_temp, sizeof(struct rte_event)); rte_free(ev_temp); qbman_swp_dqrr_consume(swp, dq); @@ -249,7 +249,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp, RTE_SET_USED(swp); RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + memcpy(ev, ev_temp, sizeof(struct rte_event)); rte_free(ev_temp); *dpaa2_seqn(ev->mbuf) = dqrr_index + 1; DPAA2_PER_LCORE_DQRR_SIZE++; From patchwork Fri Mar 1 17:15:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137737 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B457843C12; Fri, 1 Mar 2024 18:22:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C3F44349C; Fri, 1 Mar 2024 18:18:20 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 5C3E74341F for ; Fri, 1 Mar 2024 18:17:54 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dca8b86ee7so22452625ad.2 for ; Fri, 01 Mar 2024 09:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313473; x=1709918273; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kc3UkBu7gBJywBZiNoLul3e8PTLdPQrjXqfUVikGILo=; b=RARM34J00sErTgRwJ5N95BEA1Xxy9bQX9KN5if3T5jZSKCKxWpeDR+IsgzBENoHVLc +qHbZ0b6m2NHmeGq6OUWlV027KDwfdkAVnZNgiH4J7rbZzS3MDHI+ci29gqOgMFp03V1 Q/ZGEzwt39DCxEM8T7lul/DKTm3UQFhgCeRRzNNWUtaYh9/pmzJkkWfI7TU+48UzAlGp /EDzxosf04Cb1NAGvJvxi2JYEWtrYSj/iNWh3FnwRvxzmnopxKXl3/tbGy2750q3aOct kWvUFM5GvIVJaxA/ZHH556/x5mWOvYSYlsQGEZHhWE3YPdZhimHLdjgAPg1msG3VrgFg D8IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313473; x=1709918273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kc3UkBu7gBJywBZiNoLul3e8PTLdPQrjXqfUVikGILo=; b=UhdxuYYGLKCI/FSM85O1Ap9o42c3Je1C4G9ohbso9LijnyODfFWvqrY4Eqe2ODlFCh BIl+AqQNy9EJYEdxiOHw+/iySKh/uDRSbWnhT+e5ta7j5yxQE3yMa3XlBmec7RPfeJ+x gx1Wt/G6EMKIJWCORNskOHWvHh2IvFYryU/A/AMEzjlxxCvEi4IWWJ7dWK4JaAVz1Sbw td3yeoaAu+3X3CIEAJi1x8bTqQkeKXhJ5ZbicmX1VWTOHK4E1AZ2d1+wRYLIfjbZ1vHU ICsvuO+4FPQNU04e76Nk1tRWkGcC1awg1sQclffpHehQ+EPDwlJkG0p3VOACxJ8Ggrsb LQ3g== X-Gm-Message-State: AOJu0YzcAqdaK/1dji0H12qEdTQ3P+zzm4qFHeVosWKRUvrt0ySG5+MI 6VCAOEDwWXvwNgnS1F550AnO8khHZyMmdVb14XX1PvbrLHn30qcpPWc525pkvqfjDhPXvntCVMW cJvkdjg== X-Google-Smtp-Source: AGHT+IHaUpGqxnHkkmUpOEE7DX9hT6e2Rk8CSRssKJwA6GgQITPSlOTG6c3TeF75ngGV9LwoQmCuoQ== X-Received: by 2002:a17:903:32d0:b0:1dc:7721:94df with SMTP id i16-20020a17090332d000b001dc772194dfmr2853037plr.2.1709313473672; Fri, 01 Mar 2024 09:17:53 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Pavan Nikhilesh , Jerin Jacob Subject: [PATCH v2 47/71] event/octeontx: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:43 -0800 Message-ID: <20240301171707.95242-48-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/octeontx/timvf_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c index 090b3ed18378..6409d6d1615b 100644 --- a/drivers/event/octeontx/timvf_evdev.c +++ b/drivers/event/octeontx/timvf_evdev.c @@ -42,8 +42,8 @@ timvf_ring_info_get(const struct rte_event_timer_adapter *adptr, struct timvf_ring *timr = adptr->data->adapter_priv; adptr_info->max_tmo_ns = timr->max_tout; adptr_info->min_resolution_ns = timr->tck_nsec; - rte_memcpy(&adptr_info->conf, &adptr->data->conf, - sizeof(struct rte_event_timer_adapter_conf)); + memcpy(&adptr_info->conf, &adptr->data->conf, + sizeof(struct rte_event_timer_adapter_conf)); } static int From patchwork Fri Mar 1 17:15:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137738 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4547243C12; Fri, 1 Mar 2024 18:22:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53828434A3; Fri, 1 Mar 2024 18:18:21 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 2FCB64342A for ; Fri, 1 Mar 2024 18:17:55 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e09143c7bdso1809304b3a.3 for ; Fri, 01 Mar 2024 09:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313474; x=1709918274; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eBMV5Wv9ynO0fn/7j9CxEyEvP1Cb2sYzuB0817xSmjM=; b=S8jnv2txbQYy6JaG6lWyAB5AR/J9OpSLnEPchOB/66vAKpBU4CNysrVSb0RXBQq7bM Qag2fjOAjc00e8jsjDAf6ROJ+yW/uI7yf22lWVCvwhu9fqdQSBIUSK/e9m315u5F12+g GZLXzAeRYn65fnEpWlIiUguscFiqCDwf7+q33VYbUFx3mZkBmnjPcOzp+O0hNEjWHGMX GhldfSrf3TYdIxKD9hD/AmSpq37fgSHx3rKpaHoOOJ+nrsnIPSbqRwF9RMrTsnEqkgji TE/kkU0B7GL0ZOTSR+/VSQunA7lioZK68NnEYsm3FqTsSWQtNvBqDTnG3Jo6zhj9DNm6 8i6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313474; x=1709918274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eBMV5Wv9ynO0fn/7j9CxEyEvP1Cb2sYzuB0817xSmjM=; b=s11QiNGlVMkPKuM3KGpOufQIC+iO292GSeIbShP5z9+dcbXrEQ9MNrY7K6OFUECwS5 G9wol7XgogweLK+lDKjbLmFisjyfADuPaYSXbds87Pi8yAeCS7HmIGTqeamYda/i1+Gh FSbYQ1t3zN09bqCkpBbbb+ydYGk0eJ8GceBmS5cmzG9pFFhpOfydtI/erZ5PUxZkVgYE fkh8Pw5Ghue2MJbjN7azK+Xs2VQvJHDl2Rchmh6cHJ3eTpGEJXcLMZDnkzP7+Z0zGhDq Vxu5QyhXygvmBz0fUhNTZBqwc6jpUdP3dLE41Wcq8nQspvJxgP8xpawdGEbRfQz9X4Ix 8cFA== X-Gm-Message-State: AOJu0Yy7uuKIuflNLWsb+w/Wq1Q/w25gY5U4NW9u2XIJfKHMOF/Y9v/m c26ZvJbW41ayDtLF2QOr6h8fewkx6Wjo81NAyZTNVw6VmLQfnYvkU2yaG9peMROwCy0Mu405KeL XHaGOig== X-Google-Smtp-Source: AGHT+IFedbhYmo2sjOmej6m9V64glt6NdIrKAydtm0o47hSceHpVTa5VYo+KJv98ncjjo6+gkdPjCg== X-Received: by 2002:a05:6a20:af93:b0:1a0:f0db:2245 with SMTP id ds19-20020a056a20af9300b001a0f0db2245mr1883042pzb.54.1709313474417; Fri, 01 Mar 2024 09:17:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 48/71] mempool/dpaa: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:44 -0800 Message-ID: <20240301171707.95242-49-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index 0b484b3d9c7d..f72b51b47271 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.c +++ b/drivers/mempool/dpaa/dpaa_mempool.c @@ -115,8 +115,8 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp) return -ENOMEM; } - rte_memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid], - sizeof(struct dpaa_bp_info)); + memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid], + sizeof(struct dpaa_bp_info)); mp->pool_data = (void *)bp_info; DPAA_MEMPOOL_INFO("BMAN pool created for bpid =%d", bpid); From patchwork Fri Mar 1 17:15:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137739 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FFCB43C12; Fri, 1 Mar 2024 18:23:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87822434A5; Fri, 1 Mar 2024 18:18:22 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id E27A04341D for ; Fri, 1 Mar 2024 18:17:55 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dcab44747bso21666925ad.1 for ; Fri, 01 Mar 2024 09:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313475; x=1709918275; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m/DoatI4kn04wGFIZDaaJOx5saI4fml+dnlAmlFm6ms=; b=KF9aXDpeDJBAFas8MyuuxbniNInLvjfEilOixo5J29bU6ZnDjPjyoZdkCOtYQzFnMT CN/6qx8XvFWXN4ODJYoaCdkXKJp4DqkjqzfjKPCjTlhyj/DKnpYd5r/3Xia9HWsYSKaz M7fHve/Nn52fthwiw+afneG/Vprag15yTzka3EPTpz/CycOSQ67Rm7kZZ+7snMKcUR3C k6BpdiJlFlBR8enzxK4F6idAHJVbH2ex2cGXWnZuk4W1m640JW1qkZqMDhw7yZAxV0+D L8EqefoDDEeer25iK8otA+v5YxqKZTeJSzG8VBhI2RYbxQ7O+u3lA8IvJNx1GzuENH1h AY7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313475; x=1709918275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m/DoatI4kn04wGFIZDaaJOx5saI4fml+dnlAmlFm6ms=; b=uHR2aD9hgSJFPemiHus4iDN4QvUqNVAJHg0ZJeEhuJkws275ZEWeoLvQLo7uqMSIgu 48P5G5mR71cZOebQYCOZGqONIfw4AKGsxuntzNkYyVHGmC4LfOaDhz5sVoOJ50Y+tnrT fHVHh2Nz24bryhFuMO5ZQ4zcdgQiFv328JQj9vNFBRj6pkwKtn22Bh+3jR1ESW8puhQw x6fVgcUE/ig+pKAAkRaeSsEbUQ/EgfpoWbHF4GkVfgxsRizIqtZlSSpyjk/Zne7oJUS9 LItoaGW9zH0wNCWwYU5V6hRMURxn/gUU2RsQyfrIauPz7K+orHSBs1hLFscX7EjOrsEP JikA== X-Gm-Message-State: AOJu0Yzg7pXN91+q16PBlYfCuhCa6Ryvzdy+nABJxCNLQ/PotDW2g4xU CQWAfjOLqmIbSqjIelNDruJymq2IaJ9wbugnDUVwAN6pGjZQQMqvmpZk9fDuXqeDoesoykOCt4F z4+LULQ== X-Google-Smtp-Source: AGHT+IFVoOUuHuIZR8y0Ca/rZF5AmDHf/IT0tZ4jQ/cJqpkNNGn0MAh2+8AVBrQWtKAQ6ucISXK02Q== X-Received: by 2002:a17:903:496:b0:1d9:d341:b150 with SMTP id jj22-20020a170903049600b001d9d341b150mr2076820plb.40.1709313475158; Fri, 01 Mar 2024 09:17:55 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 49/71] mempool/dpaa2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:45 -0800 Message-ID: <20240301171707.95242-50-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 4c9245cb814c..8899c0f8e683 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -125,8 +125,8 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp) rte_dpaa2_bpid_info[bpid].bp_list = bp_list; rte_dpaa2_bpid_info[bpid].bpid = bpid; - rte_memcpy(bp_info, (void *)&rte_dpaa2_bpid_info[bpid], - sizeof(struct dpaa2_bp_info)); + memcpy(bp_info, (void *)&rte_dpaa2_bpid_info[bpid], + sizeof(struct dpaa2_bp_info)); mp->pool_data = (void *)bp_info; DPAA2_MEMPOOL_DEBUG("BP List created for bpid =%d", dpbp_attr.bpid); From patchwork Fri Mar 1 17:15:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137740 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F74543C12; Fri, 1 Mar 2024 18:23:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF3F5434AC; Fri, 1 Mar 2024 18:18:23 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id D51C943430 for ; Fri, 1 Mar 2024 18:17:56 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dccb2edc6dso21730565ad.3 for ; Fri, 01 Mar 2024 09:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313476; x=1709918276; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PEwuNOTQWu0Y17XX0KUVhKsbjqIXZhbEqqdqjoqnCTI=; b=EcgPsLDot5gyMlNVTLLJiyUh4qVhrNxAxb1AfMwMIUOWuEprZ+o8WSzzhv1yei7v8u AbtQBuUTglFnb6Uvi9iFQG6D9it0LJ3jkDzglENHDWx1i/PxBOIeZT9PzJ1NchF2QilB IN6W7As7D8+I5Q7pDyEe+TFOHvkMo6Jvct2SKr4U0U25KOVZBlhtXPdffsC6J/6hMG5j uqcYxBrmpZ8odXUDfztxlAbtmyTQBD3qCFD7HTiuHBj0y0snAXDEqLy29KmsCGfHCRa+ JoHwgPZjjaqhPL1gvHeMIzRu+V34pHOBM/nuvo4u1tThygirnWyTGPbMMeOQVb5Ykx41 cbwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313476; x=1709918276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEwuNOTQWu0Y17XX0KUVhKsbjqIXZhbEqqdqjoqnCTI=; b=j5R5HfrpvspUrsIMK8h7M77iTCV91RY4rpU2jIHWCUZRCIp7WWoD7YWHTE9B4qubRm QVQMwxmNLQ2OfDzhQzqvEx4z1/vEmbfz2zwKMKQODIxmsyoJMfHY16jjR/pM7N69lNqt Yqw8058XUYa1Asr8B4shj50PvTdk718zF9VJsUJly3DvFUKMFBKsyCibFGxt2THxqp0Q 9fIVKjraZds1+pX++ohfmRIJZnzxcuPou72z8jXmLqatWKDxnU308xEScYYsYSGJKmBh NiUy1HR5jqhKFZjn1H9v+OAVjdEnyfIliJfZw+Px3heUbfdBsnabmmBwr7fZcM32uTLi 0HyA== X-Gm-Message-State: AOJu0YwDd+Ng80Z2zIWkRtnkbv79uVQl951IEUg8wUwial7LcCVh0Nxb NU9YD+3jYiRFkVq3WX7k9hqvDxKd+GKhKcz/pD4iG7j6QCjAFd2ZbAC0VRW+In/t3ZKfvpkXlKg njA0daA== X-Google-Smtp-Source: AGHT+IEw2KIwsF7K+KEgOHBVG8irFzn1UCSctqFF/cikVS+HoB49IEkuf3GDxEaU/XB9t7nggju/mA== X-Received: by 2002:a17:903:1c5:b0:1db:f941:c9a with SMTP id e5-20020a17090301c500b001dbf9410c9amr3054709plh.45.1709313476074; Fri, 01 Mar 2024 09:17:56 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Srikanth Yalavarthi Subject: [PATCH v2 50/71] ml/cnxk: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:46 -0800 Message-ID: <20240301171707.95242-51-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cn10k_ml_model.c | 8 +++++--- drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++++++---- drivers/ml/cnxk/cnxk_ml_ops.c | 2 +- drivers/ml/cnxk/mvtvm_ml_model.c | 8 +++++--- drivers/ml/cnxk/mvtvm_ml_ops.c | 8 +++++--- 5 files changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/ml/cnxk/cn10k_ml_model.c b/drivers/ml/cnxk/cn10k_ml_model.c index 0325cd54f1f0..4e39a584fa82 100644 --- a/drivers/ml/cnxk/cn10k_ml_model.c +++ b/drivers/ml/cnxk/cn10k_ml_model.c @@ -560,7 +560,7 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set model info */ memset(info, 0, sizeof(struct rte_ml_model_info)); - rte_memcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN); + memcpy(info->name, metadata->model.name, MRVL_ML_MODEL_NAME_LEN); snprintf(info->version, RTE_ML_STR_MAX, "%u.%u.%u.%u", metadata->model.version[0], metadata->model.version[1], metadata->model.version[2], metadata->model.version[3]); @@ -579,7 +579,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set input info */ for (i = 0; i < info->nb_inputs; i++) { - rte_memcpy(input[i].name, io_info->input[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(input[i].name, io_info->input[i].name, + MRVL_ML_INPUT_NAME_LEN); input[i].nb_dims = io_info->input[i].nb_dims; input[i].shape = &io_info->input[i].shape[0]; input[i].type = io_info->input[i].qtype; @@ -590,7 +591,8 @@ cn10k_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set output info */ for (i = 0; i < info->nb_outputs; i++) { - rte_memcpy(output[i].name, io_info->output[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(output[i].name, io_info->output[i].name, + MRVL_ML_INPUT_NAME_LEN); output[i].nb_dims = io_info->output[i].nb_dims; output[i].shape = &io_info->output[i].shape[0]; output[i].type = io_info->output[i].qtype; diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c index 834e55e88e9b..e53ada7b1ce4 100644 --- a/drivers/ml/cnxk/cn10k_ml_ops.c +++ b/drivers/ml/cnxk/cn10k_ml_ops.c @@ -668,11 +668,13 @@ cn10k_ml_layer_load(void *device, uint16_t model_id, const char *layer_name, uin } /* Copy metadata to internal buffer */ - rte_memcpy(&layer->glow.metadata, buffer, sizeof(struct cn10k_ml_model_metadata)); + memcpy(&layer->glow.metadata, buffer, + sizeof(struct cn10k_ml_model_metadata)); cn10k_ml_model_metadata_update(&layer->glow.metadata); /* Set layer name */ - rte_memcpy(layer->name, layer->glow.metadata.model.name, MRVL_ML_MODEL_NAME_LEN); + memcpy(layer->name, layer->glow.metadata.model.name, + MRVL_ML_MODEL_NAME_LEN); /* Enable support for batch_size of 256 */ if (layer->glow.metadata.model.batch_size == 0) @@ -748,11 +750,12 @@ cn10k_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * model->subtype = ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL; /* Copy metadata to internal buffer */ - rte_memcpy(&model->glow.metadata, params->addr, sizeof(struct cn10k_ml_model_metadata)); + memcpy(&model->glow.metadata, params->addr, + sizeof(struct cn10k_ml_model_metadata)); cn10k_ml_model_metadata_update(&model->glow.metadata); /* Set model name */ - rte_memcpy(model->name, (char *)model->glow.metadata.model.name, 64); + memcpy(model->name, (char *)model->glow.metadata.model.name, 64); /* Enable support for batch_size of 256 */ if (model->glow.metadata.model.batch_size == 0) diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.c index 971362b24202..f9d0f50e1fc4 100644 --- a/drivers/ml/cnxk/cnxk_ml_ops.c +++ b/drivers/ml/cnxk/cnxk_ml_ops.c @@ -1400,7 +1400,7 @@ cnxk_ml_model_info_get(struct rte_ml_dev *dev, uint16_t model_id, } info = (struct rte_ml_model_info *)model->info; - rte_memcpy(model_info, info, sizeof(struct rte_ml_model_info)); + memcpy(model_info, info, sizeof(struct rte_ml_model_info)); model_info->input_info = info->input_info; model_info->output_info = info->output_info; diff --git a/drivers/ml/cnxk/mvtvm_ml_model.c b/drivers/ml/cnxk/mvtvm_ml_model.c index e3234ae44226..99b4774a2e11 100644 --- a/drivers/ml/cnxk/mvtvm_ml_model.c +++ b/drivers/ml/cnxk/mvtvm_ml_model.c @@ -310,7 +310,7 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo goto tvm_mrvl_model; metadata = &model->mvtvm.metadata; - rte_memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); + memcpy(info->name, metadata->model.name, TVMDP_NAME_STRLEN); snprintf(info->version, RTE_ML_STR_MAX, "%u.%u.%u.%u", metadata->model.version[0], metadata->model.version[1], metadata->model.version[2], metadata->model.version[3]); @@ -327,7 +327,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set input info */ for (i = 0; i < info->nb_inputs; i++) { - rte_memcpy(input[i].name, metadata->input[i].name, MRVL_ML_INPUT_NAME_LEN); + memcpy(input[i].name, metadata->input[i].name, + MRVL_ML_INPUT_NAME_LEN); input[i].nb_dims = metadata->input[i].ndim; input[i].shape = &model->mvtvm.info.input[i].shape[0]; input[i].type = model->mvtvm.info.input[i].qtype; @@ -338,7 +339,8 @@ mvtvm_ml_model_info_set(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_model *mo /* Set output info */ for (i = 0; i < info->nb_outputs; i++) { - rte_memcpy(output[i].name, metadata->output[i].name, MRVL_ML_OUTPUT_NAME_LEN); + memcpy(output[i].name, metadata->output[i].name, + MRVL_ML_OUTPUT_NAME_LEN); output[i].nb_dims = metadata->output[i].ndim; output[i].shape = &model->mvtvm.info.output[i].shape[0]; output[i].type = model->mvtvm.info.output[i].qtype; diff --git a/drivers/ml/cnxk/mvtvm_ml_ops.c b/drivers/ml/cnxk/mvtvm_ml_ops.c index e825c3fb23e6..fca7e0c3c0bc 100644 --- a/drivers/ml/cnxk/mvtvm_ml_ops.c +++ b/drivers/ml/cnxk/mvtvm_ml_ops.c @@ -194,7 +194,7 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * /* Copy mod.so */ model->mvtvm.object.so.addr = mz->addr; model->mvtvm.object.so.size = object[0].size; - rte_memcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.so.name, object[0].name, TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.so.addr, object[0].buffer, object[0].size); rte_free(object[0].buffer); @@ -203,7 +203,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * RTE_PTR_ADD(model->mvtvm.object.so.addr, RTE_ALIGN_CEIL(model->mvtvm.object.so.size, RTE_CACHE_LINE_MIN_SIZE)); model->mvtvm.object.json.size = object[1].size; - rte_memcpy(model->mvtvm.object.json.name, object[1].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.json.name, object[1].name, + TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.json.addr, object[1].buffer, object[1].size); rte_free(object[1].buffer); @@ -212,7 +213,8 @@ mvtvm_ml_model_load(struct cnxk_ml_dev *cnxk_mldev, struct rte_ml_model_params * RTE_PTR_ADD(model->mvtvm.object.json.addr, RTE_ALIGN_CEIL(model->mvtvm.object.json.size, RTE_CACHE_LINE_MIN_SIZE)); model->mvtvm.object.params.size = object[2].size; - rte_memcpy(model->mvtvm.object.params.name, object[2].name, TVMDP_NAME_STRLEN); + memcpy(model->mvtvm.object.params.name, object[2].name, + TVMDP_NAME_STRLEN); rte_memcpy(model->mvtvm.object.params.addr, object[2].buffer, object[2].size); rte_free(object[2].buffer); From patchwork Fri Mar 1 17:15:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137741 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7008843C12; Fri, 1 Mar 2024 18:23:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09A2E434AB; Fri, 1 Mar 2024 18:18:25 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 94FEF43438 for ; Fri, 1 Mar 2024 18:17:57 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dc418fa351so26373765ad.1 for ; Fri, 01 Mar 2024 09:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313477; x=1709918277; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4IfoUpHHXH5RcaWSJbL8DbKLH5aCTDa+W+jP7s5eerI=; b=JOf7IPrjxETvPqezGoCCEglhIQ/KUDqOBQo2xXy1IpfsnbosAr/9VYZpzhP/w0UDN/ 7srrPA/wBs7M0UmgOJwSHlSdgGloUi83u5IQCAZoyPKwUDoB9D4Y4Qo4AZguTBiLlCrK Cz1Es75dXi5GA7c4vWPm+0uP6eY7JP2cXKTJgPskYWwiQGrvE692ZRc7SCb3VgMLWqSO Rt4/VSiYK7frS4e91h8zrN5Cju570ZgKsROe/XY1I26jjLwrs43DQGyBwwbVlKagv18a SNX6MnNBSLI5cd7RzR2hlC12SmZhjwHYzGFI1JlTVhqePc6bll1C6Jn2G0kw5keT7ZSi lBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313477; x=1709918277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4IfoUpHHXH5RcaWSJbL8DbKLH5aCTDa+W+jP7s5eerI=; b=Kh4jBV52ZuFDFlKco9GwO0NDjMPV5qKVDo5CzsoNxPUv4EOMGNsEQMJArB9aV+DmGa jKM4bIV1MovW7u95iyh47Ro2W1ThCcofjIdsOfkvkCwE8ZC80uRh3CKLS3LKHg4IVVc6 4HY+11KmhEw4BJjrTTYpjAAFlwkH8CPhbpDRlYNEN7glnkumBTmOOneF1iGuUOPpyqT1 oZcI3mtrHPJWdtl6ZnhBQzbON/vNt3I55XtniMWM1AxwDya9YMmR27glAVOwRbmnho0D G5ZPX71E1xQRLerocRmAk9A7sASMkqJE0Y0XEK4hRvRzUEwxQldRZPqjpH5GwKJMRZmv 4CDA== X-Gm-Message-State: AOJu0YybVmv6wjZBzu/V1vSdOguuq0xYN9KagN/lQ/pPTtiE/N6LPV9k iyD6OnqSzcXtYeUjHGtpH2zLBVVDeXRiSsnD2ua46x9JBQlUf0AQqr85ulKyXv5ONSkk3KTl4ou 8X0tbMw== X-Google-Smtp-Source: AGHT+IEMP5CYO+6UyF6MAHw4pYpwsDAqEEFa83V4q2CQWThtKmAkwEpRckBk6fSwr/jBDwUU4QaxWg== X-Received: by 2002:a17:902:e746:b0:1dc:a84b:e83c with SMTP id p6-20020a170902e74600b001dca84be83cmr3783784plf.25.1709313476851; Fri, 01 Mar 2024 09:17:56 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ciara Loftus Subject: [PATCH v2 51/71] net/af_xdp: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:47 -0800 Message-ID: <20240301171707.95242-52-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 2d151e45c7cd..8efc0e707a78 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -2094,7 +2094,7 @@ get_iface_info(const char *if_name, if (ioctl(sock, SIOCGIFHWADDR, &ifr)) goto error; - rte_memcpy(eth_addr, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); + memcpy(eth_addr, ifr.ifr_hwaddr.sa_data, RTE_ETHER_ADDR_LEN); close(sock); return 0; From patchwork Fri Mar 1 17:15:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137742 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8571943C12; Fri, 1 Mar 2024 18:23:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A657D434BB; Fri, 1 Mar 2024 18:18:26 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 51FC84343B for ; Fri, 1 Mar 2024 18:17:58 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d93edfa76dso21896045ad.1 for ; Fri, 01 Mar 2024 09:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313477; x=1709918277; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nfrm44DPjmag7kpP9gtPqq7De/oX3KXQugUZcgN/YrM=; b=dMPiXd0/hCsL0VN9KSHqb8rEh1MbVdnzFvElU0PLL3tpAslW3dL+Vbff5B6VKrjqSg D0mDPHTYr3iYRY4QCVkGllARquF0FIjGnIXGx4bsIWp/yOPe24oBFpbtY9dkG6aa/fUf eS7SkioUeYEuSu8yMlLH+U3LCRXWAbzKDyGf9CYuZg+zPydi77Y2GjU7FdCwbDBWXkhk vCSy3lDt5GOYOczmo0rqlrhGXBYCGGMmVqMi1RSyBjw//A0upSrXvE7ZXrK1hS6BGkaU VcITtDZzvGXtUTcbtk0oVLSfxUUcjtYqvPxh1Nd8+yKSUURbwM2erbZ1xhPOa5N5a0HL GDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313477; x=1709918277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nfrm44DPjmag7kpP9gtPqq7De/oX3KXQugUZcgN/YrM=; b=ggLD23PWjmTXAuGKAv3tt/00eucywrHYBHnME1dpQeTeMfyPas3znSMw79uVYOS6/A MVcJUxFqTGdPqnab6iVAO6+5uyuF5QotYvpVZe51UKh7ZqrjOBdi8lppKkUc76sfUgTL idBBPZgjInzU3QlxFxlAAUCBo+OvH9lqe9AkRIGHW5uy1OCHx/br9imzAtUrw/Vwvd8G GWW/mY4JTmjf4zKezzSvwUqtjcJtAaoe3ppgsnY06VaLQIxA3w36hh4gR+42bQ6hdkyY ULYUcy0nCh9ZOUcScWx692+7BRZStc35OvDLytdyJ9TcGZDgOc2xFyX1UFaFhnBdr8VC L8Vw== X-Gm-Message-State: AOJu0YzPwMObo+hzUXnMUWweUdFnI8xCNZaihw3HAgt/I4JRmsU4JYkn g01hyD9mgXUKQia+uZbD8KzjWs7qUfqFnQi+nYYE1MK7ZCbV1N8LyNLdhff1BuM3y3s8+1qh/P+ VkCXOVA== X-Google-Smtp-Source: AGHT+IHVM1d0j3ywVxMpGTi5nTrIJhCxUDd1pSVYGebpbEfsOH5zDagCk09TilGCMaXO86lAhyctqA== X-Received: by 2002:a17:903:41c2:b0:1dc:e469:6f58 with SMTP id u2-20020a17090341c200b001dce4696f58mr3038410ple.51.1709313477633; Fri, 01 Mar 2024 09:17:57 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Steven Webster , Matt Peters Subject: [PATCH v2 52/71] net/avp: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:48 -0800 Message-ID: <20240301171707.95242-53-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 53d9e38c939b..9bd05301720e 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -248,7 +248,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) while (avp_fifo_get(avp->resp_q, (void **)&resp_addr, 1)) PMD_DRV_LOG(DEBUG, "Discarding stale response\n"); - rte_memcpy(avp->sync_addr, request, sizeof(*request)); + memcpy(avp->sync_addr, request, sizeof(*request)); count = avp_fifo_put(avp->req_q, &avp->host_sync_addr, 1); if (count < 1) { PMD_DRV_LOG(ERR, "Cannot send request %u to host\n", @@ -285,7 +285,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request) } /* copy to user buffer */ - rte_memcpy(request, avp->sync_addr, sizeof(*request)); + memcpy(request, avp->sync_addr, sizeof(*request)); ret = 0; PMD_DRV_LOG(DEBUG, "Result %d received for request %u\n", From patchwork Fri Mar 1 17:15:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137743 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C4E643C12; Fri, 1 Mar 2024 18:23:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7E81434BF; Fri, 1 Mar 2024 18:18:27 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 2BDE643422 for ; Fri, 1 Mar 2024 18:17:59 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dca3951ad9so21949425ad.3 for ; Fri, 01 Mar 2024 09:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313478; x=1709918278; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HJr/Ss1fl8QbNYvRFPhXAtqePcIQdwdA+0iZtITQPSo=; b=ghSFfeWcJQmra2PU61ohzDD0gMJxaTopH2hmLIUswJ2DQYjiULrOAmaRd8N8qiGNjX dxXaZqE4vKWN/Z43hbVcIptM/Q0oKkbFnZ+iAWOXzg9oaFitWh5IXdeT9/f6BrcQ9Iti Nu7Y2+CPf6upXcjREGW7iHuGJgj9HKqu1SGTaRK2YGvFz1fmiieIM+YLr8t69GzzqVxh YBZsHsNKwqTpaG8Mnm98pLFLLKKTmRlo8ds7T0e5ByPVfsuqohjjPzIvrtJlsEit5lw8 kwd/OVMJN+V0B+txW1Anfc8Zk1ikJ6A6XQOWa6kFdTJx4dyijRF/2Ug3+cljr8RuW6Yb k23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313478; x=1709918278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HJr/Ss1fl8QbNYvRFPhXAtqePcIQdwdA+0iZtITQPSo=; b=hXzRMe5hmcFsRTGBqaAm6OLlP9/hJcqa9cj4SFQ0dPxYf/G3yP69+ko141glsT8XkC JOK8CdLMJ/YHyBSowCzqApVOLewI5DBnL5TBVEg+O7mYxyK4qUq88Mtd0pwgDEH/WzxR WUh6DVpg+PF2odtaVf6CMFE+lVpT4K31DlrIjov35C5qLpBvdKdzO1hWu3In3oFe1A6x E3UcfX3r8YTpEM1tmKpIOxudHRFNk3hxiNM3oMaO2YBRiKeoURtK1uv9hR9UwA7UQq6Y pgpEVGT+qy04Tp7l9AJD9m8lACo9zRLHtWzoIVgGgZaiXo46lTyyQZhac1kJ+HyjBcbU Sn8A== X-Gm-Message-State: AOJu0YxLfuZZB7h9uF2feyY2kHGOsHQhcaz4p50VsBItQ0Ps19reYlvn bzeuTc610qzO86pI42MMojUrfJVSSMuKnYOLJAW1eScpNg0pcTZSMHH4o/42qxGzcZ81825Hmxf tlqZt7w== X-Google-Smtp-Source: AGHT+IHgTziViYCAvph76jyznG0+3VgBls8rhU2wsxaD7AxAHDhQieGkFQKzUk+GAR+xelkg3OL/dw== X-Received: by 2002:a17:903:1207:b0:1dc:df25:76d5 with SMTP id l7-20020a170903120700b001dcdf2576d5mr2969204plh.53.1709313478464; Fri, 01 Mar 2024 09:17:58 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Selwin Sebastian Subject: [PATCH v2 53/71] net/axgbe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:49 -0800 Message-ID: <20240301171707.95242-54-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index dd681f15a01e..7ac30106e335 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -594,7 +594,7 @@ axgbe_dev_rss_hash_update(struct rte_eth_dev *dev, if (rss_conf->rss_key != NULL && rss_conf->rss_key_len == AXGBE_RSS_HASH_KEY_SIZE) { - rte_memcpy(pdata->rss_key, rss_conf->rss_key, + memcpy(pdata->rss_key, rss_conf->rss_key, AXGBE_RSS_HASH_KEY_SIZE); /* Program the hash key */ ret = axgbe_write_rss_hash_key(pdata); @@ -637,7 +637,7 @@ axgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev, if (rss_conf->rss_key != NULL && rss_conf->rss_key_len >= AXGBE_RSS_HASH_KEY_SIZE) { - rte_memcpy(rss_conf->rss_key, pdata->rss_key, + memcpy(rss_conf->rss_key, pdata->rss_key, AXGBE_RSS_HASH_KEY_SIZE); } rss_conf->rss_key_len = AXGBE_RSS_HASH_KEY_SIZE; From patchwork Fri Mar 1 17:15:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137744 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8909543C12; Fri, 1 Mar 2024 18:23:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9E1D434C2; Fri, 1 Mar 2024 18:18:28 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 21CF643441 for ; Fri, 1 Mar 2024 18:18:00 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d7232dcb3eso18704455ad.2 for ; Fri, 01 Mar 2024 09:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313479; x=1709918279; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cjxhR4csAsqJ0aUw/Iixg8P9RLtulDrA5Ua4mBysleI=; b=P1A/lRdHUk8b+njW4Kc/wp5wrEGQSVW3TIOrqS+yY1hRTU+5wQwvdV5oDOb6ElfVUC N21DBNL9KgTZTVgZVh6XrQUEpSYmE/J4jmK8C8YUOj2DrCaCAzQquLyACH6+uFNm3NQ6 T0eJPrGkG/0QuKhyaifHd2p+FA/wlHk9WcrFiL3DGPQMCDKEMpcjQwguxhV3vYzGDgGT awZjFnlaXI+tEG63M2V+ZvvsCNtqvmZzVqLYv6tCdWaEMWuvifhUd6NBaHpVhSFGyWhz w4p+AOiksVmWQ3EOBWozVT4JKtGvd/O+V+vDQCTJCCQ+KE9rOgYjSsPs04xyS5wvVB9i 3KtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313479; x=1709918279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjxhR4csAsqJ0aUw/Iixg8P9RLtulDrA5Ua4mBysleI=; b=QnlK4YCCtpH/B8h54UxCJl6STG4Iz36MWMz1D3R90Wn0bDnjnue0L4thkJ4+XhC/DS uEYzmur5MlBVn+vinbU0w+ebRQN3iRAncsK9p77yg5V+7oBcE7+x5Bg2kbSRR81gdpO5 GgVuXjspKxRhhJA1ewxki3dxueDCc35aeQ/VUTcwS+22xgg8ZlYvchrIRRJVDNByOX3Q xRR7b2TVaiT1Uht4KThH56DNPjV/jV7tVsaGqtGDRt7zBkfgHg4jVSpos4w5IX2Q23IS uYF9FTevp+zKuHYjVOG/3tOqnAhZx2802ui+gtJaIo0Pt6NYV2YEoo7c5xGOZKpWxGbm xDBA== X-Gm-Message-State: AOJu0YzSLsJsLT+uwDiFkueUFjR4sa9dm++hRFjL3jFpbUOSM2ub4l/A UsRxqKJOJUt3xUCD5ABTB14whSRjZbHEXBszGvKxmpsXg2dMzkzjfhtCkU2yR/NXNFvkG/p9BGo S8ati3Q== X-Google-Smtp-Source: AGHT+IH+ojb7fcWDQoG+sAI4NSDufkFBN5k1PZS8ZS6rXrDVEC3jucfOvc8zrBtdvd8uN0B40qkupQ== X-Received: by 2002:a17:902:8c93:b0:1dc:b3a3:ca73 with SMTP id t19-20020a1709028c9300b001dcb3a3ca73mr2026742plo.38.1709313479320; Fri, 01 Mar 2024 09:17:59 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH v2 54/71] net/bnx2x: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:50 -0800 Message-ID: <20240301171707.95242-55-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci. Note: the indentation in this file does not follow the coding standard of DPDK, so it will get some checkpatch warnings. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 32 +++++++++++++++----------------- drivers/net/bnx2x/bnx2x_stats.c | 10 +++++----- drivers/net/bnx2x/bnx2x_vfpf.c | 19 ++++++++++--------- 3 files changed, 30 insertions(+), 31 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 597ee4335977..16a9ff7f8c06 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -2242,18 +2242,18 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf *m0) tx_parse_bd->parsing_data = (mac_type << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_hi, - &eh->dst_addr.addr_bytes[0], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_mid, - &eh->dst_addr.addr_bytes[2], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.dst_lo, - &eh->dst_addr.addr_bytes[4], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_hi, - &eh->src_addr.addr_bytes[0], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_mid, - &eh->src_addr.addr_bytes[2], 2); - rte_memcpy(&tx_parse_bd->data.mac_addr.src_lo, - &eh->src_addr.addr_bytes[4], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_hi, + &eh->dst_addr.addr_bytes[0], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_mid, + &eh->dst_addr.addr_bytes[2], 2); + memcpy(&tx_parse_bd->data.mac_addr.dst_lo, + &eh->dst_addr.addr_bytes[4], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_hi, + &eh->src_addr.addr_bytes[0], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_mid, + &eh->src_addr.addr_bytes[2], 2); + memcpy(&tx_parse_bd->data.mac_addr.src_lo, + &eh->src_addr.addr_bytes[4], 2); tx_parse_bd->data.mac_addr.dst_hi = rte_cpu_to_be_16(tx_parse_bd->data.mac_addr.dst_hi); @@ -6675,8 +6675,7 @@ bnx2x_config_rss_pf(struct bnx2x_softc *sc, struct ecore_rss_config_obj *rss_obj /* Hash bits */ params.rss_result_mask = MULTI_MASK; - rte_memcpy(params.ind_table, rss_obj->ind_table, - sizeof(params.ind_table)); + memcpy(params.ind_table, rss_obj->ind_table, sizeof(params.ind_table)); if (config_hash) { /* RSS keys */ @@ -6742,8 +6741,7 @@ bnx2x_set_mac_one(struct bnx2x_softc *sc, uint8_t * mac, /* fill a user request section if needed */ if (!rte_bit_relaxed_get32(RAMROD_CONT, ramrod_flags)) { - rte_memcpy(ramrod_param.user_req.u.mac.mac, mac, - ETH_ALEN); + memcpy(ramrod_param.user_req.u.mac.mac, mac, ETH_ALEN); rte_bit_relaxed_set32(mac_type, &ramrod_param.user_req.vlan_mac_flags); @@ -6958,7 +6956,7 @@ static void bnx2x_link_report_locked(struct bnx2x_softc *sc) ELINK_DEBUG_P1(sc, "link status change count = %x", sc->link_cnt); /* report new link params and remember the state for the next time */ - rte_memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); + memcpy(&sc->last_reported_link, &cur_data, sizeof(cur_data)); if (rte_bit_relaxed_get32(BNX2X_LINK_REPORT_LINK_DOWN, &cur_data.link_report_flags)) { diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index c07b01510a06..23c74c21c635 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -114,8 +114,8 @@ bnx2x_hw_stats_post(struct bnx2x_softc *sc) /* Update MCP's statistics if possible */ if (sc->func_stx) { - rte_memcpy(BNX2X_SP(sc, func_stats), &sc->func_stats, - sizeof(sc->func_stats)); + memcpy(BNX2X_SP(sc, func_stats), &sc->func_stats, + sizeof(sc->func_stats)); } /* loader */ @@ -817,10 +817,10 @@ bnx2x_hw_stats_update(struct bnx2x_softc *sc) etherstatspktsover1522octets); } - rte_memcpy(old, new, sizeof(struct nig_stats)); + memcpy(old, new, sizeof(struct nig_stats)); - rte_memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]), - sizeof(struct mac_stx)); + memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]), + sizeof(struct mac_stx)); estats->brb_drop_hi = pstats->brb_drop_hi; estats->brb_drop_lo = pstats->brb_drop_lo; diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c index 63953c2979ce..678c9e7d7d7c 100644 --- a/drivers/net/bnx2x/bnx2x_vfpf.c +++ b/drivers/net/bnx2x/bnx2x_vfpf.c @@ -52,9 +52,9 @@ bnx2x_check_bull(struct bnx2x_softc *sc) /* check the mac address and VLAN and allocate memory if valid */ if (valid_bitmap & (1 << MAC_ADDR_VALID) && memcmp(bull->mac, sc->old_bulletin.mac, ETH_ALEN)) - rte_memcpy(&sc->link_params.mac_addr, bull->mac, ETH_ALEN); + memcpy(&sc->link_params.mac_addr, bull->mac, ETH_ALEN); if (valid_bitmap & (1 << VLAN_VALID)) - rte_memcpy(&bull->vlan, &sc->old_bulletin.vlan, RTE_VLAN_HLEN); + memcpy(&bull->vlan, &sc->old_bulletin.vlan, RTE_VLAN_HLEN); sc->old_bulletin = *bull; @@ -569,7 +569,7 @@ bnx2x_vf_set_mac(struct bnx2x_softc *sc, int set) bnx2x_check_bull(sc); - rte_memcpy(query->filters[0].mac, sc->link_params.mac_addr, ETH_ALEN); + memcpy(query->filters[0].mac, sc->link_params.mac_addr, ETH_ALEN); bnx2x_add_tlv(sc, query, query->first_tlv.tl.length, BNX2X_VF_TLV_LIST_END, @@ -583,10 +583,10 @@ bnx2x_vf_set_mac(struct bnx2x_softc *sc, int set) while (BNX2X_VF_STATUS_FAILURE == reply->status && bnx2x_check_bull(sc)) { /* A new mac was configured by PF for us */ - rte_memcpy(sc->link_params.mac_addr, sc->pf2vf_bulletin->mac, - ETH_ALEN); - rte_memcpy(query->filters[0].mac, sc->pf2vf_bulletin->mac, - ETH_ALEN); + memcpy(sc->link_params.mac_addr, sc->pf2vf_bulletin->mac, + ETH_ALEN); + memcpy(query->filters[0].mac, sc->pf2vf_bulletin->mac, + ETH_ALEN); rc = bnx2x_do_req4pf(sc, sc->vf2pf_mbox_mapping.paddr); if (rc) @@ -622,10 +622,11 @@ bnx2x_vf_config_rss(struct bnx2x_softc *sc, BNX2X_VF_TLV_LIST_END, sizeof(struct channel_list_end_tlv)); - rte_memcpy(query->rss_key, params->rss_key, sizeof(params->rss_key)); + memcpy(query->rss_key, params->rss_key, sizeof(params->rss_key)); query->rss_key_size = T_ETH_RSS_KEY; - rte_memcpy(query->ind_table, params->ind_table, T_ETH_INDIRECTION_TABLE_SIZE); + memcpy(query->ind_table, params->ind_table, + T_ETH_INDIRECTION_TABLE_SIZE); query->ind_table_size = T_ETH_INDIRECTION_TABLE_SIZE; query->rss_result_mask = params->rss_result_mask; From patchwork Fri Mar 1 17:15:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137745 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68AD243C12; Fri, 1 Mar 2024 18:23:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2019E434C5; Fri, 1 Mar 2024 18:18:30 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id DE21F43007 for ; Fri, 1 Mar 2024 18:18:00 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dca160163dso23224965ad.3 for ; Fri, 01 Mar 2024 09:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313480; x=1709918280; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1BdvH/jouAqBbSMTjtk2oSIPDlB0H24n6S0x1MNUw1s=; b=gVngJpHqCh1CTwAsX6RDcJJu1QGW9zZRuYvnm4fvoWXejiDi9lDKfp2CkKjp36MHH2 sbFMlF43ZjvLN6UOlnfaQeHrNsCpvV+fCzROOxSkZxYil6kMVcIRCqmjU2A950AgpEzb uNB08kL7L+EEQU08O7tHskGVVeSAjNde3zUGXsYMG7brgRaELfZcJr9A4YUCm0OM4R+3 YMsWaCE7yKlbEDEoEbsXIw9DEGJay3R7AI8lyYfltiuxXxDlGLajR2ypU+KywAgq53yx HdRXAT10QwqwWlOAhU3vhBRYM0NkCbi2X8n1KAiHfL1yxH67ktHzsoI4HZmeUhA0dOkh C6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313480; x=1709918280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1BdvH/jouAqBbSMTjtk2oSIPDlB0H24n6S0x1MNUw1s=; b=o2Q4kj+jl4h/rvQKocXoFaXYkOjO+j2StMzfLeC5Imh3GMPuTSEXPbl7n5pRly+rZt WOxkZ53+9PTSx1XUztEe/+HrnkDreYTrNs6QTEvQtT7jtci1uJebw2heGBlpbFD2u8+2 S8nBBfnigDkIk7cwjS5y8w8sx+2ByXCz+m3p8FVFZqpK0+BsQsyfeLrf67KV+htyNcO+ 48WSkukSImvQsjFcGBU2v9s/4kj3/ftum7UE8MeaAl/WwEGzx6FaS2w7DgdEB2f1ZfyZ gr/D5JsU/x60oD0xCjOL0/cuyz34mV77JwKu6jNaGwCQc3a/dLpq1Bq1as/IDP42QTOY 4lzA== X-Gm-Message-State: AOJu0Yz5TcnDM1dldndGo0OE8fgNLqjv5YqmkMBSZB/4PDdkbYSXjg83 7JuzQTc8Kn6L4vLKtcI2pjLvHlmUHcHxFayp0zbDjZX3jUpBPr31odVBWva7WDfg2bY/LBJ5omJ Q8y96bQ== X-Google-Smtp-Source: AGHT+IFryp+5PI0ZkRtkDpPeh38xSpjsfJIL2EI70H5D+Qmu2NK59dxaOxaDlAF3VJHLwntTS4MOZg== X-Received: by 2002:a17:902:a50e:b0:1db:aa46:4923 with SMTP id s14-20020a170902a50e00b001dbaa464923mr2217247plq.40.1709313480158; Fri, 01 Mar 2024 09:18:00 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:17:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH v2 55/71] net/bnxt: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:51 -0800 Message-ID: <20240301171707.95242-56-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index f25bc6ff78c7..6466aa394af1 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -233,8 +233,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "DMAC is invalid!\n"); return -rte_errno; } - rte_memcpy(filter->dst_macaddr, - ð_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN); + memcpy(filter->dst_macaddr, + ð_spec->hdr.dst_addr, + RTE_ETHER_ADDR_LEN); en |= use_ntuple ? NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR : EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR; @@ -257,8 +258,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "SMAC is invalid!\n"); return -rte_errno; } - rte_memcpy(filter->src_macaddr, - ð_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN); + memcpy(filter->src_macaddr, + ð_spec->hdr.src_addr, + RTE_ETHER_ADDR_LEN); en |= use_ntuple ? NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR : EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR; @@ -423,23 +425,23 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR | EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR; - rte_memcpy(filter->src_ipaddr, - ipv6_spec->hdr.src_addr, 16); - rte_memcpy(filter->dst_ipaddr, - ipv6_spec->hdr.dst_addr, 16); + memcpy(filter->src_ipaddr, ipv6_spec->hdr.src_addr, + 16); + memcpy(filter->dst_ipaddr, ipv6_spec->hdr.dst_addr, + 16); if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr, 16)) { - rte_memcpy(filter->src_ipaddr_mask, - ipv6_mask->hdr.src_addr, 16); + memcpy(filter->src_ipaddr_mask, + ipv6_mask->hdr.src_addr, 16); en |= !use_ntuple ? 0 : NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK; } if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr, 16)) { - rte_memcpy(filter->dst_ipaddr_mask, - ipv6_mask->hdr.dst_addr, 16); + memcpy(filter->dst_ipaddr_mask, + ipv6_mask->hdr.dst_addr, 16); en |= !use_ntuple ? 0 : NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK; } @@ -591,8 +593,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - vxlan_spec->hdr.vni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + vxlan_spec->hdr.vni, 3); filter->vni = rte_be_to_cpu_32(tenant_id_be); filter->tunnel_type = @@ -645,8 +647,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr, "Invalid TNI mask"); return -rte_errno; } - rte_memcpy(((uint8_t *)&tenant_id_be + 1), - nvgre_spec->tni, 3); + memcpy(((uint8_t *)&tenant_id_be + 1), + nvgre_spec->tni, 3); filter->vni = rte_be_to_cpu_32(tenant_id_be); filter->tunnel_type = From patchwork Fri Mar 1 17:15:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137746 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 190B543C12; Fri, 1 Mar 2024 18:23:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D232434D2; Fri, 1 Mar 2024 18:18:31 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 044EC43454 for ; Fri, 1 Mar 2024 18:18:02 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d94b222a3aso24805945ad.2 for ; Fri, 01 Mar 2024 09:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313481; x=1709918281; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AajPaKn7ygQ2cAj/mS0n9MAjLbXQRA2KL0MgyQghs3s=; b=z3OvKg4ouzuP1JQabatbnZ62DXCzQwz1b589JoKyw8UPkTJYc7S1W8sW0F1VP1Edf7 /1UqJuRDapi9n1a/8lF1Zzmk6iJpVaGJFBYQy9wtb+6pqjIDnIhp64eeDOJcyZ5pQWAq Sqjqx6ijzp6+GxunvXxr7qKBR3Ysgdez79KxH9+trNe9ZLnvabNNWlQNuDkQFG0F0ma1 3+q3IHlj40pyawsxZlbjEBdmJ9+BOJbEShPNZEq9/o5EEdN9UK9TkSEi0M4K/gyBPU5r tfUiAJG6gUo9TrlxMBnBnV3B7VMlEP0Ho+wWUiNfT2fd6XRMFtM4SQNSv0ctryURhZPa kn5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313481; x=1709918281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AajPaKn7ygQ2cAj/mS0n9MAjLbXQRA2KL0MgyQghs3s=; b=uhTpHoKFNcNba1QxkF6kJT8XPYUEycbyuaVNunp/sjdp5sG8vv5p8hzZqEGxCZtBS8 o/X0H1TZvIUMkuLr5DBtOd3n5B8UrejIJN5O4CBSRZbMnU/UiAt4wr6spx7fQjwF7htW E7Gau5+BRQa7UzwgpGGerIb9Nt8YlzyXL3x1BjSC19qK+bcwqgSqY6pwhBpqZDA9koff O0Mbx9m9Bda7Dh+Gtd65Ch/GQsUYMaeO2PgdgU9OfWQ1ReY9zMOB9nJ7PXLldVNAuCAk EzGHgctqwJozg7sMVSDp8rRed7EM8FK3mPelKSb+3lLh8klTY1xmqcbjJ8sQe26wwUJg SJeg== X-Gm-Message-State: AOJu0Yxb7VXfuRT8iJBj2OJsQWZ++b0SanpNz2kRCWTlgBYAW0YmbA64 Z5I1P4+xCF38qxwA0DN6vWqQkyAliA/TyZzeB154eC3W0BfdMj4LOmriaY1nOt89Taf1lhJpDoo cVeP6tA== X-Google-Smtp-Source: AGHT+IEcRgsVFiZ0aNO1UEiQviQPSA20gs76RNJ2Ty8W6znPWlRs5Pb96yD415GfOrYfhngq+/knYQ== X-Received: by 2002:a17:902:7808:b0:1db:e78e:b38d with SMTP id p8-20020a170902780800b001dbe78eb38dmr1935551pll.18.1709313481256; Fri, 01 Mar 2024 09:18:01 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chas Williams , "Min Hu (Connor)" Subject: [PATCH v2 56/71] net/bonding: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:52 -0800 Message-ID: <20240301171707.95242-57-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- drivers/net/bonding/rte_eth_bond_flow.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 79f1b3f1a0f2..8ddf5dc80aff 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1539,10 +1539,10 @@ rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id, info->selected = port->selected; info->actor_state = port->actor_state; - rte_memcpy(&info->actor, &port->actor, sizeof(port->actor)); + memcpy(&info->actor, &port->actor, sizeof(port->actor)); info->partner_state = port->partner_state; - rte_memcpy(&info->partner, &port->partner, sizeof(port->partner)); + memcpy(&info->partner, &port->partner, sizeof(port->partner)); info->agg_port_id = port->aggregator_port_id; return 0; diff --git a/drivers/net/bonding/rte_eth_bond_flow.c b/drivers/net/bonding/rte_eth_bond_flow.c index 5d0be5caf54b..bb9d347e2be4 100644 --- a/drivers/net/bonding/rte_eth_bond_flow.c +++ b/drivers/net/bonding/rte_eth_bond_flow.c @@ -182,7 +182,7 @@ bond_flow_query_count(struct rte_eth_dev *dev, struct rte_flow *flow, count->hits = 0; count->bytes_set = 0; count->hits_set = 0; - rte_memcpy(&member_count, count, sizeof(member_count)); + memcpy(&member_count, count, sizeof(member_count)); for (i = 0; i < internals->member_count; i++) { ret = rte_flow_query(internals->members[i].port_id, flow->flows[i], action, From patchwork Fri Mar 1 17:15:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137747 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49FC543C12; Fri, 1 Mar 2024 18:24:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B896434D6; Fri, 1 Mar 2024 18:18:33 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id D095B4340F for ; Fri, 1 Mar 2024 18:18:02 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d7232dcb3eso18704745ad.2 for ; Fri, 01 Mar 2024 09:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313482; x=1709918282; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OEuU8lt6jliQgN/Zn/GWIVDAUxPwXJnWEslwIl4Qoao=; b=cQ813WsVWHpzK3/vqo3bIHC6lcy9hzlXL62VSfEPdQNWtfCDc0DtByMNEMxcUxDN0Z WNW/+7p5LcvX1PkstXdgCLWZaSsOCGH587qp9LAmgdF2vhUqux2BZmo8h8d28gOO2+xn FjdI8toj2iFzVAXFRHgJwMPpApJquqdykPehAUXVagqKZ0tUZq0QYxk7XzyViUPBHEbl p4yPIG8AAhdzx7QUGf/xEM5crAiQe5krpk3V/7cctsnarkbEI0q7qn+RFyUspnpjJ5M0 +XJodZu4iHZ/bsm8wEaHvU7kqY7HEt/4DuFVL8BD58FBNyIQPFttbb8QMG3lfnrQT/r7 352Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313482; x=1709918282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OEuU8lt6jliQgN/Zn/GWIVDAUxPwXJnWEslwIl4Qoao=; b=kYRDCuN33HXHKRfyc0yHi+Xpur8xLQPkPNMaywWTnKqa2awUESxsuHYa73rrUfAs6c 9kQkf3Hgg1jxAsZMpy5yuEzy/iPQgLuiE74RCz7RCYNMbFr0sRHeon9EvduszJGEmUYo sqq4+jv0zZ3buo1EDlGAhFLTOU7+RYk9hdBuzdCEajWymV9lhy8Qfi3mn41E79kGkyP6 he1E5PkFu8uAwixB2Wwcj+NScEQ4dXDiVTm0cCX4smhdj5/y8rBS6+qRg9TeO+TbMzJL vF4eVRYqRcJjdjFEsggqUZcK8PcCbBVgDCiIL1aNNPgS+by6eIFMsLkEGkwGDX5boecr cCqQ== X-Gm-Message-State: AOJu0YwVkTGEAVYPsSTQSU+RCITp0aGltu9+jxUpv8jtZPUDro7IgUJd XomoHP/WHcVrzyA7xESf8dQ3hqg91ZmY74ScyMm5G8Aj+0xitGI9Dg2g9u5tgtGgUaZI8GdSEen uEHeY1g== X-Google-Smtp-Source: AGHT+IFof1lVLtOYnHDBKIfDqW3DKDQCdnE7lsSF8r4EbhzmN+0o40MROHUH1f0J6A6sK6TIMrgnlQ== X-Received: by 2002:a17:903:1104:b0:1dc:a40c:31c6 with SMTP id n4-20020a170903110400b001dca40c31c6mr2052121plh.25.1709313482073; Fri, 01 Mar 2024 09:18:02 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v2 57/71] net/cnxk: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:53 -0800 Message-ID: <20240301171707.95242-58-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +- drivers/net/cnxk/cnxk_tm.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c index 5de2919047c1..ee407b177ec0 100644 --- a/drivers/net/cnxk/cnxk_ethdev_ops.c +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c @@ -451,7 +451,7 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr) } /* Update mac address to cnxk ethernet device */ - rte_memcpy(dev->mac_addr, addr->addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(dev->mac_addr, addr->addr_bytes, RTE_ETHER_ADDR_LEN); exit: return rc; diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c index c799193cb89b..5c8b0997ca7c 100644 --- a/drivers/net/cnxk/cnxk_tm.c +++ b/drivers/net/cnxk/cnxk_tm.c @@ -300,8 +300,7 @@ cnxk_nix_tm_shaper_profile_add(struct rte_eth_dev *eth_dev, uint32_t id, profile->profile.pkt_len_adj = params->pkt_length_adjust; profile->profile.pkt_mode = params->packet_mode; profile->profile.free_fn = rte_free; - rte_memcpy(&profile->params, params, - sizeof(struct rte_tm_shaper_params)); + memcpy(&profile->params, params, sizeof(struct rte_tm_shaper_params)); rc = roc_nix_tm_shaper_profile_add(nix, &profile->profile); @@ -373,7 +372,7 @@ cnxk_nix_tm_node_add(struct rte_eth_dev *eth_dev, uint32_t node_id, if (!node) return -ENOMEM; - rte_memcpy(&node->params, params, sizeof(struct rte_tm_node_params)); + memcpy(&node->params, params, sizeof(struct rte_tm_node_params)); node->nix_node.id = node_id; node->nix_node.parent_id = parent_node_id; From patchwork Fri Mar 1 17:15:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137748 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9059443C12; Fri, 1 Mar 2024 18:24:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E646434DB; Fri, 1 Mar 2024 18:18:34 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 9125A4345F for ; Fri, 1 Mar 2024 18:18:03 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dcafff3c50so19854395ad.0 for ; Fri, 01 Mar 2024 09:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313483; x=1709918283; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5nmo9BK1Og/gZ6s0zOgoE7yxSApmEIe1cya3yqZhKEg=; b=fSqPyec4CONQ6KlWxsKNBqbhoyQg0bqoiNujRlP+HRGNpUvjgby3pM28+81czzteYX hHmqpUOY6WhleSGUBifnUHUMTN9qvB++fjMmfmSz3NQDB/AmUvswywmQjvFZu43idTWB cc6imzlF2Vck4BL1yYK2uuqomx3BtLums/mXYRQyd/JGX5OFaBHJ1IxkbgUCnGlUxQ+P 0N4JmABr31dsQM9iNeBU5EdsDTcbdOTp5sy6x0+qkyEfkNcqZAUv/pzdRuphg+8zKslG evcxSHIpbHb/I+gusoEgU3UN/nFCkC98ilst3l840KdcAzyZTecUJEbikz1r52VsK6zw +Jwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313483; x=1709918283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nmo9BK1Og/gZ6s0zOgoE7yxSApmEIe1cya3yqZhKEg=; b=HhiTk14exYGvdfuhRs5pidKYe70BGhRv4DFjTWN+VPJGkWsusrnE5tU09/ulWq6cZb wD3YoXI3l2H7AWNW/H9sl88wegqKd65tC8ixofHSSJiuuzCOWr6fGD5DFhuuHisL+D9O +R1Z2bhqBAQVBpDbUgGyva/P/9Dx8woYOhoL2Kst6ihaGGokvUNRRvW/33bQWLYvSapg 6ZhMSj6pLUCN9dCqaZ3jAcbm2vyaEjICr1ngB2OHYw5LoLJlx6vC8gfG+HVSxy7Rs+Y7 ksD9G3pa20cGE87WQyFDnYzrmpqxJM/HJtfUNzJlz7NhCJ5gWXOr7ExB92VZZReuUyMY RdSA== X-Gm-Message-State: AOJu0YwK8dzvUIqHOdV9mXc+8kgu9yD3Ky3kNQYtrFXYz/7VAvh7Fdwl iAPliUTHPSioCLGwJ8yolrZuNIkKLCRkQTY5PmCEhWqP4PwF1KPnM2Qnu8NSY63sGzhsEp+BJ3u uZXFZlQ== X-Google-Smtp-Source: AGHT+IFvB0IQRwoSllztg9lPWgVkXsECfY9h3rf/Djz/uSYo1ftzGWu5GcyBMQP/UVEKRK/liTB1Sw== X-Received: by 2002:a17:902:cec1:b0:1dc:3517:1486 with SMTP id d1-20020a170902cec100b001dc35171486mr2584911plg.49.1709313482859; Fri, 01 Mar 2024 09:18:02 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang Subject: [PATCH v2 58/71] net/cpfl: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:54 -0800 Message-ID: <20240301171707.95242-59-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_vchnl.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ef19aa1b6a96..1037aec68d2d 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -2292,7 +2292,8 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *a strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE); - rte_memcpy(&base->caps, &req_caps, sizeof(struct virtchnl2_get_capabilities)); + memcpy(&base->caps, &req_caps, + sizeof(struct virtchnl2_get_capabilities)); ret = idpf_adapter_init(base); if (ret != 0) { diff --git a/drivers/net/cpfl/cpfl_vchnl.c b/drivers/net/cpfl/cpfl_vchnl.c index 7d277a0e8e83..e914014d8a9b 100644 --- a/drivers/net/cpfl/cpfl_vchnl.c +++ b/drivers/net/cpfl/cpfl_vchnl.c @@ -32,7 +32,7 @@ cpfl_cc_vport_list_get(struct cpfl_adapter_ext *adapter, return err; } - rte_memcpy(response, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); + memcpy(response, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE); return 0; } @@ -66,7 +66,7 @@ cpfl_cc_vport_info_get(struct cpfl_adapter_ext *adapter, return err; } - rte_memcpy(response, args.out_buffer, sizeof(*response)); + memcpy(response, args.out_buffer, sizeof(*response)); return 0; } From patchwork Fri Mar 1 17:15:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137749 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA83E43C12; Fri, 1 Mar 2024 18:24:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D257434E1; Fri, 1 Mar 2024 18:18:35 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 64C1343463 for ; Fri, 1 Mar 2024 18:18:04 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dcc7f4717fso23227175ad.0 for ; Fri, 01 Mar 2024 09:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313483; x=1709918283; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=; b=CZAFM/0onz4keT0OobQrWq1hyKehTiFqlHLAc+MbX53y6Dxm+r0/uxDz6SPj1ag+jP GqgCLMv05/QsS+i+s+Dww6gGsr0+dV81RPSZUlmZHRskUpeAFSw6L9qUkpBug94ZtVd6 l9cAkeyJ7+P9VlnhEuvBEeahxF/4b9Q4OUrB0cGXPbYFU3TO7RFf6uvmOjGnRy57NBnH t3pPT6aSt6FvrfbgwAyJieKtiEXL31c+p1TPBNFx6dl2IvjSYJSTQYYwWdBDDBbKQURe wOqEpe+aH6RLXH5xONdcehstbITCYa6srDT9/0JlztcvXKsFj2YL+iLmY9rwRIdDSEEq k2eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313483; x=1709918283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=; b=iIH97Tp+gAQ7cEJRk7vwNKXPD0sB6TF4mJWgqqtZ/WzFfMlJNXGMV+WJORl3yqk9xk tXWB15YgT0bCpQ8laE4bO90+YIDCvo9+qEcfVV+d5na58G4zekvKKTl/pvwlAaPrJ+4a OYk1mNZzp2QlVOiIvOZF8p9q9jFOO3pCywQW6qpGdil+OvmC9OQgKvFA6wO2pLzPiRJg 5hHV8evkIulXfHWbKOrvZVc91SkdiVy5l6OKXjZV0KmOyYMJ4cmvPbMPngrFdy+A9sc0 RbsfEap3BwsmoAoDGjQGBJHjXQeeQ5K9LO+F45BkWx92U9Dj+v9IfvRf5XbqGgccnvqT puCA== X-Gm-Message-State: AOJu0YwWpxyA56hJcrfSwecuCNC0olHs/8e+4+212BX9TFM3XAtjYhfc MuzTp5bqf/FM23s/4Z7EseyaB2q+e0sBIJ8bllUscl3mpwtj+OjUYLvvWlWMBbOGSDSaPyi0VYu GNfoUFA== X-Google-Smtp-Source: AGHT+IEGvKv/DrAcjcOybxNepgZc8GfONUVs+RMuTLWup/pKMqEL7SCIw6w0QviWwDCS1XXLGdbfXg== X-Received: by 2002:a17:902:ec90:b0:1dc:782a:89f9 with SMTP id x16-20020a170902ec9000b001dc782a89f9mr2522417plg.53.1709313483647; Fri, 01 Mar 2024 09:18:03 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH v2 59/71] net/cxgbe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:55 -0800 Message-ID: <20240301171707.95242-60-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/clip_tbl.c | 2 +- drivers/net/cxgbe/cxgbe_filter.c | 8 ++++---- drivers/net/cxgbe/l2t.c | 4 ++-- drivers/net/cxgbe/smt.c | 20 +++++++++----------- 4 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/net/cxgbe/clip_tbl.c b/drivers/net/cxgbe/clip_tbl.c index b709e26f6aa9..d30fa6425f28 100644 --- a/drivers/net/cxgbe/clip_tbl.c +++ b/drivers/net/cxgbe/clip_tbl.c @@ -115,7 +115,7 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev, if (ce) { t4_os_lock(&ce->lock); if (__atomic_load_n(&ce->refcnt, __ATOMIC_RELAXED) == 0) { - rte_memcpy(ce->addr, lip, sizeof(ce->addr)); + memcpy(ce->addr, lip, sizeof(ce->addr)); if (v6) { ce->type = FILTER_TYPE_IPV6; __atomic_store_n(&ce->refcnt, 1, diff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c index 5a7efe7a733e..3d1d087ec215 100644 --- a/drivers/net/cxgbe/cxgbe_filter.c +++ b/drivers/net/cxgbe/cxgbe_filter.c @@ -851,10 +851,10 @@ static int set_filter_wr(struct rte_eth_dev *dev, unsigned int fidx) fwr->ivlanm = cpu_to_be16(f->fs.mask.ivlan); fwr->ovlan = cpu_to_be16(f->fs.val.ovlan); fwr->ovlanm = cpu_to_be16(f->fs.mask.ovlan); - rte_memcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip)); - rte_memcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm)); - rte_memcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip)); - rte_memcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm)); + memcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip)); + memcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm)); + memcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip)); + memcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm)); fwr->lp = cpu_to_be16(f->fs.val.lport); fwr->lpm = cpu_to_be16(f->fs.mask.lport); fwr->fp = cpu_to_be16(f->fs.val.fport); diff --git a/drivers/net/cxgbe/l2t.c b/drivers/net/cxgbe/l2t.c index 21f4019ae626..7721c7953ec0 100644 --- a/drivers/net/cxgbe/l2t.c +++ b/drivers/net/cxgbe/l2t.c @@ -82,7 +82,7 @@ static int write_l2e(struct rte_eth_dev *dev, struct l2t_entry *e, int sync, V_L2T_W_NOREPLY(!sync)); req->l2t_idx = cpu_to_be16(l2t_idx); req->vlan = cpu_to_be16(e->vlan); - rte_memcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN); + memcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN); if (loopback) memset(req->dst_mac, 0, RTE_ETHER_ADDR_LEN); @@ -155,7 +155,7 @@ static struct l2t_entry *t4_l2t_alloc_switching(struct rte_eth_dev *dev, e->state = L2T_STATE_SWITCHING; e->vlan = vlan; e->lport = port; - rte_memcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN); + memcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN); __atomic_store_n(&e->refcnt, 1, __ATOMIC_RELAXED); ret = write_l2e(dev, e, 0, !L2T_LPBK, !L2T_ARPMISS); if (ret < 0) diff --git a/drivers/net/cxgbe/smt.c b/drivers/net/cxgbe/smt.c index 4e14a73753de..a74b2e0794e6 100644 --- a/drivers/net/cxgbe/smt.c +++ b/drivers/net/cxgbe/smt.c @@ -55,26 +55,24 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e) */ if (e->idx & 1) { req->pfvf1 = 0x0; - rte_memcpy(req->src_mac1, e->src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac1, e->src_mac, RTE_ETHER_ADDR_LEN); /* fill pfvf0/src_mac0 with entry * at prev index from smt-tab. */ req->pfvf0 = 0x0; - rte_memcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac, + RTE_ETHER_ADDR_LEN); } else { req->pfvf0 = 0x0; - rte_memcpy(req->src_mac0, e->src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac0, e->src_mac, RTE_ETHER_ADDR_LEN); /* fill pfvf1/src_mac1 with entry * at next index from smt-tab */ req->pfvf1 = 0x0; - rte_memcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac, + RTE_ETHER_ADDR_LEN); } row = (e->hw_idx >> 1); } else { @@ -87,8 +85,8 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e) /* fill pfvf0/src_mac0 from smt-tab */ t6req->pfvf0 = 0x0; - rte_memcpy(t6req->src_mac0, s->smtab[e->idx].src_mac, - RTE_ETHER_ADDR_LEN); + memcpy(t6req->src_mac0, s->smtab[e->idx].src_mac, + RTE_ETHER_ADDR_LEN); row = e->hw_idx; req = (struct cpl_smt_write_req *)t6req; } @@ -158,7 +156,7 @@ static struct smt_entry *t4_smt_alloc_switching(struct rte_eth_dev *dev, t4_os_lock(&e->lock); if (__atomic_load_n(&e->refcnt, __ATOMIC_RELAXED) == 0) { e->pfvf = pfvf; - rte_memcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN); + memcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN); ret = write_smt_entry(dev, e); if (ret) { e->pfvf = 0; From patchwork Fri Mar 1 17:15:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137750 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 532EA43C12; Fri, 1 Mar 2024 18:24:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6690F434E4; Fri, 1 Mar 2024 18:18:36 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 1F32F43258 for ; Fri, 1 Mar 2024 18:18:05 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1dcc7f4717fso23227265ad.0 for ; Fri, 01 Mar 2024 09:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313484; x=1709918284; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p57vwjpC1nEw57Bc54ETG2YPCxde0BlfQ9/7xhFmVps=; b=LmvHiB8pmJNcHTEyrx4ZW2LAAMGcW7gATw6A4a+BBQ7tcd6RS0kE7MNv9XFwwselO+ TpC5Y3h1Cn41rW4e+kbeTEePVmbUFC2xDrcZ7UmAFl6STw995k6PyTae88Lzbga8NzIt uJapEIZG6u8STaEVSwOLHiixSZSOAt8DO5zqhZ5mSE5QjaSopH/LnkmMpXOG72fiBNIC 2Ges0wPnCsUClP8H51tX+LHqthkukgIhsTwqfkVLa2HIRHn0xscIL1j4Ew6zZchpH+5W bFbiTZCKUsZmt3XUe7fKQKFKKitDo90p2VURunJ6DyHFvF3MrHLnYsEDqTbrgsHuAr0f lf5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313484; x=1709918284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p57vwjpC1nEw57Bc54ETG2YPCxde0BlfQ9/7xhFmVps=; b=NSyA1BpjJ2X/HQLCGeE9TUB+C+bpo5lZByQJUKlMVlZb726WZMOnHdo3hIoynJRkGT FxWEPsFn6hsmqgKcIcXD7cHpBRkKq3TO2xH8JnrXEIZ/tnec4XVhc7akkTf58Gpuqcaj b59Fv+HwKboa9zPFDkIm1zv8IhLlN6xe5mwnDydS827MupAbhB6sIWsVHq4hA7gqlKsZ c4LoxfcOV7wLl2bWJRMe43/jot3IqCtsvE47AyG5LhHmjVCAFgc7fVDJzfIg1/j8ii89 RuGR9lgglV90zWKcBMpsSOqxcoTqw5wNJPuitGweAz6YaYZasPaob8HIeE9yQVjgOa3j 7Aeg== X-Gm-Message-State: AOJu0YzW/Puspq5BntbRJyvXc3zY23HBoYudVA+Nt3TTQ0LYtSG69Uix i5YLaC0XgpdDEypC7rPxNBvszTNsbUIhm8hwmvr8nJ0l3uGEmH0UBGeOuvABPvjK6T69kxmSjHz dVNLVHg== X-Google-Smtp-Source: AGHT+IGYrBFGRwu0hUxHn09Yb0hlkZmt7AQN4X8rrqgLox/Dugmd5GenPAPaec5sDNM4rV32rIjumA== X-Received: by 2002:a17:902:db04:b0:1d9:b099:6f9 with SMTP id m4-20020a170902db0400b001d9b09906f9mr3116274plx.45.1709313484399; Fri, 01 Mar 2024 09:18:04 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 60/71] net/dpaa2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:56 -0800 Message-ID: <20240301171707.95242-61-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 - drivers/net/dpaa2/dpaa2_ethdev.c | 1 - drivers/net/dpaa2/dpaa2_recycle.c | 1 - drivers/net/dpaa2/dpaa2_rxtx.c | 1 - drivers/net/dpaa2/dpaa2_sparser.c | 1 - drivers/net/dpaa2/dpaa2_tm.c | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c index 4d33b51fead9..747fa4053276 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 97edc0042030..5799770fde5d 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/dpaa2/dpaa2_recycle.c b/drivers/net/dpaa2/dpaa2_recycle.c index fbfdf360d1ef..cda08a6cee69 100644 --- a/drivers/net/dpaa2/dpaa2_recycle.c +++ b/drivers/net/dpaa2/dpaa2_recycle.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index 23f7c4132d9e..b83015a94c62 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c index 36a14526a5c5..e2976282bfee 100644 --- a/drivers/net/dpaa2/dpaa2_sparser.c +++ b/drivers/net/dpaa2/dpaa2_sparser.c @@ -5,7 +5,6 @@ #include #include #include -#include #include #include diff --git a/drivers/net/dpaa2/dpaa2_tm.c b/drivers/net/dpaa2/dpaa2_tm.c index 8fe5bfa013bb..1749b1be2295 100644 --- a/drivers/net/dpaa2/dpaa2_tm.c +++ b/drivers/net/dpaa2/dpaa2_tm.c @@ -324,7 +324,7 @@ dpaa2_shaper_profile_add(struct rte_eth_dev *dev, uint32_t shaper_profile_id, NULL, NULL); profile->id = shaper_profile_id; - rte_memcpy(&profile->params, params, sizeof(profile->params)); + memcpy(&profile->params, params, sizeof(profile->params)); LIST_INSERT_HEAD(&priv->shaper_profiles, profile, next); From patchwork Fri Mar 1 17:15:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137751 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB5E943C12; Fri, 1 Mar 2024 18:24:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC7E0434F0; Fri, 1 Mar 2024 18:18:37 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id E082043443 for ; Fri, 1 Mar 2024 18:18:05 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e56a5b2812so1573852b3a.1 for ; Fri, 01 Mar 2024 09:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313485; x=1709918285; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9MG+vFZ0m+Ugqp5xyv+9jw4Ta8YjvNueglpe3DucYSs=; b=lvoIeESY4dGZusYnSrpD0ijoKjk6ws2bC7YeLe2mjbDvfRM6808kQ2+k8MMhCSuK1x rjQgic98KDwKgC3rXb2QBDiIUUvRQFtPnJveA3y93DXODOOXq+tYnH4UhCr2qa/oOQgq Ae1aJ/ajwvwE5G5xrBpkGxbH0nPZyltJ27QVNtLPZz6Td6KISIvpPEIIodeGUvQEn9r2 1DzQ4VHkxJSVIpP2/HJGAP448qz1wZBZLDLC5Rl3DzPLGCCMjnyvhIWrDCvkrY0wQLXs JvarNorcINQSJhMqc8gFGPhFv1A5nqiETQIpKLiB4vjPN9GqrvNyKMXTCuLmoemxuON4 uPTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313485; x=1709918285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9MG+vFZ0m+Ugqp5xyv+9jw4Ta8YjvNueglpe3DucYSs=; b=qPewfXlDkHU8CyGXNZcPtR2gliN5kL9xjVl4/JtcCY33/fsraBxGlk9orb9G1x5ua2 xfgdJ+Cj2sioDEvuFXPr8nVfEtyUl4XrGfvUrEWHFHBQrX2VfGLwmlWoGEWHfFjUXPEP uBeprwpiiuXv46o7PzTTjv0CsYFtZWptqOfFzq0JFft62mzhX0zh7E4TLspl81IifNG2 /hdmqH7MuTL0x8WUDTQQ24YSVluNj5akENAR/vDmGMJ/pQ1fggFpQbL9d+rrOuOehcrY 5gOapKByRWGm1xZv9oL0DfZmc+UPObDKCv0vjaQi1/G0xZQUXonQZNJ+z3gY67JTVQZl 3Igg== X-Gm-Message-State: AOJu0YxcuDlESTSiCkAv0SB2yEGemeyweAzaK/SSZpg2n9f1Jr6yNOJz 0lZjUO+B94ThssiADo21Z47IrGmdQipaD8PmgSjDy90WT2Je7weGfGfbwkbPnFvPjZoj6uHkrQs N1O5Rvw== X-Google-Smtp-Source: AGHT+IFM40c1+TbD5Hq6Y+pxxrS6hNVKU/QG0fzgqe694/TK7ub80jc6lYC+X3MGeGtSpbSMjE2pMg== X-Received: by 2002:a05:6a20:428e:b0:1a1:43c1:84f8 with SMTP id o14-20020a056a20428e00b001a143c184f8mr598453pzj.8.1709313485137; Fri, 01 Mar 2024 09:18:05 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 61/71] net/e1000: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:57 -0800 Message-ID: <20240301171707.95242-62-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_rxtx.c | 1 - drivers/net/e1000/igb_flow.c | 22 ++++++++++------------ drivers/net/e1000/igb_pf.c | 7 +++---- drivers/net/e1000/igb_rxtx.c | 1 - 4 files changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index df5fbb782361..3a069ce33ecd 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index ea9b290e1cb5..8bca48496035 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1484,9 +1484,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&igb_filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -1511,9 +1511,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&igb_filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -1536,9 +1536,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&igb_filter_syn_list, syn_filter_ptr, entries); @@ -1562,9 +1561,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&flex_filter_ptr->filter_info, - &flex_filter, - sizeof(struct igb_flex_filter)); + memcpy(&flex_filter_ptr->filter_info, &flex_filter, + sizeof(struct igb_flex_filter)); TAILQ_INSERT_TAIL(&igb_filter_flex_list, flex_filter_ptr, entries); flow->rule = flex_filter_ptr; diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index c7588ea57eaa..efb806af5692 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include @@ -290,7 +289,7 @@ igb_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = E1000_VF_RESET | E1000_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); e1000_write_mbx(hw, msgbuf, 3, vf); return 0; @@ -308,8 +307,8 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) if (rte_is_unicast_ether_addr((struct rte_ether_addr *)new_mac)) { if (!rte_is_zero_ether_addr((struct rte_ether_addr *)new_mac)) - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, - sizeof(vfinfo[vf].vf_mac_addresses)); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, + sizeof(vfinfo[vf].vf_mac_addresses)); hw->mac.ops.rar_set(hw, new_mac, rar_entry); rah = E1000_READ_REG(hw, E1000_RAH(rar_entry)); rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf)); diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 5cafd6f1ce30..4a41a3cea5fc 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/igb_rxtx.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Mar 1 17:15:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137752 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BB6043C12; Fri, 1 Mar 2024 18:24:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18DEA434F2; Fri, 1 Mar 2024 18:18:39 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id AB4B743464 for ; Fri, 1 Mar 2024 18:18:06 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1dcce5e84bcso21119015ad.1 for ; Fri, 01 Mar 2024 09:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313486; x=1709918286; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JOANpzi1ifQoaA4VhE1b6CgmCmpwuT76cyLQX4CJIYs=; b=XfMAPm+KiAsaPteIppZF4yFuc0CNful3sotoS2SVITtuYBElm+JvU7BUqsBAxbYpGt IdFFUsWAEa5sXp1DLJ/RWBh8hrIVHzWfMxaHB0/vZcQCJzwwCz3KWdZ7Ar5ep/O2qNn8 OlMoxZ02M+hacV3k53tGycq9lejnblgUJCWcJeBSdHBC5ViEPAbrWe5JQSNyAZASEsqY XVBYNgk+aAVdEdLLe6zv+GUdYQF8xE5VBrD0x3KWGlU0/Va0Qn/eNgEXmJi4lHSNJ1r9 ltu99kT6/ciwAWtsgZiLmwRr68t8qQa9oroHp3+dLEpMMvWggCZ9x1Dnpkkz6cVaieFh KveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313486; x=1709918286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JOANpzi1ifQoaA4VhE1b6CgmCmpwuT76cyLQX4CJIYs=; b=jUWNUviZA/HhlEglDMJluxK9uNgSyHwnER34aD3rKthPGU0zQYNDMPPEAIga3N2T7W DJpeoBTVl0LKWjOtSSjXbv7RawB2mRLvUJPMiuouqgJHup1TOvAW8faryC+PZQOhQuJF JFFg9gp8nf9rCjNUvkDIAUpSecSP4DZGu6rrbzRn5vNyoCNXEVObFxA261tLm8IDL9sh ulZY1hpPatnVt4PTwN1awhIuS+uT1xPS/Q5HEFOLsZI/0r9OEvDQAY0t4eCU1NpcFlk6 nm9EgmmkcbSCUhrj6pTt8h7C+4cVKdedSmiIaKdygoQRw/T+KLVo/ciQbp0hZN1RN/66 t4Ow== X-Gm-Message-State: AOJu0Yx2UvbbCyUuF+BCzB+ltPcGU7/z0Jrt4of8C05XLqkOuY4hV9ks fmbN5HBT6a8UBExd2H3In90twJFBwDU/A+6KSPlRJT7d5IBrWmLmyhOP5GACJvUhgcMS98rCph4 1hvkwPA== X-Google-Smtp-Source: AGHT+IG6ROi5KbJjmXBHgTIwhfml//DxYjgT2iJO/JjYwxWCI2RbP8vp7oq2tJ5llQYS0U248I7TIQ== X-Received: by 2002:a17:902:d489:b0:1dc:d6ba:ed4c with SMTP id c9-20020a170902d48900b001dcd6baed4cmr2670138plg.2.1709313485940; Fri, 01 Mar 2024 09:18:05 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , John Daley , Hyong Youb Kim Subject: [PATCH v2 62/71] net/enic: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:58 -0800 Message-ID: <20240301171707.95242-63-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index a6aaa760ca91..a940c160c9f1 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1221,8 +1221,8 @@ static int enic_set_rsskey(struct enic *enic, uint8_t *user_key) /* Save for later queries */ if (!err) { - rte_memcpy(&enic->rss_key, rss_key_buf_va, - sizeof(union vnic_rss_key)); + memcpy(&enic->rss_key, rss_key_buf_va, + sizeof(union vnic_rss_key)); } enic_free_consistent(enic, sizeof(union vnic_rss_key), rss_key_buf_va, rss_key_buf_pa); @@ -1243,7 +1243,7 @@ int enic_set_rss_reta(struct enic *enic, union vnic_rss_cpu *rss_cpu) if (!rss_cpu_buf_va) return -ENOMEM; - rte_memcpy(rss_cpu_buf_va, rss_cpu, sizeof(union vnic_rss_cpu)); + memcpy(rss_cpu_buf_va, rss_cpu, sizeof(union vnic_rss_cpu)); err = enic_set_rss_cpu(enic, rss_cpu_buf_pa, @@ -1254,7 +1254,7 @@ int enic_set_rss_reta(struct enic *enic, union vnic_rss_cpu *rss_cpu) /* Save for later queries */ if (!err) - rte_memcpy(&enic->rss_cpu, rss_cpu, sizeof(union vnic_rss_cpu)); + memcpy(&enic->rss_cpu, rss_cpu, sizeof(union vnic_rss_cpu)); return err; } From patchwork Fri Mar 1 17:15:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137753 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB1243C12; Fri, 1 Mar 2024 18:24:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37579434EA; Fri, 1 Mar 2024 18:18:40 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 6A02F4346A for ; Fri, 1 Mar 2024 18:18:07 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dc1ff697f9so21579185ad.0 for ; Fri, 01 Mar 2024 09:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313486; x=1709918286; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w4ZGJeq99gzn4mnFJnxYqd9ykfHfsHLb6rRl7FjUkUs=; b=MuCcOU4gpnaB+nbLedElYQmeXHa4qksxgfn4z1uBVmZniQUp7E5XRGwU7U7Bf4qxr0 6+0xxkkYB+mf44NvRlZFQHp5BuhUSRR5GFMAMP2/MfDVApdKho4GCoz3agPF0slNMQ29 xCLcxRH1efGRrq9CWTYq1Oy3n/BoLN78Tur/hF5ScrQK/OZfe0OqpsIADRmlPy2sSSPf raVOT1tFRpedQIGlDAYkkJAmK4nj+lHQmWd+cHAZGwQLHDwX66gh3/vB/uwuBSyYiMmE cEj9jVQLmfULXMkJtLn9rNOS1vdR6Rqnd6goNFVm/SxArCAiRcYJoZCkAoXq7kdh+L/P Dgtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313486; x=1709918286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w4ZGJeq99gzn4mnFJnxYqd9ykfHfsHLb6rRl7FjUkUs=; b=T5jiG6+L1QtCPrXcvXfffhaLx2TEJmMBV91kULYvbE+1xE40YGl7euthjBJ8aJA9x6 veJesLX9yroi8n0JXXPxeVyLDfGHMyNbzncS8Z/qNqnbOVbWndZ5RWJ7XCI8FIgTxmqZ OyuAkOjf3UDB5JH1xVZo05mbmanLv3R+oUkGXM3xc/O4GECn7FwJjIxULvHTRSOlP3uY q0lwGRrO1vqo2AL9dxhVJ8T1XmyLhMis5OqcHNQ6qLh0OTQB72CdP26bsUgT9ystgdXr 2RnAePM1Tcvkm7LB+YQ+hTreATIDO6EIwh8DKAK7dSN4Jysv8w+WUBNztAYRlNEJ5epI 332Q== X-Gm-Message-State: AOJu0Ywkezhf9Ej+yJSGKbMeaVKjFmp939BmSzPxFKWSsNvEpVRcyeoS MK6fDIamshd98yR3wEHL2VueAAVig/dUGwxn9lVnJsddUtN1i+hbwmgNnUrMdyop1TEv7VrwkyT ZwkTFaQ== X-Google-Smtp-Source: AGHT+IHi5y3meCw671XjVbL0wtfTtaKFm7PWh2qPkfv1wZUr6IXGOwoJcHLsk2gW9N+tWjbV2cD9mg== X-Received: by 2002:a17:902:f54a:b0:1dc:af71:29fc with SMTP id h10-20020a170902f54a00b001dcaf7129fcmr2891732plf.6.1709313486675; Fri, 01 Mar 2024 09:18:06 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gaetan Rivet Subject: [PATCH v2 63/71] net/failsafe: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:15:59 -0800 Message-ID: <20240301171707.95242-64-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 9c013e04195c..47d453ef8028 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -902,16 +902,16 @@ fs_stats_get(struct rte_eth_dev *dev, ret = fs_lock(dev, 0); if (ret != 0) return ret; - rte_memcpy(stats, &PRIV(dev)->stats_accumulator, sizeof(*stats)); + memcpy(stats, &PRIV(dev)->stats_accumulator, sizeof(*stats)); FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) { struct rte_eth_stats *snapshot = &sdev->stats_snapshot.stats; uint64_t *timestamp = &sdev->stats_snapshot.timestamp; - rte_memcpy(&backup, snapshot, sizeof(backup)); + memcpy(&backup, snapshot, sizeof(backup)); ret = rte_eth_stats_get(PORT_ID(sdev), snapshot); if (ret) { if (!fs_err(sdev, ret)) { - rte_memcpy(snapshot, &backup, sizeof(backup)); + memcpy(snapshot, &backup, sizeof(backup)); goto inc; } ERROR("Operation rte_eth_stats_get failed for sub_device %d with error %d", From patchwork Fri Mar 1 17:16:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137754 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD8DE43C12; Fri, 1 Mar 2024 18:24:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68E6D434F8; Fri, 1 Mar 2024 18:18:41 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 3967043348 for ; Fri, 1 Mar 2024 18:18:08 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dcafff3c50so19855205ad.0 for ; Fri, 01 Mar 2024 09:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313487; x=1709918287; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hKqEFCNTObx0gRK9+izVTkCMNLSW9gW0LxjHqhk3RFg=; b=sPLE0WNFiig1sksstohDb08LyRe9VRJGzxADvK//iP/mRZMaTk/Azth6pb+EM6kocf esGJbkJoBcxS7j02fKVyvV/KKYzaXTpD8YktRgkDtBErnaS7eu3j/nLAX/V5iZ8rqDAE 4tswNMEy4SAALRqd+haUNO1t0afbsWpz4N1YaGLrQg5A1LPyvgiakXhPrCXIXuMqn7dv br3SeyZ/jae2DXCQ1aOlDHvVZJKh7bfi36pCGb/Uni8EL4FuYt5NywhA4tcbAdltLykU qgAXg3uA+da1jqiZmGnSWDc0vauPjoENWNa434fjN8/ewYHqwpLDRNvdfO90pewJaGEj +HOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313487; x=1709918287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hKqEFCNTObx0gRK9+izVTkCMNLSW9gW0LxjHqhk3RFg=; b=RYvYZZTFpSM7TFhLDnZyeMqDW5WuTnMAJ+s1fS7TFOUfcRP8MK91yjuJ7QducH2t3k rnWHmeSYnRRloW/Fm6Kp0u1FVun5u4FXszn8xsKVMlVuJly2QYl6VCtg/c0QDLswaOVE k1SXtJsr+PNyuRxGz7tPsqM60htejvAnKeX5Hmxm7uyFxv5CLcWIFsdjAweTo5/Uiz51 Gbzcx6RlOMAhnjmfCtz9CljSVfPocgmSOPTE5kUp2jYUYQ6sPEQa5ovflhUOuRKbkEs1 /kkFdqAm3stBODRX+v5ly0BX5eHeHUln13ZDaSuKabLnQ183Rt9EJyMa/Zvggh0Udv52 DGmA== X-Gm-Message-State: AOJu0Ywse6r7HC5Y/Fxm11PtcdY6iOutdsHeWqSBig/tmvbCUJXXwI9x Hshr0GglVA3Rduz7T5l87SdMMhl2dzNfUzsWxRerbqdG2IF5M2s1VX6GsghH1/CINoO28neSQzh vrR0S+w== X-Google-Smtp-Source: AGHT+IEiUSyslNz/DbYKnTEcTARzQXmQO6kztCwRaqtGe9j8p1Fc+kaYrwTrTJnuRkHLQ8qkAnn/WA== X-Received: by 2002:a17:903:22cd:b0:1dc:8eba:42c3 with SMTP id y13-20020a17090322cd00b001dc8eba42c3mr2546287plg.23.1709313487484; Fri, 01 Mar 2024 09:18:07 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Junfeng Guo , Jeroen de Borst , Rushil Gupta , Joshua Washington Subject: [PATCH v2 64/71] net/gve/base: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:00 -0800 Message-ID: <20240301171707.95242-65-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/gve/base/gve_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c index 629d15cfbe77..24b00a1fbf5b 100644 --- a/drivers/net/gve/base/gve_adminq.c +++ b/drivers/net/gve/base/gve_adminq.c @@ -785,7 +785,7 @@ int gve_adminq_describe_device(struct gve_priv *priv) } priv->max_mtu = mtu; priv->num_event_counters = be16_to_cpu(descriptor->counters); - rte_memcpy(priv->dev_addr.addr_bytes, descriptor->mac, ETH_ALEN); + memcpy(priv->dev_addr.addr_bytes, descriptor->mac, ETH_ALEN); PMD_DRV_LOG(INFO, "MAC addr: " RTE_ETHER_ADDR_PRT_FMT, RTE_ETHER_ADDR_BYTES(&priv->dev_addr)); priv->tx_pages_per_qpl = be16_to_cpu(descriptor->tx_pages_per_qpl); From patchwork Fri Mar 1 17:16:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137755 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5800B43C12; Fri, 1 Mar 2024 18:24:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 935A3434FC; Fri, 1 Mar 2024 18:18:42 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 5B31F43476 for ; Fri, 1 Mar 2024 18:18:09 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d911c2103aso7700615ad.0 for ; Fri, 01 Mar 2024 09:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313488; x=1709918288; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=; b=svfAZBJuz8285lCjgPMRtOXwqcO7T+Qlyy7j3Q4sg6C9IWxP1zExdesFag/DecN7ez 7rjvoQik/S1Wc0/MXSLNqI+aCoP8Y8Ee/lOAxN13JJivrSVLSzNWzmpY5lEIk1CKT+bR iAu9TMZ/X4kOovb3tpuveVpvvYqbJ9HvgzgtqN9eRvOzqIC+PnPzAF2c4e8KM7YTe182 kswNUlPWO7/xO37hpkmKtKaQ26rrFB+J44shJrBA5SaVvveI7uqXJylK+ZCBa3uMn9sF 0/5pqBW2aXYDsydte/wwTPxm80OYs8AFDm1hS+DM+W96fxPAK6ONCrfD0TZJLPyTM5mh 5wDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313488; x=1709918288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=; b=bOMEFSiFHUjdp7FdrlaGQU436E8X26gunZ1P4xk6v8fcEaocJNmOuukB8oO7O4qYLS rCOItjgtR0zSWAkxMFcyLZnEoj6hsXsDUdA1xvzoQPa7Ua0s1wzE4QNTqCa4UgYEZsOp Z36yGY8iLGFKg2OAFx6XGw4ZHWsM8HZPsTKd+FVaMkORNbKQDju1BMHVwp1OHm00ZfGg 5XibzjYhHs/5xBp6yBYtveSuqVB0yTgsgDVOBZrnZrojP4OibSdk6XK8a/9B6GOnOSPW l6J+vSRSLhKP7l/wkuTZ9eT+pm7Egx/Rxa5TOrRK60cguS3/EZxMR43rQSNyIm+JhjyL TNpQ== X-Gm-Message-State: AOJu0YzbpzFimdR4K0/Oy9ROilIxOlMONk+qfSBhhqabQ1WDcIZu/Xma uPqNCc91VsprOcJS/n28vU7lzFNDEtkrxGTtq4tXMSRiSpYUn8LqWYgXMEX1JiiJj9kizw4OBDw 4FlbbEQ== X-Google-Smtp-Source: AGHT+IGb+llt/sscZ3DRNDkwwJKld1weTFtleB3di7RZiAOmaQmNCnoEWQMcR6GpInjV8tx3Mo0BRg== X-Received: by 2002:a17:902:7846:b0:1dc:db57:d6e2 with SMTP id e6-20020a170902784600b001dcdb57d6e2mr2223855pln.69.1709313488579; Fri, 01 Mar 2024 09:18:08 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Subject: [PATCH v2 65/71] net/hinic: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:01 -0800 Message-ID: <20240301171707.95242-66-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_flow.c | 40 ++++++++++++++---------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pmd_flow.c index d1a564a16303..cb61c989fd36 100644 --- a/drivers/net/hinic/hinic_pmd_flow.c +++ b/drivers/net/hinic/hinic_pmd_flow.c @@ -983,8 +983,7 @@ static int hinic_normal_item_check_ip(const struct rte_flow_item **in_out_item, } ipv6_spec = (const struct rte_flow_item_ipv6 *)item->spec; - rte_memcpy(rule->hinic_fdir.dst_ipv6, - ipv6_spec->hdr.dst_addr, 16); + memcpy(rule->hinic_fdir.dst_ipv6, ipv6_spec->hdr.dst_addr, 16); /* * Check if the next not void item is TCP or UDP or ICMP. @@ -2193,8 +2192,8 @@ static int hinic_add_del_ntuple_filter(struct rte_eth_dev *dev, sizeof(struct hinic_5tuple_filter), 0); if (filter == NULL) return -ENOMEM; - rte_memcpy(&filter->filter_info, &filter_5tuple, - sizeof(struct hinic_5tuple_filter_info)); + memcpy(&filter->filter_info, &filter_5tuple, + sizeof(struct hinic_5tuple_filter_info)); filter->queue = ntuple_filter->queue; filter_info->qid = ntuple_filter->queue; @@ -2912,8 +2911,7 @@ static int hinic_add_del_tcam_fdir_filter(struct rte_eth_dev *dev, sizeof(struct hinic_tcam_filter), 0); if (tcam_filter == NULL) return -ENOMEM; - (void)rte_memcpy(&tcam_filter->tcam_key, - &tcam_key, sizeof(struct tag_tcam_key)); + memcpy(&tcam_filter->tcam_key, &tcam_key, sizeof(struct tag_tcam_key)); tcam_filter->queue = fdir_tcam_rule.data.qid; ret = hinic_add_tcam_filter(dev, tcam_filter, &fdir_tcam_rule); @@ -2990,9 +2988,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, &ntuple_filter, FALSE); goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&nic_dev->filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -3022,9 +3020,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, ðertype_filter, FALSE); goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&nic_dev->filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -3065,8 +3063,8 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&fdir_rule_ptr->filter_info, &fdir_rule, - sizeof(struct hinic_fdir_rule)); + memcpy(&fdir_rule_ptr->filter_info, &fdir_rule, + sizeof(struct hinic_fdir_rule)); TAILQ_INSERT_TAIL(&nic_dev->filter_fdir_rule_list, fdir_rule_ptr, entries); flow->rule = fdir_rule_ptr; @@ -3109,8 +3107,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, case RTE_ETH_FILTER_NTUPLE: ntuple_filter_ptr = (struct hinic_ntuple_filter_ele *) pmd_flow->rule; - rte_memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info, + sizeof(struct rte_eth_ntuple_filter)); ret = hinic_add_del_ntuple_filter(dev, &ntuple_filter, FALSE); if (!ret) { TAILQ_REMOVE(&nic_dev->filter_ntuple_list, @@ -3121,9 +3119,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, case RTE_ETH_FILTER_ETHERTYPE: ethertype_filter_ptr = (struct hinic_ethertype_filter_ele *) pmd_flow->rule; - rte_memcpy(ðertype_filter, - ðertype_filter_ptr->filter_info, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter, ðertype_filter_ptr->filter_info, + sizeof(struct rte_eth_ethertype_filter)); ret = hinic_add_del_ethertype_filter(dev, ðertype_filter, FALSE); if (!ret) { @@ -3134,9 +3131,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, break; case RTE_ETH_FILTER_FDIR: fdir_rule_ptr = (struct hinic_fdir_rule_ele *)pmd_flow->rule; - rte_memcpy(&fdir_rule, - &fdir_rule_ptr->filter_info, - sizeof(struct hinic_fdir_rule)); + memcpy(&fdir_rule, &fdir_rule_ptr->filter_info, + sizeof(struct hinic_fdir_rule)); if (fdir_rule.mode == HINIC_FDIR_MODE_NORMAL) { ret = hinic_add_del_fdir_filter(dev, &fdir_rule, FALSE); } else if (fdir_rule.mode == HINIC_FDIR_MODE_TCAM) { From patchwork Fri Mar 1 17:16:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137756 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A6243C12; Fri, 1 Mar 2024 18:24:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41ADC43508; Fri, 1 Mar 2024 18:18:44 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 1D4864347A for ; Fri, 1 Mar 2024 18:18:10 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dcab44747bso21669455ad.1 for ; Fri, 01 Mar 2024 09:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313489; x=1709918289; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GHdnJw6wwF7B7iZ/PeJHD1EkHIyhK1xX2lT3kawF+kI=; b=C8oZvBKRUSCfN44wtRbMgvl8yMTUJo9niOEvtesJcLRU27DO+DyTE5MyyEAhy2e8R8 x5GRb+099nt1SJWWg0LoBhwcQErdBpy1Bf02Y4H69zOfFzgEsxAEE8b80zvWutfyzeXS yFuHnQeyVyUcQA46DTSwSWoE0kH6uynPQkZGqJ6Sz9WPgr1MaMx6ALjpnyYpsPsJsOJD 1gz0esWJx9dUiaDYhQ2tjpJzojRkUpDUlPvMQntq9b8sRrEF9G0sU337aU9/uMfzI6Ff dHq0hPgn/f/HkFy4bafJ5ovkTmGFUu+Umz0zuDbX6BvVrpjKvzTZH/7c7hlNRzpANy1a cimQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313489; x=1709918289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHdnJw6wwF7B7iZ/PeJHD1EkHIyhK1xX2lT3kawF+kI=; b=p+Jf3gBTM/fF8LmqtIOBwruS3+tCWcOvni5wLlMrzaKjPyobxH0+N37mKKGVfYCwCy ZOnwdXYlnUQ7JvahlIP6P2ocQxn0fQfhan57zhcKFKYKfCULgHOkoQgHAG/1mmZCzQVn mmssxY7rJGnkWx+i1L4KsrSj527QDPgnXY0CwEjYMSVcSpaSSWlCjsfiBm+8kphRlr+2 cjE7AU0BmaMBhUV0f+kDllor+Blyk+N/s2oISXzOk4nHibwm6jfiK4I6zsSsH0ZwkC+1 v97alViee1luOyBMjdOYzbc3ZLF0GaVkRE3iz2Thisr8fh2GwEgFXNmfmrkNt13TnteG 6rMw== X-Gm-Message-State: AOJu0YyGAyNPP8cu79YmBKsZ6BlKbvwZDcPv6Dro6KV1wldxKXvAbUKJ D7I9cVYZ78ZmKhOt3JFfL3l3L3ciHzrW/9wtWW7IAMgFq/1pNoWhqgSOqukoHFM6+Eq8ddbV5HW OTbOUFw== X-Google-Smtp-Source: AGHT+IGf0eE3f2fi90CdfdGy6dZpigVMuNTaMp6o7FkpCoHu0/7y3hunAc66sCX5Zhl5ibz8Zqyy/g== X-Received: by 2002:a17:903:1c2:b0:1db:fd4e:329f with SMTP id e2-20020a17090301c200b001dbfd4e329fmr2327155plh.15.1709313489335; Fri, 01 Mar 2024 09:18:09 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH v2 66/71] net/mvpp2: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:02 -0800 Message-ID: <20240301171707.95242-67-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_tm.c b/drivers/net/mvpp2/mrvl_tm.c index 9fac80b867be..a5cdae6d1d0d 100644 --- a/drivers/net/mvpp2/mrvl_tm.c +++ b/drivers/net/mvpp2/mrvl_tm.c @@ -437,7 +437,7 @@ mrvl_shaper_profile_add(struct rte_eth_dev *dev, uint32_t shaper_profile_id, NULL, NULL); profile->id = shaper_profile_id; - rte_memcpy(&profile->params, params, sizeof(profile->params)); + memcpy(&profile->params, params, sizeof(profile->params)); LIST_INSERT_HEAD(&priv->shaper_profiles, profile, next); From patchwork Fri Mar 1 17:16:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137757 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 666C543C12; Fri, 1 Mar 2024 18:25:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C2F64350C; Fri, 1 Mar 2024 18:18:45 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id E3C3843430 for ; Fri, 1 Mar 2024 18:18:10 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1dc13fb0133so19565605ad.3 for ; Fri, 01 Mar 2024 09:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313490; x=1709918290; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8+n3mj46ryQjCPn38wDLyoZeHUgb67I8oYwRJBQtHB4=; b=v0TarOTVkn6oT2X3qPzZV30IFjH9tA4IDQ7zk0UJF/aLa+Qw8js9i+B3i+e/sj1NfF 6WYtF64YfTVeR7X6TFaOsOrdqujEQdYulM1ExsCCURMq5+uYZu2wrZ1zZMCkwvL1HkkK xs2aayQYs/Mg+UQBfqWYvZnCHoohojqft7FFVBYndZX1UJphBYmFNJXCrLmEAaz6w8dX N0TDa6w2C/YhFPIdPvC8sMf0TE8NX/syeOJaQXMy4mi/5543zoDMJK15n9SNJDKa7X6r XiTINhXCCTWs1waMlLZBXFWt6CTYHjFxpsuTxpxHJyZKbskQvzvzRPbC5puaWWG4erro ugeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313490; x=1709918290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+n3mj46ryQjCPn38wDLyoZeHUgb67I8oYwRJBQtHB4=; b=Y9qljpakegTZt3w8FrUOiCxWOfKeB4le/fsxOzqjr0XexS0JLYRm4GpaFOtDD6hED7 h2WDeYT2NaW5/uaivpfn+cPlkt0Dqn6y4Fe6GzDS57eREjlNS9Y00Bz6Fzk+0UAu9K1d hZy9HXjVbmat1MCM2v6yI9fddUhhQ4o7qP0bT8rv6NmLKffAYfNykzBrJeyp0bL0mxyB AtzYJepySbVvJn9np+2hdN0UBqH4GWD/AVMtc1EwVeFoSa53QZQetoaikQ4SeSnl0RRm 8c2vU1nlgNel2lsEZfV1rl5NoETTeAY7BegLasqgA9ahJnf/3CDwOuhDrzZuptfYo+nW l3rg== X-Gm-Message-State: AOJu0YzwO7LvR07BLxJqeoy/NxcvjwqWjQtH5ntICvLNMuuT/tRWzdg9 Sjq6M2cZYzkYWSGfFj7lkXTkKCjaEvLl+8rnJZCjqLAsresmNjSX5n/7FGwpBhrQZcLArQuhiVg J/k2mrg== X-Google-Smtp-Source: AGHT+IHgosILrMTuY6f9nKFgF5xaf6E5sIBmpyPvAiDFY7HbcncmWTq4LH/glGJuoQvQqcLLFAfsEA== X-Received: by 2002:a17:902:d344:b0:1db:cfa0:4045 with SMTP id l4-20020a170902d34400b001dbcfa04045mr1970774plk.60.1709313490166; Fri, 01 Mar 2024 09:18:10 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aman Singh , Yuying Zhang , Ori Kam Subject: [PATCH v2 67/71] app/test-pmd: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:03 -0800 Message-ID: <20240301171707.95242-68-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 48 ++++++++++++++++++------------------- app/test-pmd/cmdline_flow.c | 24 +++++++++---------- app/test-pmd/config.c | 8 +++---- app/test-pmd/csumonly.c | 1 - app/test-pmd/flowgen.c | 1 - app/test-pmd/iofwd.c | 1 - app/test-pmd/macfwd.c | 1 - app/test-pmd/macswap.c | 1 - app/test-pmd/noisy_vnf.c | 1 - app/test-pmd/rxonly.c | 1 - app/test-pmd/testpmd.c | 1 - 11 files changed, 40 insertions(+), 48 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 566057caa523..898fb69a2f4d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -9529,7 +9529,7 @@ static void cmd_set_vxlan_parsed(void *parsed_result, vxlan_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(vxlan_encap_conf.vni, &id.vni[1], 3); + memcpy(vxlan_encap_conf.vni, &id.vni[1], 3); vxlan_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src); vxlan_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst); vxlan_encap_conf.ip_tos = res->tos; @@ -9543,10 +9543,10 @@ static void cmd_set_vxlan_parsed(void *parsed_result, } if (vxlan_encap_conf.select_vlan) vxlan_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_vxlan = { @@ -9724,7 +9724,7 @@ static void cmd_set_nvgre_parsed(void *parsed_result, nvgre_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(nvgre_encap_conf.tni, &id.tni[1], 3); + memcpy(nvgre_encap_conf.tni, &id.tni[1], 3); if (nvgre_encap_conf.select_ipv4) { IPV4_ADDR_TO_UINT(res->ip_src, nvgre_encap_conf.ipv4_src); IPV4_ADDR_TO_UINT(res->ip_dst, nvgre_encap_conf.ipv4_dst); @@ -9734,10 +9734,10 @@ static void cmd_set_nvgre_parsed(void *parsed_result, } if (nvgre_encap_conf.select_vlan) nvgre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_nvgre = { @@ -9851,10 +9851,10 @@ static void cmd_set_l2_encap_parsed(void *parsed_result, return; if (l2_encap_conf.select_vlan) l2_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_l2_encap = { @@ -10033,7 +10033,7 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result, mplsogre_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(mplsogre_encap_conf.label, &id.label, 3); + memcpy(mplsogre_encap_conf.label, &id.label, 3); if (mplsogre_encap_conf.select_ipv4) { IPV4_ADDR_TO_UINT(res->ip_src, mplsogre_encap_conf.ipv4_src); IPV4_ADDR_TO_UINT(res->ip_dst, mplsogre_encap_conf.ipv4_dst); @@ -10043,10 +10043,10 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result, } if (mplsogre_encap_conf.select_vlan) mplsogre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_mplsogre_encap = { @@ -10269,7 +10269,7 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result, mplsoudp_encap_conf.select_ipv4 = 0; else return; - rte_memcpy(mplsoudp_encap_conf.label, &id.label, 3); + memcpy(mplsoudp_encap_conf.label, &id.label, 3); mplsoudp_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src); mplsoudp_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst); if (mplsoudp_encap_conf.select_ipv4) { @@ -10281,10 +10281,10 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result, } if (mplsoudp_encap_conf.select_vlan) mplsoudp_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci); - rte_memcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes, - RTE_ETHER_ADDR_LEN); - rte_memcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes, - RTE_ETHER_ADDR_LEN); + memcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes, + RTE_ETHER_ADDR_LEN); + memcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes, + RTE_ETHER_ADDR_LEN); } static cmdline_parse_inst_t cmd_set_mplsoudp_encap = { diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index b4389e51506b..17b73d2407c4 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -13732,7 +13732,7 @@ cmd_set_raw_parsed_sample(const struct buffer *in) fprintf(stderr, "Error - Not supported action\n"); return; } - rte_memcpy(data, action, sizeof(struct rte_flow_action)); + memcpy(data, action, sizeof(struct rte_flow_action)); data++; } } @@ -13893,8 +13893,8 @@ cmd_set_raw_parsed(const struct buffer *in) /* We have to add GTP header extra word. */ *total_size += sizeof(ext_word); - rte_memcpy(data_tail - (*total_size), - &ext_word, sizeof(ext_word)); + memcpy(data_tail - (*total_size), &ext_word, + sizeof(ext_word)); } size = sizeof(struct rte_gtp_hdr); break; @@ -13939,21 +13939,21 @@ cmd_set_raw_parsed(const struct buffer *in) if (opt->checksum_rsvd.checksum) { *total_size += sizeof(opt->checksum_rsvd); - rte_memcpy(data_tail - (*total_size), - &opt->checksum_rsvd, - sizeof(opt->checksum_rsvd)); + memcpy(data_tail - (*total_size), + &opt->checksum_rsvd, + sizeof(opt->checksum_rsvd)); } if (opt->key.key) { *total_size += sizeof(opt->key.key); - rte_memcpy(data_tail - (*total_size), - &opt->key.key, - sizeof(opt->key.key)); + memcpy(data_tail - (*total_size), + &opt->key.key, + sizeof(opt->key.key)); } if (opt->sequence.sequence) { *total_size += sizeof(opt->sequence.sequence); - rte_memcpy(data_tail - (*total_size), - &opt->sequence.sequence, - sizeof(opt->sequence.sequence)); + memcpy(data_tail - (*total_size), + &opt->sequence.sequence, + sizeof(opt->sequence.sequence)); } } proto = 0x2F; diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 08d7d0e2f87c..2b81f3ef3d2d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2639,8 +2639,8 @@ port_flow_template_table_create(portid_t port_id, uint32_t id, } pt->nb_pattern_templates = nb_pattern_templates; pt->nb_actions_templates = nb_actions_templates; - rte_memcpy(&pt->flow_attr, &table_attr->flow_attr, - sizeof(struct rte_flow_attr)); + memcpy(&pt->flow_attr, &table_attr->flow_attr, + sizeof(struct rte_flow_attr)); printf("Template table #%u created\n", pt->id); return 0; } @@ -3261,8 +3261,8 @@ port_queue_action_handle_update(portid_t port_id, update = action->conf; break; case RTE_FLOW_ACTION_TYPE_METER_MARK: - rte_memcpy(&mtr_update.meter_mark, action->conf, - sizeof(struct rte_flow_action_meter_mark)); + memcpy(&mtr_update.meter_mark, action->conf, + sizeof(struct rte_flow_action_meter_mark)); if (mtr_update.meter_mark.profile) mtr_update.profile_valid = 1; if (mtr_update.meter_mark.policy) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index d73f08b2c6c2..b94ddc3526af 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c index 53b5f24f11e7..d9454a4d22e1 100644 --- a/app/test-pmd/flowgen.c +++ b/app/test-pmd/flowgen.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/iofwd.c b/app/test-pmd/iofwd.c index ba06fae4a6b0..c9727d285622 100644 --- a/app/test-pmd/iofwd.c +++ b/app/test-pmd/iofwd.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/macfwd.c b/app/test-pmd/macfwd.c index d19ace739557..ba63aedd797d 100644 --- a/app/test-pmd/macfwd.c +++ b/app/test-pmd/macfwd.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c index 57f77003fe44..e1f9be490157 100644 --- a/app/test-pmd/macswap.c +++ b/app/test-pmd/macswap.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c index 81d1187cfe9e..cf951e953251 100644 --- a/app/test-pmd/noisy_vnf.c +++ b/app/test-pmd/noisy_vnf.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c index 315f9286cdbe..cc73cf4ebf44 100644 --- a/app/test-pmd/rxonly.c +++ b/app/test-pmd/rxonly.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9e4e99e53b9a..6a2339a24145 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Mar 1 17:16:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137758 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C5D943C12; Fri, 1 Mar 2024 18:25:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B57E143503; Fri, 1 Mar 2024 18:18:46 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id AC0BE43482 for ; Fri, 1 Mar 2024 18:18:11 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dc1ff58fe4so20484515ad.1 for ; Fri, 01 Mar 2024 09:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313491; x=1709918291; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CEfszso0YsVDHyLSbXcdrEEUdq5SMGrX+9HGQAEv90o=; b=22Ta1bAJG5ItgG3Bho9Y0K3r980sZu5CwuLmlch0DXZyZOdfS7GaNyPQjZsSpe39Uc rmBlxf3gBKisCWh9IyKq25SB2ENFs+JU/fVurEpuwwro8gw/TE//5ae4lDBB9tF18GJt xK6IU0Y+PBL7LRJfuujHgh94hVJhGiVsQ3vzpuq9YWBlz4vi6R93ta3hMBFhtFBUk+7I 8nUKrv8Zx3ib8UXChMpkzWk5b6xtAL1impDYBNUqY+BUNseKSSmLSTNClkAqqLVTUFiK clm+y+72BSqPCkk596CJb+/F11BgG0HYdtiHDfkmZmFiX7DxCwxwKIWiMT8ddg+8fnGu 6UTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313491; x=1709918291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CEfszso0YsVDHyLSbXcdrEEUdq5SMGrX+9HGQAEv90o=; b=i9UoGLGkTr95V5vFf7Nu97LPbZeknIMGSq8ijKopScikifmWK4736zArJSXsxbF45l jSkFnKVXBY1xZW7ozjSnInMAB98Hf1M5nBx8Kok5IFjvyFFVKlppHxzN3XJQtYOSEaIb J3HzYq1WDQRvjNpHy5n+r1TdbkFEWQJ7B6Ov+427JNN9wDPjGicspGAqoRStE1fZh/fe k4s7EvNfjZfTInn7Rb3mvsIDLgVRZRXCjKCtOwG7GXpPkPGjHHnMMBvoeHkjBL80uucH 1WrqHVKcykUDJxMEr4MvHlGKMNq/XXAAuHNmOwqvBTHgLDQwSViTfGSDV0FIS78cNk2a zOeQ== X-Gm-Message-State: AOJu0Yx3nAVMJ4PQPN0eiYjmd/Ec78dOvv9BI4iqcxLb9rdoQ+tEmQF4 knZTi7Olt3A6i5bm/D6LcfWZKwTw6L8NWgxNXsyKHDjSLVFwx/zWR70wB0NLaurmPgd08HLa4xY 0OGXs1g== X-Google-Smtp-Source: AGHT+IGjiv18iqayrWUrkLKTa8JQXrPJh26BqTkwDubX0ltCO6WB7yb40jsUOtH+HHkOVVEkpG8Cdw== X-Received: by 2002:a17:902:c105:b0:1dc:1878:84e2 with SMTP id 5-20020a170902c10500b001dc187884e2mr2085671pli.54.1709313490989; Fri, 01 Mar 2024 09:18:10 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Kumar Kori , Rakesh Kudurumalla Subject: [PATCH v2 68/71] app/graph: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:04 -0800 Message-ID: <20240301171707.95242-69-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/graph/neigh.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/graph/neigh.c b/app/graph/neigh.c index 22be7361e310..a99d2b6981a2 100644 --- a/app/graph/neigh.c +++ b/app/graph/neigh.c @@ -91,14 +91,14 @@ ip6_rewrite_node_add(struct neigh_ipv6_config *v6_config) memset(data, 0, len); /* Copy dst mac */ - rte_memcpy((void *)&data[0], (void *)&v6_config->mac, RTE_ETHER_ADDR_LEN); + memcpy((void *)&data[0], (void *)&v6_config->mac, RTE_ETHER_ADDR_LEN); /* Copy src mac */ rc = rte_eth_macaddr_get(portid, &smac); if (rc < 0) return rc; - rte_memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); return rte_node_ip6_rewrite_add(portid, data, len, portid); } @@ -121,7 +121,7 @@ ip4_rewrite_node_add(struct neigh_ipv4_config *v4_config) memset(data, 0, len); /* Copy dst mac */ - rte_memcpy((void *)&data[0], (void *)&v4_config->mac, RTE_ETHER_ADDR_LEN); + memcpy((void *)&data[0], (void *)&v4_config->mac, RTE_ETHER_ADDR_LEN); /* Copy src mac */ rc = rte_eth_macaddr_get(portid, &smac); @@ -130,7 +130,7 @@ ip4_rewrite_node_add(struct neigh_ipv4_config *v4_config) return rc; } - rte_memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); + memcpy(&data[RTE_ETHER_ADDR_LEN], smac.addr_bytes, RTE_ETHER_ADDR_LEN); return rte_node_ip4_rewrite_add(portid, data, len, portid); } From patchwork Fri Mar 1 17:16:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137759 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0CEA43C12; Fri, 1 Mar 2024 18:25:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00DEE43512; Fri, 1 Mar 2024 18:18:48 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 9BD73402C0 for ; Fri, 1 Mar 2024 18:18:12 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dcad814986so20735855ad.0 for ; Fri, 01 Mar 2024 09:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313492; x=1709918292; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rO7SIIkiWVQ2S4NTSuaHfv9iQv4J+F5xqVXp01dtZ2g=; b=nBuSA082e9kb0SvwebS56+H5Flf6DKvFyDSuuBL+6SZqzr7cBpdX+69awiTZXnjzF8 UlEqO+5Fp/qNBj7RNhczjLHbu8z7/k/Jgx+sBWphlur7arQs90ZhiBcF6+bu+up4flAb N/wi3L4iKyu7jUUyEWoDvjIObuN7cFs2iGzjv7ecTL2KSAS7+d5ghWtBV5wIaNRhlH+h u8ATbPaFAry4n4qSCXUA+bJSc5NSjuM/ainulQ6E2JqyW4zX2po8bpqnunOnn4SpB2XD /9EoBJVZQ5vasMcVv8E4BpUtQJDKaNyPfc0jFpuEFv+6VPmSlCjlQl9WHZQ1Dia1VIx8 ES1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313492; x=1709918292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rO7SIIkiWVQ2S4NTSuaHfv9iQv4J+F5xqVXp01dtZ2g=; b=Bdy0wIJgKwGm9yf/lgt173X6UeLrFiYGO+0OgbSVSKy+uWKT5DDkDCT1pZSuTUO+fb E70+47iYzvHY6Vbto7rw6VfC3ritZ0Ttmg0vjuD8tafka+o+BAe8QIyOJS+MQeaGW8cY ly0bKPM9RJHjVI3o9FGRDMDAIRLBSeTR3WmvPtCd/gSd7LLH66YwBKT7N7xI4Hnr7A5W FkqHWvvsjo3uNTFfHuNpuOCnWoLlV/TEsD71DJopf/gFIOIydsNgvJGpOcOXqCw7hUJ9 NiVHlaPYxK+UeiyAgpbHnButPjsSwUlyJcma5dnCcrOID266kROGYWm5+c5wsfjNsYb4 l0EA== X-Gm-Message-State: AOJu0YwDNi4x/xAEzFzTx0WCM1i/vpVnbqfzsk7PEfERYRi2/f43ecs7 HxIlJS+GjsZcvfNL0dRoQ2B+Hw5AhYddxscKBcimhoMPnqQ6kzK4I4yJrLHVf3WfIh0w9RMq1+I tk6tcYQ== X-Google-Smtp-Source: AGHT+IELA3cce9uCGdwsRzynXkffMWWtXBI/+H19P6BImpm31zXU2dSFtz5nU6mGY+FAdeVq+eTBVg== X-Received: by 2002:a17:902:e951:b0:1dc:af71:fed9 with SMTP id b17-20020a170902e95100b001dcaf71fed9mr2858609pll.11.1709313491765; Fri, 01 Mar 2024 09:18:11 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob Subject: [PATCH v2 69/71] app/test-eventdev: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:05 -0800 Message-ID: <20240301171707.95242-70-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-eventdev/test_pipeline_common.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index b111690b7cd4..49bfd0c363f5 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -177,22 +177,17 @@ pipeline_tx_first(struct test_pipeline *t, struct evt_options *opt) mbuf->pkt_len = pkt_sz; /* Copy Ethernet header */ - rte_memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, 0), - ð_hdr, sizeof(struct rte_ether_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, 0), + ð_hdr, sizeof(struct rte_ether_hdr)); /* Copy Ipv4 header */ - rte_memcpy(rte_pktmbuf_mtod_offset( - mbuf, char *, - sizeof(struct rte_ether_hdr)), - &ip_hdr, sizeof(struct rte_ipv4_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, sizeof(struct rte_ether_hdr)), + &ip_hdr, sizeof(struct rte_ipv4_hdr)); /* Copy UDP header */ - rte_memcpy( - rte_pktmbuf_mtod_offset( - mbuf, char *, - sizeof(struct rte_ipv4_hdr) + - sizeof(struct rte_ether_hdr)), - &udp_hdr, sizeof(struct rte_udp_hdr)); + memcpy(rte_pktmbuf_mtod_offset(mbuf, char *, sizeof(struct rte_ipv4_hdr) + + sizeof(struct rte_ether_hdr)), + &udp_hdr, sizeof(struct rte_udp_hdr)); pkt_udp_hdr = rte_pktmbuf_mtod_offset( mbuf, struct rte_udp_hdr *, sizeof(struct rte_ipv4_hdr) + From patchwork Fri Mar 1 17:16:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137760 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D200943C12; Fri, 1 Mar 2024 18:25:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36D3B43516; Fri, 1 Mar 2024 18:18:49 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 1D7E343487 for ; Fri, 1 Mar 2024 18:18:14 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dc1ff3ba1aso19959045ad.3 for ; Fri, 01 Mar 2024 09:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313493; x=1709918293; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jS36aQlQ0xHVW/eOEn3vvIA9Ejw7hQSGnpyTmOJep+s=; b=dZFvrsU2O1oFpPYY2OYfIaSM3qX0shph8gSwjB0QPmybqRQ7wH/KEbhvsfAmYBFHEw hx2KhLQ9+Bd3N2srhUMvcCm+x8G2Lehrpq9srDHCeYzlwsUTSdQJlxvkyhHyXRR7KKRT F1ii9yMboBQMF/l8sRSEr08kFcju0hSvNzD4zpeRBPmfhtDAPsR8DX57VrV7o5Y3vwUz e9EbgDHhFoNuw0ulGl/W1lBWcqxRMwtDWeTYEjvg3VBEkmRUBKmagWxii/BPEdE0+CRN u7y/DtzWMCR6tMMAcM7SnhMNgb5SAjShtPmx+hnvn3wy9x5ma1OujCcvDIJ9eudOFgEm mhmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313493; x=1709918293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jS36aQlQ0xHVW/eOEn3vvIA9Ejw7hQSGnpyTmOJep+s=; b=sPQGVv5vGzA6MC8ZACxv7JVhi9459qrl6ZQ7qG02XoCFzZjdIbB0plA+4Zp3MYyWr1 fDNdZiXqxuDJ0NMpiGAhWMSWX0CmqUR2emLiSBAfCrHIF1Nrxju6dbvfkx5McqQPcaSM iF2j8U8g006zcr1iUoxpBr+v+oFxFM4Ldot9PaaKzJK7wP4oxhhaFKBNvKqXILj6xGUX tIvzpsMviT1mjiIpcomKnMgIjYYOKBKeIzatt+2UgS0bx7pyfGe2RK2GEGvbsSfitndq 7hUjuK7o5f1jOUtF+Ke2Z4/5xIT/RIzCJuYQz8qh33ku/KlvCG04zYblvBxqhxNva4BP P1Gw== X-Gm-Message-State: AOJu0YwqmLFJl8YNii+uFWi7+CUlMKIAAR9MQ+bN34dVfK76J5xfoGHF S5BWAq/HQQrGi3YhvYLMctROpx8zcKQeaNy2qbfoQcY+IBFHeQPChNT+Hufbd9kSDxrK1q/LQrn pTKx8xQ== X-Google-Smtp-Source: AGHT+IH/XA5nNPt1wNOzknCe3/ZfLRGuJTp/DEGwFDa/c8XnccGFOTkHJBQvTdMXkkzbiJTgedAv5w== X-Received: by 2002:a17:902:da85:b0:1dc:e58:8ab4 with SMTP id j5-20020a170902da8500b001dc0e588ab4mr2858209plx.9.1709313493285; Fri, 01 Mar 2024 09:18:13 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jasvinder Singh , Akhil Goyal , Fan Zhang , Byron Marohn , Yipeng Wang , Abhinandan Gujjar , Amit Prakash Shukla , Jerin Jacob , Konstantin Ananyev , Vladimir Medvedkin , Chas Williams , "Min Hu (Connor)" , Sameh Gobriel , Sachin Saxena , Hemant Agrawal , Anoob Joseph , Harry van Haaren Subject: [PATCH v2 70/71] app/test: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:06 -0800 Message-ID: <20240301171707.95242-71-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test/commands.c | 1 - app/test/packet_burst_generator.c | 4 +-- app/test/test_crc.c | 5 ++-- app/test/test_cryptodev.c | 18 ++++++------- app/test/test_cryptodev_asym.c | 1 - app/test/test_cryptodev_security_pdcp.c | 1 - app/test/test_efd.c | 1 - app/test/test_efd_perf.c | 1 - app/test/test_event_crypto_adapter.c | 12 ++++----- app/test/test_event_dma_adapter.c | 4 +-- app/test/test_eventdev.c | 1 - app/test/test_ipsec.c | 6 ++--- app/test/test_link_bonding_mode4.c | 8 +++--- app/test/test_mbuf.c | 1 - app/test/test_member.c | 1 - app/test/test_member_perf.c | 1 - app/test/test_rawdev.c | 1 - app/test/test_security_inline_proto.c | 36 ++++++++++++------------- app/test/test_service_cores.c | 1 - app/test/virtual_pmd.c | 3 +-- 20 files changed, 46 insertions(+), 61 deletions(-) diff --git a/app/test/commands.c b/app/test/commands.c index 497d8e9952ea..74494a0ef440 100644 --- a/app/test/commands.c +++ b/app/test/commands.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c index 867a88da0055..fcca2d238ece 100644 --- a/app/test/packet_burst_generator.c +++ b/app/test/packet_burst_generator.c @@ -148,8 +148,8 @@ initialize_ipv6_header(struct rte_ipv6_hdr *ip_hdr, uint8_t *src_addr, ip_hdr->proto = IPPROTO_UDP; ip_hdr->hop_limits = IP_DEFTTL; - rte_memcpy(ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); - rte_memcpy(ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); + memcpy(ip_hdr->src_addr, src_addr, sizeof(ip_hdr->src_addr)); + memcpy(ip_hdr->dst_addr, dst_addr, sizeof(ip_hdr->dst_addr)); return (uint16_t) (pkt_data_len + sizeof(struct rte_ipv6_hdr)); } diff --git a/app/test/test_crc.c b/app/test/test_crc.c index b85fca35fe2d..30fe00450606 100644 --- a/app/test/test_crc.c +++ b/app/test/test_crc.c @@ -6,7 +6,6 @@ #include #include -#include #include #define CRC_VEC_LEN 32 @@ -83,7 +82,7 @@ test_crc_calc(void) return -7; for (i = 0; i < CRC32_VEC_LEN1; i += 12) - rte_memcpy(&test_data[i], crc32_vec1, 12); + memcpy(&test_data[i], crc32_vec1, 12); result = crc_calc(test_data, CRC32_VEC_LEN1, type); if (result != crc32_vec1_res) { @@ -93,7 +92,7 @@ test_crc_calc(void) /* 32-bit ethernet CRC: Test 3 */ for (i = 0; i < CRC32_VEC_LEN2; i += 12) - rte_memcpy(&test_data[i], crc32_vec1, 12); + memcpy(&test_data[i], crc32_vec1, 12); result = crc_calc(test_data, CRC32_VEC_LEN2, type); if (result != crc32_vec2_res) { diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 38a65aa88f04..d87bcbb05b86 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -2345,8 +2345,8 @@ test_AES_CBC_HMAC_SHA1_encrypt_digest(void) sym_op->auth.data.length = QUOTE_512_BYTES; /* Copy IV at the end of the crypto operation */ - rte_memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), - aes_cbc_iv, CIPHER_IV_LENGTH_AES_CBC); + memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), + aes_cbc_iv, CIPHER_IV_LENGTH_AES_CBC); /* Set crypto operation cipher parameters */ sym_op->cipher.data.offset = 0; @@ -2480,9 +2480,7 @@ test_AES_CBC_HMAC_SHA512_decrypt_perform(void *sess, DIGEST_BYTE_LENGTH_SHA512); TEST_ASSERT_NOT_NULL(ut_params->digest, "no room to append digest"); - rte_memcpy(ut_params->digest, - digest, - DIGEST_BYTE_LENGTH_SHA512); + memcpy(ut_params->digest, digest, DIGEST_BYTE_LENGTH_SHA512); /* Generate Crypto op data structure */ ut_params->op = rte_crypto_op_alloc(ts_params->op_mpool, @@ -2505,8 +2503,8 @@ test_AES_CBC_HMAC_SHA512_decrypt_perform(void *sess, sym_op->auth.data.length = QUOTE_512_BYTES; /* Copy IV at the end of the crypto operation */ - rte_memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), - iv, CIPHER_IV_LENGTH_AES_CBC); + memcpy(rte_crypto_op_ctod_offset(ut_params->op, uint8_t *, IV_OFFSET), + iv, CIPHER_IV_LENGTH_AES_CBC); sym_op->cipher.data.offset = 0; sym_op->cipher.data.length = QUOTE_512_BYTES; @@ -8863,7 +8861,7 @@ create_aead_operation(enum rte_crypto_aead_operation op, uint8_t *, IV_OFFSET); if (tdata->iv.len == 0) { - rte_memcpy(iv_ptr, tdata->iv.data, AES_GCM_J0_LENGTH); + memcpy(iv_ptr, tdata->iv.data, AES_GCM_J0_LENGTH); debug_hexdump(stdout, "iv:", iv_ptr, AES_GCM_J0_LENGTH); } else { @@ -13659,8 +13657,8 @@ test_multi_session_random_usage(void) for (i = 0; i < MB_SESSION_NUMBER; i++) { - rte_memcpy(&ut_paramz[i].ut_params, &unittest_params, - sizeof(struct crypto_unittest_params)); + memcpy(&ut_paramz[i].ut_params, &unittest_params, + sizeof(struct crypto_unittest_params)); test_AES_CBC_HMAC_SHA512_decrypt_create_session_params( &ut_paramz[i].ut_params, diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 17daf734e8c4..88561a8f25d5 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include diff --git a/app/test/test_cryptodev_security_pdcp.c b/app/test/test_cryptodev_security_pdcp.c index a7641bab7a6f..39926cbee37a 100644 --- a/app/test/test_cryptodev_security_pdcp.c +++ b/app/test/test_cryptodev_security_pdcp.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test/test_efd.c b/app/test/test_efd.c index 1c0986b9bcd9..306f851c52de 100644 --- a/app/test/test_efd.c +++ b/app/test/test_efd.c @@ -13,7 +13,6 @@ test_efd(void) #else -#include #include #include #include diff --git a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c index b212e96767a2..7f5a8b9a5603 100644 --- a/app/test/test_efd_perf.c +++ b/app/test/test_efd_perf.c @@ -22,7 +22,6 @@ test_efd_perf(void) #include #include #include -#include #include #define NUM_KEYSIZES 10 diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c index 0c56744ba031..4992c5bc5035 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -454,7 +454,7 @@ test_op_forward_mode(uint8_t session_less) m_data.request_info.cdev_id = request_info.cdev_id; m_data.request_info.queue_pair_id = request_info.queue_pair_id; m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); } sym_op->m_src = m; @@ -653,8 +653,8 @@ test_asym_op_forward_mode(uint8_t session_less) m_data.request_info.cdev_id = request_info.cdev_id; m_data.request_info.queue_pair_id = request_info.queue_pair_id; m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + op->private_data_offset, - &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + op->private_data_offset, &m_data, + sizeof(m_data)); } /* Fill in event info and update event_ptr with rte_crypto_op */ memset(&ev, 0, sizeof(ev)); @@ -820,7 +820,7 @@ test_op_new_mode(uint8_t session_less) op->private_data_offset = len; /* Fill in private data information */ m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); } sym_op->m_src = m; @@ -977,8 +977,8 @@ test_asym_op_new_mode(uint8_t session_less) sizeof(struct rte_crypto_asym_xform)); /* Fill in private data information */ m_data.response_info.event = response_info.event; - rte_memcpy((uint8_t *)op + op->private_data_offset, - &m_data, sizeof(m_data)); + memcpy((uint8_t *)op + op->private_data_offset, &m_data, + sizeof(m_data)); } ret = send_op_recv_ev(op); diff --git a/app/test/test_event_dma_adapter.c b/app/test/test_event_dma_adapter.c index 35b417b69f7b..af2e44a703e4 100644 --- a/app/test/test_event_dma_adapter.c +++ b/app/test/test_event_dma_adapter.c @@ -269,8 +269,8 @@ test_op_forward_mode(void) op->vchan = TEST_DMA_VCHAN_ID; response_info.event = dma_response_info.event; - rte_memcpy((uint8_t *)op + sizeof(struct rte_event_dma_adapter_op), &response_info, - sizeof(struct rte_event)); + memcpy((uint8_t *)op + sizeof(struct rte_event_dma_adapter_op), + &response_info, sizeof(struct rte_event)); /* Fill in event info and update event_ptr with rte_event_dma_adapter_op */ memset(&ev[i], 0, sizeof(struct rte_event)); diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index e4e234dc9867..d2ae9b4930d0 100644 --- a/app/test/test_eventdev.c +++ b/app/test/test_eventdev.c @@ -8,7 +8,6 @@ #include #include #include -#include #ifdef RTE_EXEC_ENV_WINDOWS static int diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 6cb1bac1e732..25aabdb616da 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test_ipsec.c @@ -601,10 +601,10 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string, /* copy outer IP and ESP header */ ipv4_outer.total_length = rte_cpu_to_be_16(t_len); ipv4_outer.packet_id = rte_cpu_to_be_16(seq); - rte_memcpy(dst, &ipv4_outer, sizeof(ipv4_outer)); + memcpy(dst, &ipv4_outer, sizeof(ipv4_outer)); dst += sizeof(ipv4_outer); m->l3_len = sizeof(ipv4_outer); - rte_memcpy(dst, &esph, sizeof(esph)); + memcpy(dst, &esph, sizeof(esph)); dst += sizeof(esph); if (string != NULL) { @@ -616,7 +616,7 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string, sizeof(esp_pad_bytes))); dst += padlen; /* copy ESP tail header */ - rte_memcpy(dst, &espt, sizeof(espt)); + memcpy(dst, &espt, sizeof(espt)); } else memset(dst, 0, t_len); diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index ff13dbed93f3..e4827c1e8091 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -1399,8 +1399,8 @@ test_mode4_ext_ctrl(void) for (i = 0; i < MEMBER_COUNT; i++) { lacp_tx_buf[i] = rte_pktmbuf_alloc(test_params.mbuf_pool); - rte_memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), - &lacpdu, sizeof(lacpdu)); + memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), &lacpdu, + sizeof(lacpdu)); rte_pktmbuf_pkt_len(lacp_tx_buf[i]) = sizeof(lacpdu); } @@ -1453,8 +1453,8 @@ test_mode4_ext_lacp(void) for (i = 0; i < MEMBER_COUNT; i++) { lacp_tx_buf[i] = rte_pktmbuf_alloc(test_params.mbuf_pool); - rte_memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), - &lacpdu, sizeof(lacpdu)); + memcpy(rte_pktmbuf_mtod(lacp_tx_buf[i], char *), &lacpdu, + sizeof(lacpdu)); rte_pktmbuf_pkt_len(lacp_tx_buf[i]) = sizeof(lacpdu); } diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 51ea6ef1c472..9303f2492f89 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/app/test/test_member.c b/app/test/test_member.c index 5a4d2750db36..7281a644bd21 100644 --- a/app/test/test_member.c +++ b/app/test/test_member.c @@ -7,7 +7,6 @@ #include #include "test.h" -#include #include #ifdef RTE_EXEC_ENV_WINDOWS diff --git a/app/test/test_member_perf.c b/app/test/test_member_perf.c index db6b8a18efd9..f40fdba91e80 100644 --- a/app/test/test_member_perf.c +++ b/app/test/test_member_perf.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index d34691dacf5f..120e61dcc29c 100644 --- a/app/test/test_rawdev.c +++ b/app/test/test_rawdev.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #ifdef RTE_EXEC_ENV_WINDOWS diff --git a/app/test/test_security_inline_proto.c b/app/test/test_security_inline_proto.c index 481382b64e85..8268a0855ba7 100644 --- a/app/test/test_security_inline_proto.c +++ b/app/test/test_security_inline_proto.c @@ -245,8 +245,8 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, /* Copy cipher session parameters */ if (sa->aead) { - rte_memcpy(sess_conf->crypto_xform, &sa->xform.aead, - sizeof(struct rte_crypto_sym_xform)); + memcpy(sess_conf->crypto_xform, &sa->xform.aead, + sizeof(struct rte_crypto_sym_xform)); sess_conf->crypto_xform->aead.key.data = sa->key.data; /* Verify crypto capabilities */ if (test_sec_crypto_caps_aead_verify(sec_cap, sess_conf->crypto_xform) != 0) { @@ -256,13 +256,13 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, } } else { if (dir == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) { - rte_memcpy(&sess_conf->crypto_xform->cipher, - &sa->xform.chain.cipher.cipher, - sizeof(struct rte_crypto_cipher_xform)); + memcpy(&sess_conf->crypto_xform->cipher, + &sa->xform.chain.cipher.cipher, + sizeof(struct rte_crypto_cipher_xform)); - rte_memcpy(&sess_conf->crypto_xform->next->auth, - &sa->xform.chain.auth.auth, - sizeof(struct rte_crypto_auth_xform)); + memcpy(&sess_conf->crypto_xform->next->auth, + &sa->xform.chain.auth.auth, + sizeof(struct rte_crypto_auth_xform)); sess_conf->crypto_xform->cipher.key.data = sa->key.data; sess_conf->crypto_xform->next->auth.key.data = @@ -282,12 +282,12 @@ create_inline_ipsec_session(struct ipsec_test_data *sa, uint16_t portid, return TEST_SKIPPED; } } else { - rte_memcpy(&sess_conf->crypto_xform->next->cipher, - &sa->xform.chain.cipher.cipher, - sizeof(struct rte_crypto_cipher_xform)); - rte_memcpy(&sess_conf->crypto_xform->auth, - &sa->xform.chain.auth.auth, - sizeof(struct rte_crypto_auth_xform)); + memcpy(&sess_conf->crypto_xform->next->cipher, + &sa->xform.chain.cipher.cipher, + sizeof(struct rte_crypto_cipher_xform)); + memcpy(&sess_conf->crypto_xform->auth, + &sa->xform.chain.auth.auth, + sizeof(struct rte_crypto_auth_xform)); sess_conf->crypto_xform->auth.key.data = sa->auth_key.data; sess_conf->crypto_xform->next->cipher.key.data = @@ -463,12 +463,12 @@ init_packet(struct rte_mempool *mp, const uint8_t *data, unsigned int len, bool return NULL; if (outer_ipv4) { - rte_memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), - &dummy_ipv4_eth_hdr, RTE_ETHER_HDR_LEN); + memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), + &dummy_ipv4_eth_hdr, RTE_ETHER_HDR_LEN); pkt->l3_len = sizeof(struct rte_ipv4_hdr); } else { - rte_memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), - &dummy_ipv6_eth_hdr, RTE_ETHER_HDR_LEN); + memcpy(rte_pktmbuf_append(pkt, RTE_ETHER_HDR_LEN), + &dummy_ipv6_eth_hdr, RTE_ETHER_HDR_LEN); pkt->l3_len = sizeof(struct rte_ipv6_hdr); } pkt->l2_len = RTE_ETHER_HDR_LEN; diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index c12d52d8f16c..fb08821b87eb 100644 --- a/app/test/test_service_cores.c +++ b/app/test/test_service_cores.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index b7d74a467a22..ae48923df78f 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include @@ -186,7 +185,7 @@ virtual_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) struct virtual_ethdev_private *dev_private = dev->data->dev_private; if (stats) - rte_memcpy(stats, &dev_private->eth_stats, sizeof(*stats)); + memcpy(stats, &dev_private->eth_stats, sizeof(*stats)); return 0; } From patchwork Fri Mar 1 17:16:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137761 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0CF943C12; Fri, 1 Mar 2024 18:25:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6EE94350F; Fri, 1 Mar 2024 18:18:50 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 2171C43487 for ; Fri, 1 Mar 2024 18:18:15 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dca160163dso23227495ad.3 for ; Fri, 01 Mar 2024 09:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313494; x=1709918294; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6C2FGPHnRzt39pnm08MPnZG73sDYQhkMrLyqqUoxDfo=; b=UTzXQ0xGsqfUo/3tAya5FRwv2CXLdANpxTSKCTUagtB7pUxq3wUCLWh2WzZsY6mxr0 w3Y6SHf+wovT+0UPEntobbsgHUaV/8WXfhpmMeLpJD55+2rDiszhXZVjVoixz6Tz5B0F emvOwOSrqwbntThbg1ovnzMN67XMSvBVdo3wsQVIKDs0eKPXVr11Kydmi6mObXkSHPHe JpsC2fgPYTO6YeW+wrGDT0X9W4V4cvV96mmnSZYNpUiF/RBOLOBQe6rvCed24ao1stKu vrdHUOzCfALDrJ06RHugeluQNIJhMlMePGeXucbuycBv4ja7FyIRT9yZ6RCCCb/g+H24 wleQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313494; x=1709918294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6C2FGPHnRzt39pnm08MPnZG73sDYQhkMrLyqqUoxDfo=; b=ZkfL94f4d+mgFd+74EfaPVW7XS2TqxooHCvLDdCUZ2Smn88aSNYSsfBdH2W9rhv5+H iWMaznThxcYwPBU1n8HUH3lgfYZp1mf6uWE6JRj+LrOUwomeeD6KVf6uJgNxkMdxmf3v gpFHTyoXfLZLRmkSaQJ5EqBzahbrGrRw7YVHakUgn+W13jLl+AKorCT/OkaWu+PAdYWq sZIwQ+iM49UULzT6+eLvtLphDHaE0GrRsJg/8r4AEbXV+8UB+qEJFreW/7RlBkxa+J+a QFgZhCGuTmHKYrku9m0mAKzjV4N2RsvE9pAMo/tIqXMi2lYkhZjDwyxfeb+Dj0a/gx/A Vy3A== X-Gm-Message-State: AOJu0YxQgWH9hTfcDCxPatUoitvVUhy4haUThTm6tYyhh3gtM9lVNztg /LDOIK2IL/mhfjBDGnMdmMqkPG8hPZe2g63nKlckQh+dYc6ep0ZyEGK5q6Td9/+Ulh1zqfB4UU0 WN7NmCQ== X-Google-Smtp-Source: AGHT+IEEJ/DpTEsRvPyHM7hUQwsMLheNgfsze0FckzOgErnLBKSNwiNQ1s9fyADCwyAAQqy4IGHtpg== X-Received: by 2002:a17:903:32d0:b0:1db:cbff:df15 with SMTP id i16-20020a17090332d000b001dbcbffdf15mr2617971plr.9.1709313494197; Fri, 01 Mar 2024 09:18:14 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:18:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru , Tomasz Kantecki , Kirill Rybalchenko , Maxime Coquelin , Chenbo Xia Subject: [PATCH v2 71/71] examples: replace use of fixed size rte_memcpy Date: Fri, 1 Mar 2024 09:16:07 -0800 Message-ID: <20240301171707.95242-72-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301171707.95242-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> <20240301171707.95242-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 2 +- examples/l2fwd-cat/cat.c | 4 +--- examples/ptpclient/ptpclient.c | 11 +++++------ examples/vhost/main.c | 5 ++--- examples/vmdq/main.c | 6 ++---- examples/vmdq_dcb/main.c | 15 +++++---------- 6 files changed, 16 insertions(+), 27 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 16599ae9cee3..52c8eabba778 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -359,7 +359,7 @@ add_ether_hdr(struct rte_mbuf *pkt_src, struct rte_mbuf *pkt_dst) eth_to = rte_pktmbuf_mtod(pkt_dst, struct rte_ether_hdr *); /* copy header */ - rte_memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr)); + memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr)); } static inline void diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 00e4cde48b48..d1689fca2912 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -12,7 +12,6 @@ #include #include -#include #include @@ -314,8 +313,7 @@ parse_l3ca(const char *l3ca) if (cmask != 0 && is_contiguous(cmask) == 0) goto err; - rte_memcpy(&m_config[idx].cpumask, - &cpuset, sizeof(rte_cpuset_t)); + memcpy(&m_config[idx].cpumask, &cpuset, sizeof(rte_cpuset_t)); if (cmask != 0) { m_config[idx].cdp = 1; diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c index 2535d848a1e9..e918bc05db34 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -359,9 +359,9 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx) ptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id); if (ptp_data->ptpset == 0) { - rte_memcpy(&ptp_data->master_clock_id, - &ptp_hdr->source_port_id.clock_id, - sizeof(struct clock_id)); + memcpy(&ptp_data->master_clock_id, + &ptp_hdr->source_port_id.clock_id, + sizeof(struct clock_id)); ptp_data->ptpset = 1; } @@ -466,9 +466,8 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data) client_clkid->id[6] = eth_hdr->src_addr.addr_bytes[4]; client_clkid->id[7] = eth_hdr->src_addr.addr_bytes[5]; - rte_memcpy(&ptp_data->client_clock_id, - client_clkid, - sizeof(struct clock_id)); + memcpy(&ptp_data->client_clock_id, client_clkid, + sizeof(struct clock_id)); /* Enable flag for hardware timestamping. */ created_pkt->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST; diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 3fc1b151d182..5691ec110ac8 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -405,9 +405,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_devices) conf.pool_map[i].pools = (1UL << i); } - (void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, - sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); + (void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); return 0; } diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index 4a3ce6884c5c..d928f4a45ccf 100644 --- a/examples/vmdq/main.c +++ b/examples/vmdq/main.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include @@ -151,9 +150,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_pools) conf.pool_map[i].pools = (1UL << (i % num_pools)); } - (void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, - sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); + (void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf))); if (rss_enable) { eth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_RSS; eth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP | diff --git a/examples/vmdq_dcb/main.c b/examples/vmdq_dcb/main.c index 4ccc2fe4b01c..f93eca59367b 100644 --- a/examples/vmdq_dcb/main.c +++ b/examples/vmdq_dcb/main.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include @@ -161,15 +160,11 @@ get_eth_conf(struct rte_eth_conf *eth_conf) tx_conf.dcb_tc[i] = i % num_tcs; } dcb_conf.nb_tcs = (enum rte_eth_nb_tcs)num_tcs; - (void)(rte_memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf, - sizeof(conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf, - sizeof(dcb_conf))); - (void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf, - sizeof(vmdq_conf))); - (void)(rte_memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf, - sizeof(tx_conf))); + (void)(memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf, sizeof(conf))); + (void)(memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf, sizeof(dcb_conf))); + (void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf, sizeof(vmdq_conf))); + (void)(memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf, sizeof(tx_conf))); if (rss_enable) { eth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_DCB_RSS; eth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP |