diff mbox series

[5/8] net/hns3: remove reset log in secondary

Message ID	20231027060947.3183983-6-haijie1@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Ferruh Yigit
Headers	From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Chengwen Feng <fengchengwen@huawei.com>, Dongdong Liu <liudongdong3@huawei.com> CC: <lihuisong@huawei.com>, <huangdengdui@huawei.com> Subject: [PATCH 5/8] net/hns3: remove reset log in secondary Date: Fri, 27 Oct 2023 14:09:43 +0800 Message-ID: <20231027060947.3183983-6-haijie1@huawei.com> In-Reply-To: <20231027060947.3183983-1-haijie1@huawei.com> References: <20231027060947.3183983-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	net/hns3: add some bugfix for hns3 \| [0/8] net/hns3: add some bugfix for hns3 [1/8] net/hns3: fix a typo [2/8] net/hns3: fix unchecked Rx free threshold [3/8] net/hns3: fix segmentfault for NEON and SVE [4/8] net/hns3: fix double stats for IMP and global reset [5/8] net/hns3: remove reset log in secondary [6/8] net/hns3: fix multiple reset detected log [7/8] net/hns3: fix the imp/global reset interrupted possibly [8/8] net/hns3: refactor interrupt state query

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jie Hai Oct. 27, 2023, 6:09 a.m. UTC

  From: Dengdui Huang <huangdengdui@huawei.com>

The reset event is checked and done in primary. And the secondary
doesn't check and display reset log. There is a patch to remove the
check code for secondary. please see commit a8f1f7cf1b42 ("net/hns3:
fix crash when secondary process access FW")

This patch removes the redundant log print of reset.

Fixes: a8f1f7cf1b42 ("net/hns3: fix crash when secondary process access FW")
Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c    | 11 +++++------
 drivers/net/hns3/hns3_ethdev_vf.c | 11 +++++------
 2 files changed, 10 insertions(+), 12 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 964f47f1641e..3bdce1fa4b48 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -5512,14 +5512,13 @@  hns3_is_reset_pending(struct hns3_adapter *hns)
 	enum hns3_reset_level reset;
 
 	/*
-	 * Check the registers to confirm whether there is reset pending.
-	 * Note: This check may lead to schedule reset task, but only primary
-	 *       process can process the reset event. Therefore, limit the
-	 *       checking under only primary process.
+	 * Only primary can process can process the reset event,
+	 * so don't check reset event in secondary.
 	 */
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-		hns3_check_event_cause(hns, NULL);
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return false;
 
+	hns3_check_event_cause(hns, NULL);
 	reset = hns3_get_reset_level(hns, &hw->reset.pending);
 	if (reset != HNS3_NONE_RESET && hw->reset.level != HNS3_NONE_RESET &&
 	    hw->reset.level < reset) {
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index 007f5d619fbf..5f3422d14e8a 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -1715,14 +1715,13 @@  hns3vf_is_reset_pending(struct hns3_adapter *hns)
 		return false;
 
 	/*
-	 * Check the registers to confirm whether there is reset pending.
-	 * Note: This check may lead to schedule reset task, but only primary
-	 *       process can process the reset event. Therefore, limit the
-	 *       checking under only primary process.
+	 * Only primary can process can process the reset event,
+	 * so don't check reset event in secondary.
 	 */
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-		hns3vf_check_event_cause(hns, NULL);
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return false;
 
+	hns3vf_check_event_cause(hns, NULL);
 	reset = hns3vf_get_reset_level(hw, &hw->reset.pending);
 	if (hw->reset.level != HNS3_NONE_RESET && reset != HNS3_NONE_RESET &&
 	    hw->reset.level < reset) {