mbox series

[0/8] net/hns3: add some bugfix for hns3

Message ID 20231027060947.3183983-1-haijie1@huawei.com (mailing list archive)
Headers
Series net/hns3: add some bugfix for hns3 |

Message

Jie Hai Oct. 27, 2023, 6:09 a.m. UTC 
  This patchset contains some bugfix for hns3 pmd.

Dengdui Huang (6):
  net/hns3: fix unchecked Rx free threshold
  net/hns3: fix double stats for IMP and global reset
  net/hns3: remove reset log in secondary
  net/hns3: fix multiple reset detected log
  net/hns3: fix the imp/global reset interrupted possibly
  net/hns3: refactor interrupt state query

Huisong Li (1):
  net/hns3: fix segmentfault for NEON and SVE

Jie Hai (1):
  net/hns3: fix a typo

 drivers/net/hns3/hns3_ethdev.c    | 210 ++++++++++++++++++++----------
 drivers/net/hns3/hns3_ethdev.h    |   1 +
 drivers/net/hns3/hns3_ethdev_vf.c |  11 +-
 drivers/net/hns3/hns3_intr.c      |   6 +-
 drivers/net/hns3/hns3_rxtx.c      |   8 +-
 drivers/net/hns3/hns3_rxtx_vec.h  |   5 +
 drivers/net/hns3/hns3_tm.c        |   4 +-
 7 files changed, 167 insertions(+), 78 deletions(-)

Comments

fengchengwen Oct. 27, 2023, 7:11 a.m. UTC | #1 
Series-reviewed-by: Chengwen Feng <fengchengwen@huawei.com>

On 2023/10/27 14:09, Jie Hai wrote:
> This patchset contains some bugfix for hns3 pmd.
> 
> Dengdui Huang (6):
>   net/hns3: fix unchecked Rx free threshold
>   net/hns3: fix double stats for IMP and global reset
>   net/hns3: remove reset log in secondary
>   net/hns3: fix multiple reset detected log
>   net/hns3: fix the imp/global reset interrupted possibly
>   net/hns3: refactor interrupt state query
> 
> Huisong Li (1):
>   net/hns3: fix segmentfault for NEON and SVE
> 
> Jie Hai (1):
>   net/hns3: fix a typo
> 
>  drivers/net/hns3/hns3_ethdev.c    | 210 ++++++++++++++++++++----------
>  drivers/net/hns3/hns3_ethdev.h    |   1 +
>  drivers/net/hns3/hns3_ethdev_vf.c |  11 +-
>  drivers/net/hns3/hns3_intr.c      |   6 +-
>  drivers/net/hns3/hns3_rxtx.c      |   8 +-
>  drivers/net/hns3/hns3_rxtx_vec.h  |   5 +
>  drivers/net/hns3/hns3_tm.c        |   4 +-
>  7 files changed, 167 insertions(+), 78 deletions(-)
>
Ferruh Yigit Oct. 27, 2023, 7:29 p.m. UTC | #2 
On 10/27/2023 7:09 AM, Jie Hai wrote:
> This patchset contains some bugfix for hns3 pmd.
> 
> Dengdui Huang (6):
>   net/hns3: fix unchecked Rx free threshold
>   net/hns3: fix double stats for IMP and global reset
>   net/hns3: remove reset log in secondary
>   net/hns3: fix multiple reset detected log
>   net/hns3: fix the imp/global reset interrupted possibly
>   net/hns3: refactor interrupt state query
> 
> Huisong Li (1):
>   net/hns3: fix segmentfault for NEON and SVE
> 
> Jie Hai (1):
>   net/hns3: fix a typo
> 

There is a checkpatch warning related to the atomics:

  ### [PATCH] net/hns3: fix multiple reset detected log

  Warning in drivers/net/hns3/hns3_ethdev.c:
  Using __atomic_xxx built-ins, prefer rte_atomic_xxx

This is about update in the preferred atomic APIs, but as far as I can
see patch doesn't add new atomic API but just changes the logic in the
code, so I think we can ignore this warning for now,
But please be aware of the guidance of the new atomic APIs, and take
this into account for new code.


Series applied to dpdk-next-net/main, thanks.
Jie Hai Oct. 28, 2023, 1:57 a.m. UTC | #3 
On 2023/10/28 3:29, Ferruh Yigit wrote:
> On 10/27/2023 7:09 AM, Jie Hai wrote:
>> This patchset contains some bugfix for hns3 pmd.
>>
>> Dengdui Huang (6):
>>    net/hns3: fix unchecked Rx free threshold
>>    net/hns3: fix double stats for IMP and global reset
>>    net/hns3: remove reset log in secondary
>>    net/hns3: fix multiple reset detected log
>>    net/hns3: fix the imp/global reset interrupted possibly
>>    net/hns3: refactor interrupt state query
>>
>> Huisong Li (1):
>>    net/hns3: fix segmentfault for NEON and SVE
>>
>> Jie Hai (1):
>>    net/hns3: fix a typo
>>
> 
> There is a checkpatch warning related to the atomics:
> 
>    ### [PATCH] net/hns3: fix multiple reset detected log
> 
>    Warning in drivers/net/hns3/hns3_ethdev.c:
>    Using __atomic_xxx built-ins, prefer rte_atomic_xxx
> 
> This is about update in the preferred atomic APIs, but as far as I can
> see patch doesn't add new atomic API but just changes the logic in the
> code, so I think we can ignore this warning for now,
> But please be aware of the guidance of the new atomic APIs, and take
> this into account for new code.
> 
Thanks, and we will pay attention to it.
> 
> Series applied to dpdk-next-net/main, thanks.
> .