[v4,02/28] cmdline: make experimental API's stable

Message ID 20231019191016.156430-3-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Promote many experimental API's to stable |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Oct. 19, 2023, 7:09 p.m. UTC
  These API's have all ben around for several releases.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/cmdline/cmdline.h        |  1 -
 lib/cmdline/cmdline_parse.h  |  4 ----
 lib/cmdline/cmdline_rdline.h |  4 ----
 lib/cmdline/version.map      | 26 ++++++++------------------
 4 files changed, 8 insertions(+), 27 deletions(-)
  

Patch

diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h
index 992c84591456..dd41e1054378 100644
--- a/lib/cmdline/cmdline.h
+++ b/lib/cmdline/cmdline.h
@@ -39,7 +39,6 @@  void cmdline_printf(const struct cmdline *cl, const char *fmt, ...)
 int cmdline_in(struct cmdline *cl, const char *buf, int size);
 int cmdline_write_char(struct rdline *rdl, char c);
 
-__rte_experimental
 struct rdline *
 cmdline_get_rdline(struct cmdline *cl);
 
diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h
index a852ac411c59..41b4db1f76f9 100644
--- a/lib/cmdline/cmdline_parse.h
+++ b/lib/cmdline/cmdline_parse.h
@@ -155,9 +155,6 @@  typedef cmdline_parse_inst_t *cmdline_parse_ctx_t;
 int cmdline_parse(struct cmdline *cl, const char *buf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Try to parse a buffer according to the specified context, but do not
  * perform any function calls if parse is successful.
  *
@@ -166,7 +163,6 @@  int cmdline_parse(struct cmdline *cl, const char *buf);
  * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0)
  * on successful parse.
  */
-__rte_experimental
 int cmdline_parse_check(struct cmdline *cl, const char *buf);
 
 /**
diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h
index 1b4cc7ce5773..c6bb6bbbb36a 100644
--- a/lib/cmdline/cmdline_rdline.h
+++ b/lib/cmdline/cmdline_rdline.h
@@ -58,7 +58,6 @@  typedef int (rdline_complete_t)(struct rdline *rdl, const char *buf,
  *
  * \return New rdline object on success, NULL on failure.
  */
-__rte_experimental
 struct rdline *rdline_new(rdline_write_char_t *write_char,
 			  rdline_validate_t *validate,
 			  rdline_complete_t *complete,
@@ -70,7 +69,6 @@  struct rdline *rdline_new(rdline_write_char_t *write_char,
  * \param rdl A pointer to an initialized struct rdline.
  *            If NULL, this function is a no-op.
  */
-__rte_experimental
 void rdline_free(struct rdline *rdl);
 
 /**
@@ -163,13 +161,11 @@  char *rdline_get_history_item(struct rdline *rdl, unsigned int i);
 /**
  * Get maximum history buffer size.
  */
-__rte_experimental
 size_t rdline_get_history_buffer_size(struct rdline *rdl);
 
 /**
  * Get the opaque pointer supplied on struct rdline creation.
  */
-__rte_experimental
 void *rdline_get_opaque(struct rdline *rdl);
 
 #ifdef __cplusplus
diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map
index 97166789016c..88174e39bcb7 100644
--- a/lib/cmdline/version.map
+++ b/lib/cmdline/version.map
@@ -30,11 +30,13 @@  DPDK_24 {
 	cmdline_get_help_num;
 	cmdline_get_help_portlist;
 	cmdline_get_help_string;
+	cmdline_get_rdline;
 	cmdline_in;
 	cmdline_interact;
 	cmdline_isendoftoken;
 	cmdline_new;
 	cmdline_parse;
+	cmdline_parse_check;
 	cmdline_parse_etheraddr;
 	cmdline_parse_ipaddr;
 	cmdline_parse_num;
@@ -51,37 +53,25 @@  DPDK_24 {
 	cmdline_token_portlist_ops;
 	cmdline_token_string_ops;
 	cmdline_write_char;
+
 	rdline_add_history;
 	rdline_char_in;
 	rdline_clear_history;
+	rdline_free;
 	rdline_get_buffer;
+	rdline_get_history_buffer_size;
 	rdline_get_history_item;
+	rdline_get_opaque;
+	rdline_new;
 	rdline_newline;
 	rdline_quit;
 	rdline_redisplay;
 	rdline_reset;
 	rdline_restart;
 	rdline_stop;
+
 	vt100_init;
 	vt100_parser;
 
 	local: *;
 };
-
-EXPERIMENTAL {
-	global:
-
-	# added in 20.11
-	cmdline_get_rdline;
-
-	# added in 21.11
-	rdline_new;
-	rdline_free;
-	rdline_get_history_buffer_size;
-	rdline_get_opaque;
-
-	# added in 22.07
-	cmdline_parse_check;
-
-	local: *;
-};