[v4,06/28] pcapng: mark API's as stable

Message ID 20231019191016.156430-7-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Promote many experimental API's to stable |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Oct. 19, 2023, 7:09 p.m. UTC
  This API was added in 23.11 and can now be marked as not
experimental.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/pcapng/rte_pcapng.h | 11 -----------
 lib/pcapng/version.map  |  6 ++----
 2 files changed, 2 insertions(+), 15 deletions(-)
  

Comments

Morten Brørup Oct. 20, 2023, 11:03 a.m. UTC | #1
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 19 October 2023 21.10
> 
> This API was added in 23.11 and can now be marked as not
> experimental.

If they were added in 23.11 they would be brand new.

The same typo is present in other patches in this series.
  

Patch

diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h
index d93cc9f73ad5..c96c8994f38b 100644
--- a/lib/pcapng/rte_pcapng.h
+++ b/lib/pcapng/rte_pcapng.h
@@ -6,10 +6,6 @@ 
  * @file
  * RTE pcapng
  *
- * @warning
- * @b EXPERIMENTAL:
- * All functions in this file may be changed or removed without prior notice.
- *
  * Pcapng is an evolution from the pcap format, created to address some of
  * its deficiencies. Namely, the lack of extensibility and inability to store
  * additional information.
@@ -54,7 +50,6 @@  typedef struct rte_pcapng rte_pcapng_t;
  * @return
  *   handle to library, or NULL in case of error (and rte_errno is set).
  */
-__rte_experimental
 rte_pcapng_t *
 rte_pcapng_fdopen(int fd,
 		  const char *osname, const char *hardware,
@@ -66,7 +61,6 @@  rte_pcapng_fdopen(int fd,
  * @param self
  *  handle to library
  */
-__rte_experimental
 void
 rte_pcapng_close(rte_pcapng_t *self);
 
@@ -89,7 +83,6 @@  rte_pcapng_close(rte_pcapng_t *self);
  * and before any packet record. All ports used in packet capture
  * must be added.
  */
-__rte_experimental
 int
 rte_pcapng_add_interface(rte_pcapng_t *self, uint16_t port,
 			 const char *ifname, const char *ifdescr,
@@ -132,7 +125,6 @@  enum rte_pcapng_direction {
  *   - The pointer to the new mbuf formatted for pcapng_write
  *   - NULL if allocation fails.
  */
-__rte_experimental
 struct rte_mbuf *
 rte_pcapng_copy(uint16_t port_id, uint32_t queue,
 		const struct rte_mbuf *m, struct rte_mempool *mp,
@@ -149,7 +141,6 @@  rte_pcapng_copy(uint16_t port_id, uint32_t queue,
  *   The minimum size of mbuf data to handle packet with length bytes.
  *   Accounting for required header and trailer fields
  */
-__rte_experimental
 uint32_t
 rte_pcapng_mbuf_size(uint32_t length);
 
@@ -174,7 +165,6 @@  rte_pcapng_mbuf_size(uint32_t length);
  *  The number of bytes written to file, -1 on failure to write file.
  *  The mbuf's in *pkts* are always freed.
  */
-__rte_experimental
 ssize_t
 rte_pcapng_write_packets(rte_pcapng_t *self,
 			 struct rte_mbuf *pkts[], uint16_t nb_pkts);
@@ -205,7 +195,6 @@  rte_pcapng_write_packets(rte_pcapng_t *self,
  * @return
  *  number of bytes written to file, -1 on failure to write file
  */
-__rte_experimental
 ssize_t
 rte_pcapng_write_stats(rte_pcapng_t *self, uint16_t port,
 		       const char *comment,
diff --git a/lib/pcapng/version.map b/lib/pcapng/version.map
index 36393914d97c..81c9652ad6b5 100644
--- a/lib/pcapng/version.map
+++ b/lib/pcapng/version.map
@@ -1,6 +1,7 @@ 
-EXPERIMENTAL {
+DPDK_24 {
 	global:
 
+	rte_pcapng_add_interface;
 	rte_pcapng_close;
 	rte_pcapng_copy;
 	rte_pcapng_fdopen;
@@ -8,8 +9,5 @@  EXPERIMENTAL {
 	rte_pcapng_write_packets;
 	rte_pcapng_write_stats;
 
-	# added in 23.03
-	rte_pcapng_add_interface;
-
 	local: *;
 };