From patchwork Thu Oct 19 19:09:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133031 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2387431B1; Thu, 19 Oct 2023 21:10:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BDDB40E03; Thu, 19 Oct 2023 21:10:31 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 91D0D40278 for ; Thu, 19 Oct 2023 21:10:28 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1c434c33ec0so59118985ad.3 for ; Thu, 19 Oct 2023 12:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697742627; x=1698347427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=w6oXjkQMbD5XJFlrtarwr6l9zQA1RXrharMsJeWQz54RwjUUzzZ6xLe9aLqjaLzumA 84Rttf5J6946Gqyc6xFkZ44vxhmFOHHQ/2JybhUWfjEphGCVI4WHlXXeP1pZtZ5LeorU Dv6QJeIxzY47T7TlBItBVYngIOXg4Hvn2U2TSOcNFpT7AwLBJVpwFxC1dU7RG8fxA3L6 IQIvQJcw1dS3LBG8SxCuV7kNQGE9OMe8uK5RFP0A38e2Ljm1ZrmpWTO05AKbSFqzZyfm iuDzKR3AyHV8pGEvM/n/m3vw0VVOToNrvtINsc8kHgr6XZsobKYdemJZKAyoFbT495UI 0BWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697742627; x=1698347427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=Dulu5qlbV1GWJT3VTBzHUXbkU//wlcgsAFBK7dwoSWTuzie7A8KG5x0uvAaVLp3keK yLKYTIG/aTqC1MVXOnQ/dQki7Um2hkr+f4cYilbFZKSlhOd8/atb7qL7bCvoX4cFMY2O Fm+bNS/+yBXE/lqHZIKGBH35Dz6VQTQrQ5gF5UkGIqyhO8wihImnobIwwBSSkGsLcz81 C7BC7vMQ35SM2c18tvyvz0rHdmckKJdcom/kL7z9aOBX/srdIGM5e4uQvDQ7Y0ZGL74R hjUB7194wmItwwbSwC4z/6+Rcbs7EsQQDYHJ6CEH7uxVa+kTRW4uC6M8Ov4OxsofHomg vpyw== X-Gm-Message-State: AOJu0YxIIvd7g5R7X5yhN8Kgt2if4oO0qrtff/Evy76UqI3Jc4Jt5C9V QDqZJ76zNJ633Js5F5PhGf5H+dxc1KAchWtJ/u7knA== X-Google-Smtp-Source: AGHT+IHSflPVh227UKtiI7ASuBKfHtmoeVxynAK/WZ59SemEZi2/Ii695ipjSzRIT6cWVf7enai6iA== X-Received: by 2002:a17:903:1103:b0:1c9:c968:4ce with SMTP id n3-20020a170903110300b001c9c96804cemr3662188plh.33.1697742627498; Thu, 19 Oct 2023 12:10:27 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id h12-20020a170902eecc00b001a9b29b6759sm52464plb.183.2023.10.19.12.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:10:27 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v4 02/28] cmdline: make experimental API's stable Date: Thu, 19 Oct 2023 12:09:50 -0700 Message-Id: <20231019191016.156430-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019191016.156430-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019191016.156430-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h | 1 - lib/cmdline/cmdline_parse.h | 4 ---- lib/cmdline/cmdline_rdline.h | 4 ---- lib/cmdline/version.map | 26 ++++++++------------------ 4 files changed, 8 insertions(+), 27 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 992c84591456..dd41e1054378 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -39,7 +39,6 @@ void cmdline_printf(const struct cmdline *cl, const char *fmt, ...) int cmdline_in(struct cmdline *cl, const char *buf, int size); int cmdline_write_char(struct rdline *rdl, char c); -__rte_experimental struct rdline * cmdline_get_rdline(struct cmdline *cl); diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h index a852ac411c59..41b4db1f76f9 100644 --- a/lib/cmdline/cmdline_parse.h +++ b/lib/cmdline/cmdline_parse.h @@ -155,9 +155,6 @@ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t; int cmdline_parse(struct cmdline *cl, const char *buf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Try to parse a buffer according to the specified context, but do not * perform any function calls if parse is successful. * @@ -166,7 +163,6 @@ int cmdline_parse(struct cmdline *cl, const char *buf); * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0) * on successful parse. */ -__rte_experimental int cmdline_parse_check(struct cmdline *cl, const char *buf); /** diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h index 1b4cc7ce5773..c6bb6bbbb36a 100644 --- a/lib/cmdline/cmdline_rdline.h +++ b/lib/cmdline/cmdline_rdline.h @@ -58,7 +58,6 @@ typedef int (rdline_complete_t)(struct rdline *rdl, const char *buf, * * \return New rdline object on success, NULL on failure. */ -__rte_experimental struct rdline *rdline_new(rdline_write_char_t *write_char, rdline_validate_t *validate, rdline_complete_t *complete, @@ -70,7 +69,6 @@ struct rdline *rdline_new(rdline_write_char_t *write_char, * \param rdl A pointer to an initialized struct rdline. * If NULL, this function is a no-op. */ -__rte_experimental void rdline_free(struct rdline *rdl); /** @@ -163,13 +161,11 @@ char *rdline_get_history_item(struct rdline *rdl, unsigned int i); /** * Get maximum history buffer size. */ -__rte_experimental size_t rdline_get_history_buffer_size(struct rdline *rdl); /** * Get the opaque pointer supplied on struct rdline creation. */ -__rte_experimental void *rdline_get_opaque(struct rdline *rdl); #ifdef __cplusplus diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map index 97166789016c..88174e39bcb7 100644 --- a/lib/cmdline/version.map +++ b/lib/cmdline/version.map @@ -30,11 +30,13 @@ DPDK_24 { cmdline_get_help_num; cmdline_get_help_portlist; cmdline_get_help_string; + cmdline_get_rdline; cmdline_in; cmdline_interact; cmdline_isendoftoken; cmdline_new; cmdline_parse; + cmdline_parse_check; cmdline_parse_etheraddr; cmdline_parse_ipaddr; cmdline_parse_num; @@ -51,37 +53,25 @@ DPDK_24 { cmdline_token_portlist_ops; cmdline_token_string_ops; cmdline_write_char; + rdline_add_history; rdline_char_in; rdline_clear_history; + rdline_free; rdline_get_buffer; + rdline_get_history_buffer_size; rdline_get_history_item; + rdline_get_opaque; + rdline_new; rdline_newline; rdline_quit; rdline_redisplay; rdline_reset; rdline_restart; rdline_stop; + vt100_init; vt100_parser; local: *; }; - -EXPERIMENTAL { - global: - - # added in 20.11 - cmdline_get_rdline; - - # added in 21.11 - rdline_new; - rdline_free; - rdline_get_history_buffer_size; - rdline_get_opaque; - - # added in 22.07 - cmdline_parse_check; - - local: *; -};