diff mbox series

[5/9] cryptodev: fix null name when parse input args

Message ID	20230302075012.32423-6-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	David Marchand
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Declan Doherty <declan.doherty@intel.com>, Fiona Trahe <fiona.trahe@intel.com> CC: <dev@dpdk.org> Subject: [PATCH 5/9] cryptodev: fix null name when parse input args Date: Thu, 2 Mar 2023 07:50:08 +0000 Message-ID: <20230302075012.32423-6-fengchengwen@huawei.com> In-Reply-To: <20230302075012.32423-1-fengchengwen@huawei.com> References: <20230302075012.32423-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix kvargs callback prototype not clearly defined \| [0/9] fix kvargs callback prototype not clearly defined [1/9] kvargs: detailed definition of callback prototype [2/9] compressdev: fix segment fault when parse input args [3/9] compressdev: fix null name when parse input args [4/9] cryptodev: fix segment fault when parse input args [5/9] cryptodev: fix null name when parse input args [6/9] net/hns3: fix segment fault when parse runtime config [7/9] net/virtio: fix segment fault when parse devargs [8/9] dma/skeleton: fix segment fault when parse devargs [9/9] raw/skeleton: fix segment fault when parse devargs

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen March 2, 2023, 7:50 a.m. UTC

  The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

If the input args is just "name" (which mean only has keys), then it
will get (null) name in rte_cryptodev_pmd_parse_name_arg(). This patch
fixes it.

Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 lib/cryptodev/cryptodev_pmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff mbox series

Patch

diff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c
index 4122000839..d8073a601d 100644
--- a/lib/cryptodev/cryptodev_pmd.c
+++ b/lib/cryptodev/cryptodev_pmd.c
@@ -22,6 +22,9 @@  rte_cryptodev_pmd_parse_name_arg(const char *key __rte_unused,
 	struct rte_cryptodev_pmd_init_params *params = extra_args;
 	int n;
 
+	if (value == NULL || extra_args == NULL)
+		return -EINVAL;
+
 	n = strlcpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN);
 	if (n >= RTE_CRYPTODEV_NAME_MAX_LEN)
 		return -EINVAL;