diff mbox series

[4/9] cryptodev: fix segment fault when parse input args

Message ID	20230302075012.32423-5-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	David Marchand
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>, Declan Doherty <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Fiona Trahe <fiona.trahe@intel.com> CC: <dev@dpdk.org> Subject: [PATCH 4/9] cryptodev: fix segment fault when parse input args Date: Thu, 2 Mar 2023 07:50:07 +0000 Message-ID: <20230302075012.32423-5-fengchengwen@huawei.com> In-Reply-To: <20230302075012.32423-1-fengchengwen@huawei.com> References: <20230302075012.32423-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix kvargs callback prototype not clearly defined \| [0/9] fix kvargs callback prototype not clearly defined [1/9] kvargs: detailed definition of callback prototype [2/9] compressdev: fix segment fault when parse input args [3/9] compressdev: fix null name when parse input args [4/9] cryptodev: fix segment fault when parse input args [5/9] cryptodev: fix null name when parse input args [6/9] net/hns3: fix segment fault when parse runtime config [7/9] net/virtio: fix segment fault when parse devargs [8/9] dma/skeleton: fix segment fault when parse devargs [9/9] raw/skeleton: fix segment fault when parse devargs

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen March 2, 2023, 7:50 a.m. UTC

  The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'
(e.g. socket_id,max_nb_queue_pairs).

Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 lib/cryptodev/cryptodev_pmd.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Akhil Goyal March 2, 2023, 8:11 a.m. UTC | #1

> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
> 
> This patch fixes segment fault when parse input args with 'only keys'
> (e.g. socket_id,max_nb_queue_pairs).
> 
> Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

I would say, you can squash your 4/9 and 5/9 patch in a single commit.
As you are doing the same thing in both the patches.

fengchengwen March 2, 2023, 9:21 a.m. UTC | #2

On 2023/3/2 16:11, Akhil Goyal wrote:
>> The rte_kvargs_process() was used to parse KV pairs, it also supports
>> to parse 'only keys' (e.g. socket_id) type. And the callback function
>> parameter 'value' is NULL when parsed 'only keys'.
>>
>> This patch fixes segment fault when parse input args with 'only keys'
>> (e.g. socket_id,max_nb_queue_pairs).
>>
>> Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> I would say, you can squash your 4/9 and 5/9 patch in a single commit.
> As you are doing the same thing in both the patches.

The cause of the problem is the same but the symptom is different, so I split two commit.

It's okay to squash.

> .
>

diff mbox series

Patch

diff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c
index 77b269f312..4122000839 100644
--- a/lib/cryptodev/cryptodev_pmd.c
+++ b/lib/cryptodev/cryptodev_pmd.c
@@ -38,6 +38,10 @@  rte_cryptodev_pmd_parse_uint_arg(const char *key __rte_unused,
 {
 	int i;
 	char *end;
+
+	if (value == NULL || extra_args == NULL)
+		return -EINVAL;
+
 	errno = 0;
 
 	i = strtol(value, &end, 10);