mbox series

[0/9] fix kvargs callback prototype not clearly defined

Message ID 20230302075012.32423-1-fengchengwen@huawei.com (mailing list archive)
Headers
Series fix kvargs callback prototype not clearly defined |

Message

fengchengwen March 2, 2023, 7:50 a.m. UTC
  The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function 
parameter 'value' is NULL when parsed 'only keys'.

But where there is no detailed definition of 'value' maybe NULL. this 
leads to a lot of processing errors (some may cause segment errors). 
This patchset fixes some of them.

Chengwen Feng (9):
  kvargs: detailed definition of callback prototype
  compressdev: fix segment fault when parse input args
  compressdev: fix null name when parse input args
  cryptodev: fix segment fault when parse input args
  cryptodev: fix null name when parse input args
  net/hns3: fix segment fault when parse runtime config
  net/virtio: fix segment fault when parse devargs
  dma/skeleton: fix segment fault when parse devargs
  raw/skeleton: fix segment fault when parse devargs

 drivers/dma/skeleton/skeleton_dmadev.c |  8 +++++++-
 drivers/net/hns3/hns3_common.c         |  9 +++++++++
 drivers/net/virtio/virtio_ethdev.c     |  3 +++
 drivers/net/virtio/virtio_pci_ethdev.c |  3 +++
 drivers/raw/skeleton/skeleton_rawdev.c |  2 ++
 lib/compressdev/rte_compressdev_pmd.c  |  6 ++++++
 lib/cryptodev/cryptodev_pmd.c          |  7 +++++++
 lib/kvargs/rte_kvargs.h                | 14 +++++++++++++-
 8 files changed, 50 insertions(+), 2 deletions(-)
  

Comments

fengchengwen March 2, 2023, 9:17 a.m. UTC | #1
Sorry to resend, because the original v1 --cc-cmd failed.

On 2023/3/2 15:50, Chengwen Feng wrote:
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function 
> parameter 'value' is NULL when parsed 'only keys'.
> 
> But where there is no detailed definition of 'value' maybe NULL. this 
> leads to a lot of processing errors (some may cause segment errors). 
> This patchset fixes some of them.
> 
> Chengwen Feng (9):
>   kvargs: detailed definition of callback prototype
>   compressdev: fix segment fault when parse input args
>   compressdev: fix null name when parse input args
>   cryptodev: fix segment fault when parse input args
>   cryptodev: fix null name when parse input args
>   net/hns3: fix segment fault when parse runtime config
>   net/virtio: fix segment fault when parse devargs
>   dma/skeleton: fix segment fault when parse devargs
>   raw/skeleton: fix segment fault when parse devargs
> 
>  drivers/dma/skeleton/skeleton_dmadev.c |  8 +++++++-
>  drivers/net/hns3/hns3_common.c         |  9 +++++++++
>  drivers/net/virtio/virtio_ethdev.c     |  3 +++
>  drivers/net/virtio/virtio_pci_ethdev.c |  3 +++
>  drivers/raw/skeleton/skeleton_rawdev.c |  2 ++
>  lib/compressdev/rte_compressdev_pmd.c  |  6 ++++++
>  lib/cryptodev/cryptodev_pmd.c          |  7 +++++++
>  lib/kvargs/rte_kvargs.h                | 14 +++++++++++++-
>  8 files changed, 50 insertions(+), 2 deletions(-)
>
  
David Marchand March 9, 2023, 3:19 p.m. UTC | #2
On Thu, Mar 2, 2023 at 8:56 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
>
> But where there is no detailed definition of 'value' maybe NULL. this
> leads to a lot of processing errors (some may cause segment errors).
> This patchset fixes some of them.
>
> Chengwen Feng (9):
>   kvargs: detailed definition of callback prototype
>   compressdev: fix segment fault when parse input args
>   compressdev: fix null name when parse input args
>   cryptodev: fix segment fault when parse input args
>   cryptodev: fix null name when parse input args
>   net/hns3: fix segment fault when parse runtime config
>   net/virtio: fix segment fault when parse devargs
>   dma/skeleton: fix segment fault when parse devargs
>   raw/skeleton: fix segment fault when parse devargs
>
>  drivers/dma/skeleton/skeleton_dmadev.c |  8 +++++++-
>  drivers/net/hns3/hns3_common.c         |  9 +++++++++
>  drivers/net/virtio/virtio_ethdev.c     |  3 +++
>  drivers/net/virtio/virtio_pci_ethdev.c |  3 +++
>  drivers/raw/skeleton/skeleton_rawdev.c |  2 ++
>  lib/compressdev/rte_compressdev_pmd.c  |  6 ++++++
>  lib/cryptodev/cryptodev_pmd.c          |  7 +++++++
>  lib/kvargs/rte_kvargs.h                | 14 +++++++++++++-
>  8 files changed, 50 insertions(+), 2 deletions(-)

Series applied, thanks Chengwen.