diff mbox series

[21/21] net/ixgbe/base: update version

Message ID	20200612032410.20864-22-guinanx.sun@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: j5Ntk9UMvNfYHLjEskumtYHVRRRdyKP1kNIblCga26AASRo3+wXMuKmN4mjUTHd/01xvKQNY2Y 1q/0zsMWTLTg== IronPort-SDR: Xi26soBHdatW2h6ZZKFMlnVSp4f+PNgDlTaSQDMhezu32ErKfqqUOScfVnjCL7asE3u0gLwUDI Vi6hbFhQ+ZbA== From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Guinan Sun <guinanx.sun@intel.com> Date: Fri, 12 Jun 2020 03:24:10 +0000 Message-Id: <20200612032410.20864-22-guinanx.sun@intel.com> In-Reply-To: <20200612032410.20864-1-guinanx.sun@intel.com> References: <20200612032410.20864-1-guinanx.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 21/21] net/ixgbe/base: update version Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update ixgbe base code \| [00/21] update ixgbe base code [01/21] net/ixgbe/base: clear VFMBMEM and toggle VF's Tx queues [02/21] net/ixgbe/base: change in the condition for response HI [03/21] net/ixgbe/base: hange flow for "Apply Update" command [04/21] net/ixgbe/base: x550em 10G NIC driver issue [05/21] net/ixgbe/base: added API for NVM update [06/21] net/ixgbe/base: resolve infinite recursion on PCIe link down [07/21] net/ixgbe/base: added register definitions for NVM update [08/21] net/ixgbe/base: cleanup spelling mistakes in comments [09/21] net/ixgbe/base: remove whitespace in function comments [10/21] net/ixgbe/base: move increments after evaluations [11/21] net/ixgbe/base: modify loop accounting for retries [12/21] net/ixgbe/base: create dedicated func to restart auto nego [13/21] net/ixgbe/base: modify Klocwork hits for DDK 7.0 [14/21] net/ixgbe/base: add defines for min rollback revision fields [15/21] net/ixgbe/base: remove unnecessary log message FC autonego [16/21] net/ixgbe/base: initialize data field in struct buffer [17/21] net/ixgbe/base: improve log about autonego being disabled [18/21] net/ixgbe/base: ipv6 Mask for purpose FDIR VLAN Port Feature [19/21] net/ixgbe/base: remove default advertising for 2.5G and 5G [20/21] net/ixgbe/base: check Host Interface Return Status [21/21] net/ixgbe/base: update version

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/travis-robot	success	Travis build: passed
ci/Intel-compilation	success	Compilation OK

Commit Message

Guinan Sun June 12, 2020, 3:24 a.m. UTC

  Update base code version in readme.

Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/ixgbe/base/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit June 22, 2020, 12:01 p.m. UTC | #1

On 6/12/2020 4:24 AM, Guinan Sun wrote:
> Update base code version in readme.
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
>  drivers/net/ixgbe/base/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README
> index a48b14ed2..c8d6b39ac 100644
> --- a/drivers/net/ixgbe/base/README
> +++ b/drivers/net/ixgbe/base/README
> @@ -6,7 +6,7 @@ Intel® IXGBE driver
>  ===================
>  
>  This directory contains source code of FreeBSD ixgbe driver of version
> -cid-ixgbe.2018.08.28.tar.gz released by the team which develop
> +not-released-cid-ixgbe.2020.06.05.tar.gz released by the team which develop

What does 'not-released' mean?
Since this is to clarify the version of the base code, why not just
'cid-ixgbe.2020.06.05.tar.gz'?

>  basic drivers for any ixgbe NIC. The sub-directory of base/
>  contains the original source package.
>  This driver is valid for the product(s) listed below
>

Guinan Sun July 1, 2020, 6:27 a.m. UTC | #2

Hi Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 22, 2020 8:01 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 21/21] net/ixgbe/base: update version
> 
> On 6/12/2020 4:24 AM, Guinan Sun wrote:
> > Update base code version in readme.
> >
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> >  drivers/net/ixgbe/base/README | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/base/README
> > b/drivers/net/ixgbe/base/README index a48b14ed2..c8d6b39ac 100644
> > --- a/drivers/net/ixgbe/base/README
> > +++ b/drivers/net/ixgbe/base/README
> > @@ -6,7 +6,7 @@ Intel® IXGBE driver
> >  ===================
> >
> >  This directory contains source code of FreeBSD ixgbe driver of
> > version -cid-ixgbe.2018.08.28.tar.gz released by the team which
> > develop
> > +not-released-cid-ixgbe.2020.06.05.tar.gz released by the team which
> > +develop
> 
> What does 'not-released' mean?

not-released means they are drops of shared code to the DPDK team.

> Since this is to clarify the version of the base code, why not just 'cid-
> ixgbe.2020.06.05.tar.gz'?

The drop package is named like this, not our modification.

> 
> >  basic drivers for any ixgbe NIC. The sub-directory of base/  contains
> > the original source package.
> >  This driver is valid for the product(s) listed below
> >

diff mbox series

Patch

diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README
index a48b14ed2..c8d6b39ac 100644
--- a/drivers/net/ixgbe/base/README
+++ b/drivers/net/ixgbe/base/README
@@ -6,7 +6,7 @@  Intel® IXGBE driver
 ===================
 
 This directory contains source code of FreeBSD ixgbe driver of version
-cid-ixgbe.2018.08.28.tar.gz released by the team which develop
+not-released-cid-ixgbe.2020.06.05.tar.gz released by the team which develop
 basic drivers for any ixgbe NIC. The sub-directory of base/
 contains the original source package.
 This driver is valid for the product(s) listed below