diff mbox series

[17/21] net/ixgbe/base: improve log about autonego being disabled

Message ID 20200612032410.20864-18-guinanx.sun@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers show
Series update ixgbe base code | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Guinan Sun June 12, 2020, 3:24 a.m. UTC
On ESXi OS, when user disables auto negotiation, the following log
appears: "(unsupported) Flow control autoneg is disabled".
It is true that AN is disabled but it is not necessarily true that it is
not supported.

Signed-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_common.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit June 22, 2020, noon UTC | #1
On 6/12/2020 4:24 AM, Guinan Sun wrote:
> On ESXi OS, when user disables auto negotiation, the following log
> appears: "(unsupported) Flow control autoneg is disabled".

Is ESXi reference valid for the DPDK commit?

> It is true that AN is disabled but it is not necessarily true that it is
> not supported.
> 
> Signed-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>

<...>
Guinan Sun July 1, 2020, 5:19 a.m. UTC | #2
Hi  Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 22, 2020 8:01 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Chylkowski, JakubX <jakubx.chylkowski@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about
> autonego being disabled
> 
> On 6/12/2020 4:24 AM, Guinan Sun wrote:
> > On ESXi OS, when user disables auto negotiation, the following log
> > appears: "(unsupported) Flow control autoneg is disabled".
> 
> Is ESXi reference valid for the DPDK commit?

I think this is no problem, because there are a lot of commit information including'ESXi' in dpdk .
For example the following version:
{
	commit dfedf3e3f9d281fbe493cc98fd9ef82bec42fdec
	Author: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
	Date: Tue Jul 30 09:20:24 2019 +0000

	 net/mlx5: add workaround for VLAN in virtual machine
}

{
	commit 18c8e84d7726ad16bb81fdb7649e13202997cd41
	Author: Gautam Dawar <gdawar@solarflare.com>
	Date: Mon Jun 10 08:38:39 2019 +0100

	     net/sfc/base: support proxy auth operations for SR-IOV
}...

So there should be no correction.

> 
> > It is true that AN is disabled but it is not necessarily true that it
> > is not supported.
> >
> > Signed-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> 
> <...>
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index 4a3b48b39..bc9584ae0 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -3077,8 +3077,9 @@  void ixgbe_fc_autoneg(struct ixgbe_hw *hw)
 	 * - link is not up.
 	 */
 	if (hw->fc.disable_fc_autoneg) {
-		ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,
-			     "Flow control autoneg is disabled");
+		/* TODO: This should be just an informative log */
+		ERROR_REPORT1(IXGBE_ERROR_CAUTION,
+			      "Flow control autoneg is disabled");
 		goto out;
 	}