[14/21] net/ixgbe/base: add defines for min rollback revision fields

Message ID 20200612032410.20864-15-guinanx.sun@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series update ixgbe base code |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Guinan Sun June 12, 2020, 3:24 a.m. UTC
  Add defines for Minimum Rollback Revision fields as defined in SGVL.

Signed-off-by: Jacek Naczyk <jacek.naczyk@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_type.h | 11 +++++++++++
 1 file changed, 11 insertions(+)
  

Comments

Ferruh Yigit June 22, 2020, noon UTC | #1
On 6/12/2020 4:24 AM, Guinan Sun wrote:
> Add defines for Minimum Rollback Revision fields as defined in SGVL.

SGVL?

> 
> Signed-off-by: Jacek Naczyk <jacek.naczyk@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>

<...>
  
Guinan Sun July 1, 2020, 5:08 a.m. UTC | #2
Hi Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 22, 2020 8:00 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Naczyk, Jacek <jacek.naczyk@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 14/21] net/ixgbe/base: add defines for min
> rollback revision fields
> 
> On 6/12/2020 4:24 AM, Guinan Sun wrote:
> > Add defines for Minimum Rollback Revision fields as defined in SGVL.
> 
> SGVL?

Sorry, I don't know this, I will investigate later.
But this patch was removed in the latest drop package.
So patch V2 will remove this code.

> 
> >
> > Signed-off-by: Jacek Naczyk <jacek.naczyk@intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> 
> <...>
  

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h
index 9838e0643..cb5f62645 100644
--- a/drivers/net/ixgbe/base/ixgbe_type.h
+++ b/drivers/net/ixgbe/base/ixgbe_type.h
@@ -2350,6 +2350,17 @@  enum {
 #define IXGBE_ALT_MAC_ADDR_PTR		0x37
 #define IXGBE_FREE_SPACE_PTR		0X3E
 
+#if defined(PREBOOT_SUPPORT) || defined(QV_RELEASE)
+/* Minimum Rollback Revision offsets */
+#define IXGBE_MINRREV_PHY_ANALOG_LO	0x46
+#define IXGBE_MINRREV_PHY_ANALOG_HI	0x47
+#define IXGBE_MINRREV_OROM_LO		0x48
+#define IXGBE_MINRREV_OROM_HI		0x49
+#define IXGBE_MINRREV_FW_LO		0x4A
+#define IXGBE_MINRREV_FW_HI		0x4B
+#endif /* PREBOOT_SUPPORT || QV_RELEASE*/
+
+
 /* External Thermal Sensor Config */
 #define IXGBE_ETS_CFG			0x26
 #define IXGBE_ETS_LTHRES_DELTA_MASK	0x07C0