diff mbox series

[RFC] ethdev: make offload name API non-experimental

Message ID 20181019173532.19744-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [RFC] ethdev: make offload name API non-experimental |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Oct. 19, 2018, 5:35 p.m. UTC 
  The offload name functions are useful, but since they are
marked experimental they can not be used by upstream projects.
For example, VPP duplicates the same table in its code.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ethdev/rte_ethdev.c           |  4 ++--
 lib/librte_ethdev/rte_ethdev.h           | 10 ++--------
 lib/librte_ethdev/rte_ethdev_version.map |  9 +++++++--
 3 files changed, 11 insertions(+), 12 deletions(-)

Comments

Ferruh Yigit Oct. 22, 2018, 2:39 p.m. UTC | #1 
On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
> The offload name functions are useful, but since they are
> marked experimental they can not be used by upstream projects.
> For example, VPP duplicates the same table in its code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

+1, they have been added on 18.02, and I think we can remove experimental tag
for them now.
Ferruh Yigit Oct. 25, 2018, 10:27 a.m. UTC | #2 
On 10/22/2018 3:39 PM, Ferruh Yigit wrote:
> On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
>> The offload name functions are useful, but since they are
>> marked experimental they can not be used by upstream projects.
>> For example, VPP duplicates the same table in its code.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> +1, they have been added on 18.02, and I think we can remove experimental tag
> for them now.

Is there any objection to this, if not I am for getting change for rc1?
Ferruh Yigit Oct. 26, 2018, 2:47 p.m. UTC | #3 
On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
> The offload name functions are useful, but since they are
> marked experimental they can not be used by upstream projects.
> For example, VPP duplicates the same table in its code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

> +DPDK_18.11 {
> +	global:
> +
> +	rte_eth_dev_rx_offload_name;
> +	rte_eth_dev_tx_offload_name;
> +} DPDK_18.11;

DPDK_18.08, can be fixed while merging.
Ferruh Yigit Oct. 26, 2018, 3:04 p.m. UTC | #4 
On 10/26/2018 3:47 PM, Ferruh Yigit wrote:
> On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
>> The offload name functions are useful, but since they are
>> marked experimental they can not be used by upstream projects.
>> For example, VPP duplicates the same table in its code.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 21f1dfbe4f5a..beeaa0bd0850 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -983,7 +983,7 @@  rte_eth_speed_bitflag(uint32_t speed, int duplex)
 	}
 }
 
-const char * __rte_experimental
+const char *
 rte_eth_dev_rx_offload_name(uint64_t offload)
 {
 	const char *name = "UNKNOWN";
@@ -999,7 +999,7 @@  rte_eth_dev_rx_offload_name(uint64_t offload)
 	return name;
 }
 
-const char * __rte_experimental
+const char *
 rte_eth_dev_tx_offload_name(uint64_t offload)
 {
 	const char *name = "UNKNOWN";
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index fb40c89e01ba..5f88a2220139 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1465,9 +1465,6 @@  int rte_eth_dev_detach(uint16_t port_id, char *devname);
 uint32_t rte_eth_speed_bitflag(uint32_t speed, int duplex);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get DEV_RX_OFFLOAD_* flag name.
  *
  * @param offload
@@ -1475,12 +1472,9 @@  uint32_t rte_eth_speed_bitflag(uint32_t speed, int duplex);
  * @return
  *   Offload name or 'UNKNOWN' if the flag cannot be recognised.
  */
-const char * __rte_experimental rte_eth_dev_rx_offload_name(uint64_t offload);
+const char *rte_eth_dev_rx_offload_name(uint64_t offload);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get DEV_TX_OFFLOAD_* flag name.
  *
  * @param offload
@@ -1488,7 +1482,7 @@  const char * __rte_experimental rte_eth_dev_rx_offload_name(uint64_t offload);
  * @return
  *   Offload name or 'UNKNOWN' if the flag cannot be recognised.
  */
-const char * __rte_experimental rte_eth_dev_tx_offload_name(uint64_t offload);
+const char *rte_eth_dev_tx_offload_name(uint64_t offload);
 
 /**
  * Configure an Ethernet device.
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index dfa122c1a051..f1026b962501 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -220,6 +220,13 @@  DPDK_18.08 {
 
 } DPDK_18.05;
 
+DPDK_18.11 {
+	global:
+
+	rte_eth_dev_rx_offload_name;
+	rte_eth_dev_tx_offload_name;
+} DPDK_18.11;
+
 EXPERIMENTAL {
 	global:
 
@@ -236,8 +243,6 @@  EXPERIMENTAL {
 	rte_eth_dev_owner_set;
 	rte_eth_dev_owner_unset;
 	rte_eth_dev_rx_intr_ctl_q_get_fd;
-	rte_eth_dev_rx_offload_name;
-	rte_eth_dev_tx_offload_name;
 	rte_eth_switch_domain_alloc;
 	rte_eth_switch_domain_free;
 	rte_flow_conv;