From patchwork Fri Oct 19 17:35:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 47092 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1FC91B395; Fri, 19 Oct 2018 19:35:38 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 539E41B2B0 for ; Fri, 19 Oct 2018 19:35:37 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id p5-v6so1238939plq.8 for ; Fri, 19 Oct 2018 10:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CX5mJy+ZqmBgIHrRf5vr4Za2feQddamBpnXpLM95Fnk=; b=eEYoyGty6baqBHM7EVLtzvels20Oyp8tc3cihMi7pOnG3nKUeNnLTYGlsMY+BlslBQ 9znwkMZ3JkzblgORcGePcvRROatbTzvLsVeWpnESw7USUYCdDhr/U/Yg7VLyUjpopWgF NSSwGskuRE9DUJrViLK7NxXZFcZeWimNvtRgKE9jp2h+o6aVQXyrH/rkLIabWIFbWKFk pQuW5OtJo5Dvg/VvJ4XYP7iCIutP0cbnpNYVa212NPDr6mSg7uOcJgAC9QbL2gqUscnd DjHToryCjbKqNkzHtcxvcwjWQdVIrY3b4yR+UHzujihQnVgdEyTiKxUE0JbREiqdeMY2 gaVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CX5mJy+ZqmBgIHrRf5vr4Za2feQddamBpnXpLM95Fnk=; b=WmFU663Ww7hzL7/stRpDVQJtNiRfqgThlkk6qo0B31Uaq4TKrwmQWYZ/HWHDDDJWaV gxq2U9GecYsYHjZdK04uvs+rqVE0UlINIZiAXXhIDM50irrle7bVMVizLQYXa76MjaNF vKQZHrpCnhP0t+apR+FMTsCOirKx2eZNGE7ciqLSKruDTQL4qg6ODrSTNXXhlHTcYX0v R2d+xzaseqRym/xNKEkCf/ONyFr9TGYMbpxw14znpF3TqxUnVeXbzHt4HgZXGofqr6M1 Z1Wi7wbuY+LrxWqeUPsWGCfjdFDKMtUYnNzN8Xkeh4uPogpD01Z1evJ57x7753b13kqM itUA== X-Gm-Message-State: ABuFfojhePmt2XQJtfaIMLaKjTee4IGaVAf5QEm+q1rkqN/tmNEq9ZtC gxuxYg/dhqLiI68azU6T6zOp6p1elsE= X-Google-Smtp-Source: ACcGV615tqPpqB+5okTo0gcUntV/JFh0eC9JCLNtuYCoaNZfHAqv6ifY+6k/j0BdbOb88bMrZwr4zw== X-Received: by 2002:a17:902:860a:: with SMTP id f10-v6mr1952325plo.96.1539970536073; Fri, 19 Oct 2018 10:35:36 -0700 (PDT) Received: from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y24-v6sm27195708pfn.123.2018.10.19.10.35.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 10:35:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 19 Oct 2018 10:35:32 -0700 Message-Id: <20181019173532.19744-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Subject: [dpdk-dev] [RFC] ethdev: make offload name API non-experimental X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The offload name functions are useful, but since they are marked experimental they can not be used by upstream projects. For example, VPP duplicates the same table in its code. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.c | 4 ++-- lib/librte_ethdev/rte_ethdev.h | 10 ++-------- lib/librte_ethdev/rte_ethdev_version.map | 9 +++++++-- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 21f1dfbe4f5a..beeaa0bd0850 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -983,7 +983,7 @@ rte_eth_speed_bitflag(uint32_t speed, int duplex) } } -const char * __rte_experimental +const char * rte_eth_dev_rx_offload_name(uint64_t offload) { const char *name = "UNKNOWN"; @@ -999,7 +999,7 @@ rte_eth_dev_rx_offload_name(uint64_t offload) return name; } -const char * __rte_experimental +const char * rte_eth_dev_tx_offload_name(uint64_t offload) { const char *name = "UNKNOWN"; diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index fb40c89e01ba..5f88a2220139 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -1465,9 +1465,6 @@ int rte_eth_dev_detach(uint16_t port_id, char *devname); uint32_t rte_eth_speed_bitflag(uint32_t speed, int duplex); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get DEV_RX_OFFLOAD_* flag name. * * @param offload @@ -1475,12 +1472,9 @@ uint32_t rte_eth_speed_bitflag(uint32_t speed, int duplex); * @return * Offload name or 'UNKNOWN' if the flag cannot be recognised. */ -const char * __rte_experimental rte_eth_dev_rx_offload_name(uint64_t offload); +const char *rte_eth_dev_rx_offload_name(uint64_t offload); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get DEV_TX_OFFLOAD_* flag name. * * @param offload @@ -1488,7 +1482,7 @@ const char * __rte_experimental rte_eth_dev_rx_offload_name(uint64_t offload); * @return * Offload name or 'UNKNOWN' if the flag cannot be recognised. */ -const char * __rte_experimental rte_eth_dev_tx_offload_name(uint64_t offload); +const char *rte_eth_dev_tx_offload_name(uint64_t offload); /** * Configure an Ethernet device. diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index dfa122c1a051..f1026b962501 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -220,6 +220,13 @@ DPDK_18.08 { } DPDK_18.05; +DPDK_18.11 { + global: + + rte_eth_dev_rx_offload_name; + rte_eth_dev_tx_offload_name; +} DPDK_18.11; + EXPERIMENTAL { global: @@ -236,8 +243,6 @@ EXPERIMENTAL { rte_eth_dev_owner_set; rte_eth_dev_owner_unset; rte_eth_dev_rx_intr_ctl_q_get_fd; - rte_eth_dev_rx_offload_name; - rte_eth_dev_tx_offload_name; rte_eth_switch_domain_alloc; rte_eth_switch_domain_free; rte_flow_conv;