Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139428/?format=api
{ "id": 139428, "url": "http://patches.dpdk.org/api/patches/139428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240416153054.3216706-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240416153054.3216706-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240416153054.3216706-3-michaelba@nvidia.com", "date": "2024-04-16T15:30:52", "name": "[2/4] net/mlx5/hws: fix GENEVE option class partial mask", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": false, "hash": "a6cdaec3183d8388a8bd9296b32124540c178541", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240416153054.3216706-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 31758, "url": "http://patches.dpdk.org/api/series/31758/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31758", "date": "2024-04-16T15:30:53", "name": "net/mlx5: some unrelated fixes and improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/31758/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139428/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58CE143E83;\n\tTue, 16 Apr 2024 17:32:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C578C406BA;\n\tTue, 16 Apr 2024 17:31:54 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2066.outbound.protection.outlook.com [40.107.94.66])\n by mails.dpdk.org (Postfix) with ESMTP id 5034140695;\n Tue, 16 Apr 2024 17:31:51 +0200 (CEST)", "from SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35)\n by SA1PR12MB8164.namprd12.prod.outlook.com (2603:10b6:806:338::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr\n 2024 15:31:39 +0000", "from SJ5PEPF000001CD.namprd05.prod.outlook.com\n (2603:10b6:a03:330:cafe::25) by SJ0PR05CA0210.outlook.office365.com\n (2603:10b6:a03:330::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.20 via Frontend\n Transport; Tue, 16 Apr 2024 15:31:39 +0000", "from mail.nvidia.com (216.228.117.160) by\n SJ5PEPF000001CD.mail.protection.outlook.com (10.167.242.42) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7452.22 via Frontend Transport; Tue, 16 Apr 2024 15:31:39 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 16 Apr\n 2024 08:31:09 -0700", "from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 16 Apr\n 2024 08:31:09 -0700", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Tue, 16 Apr 2024 08:31:06 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ilergGZyRrZfK8UQkpCH18yVxt1cx3fZFA/xH3PuZGTskbGi0FREvJ6vo2JsFeVfEV9bKZLLS7wxBtyxp9GRnZLBOVj79FDyocv6npKs22kziXRcfWxER9v4DW327ouyVdxdP9dabu0Q5yKjqsX8Jf6Azlv0riAd0T53Rhxb5jKcd8ntZiep64uZw+0HmoDO45Ts4/LzaL66MLw2MtartgNBLkx1HR+nihDW8k20zTvno6FIC1WMeSxCiEGkYcAITXnSLYU3MvoxyXmU8gvYg8e/wsbqkQs6mTRbFN17IBWCTFjkSTQnOjdMBcPSCMXzwDlyrNyx0J5W0snw0Lueag==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=7hjI7w1ZJgCmhB3d3/x0G4czsU2iHBHmxYw1Q41cyYU=;\n b=NEFpiciTemXyKfzCdoHdkyXu1G5xrM0UpU66CmRcqCZ6akXmYbKJugnKRBLRtUAzIvMf90QgIDyLU5hu1m7MAjtgz4t5B7zZCxQhTyeyDEc9TUbjSKgq3wVlRchfbTjPPvlULx0FxmmTBs1APt1QpbRyY6iII4r/m2jM5+SrtqbEoTFWLDuB/8XPJj+HSfY4CHIiE7yE+VRNEIIqvpGSLIk1EQZHUzTkEtnco3rqLJgX6IS6oZZUL2wyO6BqPt+KY6nM0Q5UQRIImJcWdrAu8GiEU/pWjpzSmAkvKIGJ/sBozOjtFrvS9xmQ7iiwR6oLauuoDVH6HlahkATG+jpwIA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7hjI7w1ZJgCmhB3d3/x0G4czsU2iHBHmxYw1Q41cyYU=;\n b=jl1t+gT14i0Z0R4RwwHeMI6FJd1HRO2fDdjbdG2PfzFRI1MB948O+rewj4tmTgYi2Zt0RhunpKhBBC7+JEQABgzFiJ8WdsOoSGdP3Yvu061URkLyD9r6mC1cMEECH2qKP33eewuhJr6LDqAANXRAGCNudVKqn/pchXBj+YqtaQNpgN6VY6CLl1YKFFvfeWhfcO5Ayf3emz/J5g6wjwRmLiIDv+HjB0pcM1s31jB69YaMFzgeUZ+wQ/PKxKVbiaZxYbjKCxvPFZ9t2XNeHVPyVMCA/sEAp1H2uE0xxVKYH/IwJmoMcs4NkgN8h8i5G8GutwxGEUFFqYlJAjriU23VZQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>, <valex@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH 2/4] net/mlx5/hws: fix GENEVE option class partial mask", "Date": "Tue, 16 Apr 2024 18:30:52 +0300", "Message-ID": "<20240416153054.3216706-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240416153054.3216706-1-michaelba@nvidia.com>", "References": "<20240416153054.3216706-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ5PEPF000001CD:EE_|SA1PR12MB8164:EE_", "X-MS-Office365-Filtering-Correlation-Id": "507f3dbc-83ed-4455-79f5-08dc5e2a4f4a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n loOG4c2Eb40kpZKvmUWq7nQmH/zglB73RfIwU847zvBIbfLQ8Xi0puD1N1TGWOvHraXPKgXAu6WAry3PAUh9kpS5S+ZWyEIuqxxIj19sknOmLdkuCAOyNR2UXpO+YVxk3Wm0R6sL+MsOvZK3qGHZquuEeLShyqTjIi9Od6NBD/Eu6O/9lbPep+lg0DAKKIbsIVo4GgOCV1Jk4OpiH/JQ2lE0DDlS/RQeT6cR4C20N6X39zN3lxwtLCxlNdjpK31ogPJmO57ymmHVjp59a+IW5bg7/992KoRdrJhYDesB6WWxj+5xmwT2gCxO+l6KqS6uSOdgIrcCBvFvB2L52S6jSwXN5hbefMPhE6ghv0+e+h5Fu3CP8jnzoRAFqyXBZxJQnQTyaZjyfPdeA0NgzPELrFEWEcwMbAb63IING5sytoXx55VbP5jcHDbAnDjxZ+kyEuGqrxL3NcYFyZrIn6eTgltP5CBEa+tZ2pcKxnGkHQwERVgUD/JqgRLiXwmXPM50CXdnI3Q3OBXI9B+StDmTPdXEAbuCk9XoUHk8SFCM5lFceOPAUS0MlbLblgveQ0dCYmij4g7a0dp1Ui4Cixx5FGmRIlHbcdtrAgFpE6FLwhHAfkkCR0UZTS4aVvNok//rsw/goJm/7REXZvnxlz2GsYLq+gjb1AyyGNg5koY9GSXYDfoV9ceF48AcvZwgWsZn01Y9K39KfQOLpEYM/xYx/pSvU3An/brRjNBaD3EyzZLPmxphH9KcNgIkVrUMREM4", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Apr 2024 15:31:39.0436 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 507f3dbc-83ed-4455-79f5-08dc5e2a4f4a", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SJ5PEPF000001CD.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA1PR12MB8164", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When GENEVE option parser is configured, the class field has 3 optional\nmodes:\n1. ignored - ignore this field.\n2. fixed - this field is part of option identifier along with type\n\t field. In this mode, the exact value is provided in \"spec\"\n\t field during pattern template creation and mask must be 0xffff.\n3. matchable - class field isn't part of the identifier and only mask is\n\t provided in pattern template creation. The mask can be\n\t any value like all other fields.\n\nIn current implementation, when class mask isn't 0, pattern template\ncreation is failed for mask != 0xffff regardless to class mode.\n\nThis patch fixes this validation to be only when class mode is fixed.\n\nFixes: 8f8dad4289e0 (\"net/mlx5/hws: support GENEVE options matching\")\nCc: valex@nvidia.com\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nReviewed-by: Alex Vesker <valex@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_definer.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c\nindex 35a2ed2048..f1f544deab 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_definer.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c\n@@ -2500,11 +2500,6 @@ mlx5dr_definer_conv_item_geneve_opt(struct mlx5dr_definer_conv_data *cd,\n \t\tgoto out_not_supp;\n \t}\n \n-\tif (m->option_class && m->option_class != RTE_BE16(UINT16_MAX)) {\n-\t\tDR_LOG(ERR, \"Geneve option class has invalid mask\");\n-\t\tgoto out_not_supp;\n-\t}\n-\n \tret = mlx5_get_geneve_hl_data(cd->ctx,\n \t\t\t\t v->option_type,\n \t\t\t\t v->option_class,\n@@ -2517,6 +2512,11 @@ mlx5dr_definer_conv_item_geneve_opt(struct mlx5dr_definer_conv_data *cd,\n \t\tgoto out_not_supp;\n \t}\n \n+\tif (ok_bit_on_class && m->option_class != RTE_BE16(UINT16_MAX)) {\n+\t\tDR_LOG(ERR, \"Geneve option class has invalid mask\");\n+\t\tgoto out_not_supp;\n+\t}\n+\n \tif (!ok_bit_on_class && m->option_class) {\n \t\t/* DW0 is used, we will match type, class */\n \t\tif (!num_of_dws || hl_dws[0].dw_mask != UINT32_MAX) {\n", "prefixes": [ "2/4" ] }