diff mbox series

[v2,24/44] net/netvsc: fix segment fault when parse devargs

Message ID	20230320092110.37295-25-fengchengwen@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Long Li <longli@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com> CC: <dev@dpdk.org> Subject: [PATCH v2 24/44] net/netvsc: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:50 +0000 Message-ID: <20230320092110.37295-25-fengchengwen@huawei.com> In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix segment fault when parse args \| [v2,00/44] fix segment fault when parse args [v2,01/44] app/pdump: fix segment fault when parse args [v2,02/44] ethdev: fix segment fault when parse args [v2,03/44] net/memif: fix segment fault when parse devargs [v2,04/44] net/pcap: fix segment fault when parse devargs [v2,05/44] net/ring: fix segment fault when parse devargs [v2,06/44] net/sfc: fix segment fault when parse devargs [v2,07/44] net/af_xdp: fix segment fault when parse devargs [v2,08/44] net/ark: fix segment fault when parse devargs [v2,09/44] net/cnxk: fix segment fault when parse devargs [v2,10/44] net/cxgbe: fix segment fault when parse devargs [v2,11/44] net/dpaa2: fix segment fault when parse devargs [v2,12/44] net/ena: fix segment fault when parse devargs [v2,13/44] net/enic: fix segment fault when parse devargs [v2,14/44] net/fm10k: fix segment fault when parse devargs [v2,15/44] net/i40e: fix segment fault when parse devargs [v2,16/44] net/iavf: fix segment fault when parse devargs [v2,17/44] net/ice: fix segment fault when parse devargs [v2,18/44] net/idpf: fix segment fault when parse devargs [v2,19/44] net/ionic: fix segment fault when parse devargs [v2,20/44] net/mana: fix segment fault when parse devargs [v2,21/44] net/mlx4: fix segment fault when parse devargs [v2,22/44] net/mvneta: fix segment fault when parse devargs [v2,23/44] net/mvpp2: fix segment fault when parse devargs [v2,24/44] net/netvsc: fix segment fault when parse devargs [v2,25/44] net/octeontx: fix segment fault when parse devargs [v2,26/44] net/pfe: fix segment fault when parse devargs [v2,27/44] net/qede: fix segment fault when parse devargs [v2,28/44] baseband/la12xx: fix segment fault when parse devargs [v2,29/44] bus/pci: fix segment fault when parse args [v2,30/44] common/mlx5: fix segment fault when parse devargs [v2,31/44] crypto/cnxk: fix segment fault when parse devargs [v2,32/44] crypto/dpaa_sec: fix segment fault when parse devargs [v2,33/44] crypto/dpaa2_sec: fix segment fault when parse devargs [v2,34/44] crypto/mvsam: fix segment fault when parse devargs [v2,35/44] crypto/scheduler: fix segment fault when parse devargs [v2,36/44] dma/dpaa2: fix segment fault when parse devargs [v2,37/44] event/cnxk: fix segment fault when parse devargs [v2,38/44] event/dlb2: fix segment fault when parse devargs [v2,39/44] event/dpaa: fix segment fault when parse devargs [v2,40/44] event/octeontx: fix segment fault when parse devargs [v2,41/44] event/opdl: fix segment fault when parse devargs [v2,42/44] event/sw: fix segment fault when parse devargs [v2,43/44] mempool/cnxk: fix segment fault when parse devargs [v2,44/44] raw/cnxk_gpio: fix segment fault when parse devargs

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen March 20, 2023, 9:20 a.m. UTC

  The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'.

Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/net/netvsc/hn_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Long Li March 21, 2023, 10:20 p.m. UTC | #1

> Subject: [PATCH v2 24/44] net/netvsc: fix segment fault when parse devargs
> 
> The rte_kvargs_process() was used to parse KV pairs, it also supports to parse
> 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is
> NULL when parsed 'only keys'.
> 
> This patch fixes segment fault when parse input args with 'only keys'.
> 
> Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>

Thank you.

Acked-by: Long Li <longli@microsoft.com>

> ---
>  drivers/net/netvsc/hn_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index d0bbc0a4c0..e13eb03176 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -157,6 +157,9 @@ static int hn_set_parameter(const char *key, const
> char *value, void *opaque)
>  	char *endp = NULL;
>  	unsigned long v;
> 
> +	if (value == NULL)
> +		return -EINVAL;
> +
>  	v = strtoul(value, &endp, 0);
>  	if (*value == '\0' || *endp != '\0') {
>  		PMD_DRV_LOG(ERR, "invalid parameter %s=%s", key, value);
> --
> 2.17.1

Stephen Hemminger July 4, 2023, 3:02 a.m. UTC | #2

On Mon, 20 Mar 2023 09:20:50 +0000
Chengwen Feng <fengchengwen@huawei.com> wrote:

> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
> 
> This patch fixes segment fault when parse input args with 'only keys'.
> 
> Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

diff mbox series

Patch

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index d0bbc0a4c0..e13eb03176 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -157,6 +157,9 @@  static int hn_set_parameter(const char *key, const char *value, void *opaque)
 	char *endp = NULL;
 	unsigned long v;
 
+	if (value == NULL)
+		return -EINVAL;
+
 	v = strtoul(value, &endp, 0);
 	if (*value == '\0' || *endp != '\0') {
 		PMD_DRV_LOG(ERR, "invalid parameter %s=%s", key, value);