diff mbox series

[v2,15/44] net/i40e: fix segment fault when parse devargs

Message ID	20230320092110.37295-16-fengchengwen@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Yuying Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, John McNamara <john.mcnamara@intel.com>, Zhe Tao <zhe.tao@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Xiaolong Ye <xiaolong.ye@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Alvin Zhang <alvinx.zhang@intel.com>, Wei Dai <wei.dai@intel.com> CC: <dev@dpdk.org> Subject: [PATCH v2 15/44] net/i40e: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:41 +0000 Message-ID: <20230320092110.37295-16-fengchengwen@huawei.com> In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix segment fault when parse args \| [v2,00/44] fix segment fault when parse args [v2,01/44] app/pdump: fix segment fault when parse args [v2,02/44] ethdev: fix segment fault when parse args [v2,03/44] net/memif: fix segment fault when parse devargs [v2,04/44] net/pcap: fix segment fault when parse devargs [v2,05/44] net/ring: fix segment fault when parse devargs [v2,06/44] net/sfc: fix segment fault when parse devargs [v2,07/44] net/af_xdp: fix segment fault when parse devargs [v2,08/44] net/ark: fix segment fault when parse devargs [v2,09/44] net/cnxk: fix segment fault when parse devargs [v2,10/44] net/cxgbe: fix segment fault when parse devargs [v2,11/44] net/dpaa2: fix segment fault when parse devargs [v2,12/44] net/ena: fix segment fault when parse devargs [v2,13/44] net/enic: fix segment fault when parse devargs [v2,14/44] net/fm10k: fix segment fault when parse devargs [v2,15/44] net/i40e: fix segment fault when parse devargs [v2,16/44] net/iavf: fix segment fault when parse devargs [v2,17/44] net/ice: fix segment fault when parse devargs [v2,18/44] net/idpf: fix segment fault when parse devargs [v2,19/44] net/ionic: fix segment fault when parse devargs [v2,20/44] net/mana: fix segment fault when parse devargs [v2,21/44] net/mlx4: fix segment fault when parse devargs [v2,22/44] net/mvneta: fix segment fault when parse devargs [v2,23/44] net/mvpp2: fix segment fault when parse devargs [v2,24/44] net/netvsc: fix segment fault when parse devargs [v2,25/44] net/octeontx: fix segment fault when parse devargs [v2,26/44] net/pfe: fix segment fault when parse devargs [v2,27/44] net/qede: fix segment fault when parse devargs [v2,28/44] baseband/la12xx: fix segment fault when parse devargs [v2,29/44] bus/pci: fix segment fault when parse args [v2,30/44] common/mlx5: fix segment fault when parse devargs [v2,31/44] crypto/cnxk: fix segment fault when parse devargs [v2,32/44] crypto/dpaa_sec: fix segment fault when parse devargs [v2,33/44] crypto/dpaa2_sec: fix segment fault when parse devargs [v2,34/44] crypto/mvsam: fix segment fault when parse devargs [v2,35/44] crypto/scheduler: fix segment fault when parse devargs [v2,36/44] dma/dpaa2: fix segment fault when parse devargs [v2,37/44] event/cnxk: fix segment fault when parse devargs [v2,38/44] event/dlb2: fix segment fault when parse devargs [v2,39/44] event/dpaa: fix segment fault when parse devargs [v2,40/44] event/octeontx: fix segment fault when parse devargs [v2,41/44] event/opdl: fix segment fault when parse devargs [v2,42/44] event/sw: fix segment fault when parse devargs [v2,43/44] mempool/cnxk: fix segment fault when parse devargs [v2,44/44] raw/cnxk_gpio: fix segment fault when parse devargs

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen March 20, 2023, 9:20 a.m. UTC

  The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'.

Fixes: 79f2248219c0 ("net/i40e: add floating VEB option")
Fixes: cfdfca493cae ("net/i40e: fix multiple driver support")
Fixes: 56270b4208ab ("net/i40e: limit the number of VF messages")
Fixes: ee653bd80044 ("net/i40e: determine number of queues per VF at run time")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/net/i40e/i40e_ethdev.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 371f42233e..1338b9b92d 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -829,6 +829,9 @@  floating_veb_list_handler(__rte_unused const char *key,
 	int min, max;
 	bool *vf_floating_veb = opaque;
 
+	if (floating_veb_value == NULL)
+		return -EINVAL;
+
 	while (isblank(*floating_veb_value))
 		floating_veb_value++;
 
@@ -921,6 +924,9 @@  i40e_check_floating_handler(__rte_unused const char *key,
 			    const char *value,
 			    __rte_unused void *opaque)
 {
+	if (value == NULL)
+		return -EINVAL;
+
 	if (strcmp(value, "1"))
 		return -1;
 
@@ -1258,6 +1264,9 @@  i40e_parse_multi_drv_handler(__rte_unused const char *key,
 
 	pf = (struct i40e_pf *)opaque;
 
+	if (value == NULL)
+		return -EINVAL;
+
 	errno = 0;
 	support_multi_driver = strtoul(value, &end, 10);
 	if (errno != 0 || end == value || *end != 0) {
@@ -1347,6 +1356,9 @@  read_vf_msg_config(__rte_unused const char *key,
 {
 	struct i40e_vf_msg_cfg *cfg = opaque;
 
+	if (value == NULL)
+		return -EINVAL;
+
 	if (sscanf(value, "%u@%u:%u", &cfg->max_msg, &cfg->period,
 			&cfg->ignore_second) != 3) {
 		memset(cfg, 0, sizeof(*cfg));
@@ -4693,6 +4705,9 @@  static int i40e_pf_parse_vf_queue_number_handler(const char *key,
 	pf = (struct i40e_pf *)opaque;
 	RTE_SET_USED(key);
 
+	if (value == NULL)
+		return -EINVAL;
+
 	errno = 0;
 	num = strtoul(value, &end, 0);
 	if (errno != 0 || end == value || *end != 0) {