Message ID | 20230320092110.37295-26-fengchengwen@huawei.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90C9B427E0; Mon, 20 Mar 2023 10:30:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EE5040A7F; Mon, 20 Mar 2023 10:28:36 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 95CDE42C76 for <dev@dpdk.org>; Mon, 20 Mar 2023 10:28:11 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Pg8TZ62w6z17MZc; Mon, 20 Mar 2023 17:25:06 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 17:28:10 +0800 From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Harman Kalra <hkalra@marvell.com>, Santosh Shukla <santosh.shukla@caviumnetworks.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com> CC: <dev@dpdk.org> Subject: [PATCH v2 25/44] net/octeontx: fix segment fault when parse devargs Date: Mon, 20 Mar 2023 09:20:51 +0000 Message-ID: <20230320092110.37295-26-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230320092110.37295-1-fengchengwen@huawei.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
fix segment fault when parse args
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
fengchengwen
March 20, 2023, 9:20 a.m. UTC
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi, Thanks for fixing the seg fault. Acked-by: Harman Kalra <hkalra@marvell.com> Thanks Harman > -----Original Message----- > From: Chengwen Feng <fengchengwen@huawei.com> > Sent: Monday, March 20, 2023 2:51 PM > To: thomas@monjalon.net; ferruh.yigit@amd.com; Harman Kalra > <hkalra@marvell.com>; Santosh Shukla > <santosh.shukla@caviumnetworks.com>; Jerin Jacob > <jerin.jacob@caviumnetworks.com> > Cc: dev@dpdk.org > Subject: [EXT] [PATCH v2 25/44] net/octeontx: fix segment fault when parse > devargs > > External Email > > ---------------------------------------------------------------------- > The rte_kvargs_process() was used to parse KV pairs, it also supports to > parse 'only keys' (e.g. socket_id) type. And the callback function parameter > 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args with 'only keys'. > > Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> > --- > drivers/net/octeontx/octeontx_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/octeontx/octeontx_ethdev.c > b/drivers/net/octeontx/octeontx_ethdev.c > index d52a3e73d5..d11f359c7b 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -70,6 +70,9 @@ parse_integer_arg(const char *key __rte_unused, { > int *i = (int *)extra_args; > > + if (value == NULL) > + return -EINVAL; > + > *i = atoi(value); > if (*i < 0) { > octeontx_log_err("argument has to be positive."); > -- > 2.17.1
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index d52a3e73d5..d11f359c7b 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -70,6 +70,9 @@ parse_integer_arg(const char *key __rte_unused, { int *i = (int *)extra_args; + if (value == NULL) + return -EINVAL; + *i = atoi(value); if (*i < 0) { octeontx_log_err("argument has to be positive.");