test: drop 'alarm_autotest' and 'cycles_autotest' from test suite
Checks
Commit Message
The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
system having very accurate and precise timing. On systems where the timing
isn't as rigid, or the load is particularly high, these tests are unreliable
since the wake latency from the scheduler can be high enough to miss the
timing window.
Remove these tests from the test suites. Maybe it's useful for these
tests to be present as a diagnostics tool, but for normal unit testing,
they don't provide much value. They have falsely flagged patches as
FAIL on various infrastructures.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
app/test/meson.build | 2 --
1 file changed, 2 deletions(-)
Comments
25/05/2021 02:16, Aaron Conole:
> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
> system having very accurate and precise timing. On systems where the timing
> isn't as rigid, or the load is particularly high, these tests are unreliable
> since the wake latency from the scheduler can be high enough to miss the
> timing window.
>
> Remove these tests from the test suites. Maybe it's useful for these
> tests to be present as a diagnostics tool, but for normal unit testing,
> they don't provide much value. They have falsely flagged patches as
> FAIL on various infrastructures.
Are sure of the value keeping the source code?
Thomas Monjalon <thomas@monjalon.net> writes:
> 25/05/2021 02:16, Aaron Conole:
>> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
>> system having very accurate and precise timing. On systems where the timing
>> isn't as rigid, or the load is particularly high, these tests are unreliable
>> since the wake latency from the scheduler can be high enough to miss the
>> timing window.
>>
>> Remove these tests from the test suites. Maybe it's useful for these
>> tests to be present as a diagnostics tool, but for normal unit testing,
>> they don't provide much value. They have falsely flagged patches as
>> FAIL on various infrastructures.
>
> Are sure of the value keeping the source code?
Okay, I think it's fine to remove it as well.
I will submit v2
@@ -185,14 +185,12 @@ test_deps = [
# to indicate whether it can run in no-huge mode.
fast_tests = [
['acl_autotest', true],
- ['alarm_autotest', false],
['atomic_autotest', false],
['bitops_autotest', true],
['byteorder_autotest', true],
['cmdline_autotest', true],
['common_autotest', true],
['cpuflags_autotest', true],
- ['cycles_autotest', true],
['debug_autotest', true],
['eal_flags_c_opt_autotest', false],
['eal_flags_main_opt_autotest', false],