From patchwork Tue May 25 00:16:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 93429 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0EF4A0547; Tue, 25 May 2021 02:16:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40CAF406A3; Tue, 25 May 2021 02:16:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A50A4003F for ; Tue, 25 May 2021 02:16:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621901815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=TfKHWWwAuJ7CIYnVnLLZgWHLTw9Yn/bFJBh0d+fYY5I=; b=fZe3MY/9TwZN1Tj8/XFWzViz85Dib4YgaI51+x0Sf/HZbQqLWvDFGijGrdtLp/g2YIZxTd zlHuqlJjuQn6OpE7E1EbjvQIBXO0rZgQ/blBbtua4U2DsebR9fz/mTnEsGJ/XKrpO6u5oM nN7BKg08RNoxXEfzh1yxQSMmGFXpRJ8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-skVFKisyOy65ZFsKUm4UNQ-1; Mon, 24 May 2021 20:16:53 -0400 X-MC-Unique: skVFKisyOy65ZFsKUm4UNQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 363C983DCAE; Tue, 25 May 2021 00:16:52 +0000 (UTC) Received: from RHTPC1VM0NT (ovpn-118-46.rdu2.redhat.com [10.10.118.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD03A10023B5; Tue, 25 May 2021 00:16:47 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: David Marchand , ci@dpdk.org, Michael Santana , Ilya Maximets Date: Mon, 24 May 2021 20:16:46 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] test: drop 'alarm_autotest' and 'cycles_autotest' from test suite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying system having very accurate and precise timing. On systems where the timing isn't as rigid, or the load is particularly high, these tests are unreliable since the wake latency from the scheduler can be high enough to miss the timing window. Remove these tests from the test suites. Maybe it's useful for these tests to be present as a diagnostics tool, but for normal unit testing, they don't provide much value. They have falsely flagged patches as FAIL on various infrastructures. Signed-off-by: Aaron Conole --- app/test/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 08c82d3d23..8dec48e81c 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -185,14 +185,12 @@ test_deps = [ # to indicate whether it can run in no-huge mode. fast_tests = [ ['acl_autotest', true], - ['alarm_autotest', false], ['atomic_autotest', false], ['bitops_autotest', true], ['byteorder_autotest', true], ['cmdline_autotest', true], ['common_autotest', true], ['cpuflags_autotest', true], - ['cycles_autotest', true], ['debug_autotest', true], ['eal_flags_c_opt_autotest', false], ['eal_flags_main_opt_autotest', false],