Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93247/?format=api
{ "id": 93247, "url": "https://patches.dpdk.org/api/patches/93247/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210513080515.10644-1-suanmingm@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210513080515.10644-1-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210513080515.10644-1-suanmingm@nvidia.com", "date": "2021-05-13T08:05:15", "name": "net/mlx5: fix counter offset detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bc30c713985932bdf4d30462710bfe2f4b3ff8c6", "submitter": { "id": 1887, "url": "https://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210513080515.10644-1-suanmingm@nvidia.com/mbox/", "series": [ { "id": 16979, "url": "https://patches.dpdk.org/api/series/16979/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16979", "date": "2021-05-13T08:05:15", "name": "net/mlx5: fix counter offset detection", "version": 1, "mbox": "https://patches.dpdk.org/series/16979/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93247/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E320BA0A0C;\n\tThu, 13 May 2021 10:05:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6C0A24067E;\n\tThu, 13 May 2021 10:05:34 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45])\n by mails.dpdk.org (Postfix) with ESMTP id E65F44003F;\n Thu, 13 May 2021 10:05:33 +0200 (CEST)", "from DM3PR14CA0144.namprd14.prod.outlook.com (2603:10b6:0:53::28) by\n MWHPR12MB1247.namprd12.prod.outlook.com (2603:10b6:300:10::7) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4129.25; Thu, 13 May 2021 08:05:32 +0000", "from DM6NAM11FT045.eop-nam11.prod.protection.outlook.com\n (2603:10b6:0:53:cafe::7c) by DM3PR14CA0144.outlook.office365.com\n (2603:10b6:0:53::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend\n Transport; Thu, 13 May 2021 08:05:32 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT045.mail.protection.outlook.com (10.13.173.123) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4129.25 via Frontend Transport; Thu, 13 May 2021 08:05:32 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 13 May\n 2021 08:05:30 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dPAAVHguF31K8iw6a9Rsj12iytT4K7Rc6CBg6QjUA1glxPz75FpGTSarI6hBBVDqLFbhBCanzyX8Zy20ZEopli1xk2jT15eCzrsBJZYgwLSur6qpitDBBVfEnAlSAl+v4C4Osq8M10fKLZsb+jNYVGwqG0jUfHYCZBLsDfbdufDdXNq0UuJ4gUS77QO8COCDsNeqRUYH1JZT1MrY/PJJqXUdVP7g6eAtLPDmOUynwZswFVLqUIXKG5Lmw4LiJ9EqTj+4faLE+GPAtWXkHRSuat3Bu/nB5tKAxkWzdKrfP+G2KopeR0jkvKHcQPVhkxakaRbY8Cq9rjiqsYN4y3odrA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=R9Fkh0vpK4btUd1CaQCi7h9HHlL9zjxvBjaxwo3BcYs=;\n b=W/v0YhR+fBn3sai86qfXdxEyiXl5FYJIGgf+wj7cxgK/5dJ2DrMnyYczyrhqT8+00QYwLjfxznWDK0imhT30aabRYXFbi7UWuIRpLwEERgDsJFb9G7eJXa7F64oqwEYIVPuRAaCh3YDCcqCxDeN6bdIoAZKGG17RI9Ea46xigSOI+y7c3zFf3I1RmtigF//DjQVGau6qAA4e3BGadAvE0QE5o7uKgiRTEw7ZQ8BoHQXtMr57T9jgYf5bYdILTS/Pfvt4cNkljykbME/HZaMqZFVm6+cKC4ZSc14cD1A95/FtS4Yhe0oXrSI1CVmsY8bI4chhBd5RIdSdkIPkTBwxjQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=R9Fkh0vpK4btUd1CaQCi7h9HHlL9zjxvBjaxwo3BcYs=;\n b=CD6g5Aps1s4a4PYT9TD5rIsBb3hBad/HbxReDClVS04cq5lrEDuOIfEGbKLECWfZqHerR2rVJxkidwr0hja0Hjj03Z5ynNsVktwGHVEjBCwPMHNnGWQiUtiKOf01or4f8xtwI3x/VxC+EnSRe+AWZhKmiIoW0Pfie/LTNWq0ThHVKCnLE9QIU0PUUrPWkzKx+wuMNLVfRTOGpb1nC6dTgjpHfYe12RTlrOL7ZOkiLodmFqp4dwf04XLB7dC4ec5R7wMXnR6LFZtVWs2sogRAE8lxfmuYRrfDpUHyME/+Fh/xOLZYtVRjYP8iuH9JercHPNcoX7ecpSBmMNQDOw5TzA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<rasland@nvidia.com>, <dev@dpdk.org>, <stable@dpdk.org>", "Date": "Thu, 13 May 2021 11:05:15 +0300", "Message-ID": "<20210513080515.10644-1-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "a93e8a97-23c6-4643-92eb-08d915e5e188", "X-MS-TrafficTypeDiagnostic": "MWHPR12MB1247:", "X-Microsoft-Antispam-PRVS": "\n <MWHPR12MB1247BEE6C3C17EC819A4316AC1519@MWHPR12MB1247.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7691;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ckwMLMKLw8e+nNxvlyGC3K3irzNPhqSuIb87BSNQNMYaEPpN89V4fn9skKEFuorJK3NX+0587UFCJGujCXRYFi6FIg4Z31bC2/xErbq46n72p7ttcbKQ+uU5dzUsoeEDw19XYDMwKc6UpA06eSuju7xdI6wXFVjqN2/YkX2VLDJ7jej3UK4N7g85xrA6xiiy4VR/5fdRu00pW30ilf3XlrCWUUoZvdjLK3OKM4Kg83aGdStyRrfwEUqbRiSNynovzF1UqKPMiVEP1e2wLHLKvpnasEJxHz5E6epxkraUwTnTT6iz7U7Ds65jnmFxHYo6kLR9diPBoapQescjDeAe3MDZaUjN3E+IPTH1hO6k9tYtpGwGzph5qxF0PWGVkMYA9vKhxVcjMu9unwLCpAAWX0xbyrKWblUupEJ4hUY4R7uMHWNEbkkvW5sLqgvDmi9Y09P9wZJE2jwwJTHDp8LawXuxrxttdHcFE4NXxspai0Zida2uJPQaLu0QnLzxDJ3+SFB/YoN7MrdtiwxDZyjBTn0jXa/TpTmVmdFrTRu191y2vXD4px2tfPlz4Ge/Q/6ABJ6nSdFP33pB49qiq3m4xHfBYbmrRJivYlo9xdWboLFUEeKuEeQtnqjWBjEoea0fBirJxwDTt/CfVar6igX3Yw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(136003)(346002)(39860400002)(396003)(376002)(36840700001)(46966006)(6666004)(47076005)(86362001)(54906003)(26005)(4326008)(186003)(356005)(6636002)(8676002)(70206006)(70586007)(16526019)(82310400003)(2906002)(5660300002)(7696005)(36906005)(2616005)(426003)(36756003)(450100002)(8936002)(1076003)(36860700001)(336012)(110136005)(55016002)(478600001)(83380400001)(7636003)(82740400003)(6286002)(316002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 May 2021 08:05:32.1346 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a93e8a97-23c6-4643-92eb-08d915e5e188", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT045.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR12MB1247", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix counter offset detection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the counter offset support is discovered by creating the\nrule with invalid offset counter and drop action in root table. If\nthe rule creation fails with EINVAL errno, that mean counter offset\nis not supported in root table.\n\nHowever, drop action may not be supported in some rdma-core version\nin root table. In this case, the discover code will not work properly.\n\nThis commits changes flow attribute to egress. That removes all the\nextra fate actions in the flow to avoid any unsupported fate actions\nmake the discover code fail time to time.\n\nFixes: 994829e695c0 (\"net/mlx5: remove single counter container\")\nCc: stable@dpdk.org\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 7fc7efbc5c..71d9f88a95 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -16081,7 +16081,7 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev)\n \t\t.size = sizeof(value.buf),\n \t};\n \tstruct mlx5dv_flow_matcher_attr dv_attr = {\n-\t\t.type = IBV_FLOW_ATTR_NORMAL,\n+\t\t.type = IBV_FLOW_ATTR_NORMAL | IBV_FLOW_ATTR_FLAGS_EGRESS,\n \t\t.priority = 0,\n \t\t.match_criteria_enable = 0,\n \t\t.match_mask = (void *)&mask,\n@@ -16093,7 +16093,7 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev)\n \tvoid *flow = NULL;\n \tint ret = -1;\n \n-\ttbl = flow_dv_tbl_resource_get(dev, 0, 0, 0, false, NULL,\n+\ttbl = flow_dv_tbl_resource_get(dev, 0, 1, 0, false, NULL,\n \t\t\t\t\t0, 0, 0, NULL);\n \tif (!tbl)\n \t\tgoto err;\n@@ -16104,14 +16104,12 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev)\n \t\t\t\t\t\t &actions[0]);\n \tif (ret)\n \t\tgoto err;\n-\tactions[1] = sh->dr_drop_action ? sh->dr_drop_action :\n-\t\t\t\t\t priv->drop_queue.hrxq->action;\n \tdv_attr.match_criteria_enable = flow_dv_matcher_enable(mask.buf);\n \tret = mlx5_flow_os_create_flow_matcher(sh->ctx, &dv_attr, tbl->obj,\n \t\t\t\t\t &matcher);\n \tif (ret)\n \t\tgoto err;\n-\tret = mlx5_flow_os_create_flow(matcher, (void *)&value, 2,\n+\tret = mlx5_flow_os_create_flow(matcher, (void *)&value, 1,\n \t\t\t\t actions, &flow);\n err:\n \t/*\n", "prefixes": [] }