Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86832/?format=api
{ "id": 86832, "url": "https://patches.dpdk.org/api/patches/86832/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-13-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118203508.1332-13-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118203508.1332-13-aboyer@pensando.io", "date": "2021-01-18T20:35:07", "name": "[12/13] net/ionic: fix up function attribute tags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "41b3b32b90d90e83a2b6caed138f6a5c4aacbc37", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-13-aboyer@pensando.io/mbox/", "series": [ { "id": 14820, "url": "https://patches.dpdk.org/api/series/14820/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14820", "date": "2021-01-18T20:34:55", "name": "net/ionic: fixes and optimizations", "version": 1, "mbox": "https://patches.dpdk.org/series/14820/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86832/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86832/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55547A0A03;\n\tMon, 18 Jan 2021 21:37:00 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 61244140EBB;\n\tMon, 18 Jan 2021 21:35:57 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id AFCB8140E9B\n for <dev@dpdk.org>; Mon, 18 Jan 2021 21:35:55 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id e9so5087501plh.3\n for <dev@dpdk.org>; Mon, 18 Jan 2021 12:35:55 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id g201sm795160pfb.81.2021.01.18.12.35.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Jan 2021 12:35:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=V6ykGXdrJ6gcdGEWPZ8B3JYsrZUr4Mk4WKAUKxsoTc4=;\n b=na26uLfuE5oeX9YnQHboqQX8F+gRzqfeHSgEhrNZQ6TMWXg+6pmmr2BA/6tuu/KVW/\n 8yYSIGF+rME5rgRCJpqR0dEfARkvX1dD+PUsrdo8gUyhsUNWDkJiRGdK+cYqM/N/gk+G\n +v4PP/isTGwJyiVrGR4iIIo2AZywGf621Jv/h4+vxAGiZmCF8B57tJARZWHU6LV9MzBy\n F/gislNUVooZq7Kj/Q/JigH01coKcZwTn+E58PZjmWf/hLq9GFpD8l/enrylOkeloZx7\n UlgktVzKOo1ABMnyk8qp50DJNYtIDAPAQOLNBjR74WcbgWr74vycUFhDx2zd6MdR6YdH\n Kizw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=V6ykGXdrJ6gcdGEWPZ8B3JYsrZUr4Mk4WKAUKxsoTc4=;\n b=exBvlQpOYsOB91GFRg4NOWxarKYHU30i4eCibLbmsSmPwCiojvZpSR3kJp/xAnZfTi\n uBqgqubnGEGVzYc926JuYw4PrFnJM4oTKltDdvREHKTd7vXjnjnRpE/FKGQ0wVCpUhny\n qR36jmLSz9I/51u4t3UcVkvqrECmTyjA6CPRuenY8FbIf5HMNW73oAUScVlqmA61oumz\n D+WcGvkNBkJAGomXsHBqXzsVAMpJE+7iGAVTLU6/ILoQx2Ih/Lg9KJR7rR7VLY9fUGNn\n aAwA0yjlKX2OL0jxlI47fttfu4/NNr4ETL4P8JB/ygCPZ4mUHYEpE13+VKYKjdcXmr2F\n N+Zw==", "X-Gm-Message-State": "AOAM531z7lh4sZcLH7c50lS/8GSWoNUQtZldgyfKnFpcvy81JvT4UwQz\n EKIRtIbUL2umPTCsQ5fQrayVgFza/D2A5w==", "X-Google-Smtp-Source": "\n ABdhPJxtmRtXZnlv91gzJrnEexvLjTfRDGSbIdOlCJ06zt/c0W5vZJ2b6iWZuXpRUJZn+BVFLCHiJg==", "X-Received": "by 2002:a17:90a:5991:: with SMTP id\n l17mr1108582pji.187.1611002154815;\n Mon, 18 Jan 2021 12:35:54 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>, stable@dpdk.org", "Date": "Mon, 18 Jan 2021 12:35:07 -0800", "Message-Id": "<20210118203508.1332-13-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118203508.1332-1-aboyer@pensando.io>", "References": "<20210118203508.1332-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 12/13] net/ionic: fix up function attribute tags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "One function marked cold is in the hot path.\nMake sure to always inline hot path functions.\n\nFixes: a27d901331da (\"net/ionic: add Rx and Tx handling\")\nCc: stable@dpdk.org\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_rxtx.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 918701f463..f49a7cdb0e 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -67,7 +67,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED;\n }\n \n-static inline void __rte_cold\n+static __rte_always_inline void\n ionic_tx_flush(struct ionic_cq *cq)\n {\n \tstruct ionic_queue *q = cq->bound_q;\n@@ -448,7 +448,7 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \treturn 0;\n }\n \n-static int\n+static __rte_always_inline int\n ionic_tx(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \t\tbool not_xmit_more)\n {\n@@ -736,7 +736,7 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \treturn 0;\n }\n \n-static void\n+static __rte_always_inline void\n ionic_rx_clean(struct ionic_queue *q,\n \t\tuint32_t q_desc_index, uint32_t cq_desc_index,\n \t\tvoid *cb_arg, void *service_cb_arg)\n@@ -897,7 +897,7 @@ ionic_rx_recycle(struct ionic_queue *q, uint32_t q_desc_index,\n \tionic_q_post(q, true, ionic_rx_clean, mbuf);\n }\n \n-static int __rte_cold\n+static __rte_always_inline int\n ionic_rx_fill(struct ionic_qcq *rxq, uint32_t len)\n {\n \tstruct ionic_queue *q = &rxq->q;\n@@ -1013,7 +1013,7 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n \treturn 0;\n }\n \n-static inline void __rte_cold\n+static __rte_always_inline void\n ionic_rxq_service(struct ionic_cq *cq, uint32_t work_to_do,\n \t\tvoid *service_cb_arg)\n {\n", "prefixes": [ "12/13" ] }