From patchwork Mon Jan 18 20:35:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 86832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55547A0A03; Mon, 18 Jan 2021 21:37:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61244140EBB; Mon, 18 Jan 2021 21:35:57 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id AFCB8140E9B for ; Mon, 18 Jan 2021 21:35:55 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id e9so5087501plh.3 for ; Mon, 18 Jan 2021 12:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V6ykGXdrJ6gcdGEWPZ8B3JYsrZUr4Mk4WKAUKxsoTc4=; b=na26uLfuE5oeX9YnQHboqQX8F+gRzqfeHSgEhrNZQ6TMWXg+6pmmr2BA/6tuu/KVW/ 8yYSIGF+rME5rgRCJpqR0dEfARkvX1dD+PUsrdo8gUyhsUNWDkJiRGdK+cYqM/N/gk+G +v4PP/isTGwJyiVrGR4iIIo2AZywGf621Jv/h4+vxAGiZmCF8B57tJARZWHU6LV9MzBy F/gislNUVooZq7Kj/Q/JigH01coKcZwTn+E58PZjmWf/hLq9GFpD8l/enrylOkeloZx7 UlgktVzKOo1ABMnyk8qp50DJNYtIDAPAQOLNBjR74WcbgWr74vycUFhDx2zd6MdR6YdH Kizw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V6ykGXdrJ6gcdGEWPZ8B3JYsrZUr4Mk4WKAUKxsoTc4=; b=exBvlQpOYsOB91GFRg4NOWxarKYHU30i4eCibLbmsSmPwCiojvZpSR3kJp/xAnZfTi uBqgqubnGEGVzYc926JuYw4PrFnJM4oTKltDdvREHKTd7vXjnjnRpE/FKGQ0wVCpUhny qR36jmLSz9I/51u4t3UcVkvqrECmTyjA6CPRuenY8FbIf5HMNW73oAUScVlqmA61oumz D+WcGvkNBkJAGomXsHBqXzsVAMpJE+7iGAVTLU6/ILoQx2Ih/Lg9KJR7rR7VLY9fUGNn aAwA0yjlKX2OL0jxlI47fttfu4/NNr4ETL4P8JB/ygCPZ4mUHYEpE13+VKYKjdcXmr2F N+Zw== X-Gm-Message-State: AOAM531z7lh4sZcLH7c50lS/8GSWoNUQtZldgyfKnFpcvy81JvT4UwQz EKIRtIbUL2umPTCsQ5fQrayVgFza/D2A5w== X-Google-Smtp-Source: ABdhPJxtmRtXZnlv91gzJrnEexvLjTfRDGSbIdOlCJ06zt/c0W5vZJ2b6iWZuXpRUJZn+BVFLCHiJg== X-Received: by 2002:a17:90a:5991:: with SMTP id l17mr1108582pji.187.1611002154815; Mon, 18 Jan 2021 12:35:54 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id g201sm795160pfb.81.2021.01.18.12.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 12:35:54 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer , stable@dpdk.org Date: Mon, 18 Jan 2021 12:35:07 -0800 Message-Id: <20210118203508.1332-13-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210118203508.1332-1-aboyer@pensando.io> References: <20210118203508.1332-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH 12/13] net/ionic: fix up function attribute tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" One function marked cold is in the hot path. Make sure to always inline hot path functions. Fixes: a27d901331da ("net/ionic: add Rx and Tx handling") Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 918701f463..f49a7cdb0e 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -67,7 +67,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED; } -static inline void __rte_cold +static __rte_always_inline void ionic_tx_flush(struct ionic_cq *cq) { struct ionic_queue *q = cq->bound_q; @@ -448,7 +448,7 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm, return 0; } -static int +static __rte_always_inline int ionic_tx(struct ionic_qcq *txq, struct rte_mbuf *txm, bool not_xmit_more) { @@ -736,7 +736,7 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev, return 0; } -static void +static __rte_always_inline void ionic_rx_clean(struct ionic_queue *q, uint32_t q_desc_index, uint32_t cq_desc_index, void *cb_arg, void *service_cb_arg) @@ -897,7 +897,7 @@ ionic_rx_recycle(struct ionic_queue *q, uint32_t q_desc_index, ionic_q_post(q, true, ionic_rx_clean, mbuf); } -static int __rte_cold +static __rte_always_inline int ionic_rx_fill(struct ionic_qcq *rxq, uint32_t len) { struct ionic_queue *q = &rxq->q; @@ -1013,7 +1013,7 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id) return 0; } -static inline void __rte_cold +static __rte_always_inline void ionic_rxq_service(struct ionic_cq *cq, uint32_t work_to_do, void *service_cb_arg) {