Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86710/?format=api
{ "id": 86710, "url": "https://patches.dpdk.org/api/patches/86710/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com", "date": "2021-01-15T17:19:16", "name": "[1/2] net/cxgbe: do not link down for every link config change", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7c94b7b79a61a882883f6143b8347aeae0494df3", "submitter": { "id": 241, "url": "https://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 14785, "url": "https://patches.dpdk.org/api/series/14785/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14785", "date": "2021-01-15T17:19:15", "name": "net/cxgbe: minor fixes for link related changes", "version": 1, "mbox": "https://patches.dpdk.org/series/14785/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86710/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B3C8A0A05;\n\tFri, 15 Jan 2021 18:36:33 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1C1D1411F7;\n\tFri, 15 Jan 2021 18:36:30 +0100 (CET)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n by mails.dpdk.org (Postfix) with ESMTP id C48051411F4\n for <dev@dpdk.org>; Fri, 15 Jan 2021 18:36:28 +0100 (CET)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 10FHaPL3013285;\n Fri, 15 Jan 2021 09:36:26 -0800" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "kaara.satwik@chelsio.com", "Date": "Fri, 15 Jan 2021 22:49:16 +0530", "Message-Id": "\n <46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1610730372.git.rahul.lakkireddy@chelsio.com>", "<cover.1610730372.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1610730372.git.rahul.lakkireddy@chelsio.com>", "<cover.1610730372.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH 1/2] net/cxgbe: do not link down for every link\n config change", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some commands like turning local Tx/Rx pause on/off do not need link\nto go down. If there are issues with link config params, then the\nfirmware will explicitly indicate link down in reply. So, don't always\nlink down for every link config param change request. Instead, rely\non actual link status coming in firmware's link config change reply.\n\nFixes: 61570952b138 (\"net/cxgbe: rework and simplify link handling code\")\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/base/t4_hw.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c\nindex e87823f8f..8587eec60 100644\n--- a/drivers/net/cxgbe/base/t4_hw.c\n+++ b/drivers/net/cxgbe/base/t4_hw.c\n@@ -2844,14 +2844,12 @@ int t4_link_l1cfg_core(struct port_info *pi, u32 caps, u8 sleep_ok)\n \telse\n \t\tret = t4_wr_mbox_ns(adap, adap->mbox, &cmd, sizeof(cmd), NULL);\n \n-\tif (ret == FW_SUCCESS) {\n-\t\tlc->link_ok = 0;\n+\tif (ret == FW_SUCCESS)\n \t\tlc->link_caps = caps;\n-\t} else {\n+\telse\n \t\tdev_err(adap,\n \t\t\t\"Requested Port Capabilities %#x rejected, error %d\\n\",\n \t\t\tcaps, ret);\n-\t}\n \n \treturn ret;\n }\n", "prefixes": [ "1/2" ] }