From patchwork Fri Jan 15 17:19:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Lakkireddy X-Patchwork-Id: 86710 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B3C8A0A05; Fri, 15 Jan 2021 18:36:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1C1D1411F7; Fri, 15 Jan 2021 18:36:30 +0100 (CET) Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by mails.dpdk.org (Postfix) with ESMTP id C48051411F4 for ; Fri, 15 Jan 2021 18:36:28 +0100 (CET) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 10FHaPL3013285; Fri, 15 Jan 2021 09:36:26 -0800 From: Rahul Lakkireddy To: dev@dpdk.org Cc: kaara.satwik@chelsio.com Date: Fri, 15 Jan 2021 22:49:16 +0530 Message-Id: <46d699461ce3089b1a7040a3498fb22d691134c0.1610730372.git.rahul.lakkireddy@chelsio.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 1/2] net/cxgbe: do not link down for every link config change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some commands like turning local Tx/Rx pause on/off do not need link to go down. If there are issues with link config params, then the firmware will explicitly indicate link down in reply. So, don't always link down for every link config param change request. Instead, rely on actual link status coming in firmware's link config change reply. Fixes: 61570952b138 ("net/cxgbe: rework and simplify link handling code") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c index e87823f8f..8587eec60 100644 --- a/drivers/net/cxgbe/base/t4_hw.c +++ b/drivers/net/cxgbe/base/t4_hw.c @@ -2844,14 +2844,12 @@ int t4_link_l1cfg_core(struct port_info *pi, u32 caps, u8 sleep_ok) else ret = t4_wr_mbox_ns(adap, adap->mbox, &cmd, sizeof(cmd), NULL); - if (ret == FW_SUCCESS) { - lc->link_ok = 0; + if (ret == FW_SUCCESS) lc->link_caps = caps; - } else { + else dev_err(adap, "Requested Port Capabilities %#x rejected, error %d\n", caps, ret); - } return ret; }