Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84296/?format=api
{ "id": 84296, "url": "https://patches.dpdk.org/api/patches/84296/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201118062929.21345-4-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201118062929.21345-4-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201118062929.21345-4-feifei.wang2@arm.com", "date": "2020-11-18T06:29:28", "name": "[v1,3/4] net/ixgbe: implement good checksum flag for NEON vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b7ab5945f00bc662f5be056bf5e133079d24bc0d", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201118062929.21345-4-feifei.wang2@arm.com/mbox/", "series": [ { "id": 13941, "url": "https://patches.dpdk.org/api/series/13941/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13941", "date": "2020-11-18T06:29:25", "name": "Enable Checksum Offloading for NEON vector", "version": 1, "mbox": "https://patches.dpdk.org/series/13941/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84296/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DDB2A04E6;\n\tWed, 18 Nov 2020 07:30:34 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 71B7CC906;\n\tWed, 18 Nov 2020 07:29:50 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id E5955C900\n for <dev@dpdk.org>; Wed, 18 Nov 2020 07:29:49 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F24C101E;\n Tue, 17 Nov 2020 22:29:48 -0800 (PST)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.219])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EE6563F70D;\n Tue, 17 Nov 2020 22:29:45 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tfeiwan02 <feifei.wang2@arm.com>", "Date": "Wed, 18 Nov 2020 00:29:28 -0600", "Message-Id": "<20201118062929.21345-4-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201118062929.21345-1-feifei.wang2@arm.com>", "References": "<20201118062929.21345-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 3/4] net/ixgbe: implement good checksum flag\n\tfor NEON vector", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: feiwan02 <feifei.wang2@arm.com>\n\nAdd CKSUM_GOOD flag to distinguish a good checksum from an unknown one\nin neon vertor RX function.\n\nTest Results:\nNICs: 82599(igb)\nDirver: ixgbe(vector)\nPacket: IPv4_checksum = correct value && UDP_checksum = correct value\n\n$:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i --port-topology=chained\ntest-pmd> set fwd rxonly\ntest-pmd> set verbose 1\ntest-pmd> start\n\nWith this patch:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1\nol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD\n\nWithout this patch:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1\nol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_UNKNOWN\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 37 +++++++++++++++++--------\n 1 file changed, 25 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\nindex 4d6f057e7..b2bee2228 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n@@ -86,13 +86,13 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \t\t uint8x16_t staterr, uint8_t vlan_flags, struct rte_mbuf **rx_pkts)\n {\n \tuint8x16_t ptype;\n-\tuint8x16_t vtag;\n+\tuint8x16_t vtag_lo, vtag_hi, vtag;\n \tuint8x16_t temp_csum;\n \tuint32x4_t csum = {0, 0, 0, 0};\n \n \tunion {\n-\t\tuint8_t e[4];\n-\t\tuint32_t word;\n+\t\tuint16_t e[4];\n+\t\tuint64_t word;\n \t} vol;\n \n \tconst uint8x16_t rsstype_msk = {\n@@ -119,18 +119,26 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \t\t\t(IXGBE_RXDADV_ERR_TCPE | IXGBE_RXDADV_ERR_IPE) >> 24};\n \n \t/* map vlan present (0x8), IPE (0x2), L4E (0x1) to ol_flags */\n-\tconst uint8x16_t vlan_csum_map = {\n-\t\t\t0,\n-\t\t\tPKT_RX_L4_CKSUM_BAD,\n+\tconst uint8x16_t vlan_csum_map_lo = {\n+\t\t\tPKT_RX_IP_CKSUM_GOOD,\n+\t\t\tPKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD,\n \t\t\tPKT_RX_IP_CKSUM_BAD,\n \t\t\tPKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD,\n \t\t\t0, 0, 0, 0,\n-\t\t\tvlan_flags,\n-\t\t\tvlan_flags | PKT_RX_L4_CKSUM_BAD,\n+\t\t\tvlan_flags | PKT_RX_IP_CKSUM_GOOD,\n+\t\t\tvlan_flags | PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD,\n \t\t\tvlan_flags | PKT_RX_IP_CKSUM_BAD,\n \t\t\tvlan_flags | PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD,\n \t\t\t0, 0, 0, 0};\n \n+\tconst uint8x16_t vlan_csum_map_hi = {\n+\t\t\tPKT_RX_L4_CKSUM_GOOD >> sizeof(uint8_t), 0,\n+\t\t\tPKT_RX_L4_CKSUM_GOOD >> sizeof(uint8_t), 0,\n+\t\t\t0, 0, 0, 0,\n+\t\t\tPKT_RX_L4_CKSUM_GOOD >> sizeof(uint8_t), 0,\n+\t\t\tPKT_RX_L4_CKSUM_GOOD >> sizeof(uint8_t), 0,\n+\t\t\t0, 0, 0, 0};\n+\n \tptype = vzipq_u8(sterr_tmp1.val[0], sterr_tmp2.val[0]).val[0];\n \tptype = vandq_u8(ptype, rsstype_msk);\n \tptype = vqtbl1q_u8(rss_flags, ptype);\n@@ -150,11 +158,16 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \tcsum = vsetq_lane_u32(vgetq_lane_u32(vreinterpretq_u32_u8(temp_csum), 3), csum, 0);\n \tvtag = vorrq_u8(vreinterpretq_u8_u32(csum), vtag);\n \n-\t/* convert VP, IPE, L4E to ol_flags */\n-\tvtag = vqtbl1q_u8(vlan_csum_map, vtag);\n-\tvtag = vorrq_u8(ptype, vtag);\n+\t/* convert L4 checksum correct type to vtag_hi */\n+\tvtag_hi = vqtbl1q_u8(vlan_csum_map_hi, vtag);\n+\tvtag_hi = vshrq_n_u8(vtag_hi, 7);\n+\n+\t/* convert VP, IPE, L4E to vtag_lo */\n+\tvtag_lo = vqtbl1q_u8(vlan_csum_map_lo, vtag);\n+\tvtag_lo = vorrq_u8(ptype, vtag_lo);\n \n-\tvol.word = vgetq_lane_u32(vreinterpretq_u32_u8(vtag), 0);\n+\tvtag = vzipq_u8(vtag_lo, vtag_hi).val[0];\n+\tvol.word = vgetq_lane_u64(vreinterpretq_u64_u8(vtag), 0);\n \n \trx_pkts[0]->ol_flags = vol.e[0];\n \trx_pkts[1]->ol_flags = vol.e[1];\n", "prefixes": [ "v1", "3/4" ] }