Patch Comment List
List patch comments
GET /api/patches/74693/comments/?format=api
[ { "id": 116596, "web_url": "https://patches.dpdk.org/comment/116596/", "msgid": "<20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-24T11:07:18", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> From: Thomas Monjalon <thomas@monjalon.net>\n> \n> Drivers dependencies are evaluated in the order defined per\n> their parent directory (also called class).\n> This strict ordering prevent from having 2 different drivers\n> of the same class with different dependencies ordering.\n> This problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\n> while drivers/bus/dpaa depends on drivers/common/dpaax.\n> Having a strict ordering between directories bus and common\n> is too much restrictive.\n> \n> That's why it is made possible to have a more fine-grain directory list,\n> adding a driver sub-directory in the list.\n> In this case, the isolated driver must be removed from its class list,\n> and added directly in drivers/meson.build.\n> Also, the per-class variables must be duplicated in the isolated driver,\n> because the call \"subdir(class)\" is skipped in the isolated driver case.\n> \n> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n\nThe commit log above has some strange word-wrapping, and occasionally\nstrange phrasing. I think it could be slightly reworded, perhaps as:\n\n Drivers dependencies are evaluated in the order defined per their parent\n directory (also called class). This strict ordering prevents from us\n from having pairs of drivers from two classes with different dependency\n ordering. For example, if the mlx5 common code depends on the pci bus\n driver, while the dpaax common code is itself a dependency of the dpaa\n bus driver. Having a strict ordering between directories bus and common\n is too restrictive, as processing either common drivers or bus drivers\n first leads us to missing dependencies in this scenario.\n \n This patch makes it possible to have a more fine-grain directory list,\n adding a specific driver sub-directory in the top-level drivers\n subdirectory list. In this case, the isolated driver must also be removed\n from its class list, and the per-class variables must be duplicated in\n the isolated driver, because the call \"subdir(class)\" is skipped in the\n isolated driver case.\n \n\nApart from that, I think this is a good idea to give us some flexibility\nin managing driver ordering which should help other drivers too -\nperhaps QAT? Ideally, though, I'd like if we can limit the flexible\nordering to *only* common code, in which case we could move the\nper-class variables for common to the top-level to prevent duplication,\nand maybe even get rid of common/meson.build completely. That, however,\nwill depend on how much this feature gets used and by whom.\n\nTherefore:\nReview-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE42EA0518;\n\tFri, 24 Jul 2020 13:07:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 999BB1BFE7;\n\tFri, 24 Jul 2020 13:07:26 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id D7AE81BFE5\n for <dev@dpdk.org>; Fri, 24 Jul 2020 13:07:24 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jul 2020 04:07:23 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.251.87.116])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 24 Jul 2020 04:07:21 -0700" ], "IronPort-SDR": [ "\n yiEYi4/4OoTwoqSiIz1K3pAcg/UkzkL+wtsppWE38kqvA2326KhKW5Q0hwj5nywQanByKOiUgp\n aPcRRhTIorYw==", "\n WcT27/FtjoEUzxwZFNA9o4SUde6hqreg7WX0PnXVfdLIf5ikVGjZRWyhZzd7wKK1EjKluEn9eN\n rJ+4RcApIUKQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"138754472\"", "E=Sophos;i=\"5.75,390,1589266800\"; d=\"scan'208\";a=\"138754472\"", "E=Sophos;i=\"5.75,390,1589266800\"; d=\"scan'208\";a=\"463193337\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Fri, 24 Jul 2020 12:07:18 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Parav Pandit <parav@mellanox.com>", "Cc": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com,\n thomas@monjalon.net, rasland@mellanox.com, orika@mellanox.com,\n matan@mellanox.com, joyce.kong@arm.com", "Message-ID": "<20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>\n <20200723200910.376581-4-parav@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200723200910.376581-4-parav@mellanox.com>", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116607, "web_url": "https://patches.dpdk.org/comment/116607/", "msgid": "<CAJFAV8xSBpEB_6pvmQiq5kyCkYqF==bwZH8B-V=odK3Y6x7pVw@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8xSBpEB_6pvmQiq5kyCkYqF==bwZH8B-V=odK3Y6x7pVw@mail.gmail.com", "date": "2020-07-24T13:41:08", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, Jul 23, 2020 at 10:10 PM Parav Pandit <parav@mellanox.com> wrote:\n>\n> From: Thomas Monjalon <thomas@monjalon.net>\n>\n> Drivers dependencies are evaluated in the order defined per\n> their parent directory (also called class).\n> This strict ordering prevent from having 2 different drivers\n> of the same class with different dependencies ordering.\n> This problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\n> while drivers/bus/dpaa depends on drivers/common/dpaax.\n> Having a strict ordering between directories bus and common\n> is too much restrictive.\n>\n> That's why it is made possible to have a more fine-grain directory list,\n> adding a driver sub-directory in the list.\n> In this case, the isolated driver must be removed from its class list,\n> and added directly in drivers/meson.build.\n> Also, the per-class variables must be duplicated in the isolated driver,\n> because the call \"subdir(class)\" is skipped in the isolated driver case.\n>\n> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> ---\n> drivers/meson.build | 28 +++++++++++++++++++++-------\n> 1 file changed, 21 insertions(+), 7 deletions(-)\n>\n> diff --git a/drivers/meson.build b/drivers/meson.build\n> index e2aeba931..e6d0409aa 100644\n> --- a/drivers/meson.build\n> +++ b/drivers/meson.build\n> @@ -1,8 +1,8 @@\n> # SPDX-License-Identifier: BSD-3-Clause\n> # Copyright(c) 2017-2019 Intel Corporation\n>\n> -# Defines the order in which the drivers are buit.\n> -dpdk_driver_classes = [\n> +# Defines the order of dependencies evaluation\n> +subdirs = [\n> 'common',\n> 'bus',\n> 'mempool', # depends on common and bus.\n> @@ -27,7 +27,7 @@ if cc.has_argument('-Wno-format-truncation')\n> default_cflags += '-Wno-format-truncation'\n> endif\n>\n> -foreach class:dpdk_driver_classes\n> +foreach subpath:subdirs\n> drivers = []\n> std_deps = []\n> config_flag_fmt = '' # format string used to set the value in dpdk_conf\n> @@ -35,8 +35,22 @@ foreach class:dpdk_driver_classes\n> # the library, the dependency and to find the\n> # version file for linking\n>\n> - subdir(class)\n> - class_drivers = []\n> + # subpath can be either \"class\" or \"class/driver\"\n> + if subpath.contains('/')\n> + driver_path = subpath.split('/')\n> + class = driver_path[0]\n> + drivers += driver_path[1]\n> + else\n> + class = subpath\n> + subdir(class)\n> + endif\n> +\n> + # save class name on first occurence\n> + if not dpdk_driver_classes.contains(class)\n> + dpdk_driver_classes += class\n> + endif\n> + # get already enabled drivers of the same class\n> + enabled_drivers = get_variable(class + '_drivers', [])\n>\n> foreach drv:drivers\n> drv_path = join_paths(class, drv)\n> @@ -96,7 +110,7 @@ foreach class:dpdk_driver_classes\n> '_disable_reason', reason)\n> endif\n> else\n> - class_drivers += name\n> + enabled_drivers += name\n>\n> if fmt_name == ''\n> fmt_name = name\n> @@ -203,5 +217,5 @@ foreach class:dpdk_driver_classes\n> endif # build\n> endforeach\n>\n> - set_variable(class + '_drivers', class_drivers)\n> + set_variable(class + '_drivers', enabled_drivers)\n> endforeach\n> --\n> 2.25.4\n>\n\nReviewed-by: David Marchand <david.marchand@redhat.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2EA7DA0526;\n\tFri, 24 Jul 2020 15:41:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E72101C025;\n\tFri, 24 Jul 2020 15:41:25 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 9D39A1C01E\n for <dev@dpdk.org>; Fri, 24 Jul 2020 15:41:24 +0200 (CEST)", "from mail-vk1-f200.google.com (mail-vk1-f200.google.com\n [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-339-f0Xu9pK_MPKRwr81sLNy7w-1; Fri, 24 Jul 2020 09:41:20 -0400", "by mail-vk1-f200.google.com with SMTP id u203so2922796vkb.9\n for <dev@dpdk.org>; Fri, 24 Jul 2020 06:41:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1595598084;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=B6nrXB7X5xnh+H808MBM/ckJdijHbePISfUDWg48PhY=;\n b=XmJFE70KHinecrQa5i5xq1fzoc+gU9KV4bc8LhCe7MM20noLBKrthq5Aimz2vMAnjqbiOU\n +FE/vw3CP+5PEnTU+0/hblb0LwGgYp/3XH8hZTIGKDFn+menknBTCbQFsnIBpsg2sh2SqH\n UQ84E6twlNl5SRCapfIjqUvnBPNbKZU=", "X-MC-Unique": "f0Xu9pK_MPKRwr81sLNy7w-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=B6nrXB7X5xnh+H808MBM/ckJdijHbePISfUDWg48PhY=;\n b=JrIc5kS/ngEJFKurMfnR8YmEQNu1EMu8SY7c15+nenJHKhLEvSz5xjR1W/Os+aWyx2\n l1pXWAS8zeUU7q3XJFN49rJY7TRR1MUTliu+9Uz4vwbE2NhR/IpCX+wC2c4ChvljVa1Y\n 4/Y6BdyvXjJ8Shm/6rIf46t7dmUJbwGcNnGHjyCNC3U1otBbZXy7rIRzo5VrDVBR/70M\n jV8qkiWoH1qBciWovovbcU9Q8EH0Z2evmmaWPbnLMvPwFRPz3gHwQXn47HUhqp6/grFO\n ebE5DqesOJ9yUA5N3TF9z8DEpS7cFW0SD1CRXNV01hrdv8SWBxm4xXxrRFD69yN9wHlw\n dIbQ==", "X-Gm-Message-State": "AOAM5326DT53xzZTgrlZfR3qEdw/ZWTA29fBi7nYnaGFe/bR9kfyJXeN\n b9QC619jXyF6/VxGegOfrgjkBvQpux/mQg5Qur0CH/V28uMNpQTimgm16y6GoILUTH7DkE5mqjV\n vVGCZY60jD534qiPG/h8=", "X-Received": [ "by 2002:a9f:31f3:: with SMTP id w48mr7964834uad.87.1595598079682;\n Fri, 24 Jul 2020 06:41:19 -0700 (PDT)", "by 2002:a9f:31f3:: with SMTP id w48mr7964811uad.87.1595598079423;\n Fri, 24 Jul 2020 06:41:19 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJxuWiF6JzWkgon8vbTGsjtPazAPokp9hBbXrcf0YQOe9tDXmF/aXG5TJ3s2LsJ1oZSV4iRcmHZDEyhoAnSI52o=", "MIME-Version": "1.0", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>\n <20200723200910.376581-4-parav@mellanox.com>", "In-Reply-To": "<20200723200910.376581-4-parav@mellanox.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Fri, 24 Jul 2020 15:41:08 +0200", "Message-ID": "\n <CAJFAV8xSBpEB_6pvmQiq5kyCkYqF==bwZH8B-V=odK3Y6x7pVw@mail.gmail.com>", "To": "Parav Pandit <parav@mellanox.com>", "Cc": "dev <dev@dpdk.org>, Gaetan Rivet <grive@u256.net>,\n \"Yigit, Ferruh\" <ferruh.yigit@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Raslan <rasland@mellanox.com>, Ori Kam <orika@mellanox.com>,\n Matan Azrad <matan@mellanox.com>, Joyce Kong <joyce.kong@arm.com>", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116610, "web_url": "https://patches.dpdk.org/comment/116610/", "msgid": "<AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com", "date": "2020-07-24T13:48:25", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 1780, "url": "https://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "content": "Hi Bruce,\n\n> From: Bruce Richardson <bruce.richardson@intel.com>\n> Sent: Friday, July 24, 2020 4:37 PM\n> \n> On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> > From: Thomas Monjalon <thomas@monjalon.net>\n> >\n> > Drivers dependencies are evaluated in the order defined per their\n> > parent directory (also called class).\n> > This strict ordering prevent from having 2 different drivers of the\n> > same class with different dependencies ordering.\n> > This problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\n> > while drivers/bus/dpaa depends on drivers/common/dpaax.\n> > Having a strict ordering between directories bus and common is too\n> > much restrictive.\n> >\n> > That's why it is made possible to have a more fine-grain directory\n> > list, adding a driver sub-directory in the list.\n> > In this case, the isolated driver must be removed from its class list,\n> > and added directly in drivers/meson.build.\n> > Also, the per-class variables must be duplicated in the isolated\n> > driver, because the call \"subdir(class)\" is skipped in the isolated driver case.\n> >\n> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> \n> The commit log above has some strange word-wrapping, and occasionally\n> strange phrasing. I think it could be slightly reworded, perhaps as:\n> \nI updated the commit log as you suggested below along with RB, ack tag.\nThank you.\n\n> Drivers dependencies are evaluated in the order defined per their parent\n> directory (also called class). This strict ordering prevents from us\n> from having pairs of drivers from two classes with different dependency\n> ordering. For example, if the mlx5 common code depends on the pci bus\n> driver, while the dpaax common code is itself a dependency of the dpaa\n> bus driver. Having a strict ordering between directories bus and common\n> is too restrictive, as processing either common drivers or bus drivers\n> first leads us to missing dependencies in this scenario.\n> \n> This patch makes it possible to have a more fine-grain directory list,\n> adding a specific driver sub-directory in the top-level drivers\n> subdirectory list. In this case, the isolated driver must also be removed\n> from its class list, and the per-class variables must be duplicated in\n> the isolated driver, because the call \"subdir(class)\" is skipped in the\n> isolated driver case.\n> \n> \n> Apart from that, I think this is a good idea to give us some flexibility in\n> managing driver ordering which should help other drivers too - perhaps QAT?\n> Ideally, though, I'd like if we can limit the flexible ordering to *only* common\n> code, in which case we could move the per-class variables for common to the\n> top-level to prevent duplication, and maybe even get rid of\n> common/meson.build completely. That, however, will depend on how much\n> this feature gets used and by whom.\n> \n> Therefore:\n> Review-by: Bruce Richardson <bruce.richardson@intel.com>\n> Acked-by: Bruce Richardson <bruce.richardson@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2304A0526;\n\tFri, 24 Jul 2020 15:48:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B98AA1C027;\n\tFri, 24 Jul 2020 15:48:28 +0200 (CEST)", "from EUR01-DB5-obe.outbound.protection.outlook.com\n (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41])\n by dpdk.org (Postfix) with ESMTP id 23D441C012\n for <dev@dpdk.org>; Fri, 24 Jul 2020 15:48:28 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM0PR0502MB3651.eurprd05.prod.outlook.com (2603:10a6:208:16::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Fri, 24 Jul\n 2020 13:48:26 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020\n 13:48:25 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=R8k0kz5L0UAP+Lw09fg8BJyLGjEdpsLe3HC/Z5Pu5eUVZ1YWBdQ5W/KZcfnS6O3x1DQ3YrFU+TMzFdjco0YpMgzyEts3Zd6jCyGlSozPgRJM3mjqxdhEB2BEnlIGxVbUNk2QvnXd45Lyhazocrx74pCmKLqoiDdKO3F2BMLApt35q78n3abqCHK0tmGfkHpSym9HDmXGSp4SEAgn6WVaLE6uZSbi71RCtAz61lruN5iHW1w+FWvuGYK04rbTA9hNgiTaC/vexjnDHfYQaJXn+X9fxi9UQDr51rylcgVNnuGGdrk0pDn/DTvLpezFqxlsl5FYONq0UyiFBla7W3VIlg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Jw5tXkZYzfWK1t+1YLELiirIydNeHu7JBcFoHgiqyU8=;\n b=OS6uY+pu0mr+DXVLDqAFoHv22kVcsqXZkX7dMFDQ/AoIGZ8SFizZNfzzWcDJS6RLWYEb33fdtHlOEkKkoFQozip2WFbZsmc3YKJFcJA/V/TRUuQ0PP8vFof1Xc4U/0sH37+/G94CLm8wWgc0T7NjDYIZhaXrCiFkCcBTzKk/2v8OTPG6a1RsJmevPqwKj5DRYKbqv5uNFc9jw6FeqtE5/hU9gSUT/5kEy1iN12sAQ0wfOZcThBhRu+WhEqATX39OmiDSvdfS2JUNrVxQ5ryPl+DnUJhxMqNOg2aT5wRoE26ThbkF0G5+2v2QhSZw4XCbQ2ytQcgmPgZl9rVy20s11w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Jw5tXkZYzfWK1t+1YLELiirIydNeHu7JBcFoHgiqyU8=;\n b=RKYz5iZgnAJMNIK2AQToItUPYT1hlq72P0YjRJzlMFdGb+RkkEj2UYBnlBJ/nAshjjqfwVSlGe0meWV/Yn8jN+TMfSa5kM1S9YjOQA018ZGkxwTsfe00I5Agyis00xYG/J+BGESmy1z1QLGi8R3+qpwCpz44hBGftNVgbsHWaDw=", "From": "Parav Pandit <parav@mellanox.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"grive@u256.net\" <grive@u256.net>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Thomas Monjalon\n <thomas@monjalon.net>, Raslan Darawsheh <rasland@mellanox.com>, Ori Kam\n <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>, \"joyce.kong@arm.com\"\n <joyce.kong@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "Thread-Index": "AQHWYS0v/wbmxgA1t0ybPTrTM2yq66kWktYAgAAsyOA=", "Date": "Fri, 24 Jul 2020 13:48:25 +0000", "Message-ID": "\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>\n <20200723200910.376581-4-parav@mellanox.com>\n <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>", "In-Reply-To": "<20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[106.51.108.81]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "98a3400f-cd99-450b-058a-08d82fd83d3c", "x-ms-traffictypediagnostic": "AM0PR0502MB3651:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR0502MB36510232B0152FD78289FE3AD1770@AM0PR0502MB3651.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:5516;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n KhSak1o0RMvTyNN7mnCEL5Dikhgt/feQqjJV59Wl9lZhgyz4psk/Q24rEygZP76AV36YnMwtFP4+zP0xwC3jJBpHCBWsJ2HnSmJN3rFp+qLgTHb0JZnzcPIu1mUP8Sb53I4pqzCqetvXYn0fEd/U1sXimHu05vp6srcxIoAI0D+HGt6jeEg0L27MEC6gX3v7EP4spKC/TnEhCGi7BL+znzzeMxxFnKv/SHjpi24x5z6HqPvnmvYascjr4t0MGF3ZG0I84/UpQRs4fSX4Ba19Hx+cJtrCLJL7nJN16Ap+abnIdkbO8kZvdV4YnRFcDrK7KHBy06/w2RhoxSu5CDiYhw==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(54906003)(2906002)(9686003)(7696005)(26005)(33656002)(4326008)(8676002)(186003)(478600001)(83380400001)(55236004)(5660300002)(76116006)(6506007)(66946007)(71200400001)(86362001)(66476007)(66556008)(66446008)(55016002)(8936002)(52536014)(316002)(6916009)(64756008);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n hmSadlLQVudxSW/+ugq0gfShUEVd3LpmSuG25RykA+ZLjuK76DMGRo7A3pg2Hj3E3+m5LYb2gpXfB4UG3Jc8pybo8si7UHENRGaP3w9Z1GQT/U0wlyH77GL2aiec0HOZv3CQKb5nKTCZmN0SUJGSbErnAYRILif1zZdX880Qkj1A6m34fehP6E6Mj3XBmTK/5J/2be4NVCALbM7KQtPXC2VF5jlVNYGkf0Wdmf2GIuZqiv6hvnteVn00HZvdWVEyEoz8VCuldlUPdExJ4NPKDo9WUjqRb9LNlTa2Qb6sUGcZWmhgFKjzRawz7CztQUS4iI/vHGFxRF0vqzFbT3epmZ1Stq7JuVZyA1pULG+so2buKwA3Sk/y7OS9/pRDI7uqN6m6kzBu2vrj18FQNa3pCHahxm83XuvM+jLREuTFuFr9VbfP3Y+IAwfrQz+SDMWL+/e6/wjQU9b8Uid/qngDM54SgCTr/fbbzIGmKhIe+GUUWHKm8z58RYKlPiBw7ESN", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 98a3400f-cd99-450b-058a-08d82fd83d3c", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 13:48:25.8571 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n OhGPlxPIufoF1SYY60YTPgOghxHx1FLx0+t4pxJyXGoKIbpgPY0yYb2PRVJg0RsDxsmxbgvTfi4gS52vj7RBLQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR0502MB3651", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116611, "web_url": "https://patches.dpdk.org/comment/116611/", "msgid": "<4937496.TfPSyrM900@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/4937496.TfPSyrM900@thomas", "date": "2020-07-24T13:54:33", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "24/07/2020 15:48, Parav Pandit:\n> Hi Bruce,\n> \n> > From: Bruce Richardson <bruce.richardson@intel.com>\n> > Sent: Friday, July 24, 2020 4:37 PM\n> > \n> > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> > > From: Thomas Monjalon <thomas@monjalon.net>\n> > >\n> > > Drivers dependencies are evaluated in the order defined per their\n> > > parent directory (also called class).\n> > > This strict ordering prevent from having 2 different drivers of the\n> > > same class with different dependencies ordering.\n> > > This problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\n> > > while drivers/bus/dpaa depends on drivers/common/dpaax.\n> > > Having a strict ordering between directories bus and common is too\n> > > much restrictive.\n> > >\n> > > That's why it is made possible to have a more fine-grain directory\n> > > list, adding a driver sub-directory in the list.\n> > > In this case, the isolated driver must be removed from its class list,\n> > > and added directly in drivers/meson.build.\n> > > Also, the per-class variables must be duplicated in the isolated\n> > > driver, because the call \"subdir(class)\" is skipped in the isolated driver case.\n> > >\n> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> > \n> > The commit log above has some strange word-wrapping, and occasionally\n> > strange phrasing. I think it could be slightly reworded, perhaps as:\n> > \n> I updated the commit log as you suggested below along with RB, ack tag.\n> Thank you.\n> \n> > Drivers dependencies are evaluated in the order defined per their parent\n> > directory (also called class). This strict ordering prevents from us\n\nIs \"from us\" too much?\n\n> > from having pairs of drivers from two classes with different dependency\n> > ordering. For example, if the mlx5 common code depends on the pci bus\n> > driver, while the dpaax common code is itself a dependency of the dpaa\n> > bus driver. Having a strict ordering between directories bus and common\n> > is too restrictive, as processing either common drivers or bus drivers\n> > first leads us to missing dependencies in this scenario.\n> > \n> > This patch makes it possible to have a more fine-grain directory list,\n> > adding a specific driver sub-directory in the top-level drivers\n> > subdirectory list. In this case, the isolated driver must also be removed\n> > from its class list, and the per-class variables must be duplicated in\n> > the isolated driver, because the call \"subdir(class)\" is skipped in the\n> > isolated driver case.\n> > \n> > \n> > Apart from that, I think this is a good idea to give us some flexibility in\n> > managing driver ordering which should help other drivers too - perhaps QAT?\n> > Ideally, though, I'd like if we can limit the flexible ordering to *only* common\n> > code, in which case we could move the per-class variables for common to the\n> > top-level to prevent duplication, and maybe even get rid of\n> > common/meson.build completely. That, however, will depend on how much\n> > this feature gets used and by whom.\n\nFor now it is used only to have common/mlx5 isolated of the rest\nof common drivers, as an exception.\nI think it is good to keep common/meson.build\nuntil there are more exceptions than the rest.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60DC9A0526;\n\tFri, 24 Jul 2020 15:54:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9582D1C01E;\n\tFri, 24 Jul 2020 15:54:38 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 29E411BFE7\n for <dev@dpdk.org>; Fri, 24 Jul 2020 15:54:37 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id 91C995C0140;\n Fri, 24 Jul 2020 09:54:35 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Fri, 24 Jul 2020 09:54:35 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 20D10306005F;\n Fri, 24 Jul 2020 09:54:34 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=fm1; bh=\n NAOrBQaBWA7KpS41XJN9M+xxZVbP/zr18lrD5XDZTgg=; b=d3OYPBj4F2KDjMnr\n wC6uJm6Vdl1i22n5Za9ZNMXttVS5PwOrnSImlaeeodT7I0NmEHEP4iHE56F+piXm\n 1msBPTba+mt562Np8AeGKNOeElm/ZcdJ1hTTbPLF8sGks7BsWCBtcIhY3G3YTXeK\n C3a4CQ7TjM/Nh3Z1ptczcyyslqUM/9FU1R0bKqTprhj4pwbatFK70hGmZBvoTJKQ\n RrUuIcGugq8bZzZiw3ZvR7cWCdq7wLivQySQIfPqsVLm/OK+iJxW4Rnbum8xmpT0\n rJM/RHhWscMAm1eLnr4vmhbL8R5QqxhQOK5/h8R4jI+tdG8mdjfSfRot9Nsp6gpa\n sF3hzw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm3; bh=NAOrBQaBWA7KpS41XJN9M+xxZVbP/zr18lrD5XDZT\n gg=; b=rGunRumQ+4sVjOUsV6i/7WaDdgJWJNg8sXsuq8F0lFrfjq+/tsrfqfBgT\n yb4dmLYSPqBkPgSj7ICjAnW0/8OfGEm/twewwlIleBrEWnDYPqSYa+WuD0LApX8b\n xwzAV31KgFe+Tccv/YVFH8cxVczyiPn5aZF+2N3QQsgvJuDcqG2DyTy/NerScMss\n KrhctoqHLLDgLhvSpZb/DIfQW9rNVo1OwFcvUNXus6JHQ7eb2EvZu/qmVInKI642\n GU4yN0X1AK/ApHmjiQmwHBbSIZz8xsOY8e7d1mB5fWTEJxOIoroQ9nU1IqgNIOux\n 00qA/GnNeBoJYz97Jp+pHJYxg9Mhg==" ], "X-ME-Sender": "<xms:G-gaXyoZOz-r6M6GsPCDZ0nSAG00xRdfj58QIKRdHKcIHQQYqRBQEA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrheefgdejfecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei\n iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:G-gaXwqPc-vQTEwvU79V_EvpPn-3p_GyoIjNJ9QcgrMESC61iMwQaQ>\n <xmx:G-gaX3M7T5MXdBULuIFI-9BNduF5K-wdONNwGqiQIqcxPrW-cvwMtA>\n <xmx:G-gaXx4ODbXPwxpoTG9jV87x-91KTotOS7KOn4FUYyhdjdrPo6R9Sg>\n <xmx:G-gaX_SEH-M4u2SWCgiqTbiUb6I6J3COLd5pxdKBFyWXxxzG7QpMIg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n Parav Pandit <parav@mellanox.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, \"grive@u256.net\" <grive@u256.net>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>,\n Raslan Darawsheh <rasland@mellanox.com>, Ori Kam <orika@mellanox.com>,\n Matan Azrad <matan@mellanox.com>, \"joyce.kong@arm.com\" <joyce.kong@arm.com>", "Date": "Fri, 24 Jul 2020 15:54:33 +0200", "Message-ID": "<4937496.TfPSyrM900@thomas>", "In-Reply-To": "\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116617, "web_url": "https://patches.dpdk.org/comment/116617/", "msgid": "<20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-24T14:50:07", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote:\n> 24/07/2020 15:48, Parav Pandit:\n> > Hi Bruce,\n> > \n> > > From: Bruce Richardson <bruce.richardson@intel.com>\n> > > Sent: Friday, July 24, 2020 4:37 PM\n> > > \n> > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> > > > From: Thomas Monjalon <thomas@monjalon.net>\n> > > >\n> > > > Drivers dependencies are evaluated in the order defined per their\n> > > > parent directory (also called class).\n> > > > This strict ordering prevent from having 2 different drivers of the\n> > > > same class with different dependencies ordering.\n> > > > This problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\n> > > > while drivers/bus/dpaa depends on drivers/common/dpaax.\n> > > > Having a strict ordering between directories bus and common is too\n> > > > much restrictive.\n> > > >\n> > > > That's why it is made possible to have a more fine-grain directory\n> > > > list, adding a driver sub-directory in the list.\n> > > > In this case, the isolated driver must be removed from its class list,\n> > > > and added directly in drivers/meson.build.\n> > > > Also, the per-class variables must be duplicated in the isolated\n> > > > driver, because the call \"subdir(class)\" is skipped in the isolated driver case.\n> > > >\n> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> > > \n> > > The commit log above has some strange word-wrapping, and occasionally\n> > > strange phrasing. I think it could be slightly reworded, perhaps as:\n> > > \n> > I updated the commit log as you suggested below along with RB, ack tag.\n> > Thank you.\n> > \n> > > Drivers dependencies are evaluated in the order defined per their parent\n> > > directory (also called class). This strict ordering prevents from us\n> \n> Is \"from us\" too much?\n\nThe word \"from\" is incorrect, anyway, it should just be \"prevents us\".\nEvidently I didn't proofread my own text well enough. :-(\n\n> \n> > > from having pairs of drivers from two classes with different dependency\n> > > ordering. For example, if the mlx5 common code depends on the pci bus\n> > > driver, while the dpaax common code is itself a dependency of the dpaa\n> > > bus driver. Having a strict ordering between directories bus and common\n> > > is too restrictive, as processing either common drivers or bus drivers\n> > > first leads us to missing dependencies in this scenario.\n> > > \n> > > This patch makes it possible to have a more fine-grain directory list,\n> > > adding a specific driver sub-directory in the top-level drivers\n> > > subdirectory list. In this case, the isolated driver must also be removed\n> > > from its class list, and the per-class variables must be duplicated in\n> > > the isolated driver, because the call \"subdir(class)\" is skipped in the\n> > > isolated driver case.\n> > > \n> > > \n> > > Apart from that, I think this is a good idea to give us some flexibility in\n> > > managing driver ordering which should help other drivers too - perhaps QAT?\n> > > Ideally, though, I'd like if we can limit the flexible ordering to *only* common\n> > > code, in which case we could move the per-class variables for common to the\n> > > top-level to prevent duplication, and maybe even get rid of\n> > > common/meson.build completely. That, however, will depend on how much\n> > > this feature gets used and by whom.\n> \n> For now it is used only to have common/mlx5 isolated of the rest\n> of common drivers, as an exception.\n> I think it is good to keep common/meson.build\n> until there are more exceptions than the rest.\n> \n\n+1 agreed. \nJust suggesting possible future changes depending on how things\ngo, and also seeding the idea that any out-of-order build processing should\nreally be limited to the common folder.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48D2AA0527;\n\tFri, 24 Jul 2020 16:50:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 944391C02D;\n\tFri, 24 Jul 2020 16:50:15 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 2DB4F1C02C\n for <dev@dpdk.org>; Fri, 24 Jul 2020 16:50:13 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jul 2020 07:50:12 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.251.87.116])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 24 Jul 2020 07:50:10 -0700" ], "IronPort-SDR": [ "\n r3lQXHa0r1M+3N2I5wwHbYAiany560Cvf3WimD3FtnI+VlMkfc+vDOx5OkMypYkZWqruIxf1Gj\n uOYjMnmfYypg==", "\n AFcdwjzATY1k8h7hvghxUs/m1gjGxdMfN6eLL7onZjCj/Wx/KB5DtvryVVsKd18Z3SKBPGxPYP\n sQUhkalojeNA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"130793833\"", "E=Sophos;i=\"5.75,391,1589266800\"; d=\"scan'208\";a=\"130793833\"", "E=Sophos;i=\"5.75,391,1589266800\"; d=\"scan'208\";a=\"489231467\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Fri, 24 Jul 2020 15:50:07 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "Parav Pandit <parav@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n \"grive@u256.net\" <grive@u256.net>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>,\n Raslan Darawsheh <rasland@mellanox.com>,\n Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>,\n \"joyce.kong@arm.com\" <joyce.kong@arm.com>", "Message-ID": "<20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>\n <4937496.TfPSyrM900@thomas>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<4937496.TfPSyrM900@thomas>", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116619, "web_url": "https://patches.dpdk.org/comment/116619/", "msgid": "<AM0PR05MB4866596C70120AF807755B08D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB4866596C70120AF807755B08D1770@AM0PR05MB4866.eurprd05.prod.outlook.com", "date": "2020-07-24T15:17:38", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 1780, "url": "https://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "content": "> From: Bruce Richardson <bruce.richardson@intel.com>\n> Sent: Friday, July 24, 2020 8:20 PM\n> \n> On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote:\n> > 24/07/2020 15:48, Parav Pandit:\n> > > Hi Bruce,\n> > >\n> > > > From: Bruce Richardson <bruce.richardson@intel.com>\n> > > > Sent: Friday, July 24, 2020 4:37 PM\n> > > >\n> > > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> > > > > From: Thomas Monjalon <thomas@monjalon.net>\n> > > > >\n> > > > > Drivers dependencies are evaluated in the order defined per\n> > > > > their parent directory (also called class).\n> > > > > This strict ordering prevent from having 2 different drivers of\n> > > > > the same class with different dependencies ordering.\n> > > > > This problem occurs if drivers/common/mlx5 depends on\n> > > > > drivers/bus/pci, while drivers/bus/dpaa depends on\n> drivers/common/dpaax.\n> > > > > Having a strict ordering between directories bus and common is\n> > > > > too much restrictive.\n> > > > >\n> > > > > That's why it is made possible to have a more fine-grain\n> > > > > directory list, adding a driver sub-directory in the list.\n> > > > > In this case, the isolated driver must be removed from its class\n> > > > > list, and added directly in drivers/meson.build.\n> > > > > Also, the per-class variables must be duplicated in the isolated\n> > > > > driver, because the call \"subdir(class)\" is skipped in the isolated driver\n> case.\n> > > > >\n> > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> > > >\n> > > > The commit log above has some strange word-wrapping, and\n> > > > occasionally strange phrasing. I think it could be slightly reworded,\n> perhaps as:\n> > > >\n> > > I updated the commit log as you suggested below along with RB, ack tag.\n> > > Thank you.\n> > >\n> > > > Drivers dependencies are evaluated in the order defined per their\n> parent\n> > > > directory (also called class). This strict ordering prevents\n> > > > from us\n> >\n> > Is \"from us\" too much?\n> \n> The word \"from\" is incorrect, anyway, it should just be \"prevents us\".\n> Evidently I didn't proofread my own text well enough. :-(\n\nIn v10 I rephase it as \"strict ordering prevents from having pairs of drivers...\".", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B35BDA0527;\n\tFri, 24 Jul 2020 17:17:42 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F36B1C02A;\n\tFri, 24 Jul 2020 17:17:41 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76])\n by dpdk.org (Postfix) with ESMTP id EEFB41C027\n for <dev@dpdk.org>; Fri, 24 Jul 2020 17:17:39 +0200 (CEST)", "from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)\n by AM0PR05MB4210.eurprd05.prod.outlook.com (2603:10a6:208:63::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Fri, 24 Jul\n 2020 15:17:38 +0000", "from AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com\n ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020\n 15:17:38 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mdfH2CenOq602xn/ilVUEZ8U6nXjnzr+n70vVryHBlTUOhD8aTX+Fhq548lPs7l2L8zBYu5CwnHSLk15KhcbjnAmLddgbAo2VwNgEcS4cPBYpAmSlcgf3PNt/R9hp/Rt9ddnKdKBUoRYqmoR0Xk5tvlrbenmF8HmCFjfA3e/A9C6HdOndOevPspPcautkx/Tnc8X/7WFQE2W3qMijj26D+uVVxT/xp8QiFl5v74y6H4TFOpjKR52Uq99VyU156dsgYgp1VSiuJQuMpGBLZEVVgETO/BuZPNy5NdjKXAITJaPC6FGGcVk3hqN6trgNQ+puZ8wpzCPHw6AEzxAi1u0Cw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=mSKBMaMlQ72LjwEvlwgMucZB8noIvWLEX5d1n8DmEX0=;\n b=GiGAIongO0AVFjNSdAzYB2XJmt9eyV3EmrQdjktrW4S45QTvJSVgqjCYkCX7QZF7oAJYduwlijzoKwWuwG+ru0ks74lTX6lReOOpdmMfDqEPZ2JXNXWxkKqdW6QbtnSwXBdWCBmHxN9WoTyV8cG0j2wbtF7utJlDkigs+MsBQW4wzPTe2XHWIQlH9gDVqUjL+rRFUyLvv18I+5fXV0Nmm/5wP4X9l5mhMwWmuq7M2/0VcyygVNoiBmBJPrBS8w9bNcjRvixbmO5BTOLdoahqWIDD9EtCpAYwpAZtOiCTH55IPRxBcrtB2hqyMAiERvza8jzjae41rcid6yWuGD2o/w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=mSKBMaMlQ72LjwEvlwgMucZB8noIvWLEX5d1n8DmEX0=;\n b=BQNbeo2jnjN4IgDjT6Mjb0IBPAYpcD50jehwvQKDKHF8EDWiml8SaqBr5/OJ4vfY5fzTp7uPEXf7dmoKRzqQFdToSuG6bvF50Of2061OO9HLGXuUZR0r7hXhbOiFDM86jSzj92SnibUIYyZAjLfokwMJgATQJ9Tp3TSZ/WJ5m9k=", "From": "Parav Pandit <parav@mellanox.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon\n <thomas@monjalon.net>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"grive@u256.net\" <grive@u256.net>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Raslan Darawsheh\n <rasland@mellanox.com>, Ori Kam <orika@mellanox.com>, Matan Azrad\n <matan@mellanox.com>, \"joyce.kong@arm.com\" <joyce.kong@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "Thread-Index": "AQHWYS0v/wbmxgA1t0ybPTrTM2yq66kWktYAgAAsyOCAAAHygIAAD4eAgAAHbkA=", "Date": "Fri, 24 Jul 2020 15:17:38 +0000", "Message-ID": "\n <AM0PR05MB4866596C70120AF807755B08D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>\n <4937496.TfPSyrM900@thomas>\n <20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com>", "In-Reply-To": "<20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[106.51.108.81]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "d5b3e46f-63e0-4584-18dd-08d82fe4b3ac", "x-ms-traffictypediagnostic": "AM0PR05MB4210:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB421017616FCBF3F6006D74D1D1770@AM0PR05MB4210.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:4303;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n +GMK8zKAx7GxRxRS1ToaZGsc9+Tmb3eFYNZM/TAIP47zK8DSDekDkeG5QAXkMG1yxMeoxx2zmvcUKFgIQqaQP3RONiAny06bm5uRCO+lX7rLXoyls5G8rm2eecqzw/XsdtUsQHUIMtkmUMUdvIrhOuxuBEKdE559aGM3C73u0hPnDAM3sIlOHLuy4mb0TwzgnLDGTvtGiSu/yPnOwU5zKbGXqI2HfFq6jmN8qM0j/aphtkTQQVJtVt944t3XmvxXg3d+dynMtZCNVtxXBiOsKjje1CBzMJb06v0xYHMWPxCnjPw3LehCbX7n2z3Ng+kwcJUVHepw/x9A0VXexWMU5A==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(316002)(8676002)(5660300002)(86362001)(71200400001)(52536014)(26005)(33656002)(186003)(8936002)(2906002)(66946007)(55016002)(66556008)(76116006)(66476007)(110136005)(4326008)(9686003)(54906003)(478600001)(7696005)(64756008)(55236004)(6506007)(66446008)(83380400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n 3eoHQaflsRinSuC2076XtNf2MefGEUaNSlMl0SJR0Ulikt351tLKr5wfJWA42W0UxJ1+CTWfsIYA6TG1ZZDSApjWfH3lmGBMjC/YtV0t4aAJIOTMz/stnvlMkXmqnFLFrf4OQlQTn+Ak7eK4+URilTvi16ktgwfjPxm9dSc1BAu0k5m2hAPVsTALXPv4mdg/x0Fc7Z3hGkbI4Dk0IcDWK9L7EtWHkCkp8G/0GenoBNfJZqqoL1cKXUtvDxEvlIAr2qiv9HiZ7WliLfWwNNDEa8ogjERFOKMW+EghkiRMhSpDZ6+6fC0nMmisW3uo9oYFZi1hRzHOKnoV1I0QncgLbfpmYopJcgbiD2Z681A8nDQVll+BfmN8Uk+cbQY8S0p/iqPNcEqdZfDITK6XBy/ad6mSd7RgdoN/hT7UqROLP242u3pNC4iZk8XaJ7hMSDYLIZ65/7ZSRhXB+yuUMzZp+MhIuqbA/ajIjDiTKQTU6xmX6p7s/w4LcvFVspuHyr7W", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4866.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d5b3e46f-63e0-4584-18dd-08d82fe4b3ac", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 15:17:38.5265 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 3zq/0crSp6tFQ+K4IRevw6t6ixWz52t3aZKbTsoN7slruNtBf828HsDqWLI9fflCB5qHlonMlPs6WsPt3AtknQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4210", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116620, "web_url": "https://patches.dpdk.org/comment/116620/", "msgid": "<20200724152949.GD2305@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724152949.GD2305@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-24T15:29:49", "subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Fri, Jul 24, 2020 at 03:17:38PM +0000, Parav Pandit wrote:\n> \n> \n> > From: Bruce Richardson <bruce.richardson@intel.com>\n> > Sent: Friday, July 24, 2020 8:20 PM\n> > \n> > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote:\n> > > 24/07/2020 15:48, Parav Pandit:\n> > > > Hi Bruce,\n> > > >\n> > > > > From: Bruce Richardson <bruce.richardson@intel.com>\n> > > > > Sent: Friday, July 24, 2020 4:37 PM\n> > > > >\n> > > > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote:\n> > > > > > From: Thomas Monjalon <thomas@monjalon.net>\n> > > > > >\n> > > > > > Drivers dependencies are evaluated in the order defined per\n> > > > > > their parent directory (also called class).\n> > > > > > This strict ordering prevent from having 2 different drivers of\n> > > > > > the same class with different dependencies ordering.\n> > > > > > This problem occurs if drivers/common/mlx5 depends on\n> > > > > > drivers/bus/pci, while drivers/bus/dpaa depends on\n> > drivers/common/dpaax.\n> > > > > > Having a strict ordering between directories bus and common is\n> > > > > > too much restrictive.\n> > > > > >\n> > > > > > That's why it is made possible to have a more fine-grain\n> > > > > > directory list, adding a driver sub-directory in the list.\n> > > > > > In this case, the isolated driver must be removed from its class\n> > > > > > list, and added directly in drivers/meson.build.\n> > > > > > Also, the per-class variables must be duplicated in the isolated\n> > > > > > driver, because the call \"subdir(class)\" is skipped in the isolated driver\n> > case.\n> > > > > >\n> > > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> > > > >\n> > > > > The commit log above has some strange word-wrapping, and\n> > > > > occasionally strange phrasing. I think it could be slightly reworded,\n> > perhaps as:\n> > > > >\n> > > > I updated the commit log as you suggested below along with RB, ack tag.\n> > > > Thank you.\n> > > >\n> > > > > Drivers dependencies are evaluated in the order defined per their\n> > parent\n> > > > > directory (also called class). This strict ordering prevents\n> > > > > from us\n> > >\n> > > Is \"from us\" too much?\n> > \n> > The word \"from\" is incorrect, anyway, it should just be \"prevents us\".\n> > Evidently I didn't proofread my own text well enough. :-(\n> \n> In v10 I rephase it as \"strict ordering prevents from having pairs of drivers...\".\n\nGreat, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15D77A052A;\n\tFri, 24 Jul 2020 17:30:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C4841C02D;\n\tFri, 24 Jul 2020 17:29:59 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 4A5FD1C02A\n for <dev@dpdk.org>; Fri, 24 Jul 2020 17:29:56 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jul 2020 08:29:55 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.251.87.116])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 24 Jul 2020 08:29:52 -0700" ], "IronPort-SDR": [ "\n dTw60xh8n+MGvHQ+FjOuVD+IGTTUke3damGOHRZn3bUBET+OFvROJcfbP6KpyJblTpFljl22O8\n MtStJCG0ZNrA==", "\n 995olobjBUHWorKW/2wIZKQqOqCIlfiAYoDUrTTOIlF60G53rLvw/w8awi6f4+Htkj/YcH3Ewg\n XDjHJWaiQQiQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9692\"; a=\"152010406\"", "E=Sophos;i=\"5.75,391,1589266800\"; d=\"scan'208\";a=\"152010406\"", "E=Sophos;i=\"5.75,391,1589266800\"; d=\"scan'208\";a=\"489241541\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Fri, 24 Jul 2020 16:29:49 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Parav Pandit <parav@mellanox.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, \"dev@dpdk.org\" <dev@dpdk.org>,\n \"grive@u256.net\" <grive@u256.net>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>,\n Raslan Darawsheh <rasland@mellanox.com>,\n Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>,\n \"joyce.kong@arm.com\" <joyce.kong@arm.com>", "Message-ID": "<20200724152949.GD2305@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com>\n <AM0PR05MB4866DD854EA53813E7A16557D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>\n <4937496.TfPSyrM900@thomas>\n <20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com>\n <AM0PR05MB4866596C70120AF807755B08D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "\n <AM0PR05MB4866596C70120AF807755B08D1770@AM0PR05MB4866.eurprd05.prod.outlook.com>", "Subject": "Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]