Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74693/?format=api
{ "id": 74693, "url": "https://patches.dpdk.org/api/patches/74693/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723200910.376581-4-parav@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723200910.376581-4-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723200910.376581-4-parav@mellanox.com", "date": "2020-07-23T20:09:03", "name": "[v8,03/10] drivers: relax dependency order", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d46fcff59c8d134dca8601ad12273acf660ecec3", "submitter": { "id": 1780, "url": "https://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723200910.376581-4-parav@mellanox.com/mbox/", "series": [ { "id": 11259, "url": "https://patches.dpdk.org/api/series/11259/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11259", "date": "2020-07-23T20:09:00", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 8, "mbox": "https://patches.dpdk.org/series/11259/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74693/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6260DA0518;\n\tThu, 23 Jul 2020 22:10:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C82F01C034;\n\tThu, 23 Jul 2020 22:09:40 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr130082.outbound.protection.outlook.com [40.107.13.82])\n by dpdk.org (Postfix) with ESMTP id AC0571C010\n for <dev@dpdk.org>; Thu, 23 Jul 2020 22:09:37 +0200 (CEST)", "from DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32)\n by DB7PR05MB5558.eurprd05.prod.outlook.com (2603:10a6:10:5c::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul\n 2020 20:09:36 +0000", "from DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293]) by DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293%5]) with mapi id 15.20.3216.022; Thu, 23 Jul 2020\n 20:09:36 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n DM6PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:40::22) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.21 via Frontend Transport; Thu, 23 Jul 2020 20:09:33 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=kbXOEkqveqq9LHyXrntCw1kEtC1wrX8xN6z4PV0VJWwemTxEFDW4qrKsKn4uwrumGUoQ3CNgpo2sXS38ZC/TywQiIHREcjrRcPWnlS5irlA+eybshBMcfz2YkvJs+peaEUTM/cj870TR6zpoDjnSoci+5/6Q3/lhrHajCc4QNZGPOSHYu4Mh2aHFevrBuF5Wr7mI2XPXZwh5Zs9i03b37kplR1loxstWToYXdX4IIDwOh3foLxaahY5LT4n9qXHIT4LZWRHreeLkgoTeXKm+eczIfO2ePO2JeW2ZWkGq9W/6ZSiNeJh0AcsW+dUzlXzTutiDHi8aJGqWB5OTSRgeTw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=MjNOGm4Tsp53oTLnQVKVXYU2P5oIovtR4NTCvdLei3M=;\n b=c4oEFyQHGIAk8JsZz2QPZWC3pg4p+jVnuqVafPAK0kImVgpwzQd+IINPY2duawzITXeUivaho9RM9LQBSgISk1s+wZCU97X6fFK8kfow208D7Rplu2gPUIHRGZFH3MWqz0s4pk6R0cNFhc5M4yyjvMEZL88x2BpkPnn+qCaIoQaVQyLEpaZsm93xD7kkTpmG2sdZtDdJvT7Djlf+ywBuEFYJa99x1QH5VemeIyxdHIQfPtbp2iTpDNxezEe0rRAFZD5xxQqvAbjfb1AgfPL63gA7opccbAVIznx3xzX6jmLjNZAYXGxo9jqgew8rj//GREckp15e8Na1v9/HCzSoYg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=MjNOGm4Tsp53oTLnQVKVXYU2P5oIovtR4NTCvdLei3M=;\n b=YdsuCJBUz91L30+NoJ/mZmA+PknCu7OE+LijAwDgitlxLKtNMfAHRPkLO+bdPO8qju5jIN/zo+nEa5gWL6hQmJ9VkLiqyt5wywiEihciBdCXyfoyBSpeeFnZjrArhD1I32J2a0aXyy1FF5J9N1X9ZA5yE+8FgCLuN7NYNSar3aw=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com", "Date": "Thu, 23 Jul 2020 23:09:03 +0300", "Message-Id": "<20200723200910.376581-4-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200723200910.376581-1-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "DM6PR03CA0009.namprd03.prod.outlook.com\n (2603:10b6:5:40::22) To DB7PR05MB4876.eurprd05.prod.outlook.com\n (2603:10a6:10:1d::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "4b44ede1-fe16-4ee9-9182-08d82f4451ce", "X-MS-TrafficTypeDiagnostic": "DB7PR05MB5558:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB7PR05MB555816DA5027646D580D6139D1760@DB7PR05MB5558.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n C7WWIcFzntKKW2V6AUgn8eGvyLWLoL/e9s6VWjci9N400h6/DrEmEKCDN0eUIVIelN7GhoANjVU81wGzDTddI0IyAa8/E8QMDHmPvprM1hsUWhbGbgtN17KfT7rC4HOcmEYc5QkD45FRrqQlLVsGjGBxHGUr4f+7AiVgADXepqD8QSmhUMUHhsC53jW5+EKzNZtQdUiwG2Vmkvtnqqd4xIPayRR6Gjl7jNtLEUQy5PLBKx77OO2pbyMUbKW1FlxF/Lgp/QnUR4qmHfu4pMII5+aHzJhT7tiZiBLUY0q4Lkh38pqozVz9Ql8znoJsHVSmaKWXB+qnLgk65f3uB9iFgQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR05MB4876.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(6506007)(8676002)(8936002)(26005)(52116002)(2906002)(4326008)(478600001)(66946007)(66476007)(66556008)(83380400001)(36756003)(5660300002)(2616005)(6486002)(86362001)(956004)(1076003)(6512007)(6666004)(186003)(16526019)(316002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n 3ht+hPDMQQzo79R4AuiLDsC860V8JalK3K5iaB/lnPVuBQTC6OiGgA4XTDCc4ZeJf8TzT7/CDUL5nu1+RpkPEMmUVczjQnkUIAKZYWs0P0Z88qbfEYESl4tqQhNOM36ydyeqZQyg/LJsX1e/BI4ViL+QCQu8XolP8LY+uG6dJIrfJhPKW1nHhf2piBWOMuTjvGfd0v7L4yNGv5ReCxukispTOCx7ClFKxFZQ1ggVFiW5PcvFfnbE6iBUux63Ydva8mwCGeWC7Hx+FsyscosviXuGzN1R0Poq8twT3yitXECqozrm6G37W3rNkT/+R0cVTwsN06JroZ4SB+l0iG/lb2Et5gNy/LXQDXZmE2IZMZ2TehDLjAZqLZbU68GqYmjI4dhJ9GghDXZFRL8RWmM/ittjg/SpuQqMewT6JKIRLsncqndhbsERJFZXk1UwgMv0E+SyzlQFqvb2etljGpnjvqLRbbgHRZ4fng6Jw5pygn6erOnSu1fDfdyJ4yWaE8kH", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4b44ede1-fe16-4ee9-9182-08d82f4451ce", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR05MB4876.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jul 2020 20:09:35.1607 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n faXKUij/AbAidAf9qpztt5AivksGbOw6gwJlMgasD7UFYKE+JyBokYUmUlVRP0rbqEJNFSLkaIGMjVcXcY42aw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR05MB5558", "Subject": "[dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Thomas Monjalon <thomas@monjalon.net>\n\nDrivers dependencies are evaluated in the order defined per\ntheir parent directory (also called class).\nThis strict ordering prevent from having 2 different drivers\nof the same class with different dependencies ordering.\nThis problem occurs if drivers/common/mlx5 depends on drivers/bus/pci,\nwhile drivers/bus/dpaa depends on drivers/common/dpaax.\nHaving a strict ordering between directories bus and common\nis too much restrictive.\n\nThat's why it is made possible to have a more fine-grain directory list,\nadding a driver sub-directory in the list.\nIn this case, the isolated driver must be removed from its class list,\nand added directly in drivers/meson.build.\nAlso, the per-class variables must be duplicated in the isolated driver,\nbecause the call \"subdir(class)\" is skipped in the isolated driver case.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/meson.build | 28 +++++++++++++++++++++-------\n 1 file changed, 21 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex e2aeba931..e6d0409aa 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -1,8 +1,8 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017-2019 Intel Corporation\n \n-# Defines the order in which the drivers are buit.\n-dpdk_driver_classes = [\n+# Defines the order of dependencies evaluation\n+subdirs = [\n \t'common',\n \t'bus',\n \t'mempool', # depends on common and bus.\n@@ -27,7 +27,7 @@ if cc.has_argument('-Wno-format-truncation')\n \tdefault_cflags += '-Wno-format-truncation'\n endif\n \n-foreach class:dpdk_driver_classes\n+foreach subpath:subdirs\n \tdrivers = []\n \tstd_deps = []\n \tconfig_flag_fmt = '' # format string used to set the value in dpdk_conf\n@@ -35,8 +35,22 @@ foreach class:dpdk_driver_classes\n \t # the library, the dependency and to find the\n \t # version file for linking\n \n-\tsubdir(class)\n-\tclass_drivers = []\n+\t# subpath can be either \"class\" or \"class/driver\"\n+\tif subpath.contains('/')\n+\t\tdriver_path = subpath.split('/')\n+\t\tclass = driver_path[0]\n+\t\tdrivers += driver_path[1]\n+\telse\n+\t\tclass = subpath\n+\t\tsubdir(class)\n+\tendif\n+\n+\t# save class name on first occurence\n+\tif not dpdk_driver_classes.contains(class)\n+\t\tdpdk_driver_classes += class\n+\tendif\n+\t# get already enabled drivers of the same class\n+\tenabled_drivers = get_variable(class + '_drivers', [])\n \n \tforeach drv:drivers\n \t\tdrv_path = join_paths(class, drv)\n@@ -96,7 +110,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\t\t\t'_disable_reason', reason)\n \t\t\tendif\n \t\telse\n-\t\t\tclass_drivers += name\n+\t\t\tenabled_drivers += name\n \n \t\t\tif fmt_name == ''\n \t\t\t\tfmt_name = name\n@@ -203,5 +217,5 @@ foreach class:dpdk_driver_classes\n \t\tendif # build\n \tendforeach\n \n-\tset_variable(class + '_drivers', class_drivers)\n+\tset_variable(class + '_drivers', enabled_drivers)\n endforeach\n", "prefixes": [ "v8", "03/10" ] }