Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74533/?format=api
{ "id": 74533, "url": "https://patches.dpdk.org/api/patches/74533/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1595319220-173871-1-git-send-email-bingz@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1595319220-173871-1-git-send-email-bingz@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1595319220-173871-1-git-send-email-bingz@mellanox.com", "date": "2020-07-21T08:13:40", "name": "vdpa/mlx5: fix the compatibility with MISC4", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "63f0164400b93942f27145e7f1e657c397b9e5f7", "submitter": { "id": 1357, "url": "https://patches.dpdk.org/api/people/1357/?format=api", "name": "Bing Zhao", "email": "bingz@mellanox.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1595319220-173871-1-git-send-email-bingz@mellanox.com/mbox/", "series": [ { "id": 11195, "url": "https://patches.dpdk.org/api/series/11195/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11195", "date": "2020-07-21T08:13:40", "name": "vdpa/mlx5: fix the compatibility with MISC4", "version": 1, "mbox": "https://patches.dpdk.org/series/11195/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74533/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 063FCA0526;\n\tTue, 21 Jul 2020 10:14:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A99E1BFE3;\n\tTue, 21 Jul 2020 10:14:11 +0200 (CEST)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 7E43E1BFBA\n for <dev@dpdk.org>; Tue, 21 Jul 2020 10:14:09 +0200 (CEST)" ], "From": "Bing Zhao <bingz@mellanox.com>", "To": "viacheslavo@mellanox.com,\n\tmatan@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Tue, 21 Jul 2020 16:13:40 +0800", "Message-Id": "<1595319220-173871-1-git-send-email-bingz@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix the compatibility with MISC4", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When dynamic flex parser feature is introduced, the support for misc\nparameters 4 of flow table entry (FTE) match set is needed. The\nstructure of \"mlx5_ifc_fte_match_param_bits\" is extended with\n\"mlx5_ifc_fte_match_set_misc4_bits\" at the end of it. The total size\nof the FTE match set will be changed into 384 bytes from 320 bytes.\nLow level user space driver (rdma-core) will have the validation of\nthe length of FTE match set. In the old release that no MISC4\nsupported in the rdma-core, and this will break the backward\ncompatibility, even if the MISC4 is not used in most cases, like\nin vDPA driver.\nIn order not to break the compatibility old rdma-core, the length\nadjustment needs to be done. In mlx5 vDPA driver, the lengths of\nthe matcher and value are both set to 320 without MISC4. There is\nno need to change the structure definition, all bytes of the MISC4\nwill be discarded if it is not needed. Since the MISC4 parameter\nis aligned with a 64B boundary and so does the whole FTE match set\nparameter, there is no need to take any padding and alignment into\nconsideration when calculating the size.\n\nFixes: 32132fb8517c (\"net/mlx5: add flow translation of eCPRI header\")\n\nSigned-off-by: Bing Zhao <bingz@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_steer.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_steer.c b/drivers/vdpa/mlx5/mlx5_vdpa_steer.c\nindex 406c7be..1fcd24c 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_steer.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_steer.c\n@@ -139,10 +139,12 @@\n \t\tuint32_t buf[MLX5_ST_SZ_DW(fte_match_param)];\n \t\t/**< Matcher value. This value is used as the mask or a key. */\n \t} matcher_mask = {\n-\t\t\t\t.size = sizeof(matcher_mask.buf),\n+\t\t\t\t.size = sizeof(matcher_mask.buf) -\n+\t\t\t\t\tMLX5_ST_SZ_BYTES(fte_match_set_misc4),\n \t\t\t},\n \t matcher_value = {\n-\t\t\t\t.size = sizeof(matcher_value.buf),\n+\t\t\t\t.size = sizeof(matcher_value.buf) -\n+\t\t\t\t\tMLX5_ST_SZ_BYTES(fte_match_set_misc4),\n \t\t\t};\n \tstruct mlx5dv_flow_matcher_attr dv_attr = {\n \t\t.type = IBV_FLOW_ATTR_NORMAL,\n", "prefixes": [] }