Patch Comment List
List patch comments
GET /api/patches/73523/comments/?format=api
[ { "id": 115517, "web_url": "https://patches.dpdk.org/comment/115517/", "msgid": "<91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu", "date": "2020-07-08T13:09:16", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1310, "url": "https://patches.dpdk.org/api/people/1310/?format=api", "name": "Ray Kinsella", "email": "mdr@ashroe.eu" }, "content": "+ Aaron\n\nOn 08/07/2020 11:22, David Marchand wrote:\n> abidiff can provide some more information about the ABI difference it\n> detected.\n> In all cases, a discussion on the mailing must happen but we can give\n> some hints to know if this is a problem with the script calling abidiff,\n> a potential ABI breakage or an unambiguous ABI breakage.\n> \n> Signed-off-by: David Marchand <david.marchand@redhat.com>\n> ---\n> devtools/check-abi.sh | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n> index e17fedbd9f..521e2cce7c 100755\n> --- a/devtools/check-abi.sh\n> +++ b/devtools/check-abi.sh\n> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n> \t\terror=1\n> \t\tcontinue\n> \tfi\n> -\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n> +\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n> +\t\tabiret=$?\n> \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n> \t\terror=1\n> -\tfi\n> +\t\techo\n> +\t\tif [ $(($abiret & 3)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 4)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 8)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n> +\t\tfi\n> +\t\techo\n> +\t}\n> done\n> \n> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n> \n\nThis look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis.\nAt the moment it takes time to find the failure reason in the Travis log.\n\nRay K", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3117BA0526;\n\tWed, 8 Jul 2020 15:09:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C85E91DB13;\n\tWed, 8 Jul 2020 15:09:24 +0200 (CEST)", "from dal2relay155.mxroute.com (dal2relay155.mxroute.com\n [64.40.26.155]) by dpdk.org (Postfix) with ESMTP id 175C11DAF3\n for <dev@dpdk.org>; Wed, 8 Jul 2020 15:09:22 +0200 (CEST)", "from filter003.mxroute.com ([168.235.111.26]\n 168-235-111-26.cloud.ramnode.com)\n (Authenticated sender: mN4UYu2MZsgR)\n by dal2relay155.mxroute.com (ZoneMTA) with ESMTPSA id 1732e8b7fe20005b7b.001\n for <dev@dpdk.org>\n (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256);\n Wed, 08 Jul 2020 13:09:20 +0000", "from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109])\n by filter003.mxroute.com (Postfix) with ESMTPS id 06233626A4;\n Wed, 8 Jul 2020 13:09:20 +0000 (UTC)" ], "X-Zone-Loop": "ad7f07d96f269b8bd15861aba6719f043dfc3ec396e9", "X-Originating-IP": "[168.235.111.26]", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu;\n s=x;\n h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:\n Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=AMZ8eDx52RCicAdmqGRRPfk/+dxm2OeCRKu676lrpBo=; b=SSYHPRUCSiMtICbdsj5cvuzUlW\n U1rSqhVudmQxKj7yNupr/fUebtwru7Z5XoShhGKjnCxaCYy4nGRO70Vtm2EPMItdF4iI1+oJpx2gY\n EZDtfp+I+r13hYxmlrGtP53xEymF2jeWIZEFjE4vGOQWObrMaVkZVptOGSCjruLL7aHd1ptuk0OOe\n hiStfUmZKpV0/61zcDHcNldQqS8aiTazj8As0pInXiOa2/t+MFMkSrxKvlKo6ZwUB/YKe/Fw/fWIn\n bWcIkPIyGWIlyAU/CXU7MZFK3tmi4aESt7iBY+CpXk4GM179uVIWhtZpJcd44aGHIVv3f/WOW/FKk\n Xxeaz7PA==;", "To": "David Marchand <david.marchand@redhat.com>, dev@dpdk.org", "Cc": "thomas@monjalon.net, dodji@redhat.com, Neil Horman\n <nhorman@tuxdriver.com>, Aaron Conole <aconole@redhat.com>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>", "From": "\"Kinsella, Ray\" <mdr@ashroe.eu>", "Autocrypt": "addr=mdr@ashroe.eu; keydata=\n mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6\n ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s\n JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j\n HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr\n S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS\n uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++\n YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux\n TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH\n bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5\n 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs\n bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8\n B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE\n msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn\n B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f\n VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a\n 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7\n JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt\n TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1\n +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD\n dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL\n 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC\n VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5\n xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC\n hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5\n pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S\n OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v\n ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1\n pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt\n 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj\n tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y\n yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u\n AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ\n CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf\n u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17\n c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA\n thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK\n +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8\n pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2\n GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75\n QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l\n BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ\n wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg==", "Message-ID": "<91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>", "Date": "Wed, 8 Jul 2020 14:09:16 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200708102212.3311-1-david.marchand@redhat.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-AuthUser": "mdr@ashroe.eu", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115518, "web_url": "https://patches.dpdk.org/comment/115518/", "msgid": "<CAJFAV8yZwkRnXaCk30P4q-Kuu1kaQoKx8inSsoswCdAtJq90AQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8yZwkRnXaCk30P4q-Kuu1kaQoKx8inSsoswCdAtJq90AQ@mail.gmail.com", "date": "2020-07-08T13:15:25", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jul 8, 2020 at 3:09 PM Kinsella, Ray <mdr@ashroe.eu> wrote:\n>\n> + Aaron\n>\n> On 08/07/2020 11:22, David Marchand wrote:\n> > abidiff can provide some more information about the ABI difference it\n> > detected.\n> > In all cases, a discussion on the mailing must happen but we can give\n> > some hints to know if this is a problem with the script calling abidiff,\n> > a potential ABI breakage or an unambiguous ABI breakage.\n> >\n> > Signed-off-by: David Marchand <david.marchand@redhat.com>\n> > ---\n> > devtools/check-abi.sh | 16 ++++++++++++++--\n> > 1 file changed, 14 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n> > index e17fedbd9f..521e2cce7c 100755\n> > --- a/devtools/check-abi.sh\n> > +++ b/devtools/check-abi.sh\n> > @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n> > error=1\n> > continue\n> > fi\n> > - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n> > + abidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n> > + abiret=$?\n> > echo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n> > error=1\n> > - fi\n> > + echo\n> > + if [ $(($abiret & 3)) != 0 ]; then\n> > + echo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n\nForgot to --amend.\nHopefully yes, this will be reported to dev@dpdk.org... I wanted to\nhighlight this could be a script or env issue.\n\n\n> > + fi\n> > + if [ $(($abiret & 4)) != 0 ]; then\n> > + echo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n> > + fi\n> > + if [ $(($abiret & 8)) != 0 ]; then\n> > + echo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n> > + fi\n> > + echo\n> > + }\n> > done\n> >\n> > [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n> >\n>\n> This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis.\n> At the moment it takes time to find the failure reason in the Travis log.\n\nI usually look for \"FILES_TO\" to get to the last error.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B868A0526;\n\tWed, 8 Jul 2020 15:15:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA2351DB13;\n\tWed, 8 Jul 2020 15:15:41 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A3FD11DAF3\n for <dev@dpdk.org>; Wed, 8 Jul 2020 15:15:40 +0200 (CEST)", "from mail-vs1-f69.google.com (mail-vs1-f69.google.com\n [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-140-THlY8E3ZMo-mA775Da2R-A-1; Wed, 08 Jul 2020 09:15:38 -0400", "by mail-vs1-f69.google.com with SMTP id a203so427683vsd.5\n for <dev@dpdk.org>; Wed, 08 Jul 2020 06:15:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594214140;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=FH0ss0gWwMTe/IFw+gSWu01yCSixNV8QCmtlBOHmaCk=;\n b=f8Iq1zqvJb6/yOTAY0W+TLF/hhueKm4P3tvDWZWd0ZCHh70RRYwBrA9YoS6iAsuiRfqwYe\n hpjhOtDHkVrAd9mnzQkqu/A+dMSC/QGZMrWv1eZj8u+wFU9hVAGXfOGBlYWF2q9FFeWf7l\n sYLgeIcZ/cMFGe9E1ZAxxPPzW3k1X6M=", "X-MC-Unique": "THlY8E3ZMo-mA775Da2R-A-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=FH0ss0gWwMTe/IFw+gSWu01yCSixNV8QCmtlBOHmaCk=;\n b=nyd9PmvXFyLUi9JaWMiFNwkL85zYBSKA++FtRdZ/DNOZh6Cw7kRj5v4A7CJZpQ9ui1\n zNZND8U7S6YG/m0HI7/eLJaURBe8XDqL70EVIKDgMiRNAINZ9AfDLcFy1OKJZmgqKtwZ\n rK2KxJaYWUysCifMTqDouKl5qkgkhZLr1LFS4ku2en31fTeF6GhMFa+1IU9jdvWEphDr\n hBrpBkSi9m/EDTavTYqkQUH4bEzv5Vka/Y9qYiEXycB1Co3ho6JHBCIXD2wkYpMEDEVn\n Nur1NnrraSObTik2BykrLs5b4XnkXMZzig3sqvgReFndSdCVzIRc5xSiRqoXoa5WqVaG\n 3+DQ==", "X-Gm-Message-State": "AOAM532m0LzRPHBamVYsCtJlpwSU724dohm7JiRPVwf27HimXnsJ51sL\n hR2L7mi2hTa5m7ZLxN8D5aWW+cnFq44ZOOVCxBduXiAlBRFaqUXP7BsaH1UlkgvPj6EPbmYhvuO\n 8l3IHEjcPTlTlJm0PxmQ=", "X-Received": [ "by 2002:ab0:6950:: with SMTP id c16mr10938893uas.53.1594214136987;\n Wed, 08 Jul 2020 06:15:36 -0700 (PDT)", "by 2002:ab0:6950:: with SMTP id c16mr10938866uas.53.1594214136748;\n Wed, 08 Jul 2020 06:15:36 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJyAfFIaP/CO9SZbwY2F0KxDMSDwb/QS/LLHrfPr27M56g4HNGsy6ZN+A+pJqkuW+tSg6fRE9u+n05lpR+jfiFc=", "MIME-Version": "1.0", "References": "<20200708102212.3311-1-david.marchand@redhat.com>\n <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>", "In-Reply-To": "<91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 8 Jul 2020 15:15:25 +0200", "Message-ID": "\n <CAJFAV8yZwkRnXaCk30P4q-Kuu1kaQoKx8inSsoswCdAtJq90AQ@mail.gmail.com>", "To": "\"Kinsella, Ray\" <mdr@ashroe.eu>", "Cc": "dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n Dodji Seketeli <dodji@redhat.com>,\n Neil Horman <nhorman@tuxdriver.com>, Aaron Conole <aconole@redhat.com>", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115520, "web_url": "https://patches.dpdk.org/comment/115520/", "msgid": "<f0f6cf1c-5d72-e807-b7bf-e14597bbec36@ashroe.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/f0f6cf1c-5d72-e807-b7bf-e14597bbec36@ashroe.eu", "date": "2020-07-08T13:22:30", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1310, "url": "https://patches.dpdk.org/api/people/1310/?format=api", "name": "Ray Kinsella", "email": "mdr@ashroe.eu" }, "content": "On 08/07/2020 14:15, David Marchand wrote:\n> On Wed, Jul 8, 2020 at 3:09 PM Kinsella, Ray <mdr@ashroe.eu> wrote:\n>>\n>> + Aaron\n>>\n>> On 08/07/2020 11:22, David Marchand wrote:\n>>> abidiff can provide some more information about the ABI difference it\n>>> detected.\n>>> In all cases, a discussion on the mailing must happen but we can give\n>>> some hints to know if this is a problem with the script calling abidiff,\n>>> a potential ABI breakage or an unambiguous ABI breakage.\n>>>\n>>> Signed-off-by: David Marchand <david.marchand@redhat.com>\n>>> ---\n>>> devtools/check-abi.sh | 16 ++++++++++++++--\n>>> 1 file changed, 14 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n>>> index e17fedbd9f..521e2cce7c 100755\n>>> --- a/devtools/check-abi.sh\n>>> +++ b/devtools/check-abi.sh\n>>> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n>>> error=1\n>>> continue\n>>> fi\n>>> - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n>>> + abidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n>>> + abiret=$?\n>>> echo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n>>> error=1\n>>> - fi\n>>> + echo\n>>> + if [ $(($abiret & 3)) != 0 ]; then\n>>> + echo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n> \n> Forgot to --amend.\n> Hopefully yes, this will be reported to dev@dpdk.org... I wanted to\n> highlight this could be a script or env issue.\n> \n> \n>>> + fi\n>>> + if [ $(($abiret & 4)) != 0 ]; then\n>>> + echo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n>>> + fi\n>>> + if [ $(($abiret & 8)) != 0 ]; then\n>>> + echo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n>>> + fi\n>>> + echo\n>>> + }\n>>> done\n>>>\n>>> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n>>>\n>>\n>> This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis.\n>> At the moment it takes time to find the failure reason in the Travis log.\n> \n> I usually look for \"FILES_TO\" to get to the last error.\n> \nRight, but there is hopefully a better way to give Travis some clues ...", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A761BA0527;\n\tWed, 8 Jul 2020 15:22:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B421A1DB13;\n\tWed, 8 Jul 2020 15:22:38 +0200 (CEST)", "from dal2relay189.mxroute.com (dal2relay189.mxroute.com\n [64.40.26.189]) by dpdk.org (Postfix) with ESMTP id 55E0C1DAA7\n for <dev@dpdk.org>; Wed, 8 Jul 2020 15:22:37 +0200 (CEST)", "from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com)\n (Authenticated sender: mN4UYu2MZsgR)\n by dal2relay189.mxroute.com (ZoneMTA) with ESMTPSA id 1732e979e880005b7b.001\n for <dev@dpdk.org>\n (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256);\n Wed, 08 Jul 2020 13:22:35 +0000", "from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109])\n by filter004.mxroute.com (Postfix) with ESMTPS id E5A553EDB0;\n Wed, 8 Jul 2020 13:22:32 +0000 (UTC)" ], "X-Zone-Loop": "f977ed4ab5735e56643c4dfa251b57e71a97ea39fd50", "X-Originating-IP": "[149.28.56.236]", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu;\n s=x;\n h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:\n Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=Jo2hBLAabFCuhEm98Kof7hxDpEZNODoEW5qq9BSGfO8=; b=OTdvDEvz6sVD8EvPPoY07rbZuv\n KrTaaFcUndZfamcKSr2nMT5HR9RNWpeCE+jTq4sIsISZQUjSoGX0lALmlsJOYWmv08h3D4JVvZ4SX\n Ose4W3cZuDBh0uo9SMTVXqVJVcp1tZtAa1zks09DM+5MF2mcZd37h+MVjZklH5EZYhWoYB4FulBwg\n u41FQrg2ZaDkKgM0Yvg/ATacRJNyFCTpRu0ik/2IJASTsJwImr4HEUekZTVrYA7tE4ApSQf7Uu4k6\n 6dkthXp0ngBkWeELgWyszHPl0UxyTojxSFwHkmPg17xvAQx7d+L5d73NZOrRwgAUvPUF7nJ1Ckbis\n EQZZMQlw==;", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n Dodji Seketeli <dodji@redhat.com>, Neil Horman <nhorman@tuxdriver.com>,\n Aaron Conole <aconole@redhat.com>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>\n <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>\n <CAJFAV8yZwkRnXaCk30P4q-Kuu1kaQoKx8inSsoswCdAtJq90AQ@mail.gmail.com>", "From": "\"Kinsella, Ray\" <mdr@ashroe.eu>", "Autocrypt": "addr=mdr@ashroe.eu; keydata=\n mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6\n ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s\n JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j\n HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr\n S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS\n uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++\n YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux\n TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH\n bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5\n 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs\n bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8\n B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE\n msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn\n B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f\n VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a\n 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7\n JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt\n TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1\n +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD\n dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL\n 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC\n VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5\n xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC\n hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5\n pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S\n OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v\n ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1\n pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt\n 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj\n tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y\n yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u\n AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ\n CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf\n u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17\n c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA\n thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK\n +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8\n pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2\n GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75\n QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l\n BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ\n wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg==", "Message-ID": "<f0f6cf1c-5d72-e807-b7bf-e14597bbec36@ashroe.eu>", "Date": "Wed, 8 Jul 2020 14:22:30 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "\n <CAJFAV8yZwkRnXaCk30P4q-Kuu1kaQoKx8inSsoswCdAtJq90AQ@mail.gmail.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-AuthUser": "mdr@ashroe.eu", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115524, "web_url": "https://patches.dpdk.org/comment/115524/", "msgid": "<f7to8oqxgrg.fsf@dhcp-25.97.bos.redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f7to8oqxgrg.fsf@dhcp-25.97.bos.redhat.com", "date": "2020-07-08T13:45:07", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 332, "url": "https://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "content": "\"Kinsella, Ray\" <mdr@ashroe.eu> writes:\n\n> + Aaron\n>\n> On 08/07/2020 11:22, David Marchand wrote:\n>> abidiff can provide some more information about the ABI difference it\n>> detected.\n>> In all cases, a discussion on the mailing must happen but we can give\n>> some hints to know if this is a problem with the script calling abidiff,\n>> a potential ABI breakage or an unambiguous ABI breakage.\n>> \n>> Signed-off-by: David Marchand <david.marchand@redhat.com>\n>> ---\n>> devtools/check-abi.sh | 16 ++++++++++++++--\n>> 1 file changed, 14 insertions(+), 2 deletions(-)\n>> \n>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n>> index e17fedbd9f..521e2cce7c 100755\n>> --- a/devtools/check-abi.sh\n>> +++ b/devtools/check-abi.sh\n>> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n>> \t\terror=1\n>> \t\tcontinue\n>> \tfi\n>> -\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n>> +\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n>> +\t\tabiret=$?\n>> \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n>> \t\terror=1\n>> -\tfi\n>> +\t\techo\n>> +\t\tif [ $(($abiret & 3)) != 0 ]; then\n>> +\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n>> +\t\tfi\n>> +\t\tif [ $(($abiret & 4)) != 0 ]; then\n>> +\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n>> +\t\tfi\n>> +\t\tif [ $(($abiret & 8)) != 0 ]; then\n>> +\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n>> +\t\tfi\n>> +\t\techo\n>> +\t}\n>> done\n>> \n>> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n>> \n>\n> This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis.\n> At the moment it takes time to find the failure reason in the Travis log.\n\nThat's a problem even for non-ABI failures. I was considering pulling\nthe travis log for each failed build and attaching it, but even that\nisn't a great solution (very large emails aren't much easier to search).\n\nI'm open to suggestions.\n\n> Ray K", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56BE4A0526;\n\tWed, 8 Jul 2020 15:45:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0BF41DC12;\n\tWed, 8 Jul 2020 15:45:24 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 9B2581DBBC\n for <dev@dpdk.org>; Wed, 8 Jul 2020 15:45:23 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-115-MKjuZAqOO4u80Bpwo4OFog-1; Wed, 08 Jul 2020 09:45:21 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 430E4108B;\n Wed, 8 Jul 2020 13:45:20 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (ovpn-114-181.rdu2.redhat.com\n [10.10.114.181])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id 80D702DE6D;\n Wed, 8 Jul 2020 13:45:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594215923;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=+360Jfsl+Ls2KjUcteGaZtUCFxC5Nn53fwaNQXaMvr4=;\n b=iXD7m6NeB3LNeEIYEnwViXGYRYtcrA2ohzzzulDG/apqTiyB/QBYO7jgwAxBRty95QKBfa\n H8q67x0/8J6723LDwgwoeVtezOrY0CRfWByG5U2dYxZpqbjpGJmRKXV7hSVTI4UkD0OVkQ\n 15ltHI2l7Ta0P30XWXkhibaiIUV1bzo=", "X-MC-Unique": "MKjuZAqOO4u80Bpwo4OFog-1", "From": "Aaron Conole <aconole@redhat.com>", "To": "\"Kinsella\\, Ray\" <mdr@ashroe.eu>", "Cc": "David Marchand <david.marchand@redhat.com>, dev@dpdk.org,\n thomas@monjalon.net, dodji@redhat.com, Neil Horman <nhorman@tuxdriver.com>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>\n <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>", "Date": "Wed, 08 Jul 2020 09:45:07 -0400", "In-Reply-To": "<91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu> (Ray Kinsella's\n message of \"Wed, 8 Jul 2020 14:09:16 +0100\")", "Message-ID": "<f7to8oqxgrg.fsf@dhcp-25.97.bos.redhat.com>", "User-Agent": "Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115529, "web_url": "https://patches.dpdk.org/comment/115529/", "msgid": "<71002960-9158-24dd-2810-cb05092fef10@ashroe.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/71002960-9158-24dd-2810-cb05092fef10@ashroe.eu", "date": "2020-07-08T14:01:29", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1310, "url": "https://patches.dpdk.org/api/people/1310/?format=api", "name": "Ray Kinsella", "email": "mdr@ashroe.eu" }, "content": "On 08/07/2020 14:45, Aaron Conole wrote:\n> \"Kinsella, Ray\" <mdr@ashroe.eu> writes:\n> \n>> + Aaron\n>>\n>> On 08/07/2020 11:22, David Marchand wrote:\n>>> abidiff can provide some more information about the ABI difference it\n>>> detected.\n>>> In all cases, a discussion on the mailing must happen but we can give\n>>> some hints to know if this is a problem with the script calling abidiff,\n>>> a potential ABI breakage or an unambiguous ABI breakage.\n>>>\n>>> Signed-off-by: David Marchand <david.marchand@redhat.com>\n>>> ---\n>>> devtools/check-abi.sh | 16 ++++++++++++++--\n>>> 1 file changed, 14 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n>>> index e17fedbd9f..521e2cce7c 100755\n>>> --- a/devtools/check-abi.sh\n>>> +++ b/devtools/check-abi.sh\n>>> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n>>> \t\terror=1\n>>> \t\tcontinue\n>>> \tfi\n>>> -\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n>>> +\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n>>> +\t\tabiret=$?\n>>> \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n>>> \t\terror=1\n>>> -\tfi\n>>> +\t\techo\n>>> +\t\tif [ $(($abiret & 3)) != 0 ]; then\n>>> +\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n>>> +\t\tfi\n>>> +\t\tif [ $(($abiret & 4)) != 0 ]; then\n>>> +\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n>>> +\t\tfi\n>>> +\t\tif [ $(($abiret & 8)) != 0 ]; then\n>>> +\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n>>> +\t\tfi\n>>> +\t\techo\n>>> +\t}\n>>> done\n>>> \n>>> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n>>>\n>>\n>> This look good to me, my only thought was can we do anything to help the ABI checks play nice with Travis.\n>> At the moment it takes time to find the failure reason in the Travis log.\n> \n> That's a problem even for non-ABI failures. I was considering pulling\n> the travis log for each failed build and attaching it, but even that\n> isn't a great solution (very large emails aren't much easier to search).\n> \n> I'm open to suggestions.\n\nFor me the problem arises when you log on to the Travis interface,\nyou need to search for ERROR etc ... there must a better way.\n\n> \n>> Ray K\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6983DA0526;\n\tWed, 8 Jul 2020 16:01:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 368DC1DDCC;\n\tWed, 8 Jul 2020 16:01:36 +0200 (CEST)", "from qrelay207.mxroute.com (qrelay207.mxroute.com [172.82.139.207])\n by dpdk.org (Postfix) with ESMTP id 985371DDCC\n for <dev@dpdk.org>; Wed, 8 Jul 2020 16:01:34 +0200 (CEST)", "from filter003.mxroute.com ([168.235.111.26]\n 168-235-111-26.cloud.ramnode.com)\n (Authenticated sender: mN4UYu2MZsgR)\n by qrelay207.mxroute.com (ZoneMTA) with ESMTPA id 1732ebb4a310009563.001\n for <dev@dpdk.org>; Wed, 08 Jul 2020 14:01:32 +0000", "from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109])\n by filter003.mxroute.com (Postfix) with ESMTPS id 2660D626AA;\n Wed, 8 Jul 2020 14:01:32 +0000 (UTC)" ], "X-Zone-Loop": "dbdb35cbdc4e3b2fed7e32985047f66757c3159a54d7", "X-Originating-IP": "[168.235.111.26]", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu;\n s=x;\n h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:\n Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=an0RMzwNXDR21TZkJxQr8W5ll0ImAYhBAVVzuh00rhA=; b=OXrMvPqo/ORnSGs5klHRvNd95c\n 9taWM5r6cTxyvuxvuKOhEWEn74e+aYIRRrlaI/h88dpx6bmL58DlS64T1Z+P+z+vcVVg9bHQ09QIg\n i5VHqEmLaVp6VigtN4cZTW7X8qY6Sb0K51Rki3UKtxkNEsOD0xjH4khzWaK5zMUBgLkOzEBpwtNbF\n l3Fz7biHqFYpYjz4j8T7rn5JNcYR+uamh1pSI2hwBoiD0Rmddiqp7zMjqBYNgBxKudbE9Y5UvWX5S\n uGYRerTwwNBmtW1z9vwUZqGR6+HIoY990u9nEoBuPMvs/tSOwuywF84xON4sASROxNJOr3w7xBaid\n H153YiYw==;", "To": "Aaron Conole <aconole@redhat.com>", "Cc": "David Marchand <david.marchand@redhat.com>, dev@dpdk.org,\n thomas@monjalon.net, dodji@redhat.com, Neil Horman <nhorman@tuxdriver.com>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>\n <91131575-31e7-5025-ee7e-0c6101efe3ad@ashroe.eu>\n <f7to8oqxgrg.fsf@dhcp-25.97.bos.redhat.com>", "From": "\"Kinsella, Ray\" <mdr@ashroe.eu>", "Autocrypt": "addr=mdr@ashroe.eu; keydata=\n mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6\n ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s\n JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j\n HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr\n S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS\n uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++\n YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux\n TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH\n bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5\n 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs\n bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8\n B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE\n msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn\n B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f\n VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a\n 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7\n JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt\n TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1\n +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD\n dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL\n 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC\n VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5\n xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC\n hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5\n pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S\n OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v\n ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1\n pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt\n 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj\n tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y\n yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u\n AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ\n CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf\n u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17\n c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA\n thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK\n +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8\n pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2\n GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75\n QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l\n BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ\n wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg==", "Message-ID": "<71002960-9158-24dd-2810-cb05092fef10@ashroe.eu>", "Date": "Wed, 8 Jul 2020 15:01:29 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<f7to8oqxgrg.fsf@dhcp-25.97.bos.redhat.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-AuthUser": "mdr@ashroe.eu", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115646, "web_url": "https://patches.dpdk.org/comment/115646/", "msgid": "<87r1tkptxw.fsf@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/87r1tkptxw.fsf@redhat.com", "date": "2020-07-09T15:52:11", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1690, "url": "https://patches.dpdk.org/api/people/1690/?format=api", "name": "Dodji Seketeli", "email": "dodji@redhat.com" }, "content": "Hello,\n\nDavid Marchand <david.marchand@redhat.com> writes:\n\n> abidiff can provide some more information about the ABI difference it\n> detected.\n> In all cases, a discussion on the mailing must happen but we can give\n> some hints to know if this is a problem with the script calling abidiff,\n> a potential ABI breakage or an unambiguous ABI breakage.\n>\n> Signed-off-by: David Marchand <david.marchand@redhat.com>\n\nFor what it's worth, the change looks good to me, at least from an\nabidiff perspective.\n\nThanks.\n\nCheers.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9ECF6A0528;\n\tThu, 9 Jul 2020 17:52:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E92CE1E89B;\n\tThu, 9 Jul 2020 17:52:19 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81])\n by dpdk.org (Postfix) with ESMTP id D51561E894\n for <dev@dpdk.org>; Thu, 9 Jul 2020 17:52:18 +0200 (CEST)", "from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-11-rchl7obOPLyFgedU5MXjhQ-1; Thu, 09 Jul 2020 11:52:16 -0400", "by mail-wr1-f70.google.com with SMTP id b8so2290769wro.19\n for <dev@dpdk.org>; Thu, 09 Jul 2020 08:52:16 -0700 (PDT)", "from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130])\n by smtp.gmail.com with ESMTPSA id 12sm5089075wmg.6.2020.07.09.08.52.13\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 09 Jul 2020 08:52:13 -0700 (PDT)", "by localhost (Postfix, from userid 1000)\n id DECB1180092E; Thu, 9 Jul 2020 17:52:11 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594309938;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=JBC6YN/HJvZioNSIml9zdPDy3/jFHAUUUcCUJ9242uw=;\n b=EhU/4opqStNd7Dwy2OftXqHHHba6us5xdmVX0EF6rw47qEBX7KDvwMQkeFwJq5G7BRp+wr\n F+4sbwhwBXYyroQJzPj2/HYNji113+lKirQgP/tQYwuynp7YAQSadW+IkeVQ1tdMGc9c+H\n XupNiwqdhXUQ48FAcjG6xvJha3sO0qo=", "X-MC-Unique": "rchl7obOPLyFgedU5MXjhQ-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:organization:references:date\n :in-reply-to:message-id:user-agent:mime-version;\n bh=JBC6YN/HJvZioNSIml9zdPDy3/jFHAUUUcCUJ9242uw=;\n b=EhA8VHyTX1LHiPqaLx1dBLQxXaurJMzZPYaMii7VW7tULT3aYB0/GmxSziMKLN2XVB\n 2QSu1n+m/sgxMjoUTa/UUO6lRPg3JGZC6GKBf4C6MLySrh15gAaP+5RX4vylkhBPJJxZ\n 4M6+iSWWsUY2DScY8Rfc5uMWBnOLPcWRZNp+WzHkKhwOIPXyGyNHGqNKyEGV137GwMcL\n M86Y7lAyKMvBCKg5Gbz8NTtA3TPe6JGh5BYGSStaobhQQ7xhrP5Y4UmRZOgFOescWwVX\n vcbeFcbirR1Krd1ZQ2SiK7JVtQwoF+tAiMuVKDqGxGz5BP+pcXA7ZmZeRHWFAe7Heoi4\n cI3g==", "X-Gm-Message-State": "AOAM533imvxioPjGZ8h9A+8sD6Aa4uAFDXITy/GPwoAx6vLyPSb7Jw8m\n BgVe27bt6u1gxyaTtrw4HFqluLEs3Ixu/D9Mvo5zgGPXbFkwGSmfDsbnM1WTkteGh3nmCNtj++z\n tccM=", "X-Received": [ "by 2002:a5d:6452:: with SMTP id\n d18mr63337851wrw.284.1594309935299;\n Thu, 09 Jul 2020 08:52:15 -0700 (PDT)", "by 2002:a5d:6452:: with SMTP id\n d18mr63337835wrw.284.1594309935011;\n Thu, 09 Jul 2020 08:52:15 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJyRwr7LSoVus3/t48KnCpRULyRB0rDAkuamEPkUhuFPU49oUnPpUYLeVR3l0DEZ4d+GGnSciQ==", "From": "Dodji Seketeli <dodji@redhat.com>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org, thomas@monjalon.net, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>", "Organization": "Red Hat / France", "References": "<20200708102212.3311-1-david.marchand@redhat.com>", "X-Operating-System": "Red Hat Enterprise Linux Workstation 7.8 Beta", "X-URL": "http://www.redhat.com", "Date": "Thu, 09 Jul 2020 17:52:11 +0200", "In-Reply-To": "<20200708102212.3311-1-david.marchand@redhat.com> (David\n Marchand's message of \"Wed, 8 Jul 2020 12:22:12 +0200\")", "Message-ID": "<87r1tkptxw.fsf@redhat.com>", "User-Agent": "Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)", "MIME-Version": "1.0", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dodji@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115678, "web_url": "https://patches.dpdk.org/comment/115678/", "msgid": "<31560b53-93e9-c272-73b1-8d5835ed704c@ashroe.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/31560b53-93e9-c272-73b1-8d5835ed704c@ashroe.eu", "date": "2020-07-10T07:37:58", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 1310, "url": "https://patches.dpdk.org/api/people/1310/?format=api", "name": "Ray Kinsella", "email": "mdr@ashroe.eu" }, "content": "On 08/07/2020 11:22, David Marchand wrote:\n> abidiff can provide some more information about the ABI difference it\n> detected.\n> In all cases, a discussion on the mailing must happen but we can give\n> some hints to know if this is a problem with the script calling abidiff,\n> a potential ABI breakage or an unambiguous ABI breakage.\n> \n> Signed-off-by: David Marchand <david.marchand@redhat.com>\n> ---\n> devtools/check-abi.sh | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n> index e17fedbd9f..521e2cce7c 100755\n> --- a/devtools/check-abi.sh\n> +++ b/devtools/check-abi.sh\n> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n> \t\terror=1\n> \t\tcontinue\n> \tfi\n> -\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n> +\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n> +\t\tabiret=$?\n> \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n> \t\terror=1\n> -\tfi\n> +\t\techo\n> +\t\tif [ $(($abiret & 3)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 4)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 8)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n> +\t\tfi\n> +\t\techo\n> +\t}\n> done\n> \n> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n> \n\nAcked-by: Ray Kinsella <mdr@ashroe.eu>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47792A0526;\n\tFri, 10 Jul 2020 09:38:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F0C301DC35;\n\tFri, 10 Jul 2020 09:38:07 +0200 (CEST)", "from qrelay5.mxroute.com (qrelay5.mxroute.com [172.82.139.5])\n by dpdk.org (Postfix) with ESMTP id 1A4DC1DC26\n for <dev@dpdk.org>; Fri, 10 Jul 2020 09:38:05 +0200 (CEST)", "from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com)\n (Authenticated sender: mN4UYu2MZsgR)\n by qrelay5.mxroute.com (ZoneMTA) with ESMTPA id 17337a8e0e20009563.001\n for <dev@dpdk.org>; Fri, 10 Jul 2020 07:38:01 +0000", "from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109])\n by filter004.mxroute.com (Postfix) with ESMTPS id 83E863EDA1;\n Fri, 10 Jul 2020 07:38:00 +0000 (UTC)" ], "X-Zone-Loop": "85f00b91ed29faabdacef2e6e9cb85d693e6f4bc2fb0", "X-Originating-IP": "[149.28.56.236]", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu;\n s=x;\n h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:\n Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=BGxUt8blhH3Y1FJwvunmxg3sDpA7teY0yScHG46Lo+g=; b=Rv8CEjzA05rqrTdETRpgr6URJT\n bR1+5D2W9+09JPm3oiSLYILXebAKvbSIlmec7WPBVWUNmkyecA83bcvpRJXDlrD0Tb0HI6RJPX/j5\n OplWhF2FVfUpsG5JE+g4V5hQ4CVM0AcR9QO4z0kpr3Ht9+G+E6a3dABL73gUB20wRAu9tCIUdMOHC\n P7pQ113t06N4DD5F9S3a+D/TiHMeDuQZP7QVbuHK3chRSoU23Hq+O11aPgqXpbJxJNKXUPXBt0vAX\n P+2YA/sjxr00i2Q4oA4XpnoScNAoxw19krGWMyLKR0rlFfZTnYmmKJ6mWXhDvU3Dqz+EAL9uqPyLg\n R5j7C/zw==;", "To": "David Marchand <david.marchand@redhat.com>, dev@dpdk.org", "Cc": "thomas@monjalon.net, dodji@redhat.com, Neil Horman\n <nhorman@tuxdriver.com>, Aaron Conole <aconole@redhat.com>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>", "From": "\"Kinsella, Ray\" <mdr@ashroe.eu>", "Autocrypt": "addr=mdr@ashroe.eu; keydata=\n mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6\n ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s\n JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j\n HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr\n S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS\n uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++\n YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux\n TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH\n bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5\n 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs\n bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8\n B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE\n msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn\n B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f\n VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a\n 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7\n JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt\n TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1\n +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD\n dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL\n 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC\n VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5\n xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC\n hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5\n pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S\n OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v\n ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1\n pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt\n 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj\n tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y\n yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u\n AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ\n CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf\n u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17\n c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA\n thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK\n +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8\n pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2\n GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75\n QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l\n BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ\n wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg==", "Message-ID": "<31560b53-93e9-c272-73b1-8d5835ed704c@ashroe.eu>", "Date": "Fri, 10 Jul 2020 08:37:58 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200708102212.3311-1-david.marchand@redhat.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-AuthUser": "mdr@ashroe.eu", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 115683, "web_url": "https://patches.dpdk.org/comment/115683/", "msgid": "<20200710105807.GA2203594@hmswarspite.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200710105807.GA2203594@hmswarspite.think-freely.org", "date": "2020-07-10T10:58:07", "subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Wed, Jul 08, 2020 at 12:22:12PM +0200, David Marchand wrote:\n> abidiff can provide some more information about the ABI difference it\n> detected.\n> In all cases, a discussion on the mailing must happen but we can give\n> some hints to know if this is a problem with the script calling abidiff,\n> a potential ABI breakage or an unambiguous ABI breakage.\n> \n> Signed-off-by: David Marchand <david.marchand@redhat.com>\n> ---\n> devtools/check-abi.sh | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\n> index e17fedbd9f..521e2cce7c 100755\n> --- a/devtools/check-abi.sh\n> +++ b/devtools/check-abi.sh\n> @@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n> \t\terror=1\n> \t\tcontinue\n> \tfi\n> -\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n> +\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n> +\t\tabiret=$?\n> \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n> \t\terror=1\n> -\tfi\n> +\t\techo\n> +\t\tif [ $(($abiret & 3)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 4)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n> +\t\tfi\n> +\t\tif [ $(($abiret & 8)) != 0 ]; then\n> +\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n> +\t\tfi\n> +\t\techo\n> +\t}\n> done\n> \n> [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n> -- \n> 2.23.0\n> \n> \nthis looks pretty reasonable to me, sure.\nAcked-by: Neil Horman <nhorman@tuxdriver.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B9DBA052A;\n\tFri, 10 Jul 2020 12:58:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B28B1DB41;\n\tFri, 10 Jul 2020 12:58:22 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n by dpdk.org (Postfix) with ESMTP id 916811DB19\n for <dev@dpdk.org>; Fri, 10 Jul 2020 12:58:21 +0200 (CEST)", "from [2605:a601:a627:ca00:88f6:82e4:5f1a:31bb] (helo=localhost)\n by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)\n (envelope-from <nhorman@tuxdriver.com>)\n id 1jtqjN-00058A-7n; Fri, 10 Jul 2020 06:58:19 -0400" ], "Date": "Fri, 10 Jul 2020 06:58:07 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "David Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org, thomas@monjalon.net, dodji@redhat.com,\n Ray Kinsella <mdr@ashroe.eu>", "Message-ID": "<20200710105807.GA2203594@hmswarspite.think-freely.org>", "References": "<20200708102212.3311-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200708102212.3311-1-david.marchand@redhat.com>", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Subject": "Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]