Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73523/?format=api
{ "id": 73523, "url": "https://patches.dpdk.org/api/patches/73523/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200708102212.3311-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200708102212.3311-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200708102212.3311-1-david.marchand@redhat.com", "date": "2020-07-08T10:22:12", "name": "devtools: give some hints for ABI errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8903de42be90890067ed789aeaf8907bfff0b2f9", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200708102212.3311-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 10888, "url": "https://patches.dpdk.org/api/series/10888/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10888", "date": "2020-07-08T10:22:12", "name": "devtools: give some hints for ABI errors", "version": 1, "mbox": "https://patches.dpdk.org/series/10888/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/73523/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/73523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39E25A0526;\n\tWed, 8 Jul 2020 12:22:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A45411DAF4;\n\tWed, 8 Jul 2020 12:22:36 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id AE7EA1D452\n for <dev@dpdk.org>; Wed, 8 Jul 2020 12:22:34 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-86-5qznnkWsOw2Wt9X-Y8Vh8g-1; Wed, 08 Jul 2020 06:22:33 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98875108B;\n Wed, 8 Jul 2020 10:22:31 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.195.188])\n by smtp.corp.redhat.com (Postfix) with ESMTP id BF8975C57D;\n Wed, 8 Jul 2020 10:22:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1594203754;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=Pg8QZJXwwICXpdkzg0pgwqnyT8GKDeK2YYFwWo/OLJI=;\n b=U9GfW+9BWFXicKWNYW4uEY80/7R51RiHnhuLbjm3R521JcJvrfITKlt15l7POHdEgHkL5Q\n vWsqazk660mkShAAl47fHsMnm4KrLZsewkRE/cs7D/9x0HCGq7goPV2NWOUQfOGmBOhTPb\n 9unV7MgTo7WAiE0Xljf6vSmQ+OnXwRM=", "X-MC-Unique": "5qznnkWsOw2Wt9X-Y8Vh8g-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, dodji@redhat.com, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>", "Date": "Wed, 8 Jul 2020 12:22:12 +0200", "Message-Id": "<20200708102212.3311-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] devtools: give some hints for ABI errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "abidiff can provide some more information about the ABI difference it\ndetected.\nIn all cases, a discussion on the mailing must happen but we can give\nsome hints to know if this is a problem with the script calling abidiff,\na potential ABI breakage or an unambiguous ABI breakage.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n devtools/check-abi.sh | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh\nindex e17fedbd9f..521e2cce7c 100755\n--- a/devtools/check-abi.sh\n+++ b/devtools/check-abi.sh\n@@ -50,10 +50,22 @@ for dump in $(find $refdir -name \"*.dump\"); do\n \t\terror=1\n \t\tcontinue\n \tfi\n-\tif ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then\n+\tabidiff $ABIDIFF_OPTIONS $dump $dump2 || {\n+\t\tabiret=$?\n \t\techo \"Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'\"\n \t\terror=1\n-\tfi\n+\t\techo\n+\t\tif [ $(($abiret & 3)) != 0 ]; then\n+\t\t\techo \"ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, please report this to dev@dpdk.org.\"\n+\t\tfi\n+\t\tif [ $(($abiret & 4)) != 0 ]; then\n+\t\t\techo \"ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue).\"\n+\t\tfi\n+\t\tif [ $(($abiret & 8)) != 0 ]; then\n+\t\t\techo \"ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI.\"\n+\t\tfi\n+\t\techo\n+\t}\n done\n \n [ -z \"$error\" ] || [ -n \"$warnonly\" ]\n", "prefixes": [] }