Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126872/?format=api
{ "id": 126872, "url": "https://patches.dpdk.org/api/patches/126872/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230516063747.3047758-8-michaelba@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230516063747.3047758-8-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230516063747.3047758-8-michaelba@nvidia.com", "date": "2023-05-16T06:37:47", "name": "[v1,7/7] net/mlx5: add MPLS modify field support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bf001028f0ad12ea7293c615d69426c710755ab5", "submitter": { "id": 1949, "url": "https://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230516063747.3047758-8-michaelba@nvidia.com/mbox/", "series": [ { "id": 28001, "url": "https://patches.dpdk.org/api/series/28001/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28001", "date": "2023-05-16T06:37:40", "name": "ethdev: modify field API for multiple headers", "version": 1, "mbox": "https://patches.dpdk.org/series/28001/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126872/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/126872/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFF6E42B1F;\n\tTue, 16 May 2023 08:38:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C73BE42D88;\n\tTue, 16 May 2023 08:38:20 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam04on2077.outbound.protection.outlook.com [40.107.102.77])\n by mails.dpdk.org (Postfix) with ESMTP id C70F642D47\n for <dev@dpdk.org>; Tue, 16 May 2023 08:38:18 +0200 (CEST)", "from MW4PR03CA0057.namprd03.prod.outlook.com (2603:10b6:303:8e::32)\n by CY8PR12MB8315.namprd12.prod.outlook.com (2603:10b6:930:7e::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May\n 2023 06:38:17 +0000", "from CO1NAM11FT060.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8e:cafe::3d) by MW4PR03CA0057.outlook.office365.com\n (2603:10b6:303:8e::32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30 via Frontend\n Transport; Tue, 16 May 2023 06:38:17 +0000", "from mail.nvidia.com (216.228.118.233) by\n CO1NAM11FT060.mail.protection.outlook.com (10.13.175.132) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 06:38:16 +0000", "from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com\n (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 15 May 2023\n 23:38:10 -0700", "from drhqmail202.nvidia.com (10.126.190.181) by\n drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.986.37; Mon, 15 May 2023 23:38:10 -0700", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend\n Transport; Mon, 15 May 2023 23:38:08 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BrSwaqCOljT73trOggg3f5SePXgW4kuHAcGmUkB4mbBN23iNtEoX/pQj4E/A9N0Lgwy9BFb0Gl1W81nWHYQgGPsKs1XVAnQP1hCy0kiNKTZi7qIRHKnTdAt6uE5FqtVWJr4ogrK75c6nFym0BlKq8tj9ePlsGwaQTjRY66L9xsXWMYTgXABfOzG58mw1myiR0yCxbyY8fbYCSFME7Ja78j5ocVwOqIRXwGI4Kpjwa4ZEysfTOHQblz/GKuQ5Nh8GgqfXb5AjmhFvrKKUMVgyFrCsiOmqOutJPbB2VNn+Id5uzP45pTGcSGgDo9GaJO08zcY42aaXbV/5/tsldW0EIQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=yq613IPiI3VvhJCWbbJ13LLrqXW8B83Q1NW/HQJ4Crs=;\n b=hoMq/ZHK64LIJnsOfdVk9NTgN52GN5ZI3ifp3vFwrVt1RsEiZ3jxe6amDnlwjifUGsyR3nk+sUQbSIAa0TzqXFFxbq2XaGvAwHpvJgSDJ7Lt1EdqtMNvurqljpjzsa0qnvcF18lvZjwl7J2uJ21XDFn1ScZcNDS1oHe3BdLorOSlSYdaU4xvogqyz2S4QLn1YKPsdUmIs8HsK66SEMBC0oHmfslI09U+7WMtfKj/53eZMOdMT2Gp+d60+uBqu3ktYkLOw/MOIxKyp2bRc5pdmBSoENrQpQWW//27+wDdv5PqJ9+vU9PdZuViXgItsHES1WN99rVnlcbClgi7OgAtdg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yq613IPiI3VvhJCWbbJ13LLrqXW8B83Q1NW/HQJ4Crs=;\n b=ZJgtklstrWN04zJtqRZcrhUKr/HvoYby/pa74C37VBFR3JHcLzM/bANNlXr3aSSMQseLX07pXZsRmFd668mTICZ4/2lgxDEww4GwoWyOgJxd2GjAALkTZ8RO8mJmaQQEKb6p8UPRf/QVlgsqKHXsOm0OOzL3nqLy3YKUKp0czku6LocKiFEoBe3WZT/5La3uF8HkfFM4lgPFHRr2RTkjUlM1ilk/+/h2igtuaAqO/9qzzjF4Ycn/KEw72ZNuHIuKnAiA6BFF3VSlMz0cxgQnyOwxhsKcgB3JqsYdweEbJWqGsqQg2vnkHqvTMTHuVlOL7xLmzQbuzPQcpy5Vsstsxw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.233)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.233 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Ori Kam <orika@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>,\n \"Yuying Zhang\" <yuying.zhang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n \"Thomas Monjalon\" <thomas@monjalon.net>", "Subject": "[PATCH v1 7/7] net/mlx5: add MPLS modify field support", "Date": "Tue, 16 May 2023 09:37:47 +0300", "Message-ID": "<20230516063747.3047758-8-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230516063747.3047758-1-michaelba@nvidia.com>", "References": "<20230516063747.3047758-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT060:EE_|CY8PR12MB8315:EE_", "X-MS-Office365-Filtering-Correlation-Id": "641f53af-f06b-4ee4-ac85-08db55d821c3", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n S8B7OfGc8jQOlQYCzv5pTToeJMPP44OBFqOBuuWoMi5eP3ofKKjfz+phZl+UfNlNDq2xgfvTkNKFDCJwCN9WMC9BcLYgQDvyFMoZullrwutknaFvzDwNvtC9jnvgfqyAoJVhwmQ4h12QFO0q272UO9CFaME98criuSIFigGs3diNV/PeFVcFtTjvvDfb+uiDVn0tg/upeq9qklJA1MwObVcXSIRECJXOdvQDPxn0esufLrFSzdh5g+mA6lat8/S9ppriPXTmhFQoSZrXLJrahRpOvALx1VIQ5GQL1r77g9la/VYVoNsTx17dMSWZQUkxaaCHWpFukFtoSrP+UBJb39O8K6QJE3WXQAIynxe971RVsoYZr7bcmROdXloTCMLzgFc/LLhnuk9c3KhiKNqnml7PUmPttYgga1jiCeInLyfhxdCnpbo28JJ5OZmlpATetwrQ2s0LA62y7eLrV22z7eYWAZ4V63weEY7ae6GrsTxvn4xa8IDsjuISuz/6wkGpwTyQbBzBCVEkR8q8hArrCpnuV5asmuI8ZNL9Fm7vsx+muFFBssn1JYniu1pR1cb7vFxnvVbW+i0mSGlete+zTIX9HC4KzEb4C7VeXwmCtsxEzOJCMoJzduQDMeLiHzH8ZNV8n0r4XNNUcYoEh1dMK/37G8Ant5E6P7I8hsVAFIOcmixa6S5WfoRGI4dVVCpzrbfmucKaGkgKeCBRNBrJQ8WB8iVd0girUZnnBSOECOZxEy7wnKisEJ2abZp81/TJ", "X-Forefront-Antispam-Report": "CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199021)(46966006)(40470700004)(36840700001)(36756003)(86362001)(54906003)(316002)(4326008)(70586007)(70206006)(6916009)(478600001)(7696005)(6666004)(40480700001)(55016003)(82310400005)(8936002)(8676002)(5660300002)(41300700001)(2906002)(7636003)(356005)(82740400003)(336012)(2616005)(1076003)(26005)(426003)(6286002)(186003)(36860700001)(83380400001)(47076005)(40460700003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 May 2023 06:38:16.9888 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 641f53af-f06b-4ee4-ac85-08db55d821c3", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT060.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY8PR12MB8315", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for modify field in tunnel MPLS header.\nFor now it is supported only to copy from.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/common/mlx5/mlx5_prm.h | 5 +++++\n drivers/net/mlx5/mlx5_flow_dv.c | 23 +++++++++++++++++++++++\n drivers/net/mlx5/mlx5_flow_hw.c | 16 +++++++++-------\n 3 files changed, 37 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex ed3d5efbb7..04c1400a1e 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -787,6 +787,11 @@ enum mlx5_modification_field {\n \tMLX5_MODI_TUNNEL_HDR_DW_1 = 0x75,\n \tMLX5_MODI_GTPU_FIRST_EXT_DW_0 = 0x76,\n \tMLX5_MODI_HASH_RESULT = 0x81,\n+\tMLX5_MODI_IN_MPLS_LABEL_0 = 0x8a,\n+\tMLX5_MODI_IN_MPLS_LABEL_1,\n+\tMLX5_MODI_IN_MPLS_LABEL_2,\n+\tMLX5_MODI_IN_MPLS_LABEL_3,\n+\tMLX5_MODI_IN_MPLS_LABEL_4,\n \tMLX5_MODI_OUT_IPV6_NEXT_HDR = 0x4A,\n \tMLX5_MODI_INVALID = INT_MAX,\n };\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex f136f43b0a..93cce16a1e 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1388,6 +1388,7 @@ mlx5_flow_item_field_width(struct rte_eth_dev *dev,\n \tcase RTE_FLOW_FIELD_GENEVE_VNI:\n \t\treturn 24;\n \tcase RTE_FLOW_FIELD_GTP_TEID:\n+\tcase RTE_FLOW_FIELD_MPLS:\n \tcase RTE_FLOW_FIELD_TAG:\n \t\treturn 32;\n \tcase RTE_FLOW_FIELD_MARK:\n@@ -1435,6 +1436,12 @@ flow_modify_info_mask_32_masked(uint32_t length, uint32_t off, uint32_t post_mas\n \treturn rte_cpu_to_be_32(mask & post_mask);\n }\n \n+static __rte_always_inline enum mlx5_modification_field\n+mlx5_mpls_modi_field_get(const struct rte_flow_action_modify_data *data)\n+{\n+\treturn MLX5_MODI_IN_MPLS_LABEL_0 + data->sub_level;\n+}\n+\n static void\n mlx5_modify_flex_item(const struct rte_eth_dev *dev,\n \t\t const struct mlx5_flex_item *flex,\n@@ -1893,6 +1900,16 @@ mlx5_flow_field_id_to_modify_info\n \t\telse\n \t\t\tinfo[idx].offset = off_be;\n \t\tbreak;\n+\tcase RTE_FLOW_FIELD_MPLS:\n+\t\tMLX5_ASSERT(data->offset + width <= 32);\n+\t\toff_be = 32 - (data->offset + width);\n+\t\tinfo[idx] = (struct field_modify_info){4, 0,\n+\t\t\t\t\tmlx5_mpls_modi_field_get(data)};\n+\t\tif (mask)\n+\t\t\tmask[idx] = flow_modify_info_mask_32(width, off_be);\n+\t\telse\n+\t\t\tinfo[idx].offset = off_be;\n+\t\tbreak;\n \tcase RTE_FLOW_FIELD_TAG:\n \t\t{\n \t\t\tMLX5_ASSERT(data->offset + width <= 32);\n@@ -5344,6 +5361,12 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\"modifications of the GENEVE Network\"\n \t\t\t\t\" Identifier is not supported\");\n+\tif (action_modify_field->dst.field == RTE_FLOW_FIELD_MPLS ||\n+\t action_modify_field->src.field == RTE_FLOW_FIELD_MPLS)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\"modifications of the MPLS header \"\n+\t\t\t\t\"is not supported\");\n \tif (action_modify_field->dst.field == RTE_FLOW_FIELD_MARK ||\n \t action_modify_field->src.field == RTE_FLOW_FIELD_MARK)\n \t\tif (config->dv_xmeta_en == MLX5_XMETA_MODE_LEGACY ||\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 1b68a19900..80e6398992 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -3546,10 +3546,8 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\t\t\t const struct rte_flow_action *mask,\n \t\t\t\t struct rte_flow_error *error)\n {\n-\tconst struct rte_flow_action_modify_field *action_conf =\n-\t\taction->conf;\n-\tconst struct rte_flow_action_modify_field *mask_conf =\n-\t\tmask->conf;\n+\tconst struct rte_flow_action_modify_field *action_conf = action->conf;\n+\tconst struct rte_flow_action_modify_field *mask_conf = mask->conf;\n \n \tif (action_conf->operation != mask_conf->operation)\n \t\treturn rte_flow_error_set(error, EINVAL,\n@@ -3604,6 +3602,11 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\"modifying Geneve VNI is not supported\");\n+\t/* Due to HW bug, tunnel MPLS header is read only. */\n+\tif (action_conf->dst.field == RTE_FLOW_FIELD_MPLS)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\"MPLS cannot be used as destination\");\n \treturn 0;\n }\n \n@@ -4134,9 +4137,8 @@ mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\taction_flags |= MLX5_FLOW_ACTION_METER;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_MODIFY_FIELD:\n-\t\t\tret = flow_hw_validate_action_modify_field(action,\n-\t\t\t\t\t\t\t\t\tmask,\n-\t\t\t\t\t\t\t\t\terror);\n+\t\t\tret = flow_hw_validate_action_modify_field(action, mask,\n+\t\t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n \t\t\taction_flags |= MLX5_FLOW_ACTION_MODIFY_FIELD;\n", "prefixes": [ "v1", "7/7" ] }