Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123618/?format=api
{ "id": 123618, "url": "https://patches.dpdk.org/api/patches/123618/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230209221929.265059-10-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230209221929.265059-10-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230209221929.265059-10-nicolas.chautru@intel.com", "date": "2023-02-09T22:19:29", "name": "[v1,9/9] baseband/acc: remove printf from PMD function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f2f3cd134cfb349357c18067a4a23c9048feaacc", "submitter": { "id": 1314, "url": "https://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230209221929.265059-10-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 26933, "url": "https://patches.dpdk.org/api/series/26933/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26933", "date": "2023-02-09T22:19:20", "name": "baseband/acc: VRB PMD fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/26933/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/123618/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/123618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A42C641C56;\n\tThu, 9 Feb 2023 23:24:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 833D542D51;\n\tThu, 9 Feb 2023 23:23:20 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 340A642670\n for <dev@dpdk.org>; Thu, 9 Feb 2023 23:23:10 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2023 14:23:08 -0800", "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by fmsmga004.fm.intel.com with ESMTP; 09 Feb 2023 14:23:07 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1675981390; x=1707517390;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=pvDW38u5DkfxicweyuL0Mv/nHi0tZGPDgHuAh847Tl8=;\n b=QkKAXwGmtOpLaWEmq+EATDoRXG+1pWWKgAHNf/WutaHmQWVofWMcWBt4\n q6MjaMgmT/B5lIiQ7K5D72KFxixC5Q0fwQh1U9agfBhKinA/5gylo7Db5\n eQ61B8o48mT/+asQ6R71y+IvM8aXFSs2Dw3Z95Zv8viaWNDMWgbsL0rW5\n Irfv7CMKHaaJIjkSft2UN5BkbDBqL2xV2noVXfRorekBM5k7RCkBNpaA9\n wlDGW2t5g6Fi+8chwf4EsYUD1qEbKIga0NxPAkWO461LXrN6IGkXJHoPC\n fCizjAP93QAefSilB1kiW6WLGhjk6MOAdGNtygV4Z8cbDbcJ2DA46lNVu Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10616\"; a=\"331563063\"", "E=Sophos;i=\"5.97,285,1669104000\"; d=\"scan'208\";a=\"331563063\"", "E=McAfee;i=\"6500,9779,10616\"; a=\"736513289\"", "E=Sophos;i=\"5.97,285,1669104000\"; d=\"scan'208\";a=\"736513289\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com", "Cc": "hernan.vargas@intel.com, stable@dpdk.or,\n Nicolas Chautru <nicolas.chautru@intel.com>", "Subject": "[PATCH v1 9/9] baseband/acc: remove printf from PMD function", "Date": "Thu, 9 Feb 2023 22:19:29 +0000", "Message-Id": "<20230209221929.265059-10-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230209221929.265059-1-nicolas.chautru@intel.com>", "References": "<20230209221929.265059-1-nicolas.chautru@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replacing usage of printf in companion function for\nbbdev-test by rte_log.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 18 +++++++++---------\n drivers/baseband/acc/rte_vrb_pmd.c | 2 +-\n 2 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex 36f6fec5ad..40b5eaf089 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -4347,7 +4347,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc_device *d,\n {\n \tint i, template_idx, qg_idx;\n \tuint32_t address, status, value;\n-\tprintf(\"Need to clear power-on 5GUL status in internal memory\\n\");\n+\trte_bbdev_log(WARNING, \"Need to clear power-on 5GUL status in internal memory\");\n \t/* Reset LDPC Cores */\n \tfor (i = 0; i < ACC100_ENGINES_MAX; i++)\n \t\tacc_reg_write(d, HWPfFecUl5gCntrlReg +\n@@ -4421,7 +4421,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc_device *d,\n \t/* Force each engine which is in unspecified state */\n \tfor (i = 0; i < num_failed_engine; i++) {\n \t\tint failed_engine = engines_to_restart[i];\n-\t\tprintf(\"Force engine %d\\n\", failed_engine);\n+\t\trte_bbdev_log(WARNING, \"Force engine %d\", failed_engine);\n \t\tfor (template_idx = ACC100_SIG_UL_5G;\n \t\t\t\ttemplate_idx <= ACC100_SIG_UL_5G_LAST;\n \t\t\t\ttemplate_idx++) {\n@@ -4450,7 +4450,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc_device *d,\n \t\tacc_reg_write(d, HWPfQmgrIngressAq + 0x100, enq_req.val);\n \t\tusleep(ACC_LONG_WAIT * 100);\n \t\tif (desc->req.word0 != 2)\n-\t\t\tprintf(\"DMA Response %#\"PRIx32\"\\n\", desc->req.word0);\n+\t\t\trte_bbdev_log(WARNING, \"DMA Response %#\"PRIx32\"\\n\", desc->req.word0);\n \t}\n \n \t/* Reset LDPC Cores */\n@@ -4482,7 +4482,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc_device *d,\n \t\t} else\n \t\t\tacc_reg_write(d, address, 0);\n \t}\n-\tprintf(\"Number of 5GUL engines %d\\n\", numEngines);\n+\trte_bbdev_log(INFO, \"Number of 5GUL engines %d\", numEngines);\n \n \trte_free(d->sw_rings_base);\n \tusleep(ACC_LONG_WAIT);\n@@ -4671,7 +4671,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\t} else\n \t\t\tacc_reg_write(d, address, 0);\n \t}\n-\tprintf(\"Number of 5GUL engines %d\\n\", numEngines);\n+\trte_bbdev_log(INFO, \"Number of 5GUL engines %d\", numEngines);\n \t/* 4GDL */\n \tnumQqsAcc += numQgs;\n \tnumQgs\t= conf->q_dl_4g.num_qgroups;\n@@ -4801,7 +4801,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\tversion += acc_reg_read(d,\n \t\t\t\tHWPfDdrPhyIdtmFwVersion + 4 * i) << (8 * i);\n \tif (version != ACC100_PRQ_DDR_VER) {\n-\t\tprintf(\"* Note: Not on DDR PRQ version %8x != %08x\\n\",\n+\t\trte_bbdev_log(ERR, \"* Note: Not on DDR PRQ version %8x != %08x\",\n \t\t\t\tversion, ACC100_PRQ_DDR_VER);\n \t} else if (firstCfg) {\n \t\t/* ---- DDR configuration at boot up --- */\n@@ -4871,7 +4871,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\t\tif (value & 1)\n \t\t\t\tbreak;\n \t\t}\n-\t\tprintf(\"DDR Training completed in %d ms\", i);\n+\t\trte_bbdev_log(INFO, \"DDR Training completed in %d ms\", i);\n \t\t/* Enable Memory Controller */\n \t\tacc_reg_write(d, HWPfDdrUmmcCtrl, 0x401);\n \t\t/* Release AXI interface reset */\n@@ -5047,7 +5047,7 @@ acc101_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\t} else\n \t\t\tacc_reg_write(d, address, 0);\n \t}\n-\tprintf(\"Number of 5GUL engines %d\\n\", numEngines);\n+\trte_bbdev_log(INFO, \"Number of 5GUL engines %d\", numEngines);\n \t/* 4GDL */\n \tnumQqsAcc += numQgs;\n \tnumQgs\t= conf->q_dl_4g.num_qgroups;\n@@ -5185,7 +5185,7 @@ rte_acc_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\treturn -ENODEV;\n \t}\n \tstruct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(bbdev->device);\n-\tprintf(\"Configure dev id %x\\n\", pci_dev->id.device_id);\n+\trte_bbdev_log(INFO, \"Configure dev id %x\", pci_dev->id.device_id);\n \tif (pci_dev->id.device_id == ACC100_PF_DEVICE_ID)\n \t\treturn acc100_configure(dev_name, conf);\n \telse if (pci_dev->id.device_id == ACC101_PF_DEVICE_ID)\ndiff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c\nindex 18b5dab25f..c37f725415 100644\n--- a/drivers/baseband/acc/rte_vrb_pmd.c\n+++ b/drivers/baseband/acc/rte_vrb_pmd.c\n@@ -3633,7 +3633,7 @@ vrb1_configure(const char *dev_name, struct rte_acc_conf *conf)\n \t\t} else\n \t\t\tacc_reg_write(d, address, 0);\n \t}\n-\tprintf(\"Number of 5GUL engines %d\\n\", numEngines);\n+\trte_bbdev_log(INFO, \"Number of 5GUL engines %d\", numEngines);\n \t/* 4GDL */\n \tnumQqsAcc += numQgs;\n \tnumQgs\t= conf->q_dl_4g.num_qgroups;\n", "prefixes": [ "v1", "9/9" ] }