diff mbox series

[3/3] common/cnxk: check for error code in MAC address set

Message ID 20231016070437.2295803-3-ndabilpuram@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [1/3] net/cnxk: fix data offset extract logic in vector function |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-sample-apps-testing warning Testing issues
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Nithin Dabilpuram Oct. 16, 2023, 7:04 a.m. UTC 
  Check for mbox error code in MAC address set.
Fixes: 313cc41830ec ("common/cnxk: support NIX MAC operations")

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
 drivers/common/cnxk/roc_nix_mac.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Jerin Jacob Oct. 18, 2023, 5:34 a.m. UTC | #1 
On Mon, Oct 16, 2023 at 12:35 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Check for mbox error code in MAC address set.
> Fixes: 313cc41830ec ("common/cnxk: support NIX MAC operations")
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>


Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

commit 9d88abedf09d2fb966de58f9f14782df3d61389c (HEAD -> for-next-net,
origin/for-next-net)
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Oct 16 12:34:37 2023 +0530

    common/cnxk: check for error code in MAC address set

    Check for mailbox error code in MAC address set.

    Fixes: 313cc41830ec ("common/cnxk: support NIX MAC operations")
    Cc: stable@dpdk.org

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

commit b1744e2ad03d78517f9337e6377fa5ae72ca5ef2
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Oct 16 12:34:36 2023 +0530

    net/cnxk: support to extract HW error for inline IPsec

    Add PMD API support to extract HW error code from mbuf's processed
    by inline IPsec inbound.

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

commit 99b9917b020223f0fe5a3bddf598d2aef53d7da8
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Oct 16 12:34:35 2023 +0530

    net/cnxk: fix data offset extract logic in vector function

    Extract data offset from individual mbuf's instead of mbuf0.

    Fixes: 6771216c2f44 ("drivers: mark cnxk to support disabling IOVA as PA")
    Cc: stable@dpdk.org

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c
index e2e87be525..2d1c29dd66 100644
--- a/drivers/common/cnxk/roc_nix_mac.c
+++ b/drivers/common/cnxk/roc_nix_mac.c
@@ -84,7 +84,7 @@  roc_nix_mac_addr_set(struct roc_nix *roc_nix, const uint8_t addr[])
 	struct cgx_mac_addr_set_or_get *req, *rsp;
 	struct dev *dev = &nix->dev;
 	struct mbox *mbox = mbox_get(dev->mbox);
-	int rc;
+	int rc = -ENOSPC;
 
 	if (roc_nix_is_vf_or_sdp(roc_nix)) {
 		rc = NIX_ERR_OP_NOTSUP;
@@ -97,6 +97,9 @@  roc_nix_mac_addr_set(struct roc_nix *roc_nix, const uint8_t addr[])
 	}
 
 	req = mbox_alloc_msg_cgx_mac_addr_set(mbox);
+	if (req == NULL)
+		goto exit;
+
 	req->index = nix->dmac_flt_idx;
 	mbox_memcpy(req->mac_addr, addr, PLT_ETHER_ADDR_LEN);