From patchwork Mon Oct 16 07:04:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 132620 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 864164317A; Mon, 16 Oct 2023 09:05:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2A254064C; Mon, 16 Oct 2023 09:05:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EA9D740648 for ; Mon, 16 Oct 2023 09:05:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39FNomiY011001 for ; Mon, 16 Oct 2023 00:05:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=J6D5tqsRF7AFAMwWYAMwNdJo3FG5OBnEJFc+0IwPU4o=; b=YPrJ4tZq/tY5wgiCNMGjOCaCYanAfJkOjSGGQOddKXtut55BQvuuYkql2s22nbotrILD aUYkdqGGXwNGnAhPgSuTH7dJevphnNFtF5RDXmqfLw6Cv5Q8nrT6LgrhvUCQOL3MlWqk UIoMpYBC4l2dURVak364azNZzGgW3cJn5Wn48rJBkw8Q7JFDJi0IWP1k7iVlGxgzz+gL nNVX+/kegeORE7MA1DlZEbpwvOdP+NWOGRtxz/hPAkI0s58sBJEPsRQBPL2ZmYYEE1if d9uz1aqc99mr+9IStTxEQc81XJbh+0EqHVfMsO7ZlUTLA0vEwUId5II8HxD3vY6ZM7HH Lg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3tqrbpvk3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 16 Oct 2023 00:05:13 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 16 Oct 2023 00:05:11 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 16 Oct 2023 00:05:11 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 5C3E93F705C; Mon, 16 Oct 2023 00:05:09 -0700 (PDT) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , Subject: [PATCH 3/3] common/cnxk: check for error code in MAC address set Date: Mon, 16 Oct 2023 12:34:37 +0530 Message-ID: <20231016070437.2295803-3-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231016070437.2295803-1-ndabilpuram@marvell.com> References: <20231016070437.2295803-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: of-u1cRqj6KUduLCqgZdXlmn0SbsBWDB X-Proofpoint-GUID: of-u1cRqj6KUduLCqgZdXlmn0SbsBWDB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-15_09,2023-10-12_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check for mbox error code in MAC address set. Fixes: 313cc41830ec ("common/cnxk: support NIX MAC operations") Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_mac.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c index e2e87be525..2d1c29dd66 100644 --- a/drivers/common/cnxk/roc_nix_mac.c +++ b/drivers/common/cnxk/roc_nix_mac.c @@ -84,7 +84,7 @@ roc_nix_mac_addr_set(struct roc_nix *roc_nix, const uint8_t addr[]) struct cgx_mac_addr_set_or_get *req, *rsp; struct dev *dev = &nix->dev; struct mbox *mbox = mbox_get(dev->mbox); - int rc; + int rc = -ENOSPC; if (roc_nix_is_vf_or_sdp(roc_nix)) { rc = NIX_ERR_OP_NOTSUP; @@ -97,6 +97,9 @@ roc_nix_mac_addr_set(struct roc_nix *roc_nix, const uint8_t addr[]) } req = mbox_alloc_msg_cgx_mac_addr_set(mbox); + if (req == NULL) + goto exit; + req->index = nix->dmac_flt_idx; mbox_memcpy(req->mac_addr, addr, PLT_ETHER_ADDR_LEN);