Message ID | 20231011092805.693171-6-haijie1@huawei.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 508EB4235E; Wed, 11 Oct 2023 11:32:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12CDF40E03; Wed, 11 Oct 2023 11:31:37 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 3454C40279 for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:31 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S56sN2kbnz1M967; Wed, 11 Oct 2023 17:28:56 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 17:31:29 +0800 From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, Julien Aube <julien_dpdk@jaube.fr> CC: <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liudongdong3@huawei.com> Subject: [PATCH v5 05/40] net/bnx2x: check RSS hash algorithms Date: Wed, 11 Oct 2023 17:27:30 +0800 Message-ID: <20231011092805.693171-6-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231011092805.693171-1-haijie1@huawei.com> References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
support setting and querying RSS algorithms
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Jie Hai
Oct. 11, 2023, 9:27 a.m. UTC
A new field 'algorithm' has been added to rss_conf, check it
in case of ignoring unsupported values.
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai <haijie1@huawei.com> > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index 4448cf2de2d7..078d6db75d1b 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -196,6 +196,10 @@ bnx2x_dev_configure(struct rte_eth_dev *dev) > PMD_DRV_LOG(DEBUG, sc, "num_queues=%d, mtu=%d", > sc->num_queues, sc->mtu); > > + if (dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm != > + RTE_ETH_HASH_FUNCTION_DEFAULT) > + return -EINVAL; > + > /* allocate ilt */ > if (bnx2x_alloc_ilt_mem(sc) != 0) { > PMD_DRV_LOG(ERR, sc, "bnx2x_alloc_ilt_mem was failed"); bnx2x doesn't claim RSS support (doc/guides/nics/features/bnx2x.ini), so I think it will be reasonable to drop this patch.
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 4448cf2de2d7..078d6db75d1b 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -196,6 +196,10 @@ bnx2x_dev_configure(struct rte_eth_dev *dev) PMD_DRV_LOG(DEBUG, sc, "num_queues=%d, mtu=%d", sc->num_queues, sc->mtu); + if (dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm != + RTE_ETH_HASH_FUNCTION_DEFAULT) + return -EINVAL; + /* allocate ilt */ if (bnx2x_alloc_ilt_mem(sc) != 0) { PMD_DRV_LOG(ERR, sc, "bnx2x_alloc_ilt_mem was failed");