[v5,29/40] net/nfp: check RSS hash algorithms

Message ID 20231011092805.693171-30-haijie1@huawei.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series support setting and querying RSS algorithms |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jie Hai Oct. 11, 2023, 9:27 a.m. UTC
  A new field 'algorithm' has been added to rss_conf, check it
in case of ignoring unsupported values.

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 drivers/net/nfp/nfp_common.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
  

Patch

diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
index 5683afc40a31..780316c764df 100644
--- a/drivers/net/nfp/nfp_common.c
+++ b/drivers/net/nfp/nfp_common.c
@@ -390,8 +390,12 @@  nfp_net_configure(struct rte_eth_dev *dev)
 	rxmode = &dev_conf->rxmode;
 	txmode = &dev_conf->txmode;
 
-	if (rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)
+	if (rxmode->mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {
 		rxmode->offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
+		if (dev_conf->rx_adv_conf.rss_conf.algorithm !=
+		    RTE_ETH_HASH_FUNCTION_DEFAULT)
+			return -EINVAL;
+	}
 
 	/* Checking TX mode */
 	if (txmode->mq_mode) {
@@ -1805,6 +1809,9 @@  nfp_net_rss_hash_update(struct rte_eth_dev *dev,
 		return 0; /* Nothing to do */
 	}
 
+	if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)
+		return -EINVAL;
+
 	if (rss_conf->rss_key_len > NFP_NET_CFG_RSS_KEY_SZ) {
 		PMD_DRV_LOG(ERR, "hash key too long");
 		return -EINVAL;