diff mbox series

crypto/qat: fix legacy sm4 ecb capability

Message ID 20230705132311.1146176-1-ciara.power@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/qat: fix legacy sm4 ecb capability |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Power, Ciara July 5, 2023, 1:23 p.m. UTC 
  Following the deprecation of insecure algorithms in QAT,
SM4-ECB should be included as legacy, to be disabled by default.

Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ji, Kai July 5, 2023, 1:56 p.m. UTC | #1 
Acked-by: Kai Ji <kai.ji@intel.com<mailto:kai.ji@intel.com>>
O'Donovan, Saoirse July 5, 2023, 3:49 p.m. UTC | #2 
Hi Ciara,

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday 5 July 2023 14:23
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; O'Donovan, Saoirse
> <saoirse.odonovan@intel.com>; Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
> 
> Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> included as legacy, to be disabled by default.
> 
> Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Tested-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
Akhil Goyal July 5, 2023, 6:22 p.m. UTC | #3 
> > Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
> >
> > Following the deprecation of insecure algorithms in QAT, SM4-ECB should be
> > included as legacy, to be disabled by default.
> >
> > Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > ---
> >  drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Tested-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>

Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
index bc71665a50..d25e1b2f3a 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
@@ -46,6 +46,9 @@  static struct rte_cryptodev_capabilities qat_sym_crypto_legacy_caps_gen3[] = {
 	QAT_SYM_PLAIN_AUTH_CAP(SHA3_224,
 		CAP_SET(block_size, 144),
 		CAP_RNG(digest_size, 28, 28, 0)),
+	QAT_SYM_CIPHER_CAP(SM4_ECB,
+		CAP_SET(block_size, 16),
+		CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))
 };
 
 static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
@@ -147,9 +150,6 @@  static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = {
 		CAP_RNG(key_size, 32, 32, 0),
 		CAP_RNG(digest_size, 16, 16, 0),
 		CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)),
-	QAT_SYM_CIPHER_CAP(SM4_ECB,
-		CAP_SET(block_size, 16),
-		CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),
 	QAT_SYM_CIPHER_CAP(SM4_CBC,
 		CAP_SET(block_size, 16),
 		CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),