From patchwork Wed Jul 5 13:23:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 129298 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C068742DD8; Wed, 5 Jul 2023 15:24:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B119E406B5; Wed, 5 Jul 2023 15:24:09 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 697E04021F for ; Wed, 5 Jul 2023 15:24:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688563448; x=1720099448; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9f4WHBYNhyQT6mEAaRBfLkybZr5lXUypryoLLuct+pY=; b=XmT0vhkjrmgJ9V07usEYf/27w2seN6bytP7UMk5C3Azn5UMkxwPAjmcl kPMnFL27foWGOB8etOH3b3Sspl6n9s+FDBW8gCrci7ST+ZEno9nmBlYS8 OQdGEwGf5t8lnkVjSmeZnElBCbWPjDuvG0Ai69DoB7d2Hmex8Sv2F7BMW tPX+09bmCUayMo5TI/7zSqVd40Jjpy2PgqbUVDtE+rHdMpK/nBE9rmOgY 0YX6iPTCfNYAeAnmGU+TV+zDpiKo284EAU8WAXDzNUeDrJa09uXTWftNS AeVNnXg82yP+63rmSyBN3jLp3ZRbnvG1b7RqvGRofx/Njzq2d6GSZ3Ra4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="348127488" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="348127488" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 06:24:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="832544324" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="832544324" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.80]) by fmsmga002.fm.intel.com with ESMTP; 05 Jul 2023 06:24:05 -0700 From: Ciara Power To: dev@dpdk.org Cc: kai.ji@intel.com, saoirse.odonovan@intel.com, Ciara Power Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability Date: Wed, 5 Jul 2023 13:23:11 +0000 Message-Id: <20230705132311.1146176-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Following the deprecation of insecure algorithms in QAT, SM4-ECB should be included as legacy, to be disabled by default. Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms") Signed-off-by: Ciara Power Acked-by: Kai Ji > Tested-by: Saoirse O'Donovan --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c index bc71665a50..d25e1b2f3a 100644 --- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c +++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c @@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_legacy_caps_gen3[] = { QAT_SYM_PLAIN_AUTH_CAP(SHA3_224, CAP_SET(block_size, 144), CAP_RNG(digest_size, 28, 28, 0)), + QAT_SYM_CIPHER_CAP(SM4_ECB, + CAP_SET(block_size, 16), + CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)) }; static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = { @@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = { CAP_RNG(key_size, 32, 32, 0), CAP_RNG(digest_size, 16, 16, 0), CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0)), - QAT_SYM_CIPHER_CAP(SM4_ECB, - CAP_SET(block_size, 16), - CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)), QAT_SYM_CIPHER_CAP(SM4_CBC, CAP_SET(block_size, 16), CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0)),