[2/4] app/test: support test last-idx when no DMA completed

Message ID 20220527034055.33271-3-fengchengwen@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series bugfix and feature for Hisilicon DMA PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

fengchengwen May 27, 2022, 3:40 a.m. UTC
  If no DMA request is completed, the ring_idx of the last completed
operation need returned by last_idx parameter. This patch adds
testcase for it.

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/test/test_dmadev.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
  

Comments

Kevin Laatz May 30, 2022, 11:40 a.m. UTC | #1
Tested with IOAT and IDXD, both pass unit tests.

Tested-by: Kevin Laatz <kevin.laatz@intel.com>

On 27/05/2022 04:40, Chengwen Feng wrote:
> If no DMA request is completed, the ring_idx of the last completed
> operation need returned by last_idx parameter. This patch adds
> testcase for it.
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>   app/test/test_dmadev.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
> index 2b097e0f47..a7651a486f 100644
> --- a/app/test/test_dmadev.c
> +++ b/app/test/test_dmadev.c
> @@ -177,6 +177,7 @@ do_multi_copies(int16_t dev_id, uint16_t vchan,
>   static int
>   test_enqueue_copies(int16_t dev_id, uint16_t vchan)
>   {
> +	enum rte_dma_status_code status;
>   	unsigned int i;
>   	uint16_t id;
>   
> @@ -215,6 +216,20 @@ test_enqueue_copies(int16_t dev_id, uint16_t vchan)
>   			ERR_RETURN("Error:incorrect job id received, %u [expected %u]\n",
>   					id, id_count);
>   
> +		/* check for completed and id when no job done */
> +		if (rte_dma_completed(dev_id, vchan, 1, &id, NULL) != 0)
> +			ERR_RETURN("Error with rte_dma_completed when no job done\n");
> +		if (id != id_count)
> +			ERR_RETURN("Error:incorrect job id received when no job done, %u [expected %u]\n",
> +					id, id_count);
> +
> +		/* check for completed_status and id when no job done */
> +		if (rte_dma_completed_status(dev_id, vchan, 1, &id, &status) != 0)
> +			ERR_RETURN("Error with rte_dma_completed_status when no job done\n");
> +		if (id != id_count)
> +			ERR_RETURN("Error:incorrect job id received when no job done, %u [expected %u]\n",
> +					id, id_count);
> +
>   		rte_pktmbuf_free(src);
>   		rte_pktmbuf_free(dst);
>
  

Patch

diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index 2b097e0f47..a7651a486f 100644
--- a/app/test/test_dmadev.c
+++ b/app/test/test_dmadev.c
@@ -177,6 +177,7 @@  do_multi_copies(int16_t dev_id, uint16_t vchan,
 static int
 test_enqueue_copies(int16_t dev_id, uint16_t vchan)
 {
+	enum rte_dma_status_code status;
 	unsigned int i;
 	uint16_t id;
 
@@ -215,6 +216,20 @@  test_enqueue_copies(int16_t dev_id, uint16_t vchan)
 			ERR_RETURN("Error:incorrect job id received, %u [expected %u]\n",
 					id, id_count);
 
+		/* check for completed and id when no job done */
+		if (rte_dma_completed(dev_id, vchan, 1, &id, NULL) != 0)
+			ERR_RETURN("Error with rte_dma_completed when no job done\n");
+		if (id != id_count)
+			ERR_RETURN("Error:incorrect job id received when no job done, %u [expected %u]\n",
+					id, id_count);
+
+		/* check for completed_status and id when no job done */
+		if (rte_dma_completed_status(dev_id, vchan, 1, &id, &status) != 0)
+			ERR_RETURN("Error with rte_dma_completed_status when no job done\n");
+		if (id != id_count)
+			ERR_RETURN("Error:incorrect job id received when no job done, %u [expected %u]\n",
+					id, id_count);
+
 		rte_pktmbuf_free(src);
 		rte_pktmbuf_free(dst);