diff mbox

[dpdk-dev,v2] net/failsafe: fix strerror call in sub-eal

Message ID 20180201105930.12686-1-gaetan.rivet@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gaëtan Rivet Feb. 1, 2018, 10:59 a.m. UTC 
  Ownership API returns a negative value, strerror expects a valid errno
value, thus positive.

Coverity issue: 260401
Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves")

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---

v2: Fix coverity reference syntax in commit log.

 drivers/net/failsafe/failsafe_eal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Feb. 5, 2018, 3:05 p.m. UTC | #1 
On 2/1/2018 10:59 AM, Gaetan Rivet wrote:
> Ownership API returns a negative value, strerror expects a valid errno
> value, thus positive.
> 
> Coverity issue: 260401
> Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves")
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c
index 8946bf6fe..c3d673125 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -79,9 +79,9 @@  fs_bus_init(struct rte_eth_dev *dev)
 			      " %d named %s", i, da->name);
 		}
 		ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner);
-		if (ret) {
+		if (ret < 0) {
 			INFO("sub_device %d owner set failed (%s),"
-			     " will try again later", i, strerror(ret));
+			     " will try again later", i, strerror(-ret));
 			continue;
 		} else if (strncmp(rte_eth_devices[pid].device->name, da->name,
 			   strlen(da->name)) != 0) {