From patchwork Thu Feb 1 10:59:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABtan_Rivet?= X-Patchwork-Id: 34820 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 669A7A49A; Thu, 1 Feb 2018 12:00:04 +0100 (CET) Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 11BEBA48F for ; Thu, 1 Feb 2018 12:00:03 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id h9so5439488wre.12 for ; Thu, 01 Feb 2018 03:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0KGsT9m1Yruz8ZzaxHfN3et68SIHEdxJCZOjNe9oq40=; b=SJn2Bym58G9JPexw193jJK780w/hrvV5/ZeSXyC1v0UIdDRbm/F6iVtUvh6FNA8JWt vrkFRUsnva1ZymMULznmGNBrJ5F/SMhK259aybpInkEJruf8CZC8hKI0elmb7nHmlZjC ZlmlOUOAgSIFNk/tOJdNSmQsGXZOW10did/e3e70wz3MMjbp5sc7UZUVar/7yUJQLmif bdnhDXjnjH1nSpD+4Je99VfXsPt1P6DfwjRWhbXjl8/eXq5tvwoz8JTFeUm3zY/L3i8I 5ZxppkyorlNapRlqtFi0EnKn8NDviXET+ZZ82QuGTl8vFfPbLqTgqbtvPmRGs3VZ3ZNJ nKPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0KGsT9m1Yruz8ZzaxHfN3et68SIHEdxJCZOjNe9oq40=; b=GBr0DXm7ld3LP2mtYx8wEUQfjbOVTWwZULB+8ZJ83m2FyhRU0DkiyBX/CP0kDvTU7w 4461yACiyDsV5iplxseJr6MaDIWgnEy7LjSg5gsmLhYmeW03uBUkf9S0mOdd6/l2hG33 WpbbMLG3UwBfzZQKJuQzCngGmCUISlpqTQs9n3SJnO7dEtu07xXws2kjXtJZrt3vjV27 96maPEEjYkVSir44LEamucoq5U/w0Fc1CZFD6FPTD4hftHDE3X6RvVMGqkMF2MiIn9H6 ZxhDeHSDMQC9JOX3jsN+fiwNL/sTPxhfz6zOju+scV9E9hDhO9kBM35DL6oaxeod2pZx sxvQ== X-Gm-Message-State: AKwxyteuNknyHgmVeL9IXRnOZCtYXZB9qcCGV0nKAraAHUYWsOLAs0Q3 14WAzwiVycMZBoNruEj8PwelpKKf X-Google-Smtp-Source: AH8x2260XnMniGF9O4rVR6Cv7+lRRparSsMlGA20ffXXqwHw8d9CnP2RY/ZXaQBbQlKdVEFxPDZiTg== X-Received: by 10.223.134.236 with SMTP id 41mr28442961wry.87.1517482802130; Thu, 01 Feb 2018 03:00:02 -0800 (PST) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c24sm20652892wra.79.2018.02.01.03.00.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2018 03:00:01 -0800 (PST) From: Gaetan Rivet To: dev@dpdk.org Cc: Matan Azrad , Gaetan Rivet Date: Thu, 1 Feb 2018 11:59:30 +0100 Message-Id: <20180201105930.12686-1-gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180201101801.10295-1-gaetan.rivet@6wind.com> References: <20180201101801.10295-1-gaetan.rivet@6wind.com> Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix strerror call in sub-eal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ownership API returns a negative value, strerror expects a valid errno value, thus positive. Coverity issue: 260401 Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Signed-off-by: Gaetan Rivet --- v2: Fix coverity reference syntax in commit log. drivers/net/failsafe/failsafe_eal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index 8946bf6fe..c3d673125 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -79,9 +79,9 @@ fs_bus_init(struct rte_eth_dev *dev) " %d named %s", i, da->name); } ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner); - if (ret) { + if (ret < 0) { INFO("sub_device %d owner set failed (%s)," - " will try again later", i, strerror(ret)); + " will try again later", i, strerror(-ret)); continue; } else if (strncmp(rte_eth_devices[pid].device->name, da->name, strlen(da->name)) != 0) {