| Message ID | cover.1665170499.git.sthotton@marvell.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2C0EA0542; Fri, 7 Oct 2022 21:30:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3399400D5; Fri, 7 Oct 2022 21:30:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8291E40042 for <dev@dpdk.org>; Fri, 7 Oct 2022 21:30:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297FLX0n006967; Fri, 7 Oct 2022 12:30:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=HAP9QryXMQMlbDFVXDUQLNjFEHHxM1TvsB+GzHXJW/Q=; b=BJW3QABMhaWpaFS0xlL793NRaN5nhW1gL21/TOa+vizSCMVSck8mKQCsHA5oNHLu+tfe hzc3lWNFrBZGhFkNCd/N/JxltlOOIuZqg6XrxCNjWuAFNWtgURM8wSKwF9PI6p9EK4ug 3Y7OI4admoahtOxT4wMmONZgYOVLkMtn9n2RiE6l8RkkeErlXcqdjRPColRZ1ywXITIM cRn9R/mevo+VVhYvwkmFoLzCgkfAzus/+xmNV/p/foQKep6RjgexFigzsMKyCvkOTGEQ JWUWZlRGYL8VU4eIkqjg63SBHSyhS/LCb3eH+8QafkIwlZtOFjGtSaglegzTnh5iUATV OQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3k2ppes0gf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 07 Oct 2022 12:30:42 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 7 Oct 2022 12:30:41 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 7 Oct 2022 12:30:41 -0700 Received: from localhost.localdomain (unknown [10.28.34.29]) by maili.marvell.com (Postfix) with ESMTP id 7B9E93F703F; Fri, 7 Oct 2022 12:30:36 -0700 (PDT) From: Shijith Thotton <sthotton@marvell.com> To: <dev@dpdk.org> CC: Shijith Thotton <sthotton@marvell.com>, <Honnappa.Nagarahalli@arm.com>, <bruce.richardson@intel.com>, <jerinj@marvell.com>, <mb@smartsharesystems.com>, <olivier.matz@6wind.com>, <stephen@networkplumber.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <pbhagavatula@marvell.com>, <david.marchand@redhat.com> Subject: [PATCH v4 0/7] mbuf dynamic field expansion Date: Sat, 8 Oct 2022 01:00:22 +0530 Message-ID: <cover.1665170499.git.sthotton@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <cover.1663767715.git.sthotton@marvell.com> References: <cover.1663767715.git.sthotton@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: XcEimqW2kjHOUHExkQN-tPZ1sj0gcKMZ X-Proofpoint-ORIG-GUID: XcEimqW2kjHOUHExkQN-tPZ1sj0gcKMZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
mbuf dynamic field expansion
|
|
Message
Shijith Thotton
Oct. 7, 2022, 7:30 p.m. UTC
This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was deemed unsafe as some components could still use the PA field without checking IOVA mode and there are drivers which need PA to work. One suggestion was to make the IOVA mode check at compile time so that drivers which need PA can be disabled during build. This series adds this new meson build options. Fourth patch adds mbuf PA field to dynamic field on such builds. Last two patches enable Marvell cnxk PMDs and software PMDs in IOVA as PA disabled build as they work without PA field. 1. https://inbox.dpdk.org/dev/57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605763.git.sthotton@marvell.com/. v4: * Restructured changes to multiple patches. * Moved to #if scheme instead of union. * Updated release notes. v3: * Cleared use of buf_iova from cnxk PMD. v2: * Used RTE_IOVA_AS_VA instread of rte_is_iova_as_va_build(). * Moved mbuf next pointer to first cacheline if RTE_IOVA_AS_VA = 1. Shijith Thotton (7): mbuf: add API to get and set mbuf physical address test/dma: use API to get mbuf data physical address build: add meson option to configure IOVA mode as PA mbuf: add second dynamic field member lib: move mbuf next pointer to first cache line drivers: mark cnxk PMDs work with IOVA as PA disabled drivers: mark software PMDs work with IOVA as PA disabled app/test-bbdev/test_bbdev_perf.c | 2 +- app/test-crypto-perf/cperf_test_common.c | 5 +-- app/test/test_bpf.c | 2 +- app/test/test_dmadev.c | 33 ++++++-------- app/test/test_mbuf.c | 12 +++--- app/test/test_pcapng.c | 2 +- config/arm/meson.build | 8 +++- config/meson.build | 1 + doc/guides/platform/cnxk.rst | 3 +- doc/guides/rel_notes/release_22_11.rst | 3 ++ drivers/common/cnxk/meson.build | 1 + drivers/crypto/armv8/meson.build | 1 + drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 2 +- drivers/crypto/cnxk/meson.build | 2 + drivers/crypto/ipsec_mb/meson.build | 1 + drivers/crypto/null/meson.build | 1 + drivers/crypto/openssl/meson.build | 1 + drivers/dma/cnxk/meson.build | 1 + drivers/dma/skeleton/meson.build | 1 + drivers/event/cnxk/meson.build | 1 + drivers/event/dsw/meson.build | 1 + drivers/event/opdl/meson.build | 1 + drivers/event/skeleton/meson.build | 1 + drivers/event/sw/meson.build | 1 + drivers/mempool/bucket/meson.build | 1 + drivers/mempool/cnxk/meson.build | 1 + drivers/mempool/ring/meson.build | 1 + drivers/mempool/stack/meson.build | 1 + drivers/meson.build | 6 +++ drivers/net/af_packet/meson.build | 1 + drivers/net/af_xdp/meson.build | 2 + drivers/net/bonding/meson.build | 1 + drivers/net/cnxk/cn10k_ethdev.c | 4 +- drivers/net/cnxk/cn10k_tx.h | 55 +++++++----------------- drivers/net/cnxk/cn9k_ethdev.c | 4 +- drivers/net/cnxk/cn9k_tx.h | 55 +++++++----------------- drivers/net/cnxk/cnxk_ethdev.h | 1 - drivers/net/cnxk/meson.build | 1 + drivers/net/failsafe/meson.build | 1 + drivers/net/hns3/meson.build | 6 +++ drivers/net/memif/meson.build | 1 + drivers/net/null/meson.build | 1 + drivers/net/pcap/meson.build | 1 + drivers/net/ring/meson.build | 1 + drivers/net/tap/meson.build | 1 + drivers/raw/cnxk_bphy/meson.build | 1 + drivers/raw/cnxk_gpio/meson.build | 1 + drivers/raw/skeleton/meson.build | 1 + lib/eal/linux/eal.c | 6 +++ lib/kni/rte_kni.c | 3 +- lib/mbuf/rte_mbuf.c | 12 +++--- lib/mbuf/rte_mbuf.h | 37 +++++++++++++--- lib/mbuf/rte_mbuf_core.h | 26 +++++++++-- lib/mbuf/rte_mbuf_dyn.c | 3 ++ lib/meson.build | 3 ++ lib/pipeline/rte_table_action.c | 2 +- lib/vhost/vhost.h | 2 +- lib/vhost/vhost_crypto.c | 25 ++++++----- meson_options.txt | 2 + 60 files changed, 210 insertions(+), 151 deletions(-)
Comments
Hi Shijith, On Sat, Oct 08, 2022 at 01:00:22AM +0530, Shijith Thotton wrote: > This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. > Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was > deemed unsafe as some components could still use the PA field without checking IOVA mode and there > are drivers which need PA to work. One suggestion was to make the IOVA mode check at compile time so > that drivers which need PA can be disabled during build. This series adds this new meson build > options. Fourth patch adds mbuf PA field to dynamic field on such builds. Last two patches enable > Marvell cnxk PMDs and software PMDs in IOVA as PA disabled build as they work without PA field. > > 1. https://inbox.dpdk.org/dev/57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605763.git.sthotton@marvell.com/. > > v4: > * Restructured changes to multiple patches. > * Moved to #if scheme instead of union. > * Updated release notes. > > v3: > * Cleared use of buf_iova from cnxk PMD. > > v2: > * Used RTE_IOVA_AS_VA instread of rte_is_iova_as_va_build(). > * Moved mbuf next pointer to first cacheline if RTE_IOVA_AS_VA = 1. > > Shijith Thotton (7): > mbuf: add API to get and set mbuf physical address > test/dma: use API to get mbuf data physical address > build: add meson option to configure IOVA mode as PA > mbuf: add second dynamic field member > lib: move mbuf next pointer to first cache line > drivers: mark cnxk PMDs work with IOVA as PA disabled > drivers: mark software PMDs work with IOVA as PA disabled > > app/test-bbdev/test_bbdev_perf.c | 2 +- > app/test-crypto-perf/cperf_test_common.c | 5 +-- > app/test/test_bpf.c | 2 +- > app/test/test_dmadev.c | 33 ++++++-------- > app/test/test_mbuf.c | 12 +++--- > app/test/test_pcapng.c | 2 +- > config/arm/meson.build | 8 +++- > config/meson.build | 1 + > doc/guides/platform/cnxk.rst | 3 +- > doc/guides/rel_notes/release_22_11.rst | 3 ++ > drivers/common/cnxk/meson.build | 1 + > drivers/crypto/armv8/meson.build | 1 + > drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +- > drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 2 +- > drivers/crypto/cnxk/meson.build | 2 + > drivers/crypto/ipsec_mb/meson.build | 1 + > drivers/crypto/null/meson.build | 1 + > drivers/crypto/openssl/meson.build | 1 + > drivers/dma/cnxk/meson.build | 1 + > drivers/dma/skeleton/meson.build | 1 + > drivers/event/cnxk/meson.build | 1 + > drivers/event/dsw/meson.build | 1 + > drivers/event/opdl/meson.build | 1 + > drivers/event/skeleton/meson.build | 1 + > drivers/event/sw/meson.build | 1 + > drivers/mempool/bucket/meson.build | 1 + > drivers/mempool/cnxk/meson.build | 1 + > drivers/mempool/ring/meson.build | 1 + > drivers/mempool/stack/meson.build | 1 + > drivers/meson.build | 6 +++ > drivers/net/af_packet/meson.build | 1 + > drivers/net/af_xdp/meson.build | 2 + > drivers/net/bonding/meson.build | 1 + > drivers/net/cnxk/cn10k_ethdev.c | 4 +- > drivers/net/cnxk/cn10k_tx.h | 55 +++++++----------------- > drivers/net/cnxk/cn9k_ethdev.c | 4 +- > drivers/net/cnxk/cn9k_tx.h | 55 +++++++----------------- > drivers/net/cnxk/cnxk_ethdev.h | 1 - > drivers/net/cnxk/meson.build | 1 + > drivers/net/failsafe/meson.build | 1 + > drivers/net/hns3/meson.build | 6 +++ > drivers/net/memif/meson.build | 1 + > drivers/net/null/meson.build | 1 + > drivers/net/pcap/meson.build | 1 + > drivers/net/ring/meson.build | 1 + > drivers/net/tap/meson.build | 1 + > drivers/raw/cnxk_bphy/meson.build | 1 + > drivers/raw/cnxk_gpio/meson.build | 1 + > drivers/raw/skeleton/meson.build | 1 + > lib/eal/linux/eal.c | 6 +++ > lib/kni/rte_kni.c | 3 +- > lib/mbuf/rte_mbuf.c | 12 +++--- > lib/mbuf/rte_mbuf.h | 37 +++++++++++++--- > lib/mbuf/rte_mbuf_core.h | 26 +++++++++-- > lib/mbuf/rte_mbuf_dyn.c | 3 ++ > lib/meson.build | 3 ++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/vhost.h | 2 +- > lib/vhost/vhost_crypto.c | 25 ++++++----- > meson_options.txt | 2 + > 60 files changed, 210 insertions(+), 151 deletions(-) > > -- > 2.25.1 > for the series: Acked-by: Olivier Matz <olivier.matz@6wind.com> There are few minor comments but I think it can go in rc1 anyway.