mbox series

[v7,0/5] dumpcap and pcapng fixes

Message ID 20231117163729.243188-1-stephen@networkplumber.org (mailing list archive)
Headers
Series dumpcap and pcapng fixes |

Message

Stephen Hemminger Nov. 17, 2023, 4:35 p.m. UTC 
  It fixes issues related to timestamping. The design choices are
to maximize performance in the primary process; and do
all the time adjustment in the secondary (dumpcap) since
the dumpcap needs to system calls anyway to write the result.

This patches set changes where the adjustment is calculated
into the pcapng portion that opens the output file.
All details of the format of timestamp are contained inside
pcapng (data hiding).

v7 - no change, rebase there were some apply failures by CI
v6 - make sure all steps compile
v5 - fix format of getpid in capture name
v4 - incorporate review feedback
v3 - don't use alloca() since can have VLA type issues

Stephen Hemminger (5):
  pdump: fix setting rte_errno on mp error
  dumpcap: allow multiple invocations
  pcapng: modify timestamp calculation
  pcapng: avoid using alloca()
  test: cleanups to pcapng test

 app/dumpcap/main.c      |  53 ++---
 app/test/meson.build    |   2 +-
 app/test/test_pcapng.c  | 417 +++++++++++++++++++++++++++-------------
 lib/graph/graph_pcap.c  |   2 +-
 lib/pcapng/rte_pcapng.c | 156 ++++++---------
 lib/pcapng/rte_pcapng.h |  19 +-
 lib/pdump/rte_pdump.c   |   9 +-
 7 files changed, 373 insertions(+), 285 deletions(-)

Comments

Thomas Monjalon Nov. 22, 2023, 10:42 p.m. UTC | #1 
> Stephen Hemminger (5):
>   pdump: fix setting rte_errno on mp error
>   dumpcap: allow multiple invocations
>   pcapng: modify timestamp calculation
>   pcapng: avoid using alloca()
>   test: cleanups to pcapng test

Applied with a note about the API change in release notes.